Re: [PATCHES] Plan for CSV handling of quotes, NULL

2004-04-14 Thread Bruce Momjian
Bruce Momjian wrote: > Bruce Momjian wrote: > > I talked to Andrew on IRC and we went over the open CSV issues. > > > > We talked about how we could do quoting for zipcode in TEXT fields and > > not quote true numeric values without hardcoding datatypes into the > &

Re: [PATCHES] Plan for CSV handling of quotes, NULL

2004-04-14 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Particularly, how do we identify a numeric and dates? > > We don't, and I'm not convinced that we should. The entire concept is > suspect in a type-agnostic system. In particular, I've re

Re: [PATCHES] Plan for CSV handling of quotes, NULL

2004-04-14 Thread Bruce Momjian
Andrew Dunstan wrote: > Bruce Momjian said: > > So, for open CSV items we have: > > > > o add oid dump/reload > > > There seems to be agreement on this at least. All you need to do is remove > these lines - AFAICS the OID code should be ab

Re: [PATCHES] Plan for CSV handling of quotes, NULL

2004-04-14 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > I found parse_coerce.c::TypeCategory(), which contains information about > > which data type oids are in which grouping, e.g. DATETIME, STRING, > > NUMERIC, etc. It seems that function, if called with &g

Re: [PATCHES] Plan for CSV handling of quotes, NULL

2004-04-14 Thread Bruce Momjian
Andrew Dunstan wrote: > Bruce Momjian said: > > Tom Lane wrote: > >> TypeCategory is a crock that should have been done away with long ago. > >> We need to be working to eliminate it, not expand our dependency on > >> it. > > > > Ah, so do we have an

Re: [PATCHES] Plan for CSV handling of quotes, NULL

2004-04-15 Thread Bruce Momjian
Andrew Dunstan wrote: > Bruce Momjian said: > > Andrew Dunstan wrote: > >> > >> copy mytable to 'mydata.csv' csv force zipcode; > >> > >> seems OK to me. I'm all in favor of low-tecH solutions where > >> appropriate. ;-) >

Re: [PATCHES] Plan for CSV handling of quotes, NULL

2004-04-15 Thread Bruce Momjian
Andrew Dunstan wrote: > Bruce Momjian wrote: > > >What about NULL input? Is my warning and promotion to zero-length > >string for NOT NULL columns OK? > > > > > > > > > I know I originally floated this idea or one very like it, but I have >

Re: [PATCHES] Plan for CSV handling of quotes, NULL

2004-04-15 Thread Bruce Momjian
Richard Huxton wrote: > On Thursday 15 April 2004 15:58, Bruce Momjian wrote: > > > > OK, so we need a list of columns for output with quotes, and a list of > > columns where NULL should be changed to zero-length strings. > > > > How about if we use FORCE to force

Re: [PATCHES] Plan for CSV handling of quotes, NULL

2004-04-15 Thread Bruce Momjian
Bruce Momjian wrote: > Richard Huxton wrote: > > On Thursday 15 April 2004 15:58, Bruce Momjian wrote: > > > > > > OK, so we need a list of columns for output with quotes, and a list of > > > columns where NULL should be changed to zero-length strings. >

[PATCHES] Fix for SIGTERM

2004-04-16 Thread Bruce Momjian
This patch fixes a server crash for an invalid database name. I wasn't dealing with Warn_restart_ready properly in my SIGTERM safety patch. Applied. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life

Re: [PATCHES] Basic subtransaction facility

2004-04-17 Thread Bruce Momjian
itate the living f*ck out of me." (JWZ) [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 3: if posting/reading through Usenet, please send an appropriate > subscribe-nomail command to [EMAIL PROTECTED] so that

Re: [PATCHES] Basic subtransaction facility

2004-04-18 Thread Bruce Momjian
Heikki Linnakangas > > could see how it affects his two phase commit patch. > > I have not reviewed it yet, but would like to do so before it goes in. OK, thanks. Yea, I think we should get it in rather than waiting for Alvaro to finish the whole project. This way, we have somethi

Re: [PATCHES] Basic subtransaction facility

2004-04-18 Thread Bruce Momjian
gt; ---(end of broadcast)--- > TIP 3: if posting/reading through Usenet, please send an appropriate > subscribe-nomail command to [EMAIL PROTECTED] so that your > message can get through to the mailing list cleanly -- Bruce Momjian

Re: [PATCHES] Basic subtransaction facility

2004-04-19 Thread Bruce Momjian
itate the living f*ck out of me." (JWZ) [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 3: if posting/reading through Usenet, please send an appropriate > subscribe-nomail command to [EMAIL PROTECTED] so that

[PATCHES] CSV patch applied

2004-04-19 Thread Bruce Momjian
specified columns LITERAL - prevent NULL checks for specific columns If folks have better ideas for naming of those keywords, I am all ears! -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive

Re: [PATCHES] win32 fixes

2004-04-19 Thread Bruce Momjian
p://www.memetrics.com/emailpolicy.html";>http://www.memetrics.com/em > ailpolicy.html > > [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 5: Have you checked our extensive FAQ? > >http://www.post

Re: [PATCHES] minor readme patch for pg_autovacuum

2004-04-19 Thread Bruce Momjian
-v if not specified) > -s 300 (5 minutes) > -S 2 > > --- 129,135 > -v 1000 > -V 2 > -a 500 (half of -v if not specified) > ! -A 1 (half of -V if not specified) > -s 300 (5 minutes) > -S 2 > > > ---(end of broadcas

Re: [PATCHES] pg_restore ignore error patch

2004-04-19 Thread Bruce Momjian
store to continue on errors, particularly because only pg_restore can read binary dumps. Do folks get pg_restor failures frequently? I sure hope not. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your lif

Re: [PATCHES] pg_restore ignore error patch v2

2004-04-19 Thread Bruce Momjian
archives? > >http://archives.postgresql.org -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Squar

Re: [PATCHES] pg_restore ignore error patch

2004-04-19 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > I looked over the patch and it seems to continue on pg_restore errors by > > default. That isn't good. By default, any error should make it exit > > loudly. > > I'm not sure of that. pg

Re: [PATCHES] pg_restore ignore error patch v2

2004-04-19 Thread Bruce Momjian
CTED] Content-Description: [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 6: Have you searched our list archives? > >http://archives.postgresql.org -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PRO

Re: [PATCHES] pg_restore ignore error patch

2004-04-20 Thread Bruce Momjian
o allow user change the 'ignore' > behavior, and make pg_restore exit loudly if it is desired. > > Maybe it should be proposed just for backwards compatibility? Let's see if anyone asks for it. Unless they do, we will just enable it by default. As long as we exit with a

Re: [PATCHES] NetBSD 2.0 / native threads

2004-04-20 Thread Bruce Momjian
t, skipping... ] -- End of PGP section, PGP failed! -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvani

Re: [PATCHES] CSV patch applied

2004-04-20 Thread Bruce Momjian
. They same single keyword just seemed confusing. This is why the two-keyword idea sounds good to me --- we use the word QUOTE (already a keyword), and then say FORCE for output, and NULL for input: FORCE QUOTE QUOTE NULL -- Bruce Momjian| http://candle

[PATCHES] Change of CSV keywords

2004-04-20 Thread Bruce Momjian
I just changed COPY CSV keywords to be: FORCE QUOTE to force quotes on output FORCE NOT NULL to quote null input values -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive

[PATCHES] CSV keyword change

2004-04-20 Thread Bruce Momjian
I just changed the COPY CSV keywords: FORCE QUOTE to force quotes FORCE NOT NULL to quote null input values Patch attached. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive

Re: [PATCHES] PSQLRC environment variable.

2004-04-20 Thread Bruce Momjian
Bruce Momjian wrote: > Tom Lane wrote: > > Bruce Momjian <[EMAIL PROTECTED]> writes: > > > I just checked a few apps and I see they usually allow a global config > > > file to be specified. How about SYSPSQLRC that adds a system-wide psql > > > config

Re: [PATCHES] PSQLRC environment variable.

2004-04-21 Thread Bruce Momjian
Applied. --- Bruce Momjian wrote: > Bruce Momjian wrote: > > Tom Lane wrote: > > > Bruce Momjian <[EMAIL PROTECTED]> writes: > > > > I just checked a few apps and I see they usually allo

Re: [PATCHES] [JDBC] EXECUTE command tag returns actual command

2004-04-21 Thread Bruce Momjian
st)--- > TIP 2: you can get off all lists at once with the unregister command > (send "unregister YourEmailAddressHere" to [EMAIL PROTECTED]) -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610)

Re: [PATCHES] Fix for socket error msgs on win32

2004-04-21 Thread Bruce Momjian
<> Content-Description: win32_socketerror.patch [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 5: Have you checked our extensive FAQ? > >http://www.postgresql.org/docs/faqs/FAQ.html -- Bruce Momjian

Re: [PATCHES] [JDBC] EXECUTE command tag returns actual command

2004-04-21 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Your patch has been added to the PostgreSQL unapplied patches list at: > > > Kris Jurka wrote: > >> This patch makes the EXECUTE command's completion tag return the > >> completion tag

Re: [PATCHES] contrib/dbmirror

2004-04-21 Thread Bruce Momjian
AFTN: CYYZXNSX SITA: YYZNSCR > Waterloo, Ontario ARINC: YKFNSCR Content-Description: [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 5: Have you checked our extensive FAQ? > >

Re: [PATCHES] patches in the pipe?

2004-04-22 Thread Bruce Momjian
t I do, but I can only "argue", not "refute" or "address" > issues. Whether it is refuted or addressed is in the head of the decider. I seem to be losing a lot of your patches, so I must be doing something wrong. -- Bruce Momjian| http://ca

Re: [PATCHES] patches in the pipe?

2004-04-22 Thread Bruce Momjian
it isn't clear that the problem is refuted or addressed, I assume the patch shouldn't be applied. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can

Re: [PATCHES] PSQLRC environment variable.

2004-04-22 Thread Bruce Momjian
Peter Eisentraut wrote: > Bruce Momjian wrote: > > Applied. > > Replace rename it to psqlrc instead of psql.rc. Yea, I debated psql.rc and psqlrc, but chose psql.rc. If you like psqlrc better, that's fine with me. Patch attached and applied. -- Bruce Momjian

Re: [PATCHES] patch in pipe?

2004-04-22 Thread Bruce Momjian
istrador de Sistemas > UFGNet - Universidade Federal de Goi?s > > ---(end of broadcast)--- > TIP 8: explain analyze is your friend > -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] |

Re: [PATCHES] patches in the pipe?

2004-04-23 Thread Bruce Momjian
yet:-( > I bounced them *again* but directly to you. Aded both to the queue. > > I seem to be losing a lot of your patches, so I must be doing something > > wrong. > > It seems I don't know how to post them maybe. We will get it right soon. :-) -- Bruce Momjian

[PATCHES] Refactoring of running other programs

2004-05-11 Thread Bruce Momjian
tches. Patch attached and applied. I am not doing the standard application delay because I want to continue on to relocatable installs. I will make any suggested adjustments. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001

Re: [PATCHES] Patch for Makefile.shlib

2004-05-12 Thread Bruce Momjian
--- > TIP 8: explain analyze is your friend -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backu

Re: [PATCHES] mingw configure failure detection

2004-05-12 Thread Bruce Momjian
to contact the mingw maintainers about this problem. Maybe they have a > better fix available? > > Btw. test -e is not portable. And please use AC_MSG_WARN instead of > "echo". > > > ---(end of broadcast)--------

Re: [PATCHES] mingw configure failure detection

2004-05-12 Thread Bruce Momjian
exists ... I just installed the configure symlink test code that throws a warning if the symlinks don't work, so it is even easier to test now. Just run configure until it fails --- nothing to compile. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED]

Re: [PATCHES] pgkill for windows

2004-05-11 Thread Bruce Momjian
irectory. > > > > > > > > > > In effect you need this on Windows anywhere that in Unix you would want > to use kill (1) on a postgres process. Is this something that should be part of the Win32 pg_ctl C code instead? -- Bruce Momjian

[PATCHES] Reorganize backend handling of executable names

2004-05-13 Thread Bruce Momjian
This applied patch reorganizes the backend code to more cleanly manage executable names and backend startup. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road

Re: [PATCHES] mingw configure failure detection

2004-05-13 Thread Bruce Momjian
e form > linkname:targetname - we'd have to have extra code to split them up. > Something like: > > for ac_file in : $CONFIG_LINKS; do test "x$ac_file" = x: && continue > linktry=`echo "$ac_file" | sed 's,:.*,,'` > test .. >

Re: [PATCHES] [HACKERS] threads stuff/UnixWare

2004-05-13 Thread Bruce Momjian
ll Unixware builds if threading is requested. This is required because once you link with a library that uses threads, all references to that library have to use thread flags. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + I

Re: [PATCHES] [HACKERS] threads stuff/UnixWare

2004-05-13 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > *** src/Makefile.global.in 11 May 2004 21:57:14 - 1.182 > > --- src/Makefile.global.in 13 May 2004 23:03:12 - > > *** > > *** 177,182 > > --- 177,188 >

Re: [PATCHES] [HACKERS] threads stuff/UnixWare

2004-05-13 Thread Bruce Momjian
n that compile line. Would you look at Makefile.global at where I add the thread flags to see why isn't working. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road +

Re: [PATCHES] [HACKERS] threads stuff/UnixWare

2004-05-13 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > So we just add the thing in the template file? Yea, I can do that. I > > did it there because Win32 already had something for libs. Does the > > template file get included in Makefile.global? I di

Re: [PATCHES] [HACKERS] threads stuff/UnixWare

2004-05-13 Thread Bruce Momjian
Good. I changed my commit to use your version. --- Larry Rosenman wrote: -- Start of PGP signed section. > > > --On Thursday, May 13, 2004 20:03:24 -0400 Bruce Momjian > <[EMAIL PROTECTED]> wrote: >

Re: [PATCHES] mingw configure failure detection

2004-05-10 Thread Bruce Momjian
previous speculation, he did indicate that the problem is > intermittent, not constant). I think we satisfy the specifications mentioned by the person replying. Perhaps someone needs to follow up to state we are following the specifications. -- Bruce Momjian|

Re: [PATCHES] src/template/unixware syntax error

2004-05-14 Thread Bruce Momjian
E-Mail: [EMAIL PROTECTED] > US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749 Content-Description: Patch for UnixWare [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 6: Have you searched our list archives? &

Re: [PATCHES] pg_ctl patch to integrate apache's rotatelogs

2004-05-14 Thread Bruce Momjian
argument. I think the big reason we have avoided rotatelogs integration is the desire not to favor a particular log rotate solution. However, we have syslog hooks, so maybe rotatelogs hooks are OK. Comments? -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECT

Re: [PATCHES] [BUGS] BUG #1148: server restarts depending on stats options

2004-05-07 Thread Bruce Momjian
Peter Eisentraut wrote: > Bruce Momjian wrote: > > I have applied the attached patch to fix this problem. Sample output > > is: > > > > test=> set log_statement_stats = true; > > SET > > test=> set log_parser_stats = true;

Re: [PATCHES] NEXT VALUE FOR...

2004-05-07 Thread Bruce Momjian
d it'll > become kind of a moot point ;-) > > regards, tom lane [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 9: the planner will ignore your desire to choose an index scan if your > joining column's

Re: [PATCHES] [BUGS] BUG #1148: server restarts depending on stats options

2004-05-07 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Thanks: > > > errmsg("cannot enable parameter when \"log_statement_stats\" is true."))); > > errmsg("cannot enable \"log_statement_stats\" whe

Re: [PATCHES] mingw configure failure detection

2004-05-08 Thread Bruce Momjian
. --- Andrew Dunstan wrote: > > > Bruce Momjian wrote: > > >Andrew Dunstan wrote: > > > > > >>>It's different because we know why we need that one: we understand the > >>>cause of the

Re: [PATCHES] pg_ctl patch to integrate apache's rotatelogs

2004-05-14 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Ouch. How long has that documentation been wrong? We have pointed > > folks to that section of the docs tons of times, and no one mentioned > > that "logrotate" is really "rotatelogs",

Re: [PATCHES] Dollar Quoting doc patch--resend.

2004-05-06 Thread Bruce Momjian
Tom Lane wrote: > Neil Conway <[EMAIL PROTECTED]> writes: > > On 6-May-04, at 12:41 AM, Bruce Momjian wrote: > >> OK. I am just afraid if we show 4 functions, and three use $$, and one > >> doesn't use single-quotes inside, so we quote with single-q

Re: [PATCHES] thread

2004-05-06 Thread Bruce Momjian
Sorry I sent this email to the lists by accident. I meant to send it just to Magnus. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup

[PATCHES] thread

2004-05-06 Thread Bruce Momjian
Here is the email I have. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 >From [EM

Re: [PATCHES] [BUGS] BUG #1134: ALTER USER ... RENAME breaks md5 passwords

2004-05-06 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > The attached patch clears the password field on rename: > > I think you should clear the password field *only* if it's > MD5-encrypted. Patch attached and applied. -- Bruce Momjian

Re: [PATCHES] [BUGS] BUG #1134: ALTER USER ... RENAME breaks md5 passwords

2004-05-06 Thread Bruce Momjian
Bruce Momjian wrote: > Tom Lane wrote: > > Bruce Momjian <[EMAIL PROTECTED]> writes: > > > The attached patch clears the password field on rename: > > > > I think you should clear the password field *only* if it's > > MD5-encrypted. > > Pat

Re: [PATCHES] win32: whitespace in dir names, shmem bug

2004-05-06 Thread Bruce Momjian
://www.memetrics.com/emailpolicy.html";>http://www.memetrics.com/em > ailpolicy.html > > [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 7: don't forget to increase your free space map settings --

Re: [PATCHES] Alter Table phase 1 -- Please apply to 7.5

2004-05-06 Thread Bruce Momjian
ing... ] > > ---(end of broadcast)------- > TIP 4: Don't 'kill -9' the postmaster -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a h

Re: [PATCHES] [BUGS] BUG #1148: server restarts depending on stats options

2004-05-06 Thread Bruce Momjian
0/9DDCA8 > LOG: redo is not required > LOG: database system is ready > > > this is from a snapshot build on may 5th > > > > > ---(end of broadcast)--- > TIP 9: the planner will ignore your desire to

Re: [PATCHES] Run-as-admin warning for win32

2004-05-04 Thread Bruce Momjian
ove, so that's easily done. In the other case, it prompts for > username and password to run as. How would it install on an XP laptop? If I am logged in as myself and I am listed as a "Computer Administrator", do I need to create another user, and how do I do the install

Re: [PATCHES] Run-as-admin warning for win32

2004-05-04 Thread Bruce Momjian
> When running manually, you will have to grant the postgres user the > required permissions on the PGDATA directory. Then you can start the > server using "runas". Ewe, big on security, small on ease-of-use. :-) I have never had to create a user to install any other software o

Re: [PATCHES] Run-as-admin warning for win32

2004-05-04 Thread Bruce Momjian
supply a default, then if the username doesn't exist, ask if they want to create it. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your b

[PATCHES] Function to do runtime relative directory mapping

2004-05-04 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> I guess what you are saying is we should have a configure-time option to > >> address configured directories via relative paths from the executable's > >> directory

Re: [PATCHES] [pgsql-hackers-win32] Function to do runtime relative directory

2004-05-04 Thread Bruce Momjian
Andrew Dunstan wrote: > Bruce Momjian wrote: > > >+ if (toupper(*src) != toupper(*src)) > > > > > > Shouldn't this be > > if (toupper(*src) != toupper(*dst)) > > ? > Yep, fixed. > For completeness, you should probably also

Re: [PATCHES] Dollar Quoting doc patch--resend.

2004-05-05 Thread Bruce Momjian
ote and $$ based on the content is just too confusing. I would just use $$ in all cases unless $$ appears in the function (which should be rare), in which case I would use $quote$ or something generic. I am also not a fan of using $something$ that varies based on the type of function. -- B

Re: [PATCHES] FW: Timezone library

2004-04-29 Thread Bruce Momjian
e linked in. > > > > > > With this patch applied, and the timezone data installed, > > win32 now passes all time-related regression tests (3 now > > fails, 2 "known" and one being locale-inflicted, still > > investigating that one) > > > > > &

Re: [PATCHES] FW: Timezone library

2004-04-30 Thread Bruce Momjian
Peter Eisentraut wrote: > Bruce Momjian wrote: > > I have added this to CVS under src/timezone and have integrated this > > into configure. > > I think it would be better to put it under one of the generic > subdirectories, such as src/utils/timezone. We may have to add

Re: [PATCHES] subtransactions -- storage manager

2004-04-30 Thread Bruce Momjian
K, but is anybody working on the window dressing bit, so that we have > ANSI compliant commands? Not sure but that part should be easy once we have the stuff working. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610)

Re: [PATCHES] FW: Timezone library

2004-04-30 Thread Bruce Momjian
Peter Eisentraut wrote: > Am Freitag, 30. April 2004 15:27 schrieb Bruce Momjian: > > I put it under /src because it is a separate module of code that we may > > need to update someday with a new release. In that way it isn't really > > part of our backend binary but

Re: [PATCHES] FW: Timezone library

2004-04-30 Thread Bruce Momjian
Bruce Momjian wrote: > Peter Eisentraut wrote: > > Am Freitag, 30. April 2004 15:27 schrieb Bruce Momjian: > > > I put it under /src because it is a separate module of code that we may > > > need to update someday with a new release. In that way it isn't really

Re: [PATCHES] FW: Timezone library

2004-04-30 Thread Bruce Momjian
; > Cheers, > Claudio > > > > --- > Certain disclaimers and policies apply to all email sent from Memetrics. > For the full text of these disclaimers and policies see > href="http://www.memetrics.com/emailpolicy.html";>http://www.memetrics.com/em > ailpo

Re: [PATCHES] FW: Timezone library

2004-04-30 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > /usr/include/time.h:104: `pg_timezone' redeclared as different kind of > > symbol > > Your really defines "pg_timezone"?? I'm wondering if this is > an indirect effect of

Re: [PATCHES] [BUGS] BUG #1134: ALTER USER ... RENAME breaks md5 passwords

2004-04-30 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > The attached patch clears the password field on rename: > > I think you should clear the password field *only* if it's > MD5-encrypted. I thought about that but it seems strange to conditionally do the

Re: [PATCHES] FW: Timezone library

2004-04-30 Thread Bruce Momjian
t at the moment I am thinking we may end up keeping only about one > file out of the existing src/timezone import, so maybe it doesn't need > a whole subdirectory anyway? Not sure, but it is easy to move. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PRO

Re: [PATCHES] FW: Timezone library

2004-05-01 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> Right at the moment I am thinking we may end up keeping only about one > >> file out of the existing src/timezone import, so maybe it doesn't need > >> a whole sub

Re: [PATCHES] FW: Timezone library

2004-05-01 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Digging into getting this working on unix, it seems the configure tests > > that look at /usr/include are then setting values related to timezone > > that don't apply to src/timezone code. Not sur

Re: [PATCHES] [pgsql-hackers-win32] win32 build and test issues

2004-05-01 Thread Bruce Momjian
elow about not applying it, and didn't send it to -patches.) > > cheers > > andrew > > > > Bruce Momjian said: > > > > Your patch has been added to the PostgreSQL unapplied patches list at: > > > > http://momji

Re: [PATCHES] mingw regression test fixes

2004-05-01 Thread Bruce Momjian
ef="http://www.memetrics.com/emailpolicy.html";>http://www.memetrics.com/em > ailpolicy.html > > [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 7: don't forget to increase your free space ma

Re: [PATCHES] mingw regression test fixes

2004-05-02 Thread Bruce Momjian
t; I made that adjustment to what I was doing late in the day, but didn't > have time to do a revised patch before I had to do other things. > > cheers > > andrew > > > > > -------(end of broadcast)--- > TIP

Re: [PATCHES] mingw regression test fixes

2004-05-02 Thread Bruce Momjian
Peter Eisentraut wrote: > Bruce Momjian wrote: > > OK, I have made this adjustment. Thanks. > > $build_platform would be more correct. It keeps everything consistent. OK, new code for PWD flag test is: case $build_platform in *-*-mingw32*)

Re: [PATCHES] mingw regression test fixes

2004-05-03 Thread Bruce Momjian
g it does the very same > > thing for DIFFFLAGS! > > ... that is a very good argument for $host_platform as originally > proposed. OK, new code, back to original. :-) case $host_platform in *-*-mingw32*) PWDFLAGS=-W;;

Re: [PATCHES] Run-as-admin warning for win32

2004-05-03 Thread Bruce Momjian
gt; > Why? If we refuse to run as root on Unix, I do not see an argument for > being more forgiving on Windows. I am not sure it is as easy to run as non-admin on Win32 as it is to run as non-root on Unix. Is it? -- Bruce Momjian| http://candle.pha.pa.us

Re: [PATCHES] pg_ctl patch to integrate apache's rotatelogs

2004-05-16 Thread Bruce Momjian
Peter Eisentraut wrote: > Bruce Momjian wrote: > > Tom Lane wrote: > > > Bruce Momjian <[EMAIL PROTECTED]> writes: > > > > Ouch. How long has that documentation been wrong? We have > > > > pointed folks to that section of the docs tons of times,

Re: [PATCHES] Bug in CVS pg_dump against 7.0.x

2004-05-16 Thread Bruce Momjian
PQExpBuffer(buf, "%s", fmtId(typname)); > + > + /* Append array qualifier for array types */ > + if (isarray) > + appendPQExpBuffer(buf, "[]"); > > result = strdup(buf->data); > destroyPQExpBuffer(buf); > >

Re: [PATCHES] aclitem accessor functions

2004-04-26 Thread Bruce Momjian
> Fabien Coelho - [EMAIL PROTECTED] Content-Description: [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 9: the planner will ignore your desire to choose an index scan if your > joining column's datatypes do not match -- Bruce Momjian

Re: [PATCHES] [pgsql-hackers-win32] build annoyences

2004-04-26 Thread Bruce Momjian
Michiel Ephraim wrote: > On Tuesday 20 April 2004 00:32, Bruce Momjian wrote: > > Michiel Ephraim wrote: > > > dear hackers-win32 list, > > > > > > When building today's CVS version for win32, i found a few little things > > > which stopped

Re: [PATCHES] aclitem accessor functions

2004-04-26 Thread Bruce Momjian
g some patch for the documentation, although there > is no real documentation about the aclitem type in the doc tree. Would > 'func.sgml' next to has_*_privileges be an appropriate place? Yes, I thought about that, but didn't see any existing stuff either. I assume folks who want

Re: [PATCHES] [BUGS] BUG #1134: ALTER USER ... RENAME breaks md5 passwords

2004-04-26 Thread Bruce Momjian
password 'aa'; CREATE USER test=> ALTER USER pass RENAME TO pass2; NOTICE: password cleared because OF USER RENAME ALTER USER test=> ALTER USER pass2 RENAME TO pass3; ALTER USER and adds documention explaining this behavior. I

Re: [PATCHES] FW: Timezone library

2004-04-26 Thread Bruce Momjian
still > > investigating that one) > > > > > > //Magnus > > > > > > > > > <> <> Content-Description: tzcode_changes.diff [ Attachment, skipping... ] Content-Description: timezone.patch [ Attachment, skipping... ] > > --

Re: [PATCHES] NEXT VALUE FOR...

2004-04-26 Thread Bruce Momjian
kipping... ] > > ---(end of broadcast)--- > TIP 9: the planner will ignore your desire to choose an index scan if your > joining column's datatypes do not match -- Bruce Momjian| http://candle.ph

Re: [PATCHES] Basic subtransaction facility

2004-04-26 Thread Bruce Momjian
le > transaction tree (more than ERROR) but would not take the whole backend > down (less than FATAL). What should it be called? Do people agree that > it's needed? > > -- > Alvaro Herrera () > "Et put se mouve" (Galileo Galilei) [ Attachment, skipping... ]

Re: [PATCHES] subtransactions -- storage manager

2004-04-26 Thread Bruce Momjian
subtrans. Need a solution. > > > PS: somehow I managed to get tired of the phrase "nested transactions" > and I'm using the term "subtransactions" instead. In my head they are > the same thing ... > > -- > Alvaro Herrera () > Hi! I'm a .s

Re: [PATCHES] [BUGS] BUG #1134: ALTER USER ... RENAME breaks md5

2004-04-27 Thread Bruce Momjian
BSD used the username. Not sure were we got that idea. I know we needed a different salt only so users with the same password would not have the same MD5 value. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your

Re: [PATCHES] ALTER TABLE...SET WITHOUT CLUSTER

2004-04-27 Thread Bruce Momjian
t; WITHOUT OIDS.) > > Even changing the syntax to "qualified_name DROP CLUSTER" doesn't work > due to the existence of "relation_expr DROP ...". I have an idea. Change the code to use relation_expr, then throw an error from gram.y if $$->inhOpt != INH_DEFA

<    4   5   6   7   8   9   10   11   12   13   >