D10438: increase left/right margin of menuitems

[Marijo Mustac]

mmustac added a comment.


  I like the margins how they are at the moment and personally would increase 
it maximum by 5 px or so.
  The new margins shown in the screenshot are just too huge for my taste.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D10429: Disable the title bar separator by default

[Kai Uwe Broulik]

broulik added a comment.


  Can't we make it a tri-state thing? Always on, heuristic (default, like we 
used to have), disabled?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10429

To: fvogt, #vdg, #plasma, ngraham
Cc: broulik, anthonyfieroni, januz, rikmills, anemeth, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10438: increase left/right margin of menuitems

[Vlad Zagorodniy]

zzag added a comment.


  @mmustac what about this?
  
  F5706606: without-checkboxes-10.png 
  
  margins:
  
  - left: 10
  - right: 4
  - top,bottom: 3
  
  ---
  
  > The new margins shown in the screenshot are just too huge for my taste.
  
  Well, it's hard to target each personal taste. For me, bigger left margin 
feels more natural. Typical the "for my taste" problem.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D10426: Applet: Fix accessing SourceModel from main item

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10426

To: drosca, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10438: increase left/right margin of menuitems

[Fabian Riethmayer]

fabianr added a comment.


  According to the HIG  units.smallSpacing (4px) or units.largeSpacing (18px) 
or multiples of these should be used when ever possible, maybe it would make 
sense to uses these?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10438: increase left/right margin of menuitems

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D10438#204757 , @zzag wrote:
  
  > @mmustac what about this?
  >
  > F5706606: without-checkboxes-10.png 
  >
  > margins:
  >
  > - left: 10
  > - right: 4
  > - top,bottom: 3
  >
  >   ---
  >
  > > The new margins shown in the screenshot are just too huge for my taste.
  >
  > Well, it's hard to target each personal taste. For me, bigger left margin 
feels more natural. Typical the "for my taste" problem.
  
  
  Sorry to say but to my taste current margins are fine and new one two large
  Now, to address the taste issue:
  1 What is the use case?
  2 are there bug reports about margins being too narrow?  (From our users?)
  3 is this consistent with other margins used elsewhere in breeze ?
  
  For 2 at leasthe,  bug reports are generally theother way around,  from 
people complaining that breeze wastes too much space
  
  So -1 from my side sorry.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D10426: Applet: Fix accessing SourceModel from main item

[David Rosca]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:fb789820c69e: Applet: Fix accessing SourceModel from main 
item (authored by drosca).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10426?vs=26876&id=26981

REVISION DETAIL
  https://phabricator.kde.org/D10426

AFFECTED FILES
  applet/contents/ui/main.qml

To: drosca, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10454: Translated all texts from the en directory so the extension works in es

[Antonio Larrosa Jimenez]

antlarr created this revision.
antlarr added a reviewer: broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
antlarr requested review of this revision.

REVISION SUMMARY
  The chromium extension wasn't working when LANG was set to spanish and
  it seems related to the localization messages, which were completely
  borked. I took all messages from the en directory and translated them
  to spanish, which allows the extension to run successfully.

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10454

AFFECTED FILES
  extension/_locales/es/messages.json

To: antlarr, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10454: Translated all texts from the en directory so the extension works in es

[Kai Uwe Broulik]

broulik added a comment.


  Thanks for the effort but there's a bug in the translation extraction script. 
In theory the translations should be extracted into regular po files by 
scripty, translated, and then put back in but that is clearly broken.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D10454

To: antlarr, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10434: Changed hexadecimal system to decimal for Binary Clock widget

[David Edmundson]

davidedmundson added a comment.


  > I don't know if it was intended
  
  It's pretty clear this was a deliberate choice initially, not a bug, 
otherwise that startBit property wouldn't exist.
  
  > not an expected behavior from my perspective.
  
  I think you can make a valid case for either.
  
  It's not exactly an integral piece of plasma, so I don't really care either 
way, but I think this would really confuse anyone who currently uses it.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10434

To: piotrkakol
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10431: Properly handle move during touch events

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added KWin; removed Plasma.

REPOSITORY
  R108 KWin

BRANCH
  touch-quick-tiling-5.12

REVISION DETAIL
  https://phabricator.kde.org/D10431

To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D10388: allow to have more than one default activity

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> ivan wrote in Activities.cpp:233
> What do you mean by 'toggling' here?

If the default is "activityA, activityB" I don't want clients (plasmashell) to 
start loading the layout for activityA and then start loading activityB.

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D10388

To: mart, #plasma, ivan, bshah
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10429: Disable the title bar separator by default

[Marijo Mustac]

mmustac added a comment.


  In D10429#204760 , @broulik wrote:
  
  > Can't we make it a tri-state thing? Always on, heuristic (default, like we 
used to have), disabled?
  
  
  Like that idea.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10429

To: fvogt, #vdg, #plasma, ngraham
Cc: mmustac, broulik, anthonyfieroni, januz, rikmills, anemeth, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D10456: Implement Tab/Backtab navigation

[Eike Hein]

hein created this revision.
hein added a reviewer: Plasma.
Restricted Application added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  I'd like this in the 5.12 branch as it also fixes a shell freeze.
  
  BUG:387316

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10456

AFFECTED FILES
  applets/kicker/package/contents/ui/DashboardRepresentation.qml
  applets/kicker/package/contents/ui/DashboardTabBar.qml
  applets/kicker/plugin/dashboardwindow.cpp

To: hein, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8917: Reduce the amount of spurious property changes on ColorScope

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> colorscope.h:131
> +QObject *const m_parent;
> +Plasma::Theme::ColorGroup m_actualGroup;
>  

valgrind says this member isn't initialized, please fix.

http://www.davidfaure.fr/2018/colorscope_valgrind_log.txt

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D8917

To: apol, #plasma, mart, davidedmundson
Cc: dfaure, davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10456: Implement Tab/Backtab navigation

[Eike Hein]

hein updated this revision to Diff 26986.
hein added a comment.


  Full Tab/Backtab nav also when searching.
  
  Ready for review now.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10456?vs=26984&id=26986

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10456

AFFECTED FILES
  applets/kicker/package/contents/ui/DashboardRepresentation.qml
  applets/kicker/package/contents/ui/DashboardTabBar.qml
  applets/kicker/plugin/dashboardwindow.cpp

To: hein, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Monday meeting notes

[Marco Martin]

notes for 12/2/2018
present: Eike, Kai Uwe, Bhushan, Roman, Marco

Eike
* [Dashboard] Implemented missing Tab/Backtab keyboard nav in
Dashboard (fixes a reported freeze bug on Shift+Tab along the way)
* [TM] Fixed pinning apps when their .desktop file has spaces in the file name
* [TM] Fixed crash on running apps with a corrupted .desktop file (by
making KRun more careful and not starting a nested event loop from a
task delete we destroy due to an opportunistic startup notification)
** Patch needs another revision
* [General] Working on a prototype for a different activity switching
experience with Marco's help

Kai Uwe
* Did some fixes for BlueDevil and Volume applets
* Some performance improvements in Task Manager (more lazyloading,
e.g. of tooltip delegate)
* Worked a bit on making KWin's tooltips less annoying, they show up
for non-active windows and also have no show delay whatsoever
* Clened up KUrlNavigatorPlacesSelector, straight from Task Manager:
D10329 VDG-approved but I'd like some dev approval also
Diff 10329 "[KUrlNavigatorPlacesSelector] Put categories into
submenus" [Needs Review] https://phabricator.kde.org/D10329
* Cleaner look for file dialog D10325
Diff 10325 "[KFileWidget] Hide places frame and header" [Accepted]
https://phabricator.kde.org/D10325
_: what is different activity switching experience? :)
* And the most exciting thing of them all is something that I've been
working on is gmenu-dbusmenu-proxy
http://wstaw.org/m/2018/02/12/Screenshot_20180212_120532.png

Bhushan
- Packaged camera stuff finally : https://i.imgur.com/SsuFuFp.jpg
- Also included gst-omx stuff on mobile image, so fully accelerated
video playback
- random packaging stuff for plasma mobile
- ported fullscreen panel on plasma phone to kwayland, pending review
from notmart

Roman
* Follow ups on FOSDEM (was great!).
‎* Follow ups on 5.12 release (many problems apparently, we should in
5.13 planning talk about our release process).
*‎ Planning for next release (in particular our Wayland efforts).
‎* final stages for my Xwayland patches for upstream...

Marco
* pushed the plotter component crash fix
* fixed a serious security issue in the device notifier (commands
embedded in removable drives were executed... ouch) all pushed,
security advisory sent to security@
* Fixed in kirigami custom colored icons
* Fixed in Kirigami drawer handle behavior when a global footer is present
* work on qqc2-desktop-style for better look and behavior
* icons support for buttons/toolbuttons/menuitems in qqc2-desktop-style
* fixed rendering for BusyIndicator
* new missing components in qqc2-desktop-style: RoundButton,
DelayButton, MenuBarItem
* helped kai a bit on gmenu debug
* prototype for a new gesture based activity switching in plasma mobile
* patch in kactivitymanager to create a set of default activities not
from desktop scripting D10388

D10456: Implement Tab/Backtab navigation

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10456

To: hein, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10388: allow to have more than one default activity

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in Activities.cpp:233
> If the default is "activityA, activityB" I don't want clients (plasmashell) 
> to start loading the layout for activityA and then start loading activityB.

when i tested it it didn't seem to switch to the latest created one without an 
explicit setCurrentActivity?

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D10388

To: mart, #plasma, ivan, bshah
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10456: Implement Tab/Backtab navigation

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c85eb1aef49e: Implement Tab/Backtab navigation (authored 
by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10456?vs=26986&id=26988

REVISION DETAIL
  https://phabricator.kde.org/D10456

AFFECTED FILES
  applets/kicker/package/contents/ui/DashboardRepresentation.qml
  applets/kicker/package/contents/ui/DashboardTabBar.qml
  applets/kicker/plugin/dashboardwindow.cpp

To: hein, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

[Jaime Torres Amate]

jtamate added a comment.


  In D10342#204465 , @jtamate wrote:
  
  > In https://phabricator.kde.org/D9840 I noticed a high i/o and cpu usage
  >  when using the vivaldi browser, opening 10 tabs just caused a 40% cpu
  >  usage. Now, opening 10 tabs or more is bellow the 0.03%.
  
  
  I know now why it is calling windowUrlFromMetadata.
  Because unlike firefox and chromium, with sub processes using the same 
executable but with parameters, the vivaldi sub processes are called 
vivaldi-bin, and there is no .desktop file for that executable name. As soon as 
I've manually created a .desktop file for vivaldi-bin, plasmashell cpu became 
normal without the patch. With the patch, there is no need for the .desktop 
file.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10342

To: jtamate, #plasma_workspaces
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10459: Cards Dashboard Feature Added

[Aditya Mehra]

Aiix created this revision.
Aiix added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Aiix requested review of this revision.

REVISION SUMMARY
  Ref T7175  Added cards dashboard feature 
to mycroft plasmoid

REPOSITORY
  R846 Mycroft Plasma integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10459

AFFECTED FILES
  plasmoid/contents/images/ctxmenu.png
  plasmoid/contents/images/newsicon.png
  plasmoid/contents/images/readaloud.png
  plasmoid/contents/images/share.png
  plasmoid/contents/ui/DashNewsDelegate.qml
  plasmoid/contents/ui/DashWeatherDelegate.qml
  plasmoid/contents/ui/DashboardDelegate.qml
  plasmoid/contents/ui/DashboardType.qml
  plasmoid/contents/ui/DisclaimerCardDelegate.qml
  plasmoid/contents/ui/NavigationDelegate.qml
  plasmoid/contents/ui/PlacesDelegate.qml
  plasmoid/contents/ui/PlacesType.qml
  plasmoid/contents/ui/main.qml

To: Aiix, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10459: Cards Dashboard Feature Added

[Aditya Mehra]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R846:309de891c95c: Cards Dashboard Feature Added (authored by 
Aiix).

REPOSITORY
  R846 Mycroft Plasma integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10459?vs=26990&id=26992

REVISION DETAIL
  https://phabricator.kde.org/D10459

AFFECTED FILES
  plasmoid/contents/images/ctxmenu.png
  plasmoid/contents/images/newsicon.png
  plasmoid/contents/images/readaloud.png
  plasmoid/contents/images/share.png
  plasmoid/contents/ui/DashNewsDelegate.qml
  plasmoid/contents/ui/DashWeatherDelegate.qml
  plasmoid/contents/ui/DashboardDelegate.qml
  plasmoid/contents/ui/DashboardType.qml
  plasmoid/contents/ui/DisclaimerCardDelegate.qml
  plasmoid/contents/ui/NavigationDelegate.qml
  plasmoid/contents/ui/PlacesDelegate.qml
  plasmoid/contents/ui/PlacesType.qml
  plasmoid/contents/ui/main.qml

To: Aiix, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10438: increase left/right margin of menuitems

[Diego Gangl]

januz added a comment.


  IMO, the last version looks better than the current menu. That said, I think 
the top/bottom paddings are still too tight, I would try adding 2-3px for each.
  It's true that there's a question of taste but more whitespace is generally a 
good thing (unless you go overboard and start making huge widgets). A couple 
more pixels in the menus will help focus the elements better (by framing them 
in negative space), it will make the ui look less "full of stuff" and less 
tense.
  
  For reference:
  
  Material design manual: 
https://material.io/guidelines/components/menus.html#menus-usage
  Gnome: http://i.imgur.com/er2odvE.png
  Mac: 
https://www.intego.com/mac-security-blog/wp-content/uploads/2016/12/Mac-menu-bar-extras-sound.png
  Windows: 
https://docs.microsoft.com/en-us/windows/uwp/design/controls-and-patterns/menus

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10420: Make sure the FrameSvg and Svg instances have the right devicePixelRatio

[Aleix Pol Gonzalez]

apol added a comment.


  In D10420#204235 , @hein wrote:
  
  > Sanity check question: Did you make sure this doesn't introduce an extra 
render when things start up? (Initial vs. change.)
  >
  > Otherwise makes sense (and finally fixes some Wayland uglyness I've been 
annoyed by ...).
  
  
  Only should be adding an extra rendering cycle if it was rendered with the 
wrong dpi, so it's something we need anyway.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10420

To: apol, #plasma
Cc: hein, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10420: Make sure the FrameSvg and Svg instances have the right devicePixelRatio

[Eike Hein]

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10420

To: apol, #plasma, hein
Cc: hein, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10420: Make sure the FrameSvg and Svg instances have the right devicePixelRatio

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:3e4b26452aeb: Make sure the FrameSvg and Svg instances 
have the right devicePixelRatio (authored by apol).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10420?vs=26855&id=26993

REVISION DETAIL
  https://phabricator.kde.org/D10420

AFFECTED FILES
  src/declarativeimports/core/framesvgitem.cpp
  src/declarativeimports/core/framesvgitem.h
  src/declarativeimports/core/iconitem.cpp

To: apol, #plasma, hein
Cc: hein, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10438: increase left/right margin of menuitems

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D10438#204869 , @januz wrote:
  
  > IMO, the last version looks better than the current menu. That said, I 
think the top/bottom paddings are still too tight, I would try adding 2-3px for 
each.
  >  It's true that there's a question of taste but more whitespace is 
generally a good thing (unless you go overboard and start making huge widgets). 
A couple more pixels in the menus will help focus the elements better (by 
framing them in negative space), it will make the ui look less "full of stuff" 
and less tense.
  >
  > For reference:
  >
  > Material design manual: 
https://material.io/guidelines/components/menus.html#menus-usage
  
  
  This is a touch based ui.
  
  > Gnome: http://i.imgur.com/er2odvE.png
  >  Mac: 
https://www.intego.com/mac-security-blog/wp-content/uploads/2016/12/Mac-menu-bar-extras-sound.png
  >  Windows: 
https://docs.microsoft.com/en-us/windows/uwp/design/controls-and-patterns/menus
  
  None of these are application's menu. (though I did not check if applications 
menus are narrower in these three cases)
  
  In anycase, increasing margins should then be made consistently accross the 
style and not one by one if you want to keep balance.
  For gnome, for instance, see how _all_ margins are larger (and thus 
consistent).
  
  So far, on bugzilla there have been more complains about breeze being too 
space-hungry than too dense. 
  (I can post the links here if needed)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10338: Don't show tooltips for inactive windows

[Oleg Solovyov]

McPain accepted this revision.
McPain added a comment.
This revision is now accepted and ready to land.


  This commit looks good and it works just as planned

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D10338

To: broulik, #plasma, graesslin, McPain
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10438: increase left/right margin of menuitems

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  also see how in two the posted screenshots the checkmarks for checkable items 
is actually very close to the menu border.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  last round of modifications: simplifications of the blurHelper class. 
  Also, for the config ui, maybe it makes more sense to call the "Transparency" 
tab, only "Menus" and change "Menu:" into "Transparency:"
  Unless of course one wants to add transparency behind other widgets.
  
  Then I think it is good to go.

INLINE COMMENTS

> breezeblurhelper.h:138
> +
> +#endif

Because the use of this class is much simplified wrt the original one, it can 
be significantly simplified:

_timer (and timerEvent) are unnecessary.
Then update() could be removed, as well as _widgets, as well as the 
widgetDestroyed callback.
Then update(widget) could be called directly in the event filter.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D10461: WIP: GMenu-DBusMenu-Proxy

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This application finds windows using GTK GMenu DBus interfaces [1] and 
forwards them through DBusMenu. This way no adjustments in Plasma are needed.
  
  [1] https://wiki.gnome.org/Projects/GLib/GApplication/DBusAPI#org.gtk.Menus

TEST PLAN
  Branch `broulik/gmenu-dbusmenu-proxy` of plasma-workspace
  
  Tested `gedit` which supposedly only has a menu bar on Ubuntu, toggle actions 
(e.g. "Full screen" and "Overwrite mode" don't work right now)
  F5707116: Screenshot_20180212_143407.png 

  Tested LibreOffice 6 with `gtk3_kde5` platform plugin, should just work with 
regular GTK3 plugin
  F5707119: Screenshot_20180212_143237.png 

  I won't be able to add any icons to LibreOffice's menus as the action names 
are random ids assigned by it. In gedit I get some names like "open" and "save" 
I could map on our side
  
  Applications not having a dedicated menu bar will at least show the top panel 
menu with Settings, About, and Help
  F5707121: Screenshot_20180212_143839.png 

  
  Does not work with Gimp or Inkscape as they aren't GTK3-based.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10461

AFFECTED FILES
  CMakeLists.txt
  gmenu-dbusmenu-proxy/CMakeLists.txt
  gmenu-dbusmenu-proxy/gdbusmenutypes_p.cpp
  gmenu-dbusmenu-proxy/gdbusmenutypes_p.h
  gmenu-dbusmenu-proxy/gmenudbusmenuproxy.desktop
  gmenu-dbusmenu-proxy/main.cpp
  gmenu-dbusmenu-proxy/menu.cpp
  gmenu-dbusmenu-proxy/menu.h
  gmenu-dbusmenu-proxy/menuproxy.cpp
  gmenu-dbusmenu-proxy/menuproxy.h

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10438: increase left/right margin of menuitems

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D10438#204764 , @fabianr wrote:
  
  > According to the HIG  units.smallSpacing (4px) or units.largeSpacing (18px) 
or multiples of these should be used when ever possible, maybe it would make 
sense to uses these?
  
  
  Thats a good point. One should use update the breeze metrics (which predate 
the HIG), to use these whenever possible. 
  This is largely unrelated to this patch though.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10461: WIP: GMenu-DBusMenu-Proxy

[Kai Uwe Broulik]

broulik updated this revision to Diff 26999.
broulik edited the summary of this revision.
broulik edited the test plan for this revision.
broulik added a comment.


  - Don't send random arguments to `Activate`, fixes toggle actions not working

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10461?vs=26996&id=26999

REVISION DETAIL
  https://phabricator.kde.org/D10461

AFFECTED FILES
  CMakeLists.txt
  gmenu-dbusmenu-proxy/CMakeLists.txt
  gmenu-dbusmenu-proxy/gdbusmenutypes_p.cpp
  gmenu-dbusmenu-proxy/gdbusmenutypes_p.h
  gmenu-dbusmenu-proxy/gmenudbusmenuproxy.desktop
  gmenu-dbusmenu-proxy/main.cpp
  gmenu-dbusmenu-proxy/menu.cpp
  gmenu-dbusmenu-proxy/menu.h
  gmenu-dbusmenu-proxy/menuproxy.cpp
  gmenu-dbusmenu-proxy/menuproxy.h

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10461: WIP: GMenu-DBusMenu-Proxy

[Kai Uwe Broulik]

broulik edited the summary of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10461

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10438: increase left/right margin of menuitems

[Vlad Zagorodniy]

zzag added a comment.


  Just to clarify that other DE and OS have some space on the left side:
  
  - Windows: 
https://forums.windowscentral.com/attachments/windows-8/48119d1382981718t-screenshot-1-.png
  - macOS: https://i.stack.imgur.com/h6LAN.png
  - elementaryOS: https://i.stack.imgur.com/2fwU9.png
  
  even Ubuntu(Unity):
  
  F5707179: context-menu-ubuntu.png 
  
  F5707182: context-menu-tray.png 
  
  Typical pattern:
  [] []  [ or ]
  in the case when a menu item doesn't have a checkbox or radiobutton, some 
space is reserved(more precisely, width of checkbox/radiobutton).
  
  So, the left margin should be even bigger - 28. (CheckBox_Size + 
2*MenuItem_ItemSpacing)
  
  ---
  
  > According to the HIG units.smallSpacing (4px) or units.largeSpacing (18px) 
or multiples of these should be used when ever possible, maybe it would make 
sense to uses these?
  
  So, margins should be preferred to multiples of 4 or 18, right?
  
  > also see how in two the posted screenshots the checkmarks for checkable 
items is actually very close to the menu border
  
  It can be changed. Currently, distance between menu's left border and 
checkboxes equals to `MenuItem_ItemSpacing`.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10438: increase left/right margin of menuitems

[Vlad Zagorodniy]

zzag added a comment.


  In D10438#204884 , 
@hpereiradacosta wrote:
  
  > In anycase, increasing margins should then be made consistently accross the 
style and not one by one if you want to keep balance.
  
  
  No, it should not. This is a small change which doesn't require rethinking 
the whole design, imo.
  
  > For gnome, for instance, see how _all_ margins are larger (and thus 
consistent).
  
  GNOME just loves "nom-nom-nom available display space".

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10463: Consistently use a Toolbar for headers

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Discover Software Store, abetts, apol.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  BUG: 385973
  
  Use a ToolBar for every page's header, with the following benefits:
  
  - Eliminate user complaints about image banner headers
  - Add an area for UI controls, such as a sort order menu button
  - Increase internal UI consistency; now everything uses the same header style 
except for the main Featured page (which I think deserves a banner, just with a 
better image)

TEST PLAN
  Tested extensively in KDE Neon. No functional regressions.
  
  [Before-and-after screenshots will go here]

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10463

AFFECTED FILES
  discover/qml/ApplicationPage.qml
  discover/qml/ApplicationsListPage.qml
  discover/qml/InstalledPage.qml
  discover/qml/SourcesPage.qml
  discover/qml/UpdatesPage.qml

To: ngraham, #discover_software_store, abetts, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10463: Consistently use a Toolbar for headers

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10463

To: ngraham, #discover_software_store, abetts, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10463: [WIP/RFC] Consistently use a Toolbar for headers

[Nathaniel Graham]

ngraham retitled this revision from "Consistently use a Toolbar for headers" to 
"[WIP/RFC] Consistently use a Toolbar for headers".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10463

To: ngraham, #discover_software_store, abetts, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10396: Support "phone" form factor

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:2b8fd79fbf14: Support "phone" form factor 
(authored by broulik).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10396?vs=26798&id=27003

REVISION DETAIL
  https://phabricator.kde.org/D10396

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml

To: broulik, #plasma, drosca
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Re: 5.12 release: congratulations and post-mortem

[Roman Gilg]

Regarding QA of releases there is this task now:
https://phabricator.kde.org/T7949

This will most likely touch the general release process as well.

You are welcome to join the task as subscribers or with direct input.
First we need to collect ideas how to improve our QA.

On Tue, Feb 6, 2018 at 4:54 PM, Nate Graham  wrote:
> Congrats on a fantastic release of Plasma 5.12 everybody! People are really
> gonna love it.
>
> The release process was a bit rockier than expected, and I thought I might
> do a post-mortem to see how we can make the next one smoother:
>
>
>
> Problem: Initial request for release notes was not seen by many
> ===
> Solutions:
> - Send email to kde-pr...@kde.org and kde-de...@kde.org as well
> - Use a Phabricator task instead of email to track overall work
> - Make a subtask to track gathering release notes from developers
> - Delegate a specific person (Ivanna?) to be responsible for turning the
> release notes into final marketing copy
>
>
>
> Problem: Unclear roles; nobody knew who owned the beta announcement
> ===
> Solutions:
> - Make roles and responsibilities clear to all; assign specific people to
> specific tasks
> - Make the KDE Promo crew the guardians of everything public-facing
>
>
>
> Problem: Unclear access to the kde.org website
> ==
> (At once point, changes were requested and planned, but the one person that
> everybody knew had access was on vacation)
>
> Solutions:
> - Define who should have access ahead of time
> - Get those people access to the website ahead of time
>
>
>
> Problem: Promo video produced at the last minute, gating final release
> ==
> Solutions:
> - Supply whomever is making the video with a pre-release copy of Plasma 5.12
> at least a few days in advance so that the video can be completed sooner
>
>
>
> Thoughts?
>
> Nate
>

D10395: Use plasmoid.icon instead of Logic.icon()

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R97:2c5de6e121b5: Use plasmoid.icon instead of Logic.icon() 
(authored by broulik).

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10395?vs=26795&id=27004

REVISION DETAIL
  https://phabricator.kde.org/D10395

AFFECTED FILES
  src/applet/package/contents/ui/CompactRepresentation.qml

To: broulik, #plasma, drosca
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10397: Use Qt.openUrlExternally instead of Kio

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R97:52d1950213b9: Use Qt.openUrlExternally instead of Kio 
(authored by broulik).

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10397?vs=26799&id=27005

REVISION DETAIL
  https://phabricator.kde.org/D10397

AFFECTED FILES
  src/applet/package/contents/ui/BluetoothApplet.qml
  src/applet/package/contents/ui/DeviceItem.qml

To: broulik, #plasma, drosca
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10438: increase left/right margin of menuitems

[Alex Nemeth]

anemeth added a comment.


  In D10438#204922 , @zzag wrote:
  
  > Just to clarify that other DE and OS have some space on the left side:
  >
  > - Windows: 
https://forums.windowscentral.com/attachments/windows-8/48119d1382981718t-screenshot-1-.png
  > - macOS: https://i.stack.imgur.com/h6LAN.png
  > - elementaryOS: https://i.stack.imgur.com/2fwU9.png
  
  
  you're right
  one more thing I noticed in the screenshots here that there is no keyboard 
shortcut hint that makes the menu double the width it should be
  
  F5707644: qq.PNG 
  
  maybe in an another patch that could be removed too?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10463: [WIP/RFC] Consistently use a Toolbar for headers

[Aleix Pol Gonzalez]

apol added a comment.


  If we're to do this, I'd very much prefer to use kirigami's native header.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10463

To: ngraham, #discover_software_store, abetts, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Plasma Wayland 5.13 Meeting time

[Roman Gilg]

We had our regular Plasma 5.13 Kickoff meeting today. We discussed
Wayland on 5.13 as well. There is probably still need for a separate
meeting on how we want to push forward our Plasma Wayland session for
5.13.

Is tomorrow, Tuesday the 18-02-12, 7pm Berlin time ok? On #plasma IRC.

D10463: [WIP/RFC] Consistently use a Toolbar for headers

[Nathaniel Graham]

ngraham added a comment.


  As long as it looks good on the desktop too (or we can make it look good on 
the desktop too), I'm okay with that. Does it look and behave acceptably right 
now?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10463

To: ngraham, #discover_software_store, abetts, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Alex Nemeth]

anemeth marked an inline comment as done.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Alex Nemeth]

anemeth updated this revision to Diff 27008.
anemeth added a comment.


  Simplified the breezeblurhelper class

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10170?vs=26814&id=27008

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10170

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezeblurhelper.cpp
  kstyle/breezeblurhelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

Re: Plasma Wayland 5.13 Meeting time

[Jonathan Riddell]

Folks who have already ticked the poll at
https://doodle.com/poll/8wwrt59dt8prz6pf


On 12 February 2018 at 15:52, Roman Gilg  wrote:
> We had our regular Plasma 5.13 Kickoff meeting today. We discussed
> Wayland on 5.13 as well. There is probably still need for a separate
> meeting on how we want to push forward our Plasma Wayland session for
> 5.13.
>
> Is tomorrow, Tuesday the 18-02-12, 7pm Berlin time ok? On #plasma IRC.

D10170: Added optional transparency/blur to menu frames

[Alex Nemeth]

anemeth added a comment.


  In D10170#204889 , 
@hpereiradacosta wrote:
  
  > Also, for the config ui, maybe it makes more sense to call the 
"Transparency" tab, only "Menus" and change "Menu:" into "Transparency:"
  >  Unless of course one wants to add transparency behind other widgets.
  
  
  Maybe in the future someone wants to add this transparency to (for example) 
dropdown menu, combobox, or other elements.
  I say we should keep the naming vague.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Hugo Pereira Da Costa]

hpereiradacosta added inline comments.

INLINE COMMENTS

> breezeblurhelper.cpp:45
> +QObject(parent),
> +_helper(helper)
> +{

helper argument is not needed

> breezeblurhelper.h:53
> +//! constructor
> +BlurHelper( QObject*, Helper& );
> +

helper argument is not needed

> breezeblurhelper.h:80
> +
> +protected Q_SLOTS:
> +

this can go.
No more slots :)

> breezeblurhelper.h:85
> +//* helper
> +Helper _helper;
> +

this can go

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D10438: increase left/right margin of menuitems

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D10438#204960 , @anemeth wrote:
  
  > In D10438#204922 , @zzag wrote:
  >
  > > Just to clarify that other DE and OS have some space on the left side:
  > >
  > > - Windows: 
https://forums.windowscentral.com/attachments/windows-8/48119d1382981718t-screenshot-1-.png
  > > - macOS: https://i.stack.imgur.com/h6LAN.png
  > > - elementaryOS: https://i.stack.imgur.com/2fwU9.png
  >
  >
  > you're right
  >  one more thing I noticed in the screenshots here that there is no keyboard 
shortcut hint that makes the menu double the width it should be
  >
  > F5707644: qq.PNG 
  >
  > maybe in an another patch that could be removed too?
  
  
  That would be a serious regression to many users. How would you then know 
about the shortcuts ?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10438: increase left/right margin of menuitems

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D10438#204922 , @zzag wrote:
  
  > Just to clarify that other DE and OS have some space on the left side:
  >
  > - Windows: 
https://forums.windowscentral.com/attachments/windows-8/48119d1382981718t-screenshot-1-.png
  > - macOS: https://i.stack.imgur.com/h6LAN.png
  > - elementaryOS: https://i.stack.imgur.com/2fwU9.png
  >
  >   even Ubuntu(Unity):
  >
  >   F5707179: context-menu-ubuntu.png 
  >
  >   F5707182: context-menu-tray.png 
  >
  >   Typical pattern: [] []  [ or ] 
in the case when a menu item doesn't have a checkbox or radiobutton, some space 
is reserved(more precisely, width of checkbox/radiobutton).
  
  
  Agreed, and if others from vdg agree, I am fine with always adding the 
necessary space for checkboxes and radio buttons on the left.
  But then that makes it a different patch, right ?
  
  Margins are not changed. What is changed is the allocated space for the menu 
item content, that always accommodate for the checkbox, and draws it whenever 
there is one.
  
  Personally, I think it is better that this space is not allocated when there 
is no crossheck to be drawn in the full menu. I think it is an _improvement_ 
with respect to the other design you send, and would see this change rather as 
a regression. (I would not see why you allocate some empty space if there is 
nothing to render in it).
  
  But then, if VDG agrees, I would oblige.
  
  > So, the left margin should be even bigger - 28. (CheckBox_Size + 
2*MenuItem_ItemSpacing)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10438: increase left/right margin of menuitems

[Nathaniel Graham]

ngraham added a comment.


  We cannot ever remove the shortcuts from the menus, for countless usability 
reasons. Lack of discoverable keyboard shortcuts is one of the many 
productivity and ergonomic flaws of GNOME; we cannot regress to that level.
  
  in macOS, the shortcuts are more compact because symbols are used instead of 
letters:
  
  F5707708: image.png 
  
  I'm not sure we could use that here because PC keyboards' modifier keys don't 
have symbols on them the way Mac keyboards generally do.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Alex Nemeth]

anemeth updated this revision to Diff 27010.
anemeth added a comment.


  Removed the _helper variable from the breezeblurhelper class

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10170?vs=27008&id=27010

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10170

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezeblurhelper.cpp
  kstyle/breezeblurhelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D10170#204976 , @anemeth wrote:
  
  > In D10170#204889 , 
@hpereiradacosta wrote:
  >
  > > Also, for the config ui, maybe it makes more sense to call the 
"Transparency" tab, only "Menus" and change "Menu:" into "Transparency:"
  > >  Unless of course one wants to add transparency behind other widgets.
  >
  >
  > Maybe in the future someone wants to add this transparency to (for example) 
dropdown menu, combobox, or other elements.
  >  I say we should keep the naming vague.
  
  
  Can you post an updated screenshot about the configuration option, and can we 
get VDG's opinion on it ?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Alex Nemeth]

anemeth marked 4 inline comments as done.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

Re: Plasma Wayland 5.13 Meeting time

[Martin Flöser]

Am 2018-02-12 16:52, schrieb Roman Gilg:

We had our regular Plasma 5.13 Kickoff meeting today. We discussed
Wayland on 5.13 as well. There is probably still need for a separate
meeting on how we want to push forward our Plasma Wayland session for
5.13.

Is tomorrow, Tuesday the 18-02-12, 7pm Berlin time ok? On #plasma IRC.


I should probably be able to make it

Cheers
Martin

D10170: Added optional transparency/blur to menu frames

[Alex Nemeth]

anemeth added a comment.


  In D10170#205000 , 
@hpereiradacosta wrote:
  
  > Can you post an updated screenshot about the configuration option, and can 
we get VDG's opinion on it ?
  
  
  This is how it looks now
  F5707716: cvb.PNG 
  I made it look like the Translucency effect config
  F5707719: bvc.PNG 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D10438: increase left/right margin of menuitems

[Andres Betts]

abetts added a comment.


  How are we accounting for stacking menu items that have:
  
  Checkbox - Item Icon - Label -- Shortcut-Arrow Icon
  
  The first part of that tends to make the checkbox be closest to the edge. Are 
we thinking we should/not use icons in menus, keep the same?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

Re: Plasma Wayland 5.13 Meeting time

[Bhushan Shah]

On Mon, Feb 12, 2018 at 04:52:00PM +0100, Roman Gilg wrote:
> Is tomorrow, Tuesday the 18-02-12, 7pm Berlin time ok? On #plasma IRC.

I want to attend but since there is already another meeting I've to
attend tomrrow evening can we do wednesday maybe?

Also as a general suggestion, maybe we can do seperate doodle...

Thanks

-- 
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D


signature.asc
Description: PGP signature

Re: Plasma Wayland 5.13 Meeting time

[Marco Martin]

Tomorrow i can try, but i probably can't make it

On Mon, Feb 12, 2018 at 5:13 PM, Martin Flöser  wrote:
> Am 2018-02-12 16:52, schrieb Roman Gilg:
>>
>> We had our regular Plasma 5.13 Kickoff meeting today. We discussed
>> Wayland on 5.13 as well. There is probably still need for a separate
>> meeting on how we want to push forward our Plasma Wayland session for
>> 5.13.
>>
>> Is tomorrow, Tuesday the 18-02-12, 7pm Berlin time ok? On #plasma IRC.
>
>
> I should probably be able to make it
>
> Cheers
> Martin

5.13 Kickoff Meeting

[Jonathan Riddell]

Thanks for the meeting folks, here's the minutes I extracted out of the log

** 5.12 was awesome but not yet perfect, aim for perfection where possible
** dependency requirements to be better defined and documented - action JR
** tosky to add JR to calendar in phab, plasma and hopefully
frameworks to be added
** Plasma 5.13 to dep on Qt 5.9 or .10, no final decision yet
** Plasma 5.13 to be tested against Qt 5.11 but not depend on it
** 5.8 stops regular releases when we do 5.12.x, maintains support a
case by case basis
** JR to close Done tasks on Plasma todo
** kcm redesign work  https://phabricator.kde.org/project/view/254/ to
be promoted for contributors, david to assign to anyone who doesn't
run away screaming
** neon spods to documents how to write and check openqa tests
** david to create Plasma structured testing process for kde-quality
** romangg to run breakout meeting to chat about kirigami HIG and
sphinx and required to report back in triplicate by March 5st
** eike to make kicker improvements, sho and riddell to add todo items as useful
** plasma-browser-integration host binary to be shipped with Plasma
5.13, david and tosky to sort translations, extension to be made
available for easy install
** romangg and Sho_ to discuss sprint meeting dates with Mirco et al
** jr to submit plasma talk to akademy to be sorted out nearer the time
** jr to request plasma bof when they open


plasma-5.13-kickoff-log
Description: Binary data

D10438: increase left/right margin of menuitems

[Alex Nemeth]

anemeth added a comment.


  In D10438#205005 , @abetts wrote:
  
  > Are we thinking we should/not use icons in menus, keep the same?
  
  
  Looks quite good in my opinion with this patch applied and no icons
  F5707729: .PNG 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10438: increase left/right margin of menuitems

[Nathaniel Graham]

ngraham added a comment.


  Let's try to avoid radical proposals like getting rid of keyboard shortcuts 
and icons. For now, let's focus on the initial goal, or perhaps a slightly 
modified goal of adding room to put checkboxes to the left of the text (which I 
would support).

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10438: increase left/right margin of menuitems

[Andres Betts]

abetts added a comment.


  In D10438#205009 , @ngraham wrote:
  
  > Let's try to avoid radical proposals like getting rid of keyboard shortcuts 
and icons. For now, let's focus on the initial goal, or perhaps a slightly 
modified goal of adding room to put checkboxes to the left of the text (which I 
would support).
  
  
  Can you answer the question though?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10438: increase left/right margin of menuitems

[Vlad Zagorodniy]

zzag added a comment.


  In D10438#205009 , @ngraham wrote:
  
  > Let's try to avoid radical proposals like getting rid of keyboard shortcuts 
and icons. For now, let's focus on the initial goal, or perhaps a slightly 
modified goal of adding room to put checkboxes to the left of the text (which I 
would support).
  
  
  I haven't got rid of keyboard shortcuts. I've encountered this bug too. With 
`ShowIconsInMenuItems` set to `false`, `QStyleOptionMenuItem` doesn't pass 
shortcuts.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10388: allow to have more than one default activity

[Ivan Čukić]

ivan added inline comments.

INLINE COMMENTS

> mart wrote in Activities.cpp:233
> when i tested it it didn't seem to switch to the latest created one without 
> an explicit setCurrentActivity?

@davidedmundson Haven't looked at that part of Plasma for some time, but I see 
no reason why it would do that since creating a new activity does not make it 
current.

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D10388

To: mart, #plasma, ivan, bshah
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10438: increase left/right margin of menuitems

[Nathaniel Graham]

ngraham added a comment.


  In D10438#205010 , @abetts wrote:
  
  > In D10438#205009 , @ngraham 
wrote:
  >
  > > Let's try to avoid radical proposals like getting rid of keyboard 
shortcuts and icons. For now, let's focus on the initial goal, or perhaps a 
slightly modified goal of adding room to put checkboxes to the left of the text 
(which I would support).
  >
  >
  > Can you answer the question though?
  
  
  I would not be in favor of removing the menu item icons, no. This would 
introduce inconsistency issues all over the place and represents a fairly 
significant departure from a long-standing UI. If we ever do that, it would 
have to:
  
  - Present clear usability and visual advantages that enough folks agree on
  - Involve significant discussion of the ramifications
  - Be in in its own patch
  - Involve a great deal of testing to make sure there's no fallout
  - etc
  
  ...In short, not something worth bringing up in the discussion of this patch.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

KDE CI: Plasma discover stable-kf5-qt5 FreeBSDQt5.9 - Build # 61 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20stable-kf5-qt5%20FreeBSDQt5.9/61/
 Project:
Plasma discover stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 12 Feb 2018 17:05:09 +
 Build duration:
2 min 20 sec and counting
   CONSOLE OUTPUT
  [...truncated 173.44 KB...][ 38%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/ResourcesUpdatesModel.cpp.o[ 39%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/SourcesModel.cpp.o[ 40%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/AbstractResourcesBackend.cpp.o[ 41%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/AbstractResource.cpp.o[ 42%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/AbstractBackendUpdater.cpp.o[ 43%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/AbstractSourcesBackend.cpp.o[ 44%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/StoredResultsStream.cpp.o[ 45%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/CachedNetworkAccessManager.cpp.o[ 46%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ActionsModel.cpp.o[ 47%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/DiscoverBackendsFactory.cpp.o[ 48%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ScreenshotsModel.cpp.o[ 50%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ApplicationAddonsModel.cpp.o[ 51%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/DiscoverCommon_autogen/mocs_compilation.cpp.o[ 52%] Linking CXX shared library libDiscoverCommon.so[ 52%] Built target DiscoverCommonScanning dependencies of target knsbackendtest_autogenScanning dependencies of target dummy-backend_autogenScanning dependencies of target kns-backend_autogenScanning dependencies of target updatedummytest_autogenScanning dependencies of target dummytest_autogenScanning dependencies of target CategoriesTest_autogen[ 53%] Automatic MOC for target knsbackendtest[ 53%] Automatic MOC for target dummy-backend[ 54%] Automatic MOC for target updatedummytest[ 55%] Automatic MOC for target dummytest[ 56%] Automatic MOC for target CategoriesTest[ 57%] Automatic MOC for target kns-backend[ 57%] Built target knsbackendtest_autogenScanning dependencies of target plasma-discover_autogen[ 58%] Automatic MOC for target plasma-discover[ 58%] Built target dummytest_autogenScanning dependencies of target plasma-discover-exporter_autogen[ 59%] Built target CategoriesTest_autogen[ 59%] Automatic MOC for target plasma-discover-exporterScanning dependencies of target knsbackendtest[ 60%] Building CXX object libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/KNSBackendTest.cpp.o[ 60%] Built target plasma-discover-exporter_autogen[ 60%] Built target updatedummytest_autogenScanning dependencies of target CategoriesTest[ 60%] Building CXX object libdiscover/tests/CMakeFiles/CategoriesTest.dir/CategoriesTest.cpp.oScanning dependencies of target dummytest[ 61%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/dummytest.dir/__/__/__/tests/modeltest.cpp.o[ 61%] Built target dummy-backend_autogen[ 62%] Building CXX object libdiscover/tests/CMakeFiles/CategoriesTest.dir/CategoriesTest_autogen/mocs_compilation.cpp.o[ 63%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/dummytest.dir/DummyTest.cpp.o[ 64%] Linking CXX executable CategoriesTest[ 65%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/dummytest.dir/dummytest_autogen/mocs_compilation.cpp.o[ 65%] Built target kns-backend_autogen[ 65%] Built target CategoriesTest[ 65%] Built target plasma-discover_autogen[ 66%] Building CXX object libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/knsbackendtest_autogen/mocs_compilation.cpp.oScanning dependencies of target plasma-discover-exporter[ 67%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/main.cpp.oScanning dependencies of target kns-backend[ 68%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSBackend.cpp.oScanning dependencies of target dummy-backend[ 69%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyResource.cpp.oScanning dependencies of target updatedummytest[ 70%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/updatedummytest.dir/__/__/__/tests/modeltest.cpp.o[ 71%] Linking CXX executable dummytest[ 71%] Built target dummytest[ 72%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyBackend.cpp.o[ 73%] Linking CXX executable knsbackendtest[ 74%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSResource.cpp.o[ 75%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/MuonExporter.cpp.o[ 75%] Built target knsbackendtest[

KDE CI: Plasma discover stable-kf5-qt5 SUSEQt5.9 - Build # 74 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20stable-kf5-qt5%20SUSEQt5.9/74/
 Project:
Plasma discover stable-kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 12 Feb 2018 17:05:09 +
 Build duration:
2 min 31 sec and counting
   CONSOLE OUTPUT
  [...truncated 175.39 KB...][ 14%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier.cpp.o[ 14%] Built target DiscoverCommon_autogenScanning dependencies of target DiscoverNotifierDeclarativePlugin[ 15%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/BackendNotifierFactory.cpp.o[ 16%] Linking CXX executable PaginateModelTest[ 17%] Linking CXX shared module DummyNotifier.so[ 17%] Built target PaginateModelTest[ 17%] Built target DummyNotifier[ 18%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifierDeclarativePlugin_autogen/mocs_compilation.cpp.o[ 19%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifierDeclarativePlugin.cpp.o[ 20%] Building CXX object notifier/CMakeFiles/DiscoverNotifierDeclarativePlugin.dir/DiscoverNotifier.cpp.o[ 21%] Linking CXX shared library libDiscoverNotifierDeclarativePlugin.so[ 21%] Built target DiscoverNotifierDeclarativePluginScanning dependencies of target DiscoverCommon[ 22%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/Category.cpp.o[ 23%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/Review.cpp.o[ 24%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/ReviewsModel.cpp.o[ 25%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/AddonList.cpp.o[ 26%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/Transaction.cpp.o[ 27%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/TransactionListener.cpp.o[ 28%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/TransactionModel.cpp.o[ 28%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/UpdateModel/UpdateItem.cpp.o[ 29%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/UpdateModel/UpdateModel.cpp.o[ 30%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/ResourcesModel.cpp.o[ 31%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/ResourcesProxyModel.cpp.o[ 32%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/PackageState.cpp.o[ 33%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/ResourcesUpdatesModel.cpp.o[ 34%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/StandardBackendUpdater.cpp.o[ 35%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/Rating.cpp.o[ 36%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/SourcesModel.cpp.o[ 37%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/AbstractReviewsBackend.cpp.o[ 38%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/AbstractResourcesBackend.cpp.o[ 39%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/AbstractResource.cpp.o[ 40%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/AbstractBackendUpdater.cpp.o[ 41%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/AbstractSourcesBackend.cpp.o[ 42%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/StoredResultsStream.cpp.o[ 42%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/DiscoverBackendsFactory.cpp.o[ 43%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ScreenshotsModel.cpp.o[ 44%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ApplicationAddonsModel.cpp.o[ 45%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/appstream/OdrsReviewsBackend.cpp.o[ 46%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/appstream/AppStreamIntegration.cpp.o[ 47%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/DiscoverCommon_autogen/mocs_compilation.cpp.o[ 48%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ActionsModel.cpp.o[ 50%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/CachedNetworkAccessManager.cpp.o[ 51%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/CategoriesReader.cpp.o[ 52%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/CategoryModel.cpp.o[ 53%] Linking CXX shared library libDiscoverCommon.so[ 53%] Built target DiscoverCommonScanning dependencies of target kns-backend_autogen[ 54%] Automatic MOC for target kns-backend[ 54%] Built target kns-backend_autogenScanning dependencies of target CategoriesTest_autogen[ 55%] Automatic MOC for target CategoriesTest[ 55%] Built target CategoriesTest_autogenScanning dependencies of target

KDE CI: Plasma discover stable-kf5-qt5 FreeBSDQt5.9 - Build # 62 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20discover%20stable-kf5-qt5%20FreeBSDQt5.9/62/
 Project:
Plasma discover stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 12 Feb 2018 17:13:09 +
 Build duration:
2 min 52 sec and counting
   JUnit Tests
  Name: (root) Failed: 9 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.appargFailed: TestSuite.appstreamUrlFailed: TestSuite.categoryargFailed: TestSuite.installFailed: TestSuite.missingResourceFailed: TestSuite.packageArgumentFailed: TestSuite.toplevelsFailed: TestSuite.updateandinstallFailed: TestSuite.wrongInput

KDE CI: Plasma discover stable-kf5-qt5 SUSEQt5.9 - Build # 75 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20discover%20stable-kf5-qt5%20SUSEQt5.9/75/
 Project:
Plasma discover stable-kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 12 Feb 2018 17:13:09 +
 Build duration:
3 min 51 sec and counting
   JUnit Tests
  Name: (root) Failed: 9 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: TestSuite.appargFailed: TestSuite.appstreamUrlFailed: TestSuite.categoryargFailed: TestSuite.installFailed: TestSuite.missingResourceFailed: TestSuite.packageArgumentFailed: TestSuite.toplevelsFailed: TestSuite.updateandinstallFailed: TestSuite.wrongInput
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report76%
(13/17)77%
(83/108)77%
(83/108)61%
(2790/4603)44%
(1490/3387)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdiscover90%
(9/10)90%
(9/10)52%
(317/612)34%
(127/372)discover.autotests100%
(1/1)100%
(1/1)100%
(93/93)53%
(48/90)exporter0%
(0/3)0%
(0/3)0%
(0/67)0%
(0/50)libdiscover70%
(7/10)70%
(7/10)60%
(147/245)49%
(95/192)libdiscover.Category100%
(5/5)100%
(5/5)63%
(140/223)43%
(98/226)libdiscover.ReviewsBackend100%
(8/8)100%
(8/8)62%
(141/227)66%
(50/76)libdiscover.Transaction63%
(5/8)63%
(5/8)44%
(127/286)36%
(50/139)libdiscover.UpdateModel100%
(4/4)100%
(4/4)79%
(144/182)64%
(58/90)libdiscover.appstream0%
(0/4)0%
(0/4)0%
(0/211)0%
(0/132)libdiscover.backends.DummyBackend91%
(10/11)91%
(10/11)73%
(199/273)69%
(95/137)libdiscover.backends.DummyBackend.tests100%
(3/3)100%
(3/3)96%
(246/255)52%
(205/396)libdiscover.backends.KNSBackend100%
(6/6)100%
(6/6)66%
(280/423)51%
(130/256)libdiscover.backends.KNSBackend.tests100%
(2/2)100%
(2/2)98%
(84/86)53%
(77/144)libdiscover.notifiers0%
(0/2)0%
(0/2)0%
(0/4)0%
(0/2)libdiscover.resources91%
(20/22)91%
(20/22)62%
(642/1039)44%
(332/757)libdiscover.tests100%
(3/3)100%
(3/3)85%
(230/272)51%
(125/244)notifier0%
  

Re: Plasma Wayland 5.13 Meeting time

[Roman Gilg]

Doodle Poll: https://doodle.com/poll/496zqb7bpritxxwu

It's always in the evening, such that Martin is able to join the meeting.

On Mon, Feb 12, 2018 at 5:19 PM, Marco Martin  wrote:
> Tomorrow i can try, but i probably can't make it
>
> On Mon, Feb 12, 2018 at 5:13 PM, Martin Flöser  wrote:
>> Am 2018-02-12 16:52, schrieb Roman Gilg:
>>>
>>> We had our regular Plasma 5.13 Kickoff meeting today. We discussed
>>> Wayland on 5.13 as well. There is probably still need for a separate
>>> meeting on how we want to push forward our Plasma Wayland session for
>>> 5.13.
>>>
>>> Is tomorrow, Tuesday the 18-02-12, 7pm Berlin time ok? On #plasma IRC.
>>
>>
>> I should probably be able to make it
>>
>> Cheers
>> Martin

D10438: increase left/right margin of menuitems

[Vlad Zagorodniy]

zzag added a comment.


  > But then that makes it a different patch, right ?
  
  Why?
  
  > Margins are not changed. What is changed is the allocated space for the 
menu item content, that always accommodate for the checkbox, and draws it 
whenever there is one.
  
  No, margins still have to be changed. I would like to have static margins but 
how to add space on the left side if there is no any menu items with a 
checkable widget? Maybe I'm missing something? I should have added the word 
reserved in quotes.
  
  > The first part of that tends to make the checkbox be closest to the edge. 
Are we thinking we should/not use icons in menus, keep the same?
  
  What do you mean?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10438: increase left/right margin of menuitems

[Vlad Zagorodniy]

zzag added a comment.


  In D10438#205007 , @anemeth wrote:
  
  > F5707729: .PNG 
  
  
  Did you change the left margin? Could you please test the left margin with 
values 20/24/28 and pick the best one?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10438: increase left/right margin of menuitems

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D10438#205041 , @zzag wrote:
  
  > > But then that makes it a different patch, right ?
  >
  > Why?
  
  
  Because I know the code: I wrote it.
  
  >> Margins are not changed. What is changed is the allocated space for the 
menu item content, that always accommodate for the checkbox, and draws it 
whenever there is one.
  > 
  > No, margins still have to be changed. I would like to have static margins 
but how to add space on the left side if there is no any menu items with a 
checkable widget? Maybe I'm missing something? I should have added the word 
reserved in quotes.
  
  This is incorrect.
  The only thing you need to change to accomodate for enough space for 
checkboxes on all menu items disregarding whether there is a checkbox or not is 
to comment the two calls to:
  
if( menuItemOption->menuHasCheckableItems )
  
  Thats a very small patch that requires no change to the margins.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10438: increase left/right margin of menuitems

[Alex Nemeth]

anemeth added a comment.


  In D10438#205042 , @zzag wrote:
  
  > Did you change the left margin? Could you please test the left margin with 
values 20/24/28 and pick the best one?
  
  
  I didn't change the margins previously, only applied the patch. Here are they 
changed now:
  F5707947: 20.PNG 
  20 looks better, but 28 looks centered.
  Since this is with icons + shortcuts disabled it should not be used as 
reference.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10438: increase left/right margin of menuitems

[Vlad Zagorodniy]

zzag updated this revision to Diff 27019.
zzag added a comment.


  reserve space for checkable widgets in menu items

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10438?vs=26980&id=27019

BRANCH
  menuitem-margins

REVISION DETAIL
  https://phabricator.kde.org/D10438

AFFECTED FILES
  kstyle/breezestyle.cpp

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10438: increase left/right margin of menuitems

[Vlad Zagorodniy]

zzag added a comment.


  How it currently looks:
  
  F5707975: 1.png 
  
  F5707978: 2.png 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10438: increase left/right margin of menuitems

[Alex Nemeth]

anemeth added a comment.


  @zzag Did you accidentally removed the changes in breeze.h and breezestyle.h? 
:)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10438: reserve space for checkable widgets in menu items

[Vlad Zagorodniy]

zzag retitled this revision from "increase left/right margin of menuitems" to 
"reserve space for checkable widgets in menu items".
zzag edited the summary of this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10438: reserve space for checkable widgets in menu items

[Vlad Zagorodniy]

zzag added a comment.


  In D10438#205118 , @anemeth wrote:
  
  > @zzag Did you accidentally removed the changes in breeze.h and 
breezestyle.h? :)
  
  
  Yes. There is no point to keep them.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10438: reserve space for checkable widgets in menu items

[Alex Nemeth]

anemeth added a comment.


  In D10438#205119 , @zzag wrote:
  
  > In D10438#205118 , @anemeth 
wrote:
  >
  > > @zzag Did you accidentally removed the changes in breeze.h and 
breezestyle.h? :)
  >
  >
  > Yes. There is no point to keep them.
  
  
  Whoops, I misunderstood your prev comment.
  I personally like this approach better than the previous.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10438: reserve space for checkable widgets in menu items

[Vlad Zagorodniy]

zzag added a comment.


  In D10438#205125 , @anemeth wrote:
  
  > Whoops, I misunderstood your prev comment.
  
  
  I've deleted changes in breeze.h and breezestyle.h on purpose.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10438: reserve space for checkable widgets in menu items

[Nathaniel Graham]

ngraham added a comment.


  +1 on this new approach.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10438: reserve space for checkable widgets in menu items

[Vlad Zagorodniy]

zzag edited the summary of this revision.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

Re: [plasma-devel] Plasma Maniphest tasks

[Jonathan Riddell]

discussed at meeting, I'll close them

On Sat, Feb 10, 2018 at 08:54:54AM -0700, Nate Graham wrote:
> Howdy Plasma folks,
> I'm noticing that the Plasma Maniphest tasks
> (https://phabricator.kde.org/project/view/35/) that have been
> completed aren't actually closed, just moved to a "done" category.
> What's the reason for this, and can we close them instead?
> 
> Nate

D10237: Bring back embedded top3 reviews on the ApplicationPage

[Aleix Pol Gonzalez]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:acf66dd18540: Bring back embedded top3 reviews on the 
ApplicationPage (authored by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10237?vs=26856&id=27020#toc

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10237?vs=26856&id=27020

REVISION DETAIL
  https://phabricator.kde.org/D10237

AFFECTED FILES
  discover/qml/ApplicationPage.qml
  discover/qml/ReviewDelegate.qml
  discover/qml/ReviewsPage.qml

To: apol, ngraham, #discover_software_store
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10237: Bring back embedded top3 reviews on the ApplicationPage

[Nathaniel Graham]

ngraham added a comment.


  [We will iterate over this incrementally since it's on master]

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10237

To: apol, ngraham, #discover_software_store
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10438: reserve space for checkable widgets in menu items

[Alex Nemeth]

anemeth added a comment.


  Maybe you could align the checkbox better?
  The numbers are pixels
  F5708060: a.png 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10471: Use Kirgami.ToolBarApplicationHeader instead of the view headers

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: ngraham.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Use the standard Kirigami component as header for Discover. Will need
  some polishing on the kirigami component but will pay off in the long
  run.
  
  BUG: 385973

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10471

AFFECTED FILES
  discover/qml/ApplicationsListPage.qml
  discover/qml/BrowsingPage.qml
  discover/qml/DiscoverWindow.qml
  discover/qml/InstalledPage.qml
  discover/qml/SourcesPage.qml
  discover/resources.qrc

To: apol, ngraham
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10463: [WIP/RFC] Consistently use a Toolbar for headers

[Aleix Pol Gonzalez]

apol added a comment.


  See https://phabricator.kde.org/D10471

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10463

To: ngraham, #discover_software_store, abetts, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10438: reserve space for checkable widgets in menu items

[Vlad Zagorodniy]

zzag added a comment.


  In D10438#205139 , @anemeth wrote:
  
  > Maybe you could align the checkbox better?
  >  The numbers are pixels
  >  F5708060: a.png 
  
  
  I don't really think this diff should mess with margins. I'd would like to 
leave it as it is right now. Maybe another diff should be created regarding 
checkbox spacing.
  
  ---
  
  Explanation behind numbers:
  
  - 4: it should be 3(marginwidth) + 1(measurement error?)
  - 9: 4(itemspacing) + 1 + 2[(20 - 16) / 2] + 2(icons have padding)
  - 8: 2[(20 - 16) / 2] + 4(itemspacing) + 1 + 1(measurement error?)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10438

To: zzag, #breeze, #vdg, ngraham, hpereiradacosta
Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget

[Piotr Kąkol]

piotrkakol updated this revision to Diff 27024.
piotrkakol retitled this revision from "Changed hexadecimal system to decimal 
for Binary Clock widget" to "Allow users to change the format to BCD (decimal) 
in Binary Clock widget".
piotrkakol edited the summary of this revision.
piotrkakol added a comment.


  Instead of changing the base to decimal I decided to allow users to choose 
between base 10 (BCD format) and 16 (sexagesimal format) in the config.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10434?vs=26898&id=27024

REVISION DETAIL
  https://phabricator.kde.org/D10434

AFFECTED FILES
  applets/binary-clock/package/contents/config/main.xml
  applets/binary-clock/package/contents/ui/BinaryClock.qml
  applets/binary-clock/package/contents/ui/DotColumn.qml
  applets/binary-clock/package/contents/ui/configGeneral.qml

To: piotrkakol
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

[Powerdevil] [Bug 358957] laptop won't hybrid-suspend when Plasma is running

[Andrei Slavoiu]

https://bugs.kde.org/show_bug.cgi?id=358957

--- Comment #20 from Andrei Slavoiu  ---
This bug is actually fixed for almost an year. The commit that fixed it was
made in March last year
https://cgit.kde.org/powerdevil.git/commit/?id=c6b76da7a67977deacadb65e6e9d1713e8b3f7b6
that added hybid-suspend as an option to the lid-close and power-button
actions.
But while the bug itself is closed, hybrid suspend is still not a first class
citizen in plasma, I suppose this is why the bug remained open. There is still
no way to trigger hybrid-suspend on demand (from the start menu or from the
logout applet).
BTW, I'm not a KDE developer and had nothing to do with the actual fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 358957] laptop won't hybrid-suspend when Plasma is running

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=358957

Nate Graham  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 CC||pointedst...@zoho.com
 Resolution|--- |FIXED

--- Comment #21 from Nate Graham  ---
Thanks for confirming! If we need another bug to track additional work, we
should do that.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Powerdevil bug help needed

[Ongun Kanat]

Is it okay for me to bump this.

I'm currently debugging my distros powerdevil package, since I'm
unable to run git version. Not a big deal, I can switch sources and
recompile for testing.

However I'm struggling to understand some bits in powerdevilbrightnesslogic.cpp:

#63 in BrightnessLogic::increased:
 int step = m_steps - (m_valueMax - m_value - 1) * m_steps / m_valueMax;
and #81 BrightnessLogic::decreased
 int step = (m_value - 1) * m_steps / m_valueMax;

It looks like a simple ratio equation yet, shouldn't #81 be like
(m_value * m_steps) / m_valueMax - 1;

Regards
-Ongun

On 8 February 2018 at 21:09, Ongun Kanat  wrote:
> It looks like I was wrong. I've ended up copying compiled service
> files into /usr/share/dbus-1 and I still couldn't trigger neither
> backlight notification nor powerdevil.
>
> dbus-monitor shows no activity either. On my regular plasma desktop I
> can see dbus messages like [1].
>
> I'm also including my configuration for further info
> [1] dbus-monitor output on my regular plasma 5.12 desktop
> https://paste.kde.org/pvc1b0wpw On my git build it is missing.
> [2] system-local.conf symlinked to /etc/dbus-1/system-local.conf
> https://paste.kde.org/pkvcmkz6s
> [3] session-local.conf symlinked to /etc/dbus-1/session-local.conf
> https://paste.kde.org/pfiwe84m7
> [4] .desktop file for xsession https://paste.kde.org/ph5r8agfy
> [5] runPlasma.sh https://paste.kde.org/p87wfff98
>
> Any clues?
>
> -Ongun
>
> On 8 February 2018 at 02:33, David Edmundson  
> wrote:
>>
>>
>> On Wed, Feb 7, 2018 at 10:47 PM, Ongun Kanat  wrote:
>>>
>>> Hello devs,
>>>
>>> I'm trying to contribute by fixing a small bug. I'm proficient with
>>> C++ and pretty much used to debug C++ programs with Qt Creator. I've
>>> managed to build full plasma desktop into a directory in my home using
>>> kdesrc-build. and set environment correctly  Now I can launch latest
>>> git version of plasma.
>>>
>>> I'm trying to fix a bug in Powerdevil (as i guess):
>>> https://bugs.kde.org/show_bug.cgi?id=371915
>>> It looks like a calculation error is being made somewhere but I
>>> couldn't trigger any breakpoint in powerdevil executable. Moreover on
>>> git version of plasma it seems like powerdevil is not be able to get
>>> any sort of brightness signal at all and the kernel's/framebuffer's
>>> standard brightness functionality seems to be triggered. I'm making
>>> this guess since the brightness notification is not being shown. On my
>>> distro's (Arch, pretty vanilla) version of plasma both notification
>>> and powerdevil works and xev displays brightness buttons correctly.
>>>
>>> Wandering the installed files in my build directory, I realized kdesrc
>>> have installed dbus-1/system-services folder into the install
>>> directory in my home directory as expected. And there's a dbus service
>>> file called org.kde.powerdevil.backlighthelper.service . I think this
>>> file doesn't get started since it's not in the real /usr/share/dbus-1
>>> folder. Instead the distro's version of it gets started which is
>>> incompatible and is not a part of my git build. Hence, no backlight
>>> signal has been gotten caught and transferred to org.kde.powerdevil
>>> service.
>>>
>>> So, my questions are:
>>> - Is my reasoning correct?
>>
>>
>> Certainly the part about it loading the distro version.
>> No idea about whether it's compatiable or not.
>>
>>> - If it's, is there any clean way to force dbus to launch the files in
>>> my build directory instead of /usr. Using an environment variable
>>> would be nice
>>
>>
>> Session bus, yes.
>>
>> System bus, not really. The problem is because it's run as root it's locked
>> down its paths for security. You can't just randomly source other places
>> You'll also have an equivalent problem with polkit actions and rules files
>> which you need here.
>>
>> You can modify system.conf  to add an include dir, but you'll need to do
>> that as root in your system supplied config file.
>>
>> I haven't found a good solution for the polkit problem without just adding
>> symlinks.
>>
>> David