D10438: increase left/right margin of menuitems

mmustac added a comment. I like the margins how they are at the moment and personally would increase it maximum by 5 px or so. The new margins shown in the screenshot are just too huge for my taste. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #br

D10429: Disable the title bar separator by default

broulik added a comment. Can't we make it a tri-state thing? Always on, heuristic (default, like we used to have), disabled? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10429 To: fvogt, #vdg, #plasma, ngraham Cc: broulik, anthonyfieroni, januz, rikmills, anemeth,

D10438: increase left/right margin of menuitems

zzag added a comment. @mmustac what about this? F5706606: without-checkboxes-10.png margins: - left: 10 - right: 4 - top,bottom: 3 --- > The new margins shown in the screenshot are just too huge for my taste. Well, it's ha

D10426: Applet: Fix accessing SourceModel from main item

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10426 To: drosca, #plasma, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jen

D10438: increase left/right margin of menuitems

fabianr added a comment. According to the HIG units.smallSpacing (4px) or units.largeSpacing (18px) or multiples of these should be used when ever possible, maybe it would make sense to uses these? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #bre

D10438: increase left/right margin of menuitems

hpereiradacosta added a comment. In D10438#204757 , @zzag wrote: > @mmustac what about this? > > F5706606: without-checkboxes-10.png > > margins: > > - left: 10 > - right: 4 > - top,bottom: 3

D10426: Applet: Fix accessing SourceModel from main item

This revision was automatically updated to reflect the committed changes. Closed by commit R115:fb789820c69e: Applet: Fix accessing SourceModel from main item (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10426?vs=2687

D10454: Translated all texts from the en directory so the extension works in es

antlarr created this revision. antlarr added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. antlarr requested review of this revision. REVISION SUMMARY The chromium extension wasn't working when LANG was set to spanis

D10454: Translated all texts from the en directory so the extension works in es

broulik added a comment. Thanks for the effort but there's a bug in the translation extraction script. In theory the translations should be extracted into regular po files by scripty, translated, and then put back in but that is clearly broken. REPOSITORY R856 Plasma Browser Integration R

D10434: Changed hexadecimal system to decimal for Binary Clock widget

davidedmundson added a comment. > I don't know if it was intended It's pretty clear this was a deliberate choice initially, not a bug, otherwise that startBit property wouldn't exist. > not an expected behavior from my perspective. I think you can make a valid case for either.

D10431: Properly handle move during touch events

davidedmundson accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin BRANCH touch-quick-tiling-5.12 REVISION DETAIL https://phabricator.kde.org/D10431 To: graesslin, #kwin, #plasma,

D10388: allow to have more than one default activity

davidedmundson added inline comments. INLINE COMMENTS > ivan wrote in Activities.cpp:233 > What do you mean by 'toggling' here? If the default is "activityA, activityB" I don't want clients (plasmashell) to start loading the layout for activityA and then start loading activityB. REPOSITORY R

D10429: Disable the title bar separator by default

mmustac added a comment. In D10429#204760 , @broulik wrote: > Can't we make it a tri-state thing? Always on, heuristic (default, like we used to have), disabled? Like that idea. REPOSITORY R31 Breeze REVISION DETAIL https://phabrica

D10456: Implement Tab/Backtab navigation

hein created this revision. hein added a reviewer: Plasma. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY I'd like this in the 5.12 branch as it also fixes a shell freeze. BUG:387316 REPOSITORY R119 Plasma Desktop BRANCH Plasma

D8917: Reduce the amount of spurious property changes on ColorScope

dfaure added inline comments. INLINE COMMENTS > colorscope.h:131 > +QObject *const m_parent; > +Plasma::Theme::ColorGroup m_actualGroup; > valgrind says this member isn't initialized, please fix. http://www.davidfaure.fr/2018/colorscope_valgrind_log.txt REPOSITORY R242 Plasma Frame

D10456: Implement Tab/Backtab navigation

hein updated this revision to Diff 26986. hein added a comment. Full Tab/Backtab nav also when searching. Ready for review now. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10456?vs=26984&id=26986 BRANCH Plasma/5.12 REVISION DETAIL https

Monday meeting notes

notes for 12/2/2018 present: Eike, Kai Uwe, Bhushan, Roman, Marco Eike * [Dashboard] Implemented missing Tab/Backtab keyboard nav in Dashboard (fixes a reported freeze bug on Shift+Tab along the way) * [TM] Fixed pinning apps when their .desktop file has spaces in the file name * [TM] Fixed crash

D10456: Implement Tab/Backtab navigation

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10456 To: hein, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts

D10388: allow to have more than one default activity

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in Activities.cpp:233 > If the default is "activityA, activityB" I don't want clients (plasmashell) > to start loading the layout for activityA and then start loading activityB. when i tested it it didn't seem to switch to the l

D10456: Implement Tab/Backtab navigation

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c85eb1aef49e: Implement Tab/Backtab navigation (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10456?vs=26986&id=26988 REVISION DETAIL

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

jtamate added a comment. In D10342#204465 , @jtamate wrote: > In https://phabricator.kde.org/D9840 I noticed a high i/o and cpu usage > when using the vivaldi browser, opening 10 tabs just caused a 40% cpu > usage. Now, opening 10 tabs or mo

D10459: Cards Dashboard Feature Added

Aiix created this revision. Aiix added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Aiix requested review of this revision. REVISION SUMMARY Ref T7175 Added cards dashboard feature

D10459: Cards Dashboard Feature Added

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R846:309de891c95c: Cards Dashboard Feature Added (authored by Aiix). REPOSITORY R846 Mycroft Plasma integration CHANGES

D10438: increase left/right margin of menuitems

januz added a comment. IMO, the last version looks better than the current menu. That said, I think the top/bottom paddings are still too tight, I would try adding 2-3px for each. It's true that there's a question of taste but more whitespace is generally a good thing (unless you go overboa

D10420: Make sure the FrameSvg and Svg instances have the right devicePixelRatio

apol added a comment. In D10420#204235 , @hein wrote: > Sanity check question: Did you make sure this doesn't introduce an extra render when things start up? (Initial vs. change.) > > Otherwise makes sense (and finally fixes some Wayland ugly

D10420: Make sure the FrameSvg and Svg instances have the right devicePixelRatio

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D10420 To: apol, #plasma, hein Cc: hein, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai,

D10420: Make sure the FrameSvg and Svg instances have the right devicePixelRatio

This revision was automatically updated to reflect the committed changes. Closed by commit R242:3e4b26452aeb: Make sure the FrameSvg and Svg instances have the right devicePixelRatio (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.

D10438: increase left/right margin of menuitems

hpereiradacosta added a comment. In D10438#204869 , @januz wrote: > IMO, the last version looks better than the current menu. That said, I think the top/bottom paddings are still too tight, I would try adding 2-3px for each. > It's true that

D10338: Don't show tooltips for inactive windows

McPain accepted this revision. McPain added a comment. This revision is now accepted and ready to land. This commit looks good and it works just as planned REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D10338 To: broulik, #plasma, graesslin, McPain

D10438: increase left/right margin of menuitems

hpereiradacosta added a comment. also see how in two the posted screenshots the checkmarks for checkable items is actually very close to the menu border. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta Cc: januz,

D10170: Added optional transparency/blur to menu frames

hpereiradacosta added a comment. last round of modifications: simplifications of the blurHelper class. Also, for the config ui, maybe it makes more sense to call the "Transparency" tab, only "Menus" and change "Menu:" into "Transparency:" Unless of course one wants to add transparency beh

D10461: WIP: GMenu-DBusMenu-Proxy

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This application finds windows using GTK GMenu DBus interfaces [1]

D10438: increase left/right margin of menuitems

hpereiradacosta added a comment. In D10438#204764 , @fabianr wrote: > According to the HIG units.smallSpacing (4px) or units.largeSpacing (18px) or multiples of these should be used when ever possible, maybe it would make sense to uses these?

D10461: WIP: GMenu-DBusMenu-Proxy

broulik updated this revision to Diff 26999. broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a comment. - Don't send random arguments to `Activate`, fixes toggle actions not working REPOSITORY R120 Plasma Workspace CHANGES SINCE LAS

D10461: WIP: GMenu-DBusMenu-Proxy

broulik edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10461 To: broulik, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10438: increase left/right margin of menuitems

zzag added a comment. Just to clarify that other DE and OS have some space on the left side: - Windows: https://forums.windowscentral.com/attachments/windows-8/48119d1382981718t-screenshot-1-.png - macOS: https://i.stack.imgur.com/h6LAN.png - elementaryOS: https://i.stack.imgur.com/2f

D10438: increase left/right margin of menuitems

zzag added a comment. In D10438#204884 , @hpereiradacosta wrote: > In anycase, increasing margins should then be made consistently accross the style and not one by one if you want to keep balance. No, it should not. This is a small chang

D10463: Consistently use a Toolbar for headers

ngraham created this revision. ngraham added reviewers: Discover Software Store, abetts, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 385973 Use a ToolBar for e

D10463: Consistently use a Toolbar for headers

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10463 To: ngraham, #discover_software_store, abetts, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mo

D10463: [WIP/RFC] Consistently use a Toolbar for headers

ngraham retitled this revision from "Consistently use a Toolbar for headers" to "[WIP/RFC] Consistently use a Toolbar for headers". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://pha

D10396: Support "phone" form factor

This revision was automatically updated to reflect the committed changes. Closed by commit R115:2b8fd79fbf14: Support "phone" form factor (authored by broulik). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10396?vs=26798&id=27003 REVISION

Re: 5.12 release: congratulations and post-mortem

Regarding QA of releases there is this task now: https://phabricator.kde.org/T7949 This will most likely touch the general release process as well. You are welcome to join the task as subscribers or with direct input. First we need to collect ideas how to improve our QA. On Tue, Feb 6, 2018 at 4

D10395: Use plasmoid.icon instead of Logic.icon()

This revision was automatically updated to reflect the committed changes. Closed by commit R97:2c5de6e121b5: Use plasmoid.icon instead of Logic.icon() (authored by broulik). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10395?vs=26795&id=27004 REVISION DETA

D10397: Use Qt.openUrlExternally instead of Kio

This revision was automatically updated to reflect the committed changes. Closed by commit R97:52d1950213b9: Use Qt.openUrlExternally instead of Kio (authored by broulik). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10397?vs=26799&id=27005 REVISION DETAIL

D10438: increase left/right margin of menuitems

anemeth added a comment. In D10438#204922 , @zzag wrote: > Just to clarify that other DE and OS have some space on the left side: > > - Windows: https://forums.windowscentral.com/attachments/windows-8/48119d1382981718t-screenshot-1-.png > -

D10463: [WIP/RFC] Consistently use a Toolbar for headers

apol added a comment. If we're to do this, I'd very much prefer to use kirigami's native header. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10463 To: ngraham, #discover_software_store, abetts, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai

Plasma Wayland 5.13 Meeting time

We had our regular Plasma 5.13 Kickoff meeting today. We discussed Wayland on 5.13 as well. There is probably still need for a separate meeting on how we want to push forward our Plasma Wayland session for 5.13. Is tomorrow, Tuesday the 18-02-12, 7pm Berlin time ok? On #plasma IRC.

D10463: [WIP/RFC] Consistently use a Toolbar for headers

ngraham added a comment. As long as it looks good on the desktop too (or we can make it look good on the desktop too), I'm okay with that. Does it look and behave acceptably right now? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10463 To: ngraha

D10170: Added optional transparency/blur to menu frames

anemeth marked an inline comment as done. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, colomar, alake Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moh

D10170: Added optional transparency/blur to menu frames

anemeth updated this revision to Diff 27008. anemeth added a comment. Simplified the breezeblurhelper class REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10170?vs=26814&id=27008 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10170 AFFECTED

Re: Plasma Wayland 5.13 Meeting time

Folks who have already ticked the poll at https://doodle.com/poll/8wwrt59dt8prz6pf On 12 February 2018 at 15:52, Roman Gilg wrote: > We had our regular Plasma 5.13 Kickoff meeting today. We discussed > Wayland on 5.13 as well. There is probably still need for a separate > meeting on how we want

D10170: Added optional transparency/blur to menu frames

anemeth added a comment. In D10170#204889 , @hpereiradacosta wrote: > Also, for the config ui, maybe it makes more sense to call the "Transparency" tab, only "Menus" and change "Menu:" into "Transparency:" > Unless of course one wants to add

D10170: Added optional transparency/blur to menu frames

hpereiradacosta added inline comments. INLINE COMMENTS > breezeblurhelper.cpp:45 > +QObject(parent), > +_helper(helper) > +{ helper argument is not needed > breezeblurhelper.h:53 > +//! constructor > +BlurHelper( QObject*, Helper& ); > + helper argument is n

D10438: increase left/right margin of menuitems

hpereiradacosta added a comment. In D10438#204960 , @anemeth wrote: > In D10438#204922 , @zzag wrote: > > > Just to clarify that other DE and OS have some space on the left side: > > > > - Windows

D10438: increase left/right margin of menuitems

hpereiradacosta added a comment. In D10438#204922 , @zzag wrote: > Just to clarify that other DE and OS have some space on the left side: > > - Windows: https://forums.windowscentral.com/attachments/windows-8/48119d1382981718t-screenshot-1-.p

D10438: increase left/right margin of menuitems

ngraham added a comment. We cannot ever remove the shortcuts from the menus, for countless usability reasons. Lack of discoverable keyboard shortcuts is one of the many productivity and ergonomic flaws of GNOME; we cannot regress to that level. in macOS, the shortcuts are more compact be

D10170: Added optional transparency/blur to menu frames

anemeth updated this revision to Diff 27010. anemeth added a comment. Removed the _helper variable from the breezeblurhelper class REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10170?vs=27008&id=27010 BRANCH master REVISION DETAIL https://phabricator.k

D10170: Added optional transparency/blur to menu frames

hpereiradacosta added a comment. In D10170#204976 , @anemeth wrote: > In D10170#204889 , @hpereiradacosta wrote: > > > Also, for the config ui, maybe it makes more sense to call the "Transparency" t

D10170: Added optional transparency/blur to menu frames

anemeth marked 4 inline comments as done. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10170 To: anemeth, hpereiradacosta, #plasma, colomar, alake Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moh

Re: Plasma Wayland 5.13 Meeting time

Am 2018-02-12 16:52, schrieb Roman Gilg: We had our regular Plasma 5.13 Kickoff meeting today. We discussed Wayland on 5.13 as well. There is probably still need for a separate meeting on how we want to push forward our Plasma Wayland session for 5.13. Is tomorrow, Tuesday the 18-02-12, 7pm Berl

D10170: Added optional transparency/blur to menu frames

anemeth added a comment. In D10170#205000 , @hpereiradacosta wrote: > Can you post an updated screenshot about the configuration option, and can we get VDG's opinion on it ? This is how it looks now F5707716: cvb.PNG

D10438: increase left/right margin of menuitems

abetts added a comment. How are we accounting for stacking menu items that have: Checkbox - Item Icon - Label -- Shortcut-Arrow Icon The first part of that tends to make the checkbox be closest to the edge. Are we thinking we should/not use icons in menus, keep the same? REPOSITORY

Re: Plasma Wayland 5.13 Meeting time

On Mon, Feb 12, 2018 at 04:52:00PM +0100, Roman Gilg wrote: > Is tomorrow, Tuesday the 18-02-12, 7pm Berlin time ok? On #plasma IRC. I want to attend but since there is already another meeting I've to attend tomrrow evening can we do wednesday maybe? Also as a general suggestion, maybe we can do

Re: Plasma Wayland 5.13 Meeting time

Tomorrow i can try, but i probably can't make it On Mon, Feb 12, 2018 at 5:13 PM, Martin Flöser wrote: > Am 2018-02-12 16:52, schrieb Roman Gilg: >> >> We had our regular Plasma 5.13 Kickoff meeting today. We discussed >> Wayland on 5.13 as well. There is probably still need for a separate >> mee

5.13 Kickoff Meeting

Thanks for the meeting folks, here's the minutes I extracted out of the log ** 5.12 was awesome but not yet perfect, aim for perfection where possible ** dependency requirements to be better defined and documented - action JR ** tosky to add JR to calendar in phab, plasma and hopefully frameworks

D10438: increase left/right margin of menuitems

anemeth added a comment. In D10438#205005 , @abetts wrote: > Are we thinking we should/not use icons in menus, keep the same? Looks quite good in my opinion with this patch applied and no icons F5707729: .PNG

D10438: increase left/right margin of menuitems

ngraham added a comment. Let's try to avoid radical proposals like getting rid of keyboard shortcuts and icons. For now, let's focus on the initial goal, or perhaps a slightly modified goal of adding room to put checkboxes to the left of the text (which I would support). REPOSITORY R31 Br

D10438: increase left/right margin of menuitems

abetts added a comment. In D10438#205009 , @ngraham wrote: > Let's try to avoid radical proposals like getting rid of keyboard shortcuts and icons. For now, let's focus on the initial goal, or perhaps a slightly modified goal of adding room to p

D10438: increase left/right margin of menuitems

zzag added a comment. In D10438#205009 , @ngraham wrote: > Let's try to avoid radical proposals like getting rid of keyboard shortcuts and icons. For now, let's focus on the initial goal, or perhaps a slightly modified goal of adding room to put

D10388: allow to have more than one default activity

ivan added inline comments. INLINE COMMENTS > mart wrote in Activities.cpp:233 > when i tested it it didn't seem to switch to the latest created one without > an explicit setCurrentActivity? @davidedmundson Haven't looked at that part of Plasma for some time, but I see no reason why it would d

D10438: increase left/right margin of menuitems

ngraham added a comment. In D10438#205010 , @abetts wrote: > In D10438#205009 , @ngraham wrote: > > > Let's try to avoid radical proposals like getting rid of keyboard shortcuts and icons. For now,

KDE CI: Plasma discover stable-kf5-qt5 FreeBSDQt5.9 - Build # 61 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20stable-kf5-qt5%20FreeBSDQt5.9/61/ Project: Plasma discover stable-kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 12 Feb 2018 17:05:09 + Build duration: 2 min 20 sec and counting CONSOLE OU

KDE CI: Plasma discover stable-kf5-qt5 SUSEQt5.9 - Build # 74 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20stable-kf5-qt5%20SUSEQt5.9/74/ Project: Plasma discover stable-kf5-qt5 SUSEQt5.9 Date of build: Mon, 12 Feb 2018 17:05:09 + Build duration: 2 min 31 sec and counting CONSOLE OUTPUT

KDE CI: Plasma discover stable-kf5-qt5 FreeBSDQt5.9 - Build # 62 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20discover%20stable-kf5-qt5%20FreeBSDQt5.9/62/ Project: Plasma discover stable-kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 12 Feb 2018 17:13:09 + Build duration: 2 min 52 sec and counting JUnit Tes

KDE CI: Plasma discover stable-kf5-qt5 SUSEQt5.9 - Build # 75 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20discover%20stable-kf5-qt5%20SUSEQt5.9/75/ Project: Plasma discover stable-kf5-qt5 SUSEQt5.9 Date of build: Mon, 12 Feb 2018 17:13:09 + Build duration: 3 min 51 sec and counting JUnit Tests

Re: Plasma Wayland 5.13 Meeting time

Doodle Poll: https://doodle.com/poll/496zqb7bpritxxwu It's always in the evening, such that Martin is able to join the meeting. On Mon, Feb 12, 2018 at 5:19 PM, Marco Martin wrote: > Tomorrow i can try, but i probably can't make it > > On Mon, Feb 12, 2018 at 5:13 PM, Martin Flöser wrote: >> Am

D10438: increase left/right margin of menuitems

zzag added a comment. > But then that makes it a different patch, right ? Why? > Margins are not changed. What is changed is the allocated space for the menu item content, that always accommodate for the checkbox, and draws it whenever there is one. No, margins still have to be

D10438: increase left/right margin of menuitems

zzag added a comment. In D10438#205007 , @anemeth wrote: > F5707729: .PNG Did you change the left margin? Could you please test the left margin with values 20/24/28 and pick the best one? RE

D10438: increase left/right margin of menuitems

hpereiradacosta added a comment. In D10438#205041 , @zzag wrote: > > But then that makes it a different patch, right ? > > Why? Because I know the code: I wrote it. >> Margins are not changed. What is changed is the allocated spac

D10438: increase left/right margin of menuitems

anemeth added a comment. In D10438#205042 , @zzag wrote: > Did you change the left margin? Could you please test the left margin with values 20/24/28 and pick the best one? I didn't change the margins previously, only applied the patch. H

D10438: increase left/right margin of menuitems

zzag updated this revision to Diff 27019. zzag added a comment. reserve space for checkable widgets in menu items REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10438?vs=26980&id=27019 BRANCH menuitem-margins REVISION DETAIL https://phabricator.kde.org/

D10438: increase left/right margin of menuitems

zzag added a comment. How it currently looks: F5707975: 1.png F5707978: 2.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta

D10438: increase left/right margin of menuitems

anemeth added a comment. @zzag Did you accidentally removed the changes in breeze.h and breezestyle.h? :) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel

D10438: reserve space for checkable widgets in menu items

zzag retitled this revision from "increase left/right margin of menuitems" to "reserve space for checkable widgets in menu items". zzag edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradac

D10438: reserve space for checkable widgets in menu items

zzag added a comment. In D10438#205118 , @anemeth wrote: > @zzag Did you accidentally removed the changes in breeze.h and breezestyle.h? :) Yes. There is no point to keep them. REPOSITORY R31 Breeze REVISION DETAIL https://phabricat

D10438: reserve space for checkable widgets in menu items

anemeth added a comment. In D10438#205119 , @zzag wrote: > In D10438#205118 , @anemeth wrote: > > > @zzag Did you accidentally removed the changes in breeze.h and breezestyle.h? :) > > > Yes.

D10438: reserve space for checkable widgets in menu items

zzag added a comment. In D10438#205125 , @anemeth wrote: > Whoops, I misunderstood your prev comment. I've deleted changes in breeze.h and breezestyle.h on purpose. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D1

D10438: reserve space for checkable widgets in menu items

ngraham added a comment. +1 on this new approach. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreute

D10438: reserve space for checkable widgets in menu items

zzag edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta Cc: januz, fabianr, mmustac, abetts, anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas

Re: [plasma-devel] Plasma Maniphest tasks

discussed at meeting, I'll close them On Sat, Feb 10, 2018 at 08:54:54AM -0700, Nate Graham wrote: > Howdy Plasma folks, > I'm noticing that the Plasma Maniphest tasks > (https://phabricator.kde.org/project/view/35/) that have been > completed aren't actually closed, just moved to a "done" catego

D10237: Bring back embedded top3 reviews on the ApplicationPage

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:acf66dd18540: Bring back embedded top3 reviews on the ApplicationPage (authored by apol). CHANGED PRIOR TO COMMIT ht

D10237: Bring back embedded top3 reviews on the ApplicationPage

ngraham added a comment. [We will iterate over this incrementally since it's on master] REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10237 To: apol, ngraham, #discover_software_store Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mo

D10438: reserve space for checkable widgets in menu items

anemeth added a comment. Maybe you could align the checkbox better? The numbers are pixels F5708060: a.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta Cc:

D10471: Use Kirgami.ToolBarApplicationHeader instead of the view headers

apol created this revision. apol added a reviewer: ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Use the standard Kirigami component as header for Discover. Will need so

D10463: [WIP/RFC] Consistently use a Toolbar for headers

apol added a comment. See https://phabricator.kde.org/D10471 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10463 To: ngraham, #discover_software_store, abetts, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

D10438: reserve space for checkable widgets in menu items

zzag added a comment. In D10438#205139 , @anemeth wrote: > Maybe you could align the checkbox better? > The numbers are pixels > F5708060: a.png I don't really think this diff should

D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget

piotrkakol updated this revision to Diff 27024. piotrkakol retitled this revision from "Changed hexadecimal system to decimal for Binary Clock widget" to "Allow users to change the format to BCD (decimal) in Binary Clock widget". piotrkakol edited the summary of this revision. piotrkakol added a

[Powerdevil] [Bug 358957] laptop won't hybrid-suspend when Plasma is running

https://bugs.kde.org/show_bug.cgi?id=358957 --- Comment #20 from Andrei Slavoiu --- This bug is actually fixed for almost an year. The commit that fixed it was made in March last year https://cgit.kde.org/powerdevil.git/commit/?id=c6b76da7a67977deacadb65e6e9d1713e8b3f7b6 that added hybid-suspend

[Powerdevil] [Bug 358957] laptop won't hybrid-suspend when Plasma is running

https://bugs.kde.org/show_bug.cgi?id=358957 Nate Graham changed: What|Removed |Added Status|CONFIRMED |RESOLVED CC|

Re: Powerdevil bug help needed

Is it okay for me to bump this. I'm currently debugging my distros powerdevil package, since I'm unable to run git version. Not a big deal, I can switch sources and recompile for testing. However I'm struggling to understand some bits in powerdevilbrightnesslogic.cpp: #63 in BrightnessLogic::inc

  1   2   >