Re: Unable to use New Review Request to create requests with parent diffs

2014-06-30 Thread Bruce Cran
I've used NSIS in the past and I really don't like it: I've found it can lead to fragile setup packages. You may be able to use the free Visual Studio 2013 Express with WiX after installing Update 2 to avoid having to purchase a copy. To build the installer, you'd just run msbuild /m

Re: Unable to use New Review Request to create requests with parent diffs

2014-06-26 Thread Christian Hammond
I looked into the Windows installer. I love the idea of getting one in, but at the moment, neither of us have Visual Studio, so we need to figure out if we want that as a dependency or if we want to evaluate something else (like NSIS). There’s also the matter of integrating this with our build

Re: Unable to use New Review Request to create requests with parent diffs

2014-06-25 Thread Bruce Cran
Thanks! I've started committing .reviewboardrc files to each repo. I was slightly worried about the server changing, but it's simple enough to add a CNAME so things don't break. Is there anything I can do to help get the Windows installer patch committed and not forgotten about (presuming it's

Re: Unable to use New Review Request to create requests with parent diffs

2014-06-20 Thread Bruce Cran
Am I correct in thinking that a good practice would be to have users enter the reviewboard.url setting in their mercurial.ini/.hgrc files and have a .reviewboardrc file with just a REPOSITORY line committed to the repository, to avoid RBTools having to search for a matching repo in RB each time?

Re: Unable to use New Review Request to create requests with parent diffs

2014-06-20 Thread Stephen Gallagher
On 06/20/2014 03:08 PM, Bruce Cran wrote: Am I correct in thinking that a good practice would be to have users enter the reviewboard.url setting in their mercurial.ini/.hgrc files and have a .reviewboardrc file with just a REPOSITORY line committed to the repository, to avoid RBTools having to

Re: Unable to use New Review Request to create requests with parent diffs

2014-06-17 Thread Sara Rayburn
Well, we were able to get things working with RB Tools after a fashion. The rbt setup-repo command always failed to find the repository, returning an error 500. If we run rbt post --repository=foo, however, everything works fine. I think the setup-repo command either fails because we do not have

Re: Unable to use New Review Request to create requests with parent diffs

2014-06-17 Thread Bruce Cran
Yeah, I've found that setup-repo doesn't work for us either. For now I always use both --server and --repository, though I should just do the setup manually. With RBTools 0.6.1, setup-repo asks about 3 repos (whether they're the one I want to use) but they're all wrong. -- Bruce On Tue, Jun

Re: Unable to use New Review Request to create requests with parent diffs

2014-06-17 Thread Christian Hammond
What type of repository is it? It’d be really helpful to have the Path and Mirror Path fields from the desired Repository entry, and have the URL you use locally to check out the repository, so that we can figure out what’s going wrong. Christian --  Christian Hammond - 

Re: Unable to use New Review Request to create requests with parent diffs

2014-06-17 Thread Sara Rayburn
Hi Christian, All of our repos are mercurial repos. An example Path would be /data_local/hg-repository/foo. The mirror path is unused and unconfigured in all cases. We clone from ssh://devel.ourserver.com//devel/src/hg-repository/foo On Tue, Jun 17, 2014 at 2:22 PM, Christian Hammond

Re: Unable to use New Review Request to create requests with parent diffs

2014-06-17 Thread Christian Hammond
Hi Sara, Okay, that’s why. ‘rbt setup-repo’ is really intended for the typical case where the paths more or less match up. If your Path or Mirror Path looked like the ssh:// URL, they would have been found. Christian --  Christian Hammond - christ...@beanbaginc.com Review Board - 

Re: Unable to use New Review Request to create requests with parent diffs

2014-06-17 Thread Sara Rayburn
That makes sense. It would be nice to see a section in the RB Tools setup documentation about what to do if the setup-repo command fails. I'm not worried about it on our end. On Tue, Jun 17, 2014 at 2:42 PM, Christian Hammond christ...@beanbaginc.com wrote: Hi Sara, Okay, that’s why. ‘rbt

Re: Unable to use New Review Request to create requests with parent diffs

2014-06-17 Thread Bruce Cran
Isn't this covered in http://www.reviewboard.org/docs/rbtools/0.6/rbt/configuration/ ? -- Bruce On Tue, Jun 17, 2014 at 1:49 PM, Sara Rayburn sararayb...@gmail.com wrote: That makes sense. It would be nice to see a section in the RB Tools setup documentation about what to do if the

Re: Unable to use New Review Request to create requests with parent diffs

2014-06-17 Thread Sara Rayburn
Hi Bruce, Nowhere does that documentation refer to the fact that setup-repo will often fail with less than useful errors. I think that the error should be more useful (error 500 is not super helpful for the person trying to run the setup command) and that the docs should mention that setup-repo

Re: Unable to use New Review Request to create requests with parent diffs

2014-06-17 Thread Bruce Cran
I agree, http 500 isn't at all useful: I think on my setup I was always seeing an error saying there were no matching repositories found. Christian's mention of Mirror Path was the hint I needed to look up the documentation - from there I realised that entering the ssh:// URL that developers use

Re: Unable to use New Review Request to create requests with parent diffs

2014-06-16 Thread Sara Rayburn
Hi, Bruce, the installer works for our Windows guys just fine. Thanks for putting that together! Unfortunately, we can't seem to get RB Tools configured properly for anyone, but that's a question for another day. Sara On Sat, Jun 14, 2014 at 8:00 PM, Christian Hammond christ...@beanbaginc.com

Re: Unable to use New Review Request to create requests with parent diffs

2014-06-16 Thread Christian Hammond
What’s going wrong with the configuration? Christian --  Christian Hammond - christ...@beanbaginc.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 16, 2014 at 11:52:02 AM, Sara Rayburn (sararayb...@gmail.com) wrote: Hi, Bruce, the installer works

Re: Unable to use New Review Request to create requests with parent diffs

2014-06-14 Thread Bruce Cran
I've put together an RBTools installer for Windows for testing that adds only the rbt command to the environment (i.e. it doesn't pollute %PATH% with python.exe etc.). It's available from http://bluestop.org/rbtools/RBTools-0.6.1.exe - I'd welcome any feedback. It _should_ work on Windows XP and

Re: Unable to use New Review Request to create requests with parent diffs

2014-06-14 Thread Christian Hammond
Hi Bruce, That’s fantastic. I just installed in a fresh VM, and had RBTools up-and-running in just a couple minutes. Would you be willing to contribute the source to the installer? I’d like to ship an official installer with our future releases. Christian --  Christian Hammond - 

Re: Unable to use New Review Request to create requests with parent diffs

2014-06-14 Thread Bruce Cran
Christian, Yes, I was hoping I'd be able to contribute the code to make future maintenance simpler. Which repo and in which directory would it be added? I see there's a old rb-win32-installer repository on github for Review Board - would it be there, or under contrib/ in the rbtools repo etc.?

Re: Unable to use New Review Request to create requests with parent diffs

2014-06-14 Thread Christian Hammond
Awesome :) Under rbtools/contrib/installer/ would probably be best. We may end up moving it, but that’s ag ood starting point. rb-win32-installer is an old repository that can be pretty much ignored at this point. Christian --  Christian Hammond - christ...@beanbaginc.com Review Board - 

Re: Unable to use New Review Request to create requests with parent diffs

2014-06-13 Thread Sara Rayburn
Hi David, The biggest problem with RB Tools for our windows users is that it requires Python 2.7, and they are running Python 3 for other services. They've tried having both installed with no success. I think it would be a good decision to restore parent diff support to the New Review Request

Re: Unable to use New Review Request to create requests with parent diffs

2014-06-13 Thread Bruce Cran
It sounds like there might be a need for a standalone RBTools package for Windows, created using something like cx_freeze? -- Bruce On Fri, Jun 13, 2014 at 7:37 AM, Sara Rayburn sararayb...@gmail.com wrote: Hi David, The biggest problem with RB Tools for our windows users is that it

Re: Unable to use New Review Request to create requests with parent diffs

2014-06-13 Thread David Trowbridge
We've been wanting to do something like that for some time. -David On Jun 13, 2014, at 7:22 AM, Bruce Cran bruce.c...@gmail.com wrote: It sounds like there might be a need for a standalone RBTools package for Windows, created using something like cx_freeze? -- Bruce On Fri, Jun

Unable to use New Review Request to create requests with parent diffs

2014-06-12 Thread Sara Rayburn
Most of our users use hg postreview to create review requests, but our windows users prefer to use the site's New Review Request upload tool. In RB 1.7.x, there was an option to upload both a diff and a parent diff. This is no longer an option. Is there still a way to use the web tool to create

Re: Unable to use New Review Request to create requests with parent diffs

2014-06-12 Thread David Trowbridge
Sara, Is the reluctance just that installing python stuff on Windows is hard, or are there other concerns? It might be nice to add parent diff support to the New Review Request page, but we'd need to do some redesign to fit it in with the new workflow, which is really designed to handle basic