date:20090320

I imagine we're trying to detect if it's a clearcase repository and
something with the locale is causing us to fail incorrectly. Possibly a
locale-related issue. What does Le fichier spÚcifiÚ est introuvable
translate to in English?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Fri, Mar 20, 2009 at 10:07 AM, Laurent Dufréchou 
laurent.dufrec...@gmail.com wrote:


 Hum yeah...
 I've set up a svn repos in the web interface.
 But I access it usually via svn://

 (I never heard of Clear Case SCM until now :) )

  -Message d'origine-
  De : reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com]
  De la part de Bartlomiej Celary
  Envoyé : vendredi 20 mars 2009 14:33
  À : reviewboard@googlegroups.com
  Objet : Re: Cleartool missing + Svn access issue ?
 
 
  Are you using a Clear Case SCM? Cleartool is the tool needed to manage
  this kind of repo.
 
  If not that means the post-review gives a false positive for a
  clearcase repo instead of detecting subversion (I presume this is what
  you actually need). Are you sure you are in a subversion repository?
 
  Bartek
 
  2009/3/20 laurent.dufrec...@gmail.com laurent.dufrec...@gmail.com:
  
   Hello ,
   in my quest to make reviewboard i've got these issues:
   1)using post-review.py under windows got this:
   cleartool pwv -short
   Traceback (most recent call last):
File C:\Users\ldufrechou\Desktop\post-review.py, line 2312, in
   module
  main(sys.argv[1:])
File C:\Users\ldufrechou\Desktop\post-review.py, line 2253, in
   main
  repository_info, tool = determine_client()
File C:\Users\ldufrechou\Desktop\post-review.py, line 2205, in
   determine_client
  repository_info = tool.get_repository_info()
File C:\Users\ldufrechou\Desktop\post-review.py, line 744, in
   get_repository_info
  self.viewinfo = execute([cleartool, pwv, -short])
File C:\Users\ldufrechou\Desktop\post-review.py, line 1888, in
   execute
  env=env)
File C:\python25\lib\subprocess.py, line 594, in __init__
  errread, errwrite)
File C:\python25\lib\subprocess.py, line 816, in _execute_child
  startupinfo)
   WindowsError: [Error 2] Le fichier spÚcifiÚ est introuvable
  
   It don't know where is cleartool and I also don't get any idea too.
   Do I missed to install something? Looking on google I've something
   related to rational rose
  
   2) I've posted a review directly via the web interface giving a .diff
   file.
   Clicking on view diff, I get a blank page.
   I suspect that review board could not connect to svn repos.
   How can I check communication? Is there any log somewhere to see
   authentication failure?
   Does it support svn acces via : svn://svn.mycompany.com/xxx/ ?
  
   Thx for any help  :)
  
  
  
  
  
   
  
 
 

 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Small UI feature request: 2 new fields

I missed this e-mail entirely. Sorry about that.

We have no plans to add additional fields to Review Board. Custom fields are
often very dependent on the company that wants them, and it's not easy to
just add them directly in the codebase. However, after 1.0, we're putting in
support for extensions, and it should be possible at that time to add custom
fields. It's a little ways down the line, as we need to finish 1.0 first,
but that's getting much closer now.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Fri, Mar 20, 2009 at 7:45 AM, Sebastien Douche sdou...@gmail.com wrote:


 On Fri, Feb 20, 2009 at 16:57, Sebastien Douche sdou...@gmail.com wrote:
  1. field dependency
  2. field state

 No success for my proposal ;(. Now I need 4 new fields, how adding them?

 --
 Sebastien Douche sdou...@gmail.com

 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Cleartool missing + Svn access issue ?

The .reviewboardrc is needed for specifying which server to use, but really
this should be done through a property on the SVN server. See the docs in
the script for details on setting this up.

However, .reviewboardrc isn't related to this. The problem is that we're
attempting to execute the clearcase tool in order to see if 1) it's
available and 2) this is a clearcase repository. We do these scans with lots
of tools. What's odd about this one is that we're actually getting an error
back that we don't expect. The call we use *should* return an error code,
not an exception.

Where did you install your Python from?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Fri, Mar 20, 2009 at 12:29 PM, Laurent Dufrechou 
laurent.dufrec...@gmail.com wrote:

 It means File not found
 By the way taking  a look  @ python script I've seen that it look after a
 .reviewboardrc file.

 the fact is i use the script on windows pc client that is not the server.
 So perhaps someone could say me where i can find this file that must me
 configured I think?
 Sorry I fall in all the newbies trap
 :)



 2009/3/20 Christian Hammond chip...@chipx86.com

 I imagine we're trying to detect if it's a clearcase repository and
 something with the locale is causing us to fail incorrectly. Possibly a
 locale-related issue. What does Le fichier spÚcifiÚ est introuvable
 translate to in English?

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.review-board.org
 VMware, Inc. - http://www.vmware.com



 On Fri, Mar 20, 2009 at 10:07 AM, Laurent Dufréchou 
 laurent.dufrec...@gmail.com wrote:


 Hum yeah...
 I've set up a svn repos in the web interface.
 But I access it usually via svn://

 (I never heard of Clear Case SCM until now :) )

  -Message d'origine-
  De : reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com
 ]
  De la part de Bartlomiej Celary
  Envoyé : vendredi 20 mars 2009 14:33
  À : reviewboard@googlegroups.com
  Objet : Re: Cleartool missing + Svn access issue ?
 
 
  Are you using a Clear Case SCM? Cleartool is the tool needed to manage
  this kind of repo.
 
  If not that means the post-review gives a false positive for a
  clearcase repo instead of detecting subversion (I presume this is what
  you actually need). Are you sure you are in a subversion repository?
 
  Bartek
 
  2009/3/20 laurent.dufrec...@gmail.com laurent.dufrec...@gmail.com:
  
   Hello ,
   in my quest to make reviewboard i've got these issues:
   1)using post-review.py under windows got this:
   cleartool pwv -short
   Traceback (most recent call last):
File C:\Users\ldufrechou\Desktop\post-review.py, line 2312, in
   module
  main(sys.argv[1:])
File C:\Users\ldufrechou\Desktop\post-review.py, line 2253, in
   main
  repository_info, tool = determine_client()
File C:\Users\ldufrechou\Desktop\post-review.py, line 2205, in
   determine_client
  repository_info = tool.get_repository_info()
File C:\Users\ldufrechou\Desktop\post-review.py, line 744, in
   get_repository_info
  self.viewinfo = execute([cleartool, pwv, -short])
File C:\Users\ldufrechou\Desktop\post-review.py, line 1888, in
   execute
  env=env)
File C:\python25\lib\subprocess.py, line 594, in __init__
  errread, errwrite)
File C:\python25\lib\subprocess.py, line 816, in _execute_child
  startupinfo)
   WindowsError: [Error 2] Le fichier spÚcifiÚ est introuvable
  
   It don't know where is cleartool and I also don't get any idea too.
   Do I missed to install something? Looking on google I've something
   related to rational rose
  
   2) I've posted a review directly via the web interface giving a .diff
   file.
   Clicking on view diff, I get a blank page.
   I suspect that review board could not connect to svn repos.
   How can I check communication? Is there any log somewhere to see
   authentication failure?
   Does it support svn acces via : svn://svn.mycompany.com/xxx/ ?
  
   Thx for any help  :)
  
  
  
  
  
   
  
 
 







 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Cleartool missing + Svn access issue ?

By the way .reviewboardrc for the filename of config name is not good for
portability because under windows you can't '.reviewboardrc'
It absolutely want somthin like .yy or  :(
perhaps alowing a second name for windows could be a good idea too.

somethong like reviewboardrc.conf.

If you want I can modify the script to work under windows (with .conf  + try
catch for subprocess) and send it back to you.


2009/3/20 Laurent Dufrechou laurent.dufrec...@gmail.com

 More like an active state like:
 http://www.pythonxy.com/foreword_fr.php

 I think this is more because of i'm under vista business SP1.
 I've run in same bug under ipython wednesday.
 A subprocess couldn't be called due to UAC (other issue but related to
 subprocess) and it raised Windows Error.
 So seems subprocess rise this sort of error when it see that the subprocess
 call exist with failure.

 Perhpas more related to Vista vs XP?


 2009/3/20 Christian Hammond chip...@chipx86.com

 post-review doesn't require clearcase, and the code that was being run
 there is the test for whether or not you had it. What should have happened
 is that we'd see the failure (as a return code, not an exception) and then
 we'd just silently skip it. The thing is, on your Windows Python install for
 whatever reason, we're getting the exception instead of the return code.

 We can definitely do a try/except around the subprocess.Popen call, and
 then just fake an error return code. I'm just wondering why this is
 happening in the first place on your system, since I know many other people
 use post-review on Windows and haven't complained about it.

 When you say the python(x,y) distribution, do you mean specifically the
 Python installer on python.org, or are you using something like
 ActiveState's Python install?

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.review-board.org
 VMware, Inc. - http://www.vmware.com


 On Fri, Mar 20, 2009 at 1:24 PM, Laurent Dufrechou 
 laurent.dufrec...@gmail.com wrote:

 python - from python(x,y) distribution. this is a python 2.5.2.
 Json as been installed from setuptools.

 The fact is as I don't have clearcase on my computer, it could not detetc
 the tool, so it should warn the user that it could'nt do the test I think.
 This is not related to python, but more dur to the fact taht my windows
 clinet knows nothing about clearcase.
 (you can catch it with try: except WindowsError: but then I don't now how
 to says there was a failure, perhpas raisng another exeption and cathcing it
 in higher level?)

 I will definitvely read the doc, and setup a property for svn.

 will come after some tries.

 Laurent


 2009/3/20 Christian Hammond chip...@chipx86.com

 The .reviewboardrc is needed for specifying which server to use, but
 really this should be done through a property on the SVN server. See the
 docs in the script for details on setting this up.

 However, .reviewboardrc isn't related to this. The problem is that we're
 attempting to execute the clearcase tool in order to see if 1) it's
 available and 2) this is a clearcase repository. We do these scans with 
 lots
 of tools. What's odd about this one is that we're actually getting an error
 back that we don't expect. The call we use *should* return an error code,
 not an exception.

 Where did you install your Python from?

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.review-board.org
 VMware, Inc. - http://www.vmware.com


 On Fri, Mar 20, 2009 at 12:29 PM, Laurent Dufrechou 
 laurent.dufrec...@gmail.com wrote:

 It means File not found
 By the way taking  a look  @ python script I've seen that it look after
 a .reviewboardrc file.

 the fact is i use the script on windows pc client that is not the
 server. So perhaps someone could say me where i can find this file that 
 must
 me configured I think?
 Sorry I fall in all the newbies trap
 :)



 2009/3/20 Christian Hammond chip...@chipx86.com

 I imagine we're trying to detect if it's a clearcase repository and
 something with the locale is causing us to fail incorrectly. Possibly a
 locale-related issue. What does Le fichier spÚcifiÚ est introuvable
 translate to in English?

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.review-board.org
 VMware, Inc. - http://www.vmware.com



 On Fri, Mar 20, 2009 at 10:07 AM, Laurent Dufréchou 
 laurent.dufrec...@gmail.com wrote:


 Hum yeah...
 I've set up a svn repos in the web interface.
 But I access it usually via svn://

 (I never heard of Clear Case SCM until now :) )

  -Message d'origine-
  De : reviewboard@googlegroups.com [mailto:
 reviewbo...@googlegroups.com]
  De la part de Bartlomiej Celary
  Envoyé : vendredi 20 mars 2009 14:33
  À : reviewboard@googlegroups.com
  Objet : Re: Cleartool missing + Svn access issue ?
 
 
  Are you using a Clear Case SCM? Cleartool is the tool needed to
 manage
  this kind of repo.
 
  If not that means the

Re: Cleartool missing + Svn access issue ?

Just tested under linux got this execption:

Traceback (most recent call last):
  File ./post-review, line 2312, in module
main(sys.argv[1:])
  File ./post-review, line 2253, in main
repository_info, tool = determine_client()
  File ./post-review, line 2205, in determine_client
repository_info = tool.get_repository_info()
  File ./post-review, line 744, in get_repository_info
self.viewinfo = execute([cleartool, pwv, -short])
  File ./post-review, line 1897, in execute
env=env)
  File /usr/lib/python2.5/subprocess.py, line 594, in __init__
errread, errwrite)
  File /usr/lib/python2.5/subprocess.py, line 1147, in _execute_child
raise child_exception
OSError: [Errno 2] No such file or directory

So under linux it raise an OSError.

To be clear I really misuse the script as I launch it on a directory where
there is nothing else, but well it should catch the exception I think.


2009/3/20 Laurent Dufrechou laurent.dufrec...@gmail.com

 By the way .reviewboardrc for the filename of config name is not good for
 portability because under windows you can't '.reviewboardrc'
 It absolutely want somthin like .yy or  :(
 perhaps alowing a second name for windows could be a good idea too.

 somethong like reviewboardrc.conf.

 If you want I can modify the script to work under windows (with .conf  +
 try catch for subprocess) and send it back to you.


 2009/3/20 Laurent Dufrechou laurent.dufrec...@gmail.com

 More like an active state like:
 http://www.pythonxy.com/foreword_fr.php

 I think this is more because of i'm under vista business SP1.
 I've run in same bug under ipython wednesday.
 A subprocess couldn't be called due to UAC (other issue but related to
 subprocess) and it raised Windows Error.
 So seems subprocess rise this sort of error when it see that the
 subprocess call exist with failure.

 Perhpas more related to Vista vs XP?


 2009/3/20 Christian Hammond chip...@chipx86.com

 post-review doesn't require clearcase, and the code that was being run
 there is the test for whether or not you had it. What should have happened
 is that we'd see the failure (as a return code, not an exception) and then
 we'd just silently skip it. The thing is, on your Windows Python install for
 whatever reason, we're getting the exception instead of the return code.

 We can definitely do a try/except around the subprocess.Popen call, and
 then just fake an error return code. I'm just wondering why this is
 happening in the first place on your system, since I know many other people
 use post-review on Windows and haven't complained about it.

 When you say the python(x,y) distribution, do you mean specifically the
 Python installer on python.org, or are you using something like
 ActiveState's Python install?

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.review-board.org
 VMware, Inc. - http://www.vmware.com


 On Fri, Mar 20, 2009 at 1:24 PM, Laurent Dufrechou 
 laurent.dufrec...@gmail.com wrote:

 python - from python(x,y) distribution. this is a python 2.5.2.
 Json as been installed from setuptools.

 The fact is as I don't have clearcase on my computer, it could not
 detetc the tool, so it should warn the user that it could'nt do the test I
 think.
 This is not related to python, but more dur to the fact taht my windows
 clinet knows nothing about clearcase.
 (you can catch it with try: except WindowsError: but then I don't now
 how to says there was a failure, perhpas raisng another exeption and
 cathcing it in higher level?)

 I will definitvely read the doc, and setup a property for svn.

 will come after some tries.

 Laurent


 2009/3/20 Christian Hammond chip...@chipx86.com

 The .reviewboardrc is needed for specifying which server to use, but
 really this should be done through a property on the SVN server. See the
 docs in the script for details on setting this up.

 However, .reviewboardrc isn't related to this. The problem is that
 we're attempting to execute the clearcase tool in order to see if 1) it's
 available and 2) this is a clearcase repository. We do these scans with 
 lots
 of tools. What's odd about this one is that we're actually getting an 
 error
 back that we don't expect. The call we use *should* return an error code,
 not an exception.

 Where did you install your Python from?

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.review-board.org
 VMware, Inc. - http://www.vmware.com


 On Fri, Mar 20, 2009 at 12:29 PM, Laurent Dufrechou 
 laurent.dufrec...@gmail.com wrote:

 It means File not found
 By the way taking  a look  @ python script I've seen that it look
 after a .reviewboardrc file.

 the fact is i use the script on windows pc client that is not the
 server. So perhaps someone could say me where i can find this file that 
 must
 me configured I think?
 Sorry I fall in all the newbies trap
 :)



 2009/3/20 Christian Hammond chip...@chipx86.com

 I imagine we're trying to

Re: Cleartool missing + Svn access issue ?

2009-03-20 Thread Gary M. Josack


I'm going to guess you got that error because cleartool isn't installed.

Laurent Dufrechou wrote:
 Just tested under linux got this execption:

 Traceback (most recent call last):
   File ./post-review, line 2312, in module
 main(sys.argv[1:])
   File ./post-review, line 2253, in main
 repository_info, tool = determine_client()
   File ./post-review, line 2205, in determine_client
 repository_info = tool.get_repository_info()
   File ./post-review, line 744, in get_repository_info
 self.viewinfo = execute([cleartool, pwv, -short])
   File ./post-review, line 1897, in execute
 env=env)
   File /usr/lib/python2.5/subprocess.py, line 594, in __init__
 errread, errwrite)
   File /usr/lib/python2.5/subprocess.py, line 1147, in _execute_child
 raise child_exception
 OSError: [Errno 2] No such file or directory

 So under linux it raise an OSError.

 To be clear I really misuse the script as I launch it on a directory 
 where there is nothing else, but well it should catch the exception I 
 think.


 2009/3/20 Laurent Dufrechou laurent.dufrec...@gmail.com 
 mailto:laurent.dufrec...@gmail.com

 By the way .reviewboardrc for the filename of config name is not
 good for portability because under windows you can't '.reviewboardrc'
 It absolutely want somthin like .yy or  :(
 perhaps alowing a second name for windows could be a good idea too.

 somethong like reviewboardrc.conf.

 If you want I can modify the script to work under windows (with
 .conf  + try catch for subprocess) and send it back to you.


 2009/3/20 Laurent Dufrechou laurent.dufrec...@gmail.com
 mailto:laurent.dufrec...@gmail.com

 More like an active state like:
 http://www.pythonxy.com/foreword_fr.php

 I think this is more because of i'm under vista business SP1.
 I've run in same bug under ipython wednesday.
 A subprocess couldn't be called due to UAC (other issue but
 related to subprocess) and it raised Windows Error.
 So seems subprocess rise this sort of error when it see that
 the subprocess call exist with failure.

 Perhpas more related to Vista vs XP?


 2009/3/20 Christian Hammond chip...@chipx86.com
 mailto:chip...@chipx86.com

 post-review doesn't require clearcase, and the code that
 was being run there is the test for whether or not you had
 it. What should have happened is that we'd see the failure
 (as a return code, not an exception) and then we'd just
 silently skip it. The thing is, on your Windows Python
 install for whatever reason, we're getting the exception
 instead of the return code.

 We can definitely do a try/except around the
 subprocess.Popen call, and then just fake an error return
 code. I'm just wondering why this is happening in the
 first place on your system, since I know many other people
 use post-review on Windows and haven't complained about it.

 When you say the python(x,y) distribution, do you mean
 specifically the Python installer on python.org
 http://python.org, or are you using something like
 ActiveState's Python install?


 Christian

 -- 
 Christian Hammond - chip...@chipx86.com
 mailto:chip...@chipx86.com
 Review Board - http://www.review-board.org
 VMware, Inc. - http://www.vmware.com


 On Fri, Mar 20, 2009 at 1:24 PM, Laurent Dufrechou
 laurent.dufrec...@gmail.com
 mailto:laurent.dufrec...@gmail.com wrote:

 python - from python(x,y) distribution. this is a
 python 2.5.2.
 Json as been installed from setuptools.

 The fact is as I don't have clearcase on my computer,
 it could not detetc the tool, so it should warn the
 user that it could'nt do the test I think.
 This is not related to python, but more dur to the
 fact taht my windows clinet knows nothing about clearcase.
 (you can catch it with try: except WindowsError: but
 then I don't now how to says there was a failure,
 perhpas raisng another exeption and cathcing it in
 higher level?)

 I will definitvely read the doc, and setup a property
 for svn.

 will come after some tries.

 Laurent


 2009/3/20 Christian Hammond chip...@chipx86.com
 mailto:chip...@chipx86.com

 The .reviewboardrc is needed for specifying which
 server to use, but really this should be done
 through a property on the SVN server. See the docs
 in the

Re: Cleartool missing + Svn access issue ?

Yeah yeah for sure

2009/3/20 Gary M. Josack g...@byoteki.com


 I'm going to guess you got that error because cleartool isn't installed.

 Laurent Dufrechou wrote:
  Just tested under linux got this execption:
 
  Traceback (most recent call last):
File ./post-review, line 2312, in module
  main(sys.argv[1:])
File ./post-review, line 2253, in main
  repository_info, tool = determine_client()
File ./post-review, line 2205, in determine_client
  repository_info = tool.get_repository_info()
File ./post-review, line 744, in get_repository_info
  self.viewinfo = execute([cleartool, pwv, -short])
File ./post-review, line 1897, in execute
  env=env)
File /usr/lib/python2.5/subprocess.py, line 594, in __init__
  errread, errwrite)
File /usr/lib/python2.5/subprocess.py, line 1147, in _execute_child
  raise child_exception
  OSError: [Errno 2] No such file or directory
 
  So under linux it raise an OSError.
 
  To be clear I really misuse the script as I launch it on a directory
  where there is nothing else, but well it should catch the exception I
  think.
 
 
  2009/3/20 Laurent Dufrechou laurent.dufrec...@gmail.com
  mailto:laurent.dufrec...@gmail.com
 
  By the way .reviewboardrc for the filename of config name is not
  good for portability because under windows you can't '.reviewboardrc'
  It absolutely want somthin like .yy or  :(
  perhaps alowing a second name for windows could be a good idea too.
 
  somethong like reviewboardrc.conf.
 
  If you want I can modify the script to work under windows (with
  .conf  + try catch for subprocess) and send it back to you.
 
 
  2009/3/20 Laurent Dufrechou laurent.dufrec...@gmail.com
  mailto:laurent.dufrec...@gmail.com
 
  More like an active state like:
  http://www.pythonxy.com/foreword_fr.php
 
  I think this is more because of i'm under vista business SP1.
  I've run in same bug under ipython wednesday.
  A subprocess couldn't be called due to UAC (other issue but
  related to subprocess) and it raised Windows Error.
  So seems subprocess rise this sort of error when it see that
  the subprocess call exist with failure.
 
  Perhpas more related to Vista vs XP?
 
 
  2009/3/20 Christian Hammond chip...@chipx86.com
  mailto:chip...@chipx86.com
 
  post-review doesn't require clearcase, and the code that
  was being run there is the test for whether or not you had
  it. What should have happened is that we'd see the failure
  (as a return code, not an exception) and then we'd just
  silently skip it. The thing is, on your Windows Python
  install for whatever reason, we're getting the exception
  instead of the return code.
 
  We can definitely do a try/except around the
  subprocess.Popen call, and then just fake an error return
  code. I'm just wondering why this is happening in the
  first place on your system, since I know many other people
  use post-review on Windows and haven't complained about it.
 
  When you say the python(x,y) distribution, do you mean
  specifically the Python installer on python.org
  http://python.org, or are you using something like
  ActiveState's Python install?
 
 
  Christian
 
  --
  Christian Hammond - chip...@chipx86.com
  mailto:chip...@chipx86.com
  Review Board - http://www.review-board.org
  VMware, Inc. - http://www.vmware.com
 
 
  On Fri, Mar 20, 2009 at 1:24 PM, Laurent Dufrechou
  laurent.dufrec...@gmail.com
  mailto:laurent.dufrec...@gmail.com wrote:
 
  python - from python(x,y) distribution. this is a
  python 2.5.2.
  Json as been installed from setuptools.
 
  The fact is as I don't have clearcase on my computer,
  it could not detetc the tool, so it should warn the
  user that it could'nt do the test I think.
  This is not related to python, but more dur to the
  fact taht my windows clinet knows nothing about
 clearcase.
  (you can catch it with try: except WindowsError: but
  then I don't now how to says there was a failure,
  perhpas raisng another exeption and cathcing it in
  higher level?)
 
  I will definitvely read the doc, and setup a property
  for svn.
 
  will come after some tries.
 
  Laurent
 
 
  2009/3/20 Christian Hammond chip...@chipx86.com
  mailto:chip...@chipx86.com
 
  The .reviewboardrc is needed for

How post-review must be used?

2009-03-20 Thread laurent.dufrec...@gmail.com


Hello,
Just another thread because this is not related to the exception
handling.

It seems that I misuse post-review.
I was thinking that I had to launch it (wherever I was), and it would
ask me what was my SVN repos, what was my diff file, ans it would send
the update to the server.

Seems it does no do that. It seems it is looking for some info about
the repos.
Does it took the info from REVIEWBOARD_URL = http://192.168.1.200/
reviews?

If yes, admitting I have misconfigured my server (because it does not
detect the SVN repos. How can I check my repos config?

In fact I've also tried to declare a review via the web interface
sending it a .diff.
But trying to see diff, it show me a blank page. So what, Snv repos
declaration is misconfigured. If yes, where could I find a log to
check this?

I must admit I'm a little bit lost. For the moment I haven't set the
svn properties, just using .reviewboardrc but it doesn't seems to have
any effect.
REVIEWBOARD_URL = http://192.168.1.200/reviews;

So what, more a server repos misconfig?

Laurent
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Cleartool missing + Svn access issue ?

We'll have to do the try/catch method I suppose. I don't know why you'd be
getting the OSError below. There's something clearly different between the
subprocess implementations we're using. We officially are supporting the
version from python.org, so it's something in the one you're using.

As for .reviewboardrc, you can create a file with that name just fine on
Windows. I just verified it. What are you seeing that' preventing it?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Fri, Mar 20, 2009 at 1:58 PM, Laurent Dufrechou 
laurent.dufrec...@gmail.com wrote:

 By the way .reviewboardrc for the filename of config name is not good for
 portability because under windows you can't '.reviewboardrc'
 It absolutely want somthin like .yy or  :(
 perhaps alowing a second name for windows could be a good idea too.

 somethong like reviewboardrc.conf.

 If you want I can modify the script to work under windows (with .conf  +
 try catch for subprocess) and send it back to you.


 2009/3/20 Laurent Dufrechou laurent.dufrec...@gmail.com

 More like an active state like:
 http://www.pythonxy.com/foreword_fr.php

 I think this is more because of i'm under vista business SP1.
 I've run in same bug under ipython wednesday.
 A subprocess couldn't be called due to UAC (other issue but related to
 subprocess) and it raised Windows Error.
 So seems subprocess rise this sort of error when it see that the
 subprocess call exist with failure.

 Perhpas more related to Vista vs XP?


 2009/3/20 Christian Hammond chip...@chipx86.com

 post-review doesn't require clearcase, and the code that was being run
 there is the test for whether or not you had it. What should have happened
 is that we'd see the failure (as a return code, not an exception) and then
 we'd just silently skip it. The thing is, on your Windows Python install for
 whatever reason, we're getting the exception instead of the return code.

 We can definitely do a try/except around the subprocess.Popen call, and
 then just fake an error return code. I'm just wondering why this is
 happening in the first place on your system, since I know many other people
 use post-review on Windows and haven't complained about it.

 When you say the python(x,y) distribution, do you mean specifically the
 Python installer on python.org, or are you using something like
 ActiveState's Python install?

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.review-board.org
 VMware, Inc. - http://www.vmware.com


 On Fri, Mar 20, 2009 at 1:24 PM, Laurent Dufrechou 
 laurent.dufrec...@gmail.com wrote:

 python - from python(x,y) distribution. this is a python 2.5.2.
 Json as been installed from setuptools.

 The fact is as I don't have clearcase on my computer, it could not
 detetc the tool, so it should warn the user that it could'nt do the test I
 think.
 This is not related to python, but more dur to the fact taht my windows
 clinet knows nothing about clearcase.
 (you can catch it with try: except WindowsError: but then I don't now
 how to says there was a failure, perhpas raisng another exeption and
 cathcing it in higher level?)

 I will definitvely read the doc, and setup a property for svn.

 will come after some tries.

 Laurent


 2009/3/20 Christian Hammond chip...@chipx86.com

 The .reviewboardrc is needed for specifying which server to use, but
 really this should be done through a property on the SVN server. See the
 docs in the script for details on setting this up.

 However, .reviewboardrc isn't related to this. The problem is that
 we're attempting to execute the clearcase tool in order to see if 1) it's
 available and 2) this is a clearcase repository. We do these scans with 
 lots
 of tools. What's odd about this one is that we're actually getting an 
 error
 back that we don't expect. The call we use *should* return an error code,
 not an exception.

 Where did you install your Python from?

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.review-board.org
 VMware, Inc. - http://www.vmware.com


 On Fri, Mar 20, 2009 at 12:29 PM, Laurent Dufrechou 
 laurent.dufrec...@gmail.com wrote:

 It means File not found
 By the way taking  a look  @ python script I've seen that it look
 after a .reviewboardrc file.

 the fact is i use the script on windows pc client that is not the
 server. So perhaps someone could say me where i can find this file that 
 must
 me configured I think?
 Sorry I fall in all the newbies trap
 :)



 2009/3/20 Christian Hammond chip...@chipx86.com

 I imagine we're trying to detect if it's a clearcase repository and
 something with the locale is causing us to fail incorrectly. Possibly a
 locale-related issue. What does Le fichier spÚcifiÚ est introuvable
 translate to in English?

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.review-board.org

Re: How post-review must be used?

2009-03-20 Thread Vinay Venkatesh

I apologize in advance for the stream of consciousness nature of this email.
 But hopefully, it helps.

You can set the reviewboard:url property by doingsvn propedit
reviewboard:url .
inside the directory for the repository using cygwin.  When you run
post-review you'll want to be inside that directory.  Make sure that you
also have the repository set up in the review-board admin ui (
http://code.google.com/docreader/#p=reviewboards=reviewboardt=Adding_Repositories
)

I am not a windows user, so I am unaware of any gotchas with Cygwin, but
from reading your emails I gather the following information.

The cleartool error that you're getting is not the problem.  It sounds like
you are using a svn server.  And post-review is unable to find the
reviewboard url and your current working directory (when you run
post-review) isn't inside the repository.

/Vinay

On Fri, Mar 20, 2009 at 2:50 PM, Christian Hammond chip...@chipx86.comwrote:

 You must set either the REVIEWBOARD_URL variable within .reviewboardrc or
 set the reviewboard:url property on your SVN directory for the project.
 The property is preferred, and there are instructions for this within the
 post-review script.

 The repository URL provided by running `svn info` is what you must use in
 Review Board itself in the repository entry.

 Did you create a Repository entry in the admin UI in Review Board, and what
 is it set to?

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.review-board.org
 VMware, Inc. - http://www.vmware.com



 On Fri, Mar 20, 2009 at 2:37 PM, laurent.dufrec...@gmail.com 
 laurent.dufrec...@gmail.com wrote:


 Hello,
 Just another thread because this is not related to the exception
 handling.

 It seems that I misuse post-review.
 I was thinking that I had to launch it (wherever I was), and it would
 ask me what was my SVN repos, what was my diff file, ans it would send
 the update to the server.

 Seems it does no do that. It seems it is looking for some info about
 the repos.
 Does it took the info from REVIEWBOARD_URL = http://192.168.1.200/
 reviews?

 If yes, admitting I have misconfigured my server (because it does not
 detect the SVN repos. How can I check my repos config?

 In fact I've also tried to declare a review via the web interface
 sending it a .diff.
 But trying to see diff, it show me a blank page. So what, Snv repos
 declaration is misconfigured. If yes, where could I find a log to
 check this?

 I must admit I'm a little bit lost. For the moment I haven't set the
 svn properties, just using .reviewboardrc but it doesn't seems to have
 any effect.
 REVIEWBOARD_URL = http://192.168.1.200/reviews;

 So what, more a server repos misconfig?

 Laurent



 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: How post-review must be used?

Hi christian your mail helps me!
svn info gave the URL. I didn't get for what it was used while reading the
doc.
The fact is there is a ' ' space in my repos URL, and it add to be
translated to %20 ... teah I know (I didn't choose the path name ;) )
so I changed the name from svn://www.xxx.com/mypath with space/etc/ by the
one taht svn info gave me:
svn://www.xxx.com/mypath%20with%20space/etc/ and now I got a traceback in
the web interface! Good

File
/usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha4-py2.5.egg/reviewboard/scmtools/svn.py,
line 115, in get_file
raise SCMError('Login to the SCM server failed.')
SCMError: Login to the SCM server failed.

So now I have to double check my user/password and I think it will be ok :)

2009/3/20 Christian Hammond chip...@chipx86.com

You must set either the REVIEWBOARD_URL variable within .reviewboardrc or
set the reviewboard:url property on your SVN directory for the project.
The property is preferred, and there are instructions for this within the
post-review script.

The repository URL provided by running `svn info` is what you must use in
Review Board itself in the repository entry.

Did you create a Repository entry in the admin UI in Review Board, and what
is it set to?

Christian

--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com

On Fri, Mar 20, 2009 at 2:37 PM, laurent.dufrec...@gmail.com
laurent.dufrec...@gmail.com wrote:

Hello,
Just another thread because this is not related to the exception
handling.

It seems that I misuse post-review.
I was thinking that I had to launch it (wherever I was), and it would
ask me what was my SVN repos, what was my diff file, ans it would send
the update to the server.

Seems it does no do that. It seems it is looking for some info about
the repos.
Does it took the info from REVIEWBOARD_URL = http://192.168.1.200/
reviews?

If yes, admitting I have misconfigured my server (because it does not
detect the SVN repos. How can I check my repos config?

In fact I've also tried to declare a review via the web interface
sending it a .diff.
But trying to see diff, it show me a blank page. So what, Snv repos
declaration is misconfigured. If yes, where could I find a log to
check this?

I must admit I'm a little bit lost. For the moment I haven't set the
svn properties, just using .reviewboardrc but it doesn't seems to have
any effect.
REVIEWBOARD_URL = http://192.168.1.200/reviews;

So what, more a server repos misconfig?

Laurent

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

RE: Cleartool missing + Svn access issue ?

2009-03-20 Thread Laurent Dufréchou

Hum, I think this is official python.

(python(x,y) is just packaging a lot of python install into a one .msi.

And under linux I use the one given by apt-get install under ubuntu 8.10.

That is a 2.5.2

Perhaps you still use older python than 2.5.0?

 

From python doc:

Exceptions http://docs.python.org/library/subprocess.html#exceptions ¶

Exceptions raised in the child process, before the new program has started to 
execute, will be re-raised in the parent. Additionally, the exception object 
will have one extra attribute called child_traceback, which is a string 
containing traceback information from the childs point of view.

The most common exception raised is  
http://docs.python.org/library/exceptions.html#exceptions.OSError OSError. 
This occurs, for example, when trying to execute a non-existent file. 
Applications should prepare for  
http://docs.python.org/library/exceptions.html#exceptions.OSError OSError 
exceptions.

A  http://docs.python.org/library/exceptions.html#exceptions.ValueError 
ValueError will be raised if  
http://docs.python.org/library/subprocess.html#subprocess.Popen Popen is 
called with invalid arguments.

check_call() will raise CalledProcessError, if the called process returns a 
non-zero return code.

(So Raise WindowsError: under windows…)

U sure you don’t get this kind of exception ?_?

Perhaps try to rename to a dummy command that does not exist on your system. 
It’s crazy you don’t get the exception!

 

 

De : reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] De la 
part de Christian Hammond
Envoyé : vendredi 20 mars 2009 23:02
À : reviewboard@googlegroups.com
Objet : Re: Cleartool missing + Svn access issue ?

 

We'll have to do the try/catch method I suppose. I don't know why you'd be 
getting the OSError below. There's something clearly different between the 
subprocess implementations we're using. We officially are supporting the 
version from python.org, so it's something in the one you're using.

As for .reviewboardrc, you can create a file with that name just fine on 
Windows. I just verified it. What are you seeing that' preventing it?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com



On Fri, Mar 20, 2009 at 1:58 PM, Laurent Dufrechou 
laurent.dufrec...@gmail.com wrote:

By the way .reviewboardrc for the filename of config name is not good for 
portability because under windows you can't '.reviewboardrc'
It absolutely want somthin like .yy or  :(
perhaps alowing a second name for windows could be a good idea too.

somethong like reviewboardrc.conf.

If you want I can modify the script to work under windows (with .conf  + try 
catch for subprocess) and send it back to you.



2009/3/20 Laurent Dufrechou laurent.dufrec...@gmail.com

 

More like an active state like:
http://www.pythonxy.com/foreword_fr.php

I think this is more because of i'm under vista business SP1.
I've run in same bug under ipython wednesday.
A subprocess couldn't be called due to UAC (other issue but related to 
subprocess) and it raised Windows Error.
So seems subprocess rise this sort of error when it see that the subprocess 
call exist with failure.

Perhpas more related to Vista vs XP?

 

2009/3/20 Christian Hammond chip...@chipx86.com

post-review doesn't require clearcase, and the code that was being run there is 
the test for whether or not you had it. What should have happened is that we'd 
see the failure (as a return code, not an exception) and then we'd just 
silently skip it. The thing is, on your Windows Python install for whatever 
reason, we're getting the exception instead of the return code.

We can definitely do a try/except around the subprocess.Popen call, and then 
just fake an error return code. I'm just wondering why this is happening in the 
first place on your system, since I know many other people use post-review on 
Windows and haven't complained about it.

When you say the python(x,y) distribution, do you mean specifically the Python 
installer on python.org, or are you using something like ActiveState's Python 
install?



Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com



On Fri, Mar 20, 2009 at 1:24 PM, Laurent Dufrechou 
laurent.dufrec...@gmail.com wrote:

python - from python(x,y) distribution. this is a python 2.5.2.
Json as been installed from setuptools.

The fact is as I don't have clearcase on my computer, it could not detetc the 
tool, so it should warn the user that it could'nt do the test I think.
This is not related to python, but more dur to the fact taht my windows clinet 
knows nothing about clearcase.
(you can catch it with try: except WindowsError: but then I don't now how to 
says there was a failure, perhpas raisng another exeption and cathcing it in 
higher level?)

I will definitvely read the doc, and setup a property for svn.

will

Re: How post-review must be used?

2009-03-20 Thread laurent.dufrec...@gmail.com


OK that's better. I decided to first give a try to linux, since it
seems your base platfrom.
I've managed to post my first review that support diff.
Here are some point you could find interesting (as I think I've done
all the basic stupid things a newbie user will do):
First a little exaplantion:
My repos is like this:
  - www..xxx
 - project1
 - porject 2
etc...

1) First in repos creation;
I checkout project1 and so I thought in repos path in repos creation I
thougth I had to put svn://www..xxx/project1. (copying svn info)
It seems I only needed to put svn://www..xxx (and not svn://www..xxx/
...)  yeah, when I say that I did all the possible mistakes...
2)I think I've got a bug, each time I create a newreview:
- modify a file
- post-review
Review request #10 posted.
- then I access to my board
it appears in draft
I fill the missing things a) reviewer group b) description c) testing
done d) summary
- i click publish
- I get an error 500 with no information
- I reclick and all is then ok ...

So all start to go not so bad ;)
Finally I 've choosed to FORCE
REVIEWBOARD_URL = http://192.168.X.XXX/reviews/; in the script
And all is working very well.

Will do some test under windows monday since I need to be on the local
network for that :)
Will do a little report, couls help you improve this interesting piece
of software ;)

Laurent






On Mar 20, 10:50 pm, Christian Hammond chip...@chipx86.com wrote:
 You must set either the REVIEWBOARD_URL variable within .reviewboardrc or
 set the reviewboard:url property on your SVN directory for the project.
 The property is preferred, and there are instructions for this within the
 post-review script.

 The repository URL provided by running `svn info` is what you must use in
 Review Board itself in the repository entry.

 Did you create a Repository entry in the admin UI in Review Board, and what
 is it set to?

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.review-board.org
 VMware, Inc. -http://www.vmware.com

 On Fri, Mar 20, 2009 at 2:37 PM, laurent.dufrec...@gmail.com 

 laurent.dufrec...@gmail.com wrote:

  Hello,
  Just another thread because this is not related to the exception
  handling.

  It seems that I misuse post-review.
  I was thinking that I had to launch it (wherever I was), and it would
  ask me what was my SVN repos, what was my diff file, ans it would send
  the update to the server.

  Seems it does no do that. It seems it is looking for some info about
  the repos.
  Does it took the info from REVIEWBOARD_URL = http://192.168.1.200/
  reviews?

  If yes, admitting I have misconfigured my server (because it does not
  detect the SVN repos. How can I check my repos config?

  In fact I've also tried to declare a review via the web interface
  sending it a .diff.
  But trying to see diff, it show me a blank page. So what, Snv repos
  declaration is misconfigured. If yes, where could I find a log to
  check this?

  I must admit I'm a little bit lost. For the moment I haven't set the
  svn properties, just using .reviewboardrc but it doesn't seems to have
  any effect.
  REVIEWBOARD_URL = http://192.168.1.200/reviews;

  So what, more a server repos misconfig?

  Laurent
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Issue 973 in reviewboard: Allow code review without a patch


Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 973 by jocelyn.fiat: Allow code review without a patch
http://code.google.com/p/reviewboard/issues/detail?id=973

Currently code review seems to only work for actually reviewing a patch,
not for reviewing existing code for improving it.

The suggestion I'll propose is to allow a code review of unmodified code
which will simply let reviewer add comments to code and discuss those
comments among people in the same team.



--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---

Issue 974 in reviewboard: Clicking anywhere now brings up the comment box, even expand code links


Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 974 by clarkd4: Clicking anywhere now brings up the comment box,  
even expand code links
http://code.google.com/p/reviewboard/issues/detail?id=974


Firefox 3.0.7 on Win2003 64-bit.  In the latest version of Reviewboard,
clicking anywhere in the code brings up the comment box, whereas in the
past, only clicking the line numbers would bring up a new comments box.

This is annoying because:

  * There is now no easy way to set the current change marker with the
mouse, except by clicking the file header and then using keyboard shortcuts.

  * Expanding collapsed code often does not work for me.  It just brings up
the comment box instead.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---

Issue 975 in reviewboard: Launching and moving comment box, backspacing over text are very slow


Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 975 by clarkd4: Launching and moving comment box, backspacing  
over text are very slow
http://code.google.com/p/reviewboard/issues/detail?id=975


Firefox 3.0.7, Win2003 64-bit.  In the latest version of Reviewboard at
VMware, loading the comments box takes a couple of seconds.  The same delay
occurs when I click and drag the comment box to a new location - there is a
long delay before the box begins to move.

I also experience delays of about 400ms per character while backspacing
through typed text in any comment box, review field, or reply field.  My
box isn't slow and my browser isn't old, and these problems didn't happen
in the previous version of Reviewboard.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---

Issue 975 in reviewboard: Launching and moving comment box, backspacing over text are very slow


Updates:
Status: NeedInfo

Comment #1 on issue 975 by chipx86: Launching and moving comment box,  
backspacing over text are very slow
http://code.google.com/p/reviewboard/issues/detail?id=975

What extensions are you using in Firefox?

The textarea is actually just a standard textarea, so I'm not sure why it'd  
be
slower, given that the old one was a textarea + a bunch of processing per  
key stroke.
So we should figure out what it is in your browser that may be causing  
this. Does the
problem go away if you restart the browser?

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---

Issue 974 in reviewboard: Clicking anywhere now brings up the comment box, even expand code links


Updates:
Status: Duplicate
Mergedinto: 933

Comment #1 on issue 974 by chipx86: Clicking anywhere now brings up the  
comment box, even expand code links
http://code.google.com/p/reviewboard/issues/detail?id=974

(No comment was entered for this change.)

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---

Issue 933 in reviewboard: Clicking expand triggers review comment



Comment #6 on issue 933 by clarkd4: Clicking expand triggers review comment
http://code.google.com/p/reviewboard/issues/detail?id=933

For the record, I liked the old behavior that only clicking or  
drag-selecting in the
line number column triggers a comment box.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---

Issue 975 in reviewboard: Launching and moving comment box, backspacing over text are very slow



Comment #2 on issue 975 by clarkd4: Launching and moving comment box,  
backspacing over text are very slow
http://code.google.com/p/reviewboard/issues/detail?id=975

Yes, both issues go away when I restart the browser.  The comment box is  
still a
little slow, but not horrible.  It might be related to long-running browser  
sessions,
I'll see if I can correlate that and update the issue if it happens again.

My extensions are ColorfulTabs and Download Statusbar.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---

Issue 966 in reviewboard: Under General Settings, updating Server field not saved despite successful message



Comment #1 on issue 966 by ciaomary: Under General Settings,  
updating Server field not saved despite successful message
http://code.google.com/p/reviewboard/issues/detail?id=966

Turns out this is not limited to just server field in General Settings.

On a new install of 3-13-09 nightly, setting Authentication to Custom and  
then
listing the Custom Backends is also not getting saved.

Workaround (i presume) is to alter the ReviewBoard Database directly.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---

Issue 933 in reviewboard: Clicking expand triggers review comment