Re: Perforce Security
This isn't a very usable solution, for a few reasons. First, we can't use the user's Review Board username/pass, because this won't always correspond to the account on the Perforce server. Also, passwords are one-way encrypted so that they can't easily be decrypted if the database is accessed by a malicious user. Given that, we'd have to specify the user/pass to use on every operation. Since Review Board pulls files from the Perforce server when generating a diff, which may happen at any time, we'd have to store the user/pass in plaintext in the database, which is horribly insecure. IT admins generally wouldn't be okay with this, and it would just be irresponsible for us to implement. We could do a sort of two-way encryption but this isn't really much better. Yes, we are storing the repository account's password in plaintext, but the general advice is to have a read-only user account or something so that if someone has the password, they can't do anything too dangerous. It's also far better than to have every single user's password available in plaintext. Also, if a user changes his username/password at a later time on the Perforce server, or the user is removed from the Perforce server, all associated review requests would become inaccessible. So storing user account info for accessing the server has a lot of downsides. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Fri, Sep 19, 2008 at 5:16 PM, Daniel Wexler <[EMAIL PROTECTED]> wrote: > > So, I think we already are using the official Perforce Python module. > That's good (it makes my IT guys happy). > > Why do we use the client and repository setting for the Repository > instead of using a client/pass from the user? > > I think my IT guys would be happy if we used the user's client/pass > information when the server accesses the repository instead of a > single, global user/pass. > > Just poking around the code, how would I get the reviewboard user/pass > inside scmtools/perforce.py:19? If I had folks set up their > reviewboard account using their same user/pass as they have with > Perforce, would it all Just Work (tm)? > > On Sep 19, 5:00 pm, Daniel Wexler <[EMAIL PROTECTED]> wrote: > > Has anyone explored the new Python bindings for Perforce? > > > > http://www.perforce.com/perforce/doc.081/manuals/p4script/p4script.pdf > > > > They seem to have functions for logging in to the server with a > > specific user name and password from Python. Could we use this and > > have the user's provide the Perforce user/pass as part of their client > > info? > > > > On Sep 19, 4:43 pm, "Jeff Andros" <[EMAIL PROTECTED]> wrote: > > > > > it's not a pretty solution, but what about setting up multiple > reviewboard > > > instances, with different user credentials in each (one for each > project > > > you've got) then you only create accounts on the servers that theyr'e > > > supposed to have access to. > > > Jeff > > > O|||O > > > > > Help me and the Leukemia and Lymphoma society fight blood cancers: > http://pages.teamintraining.org/dm/tucson08/jandros > > > > > On Fri, Sep 19, 2008 at 4:30 PM, Daniel Wexler <[EMAIL PROTECTED]> > wrote: > > > > > > I see an older discussion about the issue of Perforce security and > the > > > > need to put the P4 user and client information into the server: > > > > > > > http://groups.google.com/group/reviewboard/browse_thread/thread/d057c... > > > > > > Any update on this situation? > > > > > > My company is similarly concerned about this security issue and would > > > > like a way of passing through the user's perforce credentials. Is > > > > anyone actively working on this issue? > > > > > > We have a large company and have many internal security groups. > There > > > > have been issues in the past with "server" accounts that make the IT > > > > department hesitant to set up a special Perforce account for the > > > > server. > > > > > > Can someone explain why the server needs Perforce access in the first > > > > place? Why not just upload the required information as part of the > > > > user-side post-review script? > > > > > > BTW, I did install Windows NTLM authentication on my server using > > > > mod_auth_sspi with no issues so far, which provides a modicum of > > > > security. > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Perforce Security
So, I think we already are using the official Perforce Python module. That's good (it makes my IT guys happy). Why do we use the client and repository setting for the Repository instead of using a client/pass from the user? I think my IT guys would be happy if we used the user's client/pass information when the server accesses the repository instead of a single, global user/pass. Just poking around the code, how would I get the reviewboard user/pass inside scmtools/perforce.py:19? If I had folks set up their reviewboard account using their same user/pass as they have with Perforce, would it all Just Work (tm)? On Sep 19, 5:00 pm, Daniel Wexler <[EMAIL PROTECTED]> wrote: > Has anyone explored the new Python bindings for Perforce? > > http://www.perforce.com/perforce/doc.081/manuals/p4script/p4script.pdf > > They seem to have functions for logging in to the server with a > specific user name and password from Python. Could we use this and > have the user's provide the Perforce user/pass as part of their client > info? > > On Sep 19, 4:43 pm, "Jeff Andros" <[EMAIL PROTECTED]> wrote: > > > it's not a pretty solution, but what about setting up multiple reviewboard > > instances, with different user credentials in each (one for each project > > you've got) then you only create accounts on the servers that theyr'e > > supposed to have access to. > > Jeff > > O|||O > > > Help me and the Leukemia and Lymphoma society fight blood > > cancers:http://pages.teamintraining.org/dm/tucson08/jandros > > > On Fri, Sep 19, 2008 at 4:30 PM, Daniel Wexler <[EMAIL PROTECTED]> wrote: > > > > I see an older discussion about the issue of Perforce security and the > > > need to put the P4 user and client information into the server: > > > >http://groups.google.com/group/reviewboard/browse_thread/thread/d057c... > > > > Any update on this situation? > > > > My company is similarly concerned about this security issue and would > > > like a way of passing through the user's perforce credentials. Is > > > anyone actively working on this issue? > > > > We have a large company and have many internal security groups. There > > > have been issues in the past with "server" accounts that make the IT > > > department hesitant to set up a special Perforce account for the > > > server. > > > > Can someone explain why the server needs Perforce access in the first > > > place? Why not just upload the required information as part of the > > > user-side post-review script? > > > > BTW, I did install Windows NTLM authentication on my server using > > > mod_auth_sspi with no issues so far, which provides a modicum of > > > security. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Perforce Security
Has anyone explored the new Python bindings for Perforce? http://www.perforce.com/perforce/doc.081/manuals/p4script/p4script.pdf They seem to have functions for logging in to the server with a specific user name and password from Python. Could we use this and have the user's provide the Perforce user/pass as part of their client info? On Sep 19, 4:43 pm, "Jeff Andros" <[EMAIL PROTECTED]> wrote: > it's not a pretty solution, but what about setting up multiple reviewboard > instances, with different user credentials in each (one for each project > you've got) then you only create accounts on the servers that theyr'e > supposed to have access to. > Jeff > O|||O > > Help me and the Leukemia and Lymphoma society fight blood > cancers:http://pages.teamintraining.org/dm/tucson08/jandros > > On Fri, Sep 19, 2008 at 4:30 PM, Daniel Wexler <[EMAIL PROTECTED]> wrote: > > > I see an older discussion about the issue of Perforce security and the > > need to put the P4 user and client information into the server: > > >http://groups.google.com/group/reviewboard/browse_thread/thread/d057c... > > > Any update on this situation? > > > My company is similarly concerned about this security issue and would > > like a way of passing through the user's perforce credentials. Is > > anyone actively working on this issue? > > > We have a large company and have many internal security groups. There > > have been issues in the past with "server" accounts that make the IT > > department hesitant to set up a special Perforce account for the > > server. > > > Can someone explain why the server needs Perforce access in the first > > place? Why not just upload the required information as part of the > > user-side post-review script? > > > BTW, I did install Windows NTLM authentication on my server using > > mod_auth_sspi with no issues so far, which provides a modicum of > > security. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Perforce Security
it's not a pretty solution, but what about setting up multiple reviewboard instances, with different user credentials in each (one for each project you've got) then you only create accounts on the servers that theyr'e supposed to have access to. Jeff O|||O Help me and the Leukemia and Lymphoma society fight blood cancers: http://pages.teamintraining.org/dm/tucson08/jandros On Fri, Sep 19, 2008 at 4:30 PM, Daniel Wexler <[EMAIL PROTECTED]> wrote: > > I see an older discussion about the issue of Perforce security and the > need to put the P4 user and client information into the server: > > http://groups.google.com/group/reviewboard/browse_thread/thread/d057cc0c05d51e1f > > Any update on this situation? > > My company is similarly concerned about this security issue and would > like a way of passing through the user's perforce credentials. Is > anyone actively working on this issue? > > We have a large company and have many internal security groups. There > have been issues in the past with "server" accounts that make the IT > department hesitant to set up a special Perforce account for the > server. > > Can someone explain why the server needs Perforce access in the first > place? Why not just upload the required information as part of the > user-side post-review script? > > BTW, I did install Windows NTLM authentication on my server using > mod_auth_sspi with no issues so far, which provides a modicum of > security. > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Perforce Security
I see an older discussion about the issue of Perforce security and the need to put the P4 user and client information into the server: http://groups.google.com/group/reviewboard/browse_thread/thread/d057cc0c05d51e1f Any update on this situation? My company is similarly concerned about this security issue and would like a way of passing through the user's perforce credentials. Is anyone actively working on this issue? We have a large company and have many internal security groups. There have been issues in the past with "server" accounts that make the IT department hesitant to set up a special Perforce account for the server. Can someone explain why the server needs Perforce access in the first place? Why not just upload the required information as part of the user-side post-review script? BTW, I did install Windows NTLM authentication on my server using mod_auth_sspi with no issues so far, which provides a modicum of security. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: ship it! response emails not sending?
Christian, Great. We were at 1500, so I'm sure that's it. Thanks! Kevin On Fri, Sep 19, 2008 at 1:24 PM, Christian Hammond <[EMAIL PROTECTED]>wrote: > Hi Kevin. > > There was a bug where the recipients were added to the CC header but not > actually included in the list send to the sendmail() function. This was just > fixed in r1509 two nights ago, so check which revision you're using and do > an update. > > Hope it works! > > Christian > > -- > Christian Hammond - [EMAIL PROTECTED] > VMware, Inc. > > > > On Fri, Sep 19, 2008 at 11:25 AM, [EMAIL PROTECTED] <[EMAIL PROTECTED] > > wrote: > >> >> First off, let me say that reviewboard is wonderful. >> >> One strange issue we're seeing -- say that I post_review a review to a >> friend A. The two of us get the initial "review created" email at >> first, like we should. If A reviews it and says "ship it!", we're >> seeing that A gets the email, but I don't, which totally kills the >> workflow. It gets updated properly on the server side, but it means I >> have to go back and check my dashboard rather than getting notified. >> The email that A gets appears to show me being CC'd, but I never get >> the email. >> >> Has something like this ever come up? >> >> Thanks! >> Kevin >> >> > > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: ship it! response emails not sending?
Hi Kevin. There was a bug where the recipients were added to the CC header but not actually included in the list send to the sendmail() function. This was just fixed in r1509 two nights ago, so check which revision you're using and do an update. Hope it works! Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Fri, Sep 19, 2008 at 11:25 AM, [EMAIL PROTECTED] <[EMAIL PROTECTED]>wrote: > > First off, let me say that reviewboard is wonderful. > > One strange issue we're seeing -- say that I post_review a review to a > friend A. The two of us get the initial "review created" email at > first, like we should. If A reviews it and says "ship it!", we're > seeing that A gets the email, but I don't, which totally kills the > workflow. It gets updated properly on the server side, but it means I > have to go back and check my dashboard rather than getting notified. > The email that A gets appears to show me being CC'd, but I never get > the email. > > Has something like this ever come up? > > Thanks! > Kevin > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
ship it! response emails not sending?
First off, let me say that reviewboard is wonderful. One strange issue we're seeing -- say that I post_review a review to a friend A. The two of us get the initial "review created" email at first, like we should. If A reviews it and says "ship it!", we're seeing that A gets the email, but I don't, which totally kills the workflow. It gets updated properly on the server side, but it means I have to go back and check my dashboard rather than getting notified. The email that A gets appears to show me being CC'd, but I never get the email. Has something like this ever come up? Thanks! Kevin --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review in perforce
I Fixed it thanks But now i get this Error
Unable to parse diff header: operable program or batch file
On Sep 19, 2:58 pm, 13Strider <[EMAIL PROTECTED]> wrote:
> I Guess i have to wait till i get a responce from Christan ?
>
> On Sep 19, 2:08 pm, 13Strider <[EMAIL PROTECTED]> wrote:
>
>
>
> > This is Exactly what i got and I get the Error
>
> > On Sep 19, 1:59 pm, "Joshua Slominski" <[EMAIL PROTECTED]> wrote:
>
> > > That is what you need.
>
> > > On Fri, Sep 19, 2008 at 12:57 PM, 13Strider <[EMAIL PROTECTED]>wrote:
>
> > > > I have made the changes, this is what i have.
>
> > > > # set the P4 enviroment:
> > > > if options.p4_client:
> > > > os.environ['P4CLIENT'] = options.p4_client
>
> > > > if options.p4_port:
> > > > os.environ['P4PORT'] = options.p4_port
>
> > > > if isinstance(tool,PerforceClient):
> > > > parser.add_option("--p4-client",
>
> > > > dest="p4_client", default=None,
> > > > help="the Perforce client name that the review is in")
>
> > > > parser.add_option("--p4-port",
> > > > dest="p4_port", default=None,
> > > > help="the Perforce servers IP address that the review is on")- Hide
> > > > quoted text -
>
> > > - Show quoted text -- Hide quoted text -
>
> > - Show quoted text -- Hide quoted text -
>
> - Show quoted text -
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: post-review in perforce
I Guess i have to wait till i get a responce from Christan ?
On Sep 19, 2:08 pm, 13Strider <[EMAIL PROTECTED]> wrote:
> This is Exactly what i got and I get the Error
>
> On Sep 19, 1:59 pm, "Joshua Slominski" <[EMAIL PROTECTED]> wrote:
>
>
>
> > That is what you need.
>
> > On Fri, Sep 19, 2008 at 12:57 PM, 13Strider <[EMAIL PROTECTED]>wrote:
>
> > > I have made the changes, this is what i have.
>
> > > # set the P4 enviroment:
> > > if options.p4_client:
> > > os.environ['P4CLIENT'] = options.p4_client
>
> > > if options.p4_port:
> > > os.environ['P4PORT'] = options.p4_port
>
> > > if isinstance(tool,PerforceClient):
> > > parser.add_option("--p4-client",
>
> > > dest="p4_client", default=None,
> > > help="the Perforce client name that the review is in")
>
> > > parser.add_option("--p4-port",
> > > dest="p4_port", default=None,
> > > help="the Perforce servers IP address that the review is on")- Hide
> > > quoted text -
>
> > - Show quoted text -- Hide quoted text -
>
> - Show quoted text -
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: post-review in perforce
This is Exactly what i got and I get the Error
On Sep 19, 1:59 pm, "Joshua Slominski" <[EMAIL PROTECTED]> wrote:
> That is what you need.
>
> On Fri, Sep 19, 2008 at 12:57 PM, 13Strider <[EMAIL PROTECTED]>wrote:
>
>
>
>
>
> > I have made the changes, this is what i have.
>
> > # set the P4 enviroment:
> > if options.p4_client:
> > os.environ['P4CLIENT'] = options.p4_client
>
> > if options.p4_port:
> > os.environ['P4PORT'] = options.p4_port
>
> > if isinstance(tool,PerforceClient):
> > parser.add_option("--p4-client",
>
> > dest="p4_client", default=None,
> > help="the Perforce client name that the review is in")
>
> > parser.add_option("--p4-port",
> > dest="p4_port", default=None,
> > help="the Perforce servers IP address that the review is on")- Hide quoted
> > text -
>
> - Show quoted text -
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: post-review in perforce
i still get the error
On Sep 19, 1:59 pm, "Joshua Slominski" <[EMAIL PROTECTED]> wrote:
> That is what you need.
>
> On Fri, Sep 19, 2008 at 12:57 PM, 13Strider <[EMAIL PROTECTED]>wrote:
>
>
>
>
>
> > I have made the changes, this is what i have.
>
> > # set the P4 enviroment:
> > if options.p4_client:
> > os.environ['P4CLIENT'] = options.p4_client
>
> > if options.p4_port:
> > os.environ['P4PORT'] = options.p4_port
>
> > if isinstance(tool,PerforceClient):
> > parser.add_option("--p4-client",
>
> > dest="p4_client", default=None,
> > help="the Perforce client name that the review is in")
>
> > parser.add_option("--p4-port",
> > dest="p4_port", default=None,
> > help="the Perforce servers IP address that the review is on")- Hide quoted
> > text -
>
> - Show quoted text -
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: post-review in perforce
That is what you need.
On Fri, Sep 19, 2008 at 12:57 PM, 13Strider <[EMAIL PROTECTED]>wrote:
>
> I have made the changes, this is what i have.
>
> # set the P4 enviroment:
> if options.p4_client:
> os.environ['P4CLIENT'] = options.p4_client
>
> if options.p4_port:
> os.environ['P4PORT'] = options.p4_port
>
> if isinstance(tool,PerforceClient):
> parser.add_option("--p4-client",
>
> dest="p4_client", default=None,
> help="the Perforce client name that the review is in")
>
> parser.add_option("--p4-port",
> dest="p4_port", default=None,
> help="the Perforce servers IP address that the review is on")
>
>
> >
>
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: post-review in perforce
I have made the changes, this is what i have.
# set the P4 enviroment:
if options.p4_client:
os.environ['P4CLIENT'] = options.p4_client
if options.p4_port:
os.environ['P4PORT'] = options.p4_port
if isinstance(tool,PerforceClient):
parser.add_option("--p4-client",
dest="p4_client", default=None,
help="the Perforce client name that the review is in")
parser.add_option("--p4-port",
dest="p4_port", default=None,
help="the Perforce servers IP address that the review is on")
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: post-review in perforce
I received comments from Christan to make changes to the argument names. So if you update your version of post-review you should be good to go On Fri, Sep 19, 2008 at 12:50 PM, 13Strider <[EMAIL PROTECTED]>wrote: > > Yes i've added it from http://reviews.review-board.org/r/467/ > > On Sep 19, 1:44 pm, Daniel Wexler <[EMAIL PROTECTED]> wrote: > > Does post-review have --p4-port and --p4-client options? > > > > I don't see them in my version. > > > > On Sep 19, 9:40 am, 13Strider <[EMAIL PROTECTED]> wrote: > > > > > > > > > i imported the P4Tool.txt in perforce > > > installed python and simplejson > > > as soon as i go to submit for review > > > i get this error : > > > > > Usage: post-review [-pond] [-r review_id] [changenum] > > > post-review: error: no such option: --p4-client > > > > > when i click on the new option i've added in perforce > > > this what it runs > > > C:\Python25\python.exe R:/post-review %C --p4-client Sam --p4-port > > > salmon.bob.com:1999 > > > > > Any Ideas?- Hide quoted text - > > > > - Show quoted text - > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review in perforce
Yes i've added it from http://reviews.review-board.org/r/467/ On Sep 19, 1:44 pm, Daniel Wexler <[EMAIL PROTECTED]> wrote: > Does post-review have --p4-port and --p4-client options? > > I don't see them in my version. > > On Sep 19, 9:40 am, 13Strider <[EMAIL PROTECTED]> wrote: > > > > > i imported the P4Tool.txt in perforce > > installed python and simplejson > > as soon as i go to submit for review > > i get this error : > > > Usage: post-review [-pond] [-r review_id] [changenum] > > post-review: error: no such option: --p4-client > > > when i click on the new option i've added in perforce > > this what it runs > > C:\Python25\python.exe R:/post-review %C --p4-client Sam --p4-port > > salmon.bob.com:1999 > > > Any Ideas?- Hide quoted text - > > - Show quoted text - --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review in perforce
Does post-review have --p4-port and --p4-client options? I don't see them in my version. On Sep 19, 9:40 am, 13Strider <[EMAIL PROTECTED]> wrote: > i imported the P4Tool.txt in perforce > installed python and simplejson > as soon as i go to submit for review > i get this error : > > Usage: post-review [-pond] [-r review_id] [changenum] > post-review: error: no such option: --p4-client > > when i click on the new option i've added in perforce > this what it runs > C:\Python25\python.exe R:/post-review %C --p4-client Sam --p4-port > salmon.bob.com:1999 > > Any Ideas? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
post-review in perforce
i imported the P4Tool.txt in perforce installed python and simplejson as soon as i go to submit for review i get this error : Usage: post-review [-pond] [-r review_id] [changenum] post-review: error: no such option: --p4-client when i click on the new option i've added in perforce this what it runs C:\Python25\python.exe R:/post-review %C --p4-client Sam --p4-port salmon.bob.com:1999 Any Ideas? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Annotating Reviews
You can just review your own code... Publish the review to yourself, review it, then add the intended reviewers. I do that sometimes. Being able to order the files would definitely be helpful. On Sep 19, 11:50 am, Daniel Wexler <[EMAIL PROTECTED]> wrote: > How do people annotate reviews prior to posting them publicly? > > When preparing a new review, I like to annotate the code with comments > that describe the reasoning behind my choices. These comments help > guide the reviewer through the changes. It is great when these > annotations are tied to lines in the code. When I try to annotate the > code prior to a review, the diff tool lets me bring up the dialog, but > it doesn't let me save my comments. I have been able to enter > comments into the "review" tab, and then publish them, but they don't > seem to be tied to a code line. Am I doing something wrong? > > The alternative that I'm using now is to write a long description of > the change and put my annotations in the description field, using a > file.cpp:# text to guide the reviewer. There must be a better way? > > Along these lines, I also would love to have the option of ordering > the files within the diff semantically. By ordering the files > carefully I can again help guide the reviewer through the review by > showing, for example, the changes to a header before the > associated .cpp file. Ironically, the alphabetical ordering tends to > put code files (.cpp) ahead of headers with the same name. > > How do other people annotate their reviews to help guide the reviewer? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Annotating Reviews
How do people annotate reviews prior to posting them publicly? When preparing a new review, I like to annotate the code with comments that describe the reasoning behind my choices. These comments help guide the reviewer through the changes. It is great when these annotations are tied to lines in the code. When I try to annotate the code prior to a review, the diff tool lets me bring up the dialog, but it doesn't let me save my comments. I have been able to enter comments into the "review" tab, and then publish them, but they don't seem to be tied to a code line. Am I doing something wrong? The alternative that I'm using now is to write a long description of the change and put my annotations in the description field, using a file.cpp:# text to guide the reviewer. There must be a better way? Along these lines, I also would love to have the option of ordering the files within the diff semantically. By ordering the files carefully I can again help guide the reviewer through the review by showing, for example, the changes to a header before the associated .cpp file. Ironically, the alphabetical ordering tends to put code files (.cpp) ahead of headers with the same name. How do other people annotate their reviews to help guide the reviewer? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
