Re: Cookies Firefox3

[Ben]

On Thu, Sep 18, 2008 at 08:52, Christian Hammond [EMAIL PROTECTED] wrote:
 Hi.

 I'm using Firefox 3 and haven't seen any cookie-related problems. What
 extensions are you running?

Extension of my Firefox you mean ?

Nothing related to cookies I guess ...

I just disabled everything, it did not solved my problem ... I keep
getting a  Cookies must be enabled. message ... quite annoying to
sell it to the team ... IE7, Ff2 is working fine by the way ...

Using 3.0.1 on XP if that helps.

I can do some more investigating/testing if I'm told where to look at ...


 We can definitely add to settings_local.py.tmpl. I'll make a note to do that
 soon.

I can submit something related to the review-board if you want so.

Regards,
Benoit

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Cookies Firefox3

[Ben]

Wahoo !

Many thanks ... I had (suposely) old cookies in place, removed them,
reloaded, logged-in, and it worked fine !

solved.

Regards,
Benoit

On Thu, Sep 18, 2008 at 11:04, Christian Hammond [EMAIL PROTECTED] wrote:
 A couple things you might want to check.

 Go to your Review Board page, right-click on the page and choose View Page
 Info.

 On the Permissions tab, make sure you have Set Cookies set to allow
 always.

 Then go to the Security tab and click View Cookies. See what comes up.

 Christian

 --
 Christian Hammond - [EMAIL PROTECTED]
 VMware, Inc.


 On Thu, Sep 18, 2008 at 2:02 AM, Ben [EMAIL PROTECTED] wrote:

 BTW, reviews.review-board.org works fine from the same browser ... I'm
 seriously suspecting my django install (taken it from 1.0 tarball ...
 and `python setup.py install`)



 On Thu, Sep 18, 2008 at 10:16, Ben [EMAIL PROTECTED] wrote:
  On Thu, Sep 18, 2008 at 08:52, Christian Hammond [EMAIL PROTECTED]
  wrote:
  Hi.
 
  I'm using Firefox 3 and haven't seen any cookie-related problems. What
  extensions are you running?
 
  Extension of my Firefox you mean ?
 
  Nothing related to cookies I guess ...
 
  I just disabled everything, it did not solved my problem ... I keep
  getting a  Cookies must be enabled. message ... quite annoying to
  sell it to the team ... IE7, Ff2 is working fine by the way ...
 
  Using 3.0.1 on XP if that helps.
 
  I can do some more investigating/testing if I'm told where to look at
  ...
 
 
  We can definitely add to settings_local.py.tmpl. I'll make a note to do
  that
  soon.
 
  I can submit something related to the review-board if you want so.
 
  Regards,
  Benoit
 




 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Upgrade issues

[Ben]

Hi there,

Upgrading from an svn install I'm also hitting that one ...

How did you solved it ? manually editing the database ?

Regards,
Benoit

On Mon, Dec 8, 2008 at 20:12, Chris Clarkchris.cl...@ingres.com wrote:
 Christian Hammond wrote:

 This was due to a bug I'm currently fixing. I should have it in in about 15
 mins.

 I'm not sure which this referred to. I've pulled (new) headrevs - I still
 get the problem with htdocs and an existing review not viewable anymore.

 BUT I know how to deal with htdocs (I'll start using the new rb-site
 script).

 RE the review not visible anymore I now know what the problem is! If you
 have any reviews in Draft, i.e not yet published, and you are pre change
 description on review update, at the time of the evolve. With sqlite the
 evolve appears to use the string 'changedesc_id' for the
 reviews_reviewrequestdraft.changedesc_id column (supposed to be integer or
 null). For the draft reviews I've simple updated all the
 reviews_reviewrequestdraft.changedesc_id columns to NULL if they ==
 'changedesc_id' - I've not looked any further into this or checked other
 database engines.

 Summary of the problem:

 upgrade from release of RB that does not have the change description field
 on updated reviews
 using sqlite
 have an existing review, that is in draft (with some updated diffs)
 you are logged in as the review owner
 you evolve the database
 view review

 Error traceback (from debug on, so result go to web browser)

 TemplateSyntaxError at /r/62/

 Caught an exception while rendering: invalid literal for int():
 changedesc_id

 Original Traceback (most recent call last):
   File C:\svn\django\django\template\debug.py, line 71, in render_node
 result = node.render(context)
   File C:\svn\django\django\template\debug.py, line 87, in render
 output = force_unicode(self.filter_expression.resolve(context))
   File C:\svn\django\django\template\__init__.py, line 535, in resolve
 obj = self.var.resolve(context)
   File C:\svn\django\django\template\__init__.py, line 676, in resolve
 value = self._resolve_lookup(context)
   File C:\svn\django\django\template\__init__.py, line 705, in
 _resolve_lookup
 current = getattr(current, bit)
   File C:\svn\django\django\db\models\fields\related.py, line 248, in
 __get__
 rel_obj = QuerySet(self.field.rel.to).get(**params)
   File C:\svn\django\django\db\models\query.py, line 297, in get
 clone = self.filter(*args, **kwargs)
   File C:\svn\django\django\db\models\query.py, line 483, in filter
 return self._filter_or_exclude(False, *args, **kwargs)
   File C:\svn\django\django\db\models\query.py, line 501, in
 _filter_or_exclude
 clone.query.add_q(Q(*args, **kwargs))
   File C:\svn\django\django\db\models\sql\query.py, line 1224, in add_q
 can_reuse=used_aliases)
   File C:\svn\django\django\db\models\sql\query.py, line 1167, in
 add_filter
 self.where.add((alias, col, field, lookup_type, value), connector)
   File C:\svn\django\django\db\models\sql\where.py, line 48, in add
 params = field.get_db_prep_lookup(lookup_type, value)
   File C:\svn\django\django\db\models\fields\__init__.py, line 202, in
 get_db_prep_lookup
 return [self.get_db_prep_value(value)]
   File C:\svn\django\django\db\models\fields\__init__.py, line 353, in
 get_db_prep_value
 return int(value)
 ValueError: invalid literal for int(): changedesc_id

 Request Method: GET
 Request URL: http://clach04-745.ingres.prv:8000/r/62/
 Exception Type: TemplateSyntaxError
 Exception Value:

 Caught an exception while rendering: invalid literal for int():
 changedesc_id

 Original Traceback (most recent call last):
   File C:\svn\django\django\template\debug.py, line 71, in render_node
 result = node.render(context)
   File C:\svn\django\django\template\debug.py, line 87, in render
 output = force_unicode(self.filter_expression.resolve(context))
   File C:\svn\django\django\template\__init__.py, line 535, in resolve
 obj = self.var.resolve(context)
   File C:\svn\django\django\template\__init__.py, line 676, in resolve
 value = self._resolve_lookup(context)
   File C:\svn\django\django\template\__init__.py, line 705, in
 _resolve_lookup
 current = getattr(current, bit)
   File C:\svn\django\django\db\models\fields\related.py, line 248, in
 __get__
 rel_obj = QuerySet(self.field.rel.to).get(**params)
   File C:\svn\django\django\db\models\query.py, line 297, in get
 clone = self.filter(*args, **kwargs)
   File C:\svn\django\django\db\models\query.py, line 483, in filter
 return self._filter_or_exclude(False, *args, **kwargs)
   File C:\svn\django\django\db\models\query.py, line 501, in
 _filter_or_exclude
 clone.query.add_q(Q(*args, **kwargs))
   File C:\svn\django\django\db\models\sql\query.py, line 1224, in add_q
 can_reuse=used_aliases)
   File C:\svn\django\django\db\models\sql\query.py, line 1167, in
 add_filter
 self.where.add((alias, col, field, lookup_type, value), 

Re: Upgrade issues

[Ben]

I went to the admin part and looked for something that looks like
'reviews_reviewrequestdraft.changedesc_id' visited the right page
(http://server/admin/db/reviews/reviewrequestdraft/), did nothing,
saved, and it's gone ...

thanks anyway for pointing the right database ...

On Fri, Jul 17, 2009 at 15:38, Benal.ya...@gmail.com wrote:
 Hi there,

 Upgrading from an svn install I'm also hitting that one ...

 How did you solved it ? manually editing the database ?

 Regards,
 Benoit

 On Mon, Dec 8, 2008 at 20:12, Chris Clarkchris.cl...@ingres.com wrote:
 Christian Hammond wrote:

 This was due to a bug I'm currently fixing. I should have it in in about 15
 mins.

 I'm not sure which this referred to. I've pulled (new) headrevs - I still
 get the problem with htdocs and an existing review not viewable anymore.

 BUT I know how to deal with htdocs (I'll start using the new rb-site
 script).

 RE the review not visible anymore I now know what the problem is! If you
 have any reviews in Draft, i.e not yet published, and you are pre change
 description on review update, at the time of the evolve. With sqlite the
 evolve appears to use the string 'changedesc_id' for the
 reviews_reviewrequestdraft.changedesc_id column (supposed to be integer or
 null). For the draft reviews I've simple updated all the
 reviews_reviewrequestdraft.changedesc_id columns to NULL if they ==
 'changedesc_id' - I've not looked any further into this or checked other
 database engines.

 Summary of the problem:

 upgrade from release of RB that does not have the change description field
 on updated reviews
 using sqlite
 have an existing review, that is in draft (with some updated diffs)
 you are logged in as the review owner
 you evolve the database
 view review

 Error traceback (from debug on, so result go to web browser)

 TemplateSyntaxError at /r/62/

 Caught an exception while rendering: invalid literal for int():
 changedesc_id

 Original Traceback (most recent call last):
   File C:\svn\django\django\template\debug.py, line 71, in render_node
     result = node.render(context)
   File C:\svn\django\django\template\debug.py, line 87, in render
     output = force_unicode(self.filter_expression.resolve(context))
   File C:\svn\django\django\template\__init__.py, line 535, in resolve
     obj = self.var.resolve(context)
   File C:\svn\django\django\template\__init__.py, line 676, in resolve
     value = self._resolve_lookup(context)
   File C:\svn\django\django\template\__init__.py, line 705, in
 _resolve_lookup
     current = getattr(current, bit)
   File C:\svn\django\django\db\models\fields\related.py, line 248, in
 __get__
     rel_obj = QuerySet(self.field.rel.to).get(**params)
   File C:\svn\django\django\db\models\query.py, line 297, in get
     clone = self.filter(*args, **kwargs)
   File C:\svn\django\django\db\models\query.py, line 483, in filter
     return self._filter_or_exclude(False, *args, **kwargs)
   File C:\svn\django\django\db\models\query.py, line 501, in
 _filter_or_exclude
     clone.query.add_q(Q(*args, **kwargs))
   File C:\svn\django\django\db\models\sql\query.py, line 1224, in add_q
     can_reuse=used_aliases)
   File C:\svn\django\django\db\models\sql\query.py, line 1167, in
 add_filter
     self.where.add((alias, col, field, lookup_type, value), connector)
   File C:\svn\django\django\db\models\sql\where.py, line 48, in add
     params = field.get_db_prep_lookup(lookup_type, value)
   File C:\svn\django\django\db\models\fields\__init__.py, line 202, in
 get_db_prep_lookup
     return [self.get_db_prep_value(value)]
   File C:\svn\django\django\db\models\fields\__init__.py, line 353, in
 get_db_prep_value
     return int(value)
 ValueError: invalid literal for int(): changedesc_id

 Request Method: GET
 Request URL: http://clach04-745.ingres.prv:8000/r/62/
 Exception Type: TemplateSyntaxError
 Exception Value:

 Caught an exception while rendering: invalid literal for int():
 changedesc_id

 Original Traceback (most recent call last):
   File C:\svn\django\django\template\debug.py, line 71, in render_node
     result = node.render(context)
   File C:\svn\django\django\template\debug.py, line 87, in render
     output = force_unicode(self.filter_expression.resolve(context))
   File C:\svn\django\django\template\__init__.py, line 535, in resolve
     obj = self.var.resolve(context)
   File C:\svn\django\django\template\__init__.py, line 676, in resolve
     value = self._resolve_lookup(context)
   File C:\svn\django\django\template\__init__.py, line 705, in
 _resolve_lookup
     current = getattr(current, bit)
   File C:\svn\django\django\db\models\fields\related.py, line 248, in
 __get__
     rel_obj = QuerySet(self.field.rel.to).get(**params)
   File C:\svn\django\django\db\models\query.py, line 297, in get
     clone = self.filter(*args, **kwargs)
   File C:\svn\django\django\db\models\query.py, line 483, in filter
     return self._filter_or_exclude(False, *args, **kwargs)
   File 

Re: Something broke! (Error 500) after adding new Git repository

[Ben]

Hi there, what was the fix you did for this? I currently have exactly
the same issue and cannot make it work correctly.

On Jul 14, 11:57 pm, wezyde wes.bill...@gmail.com wrote:
 Looks like it was an error in the paths.  I had to enter some
 additional information in the mirror and also create a new local
 clone.

 Working now though.

 Thanks for the help.

 On Jul 14, 3:26 pm, wezyde wes.bill...@gmail.com wrote:

  I just ran...
  git --git-dir=/var/git/repositories/k2.git config
  core.repositoryformatversion

  and it responded with...
  0

  I'm not a python expert, but hopefully that is the command.

  In my repository setup I have
  /var/git/repositories/k2.git

  Thanks.

  On Jul 14, 3:03 pm, Christian Hammond chip...@chipx86.com wrote:

   Actually, it looks like it had trouble with the repository it was 
   configured
   with.

   The relevant code is:

       def __init__(self, path):
           self.path = path
           p = subprocess.Popen(
               ['git', '--git-dir=%s' % self.path, 'config',
                    'core.repositoryformatversion'],
               stderr=subprocess.PIPE,
               stdout=subprocess.PIPE,
               close_fds=(os.name != 'nt')
           )
           contents = p.stdout.read()
           errmsg = p.stderr.read()
           failure = p.wait()

           if failure:
               raise ImportError

   So maybe try executing that same command and making sure it works on the
   exact path specified in your repository info.

   Christian

   --
   Christian Hammond - chip...@chipx86.com
   Review Board -http://www.review-board.org
   VMware, Inc. -http://www.vmware.com

   On Tue, Jul 14, 2009 at 3:02 PM, wezyde wes.bill...@gmail.com wrote:

I definitely have Git on the server.  I'm using it for many projects.
Is is possible that there is an issue with permissions for the apache
user?

On Jul 14, 2:41 pm, Christian Hammond chip...@chipx86.com wrote:
 Looks like git isn't installed on that server.

 We're going to put in better error messages for such failure cases in
1.1,
 but for now, make sure git is installed and in the path.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.review-board.org
 VMware, Inc. -http://www.vmware.com

 On Tue, Jul 14, 2009 at 2:38 PM, wezyde wes.bill...@gmail.com wrote:

  I just installed reviewboard on a Ubuntu box and things were running
  well.  Once I add a new git repository and click on New Review
  Request I get the Something Broke! page.

  Can anyone help with this?

  Thanks.

  Traceback (most recent call last):

   File /usr/local/lib/python2.6/dist-packages/Django-1.0.2_final-
  py2.6.egg/django/core/handlers/base.py, line 86, in get_response
     response = callback(request, *callback_args, **callback_kwargs)

   File /usr/local/lib/python2.6/dist-packages/Djblets-0.5-py2.6.egg/
  djblets/auth/util.py, line 45, in _checklogin
     return view_func(request, *args, **kwargs)

   File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0-
  py2.6.egg/reviewboard/reviews/views.py, line 84, in
  new_review_request
     fields[repo.id] = repo.get_scmtool().get_fields()

   File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0-
  py2.6.egg/reviewboard/scmtools/models.py, line 40, in get_scmtool
     return cls(self)

   File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0-
  py2.6.egg/reviewboard/scmtools/git.py, line 18, in __init__
     self.client = GitClient(repository.path)

   File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0-
  py2.6.egg/reviewboard/scmtools/git.py, line 170, in __init__
     raise ImportError

  ImportError

  ModPythonRequest
  path:/r/new/,
  GET:QueryDict: {},
  POST:QueryDict: {},
  COOKIES:{'rbsessionid': 'a343a2ba1857c6035cfdd714e3e473c8'},
  META:{'AUTH_TYPE': None,
   'CONTENT_LENGTH': 0L,
   'CONTENT_TYPE': None,
   'GATEWAY_INTERFACE': 'CGI/1.1',
   'HTTP_ACCEPT': 'application/xml,application/xhtml+xml,text/
  html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5',
   'HTTP_ACCEPT_CHARSET': 'ISO-8859-1,utf-8;q=0.7,*;q=0.3',
   'HTTP_ACCEPT_ENCODING': 'gzip,deflate,bzip2,sdch',
   'HTTP_ACCEPT_LANGUAGE': 'en-US,en;q=0.8',
   'HTTP_CONNECTION': 'keep-alive',
   'HTTP_COOKIE': 'rbsessionid=a343a2ba1857c6035cfdd714e3e473c8',
   'HTTP_HOST': 'review.firmware',
   'HTTP_REFERER': 'http://review.firmware/account/preferences/?next=/
  dashboard/
   http://review.firmware/account/preferences/?next=/%0Adashboard/
  ',
   'HTTP_USER_AGENT': 'Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US)
  AppleWebKit/530.5 (KHTML, like Gecko) Chrome/2.0.172.33 
  Safari/530.5',
   'PATH_INFO': u'/r/new/',
   'PATH_TRANSLATED': None,
   'QUERY_STRING': None,
   'REMOTE_ADDR': 

post-review new files with Perforce

[Ben]

I am having a problem using ReviewBoard 1.6 with Perforce. When I run
post-review for a changelist with new files, I get an error while
posting the diffs. (post-review debug trace below). I have tried
uploading the diffs manually after generating them with post-review,
but I just get malformed patch errors on the server. This looks like
Issue 2054 to me, and I posted my information there.

Does anyone have this working or know of a workaround?

-Ben

 RBTools 0.3.3
 Home = C:\Users\ben\AppData\Roaming
 p4 info
 repository info: Path: lenel-sourceold.windows.lenel.com:1666, Base
 path: None, Supports changesets: True
 p4 counters
 HTTP GETting api/
 HTTP GETting http://10.112.8.55/api/info/
 Using the new web API
 Generating diff for changenum 206994
 p4 describe -s 206994
 Processing edit of //Development/Path/To/My/src/Solution.sln
 Writing //Development/Path/To/My/src/Solution.sln#10
 to c:\users\ben\appdata\local\temp\tmp5eiypf
 p4 print -o c:\users\ben\appdata\local\temp\tmp5eiypf -q
 //Development/Path/To/My/src/Solution.sln#10
 diff -urNp c:\users\ben\appdata\local\temp\tmp5eiypf
 D:/Development\Path\To\My\src\Solution.sln
 Processing add of
 //Development/OnGuard/Branches/Titan/DotNet/src/TwoFlower/app.config
 diff -urNp c:\users\ben\appdata\local\temp\tmporoe81
 D:/Development\Path\To\My\src\TwoFlower\app.config
 Processing add of //Development/Path/To/My/src/TwoFlower/PrincipalExt.cs
 diff -urNp c:\users\ben\appdata\local\temp\tmporoe81
 D:/Development\Path\To\My\src\TwoFlower\Principal.cs
 Processing add of //Development/Path/To/My/src/TwoFlower/Program.cs
 diff -urNp c:\users\ben\appdata\local\temp\tmporoe81
 D:/Development\Path\To\My\src\TwoFlower\Program.cs
 Processing add of
 //Development/Path/To/My/src/TwoFlower/Properties/AssemblyInfo.cs
 diff -urNp c:\users\ben\appdata\local\temp\tmporoe81
 D:/Development\Path\To\My\src\TwoFlower\Properties\AssemblyInfo.cs
 Processing add of
 //Development/Path/To/My/src/TwoFlower/TwoFlower.csproj
 diff -urNp c:\users\ben\appdata\local\temp\tmporoe81
 D:/Development\Path\To\My\src\TwoFlower\TwoFlower.csproj
 Processing add of
 //Development/Path/To/My/src/TwoFlower/WrappedServer.cs
 diff -urNp c:\users\ben\appdata\local\temp\tmporoe81
 D:/Development\Path\To\My\src\TwoFlower\WrappedServer.cs
 Attempting to create review request on
 lenel-sourceold.windows.lenel.com:1666 for 206994
 HTTP POSTing to http://10.112.8.55/api/review-requests/:
 {'changenum': '206994', 'repository': 
 'lenel-sourceold.windows.lenel.com:1666'}
 Got API Error 204 (HTTP code 409): The change number specified has
 already been used
 Error data: {u'stat': u'fail', u'review_request': {u'status':
 u'pending', u'last_updated': u'2011-09-13 17:28:43', u'description':
 u'Test rig for using two embedded application servers\n', u'links':
 {u'diffs': {u'href':
 u'http://10.112.8.55/api/review-requests/5/diffs/', u'method': u'GET'},
 u'repository': {u'href': u'http://10.112.8.55/api/repositories/2/',
 u'method': u'GET', u'title': u'Old OnGuard Repository'}, u'changes':
 {u'href': u'http://10.112.8.55/api/review-requests/5/changes/',
 u'method': u'GET'}, u'self': {u'href':
 u'http://10.112.8.55/api/review-requests/5/', u'method': u'GET'},
 u'update': {u'href': u'http://10.112.8.55/api/review-requests/5/',
 u'method': u'PUT'}, u'last_update': {u'href':
 u'http://10.112.8.55/api/review-requests/5/last-update/', u'method':
 u'GET'}, u'reviews': {u'href':
 u'http://10.112.8.55/api/review-requests/5/reviews/', u'method':
 u'GET'}, u'draft': {u'href':
 u'http://10.112.8.55/api/review-requests/5/draft/',u'method': u'GET'},
 u'file_attachments': {u'href':
 u'http://10.112.8.55/api/review-requests/5/file-attachments/',
 u'method': u'GET'}, u'submitter': {u'href':
 u'http://10.112.8.55/api/users/ben/', u'method': u'GET', u'title':
 u'ben'},u'screenshots': {u'href':
 u'http://10.112.8.55/api/review-requests/5/screenshots/', u'method':
 u'GET'}, u'delete': {u'href':
 u'http://10.112.8.55/api/review-requests/5/', u'method': u'DELETE'}},
 u'target_groups': [], u'bugs_closed': [], u'changenum': 206994,
 u'target_people': [], u'testing_done': u'', u'branch': u'', u'id': 5,
 u'time_added': u'2011-09-13 17:28:43', u'summary': u'Test rig for using
 two embedded application servers', u'public': False}, u'err': {u'msg':
 u'The change number specified has already been used', u'code': 204}}
 Review request already exists. Updating it...
 HTTP PUTting to http://10.112.8.55/api/review-requests/5/:
 {'changenum': 206994}
 Uploading diff, size: 16111
 HTTP POSTing to http://10.112.8.55/api/review-requests/5/diffs/: {}

Traceback (most recent call last):
   File c:\Python27\Scripts\post-review-script.py, line 8, in
module
 load_entry_point('rbtools==0.3.3', 'console_scripts', 'post-
review')()
File c:\Python27\lib\site-packages\rbtools-0.3.3-py2.7.egg\rbtools
\postreview.p y,
line 4004, in main
File c:\Python27\lib\site-packages\rbtools-0.3.3-py2.7.egg\rbtools
\postreview.p y,
line 3663, in tempt_fate
File c

Archive ClearCase review board

[Ben]

Hi,
I would like to migrate a reviewboard database configured with Clearcase 
and archive it in read only mode.

Any one know what live connection it needs with a clearcase replica (if 
any) for users to browse old reviews and diffs?

Is connection to live clearcase required?
if so
do branches uses to post reviews need to be mastered in the replica?
Thanks
Ben

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Archive ClearCase review board

[Ben]

Thank you Christian.
I want to port the ReviewBoard DB to a different site.

This may be an arcane follow-up question;
Would we need to ensure the ClearCase branches from posted reviews are 
mastered at the new site (writable).
Or is read only access at a different site sufficient for the closed 
reviews?
Thanks
Ben


On Wednesday, August 30, 2017 at 5:55:21 PM UTC-4, Christian Hammond wrote:
>
> Hi Ben,
>
> At the moment, you'll need to keep a working, accessible server around 
> with the same set of branches/commits, so that Review Board can access it. 
> Down the road, I expect we're going to provide proper archival 
> functionality of some sort (this might be a Power Pack feature) so you can 
> take the server offline. It'll be a post-3.0 project.
>
> Christian
>
> On Wed, Aug 30, 2017 at 11:03 AM, Ben <bsan...@gmail.com > 
> wrote:
>
>> Hi,
>> I would like to migrate a reviewboard database configured with Clearcase 
>> and archive it in read only mode.
>>
>> Any one know what live connection it needs with a clearcase replica (if 
>> any) for users to browse old reviews and diffs?
>>
>> Is connection to live clearcase required?
>> if so
>> do branches uses to post reviews need to be mastered in the replica?
>> Thanks
>> Ben
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
>
> -- 
> Christian Hammond
> President/CEO of Beanbag <https://www.beanbaginc.com/>
> Makers of Review Board <https://www.reviewboard.org/>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Fwd: User Account Management through REST API

[Ben Cooksley]

Forwarding due to delivery failure...

-- Forwarded message --
From: Eike Hein h...@kde.org
Date: Wed, Jun 30, 2010 at 9:40 PM
Subject: Re: User Account Management through REST API
To: reviewboard@googlegroups.com
Cc: sysad...@kde.org


On 6/30/2010 11:19 AM, Christian Hammond wrote:

 Right. It's best never to delete a user in Review Board. Marking them as
 inactive is fine, though.

That's fine, actually: Deleting users is not allowed in
Redmine, only disabling them.


--
Best regards,
Eike Hein

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Argh. I've managed to mess up an upgrade...

[Ben Bennett]

When tryhing to go to 1.6.1 I get:
# rb-site upgrade /var/www/localhost/reviewboard
Rebuilding directory structure
Updating database. This may take a while.
Creating tables ...
There are unapplied evolutions for accounts.
There are unapplied evolutions for changedescs.
There are unapplied evolutions for reviews.
There are unapplied evolutions for scmtools.
Adding baseline version for new models
Project signature has changed - an evolution is required
Installing custom SQL ...
Installing indexes ...
No fixtures found.
Traceback (most recent call last):
  File /usr/bin/rb-site-2.7, line 9, in module
load_entry_point('ReviewBoard==1.6.1', 'console_scripts', 'rb-
site')()
  File /usr/lib/python2.7/site-packages/reviewboard/cmdline/
rbsite.py, line 1747, in main
command.run()
  File /usr/lib/python2.7/site-packages/reviewboard/cmdline/
rbsite.py, line 1645, in run
site.migrate_database()
  File /usr/lib/python2.7/site-packages/reviewboard/cmdline/
rbsite.py, line 353, in migrate_database
self.run_manage_command(evolve, [--noinput, --execute])
  File /usr/lib/python2.7/site-packages/reviewboard/cmdline/
rbsite.py, line 472, in run_manage_command
execute_manager(reviewboard.settings, [__file__, cmd] + params)
  File /usr/lib/python2.7/site-packages/django/core/management/
__init__.py, line 438, in execute_manager
utility.execute()
  File /usr/lib/python2.7/site-packages/django/core/management/
__init__.py, line 379, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
  File /usr/lib/python2.7/site-packages/django/core/management/
base.py, line 191, in run_from_argv
self.execute(*args, **options.__dict__)
  File /usr/lib/python2.7/site-packages/django/core/management/
base.py, line 220, in execute
output = self.handle(*args, **options)
  File /usr/lib/python2.7/site-packages/django_evolution/management/
commands/evolve.py, line 60, in handle
self.evolve(*app_labels, **options)
  File /usr/lib/python2.7/site-packages/django_evolution/management/
commands/evolve.py, line 140, in evolve
database))
  File /usr/lib/python2.7/site-packages/django_evolution/
mutations.py, line 418, in mutate
return self.add_column(app_label, proj_sig, database)
  File /usr/lib/python2.7/site-packages/django_evolution/
mutations.py, line 426, in add_column
self.field_attrs, model)
  File /usr/lib/python2.7/site-packages/django_evolution/
mutations.py, line 33, in create_field
related_model_sig = proj_sig[related_app_name][related_model_name]


I see the same error message in Google with a follow-up indicating
that it was fixed by a syncdb, so I tried that:
# rb-site manage /var/www/localhost/reviewboard syncdb
Creating tables ...
There are unapplied evolutions for accounts.
There are unapplied evolutions for changedescs.
There are unapplied evolutions for reviews.
There are unapplied evolutions for scmtools.
Adding baseline version for new models
Project signature has changed - an evolution is required
Installing custom SQL ...
Installing indexes ...
No fixtures found.

Then I re-run the upgrade and it gets the same error.  If I manually
run:
# rb-site manage /var/www/localhost/reviewboard evolve -- -x

I get the same error.

Any assistance would be greatly appreciated.


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

updating review-requests

[Ben Holm]

I am using Perforce and I want to create a trigger to update the
review-request on code submission. I am getting strange behavior when I try
to update both the changenum and the status. The changenum is changed, it
seems like a draft is created, and the status does not change. A separate
call to change the status to submitted does work.

Am I misunderstanding something, or is there a bug here?

Here is what I am doing:

D:\curl -X PUT -F changenum=210649 -F status=submitted -k --basic -u
user:pass https://reviewboard.company.com/api/review-requests/27/

Thanks,
-Ben

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Delete users from sql, auth_user

[Ben Copeland]

Hello all,

I am writing a custom script so users can be added and deleted from 
reviewboard. However how can I delete a user from auth_user, because I got 
problems with the foreign key constraint. 

I am writing the script in php/mysql.

Cannot delete or update a parent row: a foreign key constraint fails 
(`reviewboard`.`accounts_profile`, CONSTRAINT `user_id_refs_id_46e869e2` 
FOREIGN KEY (`user_id`) REFERENCES `auth_user` (`id`))

What sql code would I need to delete, or make sure the user and history are 
deleted properly? 

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

deleting users from reviewboard using sql

[Ben Copeland]

Hello all,

How can I delete a user using sql code? I have coded a php app populates 
reviewboard users but I wish to delete users too. Because the use of foreign 
key constraint makes deleting a user out of the database hard due to all 
the links.


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Self Registration fault

[Ben Cooksley]

Hi all,

Since migrating one of our Reviewboard instances (we have two) to a
new system, I have been receiving mails from Reviewboard complaining
of various traceback errors.

The most common one of these relates to /account/register, and seems
to be a bug in Reviewboard. Does anyone know if this is a fault on our
side, or if a bug should be reported to Reviewboard/Djblets? It looks
to me like an import is missing, but i'm not sure if this is a defect
in our installation.

The traceback is below. We run Reviewboard on Debian Wheezy using
Apache's mod_wsgi and memcached for caching. The instance at question
is at https://svn.reviewboard.kde.org/. Our Git instance of
Reviewboard is unaffected as registrations for it are handled through
a separate system.

Thanks,
Ben Cooksley
KDE Sysadmin

Traceback (most recent call last):

  File 
/usr/local/lib/python2.7/dist-packages/Django-1.4.10-py2.7.egg/django/core/handlers/base.py,
line 111, in get_response
response = callback(request, *callback_args, **callback_kwargs)

  File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.20-py2.7.egg/reviewboard/accounts/views.py,
line 29, in account_register
form_class=RegistrationForm)

  File 
/usr/local/lib/python2.7/dist-packages/Djblets-0.7.27-py2.7.egg/djblets/auth/views.py,
line 95, in register
user = form.save()

  File 
/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.20-py2.7.egg/reviewboard/accounts/forms.py,
line 157, in save
user = DjbletsRegistrationForm.save(self)

  File 
/usr/local/lib/python2.7/dist-packages/Djblets-0.7.27-py2.7.egg/djblets/auth/forms.py,
line 76, in save
if get_object_or_none(User,

NameError: global name 'get_object_or_none' is not defined

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Self Registration fault

[Ben Cooksley]

On Wednesday, January 1, 2014 3:28:39 PM UTC+13, Christian Hammond wrote:

 Hi Ben,

 I can confirm this is a bug on our end. It's being triggered, most likely, 
 due to people trying to register someone else's username.

 I'll fix this in the next 10 minutes and put out a release. Give me 20 
 minutes or so just in case, and try an upgrade to 0.7.28.


Thanks Christian, I can confirm that fixed the issue for us.
The quick response is much appreciated.


 Christian


Thanks,
Ben
 


 -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com


 On Tue, Dec 31, 2013 at 5:14 PM, Ben Cooksley bcoo...@kde.orgjavascript:
  wrote:

 Hi all,

 Since migrating one of our Reviewboard instances (we have two) to a
 new system, I have been receiving mails from Reviewboard complaining
 of various traceback errors.

 The most common one of these relates to /account/register, and seems
 to be a bug in Reviewboard. Does anyone know if this is a fault on our
 side, or if a bug should be reported to Reviewboard/Djblets? It looks
 to me like an import is missing, but i'm not sure if this is a defect
 in our installation.

 The traceback is below. We run Reviewboard on Debian Wheezy using
 Apache's mod_wsgi and memcached for caching. The instance at question
 is at https://svn.reviewboard.kde.org/. Our Git instance of
 Reviewboard is unaffected as registrations for it are handled through
 a separate system.

 Thanks,
 Ben Cooksley
 KDE Sysadmin

 Traceback (most recent call last):

   File 
 /usr/local/lib/python2.7/dist-packages/Django-1.4.10-py2.7.egg/django/core/handlers/base.py,
 line 111, in get_response
 response = callback(request, *callback_args, **callback_kwargs)

   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.20-py2.7.egg/reviewboard/accounts/views.py,
 line 29, in account_register
 form_class=RegistrationForm)

   File 
 /usr/local/lib/python2.7/dist-packages/Djblets-0.7.27-py2.7.egg/djblets/auth/views.py,
 line 95, in register
 user = form.save()

   File 
 /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.20-py2.7.egg/reviewboard/accounts/forms.py,
 line 157, in save
 user = DjbletsRegistrationForm.save(self)

   File 
 /usr/local/lib/python2.7/dist-packages/Djblets-0.7.27-py2.7.egg/djblets/auth/forms.py,
 line 76, in save
 if get_object_or_none(User,

 NameError: global name 'get_object_or_none' is not defined

 --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/groups/opt_out.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Create Review-Request automatically on pushing to git-hub

[ben . bracha]

Hey, what's up?

I know this question was probably raised several times in the past, but 
after a long search I couldn't find a clear answer.

We are working with ReviewBoard and SVN for quite long time. We use a 
post-commit hook in order to automatically post review-requests to the 
review-board.
Each developer adds to the commit message a string like: RB: username, 
and our script creates a review request targeted for username.

We are now moving to github (using private repositories). 
I see that ReviewBoard has support for git-hub: I can configure my 
repository and such.
But - how can I trigger an automatic review-request on each push?

I can see that GitHub has a webhooks support - so I can trigger some 
POST command on each push. Probably this can be integrated with 
ReviewBoard API, although I'm not sure how we can parse the commit message 
in order to open the review-request for a specific user.

Does anyone has a working example? It should be quite common, I wonder how 
come I couldn't find anything clear on this.

Thanks

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Create Review-Request automatically on pushing to git-hub

[ben . bracha]

Hey, what's up?

I know this question was probably raised several times in the past, but 
after a long search I couldn't find a clear answer.

We are working with ReviewBoard and SVN for quite long time. We use a 
post-commit hook in order to automatically post review-requests to the 
review-board.
Each developer adds to the commit message a string like: RB: username, 
and our script creates a review request targeted for username.

We are now moving to github (using private repositories). 
I see that ReviewBoard has support for git-hub: I can configure my 
repository and such.
But - how can I trigger an automatic review-request on each push?

I can see that GitHub has a webhooks support - so I can trigger some 
POST command on each push. Probably this can be integrated with 
ReviewBoard API, although I'm not sure how we can parse the commit message 
in order to open the review-request for a specific user.

Does anyone has a working example? It should be quite common, I wonder how 
come I couldn't find anything clear on this.

Thanks

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Google Chrome defect breaks parts of Reviewboard

[Ben Cooksley]

Hi all,

Just a heads up that in certain scenarios Google Chrome might prevent
your users from downloading diffs from Reviewboard. See
https://code.google.com/p/reviewboard/issues/detail?id=3704 for more
information.

Despite what Chrome says, the headers are fine. A temporary fix is
available within the report.
It is the only browser and client affected by this.

Thanks,
Ben Cooksley
KDE Sysadmin

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

How Do I Delete One of Google Reviews

[Ben Scott]

How Do I Delete One of Google Reviews

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Reviewboard upgrade failure

[Ben Cooksley]

On Fri, Jan 15, 2016 at 11:04 PM, Christian Hammond
<christ...@beanbaginc.com> wrote:
> Hi Ben,
>
> This is due to a mismatch between MySQL table types. The existing tables are
> likely MyISAM, with MySQL now defaulting to InnoDB for new ones. You'll need
> to either migrate all the existing tables, or tell MySQL to use the existing
> type for new tables.
>
> (It's a pretty terrible error, but unfortunately, beyond our control. I just
> recognize this sort of problem.)

Argh. Our systems usually have InnoDB as default, guess that isn't the
case when we originally had Reviewboard provisioned.
I shouldn't see any issues migrating all tables into InnoDB correct?

>
> Christian

Cheers,
Ben

>
> --
> Christian Hammond - christ...@beanbaginc.com
> Review Board - https://www.reviewboard.org
> Beanbag, Inc. - https://www.beanbaginc.com
>
> On Thu, Jan 14, 2016 at 11:27 PM, Ben Cooksley <bcooks...@kde.org> wrote:
>>
>> Hi everyone,
>>
>> While upgrading from Reviewboard 2.0.17 to 2.5.2 i've encountered a
>> few SQL errors.
>> Reviewboard itself appears to boot and run fine though, based on the
>> nature of the errors I suspect it's a case of index name collisions.
>>
>> Output from the upgrade process is below:
>>
>> (virtualenv)reviewboard@mimi:~$ rb-site upgrade
>> /srv/www/reviewboard/git.reviewboard.kde.org/
>> Rebuilding directory structure
>> Updating database. This may take a while.
>>
>> The log output below, including warnings and errors,
>> can be ignored unless upgrade fails.
>>
>> --  --
>> Creating tables ...
>> Creating table accounts_trophy
>>
>> [!] There was an error synchronizing the database. Make sure the
>> database is created and has the appropriate permissions, and then
>> continue.
>> [!] Details: (1005, "Can't create table 'reviewboard_git.#sql-
>> 331d_214215' (errno: 150)")
>>
>> Press Enter to continue
>> Creating tables ...
>> Creating table attachments_fileattachmenthistory
>> Creating table diffviewer_rawfilediffdata
>> Creating table notifications_webhooktarget_repositories
>>
>> [!] There was an error synchronizing the database. Make sure the
>> database is created and has the appropriate permissions, and then
>> continue.
>> [!] Details: (1005, "Can't create table 'reviewboard_git.#sql-
>> 331d_214215' (errno: 150)")
>>
>> Press Enter to continue
>> Creating tables ...
>> Creating table notifications_webhooktarget
>>
>> [!] There was an error synchronizing the database. Make sure the
>> database is created and has the appropriate permissions, and then
>> continue.
>> [!] Details: (1005, "Can't create table 'reviewboard_git.#sql-
>> 331d_214215' (errno: 150)")
>>
>> Press Enter to continue
>> Creating tables ...
>> Creating table webapi_webapitoken
>>
>> [!] There was an error synchronizing the database. Make sure the
>> database is created and has the appropriate permissions, and then
>> continue.
>> [!] Details: (1005, "Can't create table 'reviewboard_git.#sql-
>> 331d_214215' (errno: 150)")
>>
>> Press Enter to continue
>> Creating tables ...
>> Upgrading Review Board from 2.0.17 to 2.5.2
>> There are unapplied evolutions for accounts.
>> There are unapplied evolutions for attachments.
>> There are unapplied evolutions for diffviewer.
>> There are unapplied evolutions for notifications.
>> There are unapplied evolutions for reviews.
>> There are unapplied evolutions for webapi.
>> Adding baseline version for new models
>> Evolutions in notifications baseline: webhooktarget_extra_state,
>> webhooktarget_extra_data_null
>> Project signature has changed - an evolution is required
>> Installing custom SQL ...
>> Installing indexes ...
>> Installed 0 object(s) from 0 fixture(s)
>> CommandError: Error applying evolution: (1005, "Can't create table
>> 'reviewboard_git.#sql-331d_214238' (errno: 150)")
>>
>> Any pointers?
>>
>> Cheers,
>> Ben Cooksley
>> KDE Sysadmin
>>
>> --
>>
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "reviewboard-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>
>
> --
>
> ---
> You recei

Re: Reviewboard upgrade failure

[Ben Cooksley]

On Sat, Jan 16, 2016 at 6:09 AM, Christian Hammond <chip...@chipx86.com> wrote:
> Hi Ben,
>
> You'll have a much easier time restoring from a backup. It's hard to say how
> far it went through the evolution process, and unfortunately today it
> doesn't keep track of how far it got and what it'd have to do to recover.
> You'd have a lot of trial and error to fix it manually. You can try it,
> though.
>
> Basically, you'll need to dump the SQL that the evolutions want to apply,
> and go through and hand-undo each thing it did until you get back to the
> point of where it was. You'd definitely want to do a backup first, though.

Unfortunately people had started using it already so this was the
easiest approach :(

Would it be possible to get a copy of a normally, safely upgraded
schema so I can double check I haven't clobbered anything?

The queries I ended up having to run to revert things to a state where
the upgrade process would work was:

160115 19:34:12 2197763 Query   ALTER TABLE
accounts_reviewrequestvisit DROP COLUMN visibility
160115 19:34:24 2197763 Query   DROP INDEX
`accounts_reviewrequestvisit_05ee5d21` ON
`accounts_reviewrequestvisit`
160115 19:34:45 2197763 Query   ALTER TABLE attachments_fileattachment
DROP COLUMN attachment_revision, DROP COLUMN attachment_history_id
160115 19:34:58 2197763 Query   ALTER TABLE diffviewer_filediff DROP
COLUMN raw_diff_hash_id, DROP COLUMN raw_parent_diff_hash_id
160115 19:36:18 2197763 Query   ALTER TABLE `reviews_group` DROP
COLUMN `email_list_only`, DROP COLUMN is_default_group
160115 19:36:25 2197763 Query   DROP TABLE
reviews_reviewrequest_file_attachment_histories

Note that I observed that the Reviewboard process tries to reverse
it's failed upgrade by doing a rollback. It is noted in the case of
InnoDB that schema changes cannot be rolled back (see
http://www.sitepoint.com/mysql-transaction-gotchas-good-parts/)

>
> Christian

Cheers,
Ben

>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board - https://www.reviewboard.org
> Beanbag, Inc. - https://www.beanbaginc.com
>
> On Fri, Jan 15, 2016 at 2:26 AM, Ben Cooksley <bcooks...@kde.org> wrote:
>>
>> On Fri, Jan 15, 2016 at 11:09 PM, Ben Cooksley <bcooks...@kde.org> wrote:
>> > On Fri, Jan 15, 2016 at 11:04 PM, Christian Hammond
>> > <christ...@beanbaginc.com> wrote:
>> >> Hi Ben,
>> >>
>> >> This is due to a mismatch between MySQL table types. The existing
>> >> tables are
>> >> likely MyISAM, with MySQL now defaulting to InnoDB for new ones. You'll
>> >> need
>> >> to either migrate all the existing tables, or tell MySQL to use the
>> >> existing
>> >> type for new tables.
>> >>
>> >> (It's a pretty terrible error, but unfortunately, beyond our control. I
>> >> just
>> >> recognize this sort of problem.)
>> >
>> > Argh. Our systems usually have InnoDB as default, guess that isn't the
>> > case when we originally had Reviewboard provisioned.
>> > I shouldn't see any issues migrating all tables into InnoDB correct?
>>
>> Seems it is safe.
>> Unfortunately it looks like one of the evolutions got part way through
>> the process.
>>
>> CommandError: Error applying evolution: (1060, "Duplicate column name
>> 'visibility'")
>>
>> Any suggestions (I could restore from backups, but if I can avoid it...)?
>>
>> >
>> >>
>> >> Christian
>> >
>> > Cheers,
>> > Ben
>>
>> Thanks,
>> Ben
>>
>> >
>> >>
>> >> --
>> >> Christian Hammond - christ...@beanbaginc.com
>> >> Review Board - https://www.reviewboard.org
>> >> Beanbag, Inc. - https://www.beanbaginc.com
>> >>
>> >> On Thu, Jan 14, 2016 at 11:27 PM, Ben Cooksley <bcooks...@kde.org>
>> >> wrote:
>> >>>
>> >>> Hi everyone,
>> >>>
>> >>> While upgrading from Reviewboard 2.0.17 to 2.5.2 i've encountered a
>> >>> few SQL errors.
>> >>> Reviewboard itself appears to boot and run fine though, based on the
>> >>> nature of the errors I suspect it's a case of index name collisions.
>> >>>
>> >>> Output from the upgrade process is below:
>> >>>
>> >>> (virtualenv)reviewboard@mimi:~$ rb-site upgrade
>> >>> /srv/www/reviewboard/git.reviewboard.kde.org/
>> >>> Rebuilding directory structure
>> >>> Updating database. This may take a while.
>> >>>
>> >>> The log output below,

Reviewboard upgrade failure

[Ben Cooksley]

Hi everyone,

While upgrading from Reviewboard 2.0.17 to 2.5.2 i've encountered a
few SQL errors.
Reviewboard itself appears to boot and run fine though, based on the
nature of the errors I suspect it's a case of index name collisions.

Output from the upgrade process is below:

(virtualenv)reviewboard@mimi:~$ rb-site upgrade
/srv/www/reviewboard/git.reviewboard.kde.org/
Rebuilding directory structure
Updating database. This may take a while.

The log output below, including warnings and errors,
can be ignored unless upgrade fails.

--  --
Creating tables ...
Creating table accounts_trophy

[!] There was an error synchronizing the database. Make sure the
database is created and has the appropriate permissions, and then
continue.
[!] Details: (1005, "Can't create table 'reviewboard_git.#sql-
331d_214215' (errno: 150)")

Press Enter to continue
Creating tables ...
Creating table attachments_fileattachmenthistory
Creating table diffviewer_rawfilediffdata
Creating table notifications_webhooktarget_repositories

[!] There was an error synchronizing the database. Make sure the
database is created and has the appropriate permissions, and then
continue.
[!] Details: (1005, "Can't create table 'reviewboard_git.#sql-
331d_214215' (errno: 150)")

Press Enter to continue
Creating tables ...
Creating table notifications_webhooktarget

[!] There was an error synchronizing the database. Make sure the
database is created and has the appropriate permissions, and then
continue.
[!] Details: (1005, "Can't create table 'reviewboard_git.#sql-
331d_214215' (errno: 150)")

Press Enter to continue
Creating tables ...
Creating table webapi_webapitoken

[!] There was an error synchronizing the database. Make sure the
database is created and has the appropriate permissions, and then
continue.
[!] Details: (1005, "Can't create table 'reviewboard_git.#sql-
331d_214215' (errno: 150)")

Press Enter to continue
Creating tables ...
Upgrading Review Board from 2.0.17 to 2.5.2
There are unapplied evolutions for accounts.
There are unapplied evolutions for attachments.
There are unapplied evolutions for diffviewer.
There are unapplied evolutions for notifications.
There are unapplied evolutions for reviews.
There are unapplied evolutions for webapi.
Adding baseline version for new models
Evolutions in notifications baseline: webhooktarget_extra_state,
webhooktarget_extra_data_null
Project signature has changed - an evolution is required
Installing custom SQL ...
Installing indexes ...
Installed 0 object(s) from 0 fixture(s)
CommandError: Error applying evolution: (1005, "Can't create table
'reviewboard_git.#sql-331d_214238' (errno: 150)")

Any pointers?

Cheers,
Ben Cooksley
KDE Sysadmin

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Can the Slack integration be configured to omit or truncate the Description?

[Ben ST]

Hi Christian -- thanks for the detailed reply. So to explain the request in 
more detail:

We have no concern about the Summary field, nor the repo name or branch. 
It's really only the Description field we care about because it contains 
potentially unbounded amounts of text, and maybe sensitive source code that 
we wouldn't necessarily want unexpected Slack users seeing. Slack channel 
membership is not as tightly controlled as Git repo access is for 
developers -- it's pretty easy to invite someone to a Slack channel, so the 
person posting doesn't always know the exact readership.

Interesting that you mentioned screenshots -- I tested a review with a 
screenshot and that didn't show up in Slack in fact, so I assumed it was 
deliberate. I think if possible we would want to skip attachments in 
principle. It's less clear cut than the Description and probably wouldn't 
be a killer as long as they were just URLs, though if they displayed as 
full images in Slack it would bulk out the notification a lot. We'd prefer 
the Slack notification to be a basic "something changed" type of thing and 
people who care can follow the link back to the review.

Apart from code confidentiality issues, our Slack admins are very nervous 
about any automated process making posts without some kind of size sanity 
checks. I think if the Description field had a maximum length (we'd 
probably choose 100 or 200 chars) that would be a big help to get it 
approved.

Thanks for the subclassing suggestion. I might take a look at that.

-- Ben

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/f7355248-ebf2-43f0-9fd0-fda2b7468f03%40googlegroups.com.

Re: Can the Slack integration be configured to omit or truncate the Description?

[Ben ST]

Hi Christian -- thanks for the detailed reply. So to explain the request in 
more detail:

We have no concern about the Summary field, nor the repo name or branch. 
It's really only the Description field we care about because it contains 
potentially unbounded amounts of text, and maybe sensitive source code that 
we wouldn't necessarily want unexpected Slack users seeing. Slack channel 
membership is not as tightly controlled as Git repo access is for 
developers -- it's pretty easy to invite someone to a Slack channel, so the 
person posting doesn't always know the exact readership.

Interesting that you mentioned screenshots -- I tested a review with a 
screenshot and that didn't show up in Slack in fact, so I assumed it was 
deliberate. I think if possible we would want to skip attachments in 
principle. It's less clear cut than the Description and probably wouldn't 
be a killer as long as they were just URLs, though if they displayed as 
full images in Slack it would bulk out the notification a lot. We'd prefer 
the Slack notification to be a basic "something changed" type of thing and 
people who care can follow the link back to the review.

Apart from code confidentiality issues, our Slack admins are very nervous 
about any automated process making posts without some kind of size sanity 
checks. I think if the Description field had a maximum length (we'd 
probably choose 100 or 200 chars) that would be a big help to get it 
approved.

Thanks for the subclassing suggestion. I might take a look at that.

-- Ben.

On Wednesday, 23 October 2019 06:58:56 UTC+1, Christian Hammond wrote:
>
> Hi Ben,
>
> We don't have any way of doing this built-in, I'm afraid. I want to 
> understand this in more detail.
>
> So the main concern is that you're looking to limit what information Slack 
> receives, and the main source of this information in your case would be in 
> the description, correct? Are there any concerns about the summary or any 
> fields (branch, repository, etc.) being sent as well? If a review request 
> has an attached screenshot, it will be shown as well, so would that also 
> need to be filtered out?
>
> One approach, which admittedly is more involved but gives you more control 
> over what gets sent, is to write your own extension that registers a 
> subclass of our own SlackIntegration (
> https://github.com/reviewboard/rbintegrations/blob/master/rbintegrations/slack/integration.py#L155
> ).
>
> That subclass would override notify(), altering some of the fields and 
> stripping away the description, screenshots, or whatever else you need to 
> remove, and then call the parent with the new method.
>
> Your Extension subclass would be simple, just something like:
>
>
> from reviewboard.extensions.base import Extension
> from reviewboard.extensions.hooks import IntegrationHook
>
> class MySlackExtension(Extension):
> def initialize(self):
>     IntegrationHook(self, MySlackIntegration)
>
>
> Christian
>
> On Tue, Oct 22, 2019 at 8:03 AM Ben ST > 
> wrote:
>
>> Hi
>>
>> I am experimenting with the Slack integration (RB 3.0.15). Currently all 
>> of the RB Description body is sent to Slack. Is there a way to limit the 
>> post just to the Summary?
>>
>> For confidentiality/security reasons our system admins don't want code 
>> posted into Slack channels, at least not by an automated system. So I can't 
>> use the Slack integration as it is. Or if there was a way to limit the 
>> Description to a max length like 250 chars, that would be good enough.
>>
>> Thanks.
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "Review Board Community" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to revie...@googlegroups.com .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/reviewboard/511c5ed2-6d32-471a-b7de-38d22479abca%40googlegroups.com
>>  
>> <https://groups.google.com/d/msgid/reviewboard/511c5ed2-6d32-471a-b7de-38d22479abca%40googlegroups.com?utm_medium=email_source=footer>
>> .
>>
>
>
> -- 
> Christian Hammond
> President/CEO of Beanbag <https://www.beanbaginc.com/>
> Makers of Review Board <https://www.reviewboard.org/>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board 

Can the Slack integration be configured to omit or truncate the Description?

[Ben ST]

Hi

I am experimenting with the Slack integration (RB 3.0.15). Currently all of 
the RB Description body is sent to Slack. Is there a way to limit the post 
just to the Summary?

For confidentiality/security reasons our system admins don't want code 
posted into Slack channels, at least not by an automated system. So I can't 
use the Slack integration as it is. Or if there was a way to limit the 
Description to a max length like 250 chars, that would be good enough.

Thanks.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/511c5ed2-6d32-471a-b7de-38d22479abca%40googlegroups.com.

Re: HTTP 0 error with larger reviews (Docker image)

[Ben ST]

Thanks very much for the reply, Christian. You're absolutely right and it 
is the email send that is hanging. It works fine configured the same way 
outside of a Docker container. The odd thing is that after the hang and 
timeout the email does actually get delivered, so it's not a complete 
network failure.

I'll have to figure out what Docker is doing. Can you tell me anything 
about how RB sends the emails -- does it use some particular subsystem?

I tried setting uwsgi to use multiple processes but it didn't make a 
difference.

-- Ben.


On Tuesday, 1 October 2019 19:51:48 UTC+1, Christian Hammond wrote:
>
> Hi Ben,
>
> If this is happening at Publish time, then my first guess would be that 
> something is going wrong with sending an e-mail. That, or custom WebHooks, 
> are the only blocking operations that exist in the publish process (we do 
> want to make these non-blocking in the future, fwiw).
>
> Try disabling e-mails entirely and see if that fixes the problem. WebHooks 
> as well, if they're configured.
>
> What concerns me a bit is the Connection Refused errors. I looked at the 
> Docker image and I suspect part of what's happening is that uwsgi (set up 
> in the image) is running multi-threaded but only with a single process. 
> This can lead to blocking issues. You're really going to want to update 
> that to use multiple processes, for things like this. Maybe start with 10, 
> go up from there. You'll have to determine what numbers are best for your 
> scale (and how many Docker instances you plan to run). It doesn't look like 
> the image natively supports customizing this, so you'll probably have to 
> fork the image.
>
> Christian
>
> On Thu, Sep 26, 2019 at 8:39 AM Ben ST > 
> wrote:
>
>> I have installed ReviewBoard using Docker and the ikatson/reviewboard 
>> image. I thought it was all working and some small test diffs I posted 
>> worked fine. Then when we tried to use some real diffs that were a bit 
>> larger, ReviewBoard shows "Saving" for a long time (~60 seconds) and gives 
>> a "HTTP 0" error. See attached screen shot.
>>
>> This is not a stupidly large diff. It's around 50 files, and an attached 
>> 6MB movie. The diff upload itself, and attaching the movie, work fine. The 
>> error happens when you try to publish. I am using HTTP on port 8000.
>>
>> Does anyone know what is causing this? Thanks.
>>
>> ReviewBoard log:
>>
>> 2019-09-26 11:23:59,273 - INFO -  - root - Reloading logging settings
>> 2019-09-26 11:24:02,977 - DEBUG - None - bestave - 
>> /reviews/r/1/_fragments/diff-comments/1/ - root - Begin: Generating diff 
>> file info for diffset id 1, filediff 2
>> 2019-09-26 11:24:03,632 - DEBUG - None - bestave - 
>> /reviews/r/1/_fragments/diff-comments/1/ - root - End: Generating diff file 
>> info for diffset id 1, filediff 2
>> 2019-09-26 11:24:03,633 - DEBUG - None - bestave - 
>> /reviews/r/1/_fragments/diff-comments/1/ - root - Generating diff file info 
>> for diffset id 1, filediff 2 took 0.655330 seconds
>> 2019-09-26 11:25:17,069 - DEBUG -  - root - Calculated issue counts for 
>> review request ID 1 across 1 review(s): Resulting counts = {u'A': 0, u'B': 
>> 0, u'R': 0, u'D': 0, u'O': 1}; DB values = 
>> [{u'screenshot_comments__issue_status': None, 
>> u'general_comments__issue_opened': True, u'file_attachment_comments__pk': 
>> None, u'screenshot_comments__issue_opened': None, u'comments__pk': None, 
>> u'general_comments__pk': 1, u'comments__issue_opened': None, 
>> u'general_comments__issue_status': u'O', 
>> u'file_attachment_comments__issue_opened': None, 
>> u'screenshot_comments__pk': None, u'comments__issue_status': None, 
>> u'file_attachment_comments__issue_status': None}]; Field IDs = 
>> {u'screenshot_comments': set([]), u'general_comments': set([1]), 
>> u'comments': set([]), u'file_attachment_comments': set([])}
>>
>>
>> Chrome console (also in a screen shot):
>> base.min.af574b99af97.js:3 [Deprecation] The Notification API may no 
>> longer be used from insecure origins. You should consider switching your 
>> application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz 
>> for more details.
>> setup @ base.min.af574b99af97.js:3
>> :8000/reviews/api/review-requests/1/reviews/draft/?1569497084270_format=json=html=raw%2Cmarkdown:1
>>  
>> Failed to load resource: the server responded with a status of 404 (NOT 
>> FOUND)
>> reviews.min.62c9e1499e46.js:5 Failed to save review Arguments(2)0: r 
>> {cid: "c20", attributes: {…}, _changing: false, _previousAttributes: {…}, 
>> changed: {…}, …}attributes: {parentObject: r,

Do you need a mirror path if using local Git repositories?

[Ben ST]

If Review Board is set up to only use local Git repositories, would it ever 
contact the remote Git server? Do I need to specify the remote URL in the 
mirror path?

I'm just trying to simplify my configuration to eliminate scope for network 
and/or authentication issues. In the Repository admin page I have removed 
the Mirror path, and also the SSH key, and all still seems to work.

Thanks.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/b4f35bbb-3a38-470b-afeb-38aa0ba8362b%40googlegroups.com.

Publishing a review request by a user other than the submitter

[hanen ben elarbi]

Hi,
It seems that only  the submitter can publish a review request !!
Even if we grant the permission to change review request the reviewer
cant publish it.
is there any alternative to make other reviewers make this ?
thx,

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: How to log in reviewboard !!!

[hanen ben elarbi]

Thanks Christian,
I can retrieve the rbsessionid of a reviewboard user from a third party
webapplication.
But is it possible to pass this rbsession to my browser to let it connect
to reviewboard
through a link an api or other ?

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Review Board Ticket #4561: Are Perforce Task Streams supported

[Ben Allen]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4561/
--

New ticket #4561 by BenA
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect


--
Are Perforce Task Streams supported
==

# What version are you running?

>> > Running on Linux-2.6.18-194.el5-x86_64-with-redhat-5.5-Tikanga
70  16:19   [GCC 4.4.4 20100726 ( Red Hat 4.4.4-13 ) ]
71  16:19   >> > Python 2.7.2 ( default, Mar 26 2013, 18:57:24 )
72  16:19   >> > RBTools 0.7.6

Are Peforce Task Streams supported?

# What steps will reproduce the problem?
1. create a Task Stream in Task Stream Depot.
2. Create a change list
3. submit review for change list
4. /grid/common/pkgs/python/v2.7.2/bin/rbt post --bugs-closed 17 -p 9065

# What is the expected output? What do you see instead
Review as usual. Seeing an issue on displaying the diffs.

There was an error displaying this diff.
The patch to '//depot/t_2027/C_Macros.hppa' didn't apply cleanly. The temporary 
files have been left in '/tmp/reviewboard.mYtZ9l' for debugging purposes.
`patch` returned:
This may be a bug in the software, a temporary outage, or an issue with the 
format of your diff.
Please try again, and if you still have trouble, contact support.

# What operating system are you using? What browser?
Chrome browser
 
# Please provide any additional information below.

Is the combination of task streams and P4 supported?

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools Ticket #4825: rbt diff fails for git-p4 repo with Python 3.7.2 on Windows.

[Ben Jackson]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4825/
--

New update by alebastr
For Beanbag, Inc. > RBTools > Ticket #4825


Reply:

How about this patch ?

```
commit ad51dadc52685520293a0ed226b95649b4104298
Author: Ben Jackson 
Date:   Wed Apr 24 10:16:37 2019 +0100

Fix unicode errors

diff --git a/rbtools/clients/git.py b/rbtools/clients/git.py
index 142e547..cd4d459 100644
--- a/rbtools/clients/git.py
+++ b/rbtools/clients/git.py
@@ -925,7 +925,9 @@ class GitClient(SCMClient):
 p4rev = b''

 # Find which depot changelist we're based on
-log = self._execute([self.git, 'log', merge_base], 
ignore_errors=True)
+log = self._execute([self.git, 'log', merge_base],
+ignore_errors=True,
+results_unicode=False)

 for line in log:
 m = re.search(br'[rd]epo.-paths = "(.+)": change = (\d+).*]',
@@ -952,23 +954,24 @@ class GitClient(SCMClient):
 elif (line.startswith(b'--- ') and i + 1 < len(diff_lines) and
   diff_lines[i + 1].startswith(b'+++ ')):
 data = self._execute(
-['p4', 'files', base_path + filename + '@' + p4rev],
-ignore_errors=True, results_unicode=False)
+[b'p4', b'files', base_path + filename + b'@' + p4rev],
+ignore_errors=True,
+results_unicode=False)
 m = re.search(br'^%s%s#(\d+).*$' % (re.escape(base_path),
 re.escape(filename)),
   data, re.M)
 if m:
 file_version = m.group(1).strip()
 else:
-file_version = 1
+file_version = b'1'

-diff_data += b'--- %s%s\t%s%s#%s\n' % (base_path, filename,
+diff_data += ( b'--- %s%s\t%s%s#%s\n' % (base_path, 
filename,
base_path, filename,
-   file_version)
+   file_version) )
 elif line.startswith(b'+++ '):
 # TODO: add a real timestamp
-diff_data += b'+++ %s%s\t%s\n' % (base_path, filename,
-  b'TIMESTAMP')
+diff_data += ( b'+++ %s%s\t%s\n' % (base_path, filename,
+  b'TIMESTAMP') )
 else:
 diff_data += line

```

works for me...

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20191203171142.30925.62351%40ip-10-1-54-209.ec2.internal.

Re: RBTools Ticket #4825: rbt diff fails for git-p4 repo with Python 3.7.2 on Windows.

[Ben Jackson]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4825/
--

New update by alebastr
For Beanbag, Inc. > RBTools > Ticket #4825


Reply:

i posted it really in the hope that it would be useful. apologies, but i 
don't have the bandwidth right now to do a proper 9 yards on it, not least 
because it was many months ago that i made the change and i no longer have the 
code paged in :)

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20200117182147.23864.85934%40ip-10-1-54-209.ec2.internal.

Re: Review Board Ticket #4988: Fail to post diff with perforce repo: 'Value to convert is unexpected type %s',

[Ben Jackson]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4988/
--

New update by benjackson
For Beanbag, Inc. > Review Board > Ticket #4988


Reply:

https://reviews.reviewboard.org/r/12798/
https://reviews.reviewboard.org/r/12799/

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20230123101747.23038.44754%40ip-10-1-54-209.ec2.internal.

Review Board Ticket #4988: Fail to post diff with perforce repo: 'Value to convert is unexpected type %s',

[Ben Jackson]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4988/
--

New ticket #4988 by benjackson
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect

File attachments:

 * PRE-CREATION.png
   

 * PRE-CREATION-assignment-call-stack.png
   



--
Fail to post diff with perforce repo: 'Value to convert is unexpected type %s', 

==

# What version are you running?

4.0.11

# What's the URL of the page containing the problem?

`│>>> Making HTTP POST request to http://ukfd-ltp4l:49320/api/validation/diffs/`


# What steps will reproduce the problem?

It doesn't seem to happen for all diffs where a new file is added, but it's 
certainly related to adding new files, with perforce as the repo type. 
Specifically, it needs to go though these lines in `perforce.py` where the old 
revision is set to `PRE_CREATION`.

```
# Older versions of Perforce had this lovely idiosyncracy that diffs
# show revision #1 both for pre-creation and when there's an actual
# revision. In this case, we need to check if the file already exists
# in the repository.
#
# Newer versions use #0, so it's quicker to check.
if (revision == b'0' or
(revision == b'1' and
 not self.repository.get_file_exists(filename.decode('utf-8'),
 revision.decode('utf-8':
revision = PRE_CREATION


```

1. Using git-p4 client repo, add a new file and commit that
2. rbt post

As i said, i debugged it a bit but wasn't 100% sure why this didn't happen for 
every new file add. See below for the exact exception and code which is 
triggering it. Attached screenshots of debugger showing the call stacks where 
it's assigned etc.

I can easily repro this with a specific commit right now, and have a debug 
environment set up, so please shout if there is more info I can provide.


# What is the expected output? What do you see instead?

Diff created.
Actual: Exceptoin TypeError: ('Value to convert is unexpected type %s', )

```
$>rbt post --repository perforce:1666 --server http://ukfd-ltp4l:49320 
675417754ac980cc60d9b72eddaf9f9cb80817dd

Unexpected error when validating the diff: ('Value to convert is unexpected 
type %s', ) (API Error 224: Diff 
Parsing Failed)
ukfd-ltp4l(benj:TESTKIT_main.git) TESTKIT/main.git>

```

# What operating system are you using? What browser?

RHEL7

Also reproduced in a minimal ubuntu 20.02 container (based on 
contrib/docker/Dockerfile)

# Please provide any additional information below.

The issue appears to be with this code in filediff_creator.py:

```
# Store the information on the parent's filename and revision.
# It's important we force these to text, since they may be
# byte strings and the revision may be a Revision instance.
#
# Starting in Review Board 4.0.5, we store this any time there's
# a parent diff, whether or not the file existed in the parent
# diff.
extra_data.update({
FileDiff._IS_PARENT_EMPTY_KEY: parent_is_empty,
'parent_source_filename':
convert_to_unicode(parent_source_filename,
   encoding_list)[1],
'parent_source_revision':
convert_to_unicode(parent_source_revision,
   encoding_list)[1],
})



```

Per the comment, the argument `parent_source_revision` may be a `Revision` 
object (in this case, it is literally `PRE_CREATION` which is an instance of 
`Revision`, however `convert_to_unicode` requires arguments to be some type of 
string, and throws an exception when they aren'

Git blame points the finger at this commit on the branch: b972f20c55 (it's the 
same on master)



---


Here's the full stack trace from the log:

```
2023-01-20 20:59:32,986 - ERROR -  - reviewboard.webapi.resources.validate_diff 
- Unexpected error whe
n validating diff.
Traceback (most recent call last):
  File "/build_root/reviewboard/reviewboard/webapi/resources/validate_diff.py", 
line 161, in create
DiffSet.objects.create_from_upload(
  File "/build_root/reviewboard/reviewboard/diffviewer/managers.py", line 767, 
in create_from_upload
return self.create_from_data(
  File "/build_root/reviewboard/reviewboard/diffviewer/managers.py", line 1060, 
in create_from_data
create_filediffs(
  File "/build_root/reviewboard/reviewboard/diffviewer/filediff_creator.py", 
line 210, in create_filed
iffs

Re: Review Board Ticket #4988: Fail to post diff with perforce repo: 'Value to convert is unexpected type %s',

[Ben Jackson]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4988/
--

New update by benjackson
For Beanbag, Inc. > Review Board > Ticket #4988


Reply:

I just tried with release-5.0.x and same behaviour.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20230120223821.4660.34457%40ip-10-1-54-209.ec2.internal.