Re: Python API: Delete a user from a review group
It looks like it's not actually possible to delete a user from a review
group using the Python API at the moment. Review Board seems to be
returning an incorrect url which points to the user resource itself, rather
than the review-group-user resource for the delete link. you can see that
by looking at the example here:
https://www.reviewboard.org/docs/manual/dev/webapi/2.0/resources/review-group-user/#example_application/vnd.reviewboard.org.user+json
"delete": {
> "href": "http://reviews.example.com/api/users/doc/;,
> "method": "DELETE"
> },
This is a bug in Review Board and will need to be fixed there to allow
this.
On Wed, Sep 2, 2015 at 12:29 PM, Steve wrote:
> I'm trying to remove users from review groups using the Python API. The
> docs indicate that the review group user resource has a delete method, but
> I can't figure out how to get it to work. I can add a user to a group
> easily this way:
>
> g.get_users().create(username='steve')
>
> Unfortunately, this doesn't work:
>
> g.get_users().delete(username='steve')
>
> Nor does this:
>
> g.get_user()[0].delete()
>
> or any other incarnation I've tried. Can somebody point me in the right
> direction?
>
> Thanks!
>
> --Steve
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: Recommended Approach To Add Review Diff Comments Through API
The API is expecting you to pass in the row number which is you is the number indicating which row of a side by side diff the comment is on. This row number might not match the file line number if your diff contains adds / deletes on either side. The Review Bot project has some MIT licensed code which is used to translate from a file line number to a Review Board diff row number: https://github.com/reviewboard/ReviewBot/blob/f5a77c039dd59a5880d334c08567af3a068bf933/bot/reviewbot/processing/review.py#L87-L102 On Wed, Aug 12, 2015 at 12:25 PM, jaylee108...@gmail.com wrote: Hi All, I have some automated machinery that creates diff comments based on the line numbers in the new diff. This creates an issue on the correct line number the majority of the time. However, there are cases when the line number passed through the API does not strictly map to the correct diff line number in the UI. The belief is that the line number expected through the API is not a 1:1 mapping with the line number on the new diff. What is the recommended approach to translating the new diff line number to this API expected line number so that the issue shows up on the correct line of the diff? For reference, we are using: https://www.reviewboard.org/docs/manual/2.5/webapi/2.0/resources/review-diff-comment/ on a 2.0.12 instance. Thanks! -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Plugin for reviewing .doc, .pdf and .xls in reviewboard
The Review Board Power Pack provides support for reviewing .pdf https://www.reviewboard.org/powerpack/ I don't currently know of an extension for reviewing .doc and .xls inside Review Board, but you can certainly attach them and then download to review. On Wed, Jul 16, 2014 at 6:37 AM, sharath.r...@gmail.com wrote: Looking for a plugin using which .doc, .pdf and .xls can be review similar to source code files in reviewboard -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Content-Disposition is inline instead of attachment in response to Download Diff
Most sites seem to do the opposite of what I want about 50% of the time. I think in this case though since Review Board gives you a diff viewer, you'd generally want to download the diff when clicking Download Diff, so I vote for changing it. As an aside, here is a firefox add-on I use for dealing with the annoying opposite case where things try to download and I want to view them in the browser: https://addons.mozilla.org/en-US/firefox/addon/open-in-browser/ On Thu, May 22, 2014 at 9:41 PM, David Trowbridge trowb...@gmail.comwrote: Personally, if I click Download X and it displays in the browser, I get annoyed. -David On Thu, May 22, 2014 at 6:37 PM, Christian Hammond chip...@chipx86.comwrote: Hi Brett, It's actually never come up before, that I know of. It may be more useful to do that, but I think it's arguable. Certainly, I sometimes view the diff and am happy looking at it right in the browser, instead of having to save it somewhere and then open it. I'm interested in hearing what others have to say. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Thu, May 22, 2014 at 6:25 PM, Brett Randall javabr...@gmail.comwrote: Hi, RB 1.7.21. I've noticed that the response to Download Diff includes a Content-Disposition: inline: GET /r/1234/diff/raw/ HTTP/1.1 Content-Type: text/x-patch ... Content-Disposition: *inline*; filename=some.patch Shouldn't that be: Content-Disposition: *attachment*; filename=some.patch ? Current Chrome version sees text/ MIME type and displays the content inline (in the current window) as suggested, instead of raising a download dialog. I image most if not all folks clicking Download Diff want the patch as a file, otherwise they would click View Diff. Has this come up before? Raise a bug? Thanks Brett -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Push Based Workflow
Hi everyone, Over the weekend Mike Conley and I hacked together a little project to allow posting code for review using a push based workflow. The idea is to allow for code to be pushed to a special reviews clone which handles creating the review requests. This only took a few hours to throw together and is mostly a prototype, but we think it's a pretty good proof of concept. We'd love to hear some feedback or ideas for continued development in this space. Demo video: https://vimeo.com/86448355 Code: https://github.com/mikeconley/rb-repo (Cross posting to both lists as I believe both parties could be interested) -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Problem with signal handling in an extension
Hi, I'm actually the original author of the WebHooks extension. It was originally written as more of a prototype, and probably has a few bugs. You appear to have hit one. What I believe the problem here is most likely, is the webhooks extension doesn't unregister its signal handlers when it shuts down. So, if you were to disable and then re-enable the extension, it might have the handler registered twice. If you'd like an example of an extension to work from with a little more work put into it, check out https://github.com/reviewboard/ReviewBot It should have signal handlers that work properly. On Wed, Dec 4, 2013 at 8:10 AM, Samuel Degrande degrande.sam...@orange.fr wrote: Hi all. I use ReviewBoard 1.7.19, with mod_wsgi. I'm writing a rbirker extension, as a replacement to rbcia. I used rbwebhooks as an example to write my extension, so mainly only the notification code is different: it sends a notification to an irker relay through a TCP socket. But, the signal handler callbacks are called several times for each notification (the number of times varying...). I added some logging to my extension and to the mail notification code, and here is an example log of what I get: 16:34:44 INFO - mail: review_published 16:34:44 INFO - mail: sending to . 16:34:44 INFO - irker: review_published which is fine, but I also sometime get: 00:10:10 INFO - mail: review_published 00:10:10 INFO - mail: sending to . 00:10:10 INFO - irker: review_published 00:10:10 INFO - irker: review_published 00:10:10 INFO - irker: review_published 00:10:10 INFO - irker: review_published which is not fine. I also logged the call to the extension __init__ (which connect callbacks to signals), and I can see lot of traces: 19:21:06 INFO - Connecting rbiker 19:26:09 INFO - Connecting rbiker 19:31:10 INFO - Connecting rbiker 19:39:06 INFO - Connecting rbiker 19:44:07 INFO - Connecting rbiker 19:57:06 INFO - Connecting rbiker My guess (but I may be totally wrong, I'm a python newbie and I know nothing of django) is that the callbacks could be registered several times ? Could someone help me solving that issue ? Thanks. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Reviewbot: Should I see cppcheck and pep8 in my extension list?
Right after the section you've pasted, you'll see this: After a tool has been installed on a worker, it must be registered with the Review Bot extension, and configured in the admin panel. Registering tools is accomplished in the following manner: 1. Go to the extension list in the admin panel. 2. Click the 'DATABASE' button for the 'Review-Bot-Extension'. 3. Click the 'Review bot tools' link. 4. Click 'REFRESH INSTALLED TOOLS' in the upper right of the page. This will trigger tool registration for all of the currently running workers, and refresh the page. You will now see the list of installed tools and may configure them using this admin panel. On Wed, Sep 25, 2013 at 2:21 PM, Steve seide.al...@gmail.com wrote: I installed reviewbot on our 1.7.14 server using these instructions: https://github.com/reviewboard/ReviewBot It looks like pep8 and cppcheck are automatically installed with reviewbot, but I don't see them listed in the extension list. I'm looking for them under *Extensions - Database - Review bot tools* That page says *'0 review bot tools'*. Is some additional configuration needed? The instructions say: Workers are able to find installed tools using Entry Pointshttp://packages.python.org/distribute/pkg_resources.html#entry-points. New tool classes should add a reviewbot.toolsentry point. The entry point for the pep8 tool is part of the review bot installation, here is an example showing its definition: 'reviewbot.tools': [ 'cppcheck = reviewbot.tools.cppcheck:CPPCheckTool', 'cpplint = reviewbot.tools.cpplint:CPPLintTool', 'pep8 = reviewbot.tools.pep8:PEP8Tool', ], But it's not clear to me where that setting should be. --Steve -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: listing all review groups and users within the group using a python script
Yes, this can be done using the API. Assuming you have rbtools 5.x installed, the following script should work. Modify for your desired output. It should be noted that this will make a large number of HTTP requests, and is not optimized. from rbtools.api.client import RBClient client = RBClient(http://your-rb-server-here) root = client.get_root() groups = root.get_groups() while True: for group in groups: print group.name users = group.get_users() while True: for user in users: print \t%s % user.username try: users = users.get_next() except StopIteration: break try: groups = groups.get_next() except StopIteration: break On Wed, Sep 11, 2013 at 12:46 PM, Steve seide.al...@gmail.com wrote: Better yet, is there a way to do this with the new RBTools 5.x API? --Steve On Wednesday, September 11, 2013 8:54:07 AM UTC-7, Steve wrote: I can list all RB users this way: from django.contrib.auth.models import User for user in User.objects.all(): print user That correctly prints out all of my users. But the same doesn't work for Group from django.contrib.auth.models import Group for group in Group.objects.all(): print group default reviewer I have about 30 groups defined in RB, but I only get 'default reviewer'. What I'd like to do is list out all the groups, or more specifically, for each group, list all the user in the group. There's probably a set of django functions that will do that, but I'm having trouble finding them. Can someone point me in the right direction? Thanks --Steve -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: post-review: Error uploading diff
The minimum Review Board version which fully supports the rbt commands is RB
1.6.12. There were some changes to the web API in this version which rbt
relies on. Unfortunately, you won't be able to make use of most of rbt
without a newer version of Review Board.
Admittedly, the error reporting here was terrible, but is something I'm
working on imporoving.
On Tue, Aug 20, 2013 at 8:43 AM, Akshaya Samantaray
akshaya.samanta...@gmail.com wrote:
Thank for the response David .
I had rbtool 0.4.1 so rbt was not there so i installed 0.5.2 and got rbt
script .
To attach a arbitary file to existing review ,as per you i am using *rbt
attach 359 --filename=diff* (where 359 is ReviewID), it giving below
usage messge
hostname:/vobs/ms 167 % *rbt attach 359 --filename=diff*
*Usage: rbt attach [options] review-request-id file*
*
*
*rbt: error: Invalid number of arguments provided*
So i tried the command as *rbt attach 359 diff* (where 359 is the
reviewID and diff is the filename) but it giving error * CRITICAL:root:
.Please have look and let me know what could be the issue .*
*
*
*Note:The reviewBoard server version 1.6.3 and Rbtools is 0.5.2 ,Python
2.7 *
rbt attach 359 diff
CRITICAL:root:
*below is the debug output :*
169 % rbt attach 359 diff -d
DEBUG:root:Checking for a Subversion repository...
DEBUG:root:Checking for a Git repository...
DEBUG:root:Checking for a Mercurial repository...
DEBUG:root:Checking for a CVS repository...
DEBUG:root:Checking for a Perforce repository...
DEBUG:root:Checking for a Plastic repository...
DEBUG:root:Checking for a ClearCase repository...
DEBUG:root:Running: cleartool pwv -short
DEBUG:root:Running: diff --version
DEBUG:root:Running: cleartool lsview -full -properties -cview
DEBUG:root:Running: cleartool describe -short vob:.
DEBUG:root:Running: cleartool pwv -root
DEBUG:root:repository info: Path: /vobs/ms-test, Base path: /vobs/ms-test,
Supports changesets: False
DEBUG:root:Making HTTP GET request to https://ppsappdev02:443/api/
Traceback (most recent call last):
File /clearcase/tools/bin/rbt, line 9, in module
load_entry_point('RBTools==0.5.2', 'console_scripts', 'rbt')()
File
/usr/local/project/tools/ActivePython-2.7/lib/python2.7/site-packages/RBTools-0.5.2-py2.7.egg/rbtools/commands/main.py,
line 106, in main
command.run_from_argv([RB_MAIN] + args)
File
/usr/local/project/tools/ActivePython-2.7/lib/python2.7/site-packages/RBTools-0.5.2-py2.7.egg/rbtools/commands/__init__.py,
line 157, in run_from_argv
exit_code = self.main(*args) or 0
File
/usr/local/project/tools/ActivePython-2.7/lib/python2.7/site-packages/RBTools-0.5.2-py2.7.egg/rbtools/commands/attach.py,
line 67, in main
request = self.get_review_request(request_id, api_root)
File
/usr/local/project/tools/ActivePython-2.7/lib/python2.7/site-packages/RBTools-0.5.2-py2.7.egg/rbtools/commands/attach.py,
line 55, in get_review_request
request = api_root.get_review_request(review_request_id=request_id)
File
/usr/local/project/tools/ActivePython-2.7/lib/python2.7/site-packages/RBTools-0.5.2-py2.7.egg/rbtools/api/resource.py,
line 278, in __getattr__
raise AttributeError
AttributeError
On Tuesday, August 20, 2013 1:01:04 AM UTC+5:30, David Trowbridge wrote:
You can't use post-review --diff-filename to upload arbitrary files.
The newer rbt commands will let you upload file attachments with rbt
attach review request ID --filename=filename
For your existing
On Mon, Aug 19, 2013 at 4:35 AM, Akshaya Samantaray
akshaya.s...@gmail.com wrote:
Hi David ,
My object is just to upload a file which can be any file (*.gif or
*.bmp ) (need not be a diff file) using commandline post-review
--diff-filename=file_name to review-board server in our clear-case
environment
How to do it using post-review in clearcase environment ? let me know if
any other option to post-review is there ?
Thanks
On Monday, August 19, 2013 4:39:59 PM UTC+5:30, Akshaya Samantaray wrote:
HI David ,
Thanks for the response .
d1.diff is just diff file i have created manually i.e the diff between
my dev branch changes Integration branch changes redirected to file
called d1.diff and i am trying to upload this manually created diff file
d1.diff using *post-review --diff-filename=d1.diff --server=
https://MyRbServer https://myrbserver/ .*
*
*
I can upload this manually created diff file d1.diff file from GUI in
reviewboard page but not sure why its not uploading using from command
line using post-review diff-**filen**ame=d1.diff --server=
https://MyRbServer https://myrbserver/ .I am not getting any clue
from the post-review debug log or reviewboard server log .
Do i need to have any setup for apache or reviewboard server side
configuration ?where can i check to get the exact clue for this error ?
Please have a look and get back to me .I am waiting for your response .
Thanks
HTTP POSTing
Re: Bitnami Review Board Stack-Issue while running post-review with perforce on windows
Try changing the REPOSITORY field in your .reviewboardrc to be the name of the repository given in the RB admin panel. This is the name you give the repository when configuring it for the first time. On Thu, Jul 25, 2013 at 2:17 AM, RB lanka.a...@gmail.com wrote: I have set-up Bitnami Review Board stack on windows 64-bit. Later i am able to log-in to Review Board url and i was able to add a Perforce repository by clicking the Add Repository link. When i try to submit a review request for review using post-review command *post-review 12345*(changelist number) first it will ask for credentials and after submitting the credentials i am getting the following error: *There was an error creating this review request.* *The repository path public.perforce.com:1666 is not in the list of known repositories on the server.* *Ask the administrator to add this repository to the Review Board server. For information on adding repositories, please read* * http://www.reviewboard.org/docs/manual/dev/admin/configuration/repositories/ * Replaced my perforce path with public.perforce.com:1666 for posting question in this forum. I have created .reviewboardrc file with following values: REPOSITORY = 'public.perforce.com:1666' REVIEWBOARD_URL = 'http://XX.XX.XX.XX:/reviewboard'. My question here is though i have added perforce repository on Review Board why it is still throwing the error: The repository path public.perforce.com:1666 is not in the list of known repositories on the server Also am i missing something in .reviewboardrc file. Please provide your inputs for resolving this issue. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: ReviewBot Projects
Hey Ross, Currently this is unsupported. I'm working on a large patch to Review Bot which will include this, along with a number of new features: - Multiple configurations per tool. - Manual execution of tools on review requests using a drop down on the request page. - Better logging of tool execution. - Option to consolidate multiple tool reviews into a single review before it is posted. I've been pretty busy though, so progress is a little slower than I'd like. Features are coming. - Steve On Fri, Jun 28, 2013 at 2:12 PM, Ross Guarino rssg...@gmail.com wrote: Hi, Does anyone know if there is a way to set up reviewbot settings for different project/repositories? I have different repos that are all on the same reviewboard instance but they need different settings for them. Is there a way to do this? -- Ross -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: post-review with git
You can create a '.reviewboardrc' file in the top-level of the repository, and add the following line: REPOSITORY = 'repository-name' where repository-name is the name you gave the repository in the Review Board admin panel. This should make things work. On Wed, May 29, 2013 at 5:23 PM, Peter Snelling usenet.snell...@gmail.comwrote: I posted previously that I've installed ReviewBoard 1.7.7.1 on a Suse linux server (with git, apache, postgresql, modswgi, memcached, ...). The git repository we all use is 172.16.27.63. To get post-review to work properly, I had to add the following repository: Path: snelling@172.16.27.63:/**localdisk/git/repositories/**TCD.git Raw File URL: http://172.16.27.63/cgi-bin/** gitweb/gitweb.cgi?p=TCD.git;a=**blob_plain;f=filename;h=**revision and to have review board accept that repository, I had to setup ssh keys from the review board server to 172.16.27.63. Now that all works fine for me. The problem now is when I tried to get another user to use post-review, they failed. Their repository was: someuser@172.16.27.63:/**localdisk/git/repositories/**TCD.git and post-review wouldn't accept that. I had to create another repository for them, and add their ssh keys to the git server. That worked, but it seems like too much pain for dozens of users. If users upload their diff using the ReviewBoard web page and my repository (snelling@172.16.27.63:/**localdisk/git/repositories/**TCD.git) on the New Review Request screen that works fine. But I'd like to get post-review work without having to create a specific repository for each user. Does anyone know if this can be done? - Peter -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Creating a review with Python API
Hi,
'root.get_review_requests().get_self(id='15583', repository=repository)'
will result in a
GET http://.../api/review_requests/?id=15583repository=id
What you're looking for is 'root.get_review_requests().get_item(15583)', or
alternatively 'root.get_review_request(review_request_id=15583). The former
traverses the tree of resources, while the latter uses the root resource's
uri-template for 'review-request'.
Additionally, retrieving the id of the repository is unnecessary to find
the review request with the ID you are looking for.
On Mon, May 20, 2013 at 8:50 AM, Dave Johnston dave.johns...@me.com wrote:
Hi,
I've been trying to following the documentation here:
http://www.reviewboard.org/docs/rbtools/0.5/api/tutorial/
To create a review for a existing review request, and then add a comment
to the review. Unfortunately I'm not getting far.
I've tried the following:
root = client.get_root()
repos = root.get_repositories()
if repos.num_items 1:
raise Exception('No valid repositories.')
repository = repos[0].id
review_request = root.get_review_requests().get_self(id='15583',
repository=repository)
review = review_request.get_reviews().create()
filediff_id = review.get_diffs()[0].get_files()[0].id
review.get_diff_comments().create(
filediff_id=1,
first_line=131,
num_lines=2,
text='This is a diff comment!')
review.update(body_top='Test Review Comment - please ignore', public=True)
I get the error: AttributeError: 'ResourceList' object has no attribute
'get_reviews'
So it looks like root.get_review_requests().get_self(id='15583',
repository=repository) isn't the right request to return an existing review
request ?
Any help would be much appreciated.
Cheers
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an
email to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Problem with RBTools 0.5
You can download curl for windows here: http://curl.haxx.se/download.html
On Mon, Apr 8, 2013 at 1:34 PM, Robert Dailey rcdailey.li...@gmail.comwrote:
I'm not on Linux, how can I get you what you want on Windows 7?
On Fri, Apr 5, 2013 at 12:28 AM, Steven MacLeod ste...@smacleod.ca
wrote:
Hi Robert,
Sorry for the delay in response, this slipped by in my inbox.
Could you please send me the output of:
$ curl
http://reviewboard.corp.good.com/api/review-requests/44580/diffs/
-I
Basically I need to take a look at the headers being returned in the HTTP
request to RB.
On Fri, Mar 29, 2013 at 1:40 PM, Robert Dailey rcdailey.li...@gmail.com
wrote:
Using RB version 1.6.3. Output of the command you requested is below:
DEBUG:root:Checking for a Bazaar repository...
DEBUG:root:Checking for a CVS repository...
DEBUG:root:Checking for a ClearCase repository...
DEBUG:root:Checking for a Git repository...
DEBUG:root:Running: git rev-parse --git-dir
DEBUG:root:Command exited with rc 128: ['git', 'rev-parse', '--git-dir']
fatal: Not a git repository (or any of the parent directories): .git
---
DEBUG:root:Checking for a Mercurial repository...
DEBUG:root:Checking for a Perforce repository...
DEBUG:root:Running: p4 info
DEBUG:root:Running: diff --version
DEBUG:root:repository info: Path: perforce-rws2.corp.good.com:3666,
Base path: None, Supports changesets: True
DEBUG:root:Making HTTP GET request to
http://reviewboard.corp.good.com/api/
DEBUG:root:Making HTTP GET request to
http://reviewboard.corp.good.com/api/info/
INFO:root:Generating diff for changenum 303396
DEBUG:root:Running: p4 describe -s 303396
DEBUG:root:Processing delete of
//depot/dev/DominoProcessDecomp/DominoProcessDecomp.sln
DEBUG:root:Writing
//depot/dev/DominoProcessDecomp/DominoProcessDecomp.sln#4 to
c:\users\rdailey\appdata\local\temp\tmpivyvra
DEBUG:root:Running: p4 print -o
c:\users\rdailey\appdata\local\temp\tmpivyvra -q
//depot/dev/DominoProcessDecomp/DominoProcessDecomp.sln#4
DEBUG:root:Running: diff -urNp
c:\users\rdailey\appdata\local\temp\tmpivyvra
c:\users\rdailey\appdata\local\temp\tmpljgwo3
DEBUG:root:Command exited with rc 1: ['diff', '-urNp',
'c:\\users\\rdailey\\appdata\\local\\temp\\tmpivyvra',
'c:\\users\\rdailey\\appdata\\local\\temp\\tmpljgwo3']
--- c:\users\rdailey\appdata\local\temp\tmpivyvra 2013-03-29
12:39:00.971865100 -0500
+++ c:\users\rdailey\appdata\local\temp\tmpljgwo3 2013-03-29
12:39:00.798330400 -0500
@@ -1,44 +0,0 @@
-
-Microsoft Visual Studio Solution File, Format Version 9.00
-# Visual Studio 2005
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = services,
server\gmmserver\domino\server\services\services.vcproj,
{40E4563C-EDCE-4F19-8A3F-F9497265ACEE}
-EndProject
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = interface,
server\gmmserver\domino\server\interface\interface.vcproj,
{EADFA55E-6196-44CC-A496-1FDEC07DDE54}
-EndProject
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = groupware,
server\gmmserver\domino\server\groupware\groupware.vcproj,
{C4D3A251-B853-43E2-84C8-5501FE40EEE8}
-EndProject
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = gwserver,
server\gmmserver\domino\server\gwserver\gwserver.vcproj,
{0B59A140-C1D4-4A06-ACD8-5A78745D3C9F}
-EndProject
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = gwclient,
server\gmmserver\domino\server\gwclient\gwclient.vcproj,
{933240B0-F445-49E7-AB25-7BAE6B3C458C}
-EndProject
-Global
- GlobalSection(SolutionConfigurationPlatforms) = preSolution
- Debug|Win32 = Debug|Win32
- Release|Win32 = Release|Win32
- EndGlobalSection
- GlobalSection(ProjectConfigurationPlatforms) = postSolution
- {40E4563C-EDCE-4F19-8A3F-F9497265ACEE}.Debug|Win32.ActiveCfg =
Debug|Win32
- {40E4563C-EDCE-4F19-8A3F-F9497265ACEE}.Debug|Win32.Build.0 =
Debug|Win32
- {40E4563C-EDCE-4F19-8A3F-F9497265ACEE}.Release|Win32.ActiveCfg =
Release|Win32
- {40E4563C-EDCE-4F19-8A3F-F9497265ACEE}.Release|Win32.Build.0 =
Release|Win32
- {EADFA55E-6196-44CC-A496-1FDEC07DDE54}.Debug|Win32.ActiveCfg =
Debug|Win32
- {EADFA55E-6196-44CC-A496-1FDEC07DDE54}.Debug|Win32.Build.0 =
Debug|Win32
- {EADFA55E-6196-44CC-A496-1FDEC07DDE54}.Release|Win32.ActiveCfg =
Release|Win32
- {EADFA55E-6196-44CC-A496-1FDEC07DDE54}.Release|Win32.Build.0 =
Release|Win32
- {C4D3A251-B853-43E2-84C8-5501FE40EEE8}.Debug|Win32.ActiveCfg =
Debug|Win32
- {C4D3A251-B853-43E2-84C8-5501FE40EEE8}.Debug|Win32.Build.0 =
Debug|Win32
- {C4D3A251-B853-43E2-84C8-5501FE40EEE8}.Release|Win32.ActiveCfg =
Release|Win32
- {C4D3A251-B853-43E2-84C8-5501FE40EEE8}.Release|Win32.Build.0 =
Release|Win32
- {0B59A140-C1D4-4A06-ACD8-5A78745D3C9F}.Debug
Re: Problem with RBTools 0.5
It appears your Apache server won't allow a HEAD request.
Can I see the output of:
$ curl http://reviewboard.corp.good.com/api/review-requests/44580/diffs/
-i
On Mon, Apr 8, 2013 at 4:27 PM, Robert Dailey rcdailey.li...@gmail.comwrote:
Here you go:
C:\workcurl
http://reviewboard.corp.good.com/api/review-requests/44580/diffs/
-I
HTTP/1.1 405 METHOD NOT ALLOWED
Date: Mon, 08 Apr 2013 20:24:40 GMT
Server: Apache/2.2.21 (Unix) mod_wsgi/3.3 Python/2.7 mod_ssl/2.2.17
OpenSSL/1.0.0c
Content-Language: en-us
Expires: Mon, 08 Apr 2013 20:24:40 GMT
Vary: Accept,Cookie,Accept-Language
Last-Modified: Mon, 08 Apr 2013 20:24:40 GMT
Allow: GET, POST
Cache-Control: max-age=0
Content-Type: text/html; charset=utf-8
On Fri, Apr 5, 2013 at 12:28 AM, Steven MacLeod ste...@smacleod.ca
wrote:
Hi Robert,
Sorry for the delay in response, this slipped by in my inbox.
Could you please send me the output of:
$ curl
http://reviewboard.corp.good.com/api/review-requests/44580/diffs/
-I
Basically I need to take a look at the headers being returned in the HTTP
request to RB.
On Fri, Mar 29, 2013 at 1:40 PM, Robert Dailey rcdailey.li...@gmail.com
wrote:
Using RB version 1.6.3. Output of the command you requested is below:
DEBUG:root:Checking for a Bazaar repository...
DEBUG:root:Checking for a CVS repository...
DEBUG:root:Checking for a ClearCase repository...
DEBUG:root:Checking for a Git repository...
DEBUG:root:Running: git rev-parse --git-dir
DEBUG:root:Command exited with rc 128: ['git', 'rev-parse', '--git-dir']
fatal: Not a git repository (or any of the parent directories): .git
---
DEBUG:root:Checking for a Mercurial repository...
DEBUG:root:Checking for a Perforce repository...
DEBUG:root:Running: p4 info
DEBUG:root:Running: diff --version
DEBUG:root:repository info: Path: perforce-rws2.corp.good.com:3666,
Base path: None, Supports changesets: True
DEBUG:root:Making HTTP GET request to
http://reviewboard.corp.good.com/api/
DEBUG:root:Making HTTP GET request to
http://reviewboard.corp.good.com/api/info/
INFO:root:Generating diff for changenum 303396
DEBUG:root:Running: p4 describe -s 303396
DEBUG:root:Processing delete of
//depot/dev/DominoProcessDecomp/DominoProcessDecomp.sln
DEBUG:root:Writing
//depot/dev/DominoProcessDecomp/DominoProcessDecomp.sln#4 to
c:\users\rdailey\appdata\local\temp\tmpivyvra
DEBUG:root:Running: p4 print -o
c:\users\rdailey\appdata\local\temp\tmpivyvra -q
//depot/dev/DominoProcessDecomp/DominoProcessDecomp.sln#4
DEBUG:root:Running: diff -urNp
c:\users\rdailey\appdata\local\temp\tmpivyvra
c:\users\rdailey\appdata\local\temp\tmpljgwo3
DEBUG:root:Command exited with rc 1: ['diff', '-urNp',
'c:\\users\\rdailey\\appdata\\local\\temp\\tmpivyvra',
'c:\\users\\rdailey\\appdata\\local\\temp\\tmpljgwo3']
--- c:\users\rdailey\appdata\local\temp\tmpivyvra 2013-03-29
12:39:00.971865100 -0500
+++ c:\users\rdailey\appdata\local\temp\tmpljgwo3 2013-03-29
12:39:00.798330400 -0500
@@ -1,44 +0,0 @@
-
-Microsoft Visual Studio Solution File, Format Version 9.00
-# Visual Studio 2005
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = services,
server\gmmserver\domino\server\services\services.vcproj,
{40E4563C-EDCE-4F19-8A3F-F9497265ACEE}
-EndProject
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = interface,
server\gmmserver\domino\server\interface\interface.vcproj,
{EADFA55E-6196-44CC-A496-1FDEC07DDE54}
-EndProject
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = groupware,
server\gmmserver\domino\server\groupware\groupware.vcproj,
{C4D3A251-B853-43E2-84C8-5501FE40EEE8}
-EndProject
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = gwserver,
server\gmmserver\domino\server\gwserver\gwserver.vcproj,
{0B59A140-C1D4-4A06-ACD8-5A78745D3C9F}
-EndProject
-Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = gwclient,
server\gmmserver\domino\server\gwclient\gwclient.vcproj,
{933240B0-F445-49E7-AB25-7BAE6B3C458C}
-EndProject
-Global
- GlobalSection(SolutionConfigurationPlatforms) = preSolution
- Debug|Win32 = Debug|Win32
- Release|Win32 = Release|Win32
- EndGlobalSection
- GlobalSection(ProjectConfigurationPlatforms) = postSolution
- {40E4563C-EDCE-4F19-8A3F-F9497265ACEE}.Debug|Win32.ActiveCfg =
Debug|Win32
- {40E4563C-EDCE-4F19-8A3F-F9497265ACEE}.Debug|Win32.Build.0 =
Debug|Win32
- {40E4563C-EDCE-4F19-8A3F-F9497265ACEE}.Release|Win32.ActiveCfg =
Release|Win32
- {40E4563C-EDCE-4F19-8A3F-F9497265ACEE}.Release|Win32.Build.0 =
Release|Win32
- {EADFA55E-6196-44CC-A496-1FDEC07DDE54}.Debug|Win32.ActiveCfg =
Debug|Win32
- {EADFA55E-6196-44CC-A496-1FDEC07DDE54}.Debug|Win32.Build.0 =
Debug|Win32
- {EADFA55E-6196-44CC-A496-1FDEC07DDE54}.Release
Re: Problem with RBTools 0.5
|Win32
- {933240B0-F445-49E7-AB25-7BAE6B3C458C}.Release|Win32.Build.0 =
Release|Win32
- EndGlobalSection
- GlobalSection(SolutionProperties) = preSolution
- HideSolutionNode = FALSE
- EndGlobalSection
-EndGlobal
---
DEBUG:root:Making HTTP GET request to
http://reviewboard.corp.good.com/api/review-requests/
DEBUG:root:Making HTTP POST request to
http://reviewboard.corp.good.com/api/review-requests/
DEBUG:root:Making HTTP GET request to
http://reviewboard.corp.good.com/api/review-requests/44580/diffs/
Traceback (most recent call last):
File C:\Python27\Scripts\rbt-script.py, line 8, in module
load_entry_point('RBTools==0.5', 'console_scripts', 'rbt')()
File
C:\Python27\lib\site-packages\rbtools-0.5-py2.7.egg\rbtools\commands\main.py,
line 99, in main
File
C:\Python27\lib\site-packages\rbtools-0.5-py2.7.egg\rbtools\commands\__init__.py,
line 150, in run_from_argv
File
C:\Python27\lib\site-packages\rbtools-0.5-py2.7.egg\rbtools\commands\post.py,
line 450, in main
File
C:\Python27\lib\site-packages\rbtools-0.5-py2.7.egg\rbtools\commands\post.py,
line 324, in post_request
File
C:\Python27\lib\site-packages\rbtools-0.5-py2.7.egg\rbtools\api\transport\sync.py,
line 289, in __getattr__
AttributeError: 'ResourceList' object has no attribute 'upload_diff'
On Fri, Mar 29, 2013 at 12:20 PM, Steven MacLeod ste...@smacleod.ca
wrote:
Hi Robert,
What version of Review Board is there server running? Could you also
provide
the output of rbt post -d --server=http://my.review.board.url--p4-client=$c
--p4-port=$p --username=myuser --password=mypassword %C
The post-review script is still part of rbtools 0.5, so you can use that
as
a backup until we have this figured out.
On Mar 29, 2013 11:01 AM, Robert Dailey rcdailey.li...@gmail.com
wrote:
No one will help?
On Thu, Mar 28, 2013 at 3:54 PM, Robert Dailey
rcdailey.li...@gmail.com
wrote:
I am getting the following error uploading my review from a Perforce
changelist. This impedes my day to day work, so I hope that someone
can help me quickly. The error I get while trying to run 'rbt post'
is:
CRITICAL:root:'ResourceList' object has no attribute 'upload_diff'
I have only transitioned from review-board to RBT 0.5, most of the
commands are the same so I am only invoking a different process. I am
using Python 2.7.3 on Windows 7 x64.
Here is the command I'm running:
rbt post --server=http://my.review.board.url --p4-client=$c
--p4-port=$p --username=myuser --password=mypassword %C
Note that the previous command I used was:
post-review %C --server=http://my.review.board.url --p4-client=$c
--p4-port=$p --username=myuser --password=mypassword
The post-review command always worked fine for me. I installed RBTools
0.5 using easy_install (logs below). Note that I run this as a custom
tool in P4V, so %C actually maps to the Changelist number. $c maps to
client name, $p is port, and so on.
C:\Users\rdaileyeasy_install -U RBTools
Searching for RBTools
Reading http://pypi.python.org/simple/RBTools/
Reading http://www.reviewboard.org/
Reading http://downloads.reviewboard.org/releases/RBTools/0.3/
Reading http://downloads.reviewboard.org/releases/RBTools/0.4/
Reading http://downloads.reviewboard.org/releases/RBTools/0.5/
Reading http://downloads.reviewboard.org/releases/RBTools/0.2/
Reading http://www.review-board.org/
Reading http://downloads.review-board.org/releases/
Reading http://downloads.review-board.org/releases/RBTools/0.2/
Best match: RBTools 0.5
Downloading
http://downloads.reviewboard.org/releases/RBTools/0.5/RBTools-0.5-py2.7.egg
Processing RBTools-0.5-py2.7.egg
Moving RBTools-0.5-py2.7.egg to c:\python27\lib\site-packages
Removing rbtools 0.4.1 from easy-install.pth file
Adding RBTools 0.5 to easy-install.pth file
Installing post-review-script.py script to C:\Python27\Scripts
Installing post-review.exe script to C:\Python27\Scripts
Installing post-review.exe.manifest script to C:\Python27\Scripts
Installing rbt-script.py script to C:\Python27\Scripts
Installing rbt.exe script to C:\Python27\Scripts
Installing rbt.exe.manifest script to C:\Python27\Scripts
Installed c:\python27\lib\site-packages\rbtools-0.5-py2.7.egg
Processing dependencies for RBTools
Finished processing dependencies for RBTools
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
---
You received this message because you are subscribed to the Google
Groups
reviewboard group.
To unsubscribe from this group
Re: Problem with RBTools 0.5
Hi Robert, What version of Review Board is there server running? Could you also provide the output of rbt post -d --server=http://my.review.board.url --p4-client=$c --p4-port=$p --username=myuser --password=mypassword %C The post-review script is still part of rbtools 0.5, so you can use that as a backup until we have this figured out. On Mar 29, 2013 11:01 AM, Robert Dailey rcdailey.li...@gmail.com wrote: No one will help? On Thu, Mar 28, 2013 at 3:54 PM, Robert Dailey rcdailey.li...@gmail.com wrote: I am getting the following error uploading my review from a Perforce changelist. This impedes my day to day work, so I hope that someone can help me quickly. The error I get while trying to run 'rbt post' is: CRITICAL:root:'ResourceList' object has no attribute 'upload_diff' I have only transitioned from review-board to RBT 0.5, most of the commands are the same so I am only invoking a different process. I am using Python 2.7.3 on Windows 7 x64. Here is the command I'm running: rbt post --server=http://my.review.board.url --p4-client=$c --p4-port=$p --username=myuser --password=mypassword %C Note that the previous command I used was: post-review %C --server=http://my.review.board.url --p4-client=$c --p4-port=$p --username=myuser --password=mypassword The post-review command always worked fine for me. I installed RBTools 0.5 using easy_install (logs below). Note that I run this as a custom tool in P4V, so %C actually maps to the Changelist number. $c maps to client name, $p is port, and so on. C:\Users\rdaileyeasy_install -U RBTools Searching for RBTools Reading http://pypi.python.org/simple/RBTools/ Reading http://www.reviewboard.org/ Reading http://downloads.reviewboard.org/releases/RBTools/0.3/ Reading http://downloads.reviewboard.org/releases/RBTools/0.4/ Reading http://downloads.reviewboard.org/releases/RBTools/0.5/ Reading http://downloads.reviewboard.org/releases/RBTools/0.2/ Reading http://www.review-board.org/ Reading http://downloads.review-board.org/releases/ Reading http://downloads.review-board.org/releases/RBTools/0.2/ Best match: RBTools 0.5 Downloading http://downloads.reviewboard.org/releases/RBTools/0.5/RBTools-0.5-py2.7.egg Processing RBTools-0.5-py2.7.egg Moving RBTools-0.5-py2.7.egg to c:\python27\lib\site-packages Removing rbtools 0.4.1 from easy-install.pth file Adding RBTools 0.5 to easy-install.pth file Installing post-review-script.py script to C:\Python27\Scripts Installing post-review.exe script to C:\Python27\Scripts Installing post-review.exe.manifest script to C:\Python27\Scripts Installing rbt-script.py script to C:\Python27\Scripts Installing rbt.exe script to C:\Python27\Scripts Installing rbt.exe.manifest script to C:\Python27\Scripts Installed c:\python27\lib\site-packages\rbtools-0.5-py2.7.egg Processing dependencies for RBTools Finished processing dependencies for RBTools -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: python API: target_people access fails
Hi,
This is an issue with Python versions 2.6.5. I have a fix for it which
will be part of the RBTools 0.5.1 release which is coming soon.
On Fri, Mar 22, 2013 at 6:13 PM, Steven MacLeod ste...@smacleod.ca wrote:
What version of python are you running?
On Fri, Mar 22, 2013 at 3:54 PM, A.M. age...@themactionfaction.comwrote:
On Fri, 22 Mar 2013 15:25:48 -0400, Steven MacLeod ste...@smacleod.ca
wrote:
That looks correct. I'm not quire sure what's going wrong.
Could you provide me with the JSON payload being used to create the
review
request resource. You can get this by running:
review_requests = rb_conn.get_root().get_review_
requests(time_added_from=time_added, status='pending', max_results=1)
for rr in review_requests:
print rr._resource._payload
Sure- here is one sanitized parsed-to-dict JSON structure:
{u'status': u'pending', u'last_updated': u'2013-03-22T18:39:57.056Z',
u'description': u_, u'links': {u'diffs': {u'href':
u'https://reviewboard._.com/api/review-requests/2727/diffs/', u'method':
u'GET'}, u'repository': {u'href':
u'https://reviewboard._.com/api/repositories/9/', u'method': u'GET',
u'title': u'_'}, u'changes': {u'href':
u'https://reviewboard._.com/api/review-requests/2727/changes/',
u'method':
u'GET'}, u'self': {u'href':
u'https://reviewboard._.com/api/review-requests/2727/', u'method':
u'GET'},
u'update': {u'href':
u'https://reviewboard._.com/api/review-requests/2727/', u'method':
u'PUT'},
u'last_update': {u'href':
u'https://reviewboard._.com/api/review-requests/2727/last-update/',
u'method': u'GET'}, u'reviews': {u'href':
u'https://reviewboard._.com/api/review-requests/2727/reviews/',
u'method':
u'GET'}, u'draft': {u'href':
u'https://reviewboard._.com/api/review-requests/2727/draft/', u'method':
u'GET'}, u'file_attachments': {u'href':
u'https://reviewboard._.com/api/review-requests/2727/file-attachments/',
u'method': u'GET'}, u'submitter': {u'href':
u'https://reviewboard._.com/api/users/_/', u'method': u'GET', u'title':
u'_'}, u'screenshots': {u'href':
u'https://reviewboard._.com/api/review-requests/2727/screenshots/',
u'method': u'GET'}, u'delete': {u'href':
u'https://reviewboard._.com/api/review-requests/2727/', u'method':
u'DELETE'}}, u'target_groups': [], u'bugs_closed': [u'_'], u'changenum':
None, u'target_people': [{u'href':
u'https://reviewboard._.com/api/users/_/', u'method': u'GET', u'title':
u'_'}, {u'href': u'https://reviewboard._.com/api/users/_/', u'method':
u'GET', u'title': u'_'}, {u'href':
u'https://reviewboard._.com/api/users/_/', u'method': u'GET', u'title':
u'_'}], u'testing_done': u_, u'branch': u'2013-1', u'id': 2727,
u'time_added': u'2013-03-22T16:49:32.368Z', u'summary': u'_', u'public':
True}
Company-specific information has been redacted with underscores.
We are using ReviewBoard 1.7.5, in case that matters.
Cheers,
M
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an
email to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Re: python API: target_people access fails
That looks correct. I'm not quire sure what's going wrong. Could you provide me with the JSON payload being used to create the review request resource. You can get this by running: review_requests = rb_conn.get_root().get_review_ requests(time_added_from=time_added, status='pending', max_results=1) for rr in review_requests: print rr._resource._payload On Fri, Mar 22, 2013 at 1:55 PM, A.M. age...@themactionfaction.com wrote: Hello, I am trying to extract user names from the review_request.target_people but I receive an unexpected exception. review_requests = rb_conn.get_root().get_review_requests(time_added_from=time_added, status='pending',max_results=1) for rr in review_requests: for reviewer in rr.target_people: print reviewer Traceback (most recent call last): File rbpoller.py, line 129, in module send_rb_fresh_emails() File rbpoller.py, line 97, in send_rb_fresh_emails for reviewer in rr.target_people: File build/bdist.linux-x86_64/egg/rbtools/api/transport/sync.py, line 142, in next File build/bdist.linux-x86_64/egg/rbtools/api/transport/sync.py, line 162, in __getitem__ File build/bdist.linux-x86_64/egg/rbtools/api/transport/sync.py, line 71, in wrap TypeError: __init__() keywords must be strings My understanding is that the ResourceListField should be iterable. Am I doing something incorrectly? Cheers, M -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: python API: target_people access fails
What version of python are you running?
On Fri, Mar 22, 2013 at 3:54 PM, A.M. age...@themactionfaction.com wrote:
On Fri, 22 Mar 2013 15:25:48 -0400, Steven MacLeod ste...@smacleod.ca
wrote:
That looks correct. I'm not quire sure what's going wrong.
Could you provide me with the JSON payload being used to create the
review
request resource. You can get this by running:
review_requests = rb_conn.get_root().get_review_
requests(time_added_from=time_added, status='pending', max_results=1)
for rr in review_requests:
print rr._resource._payload
Sure- here is one sanitized parsed-to-dict JSON structure:
{u'status': u'pending', u'last_updated': u'2013-03-22T18:39:57.056Z',
u'description': u_, u'links': {u'diffs': {u'href':
u'https://reviewboard._.com/api/review-requests/2727/diffs/', u'method':
u'GET'}, u'repository': {u'href':
u'https://reviewboard._.com/api/repositories/9/', u'method': u'GET',
u'title': u'_'}, u'changes': {u'href':
u'https://reviewboard._.com/api/review-requests/2727/changes/', u'method':
u'GET'}, u'self': {u'href':
u'https://reviewboard._.com/api/review-requests/2727/', u'method':
u'GET'},
u'update': {u'href':
u'https://reviewboard._.com/api/review-requests/2727/', u'method':
u'PUT'},
u'last_update': {u'href':
u'https://reviewboard._.com/api/review-requests/2727/last-update/',
u'method': u'GET'}, u'reviews': {u'href':
u'https://reviewboard._.com/api/review-requests/2727/reviews/', u'method':
u'GET'}, u'draft': {u'href':
u'https://reviewboard._.com/api/review-requests/2727/draft/', u'method':
u'GET'}, u'file_attachments': {u'href':
u'https://reviewboard._.com/api/review-requests/2727/file-attachments/',
u'method': u'GET'}, u'submitter': {u'href':
u'https://reviewboard._.com/api/users/_/', u'method': u'GET', u'title':
u'_'}, u'screenshots': {u'href':
u'https://reviewboard._.com/api/review-requests/2727/screenshots/',
u'method': u'GET'}, u'delete': {u'href':
u'https://reviewboard._.com/api/review-requests/2727/', u'method':
u'DELETE'}}, u'target_groups': [], u'bugs_closed': [u'_'], u'changenum':
None, u'target_people': [{u'href':
u'https://reviewboard._.com/api/users/_/', u'method': u'GET', u'title':
u'_'}, {u'href': u'https://reviewboard._.com/api/users/_/', u'method':
u'GET', u'title': u'_'}, {u'href':
u'https://reviewboard._.com/api/users/_/', u'method': u'GET', u'title':
u'_'}], u'testing_done': u_, u'branch': u'2013-1', u'id': 2727,
u'time_added': u'2013-03-22T16:49:32.368Z', u'summary': u'_', u'public':
True}
Company-specific information has been redacted with underscores.
We are using ReviewBoard 1.7.5, in case that matters.
Cheers,
M
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an
email to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Creating a new comment, first_line not being used correctly?
Hi, first_line is in reference to the line numbers of the file diff resource ( http://www.reviewboard.org/docs/manual/1.6/webapi/2.0/resources/file-diff/). This number doesn't correspond to either the left or right pane of the diff, but a combination of the two. If you were to count down the rows of the diff simultaneously, the row number the line of code falls on is the value of first_line you are looking for. (i.e. in the file-diff resource, look at the description of the lines field inside a chunk, the value you are looking for is 1.Row number of the line in the combined side-by-side diff. ). You can find an example function which converts the line number from the file to the row number here: https://github.com/smacleod/ReviewBot/blob/490522cfcd2ec8ec3d5a953d0b225344e60e9ad3/bot/reviewbot/processing/review.py#L84 It uses a very slow algorithm though, so I only recommend looking at it to make things clearer. On Mon, Sep 17, 2012 at 7:47 AM, soorajchirag contact.sund...@gmail.comwrote: Hi, I am looking at the web page: http://www.reviewboard.org/docs/manual/1.6/webapi/2.0/resources/review-diff-comment-list/#webapi2.0-review-diff-comment-list-resource to know how to post comments using the API on an uploaded diff. The comment is getting posted by using the parameters specified on the page, but the first_line parameter doesn't seem to be working as expected. From the web page quoted above: first_line (required) Integer The line number the comment starts at. The issue: I am setting the first_line as the one where I want the comment to appear on the updated content (right hand column in the browser). I have verified that the request being sent to the reviewboard server has the correct first_line value. But when I view the review using the Web browser it appears at a different line number. The line number is not correct even if I assume that the first_line is based on the line numbers of the original content. Eg: Posted on line number 1594, displayed on: 1. New content line number 1468 2. Old content line number 1505 If I use the Web browser to post the comment on the intended line (i.e. 1594), I see that it uses first_line as 1720! I am running version 1.6.3. Is my understanding of the description of first_line incorrect? Any suggestions on how to go about figuring out the cause? Thanks, Sundeep -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: install RB extension
Hi, Extensions are not supported in version 1.6.1, support starts in version 1.7 which is currently in beta. Note that 1.7 is still unstable and not recommended for production use yet. Steve On Thu, Sep 13, 2012 at 7:28 AM, Nilesh Jaiswal nileshj...@gmail.comwrote: Hi All, Presently i am using RB server 1.6.1 and I want to install reviewboard extension explicitly, is it recommended or supported for this version of RB server. Regards, Nilesh J -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: When i use post-review, always get the No supported repository could be accessed at the supplied url.
It appears that post-review does not support Bazaar yet. There is an issue for this in this tracker: http://code.google.com/p/reviewboard/issues/detail?id=773 And some discussion about working on a patch (From May) can be found in this mailing list thread: https://groups.google.com/d/topic/reviewboard/lnaB7bnfc34/discussion On Tue, Aug 7, 2012 at 9:41 PM, Kyoyeol Kim kimkyo...@gmail.com wrote: Hi, My name is Kyoyeol Kim. I'm from South Korean. I think ReviewBoard is amazing! but I got a problem. When i use post-review, always get the No supported repository could be accessed at the supplied url. Please help me. Problem (269)$ post-review No supported repository could be accessed at the supplied url. Infomation ReviewBoard : ver.1.6.1, http://10.90.38.82/reviews/ RBTools : ver.0.4.1 Bazaar : ver.2.1.4 /bazaar/sample1 =repository /bazaar/sample1/trunk =branch /bazaar/sample1/.reviewboardrc (270)$ cat .reviewboardrc REPOSITORY= 'sample1/trunk' REVIEWBOARD_URL= 'http://10.90.38.82/reviews/' -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Installing the Web Hooks extension
Hey Rodrigo, I'm the author of the Web Hooks extension. I believe it should be compatible with the latest 1.7 dev code, as I don't remember any changes which would have broken it since it was committed. As for not running a production site off of 1.7, the Web Hooks extension is even less ready for production. To be honest, it is more of a prototype which has had only minimal testing. Working to improve this extension isn't currently one of my priorities, but I'd be more than happy to offer support if you are interested in tinkering with it. Steve -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Post-Commit in server side?
I've never done this myself, but I think it's probably possible. SVN has a number of hook points where you can run scripts, including a post-commit hook. After a quick search I found this: http://svnbook.red-bean.com/en/1.6/svn.reposadmin.create.html#svn.reposadmin.create.hooks On Thursday, March 8, 2012 4:56:14 AM UTC-5, brucenan wrote: Does any solutions for post-commit in server? I do not want to make developer commit codes manually. Does any hooks in server's SVN can implement this function. My steps: 1.Dev commit codes to SVN in sever 2.SVN automatically commit review request to Reviewboard 3.All can view request in Reviewboard Web. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Extension's ModelAdmin and AdminSite
After a design discussion with ChipX86, the plans have changed a little. Instead of allowing extensions to register with the Review Board admin site, I'm going to add support for extensions to have their own admin site instance. By specifying a flag in your extension (similar to how you may set is_configurable = true), a separate admin site instance will be created for you, which you may register your ModelAdmins to. This will work by calling something like extension.admin_site.register(...) I think this will cover what you are looking to do. I'll keep you posted -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Extension's ModelAdmin and AdminSite
I came up against this issue myself recently.
Currently Djblets has nothing implemented to import the admin.py files
from extensions.
ChipX86 django has a function that scans all admin.py files in
INSTALLED_APPS and imports them, causing registers to happen
I've started adding something similar to Djblets extensions. I'll let
you know when it's up for review.
On Feb 9, 3:15 pm, Bart Celary bartlomiej.cel...@gmail.com wrote:
Hello,
Could you tell me what is the proper way of registering ModelAdmin
classes for extensions. Should I create extra AdminSite instance for
this purpose or use django.contrib.admin.site? I thought that just
registering ModelAdmin classes in myext.admin module would be OK but
it is not picked up by Django. I have added explicit import of admin
module in urls:
from django.conf.urls.defaults import include, patterns, url
from myext.admin import admin
urlpatterns = patterns('myext.views',
url(r'^$', 'dashboard'),
(r'^db/', include(admin.site.urls)),
)
and although it is working, there's always a list of all applications
in both myext/db and admin/db but in admin/db the myext application
urls are not valid. This doesn't look to good... Could you suggest a
right way of doing this? Any help would be greatly appreciated.
Thanks,
Bartek
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
