..@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
> On Sun, Mar 28, 2010 at 7:06 PM, plumpy wrote:
> > When you try to submit a diff, you get this:
> > 'NoneType' object has no attribute 'path2id'
>
> &g
When you try to submit a diff, you get this:
'NoneType' object has no attribute 'path2id'
This is the change that broke it:
http://github.com/reviewboard/reviewboard/commit/2f5b56e1f7cd33fd364481312a9ef078a2741dbe
I reverted scmtools/bzr.py back to the old version and it works fine.
I'm not sure
In the dashboard, the rightmost column is "...". If you click on that,
you get a list of other available columns to display. One of them is
"Review ID", which will show you what you want.
I think it's not displayed by default because there's nothing you can
really DO with this number. If there wa
I'm working on some of our bzr tools right now. I can try to look at
it early next week, but unless it's relatively straightforward, I
doubt I'll get around to fixing it. Honestly, I'm a little unsure why
it wouldn't work, since we're just using bzrlib, presumably accessing
it the exact same way b
While tracking down some caching issues we're having, I noticed that
build_diff_fragment in diffviewer/views.py isn't using the large_data
option to cache_memoize. Should it be? (That's not a rhetorical
question.)
I doubt this is the source of the problems we're having, but I noticed
it and thoug
The way we have it set up here is that the repository configured in
Review Board is the URL that contains the .bzr directory. In your
case, this looks like probably
http://a.org/~lead/projects/my_proj_mainline
Now if you're diffing against that directory directly, you'd use '/'
as your base diff
Because a diff file isn't very useful if you can't find the original
files to apply it to. In order to get those, you need the repository
and the base diff path.
On Mar 11, 8:53 am, lzhu wrote:
> What is the repository information used for since user needs to
> manually post the diff file? And w
There is a post-commit hook for subversion that will automatically
close reviews. That's not at all what you asked for, but maybe it will
help. It's at contrib/tools/post-commit.
On Mar 2, 1:22 pm, David Trowbridge wrote:
> We've been toying around with how best to do this for a while. Can you
>
We use it at Tripwire. I think a lot of people use it internally at
various companies. Did you have some specific question? The
configuration certainly shouldn't be any different than normal.
On Feb 23, 10:54 pm, Rohit wrote:
> Hi,
>
> Consider me a novice with review board.
>
> Just wanted to k
I can't speak for the maintainers, since I'm not one, but I wrote the
SVN UUID code. Basically you want to fetch and store the UUID for an
SVN repository any time you create or edit one, correct? That seems
perfectly reasonable to me. I say go for it.
On Feb 20, 8:52 am, "Gary M. Josack" wrote:
if any javascript files are 404s?
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> VMware, Inc.
>
> On Fri, Jan 30, 2009 at 2:41 PM, plumpy wrote:
>
> > Yeah, both Review Board and Djblets are version 20090130.
>
> > On Jan 30, 2:25 pm,
Yeah, both Review Board and Djblets are version 20090130.
On Jan 30, 2:25 pm, Christian Hammond wrote:
> Did you upgrade Djblets and restart Apache?
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> VMware, Inc.
>
> On Fri, Jan 30, 2009 at 11:24 AM, p
So I'd assume this has to do with the jquery upgrade. But I don't
understand why downgrading Review Board doesn't fix it. Hmm.
On Jan 30, 11:17 am, plumpy wrote:
> Last night I did an easy_install upgrade from the 01/25 build to the
> 01/29 build. Now no one can leave comments.
Last night I did an easy_install upgrade from the 01/25 build to the
01/29 build. Now no one can leave comments. Clicking on lines of code
on the diff does nothing. Clicking the "Review" button at the top puts
a little "Ship It" button and a text entry box at the very bottom of
the page... not in
I think you need to bump the djblets required version again. When I
upgraded tonight, I got an error when viewing a review request:
'invalid filter: range'. I did an 'easy_install --upgrade djblets' and
it was fixed.
--~--~-~--~~~---~--~~
You received this message b
I used to run the 20081231 build. When I tried to upgrade to 20090107,
I get this when viewing the dashboard. Other pages seem to work fine.
The line in question was added on 12/31, but I'm surprised no one else
has bumped into this?
Environment:
Request Method: GET
Request URL: http://reviews.d
Submitted is: /api/json/reviewrequests/nnn/close/submitted/
Ship it need to be set on a review, not on the review request...
On Dec 31, 1:48 am, "Sebastien Douche" wrote:
> Hi,
> i'm coding a CLI client for reviewboard, the goal is to cover common
> use cases (and reduce time consuming with bro
I have this issue on Ubuntu 8.10. The review dialog pops up like
normal and I can click into the various text entry fields, but I can't
enter text into any of them. (I can, however, check/uncheck the "Ship
It" checkbox.)
On Dec 29, 4:32 am, Ibmurai wrote:
> Hi,
>
> I've set review-board up on a
That is pretty much exactly what I did last week... Dumped my mysql
database without the table definitions, created a clean database,
loaded it with './manage.py syncdb', and then loaded my old data into
that database (after massaging a few things, like deleting the
permissions table and a few oth
You can just review your own code... Publish the review to yourself,
review it, then add the intended reviewers. I do that sometimes. Being
able to order the files would definitely be helpful.
On Sep 19, 11:50 am, Daniel Wexler <[EMAIL PROTECTED]> wrote:
> How do people annotate reviews prior to
20 matches
Mail list logo
