How do people annotate reviews prior to posting them publicly?
When preparing a new review, I like to annotate the code with comments
that describe the reasoning behind my choices. These comments help
guide the reviewer through the changes. It is great when these
annotations are tied to lines i
You can just review your own code... Publish the review to yourself,
review it, then add the intended reviewers. I do that sometimes. Being
able to order the files would definitely be helpful.
On Sep 19, 11:50 am, Daniel Wexler <[EMAIL PROTECTED]> wrote:
> How do people annotate reviews prior to
i imported the P4Tool.txt in perforce
installed python and simplejson
as soon as i go to submit for review
i get this error :
Usage: post-review [-pond] [-r review_id] [changenum]
post-review: error: no such option: --p4-client
when i click on the new option i've added in perforce
this what it r
Does post-review have --p4-port and --p4-client options?
I don't see them in my version.
On Sep 19, 9:40 am, 13Strider <[EMAIL PROTECTED]> wrote:
> i imported the P4Tool.txt in perforce
> installed python and simplejson
> as soon as i go to submit for review
> i get this error :
>
> Usage: post-
Yes i've added it from http://reviews.review-board.org/r/467/
On Sep 19, 1:44 pm, Daniel Wexler <[EMAIL PROTECTED]> wrote:
> Does post-review have --p4-port and --p4-client options?
>
> I don't see them in my version.
>
> On Sep 19, 9:40 am, 13Strider <[EMAIL PROTECTED]> wrote:
>
>
>
> > i import
I received comments from Christan to make changes to the argument names. So
if you update your version of post-review you should be good to go
On Fri, Sep 19, 2008 at 12:50 PM, 13Strider <[EMAIL PROTECTED]>wrote:
>
> Yes i've added it from http://reviews.review-board.org/r/467/
>
> On Sep 19, 1:
I have made the changes, this is what i have.
# set the P4 enviroment:
if options.p4_client:
os.environ['P4CLIENT'] = options.p4_client
if options.p4_port:
os.environ['P4PORT'] = options.p4_port
if isinstance(tool,PerforceClient):
parser.add_option("--p4-client",
dest="p4_client", default=None
That is what you need.
On Fri, Sep 19, 2008 at 12:57 PM, 13Strider <[EMAIL PROTECTED]>wrote:
>
> I have made the changes, this is what i have.
>
> # set the P4 enviroment:
> if options.p4_client:
> os.environ['P4CLIENT'] = options.p4_client
>
> if options.p4_port:
> os.environ['P4PORT'] = option
i still get the error
On Sep 19, 1:59 pm, "Joshua Slominski" <[EMAIL PROTECTED]> wrote:
> That is what you need.
>
> On Fri, Sep 19, 2008 at 12:57 PM, 13Strider <[EMAIL PROTECTED]>wrote:
>
>
>
>
>
> > I have made the changes, this is what i have.
>
> > # set the P4 enviroment:
> > if options.p4_c
This is Exactly what i got and I get the Error
On Sep 19, 1:59 pm, "Joshua Slominski" <[EMAIL PROTECTED]> wrote:
> That is what you need.
>
> On Fri, Sep 19, 2008 at 12:57 PM, 13Strider <[EMAIL PROTECTED]>wrote:
>
>
>
>
>
> > I have made the changes, this is what i have.
>
> > # set the P4 enviro
I Guess i have to wait till i get a responce from Christan ?
On Sep 19, 2:08 pm, 13Strider <[EMAIL PROTECTED]> wrote:
> This is Exactly what i got and I get the Error
>
> On Sep 19, 1:59 pm, "Joshua Slominski" <[EMAIL PROTECTED]> wrote:
>
>
>
> > That is what you need.
>
> > On Fri, Sep 19, 2008
I Fixed it thanks But now i get this Error
Unable to parse diff header: operable program or batch file
On Sep 19, 2:58 pm, 13Strider <[EMAIL PROTECTED]> wrote:
> I Guess i have to wait till i get a responce from Christan ?
>
> On Sep 19, 2:08 pm, 13Strider <[EMAIL PROTECTED]> wrote:
>
>
>
> > Th
First off, let me say that reviewboard is wonderful.
One strange issue we're seeing -- say that I post_review a review to a
friend A. The two of us get the initial "review created" email at
first, like we should. If A reviews it and says "ship it!", we're
seeing that A gets the email, but I don
Hi Kevin.
There was a bug where the recipients were added to the CC header but not
actually included in the list send to the sendmail() function. This was just
fixed in r1509 two nights ago, so check which revision you're using and do
an update.
Hope it works!
Christian
--
Christian Hammond -
Christian,
Great. We were at 1500, so I'm sure that's it. Thanks!
Kevin
On Fri, Sep 19, 2008 at 1:24 PM, Christian Hammond <[EMAIL PROTECTED]>wrote:
> Hi Kevin.
>
> There was a bug where the recipients were added to the CC header but not
> actually included in the list send to the sendmail()
I see an older discussion about the issue of Perforce security and the
need to put the P4 user and client information into the server:
http://groups.google.com/group/reviewboard/browse_thread/thread/d057cc0c05d51e1f
Any update on this situation?
My company is similarly concerned about this secur
it's not a pretty solution, but what about setting up multiple reviewboard
instances, with different user credentials in each (one for each project
you've got) then you only create accounts on the servers that theyr'e
supposed to have access to.
Jeff
O|||O
Help me and the Leukemia and Lymphoma
Has anyone explored the new Python bindings for Perforce?
http://www.perforce.com/perforce/doc.081/manuals/p4script/p4script.pdf
They seem to have functions for logging in to the server with a
specific user name and password from Python. Could we use this and
have the user's provide the Perforc
So, I think we already are using the official Perforce Python module.
That's good (it makes my IT guys happy).
Why do we use the client and repository setting for the Repository
instead of using a client/pass from the user?
I think my IT guys would be happy if we used the user's client/pass
info
This isn't a very usable solution, for a few reasons.
First, we can't use the user's Review Board username/pass, because this
won't always correspond to the account on the Perforce server. Also,
passwords are one-way encrypted so that they can't easily be decrypted if
the database is accessed by a
20 matches
Mail list logo
