Problem setting Syntax Highlighting option

2008-10-15 Thread fts1050
I installed the Pygments library, as a result, I was able to turn on syntax highlighting in gthe admin interface. When I hit "save" the notification said my setting was changed successfully, but the setting now appears unset again after the save occurred. I repeated this and no change. I am not su

email notifications - questions and possible issue

2008-10-16 Thread fts1050
I was wondering what all the events that cause an email trigger. My guess would be: 1.)When a review goes "live" (to everyone who is on the review) 2.)When a review gets closed ("set submitted") 3.)Anytime a review is published by any of the reviewers 4.)When a diff is updated 5.)More:? (Can you

diff view - looking to do full file reviews not a diff between two version

2008-10-16 Thread fts1050
In the diff viewer, for new files, only one version of the file is show (because only 1 exists). I would like our code reviews to be more about reviewing a file in a given state, not simply a diff. Is there anyway to create your diff so that the diff viewer will only show a single version of the f

Re: diff view - looking to do full file reviews not a diff between two version

2008-10-16 Thread fts1050
> 2. I haven't tried it, but there's a revision range argument on > > post-review.  Last I knew, this doesn't work for all SCM's, but it should > > eventually.  just supply a revision number like 0.  (this has been suggested > > before I think) > >

Re: Problem setting Syntax Highlighting option

2008-10-16 Thread fts1050
EMAIL PROTECTED] > VMware, Inc. > > On Wed, Oct 15, 2008 at 7:02 AM, fts1050 <[EMAIL PROTECTED]> wrote: > > > I installed the Pygments library, as a result, I was able to turn on > > syntax highlighting in gthe admin interface. When I hit "save" the > > n

Limitations with diff files - any suggestions?

2008-10-28 Thread fts1050
I am using CVS as my code repository and the Post Review tool, and we wish to do post commit reviews and have been successful for some cases. However, I have some diff scenarios that I am having trouble generating easily in order to successfully create the code reviews I want. Aside: Is there an

Re: email notifications - questions and possible issue

2008-11-04 Thread fts1050
4 AM, Nancy Bennett < > >> [EMAIL PROTECTED]> wrote: > > >>> Thanks for the response, any thoughts on why those emails only work > >>> sometimes? Has anyone else had this issue besides me? > > >>> On Thu, Oct 16, 2008 at 1:37 PM, David Trowbridge

Re: Limitations with diff files - any suggestions?

2008-11-04 Thread fts1050
Chris Thanks for the feedback. I almost went ahead and made these changes, then I realized that it might not be worth it as we are starting to think that, for our needs, post review is not fully featured enough for what we need to do. Even with CVS diff we found we needed to manually make changes

Possible bug with discard functionality

2008-11-12 Thread fts1050
I might have found a bug (I am on r1537): I added Reviewer A to a review. Reviewer A discarded the review. As a result, the submitter of the review (assuming other reviewers as well, but this is what I tested) can no longer do subsequent publishes on the review. The behavior is that you hit the