Re: Question about running post-review
On Tue, Oct 13, 2009 at 8:33 PM, Alfred von Campe wrote: > Any idea on the schedule for 1.1? Is it one day, one week, one > month, one quarter? > > Alfred > It's tentatively scheduled for around January, but this depends on our availability between now and then, and the number of bugs found during the beta cycle. Alpha 2 will be released perhaps this upcoming weekend, but definitely before the end of the month. Beta 1 should be in November, Beta 2 either late November or in December, followed by an RC in january and then hopefully a final release shortly after. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Question about running post-review
Hi Christian: > Also, when you saw ClientError from post-review, that was output > from the server. So it's the same problem. I'd recommend restarting > Apache just in case it is an issue with one or two threads not > having imported it successfully. I thought I had restarted Apache, but perhaps I did not. I haven't seen the error again, so you are probably right. > I should also mention that the upcoming 1.1 release does a much > better job of dependency checking. It's impossible to create a > repository entry without first having all the necessary > dependencies correctly installed. However, there's nothing we can > do about the above problem except to say to restart Apache. Any idea on the schedule for 1.1? Is it one day, one week, one month, one quarter? Alfred --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.review-board.org/donate/ Happy user? Let us know at http://www.review-board.org/users/ -~--~~~~--~~--~--~--- You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Question about running post-review
Also, when you saw ClientError from post-review, that was output from the server. So it's the same problem. I'd recommend restarting Apache just in case it is an issue with one or two threads not having imported it successfully. I should also mention that the upcoming 1.1 release does a much better job of dependency checking. It's impossible to create a repository entry without first having all the necessary dependencies correctly installed. However, there's nothing we can do about the above problem except to say to restart Apache. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, Oct 13, 2009 at 2:03 PM, Christian Hammond wrote: > Hi, > > The only way to get a ClientError is if pysvn didn't import properly. This > sporadic behavior can happen if you've installed pysvn since starting > Apache. Some threads will have failed to import it (back when it didn't > exist) and some will have succeeded (as they tried after the install). This > is the only thing I can see happening. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board - http://www.review-board.org > VMware, Inc. - http://www.vmware.com > > > > On Tue, Oct 13, 2009 at 6:05 AM, Alfred von Campe wrote: > >> >> On Oct 12, 2009, at 11:42, Alfred von Campe wrote: >> >> The error I posted yesterday is suddenly gone today; that is, I ran >> post-review again in the same sandbox and the review posted without >> errors. I have not changed a thing on the server. Furthermore, when >> I went into the web interface and clicked on "View Diff" for the >> first time, I got a similar stack trace containing "ClientError not >> defined". However, the second time I clicked on "View Diff" it >> displayed properly. So it looks like I'm all set to announce this to >> the developers, although it appears to be a little fragile still. I >> don't like it when things "fix themselves" and I don't understand >> what the underlying problem was (or is) as it will probably come back >> to bite me in the future. Now if I can just get LDAP or AD >> integration to work... >> >> Alfred >> >> >> >> You received this message because you are subscribed to the Google >> Groups "reviewboard" group. >> To post to this group, send email to reviewboard@googlegroups.com >> To unsubscribe from this group, send email to >> reviewboard+unsubscr...@googlegroups.com >> For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en >> -~--~~~~--~~--~--~--- >> >> > --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.review-board.org/donate/ Happy user? Let us know at http://www.review-board.org/users/ -~--~~~~--~~--~--~--- You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Question about running post-review
Hi, The only way to get a ClientError is if pysvn didn't import properly. This sporadic behavior can happen if you've installed pysvn since starting Apache. Some threads will have failed to import it (back when it didn't exist) and some will have succeeded (as they tried after the install). This is the only thing I can see happening. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, Oct 13, 2009 at 6:05 AM, Alfred von Campe wrote: > > On Oct 12, 2009, at 11:42, Alfred von Campe wrote: > > The error I posted yesterday is suddenly gone today; that is, I ran > post-review again in the same sandbox and the review posted without > errors. I have not changed a thing on the server. Furthermore, when > I went into the web interface and clicked on "View Diff" for the > first time, I got a similar stack trace containing "ClientError not > defined". However, the second time I clicked on "View Diff" it > displayed properly. So it looks like I'm all set to announce this to > the developers, although it appears to be a little fragile still. I > don't like it when things "fix themselves" and I don't understand > what the underlying problem was (or is) as it will probably come back > to bite me in the future. Now if I can just get LDAP or AD > integration to work... > > Alfred > > > > You received this message because you are subscribed to the Google > Groups "reviewboard" group. > To post to this group, send email to reviewboard@googlegroups.com > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -~--~~~~--~~--~--~--- > > --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.review-board.org/donate/ Happy user? Let us know at http://www.review-board.org/users/ -~--~~~~--~~--~--~--- You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Question about running post-review
On Oct 12, 2009, at 11:42, Alfred von Campe wrote: The error I posted yesterday is suddenly gone today; that is, I ran post-review again in the same sandbox and the review posted without errors. I have not changed a thing on the server. Furthermore, when I went into the web interface and clicked on "View Diff" for the first time, I got a similar stack trace containing "ClientError not defined". However, the second time I clicked on "View Diff" it displayed properly. So it looks like I'm all set to announce this to the developers, although it appears to be a little fragile still. I don't like it when things "fix themselves" and I don't understand what the underlying problem was (or is) as it will probably come back to bite me in the future. Now if I can just get LDAP or AD integration to work... Alfred --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.review-board.org/donate/ Happy user? Let us know at http://www.review-board.org/users/ -~--~~~~--~~--~--~--- You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Question about running post-review
On Oct 12, 2009, at 11:27, David Trowbridge wrote:
> If you run post-review with --debug, it'll spit out a bunch of output
> which should hopefully tell you the real error.
I must be going bling; I didn't see that option in the output of
"post-review -h" but it's right there at the bottom. Here's the
(slightly edited) output which is not very helpful to me but
hopefully will be to someone on this list:
$ post-review -d
>>> svn info
>>> repository info: Path: svn+ssh://svn.XXX.com/svn/projectX,
Base path: /trunk, Supports changesets: False
>>> svn propget reviewboard:url /scratch/Sandbox/projectX/trunk
>>> svn diff --diff-cmd=diff
>>> svn info Scripts/install.sh
>>> svn info Scripts/install.sh
>>> svn info Scripts/install.sh
>>> svn info Scripts/install.sh
>>> Looking for 'rb.XXX.com /rb/' cookie in /home/avc/.post-review-
cookies.txt
>>> Loaded valid cookie -- no login required
>>> Attempting to create review request for None
>>> HTTP GETting /api/json/repositories/
>>> HTTP GETting /api/json/repositories/1/info/
>>> repository info: Path: svn+ssh://svn.XXX.com/svn/projectX,
Base path: /trunk, Supports changesets: False
>>> HTTP POSTing to http://rb.XXX.com/rb/api/json/reviewrequests/
new/: {'repository_path': 'svn+ssh://svn.XXX.com/svn/projectX'}
>>> Review request created
>>> Uploading diff, size: 3187
>>> HTTP POSTing to http://rb.XXX.com/rb/api/json/reviewrequests/6/
diff/new/: {'basedir': '/trunk'}
Error uploading diff: One or more fields had errors (105)
>>> {'fields': {'path': ["global name 'ClientError' is not
defined"]}, 'stat': 'fail', 'err': {'msg': 'One or more fields had
errors', 'co
Your review request still exists, but the diff is not attached.
Any ideas what can be causing my post-review error?
Alfred
--~--~-~--~~~---~--~~
Want to help the Review Board project? Donate today at
http://www.review-board.org/donate/
Happy user? Let us know at http://www.review-board.org/users/
-~--~~~~--~~--~--~---
You received this message because you are subscribed to the Google
Groups "reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: Question about running post-review
If you run post-review with --debug, it'll spit out a bunch of output which should hopefully tell you the real error. -David On Mon, Oct 12, 2009 at 7:59 AM, Alfred von Campe wrote: > > On Oct 10, 2009, at 6:10, Raghu wrote: > >> post-review is usually run from the user's development box, not the >> server. It will connect to the server over http(s) and upload the >> review request. > > Yes, I realize that, which is why I asked how I can get post-review > installed on all the developer desktops. But I've since found the > answer: I can use "easy_install RBTools" to install post-review on > all developer desktops. > > I think I'm getting very close (except for LDAP/AP integration). I > had to build pysvn from source since it doesn't appear to be > available in RPM format for Red Hat/CentOS and isntall it on the > server. Now when I run post-review the request gets generated on the > server (I can see it in the web interface), but I get the following > error: > > $ post-review > Error uploading diff: One or more fields had errors (105) > Your review request still exists, but the diff is not attached. > > What is error 105 and how can I find out more about it to get it > fixed? I can't find any logs that would help me figure this out... > > Thanks, > Alfred > > > > You received this message because you are subscribed to the Google > Groups "reviewboard" group. > To post to this group, send email to reviewboard@googlegroups.com > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -~--~~~~--~~--~--~--- > > --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.review-board.org/donate/ Happy user? Let us know at http://www.review-board.org/users/ -~--~~~~--~~--~--~--- You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Question about running post-review
On Oct 10, 2009, at 6:10, Raghu wrote: > post-review is usually run from the user's development box, not the > server. It will connect to the server over http(s) and upload the > review request. Yes, I realize that, which is why I asked how I can get post-review installed on all the developer desktops. But I've since found the answer: I can use "easy_install RBTools" to install post-review on all developer desktops. I think I'm getting very close (except for LDAP/AP integration). I had to build pysvn from source since it doesn't appear to be available in RPM format for Red Hat/CentOS and isntall it on the server. Now when I run post-review the request gets generated on the server (I can see it in the web interface), but I get the following error: $ post-review Error uploading diff: One or more fields had errors (105) Your review request still exists, but the diff is not attached. What is error 105 and how can I find out more about it to get it fixed? I can't find any logs that would help me figure this out... Thanks, Alfred --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.review-board.org/donate/ Happy user? Let us know at http://www.review-board.org/users/ -~--~~~~--~~--~--~--- You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Question about running post-review
post-review is usually run from the user's development box, not the server. It will connect to the server over http(s) and upload the review request. -Raghu On Oct 8, 10:47 pm, Alfred von Campe wrote: > I'm still in the process of setting up out ReviewBoard server > (struggling with LDAP/AD integration at the moment), but I'm looking > slightly ahead. It appears that post-review is the recommended way to > create a review (we're using Subversion if that matters), and I can > see that post-review has been installed into /usr/bin/post-review. > However, the server I installed ReviewBoard on is not a server that > allows users to log in, and besides, the user's sandboxes are not on > that server anyway. So how is a user supposed to run post-review on > his or her system? I'm dealing with a few dozen developers on a few > dozen Linux systems; am I supposed to install ReviewBoard on each > user's desktop? > > Alfred --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Question about running post-review
I'm still in the process of setting up out ReviewBoard server (struggling with LDAP/AD integration at the moment), but I'm looking slightly ahead. It appears that post-review is the recommended way to create a review (we're using Subversion if that matters), and I can see that post-review has been installed into /usr/bin/post-review. However, the server I installed ReviewBoard on is not a server that allows users to log in, and besides, the user's sandboxes are not on that server anyway. So how is a user supposed to run post-review on his or her system? I'm dealing with a few dozen developers on a few dozen Linux systems; am I supposed to install ReviewBoard on each user's desktop? Alfred --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
