Re: Review Request 64827: Debug about restart agent command sent by server

2017-12-26 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64827/#review194509 --- Ship it! Ship It! - Andrew Onischuk On Dec. 23, 2017, 12:43

Re: Review Request 64552: Fix misuses of os.path.dirname(path) in yarn.py

2017-12-20 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64552/#review194316 --- Ship it! Ship It! - Andrew Onischuk On Dec. 12, 2017, 7:36

Re: Review Request 64747: Don't call pprint.pformat unnecessarily in Ambari agent

2017-12-20 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64747/#review194235 --- Ship it! Ship It! - Andrew Onischuk On Dec. 20, 2017, 12:18

Re: Review Request 64747: Don't call pprint.pformat unnecessarily in Ambari agent

2017-12-20 Thread Andrew Onischuk
214 (original), 215 (patched) <https://reviews.apache.org/r/64747/#comment272963> Not a issue. Just wondering if that does make a change in calls number or just a refactoring. - Andrew Onischuk On Dec. 20, 2017, 12:18 p.m., Attila Magyar

Review Request 64710: UI hangs on step 2 of security wizard

2017-12-19 Thread Andrew Onischuk
/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 64709: Stack unit tests fixes

2017-12-19 Thread Andrew Onischuk
fede57b075 ambari-server/src/test/python/stacks/2.6/configs/default_kafka_sasl_plaintext.json 953e44462a ambari-server/src/test/python/stacks/2.6/configs/default_kafka_sasl_ssl.json c00528c499 Diff: https://reviews.apache.org/r/64709/diff/1/ Testing --- mvn clean test Thanks, Andrew

Review Request 64682: Fix unit test failures caused by old json format

2017-12-18 Thread Andrew Onischuk
://reviews.apache.org/r/64682/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 64547: Hive MetaStore does not start even after passing the mysql-connector to ambari-server

2017-12-12 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64547/#review193546 --- Ship it! Ship It! - Andrew Onischuk On Dec. 12, 2017, 3:49

Review Request 64501: Fix Stacks UT based on secured.json/default.json

2017-12-11 Thread Andrew Onischuk
ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/scripts/hive.py f9ad166aef Diff: https://reviews.apache.org/r/64501/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 64499: Reporting host status was broken by merge

2017-12-11 Thread Andrew Onischuk
-22623 https://issues.apache.org/jira/browse/AMBARI-22623 Repository: ambari Description --- Diffs - ambari-agent/src/main/python/ambari_agent/HostStatusReporter.py c27ee552f6 Diff: https://reviews.apache.org/r/64499/diff/1/ Testing --- mvn clean test Thanks, Andrew

Review Request 64498: NFSGateway start failing with error : "ERROR: You must be a privileged user in order to run a secure service."

2017-12-11 Thread Andrew Onischuk
raise ExecutionFailed(err_msg, code, out, err) resource_management.core.exceptions.ExecutionFailed: Execution of 'ambari-sudo.sh su hdfs -l -s /bin/bash -c 'ulimit -c unlimited ; /usr/hdp/3.0.0.0-555/hadoop/bin/hdfs --config /usr/hdp/3.0.0.0-555/hadoop/conf --daemon start nfs3'' returned 1. WARNING: HADOOP_PRIVILEGED_NFS_USER has been replaced by HDFS_NFS3_SECURE_USER. Using value of HADOOP_PRIVILEGED_NFS_USER. WARNING: HADOOP_NFS3_OPTS has been replaced by HDFS_NFS3_OPTS. Using value of HADOOP_NFS3_OPTS. ERROR: You must be a privileged user in order to run a secure service. Diffs - ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/status_params.py 153f9a6ca6 Diff: https://reviews.apache.org/r/64498/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario

2017-12-05 Thread Andrew Onischuk
libraries.script import Script return RepositoryUtil(Script.get_config(), set()).create_repo_files() ... - Andrew Onischuk On Dec. 5, 2017, 11:04 a.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario

2017-12-05 Thread Andrew Onischuk
://reviews.apache.org/r/64209/diff/2/ Changes: https://reviews.apache.org/r/64209/diff/1-2/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 64275: Broken Python Unit Tests in branch-2.6

2017-12-02 Thread Andrew Onischuk
es:0 Diffs - ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 10a83d6c23 ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 29cbddca55 Diff: https://reviews.apache.org/r/64275/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario

2017-12-02 Thread Andrew Onischuk
ustom repo handling > in any case, we do not have a repo-tag -> license-tag mapping anywhere so > wouldn't it be equally ugly? > > Sid Wagle wrote: > By license-tag I meant some lookup to figure out whether license was > accepted. > > Andrew Onischuk wrote:

Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario

2017-12-01 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64209/#review192365 ------- On Nov. 30, 2017, 1:28 p.m., Andrew Onischuk wrote: > > -

Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario

2017-12-01 Thread Andrew Onischuk
iew192335 --- On Nov. 30, 2017, 1:28 p.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 64186: Update server setup to deny GPL as default

2017-11-30 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64186/#review192331 --- Ship it! Ship It! - Andrew Onischuk On Nov. 30, 2017, 6:36

Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario

2017-11-30 Thread Andrew Onischuk
ambari-server/src/test/python/stacks/utils/RMFTestCase.py 80712c5ebe Diff: https://reviews.apache.org/r/64209/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 64186: Update server setup to deny GPL as default

2017-11-30 Thread Andrew Onischuk
> On Nov. 30, 2017, 8:19 a.m., Andrew Onischuk wrote: > > ambari-server/src/main/python/ambari_server/serverConfiguration.py > > Line 1162 (original), 1157 (patched) > > <https://reviews.apache.org/r/64186/diff/3/?file=1904146#file1904146line1163> > > > >

Re: Review Request 64186: Update server setup to deny GPL as default

2017-11-30 Thread Andrew Onischuk
> On Nov. 30, 2017, 8:19 a.m., Andrew Onischuk wrote: > > ambari-server/src/main/python/ambari_server/serverConfiguration.py > > Line 1162 (original), 1157 (patched) > > <https://reviews.apache.org/r/64186/diff/3/?file=1904146#file1904146line1163> > > > >

Re: Review Request 64186: Update server setup to deny GPL as default

2017-11-30 Thread Andrew Onischuk
> On Nov. 30, 2017, 8:19 a.m., Andrew Onischuk wrote: > > ambari-server/src/main/python/ambari_server/serverConfiguration.py > > Line 1162 (original), 1157 (patched) > > <https://reviews.apache.org/r/64186/diff/3/?file=1904146#file1904146line1163> > > > >

Re: Review Request 64186: Update server setup to deny GPL as default

2017-11-30 Thread Andrew Onischuk
/serverConfiguration.py Line 1162 (original), 1157 (patched) <https://reviews.apache.org/r/64186/#comment270281> I think you might have broken silent flag to enable gpl by doing this. - Andrew Onischuk On Nov. 30, 2017, 12:20 a.m., Sid Wagle

Re: Review Request 64186: Update server setup to deny GPL as default

2017-11-30 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64186/#review192244 --- Ship it! Ship It! - Andrew Onischuk On Nov. 30, 2017, 12:20

Review Request 64153: Oozie stop failed during IOP migration with missing module get_lzo_packages

2017-11-29 Thread Andrew Onischuk
ckage/scripts/params_linux.py 0e6179b8a7 Diff: https://reviews.apache.org/r/64153/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 64117: PERF stack fixes

2017-11-28 Thread Andrew Onischuk
833fdbc8ac Diff: https://reviews.apache.org/r/64117/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 64117: PERF stack fixes

2017-11-28 Thread Andrew Onischuk
Diff: https://reviews.apache.org/r/64117/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 64082: PERF stack: deploy fails due to incorrect stack upgrade related information

2017-11-27 Thread Andrew Onischuk
/stack_packages.json PRE-CREATION Diff: https://reviews.apache.org/r/64082/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 63982: Port AMBARI-22467 to BigInsight

2017-11-21 Thread Andrew Onischuk
://reviews.apache.org/r/63982/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 63916: YARN, MapReduce2, Hive, and Oozie Should Conditionally Install LZO

2017-11-20 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63916/#review191492 --- Thanks for reviews - Andrew Onischuk On Nov. 20, 2017, 10:35

Re: Review Request 63916: YARN, MapReduce2, Hive, and Oozie Should Conditionally Install LZO

2017-11-20 Thread Andrew Onischuk
-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 86ca03a4a3101e646f265b5dca6e32bb179c9856 Diff: https://reviews.apache.org/r/63916/diff/2/ Changes: https://reviews.apache.org/r/63916/diff/1-2/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 63916: YARN, MapReduce2, Hive, and Oozie Should Conditionally Install LZO

2017-11-20 Thread Andrew Onischuk
Also - don't forget to merge into 3.0 stack in trunk as well ... anything > Python changes in branch-2.6 need extra-work done when going into trunk. > > Andrew Onischuk wrote: > Sure @Jonathan. > Do you guys think a separate jira sho

Re: Review Request 63916: YARN, MapReduce2, Hive, and Oozie Should Conditionally Install LZO

2017-11-18 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63916/#review191346 ------- On Nov. 17, 2017, 2:40 p.m., Andrew Onischuk wrote: > > -

Re: Review Request 63916: YARN, MapReduce2, Hive, and Oozie Should Conditionally Install LZO

2017-11-18 Thread Andrew Onischuk
ow if you think differently - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63916/#review191345 --- On Nov. 17,

Re: Review Request 63916: YARN, MapReduce2, Hive, and Oozie Should Conditionally Install LZO

2017-11-18 Thread Andrew Onischuk
eviews.apache.org/r/63916/#review191345 --- On Nov. 17, 2017, 2:40 p.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 63916: YARN, MapReduce2, Hive, and Oozie Should Conditionally Install LZO

2017-11-18 Thread Andrew Onischuk
enerated e-mail. To reply, visit: https://reviews.apache.org/r/63916/#review191344 --- On Nov. 17, 2017, 2:40 p.m., Andrew Onischuk wrote: > > --- > This is an automati

Re: Review Request 63916: YARN, MapReduce2, Hive, and Oozie Should Conditionally Install LZO

2017-11-17 Thread Andrew Onischuk
it for easier review. - Andrew Onischuk On Nov. 17, 2017, 2:40 p.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 63916: YARN, MapReduce2, Hive, and Oozie Should Conditionally Install LZO

2017-11-17 Thread Andrew Onischuk
Thanks, Andrew Onischuk

Re: Review Request 63876: ambari-server upgrade to 2.6.1 should surface the GPL agreement

2017-11-17 Thread Andrew Onischuk
/ambari_server/serverUpgrade.py 421adfc4a1 ambari-server/src/test/python/TestAmbariServer.py 840b9a6579 Diff: https://reviews.apache.org/r/63876/diff/2/ Changes: https://reviews.apache.org/r/63876/diff/1-2/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 63838: ambari-server setup should surface GPL software agreement

2017-11-16 Thread Andrew Onischuk
accidentally committed old version of the patch (from here) - Andrew Onischuk On Nov. 16, 2017, 6:26 a.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 63876: ambari-server upgrade to 2.6.1 should surface the GPL agreement

2017-11-16 Thread Andrew Onischuk
/63876/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 63872: NFSGateway start failed

2017-11-16 Thread Andrew Onischuk
/role_command_order.json 78a31f1797 Diff: https://reviews.apache.org/r/63872/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 63838: ambari-server setup should surface GPL software agreement

2017-11-16 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63838/#review191162 --- Thanks for your reviews guys. - Andrew Onischuk On Nov. 16

Review Request 63838: ambari-server setup should surface GPL software agreement

2017-11-15 Thread Andrew Onischuk
ambari-server/src/main/python/ambari_server/serverConfiguration.py c7ac13476f ambari-server/src/main/python/ambari_server/serverSetup.py c1643f2621 Diff: https://reviews.apache.org/r/63838/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 63755: Check if configurations used for commands are of correct version

2017-11-13 Thread Andrew Onischuk
/ambari_agent/dummy_files/stomp/execution_commands.json 76dac1b975 Diff: https://reviews.apache.org/r/63755/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 63464: Beeline connection hangs for longer time when connection to HS2 with metastore DB down

2017-11-10 Thread Andrew Onischuk
/diff/2/ Changes: https://reviews.apache.org/r/63464/diff/1-2/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 63464: Beeline connection hangs for longer time when connection to HS2 with metastore DB down

2017-11-10 Thread Andrew Onischuk
ark2 - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63464/#review190596 --- On Nov. 1, 2017, 12:43 p.m., Andrew

Review Request 63702: PERF stack: Deploy fails due to common hooks being used instead of one specific to PERF

2017-11-09 Thread Andrew Onischuk
, Andrew Onischuk

Review Request 63701: Upstart is not able to stop the ambari-agent

2017-11-09 Thread Andrew Onischuk
----- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 63618: Multiple issue with handling unexcepted situations

2017-11-07 Thread Andrew Onischuk
ly, visit: https://reviews.apache.org/r/63618/#review190309 ------- On Nov. 7, 2017, 1:48 p.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail.

Review Request 63618: Multiple issue with handling unexcepted situations

2017-11-07 Thread Andrew Onischuk
/TestAgentStompResponses.py 2154fca8d3 Diff: https://reviews.apache.org/r/63618/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 63444: A bunch of alerts fails due to absence of configs

2017-11-02 Thread Andrew Onischuk
/main/python/ambari_agent/alerts/script_alert.py 301e4401f9 ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 0e400f75e3 Diff: https://reviews.apache.org/r/63444/diff/2/ Changes: https://reviews.apache.org/r/63444/diff/1-2/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 63504: Changing hostname causes ambari-agent start to fail

2017-11-02 Thread Andrew Onischuk
nt/src/main/python/ambari_agent/main.py 3948290519 ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 2154fca8d3 Diff: https://reviews.apache.org/r/63504/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 63464: Beeline connection hangs for longer time when connection to HS2 with metastore DB down

2017-11-01 Thread Andrew Onischuk
/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 63444: A bunch of alerts fails due to absence of configs

2017-10-31 Thread Andrew Onischuk
/script_alert.py 301e4401f9 ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 0e400f75e3 Diff: https://reviews.apache.org/r/63444/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 63412: Alerts UPDATE/DELETE should work deleting and adding a cluster

2017-10-30 Thread Andrew Onischuk
/main/resources/stacks/PERF/2.0/repos/repoinfo.xml 5c3b40b7e5 contrib/utils/perf/deploy-gce-perf-cluster.py 7431ae9d7a Diff: https://reviews.apache.org/r/63412/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 63411: PERF stack: UI hangs to 2nd step

2017-10-30 Thread Andrew Onischuk
/stacks/PERF/2.0/repos/repoinfo.xml 5c3b40b7e5 ambari-server/src/main/resources/stacks/PERF/2.0/vdf.xml PRE-CREATION Diff: https://reviews.apache.org/r/63411/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 63289: Spark history server is stopped (with umask 027 and custom spark log/pid dir)

2017-10-25 Thread Andrew Onischuk
tacks/2.3/SPARK/test_spark_thrift_server.py fbe5403a35 Diff: https://reviews.apache.org/r/63289/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 63243: Unable to Enable NameNode HA on branch-3.0-perf

2017-10-24 Thread Andrew Onischuk
l be used to report the version of the component which was installed Command failed after 1 tries Diffs - ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 289a1d6571 Diff: https://reviews.apache.org/r/63243/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 63240: RU tasks fail

2017-10-24 Thread Andrew Onischuk
rc/main/resources/custom_actions/scripts/ru_execute_tasks.py 23a0cfb7f5 Diff: https://reviews.apache.org/r/63240/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 63080: Smartsense requires HDFS to be always present while installing

2017-10-17 Thread Andrew Onischuk
ns.Fail: Configuration parameter 'fs.defaultFS' was not found in configurations dictionary! Diffs - ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 55a609328e Diff: https://reviews.apache.org/r/63080/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 63071: A bunch of services fail to start

2017-10-17 Thread Andrew Onischuk
/scripts/params.py 466837c5cd Diff: https://reviews.apache.org/r/63071/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 62932: Deploy fails due to PU code related issues (post-merge)

2017-10-13 Thread Andrew Onischuk
/python/custom_actions/test_ru_set_all.py de83f7e07b Diff: https://reviews.apache.org/r/62932/diff/2/ Changes: https://reviews.apache.org/r/62932/diff/1-2/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 62932: Deploy fails due to PU code related issues (post-merge)

2017-10-12 Thread Andrew Onischuk
/test_ru_set_all.py de83f7e07b Diff: https://reviews.apache.org/r/62932/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 62888: ZKFC start failed due to hadoop-hdfs-zkfc is not supported

2017-10-11 Thread Andrew Onischuk
/stacks/HDP/2.0.6/properties/stack_packages.json 2db0a74195 Diff: https://reviews.apache.org/r/62888/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 62808: hadooplzo package installation failed on devdeploys

2017-10-10 Thread Andrew Onischuk
/utils/RMFTestCase.py 7091298cbc Diff: https://reviews.apache.org/r/62808/diff/3/ Changes: https://reviews.apache.org/r/62808/diff/2-3/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 62808: hadooplzo package installation failed on devdeploys

2017-10-06 Thread Andrew Onischuk
/python/stacks/utils/RMFTestCase.py c10ff64e0b Diff: https://reviews.apache.org/r/62808/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 62808: hadooplzo package installation failed on devdeploys

2017-10-06 Thread Andrew Onischuk
/test/python/stacks/utils/RMFTestCase.py c10ff64e0b Diff: https://reviews.apache.org/r/62808/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 62771: Agent UT fail on trunk

2017-10-04 Thread Andrew Onischuk
8e07 ambari-agent/src/test/python/ambari_agent/TestSecurity.py c9a7fbe865 Diff: https://reviews.apache.org/r/62771/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 62750: Cache becomes corrupt

2017-10-03 Thread Andrew Onischuk
correctly, during rewritting. This happened only once on perf cluster. But worth a preventive fix. Diffs - ambari-agent/src/main/python/ambari_agent/ClusterCache.py 40b32886cf Diff: https://reviews.apache.org/r/62750/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 62674: A couple of merge fixes for branch-3.0-perf

2017-09-29 Thread Andrew Onischuk
/UpgradeCatalog300Test.java 95a04deb6b ambari-web/app/mixins/common/persist.js e69de29bb2 Diff: https://reviews.apache.org/r/62674/diff/3/ Changes: https://reviews.apache.org/r/62674/diff/2-3/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 62674: A couple of merge fixes for branch-3.0-perf

2017-09-28 Thread Andrew Onischuk
://reviews.apache.org/r/62674/diff/2/ Changes: https://reviews.apache.org/r/62674/diff/1-2/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 62674: A couple of merge fixes for branch-3.0-perf

2017-09-28 Thread Andrew Onischuk
://reviews.apache.org/r/62674/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 62667: Zeppelin start failed

2017-09-28 Thread Andrew Onischuk
credentials",) Diffs - ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py af5758a6c5 Diff: https://reviews.apache.org/r/62667/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 62563: Reduce alert reports performance overhead

2017-09-26 Thread Andrew Onischuk
eviews.apache.org/r/62563/#review186227 --- On Sept. 26, 2017, 10:58 a.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 62563: Reduce alert reports performance overhead

2017-09-26 Thread Andrew Onischuk
, Andrew Onischuk

Re: Review Request 62563: Reduce alert reports performance overhead

2017-09-26 Thread Andrew Onischuk
, Andrew Onischuk

Review Request 62563: Reduce alert reports performance overhead

2017-09-26 Thread Andrew Onischuk
/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java 3607df4 Diff: https://reviews.apache.org/r/62563/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 62501: configs.py does not work properly when dealing with files

2017-09-22 Thread Andrew Onischuk
- ambari-server/src/main/resources/scripts/configs.py 639f28e ambari-server/src/main/resources/scripts/configs.sh 5fc96fd Diff: https://reviews.apache.org/r/62501/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 62500: File "hdfs.headless.keytab" has incorrect permission

2017-09-22 Thread Andrew Onischuk
rg/r/62500/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 62431: Ambari schema upgrade failure as views destination path dir already exists

2017-09-20 Thread Andrew Onischuk
Upgrade.py a10841d Diff: https://reviews.apache.org/r/62431/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 62402: Multiple fixes into branch-3.0-perf

2017-09-19 Thread Andrew Onischuk
/TestAgentStompResponses.py 3c571ab Diff: https://reviews.apache.org/r/62402/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 62388: APPLICATION_TIMELINE_SERVER filed to start, coz were already started

2017-09-19 Thread Andrew Onischuk
> > Sounds like a very dirty hack. Does that reproduce in latest Ambari > > versions? Maybe it would be better to check status() before attempt to run > > start() ? > > Andrew Onischuk wrote: > +1. Checking output might break with a simple change to ats, also i

Re: Review Request 62388: APPLICATION_TIMELINE_SERVER filed to start, coz were already started

2017-09-19 Thread Andrew Onischuk
-- > > (Updated Sept. 18, 2017, 6 p.m.) > > > Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Robert > Levas. > > > Bugs: AMBARI-21984 > https://issues.apache.org/jira/browse/AMBARI-21984 > > > Repository: ambari

Re: Review Request 62388: APPLICATION_TIMELINE_SERVER filed to start, coz were already started

2017-09-19 Thread Andrew Onischuk
output in exception text. To give debugging information for failures of ATS. - Andrew Onischuk On Sept. 18, 2017, 6 p.m., Eugene Chekanskiy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Review Request 62379: Fixes to CommandStatusDict

2017-09-18 Thread Andrew Onischuk
ambari-agent/src/main/python/ambari_agent/InitializerModule.py 4fbef65 Diff: https://reviews.apache.org/r/62379/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 62278: Ambari updates database/tables location from intended remote HDFS to local HDFS

2017-09-13 Thread Andrew Onischuk
/params_linux.py 956438e ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml eb16778 Diff: https://reviews.apache.org/r/62278/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 62215: Ambari should honor permissions specified for dfs.datanode.data.dir.perm when creating datanode dir's

2017-09-11 Thread Andrew Onischuk
966254a Diff: https://reviews.apache.org/r/62215/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 62151: Component status reports are sent for the components which are not on the host

2017-09-07 Thread Andrew Onischuk
/python/ambari_agent/ComponentStatusExecutor.py 4ccd815 Diff: https://reviews.apache.org/r/62151/diff/2/ Changes: https://reviews.apache.org/r/62151/diff/1-2/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 62151: Component status reports are sent for the components which are not on the host

2017-09-07 Thread Andrew Onischuk
test Thanks, Andrew Onischuk

Re: Review Request 62121: Fix AmbariServerTest

2017-09-06 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62121/#review184672 --- Ship it! Ship It! - Andrew Onischuk On Sept. 6, 2017, 1:41

Re: Review Request 61886: AMBARI-21803. Implement STOMP endpoint for alert definitions

2017-09-05 Thread Andrew Onischuk
have now sends port property as "defaultPort" and "port" instead of "default_port". Is that expected to happen? Should I do the change in python code to reflect this? - Andrew Onischuk On Sept. 5, 2017, 12:3

Re: Review Request 62058: Deploys failing with MR service check failure due to missing mapreduce.tar.gz

2017-09-05 Thread Andrew Onischuk
hon/resource_management/libraries/functions/copy_tarball.py 795160c Diff: https://reviews.apache.org/r/62058/diff/2/ Changes: https://reviews.apache.org/r/62058/diff/1-2/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 62081: AMBARI-21878. Implement STOMP endpoint to handle alerts from agent

2017-09-05 Thread Andrew Onischuk
> On Sept. 5, 2017, 12:44 p.m., Andrew Onischuk wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py > > Line 149 (original), 149 (patched) > > <https://reviews.apache.org/r/62081/diff/1/?file=1814401#file1814401line149> > > > >

Re: Review Request 62081: AMBARI-21878. Implement STOMP endpoint to handle alerts from agent

2017-09-05 Thread Andrew Onischuk
Line 149 (original), 149 (patched) <https://reviews.apache.org/r/62081/#comment260693> Can we remove this line? - Andrew Onischuk On Sept. 5, 2017, 12:43 p.m., Attila Doroszlai wrote: > > --- > This is an automatically g

Review Request 62058: Deploys failing with MR service check failure due to missing mapreduce.tar.gz

2017-09-04 Thread Andrew Onischuk
.py 795160c Diff: https://reviews.apache.org/r/62058/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 62026: ambari-server upgrade process still puts the new views jar to default location even if views.dir is customized in ambari.properties

2017-09-01 Thread Andrew Onischuk
ain/python/ambari_server/serverConfiguration.py f6f3f43 ambari-server/src/main/python/ambari_server/serverUpgrade.py 07f5097 Diff: https://reviews.apache.org/r/62026/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 62012: Agent sometimes hangs during connection to server

2017-08-31 Thread Andrew Onischuk
, line 279, in do_handshake self._sslobj.do_handshake() Diffs - ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py b6e1aaf ambari-common/src/main/python/ambari_ws4py/client/__init__.py 89598ab Diff: https://reviews.apache.org/r/62012/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 61945: Sqoop: hive import fails with exception 'java.io.IOException:java.lang.RuntimeException: native-lzo library not available' for LZO compression codec

2017-08-28 Thread Andrew Onischuk
ds Diffs - ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml d85c7ee Diff: https://reviews.apache.org/r/61945/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 61941: Fix config paths in libraries folder

2017-08-28 Thread Andrew Onischuk
/resource_management/libraries/providers/msi.py 7f4deeb Diff: https://reviews.apache.org/r/61941/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk

  1   2   3   4   5   6   7   >