Re: Review Request 46568: AMBARI-13349 Create a keytab for Ranger Service for performing Name Lookup to Components

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46568/#review130168 --- Ship it! Ship It! - Jayush Luniya On April 22, 2016, 1:36

Re: Review Request 46565: AMBARI-16035 Add support for Rolling and Express Upgrade for Ranger Tagsync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46565/#review130167 --- Ship it! Ship It! - Jayush Luniya On April 22, 2016, 10:51

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

> On April 20, 2016, 8:03 a.m., Jayush Luniya wrote: > > Ship It! > > Masahiro Tanaka wrote: > Thank you, could you commit this? > > Jayush Luniya wrote: > Ok will commit today. Committed. Can you please close the review? - Jayush

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46583/#review130176 --- Ship it! This looks like a general utility method. Can we

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

> On April 22, 2016, 5:30 p.m., Alexandr Antonenko wrote: > > if we will ask BE and create task for them, this will mean move this out of > > 2.4. As BE is pretty heavy loaded with tasks > > Zhe (Joe) Wang wrote: > Agree. That's why I use FE to set the initial value. > > Alexandr

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

> On April 22, 2016, 5:30 p.m., Alexandr Antonenko wrote: > > if we will ask BE and create task for them, this will mean move this out of > > 2.4. As BE is pretty heavy loaded with tasks > > Zhe (Joe) Wang wrote: > Agree. That's why I use FE to set the initial value. > > Alexandr

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 6:15 p.m., Jayush Luniya wrote: > > > > Alexander Denissov wrote: > So, what will be the rules for SA logic inheritance ? > > When MYSERVICE/2.0.0 ships and needs to reuse the stack_advisor logic > from MYSERVICE/1.0.0 -- will we: > - rely on stack

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

> On April 22, 2016, 4:58 p.m., Aravindan Vijayan wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java, > > line 2433 > > > > > > I meant this method. I did a bit of

Re: Review Request 46445: Refactor get_stack_to_component() method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46445/ --- (Updated April 22, 2016, 10:54 p.m.) Review request for Ambari, Alejandro

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

> On April 22, 2016, 4:58 p.m., Aravindan Vijayan wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java, > > line 2433 > > > > > > I meant this method. > > Robert

Review Request 46585: Show number of PXFs Live widget on main dashboard

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46585/ --- Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi,

Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46583/ --- Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Oliver Szabo,

Re: Review Request 46592: Add a quick link to Grafana dashboards from Hive Service page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46592/ --- (Updated April 22, 2016, 11:17 p.m.) Review request for Ambari, Di Li,

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 6:15 p.m., Jayush Luniya wrote: > > So, what will be the rules for SA logic inheritance ? When MYSERVICE/2.0.0 ships and needs to reuse the stack_advisor logic from MYSERVICE/1.0.0 -- will we: - rely on stack inheritance ? - rely on SA inheritance within MYSERVICE ? -

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 6:15 p.m., Jayush Luniya wrote: > > > > Alexander Denissov wrote: > So, what will be the rules for SA logic inheritance ? > > When MYSERVICE/2.0.0 ships and needs to reuse the stack_advisor logic > from MYSERVICE/1.0.0 -- will we: > - rely on stack

Re: Review Request 46445: Refactor get_stack_to_component() method

> On April 22, 2016, 6:27 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/script/script.py, > > line 155 > > > > > > Should add "pass" for it to be a complete

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

> On April 22, 2016, 8:58 p.m., Aravindan Vijayan wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java, > > line 2433 > > > > > > I meant this method. > > Robert

Re: Review Request 46547: Create "/hadoop/llap/local" on each host and disk in Kerberized cluster for LLAP

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46547/#review130209 --- Ship it! LGTM. - Swapan Shridhar On April 22, 2016, 10:24

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46583/#review130241 --- Ship it! Ship It! - Sumit Mohanty On April 22, 2016, 9:12

Re: Review Request 46595: MR service check failed during EU (Intermittent)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46595/#review130228 --- Ship it! Ship It! - Alejandro Fernandez On April 23, 2016,

Review Request 46600: Config calculations used by LLAP app.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46600/ --- Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Bugs:

Review Request 46595: MR service check failed during EU (Intermittent)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46595/ --- Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. Bugs:

Re: Review Request 46560: Add logging for problems in ambari-agent Controller and ActionQueue

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46560/#review130065 --- Ship it! Ship It! - Dmitro Lisnichenko On April 22, 2016,

Review Request 46565: AMBARI-16035 Add support for Rolling and Express Upgrade for Ranger Tagsync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46565/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly,

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46405/#review130071 --- Ship it! Ship It! - Alexandr Antonenko On April 21, 2016,

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45676/ --- (Updated 4月 22, 2016, 9:35 a.m.) Review request for Ambari, Andrew Onischuk,

Review Request 46562: View Configuration Simplification

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46562/ --- Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav

Re: Review Request 46484: Enhance Health Check for the Cluster before upgrading.

> On April 21, 2016, 8:57 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java, > > line 67 > > > > > > I thought we were going to filter for only a

Re: Review Request 46484: Enhance Health Check for the Cluster before upgrading.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46484/#review130081 --- One other thing is that you'll want to check against the

Re: Review Request 46568: AMBARI-13349 Create a keytab for Ranger Service for performing Name Lookup to Components

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46568/#review130091 --- Ship it!

Review Request 46571: Add ability to log .out files into the agent log

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46571/ --- Review request for Ambari and Alejandro Fernandez. Bugs: AMBARI-16042

Re: Review Request 46434: DataNode and RegionServer during upgrade are reported as "failed" incorrectly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46434/ --- (Updated ápr. 22, 2016, 12:42 du) Review request for Ambari, Alejandro

Review Request 46568: AMBARI-13349 Create a keytab for Ranger Service for performing Name Lookup to Components

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46568/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly,

Re: Review Request 46544: AMBARI-16028: Namenode marked as INITIAL standby could potentially never start if other namenode is down

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46544/#review130117 --- Ship it! Ship It! - Robert Nettleton On April 21, 2016,

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46405/#review130109 --- ambari-web/app/controllers/wizard.js (line 749)

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46405/#review130111 --- ambari-web/app/mixins/wizard/assign_master_components.js (line

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

> On April 22, 2016, 4 p.m., Andrii Tkach wrote: > > ambari-web/app/controllers/wizard.js, line 749 > > > > > > I don't think that's good approach to set maintenance_state to not > > installed hosts, it may cause

Re: Review Request 46571: Add ability to log .out files into the agent log

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46571/#review130110 --- Ship it! nice feature - Alejandro Fernandez On April 22,

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/ --- (Updated April 22, 2016, 4:39 p.m.) Review request for Ambari, Jayush Luniya,

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/#review130124 --- ambari-server/src/main/resources/stacks/service_advisor.py (line

Re: Review Request 46571: Add ability to log .out files into the agent log

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46571/ --- (Updated April 22, 2016, 2:20 p.m.) Review request for Ambari, Alejandro

Re: Review Request 46571: Add ability to log .out files into the agent log

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46571/#review130092 --- Ship it! Ship It! - Dmitro Lisnichenko On April 22, 2016,

Re: Review Request 46571: Add ability to log .out files into the agent log

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46571/#review130093 --- Ship it! Ship It! - Dmytro Sen On Апрель 22, 2016, 2:21

Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46152/ --- (Updated April 22, 2016, 3:07 p.m.) Review request for Ambari, Alejandro

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 5:33 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/stack_advisor.py, line 522 > > > > > > loadServiceAdvisor() instead? If I follow the tradition of the

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 6:15 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py, > > line 31 > > > > > > Lets say we have > >

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46405/#review130129 --- if we will ask BE and create task for them, this will mean move

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 5:18 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py, > > line 19 > > > > > > Please add Pivotal folks to the review to look at

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 5:10 p.m., Srimanth Gunturi wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java, > > line 77 > > > > > > Trying to think

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 5:15 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/service_advisor.py, line 24 > > > > > > Add documentation for all functions here. I will make sure I document all the

Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46152/ --- (Updated April 22, 2016, 6:02 p.m.) Review request for Ambari, Alejandro

Re: Review Request 46565: AMBARI-16035 Add support for Rolling and Express Upgrade for Ranger Tagsync

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46565/#review130148 --- Ship it! Ship It! - Alejandro Fernandez On April 22, 2016,

Re: Review Request 46445: Refactor get_stack_to_component() method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46445/#review130152 --- Fix it, then Ship it!

Re: Review Request 46405: AMBARI-15519 Add Service Wizard with nodes in the maintenance mode

> On April 22, 2016, 5:30 p.m., Alexandr Antonenko wrote: > > if we will ask BE and create task for them, this will mean move this out of > > 2.4. As BE is pretty heavy loaded with tasks Agree. That's why I use FE to set the initial value. - Zhe (Joe)

Re: Review Request 46434: DataNode and RegionServer during upgrade are reported as "failed" incorrectly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46434/#review130144 --- Fix it, then Ship it!

Re: Review Request 46484: Enhance Health Check for the Cluster before upgrading.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46484/#review130145 --- Ship it! Ship It! - Alejandro Fernandez On April 21, 2016,

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/#review130126 ---

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/#review130131 --- ambari-server/src/main/resources/stacks/stack_advisor.py (line

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/#review130141 ---

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 5:33 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/stack_advisor.py, line 522 > > > > > > loadServiceAdvisor() instead? > > Tim Thorpe wrote: > If I follow the

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 5:58 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/stack_advisor.py, line 473 > > > > > > I might be missing something, but it doesnt look like we are using > >

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 5:18 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py, > > line 19 > > > > > > Please add Pivotal folks to the review to look at

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 6:15 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py, > > line 31 > > > > > > Lets say we have > >

Re: Review Request 46475: Provide UI validation for widget_name and description fields in Create/Edit Widget pop-up.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46475/#review130159 --- ambari-web/app/messages.js (line 2842)

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 5:10 p.m., Srimanth Gunturi wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java, > > line 77 > > > > > > Trying to think

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 5:10 p.m., Srimanth Gunturi wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java, > > line 77 > > > > > > Trying to think

Re: Review Request 46562: View Configuration Simplification

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46562/ --- (Updated April 22, 2016, 7:32 p.m.) Review request for Ambari, DIPAYAN

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46583/#review130178 ---

Re: Review Request 46445: Refactor get_stack_to_component() method

> On April 22, 2016, 6:27 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/script/script.py, > > line 155 > > > > > > Should add "pass" for it to be a complete

Re: Review Request 46509: Remove performing service check during "Remove Standby Wizard"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46509/#review130162 --- Ship it! Ship It! - Alexander Denissov On April 21, 2016,

Re: Review Request 46445: Refactor get_stack_to_component() method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46445/#review130163 ---