Re: Review Request 46183: AMBARI-15876. Stack advisor work for adding and removing LLAP queue when Interactive query is turned on and off respectively.

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46183/#review128828
---




ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/configuration/capacity-scheduler.xml
 (line 21)


Anyway to avoid it? This is not a valid property for capacity-scheduler.



ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 
124)


Lets protect the whole logic based on if HIVE server exists and HSI is 
mapped to a host. Its possible to add hive-interactive-site without adding 
service/component.



ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 
140)


Similar to above - check that service exists, component exists and then 
configuration exists. Perhaps a helper method that can be used in multiple 
places.



ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 
149)


This may change based on what gets decided about RM delete. For now, you 
can keep the code as is.


- Sumit Mohanty


On April 14, 2016, 3:06 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46183/
> ---
> 
> (Updated April 14, 2016, 3:06 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15876
> https://issues.apache.org/jira/browse/AMBARI-15876
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - When Hive Server Interactive is turned ON, Ambari will create 'llap' named 
> YARN queue if only 'default' queue exists at root level and is consuming 100% 
> capacity.
> - When Hive Server Interactive is turned OFF, Ambari will delete 'llap' queue 
> only if 2 queues exist at root level namely, 'llap' and 'default'.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
>  d518c8b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  ba46f00 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/configuration/capacity-scheduler.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 7407da3 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> c21bad7 
> 
> Diff: https://reviews.apache.org/r/46183/diff/
> 
> 
> Testing
> ---
> 
> - Python UT passes.
> - Manual testing done. Various scenarios tested.
> - Test cases added to test the creation and deletion logic.
> 
> - Screenshots attached.
> 
> 
> File Attachments
> 
> 
> LLAP queue created
>   
> https://reviews.apache.org/media/uploaded/files/2016/04/14/4304fa89-fcfa-47b2-9240-d4ffa221cb76__Screen_Shot_2016-04-13_at_4.51.35_PM.png
> HSI On and llap and default queues shown in dropdown
>   
> https://reviews.apache.org/media/uploaded/files/2016/04/14/622db04f-ec39-4a63-920d-dffc3a269917__Screen_Shot_2016-04-13_at_4.51.03_PM.png
> YARn queue manager with llap and default queues 
>   
> https://reviews.apache.org/media/uploaded/files/2016/04/14/29ee3e5c-9c49-4e73-be39-46e6ec786d21__Screen_Shot_2016-04-13_at_4.48.46_PM.png
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

[Alexander Denissov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review128826
---




ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 (line 92)


I think this function should only take a name of component and use utility 
to get process name and port number based on metadata. Maybe refactor that 
function from status into utils ?


- Alexander Denissov


On April 14, 2016, 2:19 a.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46186/
> ---
> 
> (Updated April 14, 2016, 2:19 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15852
> https://issues.apache.org/jira/browse/AMBARI-15852
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ restart after port change will fail because Ambari looks for a currently 
> running process with a new port number.
> This change is to make Ambari to look for an older port value.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  413cf1a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
>  f2ec914 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
>  636dcad 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
>  67d1cb0 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
>  92ac0af 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py
>  0baa4c5 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3 
> 
> Diff: https://reviews.apache.org/r/46186/diff/
> 
> 
> Testing
> ---
> 
> Unit test has passed.
> Manual Test in progress.
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Review Request 46183: AMBARI-15876. Stack advisor work for adding and removing LLAP queue when Interactive query is turned on and off respectively.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46183/
---

Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.


Bugs: AMBARI-15876
https://issues.apache.org/jira/browse/AMBARI-15876


Repository: ambari


Description
---

- When Hive Server Interactive is turned ON, Ambari will create 'llap' named 
YARN queue if only 'default' queue exists at root level and is consuming 100% 
capacity.
- When Hive Server Interactive is turned OFF, Ambari will delete 'llap' queue 
only if 2 queues exist at root level namely, 'llap' and 'default'.


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
 d518c8b 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 ba46f00 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/configuration/capacity-scheduler.xml
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
7407da3 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py c21bad7 

Diff: https://reviews.apache.org/r/46183/diff/


Testing
---

- Python UT passes.
- Manual testing done. Various scenarios tested.
- Test cases added to test the creation and deletion logic.

- Screenshots attached.


File Attachments


LLAP queue created
  
https://reviews.apache.org/media/uploaded/files/2016/04/14/4304fa89-fcfa-47b2-9240-d4ffa221cb76__Screen_Shot_2016-04-13_at_4.51.35_PM.png
HSI On and llap and default queues shown in dropdown
  
https://reviews.apache.org/media/uploaded/files/2016/04/14/622db04f-ec39-4a63-920d-dffc3a269917__Screen_Shot_2016-04-13_at_4.51.03_PM.png
YARn queue manager with llap and default queues 
  
https://reviews.apache.org/media/uploaded/files/2016/04/14/29ee3e5c-9c49-4e73-be39-46e6ec786d21__Screen_Shot_2016-04-13_at_4.48.46_PM.png


Thanks,

Swapan Shridhar

Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review128823
---


Ship it!





ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 (line 92)


Are the expected return values just 0 and 1?

If yes, the function can have a name similar to  __is_process_running



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 (line 96)


You may use the component attribute map to get program_name or process_name.



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
 (line 25)


You may move this attribute map to hawq_constants if you think that is the 
right place.


- Matt


On April 13, 2016, 7:19 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46186/
> ---
> 
> (Updated April 13, 2016, 7:19 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15852
> https://issues.apache.org/jira/browse/AMBARI-15852
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ restart after port change will fail because Ambari looks for a currently 
> running process with a new port number.
> This change is to make Ambari to look for an older port value.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
>  413cf1a 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
>  f2ec914 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
>  636dcad 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
>  67d1cb0 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
>  92ac0af 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py
>  0baa4c5 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3 
> 
> Diff: https://reviews.apache.org/r/46186/diff/
> 
> 
> Testing
> ---
> 
> Unit test has passed.
> Manual Test in progress.
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ service from restarting

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/
---

Review request for Ambari.


Bugs: AMBARI-15852
https://issues.apache.org/jira/browse/AMBARI-15852


Repository: ambari


Description
---

HAWQ restart after port change will fail because Ambari looks for a currently 
running process with a new port number.
This change is to make Ambari to look for an older port value.


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
 413cf1a 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
 f2ec914 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
 636dcad 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
 67d1cb0 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
 92ac0af 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py
 0baa4c5 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3 

Diff: https://reviews.apache.org/r/46186/diff/


Testing
---

Unit test has passed.
Manual Test in progress.


Thanks,

jun aoki

Re: Review Request 46169: Add dryrun method on request object

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46169/#review128807
---


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestImpl.java
 (line 76)


just dryRun will do


- Nate Cole


On April 13, 2016, 5:42 p.m., Ajit Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46169/
> ---
> 
> (Updated April 13, 2016, 5:42 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15870
> https://issues.apache.org/jira/browse/AMBARI-15870
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> To implement dry-run version of an API, request needs to be parsed manually 
> to figure out if request has dry-run directive.
> It will be good to add a method on Request object method itself which 
> centralizes parsing and logic for figuring out dry-run directive
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/VersionDefinitionResourceDefinition.java
>  12b91e3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestImpl.java
>  f27f621 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
>  f8f8290 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Request.java
>  50eed9a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java
>  93fe36f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java
>  633815e 
> 
> Diff: https://reviews.apache.org/r/46169/diff/
> 
> 
> Testing
> ---
> 
> Unit tests
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>

Re: Review Request 46181: Activate HAWQ standby wizard fails to delete previous hawq standby master

[Alexander Denissov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46181/#review128799
---


Ship it!




Ship It!

- Alexander Denissov


On April 13, 2016, 11:37 p.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46181/
> ---
> 
> (Updated April 13, 2016, 11:37 p.m.)
> 
> 
> Review request for Ambari and Alexander Denissov.
> 
> 
> Bugs: AMBARI-15849
> https://issues.apache.org/jira/browse/AMBARI-15849
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Activate HAWQ standby wizard fails to delete previous hawq standby master. 
> Currently, HAWQ standby status check is done based on the pid available in a 
> directory. This directory is same for HAWQ master and HAWQ standby, thus if 
> standby has been activated to active master, status of HAWQ Standby component 
> still relies on the file and states it as running, and when an attempt is 
> made to remove the standby component, it fails.
> 
> Fixed the hawq component status derivation logic
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
>  2432df6 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
>  28946f1 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
>  c38e0de 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
>  a1b6dd9 
> 
> Diff: https://reviews.apache.org/r/46181/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested.
> 
> Ran unit tests:
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-04-13 
> 16:36:49,436 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys 
> is either set to false or is not available in hawq-env.xml
> ok
> test_stop_default (test_hawqmaster.TestHawqMaster) ... ok
> test_configure_default (test_hawqsegment.TestHawqSegment) ... ok
> test_install_default (test_hawqsegment.TestHawqSegment) ... ok
> test_start_default (test_hawqsegment.TestHawqSegment) ... ok
> test_stop_default (test_hawqsegment.TestHawqSegment) ... ok
> test_configure_default (test_hawqstandby.TestHawqStandby) ... ok
> test_install_default (test_hawqstandby.TestHawqStandby) ... ok
> test_start_default (test_hawqstandby.TestHawqStandby) ... ok
> test_stop_default (test_hawqstandby.TestHawqStandby) ... ok
> 
> --
> Ran 34 te

Review Request 46181: Activate HAWQ standby wizard fails to delete previous hawq standby master

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46181/
---

Review request for Ambari and Alexander Denissov.


Bugs: AMBARI-15849
https://issues.apache.org/jira/browse/AMBARI-15849


Repository: ambari


Description
---

Activate HAWQ standby wizard fails to delete previous hawq standby master. 
Currently, HAWQ standby status check is done based on the pid available in a 
directory. This directory is same for HAWQ master and HAWQ standby, thus if 
standby has been activated to active master, status of HAWQ Standby component 
still relies on the file and states it as running, and when an attempt is made 
to remove the standby component, it fails.

Fixed the hawq component status derivation logic


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
 2432df6 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
 28946f1 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
 c38e0de 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
 a1b6dd9 

Diff: https://reviews.apache.org/r/46181/diff/


Testing
---

Manually Tested.

Ran unit tests:
test_hawq_master_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_segment_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_standby_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_exception_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
handlers could be found for logger "ambari_alerts"
ok
test_missing_configs 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_missing_slave_file 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_successful_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_empty_db_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status_plural 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
test_install_default (test_hawqmaster.TestHawqMaster) ... ok
test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-04-13 16:36:49,436 
- Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys is either set to 
false or is not available in hawq-env.xml
ok
test_stop_default (test_hawqmaster.TestHawqMaster) ... ok
test_configure_default (test_hawqsegment.TestHawqSegment) ... ok
test_install_default (test_hawqsegment.TestHawqSegment) ... ok
test_start_default (test_hawqsegment.TestHawqSegment) ... ok
test_stop_default (test_hawqsegment.TestHawqSegment) ... ok
test_configure_default (test_hawqstandby.TestHawqStandby) ... ok
test_install_default (test_hawqstandby.TestHawqStandby) ... ok
test_start_default (test_hawqstandby.TestHawqStandby) ... ok
test_stop_default (test_hawqstandby.TestHawqStandby) ... ok

--
Ran 34 tests in 0.357s

OK


Thanks,

Matt

Re: Review Request 46176: Update group for postgres proxy user to * from hadoop

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46176/#review128794
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 13, 2016, 10:41 p.m., Alexander Denissov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46176/
> ---
> 
> (Updated April 13, 2016, 10:41 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, Jayush Luniya, Lav Jain, Matt, Sumit Mohanty, and Srimanth 
> Gunturi.
> 
> 
> Bugs: AMBARI-15770
> https://issues.apache.org/jira/browse/AMBARI-15770
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update group for postgres proxy user to * from hadoop
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/kerberos.json 
> 088a244 
> 
> Diff: https://reviews.apache.org/r/46176/diff/
> 
> 
> Testing
> ---
> 
> Manual.
> 
> --
> Ran 260 tests in 7.220s
> OK
> --
> Total run:959
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Alexander Denissov
> 
>

Re: Review Request 46178: AMBARI-15872 : Provide ability to skip WAL file writes for AMS HBase tables

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46178/#review128792
---


Ship it!




Ship It!

- Sid Wagle


On April 13, 2016, 10:52 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46178/
> ---
> 
> (Updated April 13, 2016, 10:52 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-15872
> https://issues.apache.org/jira/browse/AMBARI-15872
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> For large clusters, this is a very useful optimization that can be employed.
> 
> Added an optional config (Not available through default from the stack)
> 
> ams-site : timeline.metrics.tables.durability
> Valid values it can take : SKIP_WAL / SYNC_WAL / ASYNC_WAL / FSYNC_WAL
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
>  813387f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  0ebc248 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java
>  89f3fbe 
> 
> Diff: https://reviews.apache.org/r/46178/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> Added unit test.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Review Request 46178: AMBARI-15872 : Provide ability to skip WAL file writes for AMS HBase tables

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46178/
---

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-15872
https://issues.apache.org/jira/browse/AMBARI-15872


Repository: ambari


Description
---

For large clusters, this is a very useful optimization that can be employed.

Added an optional config (Not available through default from the stack)

ams-site : timeline.metrics.tables.durability
Valid values it can take : SKIP_WAL / SYNC_WAL / ASYNC_WAL / FSYNC_WAL


Diffs
-

  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
 813387f 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
 0ebc248 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java
 89f3fbe 

Diff: https://reviews.apache.org/r/46178/diff/


Testing
---

Manually tested.

Added unit test.


Thanks,

Aravindan Vijayan

Re: Review Request 46176: Update group for postgres proxy user to * from hadoop

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46176/#review128782
---


Ship it!




Ship It!

- Matt


On April 13, 2016, 3:41 p.m., Alexander Denissov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46176/
> ---
> 
> (Updated April 13, 2016, 3:41 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, Jayush Luniya, Lav Jain, Matt, Sumit Mohanty, and Srimanth 
> Gunturi.
> 
> 
> Bugs: AMBARI-15770
> https://issues.apache.org/jira/browse/AMBARI-15770
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update group for postgres proxy user to * from hadoop
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/kerberos.json 
> 088a244 
> 
> Diff: https://reviews.apache.org/r/46176/diff/
> 
> 
> Testing
> ---
> 
> Manual.
> 
> --
> Ran 260 tests in 7.220s
> OK
> --
> Total run:959
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Alexander Denissov
> 
>

Re: Review Request 46176: Update group for postgres proxy user to * from hadoop

[Goutam Tadi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46176/#review128778
---


Ship it!




Ship It!

- Goutam Tadi


On April 13, 2016, 10:41 p.m., Alexander Denissov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46176/
> ---
> 
> (Updated April 13, 2016, 10:41 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, Jayush Luniya, Lav Jain, Matt, Sumit Mohanty, and Srimanth 
> Gunturi.
> 
> 
> Bugs: AMBARI-15770
> https://issues.apache.org/jira/browse/AMBARI-15770
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update group for postgres proxy user to * from hadoop
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/kerberos.json 
> 088a244 
> 
> Diff: https://reviews.apache.org/r/46176/diff/
> 
> 
> Testing
> ---
> 
> Manual.
> 
> --
> Ran 260 tests in 7.220s
> OK
> --
> Total run:959
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Alexander Denissov
> 
>

Review Request 46176: Update group for postgres proxy user to * from hadoop

[Alexander Denissov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46176/
---

Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam 
Tadi, jun aoki, Jayush Luniya, Lav Jain, Matt, Sumit Mohanty, and Srimanth 
Gunturi.


Bugs: AMBARI-15770
https://issues.apache.org/jira/browse/AMBARI-15770


Repository: ambari


Description
---

Update group for postgres proxy user to * from hadoop


Diffs
-

  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/kerberos.json 
088a244 

Diff: https://reviews.apache.org/r/46176/diff/


Testing
---

Manual.

--
Ran 260 tests in 7.220s
OK
--
Total run:959
Total errors:0
Total failures:0


Thanks,

Alexander Denissov

Re: Review Request 46170: HAWQ Segment Registration Status Alert shows false alert

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46170/#review128771
---


Ship it!




Ship It!

- Matt


On April 13, 2016, 2:55 p.m., Lav Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46170/
> ---
> 
> (Updated April 13, 2016, 2:55 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, Matt, Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-15794
> https://issues.apache.org/jira/browse/AMBARI-15794
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Steps to reproduce:
> 
> Install HAWQ with HAWQSEGMENT on the same host as HAWQMASTER
> Segment registration would show an alert saying that localhost is not 
> registered.
> 
> localhost is returned by gp_segment_configuration for that HAWQSEGMENT, but 
> in the slaves file, there is no entry 'localhost'
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_segment_registration_status.py
>  4d09763 
> 
> Diff: https://reviews.apache.org/r/46170/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Lav Jain
> 
>

Re: Review Request 46170: HAWQ Segment Registration Status Alert shows false alert

[Goutam Tadi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46170/#review128763
---


Ship it!




Ship It!

- Goutam Tadi


On April 13, 2016, 9:55 p.m., Lav Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46170/
> ---
> 
> (Updated April 13, 2016, 9:55 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, Matt, Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-15794
> https://issues.apache.org/jira/browse/AMBARI-15794
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Steps to reproduce:
> 
> Install HAWQ with HAWQSEGMENT on the same host as HAWQMASTER
> Segment registration would show an alert saying that localhost is not 
> registered.
> 
> localhost is returned by gp_segment_configuration for that HAWQSEGMENT, but 
> in the slaves file, there is no entry 'localhost'
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_segment_registration_status.py
>  4d09763 
> 
> Diff: https://reviews.apache.org/r/46170/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Lav Jain
> 
>

Review Request 46170: HAWQ Segment Registration Status Alert shows false alert

[Lav Jain]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46170/
---

Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam Tadi, 
jun aoki, Matt, Newton Alex, Oleksandr Diachenko, and Srimanth Gunturi.


Bugs: AMBARI-15794
https://issues.apache.org/jira/browse/AMBARI-15794


Repository: ambari


Description
---

Steps to reproduce:

Install HAWQ with HAWQSEGMENT on the same host as HAWQMASTER
Segment registration would show an alert saying that localhost is not 
registered.

localhost is returned by gp_segment_configuration for that HAWQSEGMENT, but in 
the slaves file, there is no entry 'localhost'


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_segment_registration_status.py
 4d09763 

Diff: https://reviews.apache.org/r/46170/diff/


Testing
---

Manually tested.


Thanks,

Lav Jain

Re: Review Request 46127: Add support for Rolling and Express Upgrade for Hive Server Interactive and LLAP

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46127/
---

(Updated April 13, 2016, 9:45 p.m.)


Review request for Ambari, Dmytro Grinenko, Jonathan Hurley, Jayush Luniya, 
Nate Cole, and Swapan Shridhar.


Changes
---

Minor text changes.


Summary (updated)
-

Add support for Rolling and Express Upgrade for Hive Server Interactive and LLAP


Bugs: AMBARI-15850
https://issues.apache.org/jira/browse/AMBARI-15850


Repository: ambari


Description
---

Hive Server Interactive is a new component and needs to be included in the 
Rolling and Express Upgrades for HDP 2.5 to 2.5.*

It also has instructions to restart LLAP app on Slider.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
 2ba12b6 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
 188f199 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 d909f6d 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 f878141 
  
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/pre_upgrade.py
 9d5868b 
  ambari-server/src/main/resources/scripts/Ambaripreupload.py aff33d1 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
6be568b 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/tarball_map.json 
b70af13 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
 c05e33f 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
2acffda 

Diff: https://reviews.apache.org/r/46127/diff/


Testing
---

Verifying on RU and EU from HDP 2.5.0.0-x to HDP 2.5.0.0-y right now.

Python unit tests passed,
--
Total run:952
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez

Review Request 46169: Add dryrun method on request object

[Ajit Kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46169/
---

Review request for Ambari, Jayush Luniya, Nate Cole, and Sumit Mohanty.


Bugs: AMBARI-15870
https://issues.apache.org/jira/browse/AMBARI-15870


Repository: ambari


Description
---

To implement dry-run version of an API, request needs to be parsed manually to 
figure out if request has dry-run directive.
It will be good to add a method on Request object method itself which 
centralizes parsing and logic for figuring out dry-run directive


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/VersionDefinitionResourceDefinition.java
 12b91e3 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestImpl.java
 f27f621 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
 f8f8290 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Request.java
 50eed9a 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java
 93fe36f 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java
 633815e 

Diff: https://reviews.apache.org/r/46169/diff/


Testing
---

Unit tests


Thanks,

Ajit Kumar

Re: Review Request 46159: VDF with newlines preventing valid repo files

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46159/
---

(Updated April 13, 2016, 3:45 p.m.)


Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-15867
https://issues.apache.org/jira/browse/AMBARI-15867


Repository: ambari


Description
---

When using a non-formatted VDF file with newlines in XML values, the newlines 
are being preserved.  This prevents repo files from being generated correctly.

(Also noticed a test failure that was easy to fix and a visual issue whereby 
non-manifest services like kerberos and AMS versions should be pulled from the 
stack)


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/repository/Release.java
 f855b05 
  
ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
 4488f58 
  
ambari-server/src/main/java/org/apache/ambari/server/state/repository/package-info.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/TrimmingAdapter.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/package-info.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 186ebe7 
  
ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java
 d262df3 

Diff: https://reviews.apache.org/r/46159/diff/


Testing (updated)
---

Manual.  Automated:

Tests run: 4209, Failures: 0, Errors: 0, Skipped: 32

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 37:59.760s
[INFO] Finished at: Wed Apr 13 15:27:04 EDT 2016
[INFO] Final Memory: 39M/749M
[INFO] 


Thanks,

Nate Cole

Re: Review Request 46159: VDF with newlines preventing valid repo files

[Nate Cole]

> On April 13, 2016, 3:14 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java,
> >  line 161
> > 
> >
> > Is the version required in the XSD? Want to make sure this can't NPE out

Interesting - that's off the stack that doesn't use XSD, which means it could 
be null.  I'll add the check.


> On April 13, 2016, 3:14 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/repository/package-info.java,
> >  lines 18-19
> > 
> >
> > I'm LMAO at this. Can't believe the annotation doesn't support classes.

I was pulling my hair out.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46159/#review128734
---


On April 13, 2016, 2:53 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46159/
> ---
> 
> (Updated April 13, 2016, 2:53 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-15867
> https://issues.apache.org/jira/browse/AMBARI-15867
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When using a non-formatted VDF file with newlines in XML values, the newlines 
> are being preserved.  This prevents repo files from being generated correctly.
> 
> (Also noticed a test failure that was easy to fix and a visual issue whereby 
> non-manifest services like kerberos and AMS versions should be pulled from 
> the stack)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/Release.java
>  f855b05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
>  4488f58 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/package-info.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/TrimmingAdapter.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/package-info.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  186ebe7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java
>  d262df3 
> 
> Diff: https://reviews.apache.org/r/46159/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 46159: VDF with newlines preventing valid repo files

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46159/#review128736
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 13, 2016, 6:53 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46159/
> ---
> 
> (Updated April 13, 2016, 6:53 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-15867
> https://issues.apache.org/jira/browse/AMBARI-15867
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When using a non-formatted VDF file with newlines in XML values, the newlines 
> are being preserved.  This prevents repo files from being generated correctly.
> 
> (Also noticed a test failure that was easy to fix and a visual issue whereby 
> non-manifest services like kerberos and AMS versions should be pulled from 
> the stack)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/Release.java
>  f855b05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
>  4488f58 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/package-info.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/TrimmingAdapter.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/package-info.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  186ebe7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java
>  d262df3 
> 
> Diff: https://reviews.apache.org/r/46159/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 46159: VDF with newlines preventing valid repo files

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46159/#review128734
---


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
 (line 161)


Is the version required in the XSD? Want to make sure this can't NPE out



ambari-server/src/main/java/org/apache/ambari/server/state/repository/package-info.java
 (lines 18 - 19)


I'm LMAO at this. Can't believe the annotation doesn't support classes.


- Jonathan Hurley


On April 13, 2016, 2:53 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46159/
> ---
> 
> (Updated April 13, 2016, 2:53 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-15867
> https://issues.apache.org/jira/browse/AMBARI-15867
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When using a non-formatted VDF file with newlines in XML values, the newlines 
> are being preserved.  This prevents repo files from being generated correctly.
> 
> (Also noticed a test failure that was easy to fix and a visual issue whereby 
> non-manifest services like kerberos and AMS versions should be pulled from 
> the stack)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/Release.java
>  f855b05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
>  4488f58 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/package-info.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/TrimmingAdapter.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/package-info.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
>  186ebe7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java
>  d262df3 
> 
> Diff: https://reviews.apache.org/r/46159/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 46127: [PREVIEW] Add support for Rolling and Express Upgrade for Hive Server Interactive and LLAP

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46127/#review128733
---


Ship it!




Ship It!

- Jayush Luniya


On April 13, 2016, 1:03 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46127/
> ---
> 
> (Updated April 13, 2016, 1:03 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Jonathan Hurley, Jayush Luniya, 
> Nate Cole, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-15850
> https://issues.apache.org/jira/browse/AMBARI-15850
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hive Server Interactive is a new component and needs to be included in the 
> Rolling and Express Upgrades for HDP 2.5 to 2.5.*
> 
> It also has instructions to restart LLAP app on Slider.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
>  2ba12b6 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  188f199 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  d909f6d 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  f878141 
>   
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/pre_upgrade.py
>  9d5868b 
>   ambari-server/src/main/resources/scripts/Ambaripreupload.py aff33d1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  6be568b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/tarball_map.json 
> b70af13 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  c05e33f 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 5503c1a 
> 
> Diff: https://reviews.apache.org/r/46127/diff/
> 
> 
> Testing
> ---
> 
> Verifying on RU and EU from HDP 2.5.0.0-x to HDP 2.5.0.0-y right now.
> 
> Python unit tests passed,
> --
> Total run:952
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 46127: [PREVIEW] Add support for Rolling and Express Upgrade for Hive Server Interactive and LLAP

[Jayush Luniya]

> On April 13, 2016, 4:50 a.m., Jayush Luniya wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py,
> >  line 40
> > 
> >
> > @Alejandro, lets talk about this before we make this change. Declaring 
> > this in service definition will be quite involved as we copy tarballs for 
> > components of other services. For example for hive we have code that copies 
> > mapreduce and tez tarball. 
> > 
> > 
> > ambari/ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
> > #  if copy tarball to HDFS feature  supported copy mapreduce.tar.gz 
> > and tez.tar.gz to HDFS
> > if params.stack_version_formatted_major and 
> > check_stack_feature(StackFeature.COPY_TARBALL_TO_HDFS, 
> > params.stack_version_formatted_major):
> >   copy_to_hdfs("mapreduce", params.user_group, params.hdfs_user, 
> > host_sys_prepped=params.host_sys_prepped)
> >   copy_to_hdfs("tez", params.user_group, params.hdfs_user, 
> > host_sys_prepped=params.host_sys_prepped)
> >   
> > Also, I have some changes pending to handle ambari-server upgrade to 
> > add these new properties. Once that done we will not need these static 
> > defaults in python file. By removing cluster-env config property we are 
> > reverted back to how it was in the past. So if a stack provider wants to 
> > place tarballs in HDFS to say /somebasepath/mapreduce/mapreduce.tar.gz, it 
> > won't be possible.

@Alejandro and I talked about this and for now I am ok with we moving back to 
python code as there isnt anyone asking for this fexibility for tarball map. I 
will look into adding stack-level config support rather than stack-version 
level config support where such properties can be defined.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46127/#review128610
---


On April 13, 2016, 1:03 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46127/
> ---
> 
> (Updated April 13, 2016, 1:03 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Jonathan Hurley, Jayush Luniya, 
> Nate Cole, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-15850
> https://issues.apache.org/jira/browse/AMBARI-15850
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hive Server Interactive is a new component and needs to be included in the 
> Rolling and Express Upgrades for HDP 2.5 to 2.5.*
> 
> It also has instructions to restart LLAP app on Slider.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
>  2ba12b6 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  188f199 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  d909f6d 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  f878141 
>   
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/pre_upgrade.py
>  9d5868b 
>   ambari-server/src/main/resources/scripts/Ambaripreupload.py aff33d1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  6be568b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/tarball_map.json 
> b70af13 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  c05e33f 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 5503c1a 
> 
> Diff: https://reviews.apache.org/r/46127/diff/
> 
> 
> Testing
> ---
> 
> Verifying on RU and EU from HDP 2.5.0.0-x to HDP 2.5.0.0-y right now.
> 
> Python unit tests passed,
> --
> Total run:952
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Review Request 46159: VDF with newlines preventing valid repo files

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46159/
---

Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-15867
https://issues.apache.org/jira/browse/AMBARI-15867


Repository: ambari


Description
---

When using a non-formatted VDF file with newlines in XML values, the newlines 
are being preserved.  This prevents repo files from being generated correctly.

(Also noticed a test failure that was easy to fix and a visual issue whereby 
non-manifest services like kerberos and AMS versions should be pulled from the 
stack)


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/repository/Release.java
 f855b05 
  
ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
 4488f58 
  
ambari-server/src/main/java/org/apache/ambari/server/state/repository/package-info.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/TrimmingAdapter.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/package-info.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 186ebe7 
  
ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java
 d262df3 

Diff: https://reviews.apache.org/r/46159/diff/


Testing
---

Manual.  Automated pending.


Thanks,

Nate Cole

Re: Review Request 46155: Re-Upgrade from 2.2 to 2.3+ Fails Due To Circular Symlink

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46155/#review128726
---


Ship it!




Ship It!

- Nate Cole


On April 13, 2016, 1:17 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46155/
> ---
> 
> (Updated April 13, 2016, 1:17 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-15864
> https://issues.apache.org/jira/browse/AMBARI-15864
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> With Ambari 2.2.2.0-408 build, install 2.2.9.0 cluster (HA cluster)
> Perform EU to 2.4.2.0-178 till finalize step
> Downgrade back to 2.2.9
> Again run EU to 2.4.2.0
> 
> The problem is that the downgrade unlinks configurations, getting rid of 
> {{conf.backup}} and makes {{/etc//conf}} a directory again. 
> However, the only code which bootstraps {{conf.backup}} is executed on 
> installation of the stack. That action does not happen again between U->D->U.
> 
> As a way to catch this scenario, {{conf_select.select()}} tries to be smart 
> and checks for {{/etc//conf}} as a directory and if it finds that 
> it is, it will create {{conf.backup}}. 
> 
> **The bug here is that the new {{/etc/ {{/usr/hdp/current//conf}} which is a link back to 
> {{/etc//conf}}. It should be linked to 
> {{/etc//conf.backup}} instead.**
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
>  b5de69d 
>   
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 
> 9f52b57 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 
> caf1430 
>   
> ambari-server/src/test/python/stacks/2.0.6/ZOOKEEPER/test_zookeeper_server.py 
> 2bd9944 
> 
> Diff: https://reviews.apache.org/r/46155/diff/
> 
> 
> Testing
> ---
> 
> OK
> --
> Total run:959
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 46155: Re-Upgrade from 2.2 to 2.3+ Fails Due To Circular Symlink

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46155/#review128713
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 13, 2016, 5:17 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46155/
> ---
> 
> (Updated April 13, 2016, 5:17 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-15864
> https://issues.apache.org/jira/browse/AMBARI-15864
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> With Ambari 2.2.2.0-408 build, install 2.2.9.0 cluster (HA cluster)
> Perform EU to 2.4.2.0-178 till finalize step
> Downgrade back to 2.2.9
> Again run EU to 2.4.2.0
> 
> The problem is that the downgrade unlinks configurations, getting rid of 
> {{conf.backup}} and makes {{/etc//conf}} a directory again. 
> However, the only code which bootstraps {{conf.backup}} is executed on 
> installation of the stack. That action does not happen again between U->D->U.
> 
> As a way to catch this scenario, {{conf_select.select()}} tries to be smart 
> and checks for {{/etc//conf}} as a directory and if it finds that 
> it is, it will create {{conf.backup}}. 
> 
> **The bug here is that the new {{/etc/ {{/usr/hdp/current//conf}} which is a link back to 
> {{/etc//conf}}. It should be linked to 
> {{/etc//conf.backup}} instead.**
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
>  b5de69d 
>   
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 
> 9f52b57 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 
> caf1430 
>   
> ambari-server/src/test/python/stacks/2.0.6/ZOOKEEPER/test_zookeeper_server.py 
> 2bd9944 
> 
> Diff: https://reviews.apache.org/r/46155/diff/
> 
> 
> Testing
> ---
> 
> OK
> --
> Total run:959
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 46155: Re-Upgrade from 2.2 to 2.3+ Fails Due To Circular Symlink

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46155/#review128710
---




ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
 (lines 313 - 317)


This is the real meat of the change; after creating conf.backup, we need to 
link to it and not `current`

Only if the symlink is totally missing should we link it to `current`


- Jonathan Hurley


On April 13, 2016, 1:17 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46155/
> ---
> 
> (Updated April 13, 2016, 1:17 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-15864
> https://issues.apache.org/jira/browse/AMBARI-15864
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> With Ambari 2.2.2.0-408 build, install 2.2.9.0 cluster (HA cluster)
> Perform EU to 2.4.2.0-178 till finalize step
> Downgrade back to 2.2.9
> Again run EU to 2.4.2.0
> 
> The problem is that the downgrade unlinks configurations, getting rid of 
> {{conf.backup}} and makes {{/etc//conf}} a directory again. 
> However, the only code which bootstraps {{conf.backup}} is executed on 
> installation of the stack. That action does not happen again between U->D->U.
> 
> As a way to catch this scenario, {{conf_select.select()}} tries to be smart 
> and checks for {{/etc//conf}} as a directory and if it finds that 
> it is, it will create {{conf.backup}}. 
> 
> **The bug here is that the new {{/etc/ {{/usr/hdp/current//conf}} which is a link back to 
> {{/etc//conf}}. It should be linked to 
> {{/etc//conf.backup}} instead.**
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
>  b5de69d 
>   
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 
> 9f52b57 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 
> caf1430 
>   
> ambari-server/src/test/python/stacks/2.0.6/ZOOKEEPER/test_zookeeper_server.py 
> 2bd9944 
> 
> Diff: https://reviews.apache.org/r/46155/diff/
> 
> 
> Testing
> ---
> 
> OK
> --
> Total run:959
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 46155: Re-Upgrade from 2.2 to 2.3+ Fails Due To Circular Symlink

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46155/
---

Review request for Ambari, Alejandro Fernandez and Nate Cole.


Bugs: AMBARI-15864
https://issues.apache.org/jira/browse/AMBARI-15864


Repository: ambari


Description
---

STR:
With Ambari 2.2.2.0-408 build, install 2.2.9.0 cluster (HA cluster)
Perform EU to 2.4.2.0-178 till finalize step
Downgrade back to 2.2.9
Again run EU to 2.4.2.0

The problem is that the downgrade unlinks configurations, getting rid of 
{{conf.backup}} and makes {{/etc//conf}} a directory again. However, 
the only code which bootstraps {{conf.backup}} is executed on installation of 
the stack. That action does not happen again between U->D->U.

As a way to catch this scenario, {{conf_select.select()}} tries to be smart and 
checks for {{/etc//conf}} as a directory and if it finds that it is, 
it will create {{conf.backup}}. 

**The bug here is that the new {{/etc//conf}} which is a link back to 
{{/etc//conf}}. It should be linked to 
{{/etc//conf.backup}} instead.**


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
 b5de69d 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 
9f52b57 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py caf1430 
  ambari-server/src/test/python/stacks/2.0.6/ZOOKEEPER/test_zookeeper_server.py 
2bd9944 

Diff: https://reviews.apache.org/r/46155/diff/


Testing
---

OK
--
Total run:959
Total errors:0
Total failures:0
OK


Thanks,

Jonathan Hurley

Re: Review Request 46126: Activate HAWQ standby wizard fails to delete previous hawq standby master

[Alexander Denissov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46126/#review128707
---




ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
 (line 60)


should this be using hawq_constants.SEGMENT ?



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
 (line 37)


if you raise ComponentIsNotRunning exception here, there will be no need to 
use try / catch in the methods that call it. Might also rename 
get_component_status() to assert_component_running() as technically the 
function returns no value, but rather asserts if the component is running.


- Alexander Denissov


On April 13, 2016, 12:50 a.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46126/
> ---
> 
> (Updated April 13, 2016, 12:50 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, jun aoki, 
> Jayush Luniya, Matt, and Oleksandr Diachenko.
> 
> 
> Bugs: AMBARI-15849
> https://issues.apache.org/jira/browse/AMBARI-15849
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Activate HAWQ standby wizard fails to delete previous hawq standby master. 
> Currently, HAWQ standby status check is done based on the pid available in a 
> directory. This directory is same for HAWQ master and HAWQ standby, thus if 
> standby has been activated to active master, status of HAWQ Standby component 
> still relies on the file and states it as running, and when an attempt is 
> made to remove the standby component, it fails.
> Fixed the hawq component status derivation logic in this patch.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
>  98dedf1 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py
>  8a5ad16 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
>  fb677ee 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py
>  a1b6dd9 
> 
> Diff: https://reviews.apache.org/r/46126/diff/
> 
> 
> Testing
> ---
> 
> yes.
> bhuvneshchaudhary@bhuviMac:HAWQ$ python -m discover -v
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-04-12 
> 17:51:26,025 - Skipping ssh key exchange 

Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

[Don Bosco Durai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46152/#review128699
---




ambari-logsearch/ambari-logsearch-solr-client/src/main/groovy/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.groovy
 (line 73)


In LogSearch we use implicit routing, which needs to be sent as additional 
param while creating collections



ambari-logsearch/ambari-logsearch-solr-client/src/main/groovy/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.groovy
 (line 78)


We might have take a higher number or configurable param. If the node 
contains other shards, then this will fail.


- Don Bosco Durai


On April 13, 2016, 4:32 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46152/
> ---
> 
> (Updated April 13, 2016, 4:32 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert 
> Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-15865
> https://issues.apache.org/jira/browse/AMBARI-15865
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Create a small ambari solr client (and rpm/deb), for logsearch solr.
> The goal is the create a client which can be used for another services to 
> access zookeeper/solr and create their own collections in logsearch solr. 
> (e.g. for ATLAS or RANGER)
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-assembly/pom.xml 2db0608 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/control
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postinst
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postrm
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/preinst
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/prerm
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/build.xml PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/pom.xml PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/groovy/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.groovy
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/groovy/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.groovy
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/DoNotDeleteMe.java
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/solrCli.sh 
> PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/test/groovy/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.groovy
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/NeitherMe.java
>  PRE-CREATION 
>   ambari-logsearch/pom.xml 3d4edcd 
> 
> Diff: https://reviews.apache.org/r/46152/diff/
> 
> 
> Testing
> ---
> 
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.917 sec - 
> in org.apache.ambari.logsearch.solr.AmbariSolrCloudClientTest
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46152/
---

Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert 
Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Bugs: AMBARI-15865
https://issues.apache.org/jira/browse/AMBARI-15865


Repository: ambari


Description
---

Create a small ambari solr client (and rpm/deb), for logsearch solr.
The goal is the create a client which can be used for another services to 
access zookeeper/solr and create their own collections in logsearch solr. (e.g. 
for ATLAS or RANGER)


Diffs
-

  ambari-logsearch/ambari-logsearch-assembly/pom.xml 2db0608 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/control
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postinst
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postrm
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/preinst
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/prerm
 PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/build.xml PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/pom.xml PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/groovy/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.groovy
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/groovy/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.groovy
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/DoNotDeleteMe.java
 PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/solrCli.sh 
PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/test/groovy/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.groovy
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/NeitherMe.java
 PRE-CREATION 
  ambari-logsearch/pom.xml 3d4edcd 

Diff: https://reviews.apache.org/r/46152/diff/


Testing
---

Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.917 sec - in 
org.apache.ambari.logsearch.solr.AmbariSolrCloudClientTest


Thanks,

Oliver Szabo

Re: Review Request 46147: Fix for NullPointerException in LoggingSearchPropertyProvider

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46147/
---

(Updated April 13, 2016, 3:51 p.m.)


Review request for Ambari, Jonathan Hurley, Oliver Szabo, and Sumit Mohanty.


Bugs: AMBARI-15861
https://issues.apache.org/jira/browse/AMBARI-15861


Repository: ambari


Description
---

This patch resolves AMBARI-15861. 

Last night's checkin of the initial LogSearch integration code in Ambari caused 
a NullPointerException to occur in cluster deployments when LogSearch is not 
available.  Currently, that would account for most deployment attempts on 
trunk, so this issue will block successful cluster deployments on trunk until 
it is resolved.  

This patch implements the following

1. Adds a check for a null LoggingRequestHelper in the 
LoggingSearchPropertyProvider implementation. 
2. Implements a new unit test to verify this fix.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
 6b4a8a4 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProviderTest.java
 19c0756 

Diff: https://reviews.apache.org/r/46147/diff/


Testing (updated)
---

1. I manually verified that applying this fix to a trunk build will allow a 
successful cluster deployment to occur, with no NullPointerExceptions 
occurring, and I verified that the services started seem to be 
installed/started as expected. 
2. Currently running ambari-server's "mvn clean test" suite, and will update 
with results once that is completed.

Test Results:

The "mvn clean test" suite in ambari-server did have some failures:

"Failed tests:
  UpgradeCatalog240Test.testExecuteDDLUpdates:227
  Unexpected method call DBAccessor.addColumn("viewinstanceentity", 
org.apache.ambari.server.orm.DBAccessor$DBColumnInfo@4574042f):
DBAccessor.addColumn("host_role_command", 
capture(org.apache.ambari.server.orm.DBAccessor$DBColumnInfo@3473076d)): 
expected: 1, actual: 1
  ViewDirectoryWatcherTest.testDirectoryExtractionOnFileAdd:111
  Expectation failure on verify:

ViewRegistry.readViewArchive(/var/folders/7l/3g9wc3qn4t36xr465lhmrk0cgp/T/test_dir/file.jar):
 expected: 1, actual: 0
Tests in error:
  AmbariManagementControllerTest.testUpdateRepoUrlController:8524 » 
IllegalArgument

Tests run: 4217, Failures: 2, Errors: 1, Skipped: 32"

These tests are also failing in trunk without my patch applied, so I went 
forward with a merge, since these failures were already present in trunk.


Thanks,

Robert Nettleton

Re: Review Request 46147: Fix for NullPointerException in LoggingSearchPropertyProvider

[Robert Nettleton]

> On April 13, 2016, 2:53 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java,
> >  line 128
> > 
> >
> > Does this cause an empty sub resource rendering in the JSON?

It should not.  In my initial testing, I haven't seen any cases where an empty 
property set was attached to the resource.

In the case of LogSearch not being available, there's no logging metadata to 
attach to the resource, so returning the passed-in resources seemed appropriate.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46147/#review128684
---


On April 13, 2016, 2:28 p.m., Robert Nettleton wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46147/
> ---
> 
> (Updated April 13, 2016, 2:28 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Oliver Szabo, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15861
> https://issues.apache.org/jira/browse/AMBARI-15861
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This patch resolves AMBARI-15861. 
> 
> Last night's checkin of the initial LogSearch integration code in Ambari 
> caused a NullPointerException to occur in cluster deployments when LogSearch 
> is not available.  Currently, that would account for most deployment attempts 
> on trunk, so this issue will block successful cluster deployments on trunk 
> until it is resolved.  
> 
> This patch implements the following
> 
> 1. Adds a check for a null LoggingRequestHelper in the 
> LoggingSearchPropertyProvider implementation. 
> 2. Implements a new unit test to verify this fix.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
>  6b4a8a4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProviderTest.java
>  19c0756 
> 
> Diff: https://reviews.apache.org/r/46147/diff/
> 
> 
> Testing
> ---
> 
> 1. I manually verified that applying this fix to a trunk build will allow a 
> successful cluster deployment to occur, with no NullPointerExceptions 
> occurring, and I verified that the services started seem to be 
> installed/started as expected. 
> 2. Currently running ambari-server's "mvn clean test" suite, and will update 
> with results once that is completed.
> 
> 
> Thanks,
> 
> Robert Nettleton
> 
>

Re: Review Request 46148: NPE when deleting a host

[Daniel Gergely]

> On ápr. 13, 2016, 3:05 du, Oliver Szabo wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java,
> >  line 914
> > 
> >
> > Can you provide a test for that case when the hostname is null? (to 
> > avoid that someone change the code here again)

Yes, will do, but ClustersImpl has no test at all right now, so it will take a 
while to build up a testcase for that.


- Daniel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46148/#review128689
---


On ápr. 13, 2016, 3:04 du, Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46148/
> ---
> 
> (Updated ápr. 13, 2016, 3:04 du)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-15862
> https://issues.apache.org/jira/browse/AMBARI-15862
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When deleting a host, NPE may occur.
> TopologyHostRequests are created with hostName=null at the first time, and 
> when hosts are registered, then these null values are replaced with the 
> correct host names.
> In the case when a host is being deleted, a loop checks the host name for all 
> the requests, and if there is a request with hostName=null, a NPE is thrown.
> Swapping the sides of **equals** method can solve the problem, since the 
> variable **hostname** is checked before and not null.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
>  caab7df 
> 
> Diff: https://reviews.apache.org/r/46148/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 46148: NPE when deleting a host

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46148/#review128689
---




ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
 (line 914)


Can you provide a test for that case when the hostname is null? (to avoid 
that someone change the code here again)


- Oliver Szabo


On April 13, 2016, 3:04 p.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46148/
> ---
> 
> (Updated April 13, 2016, 3:04 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-15862
> https://issues.apache.org/jira/browse/AMBARI-15862
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When deleting a host, NPE may occur.
> TopologyHostRequests are created with hostName=null at the first time, and 
> when hosts are registered, then these null values are replaced with the 
> correct host names.
> In the case when a host is being deleted, a loop checks the host name for all 
> the requests, and if there is a request with hostName=null, a NPE is thrown.
> Swapping the sides of **equals** method can solve the problem, since the 
> variable **hostname** is checked before and not null.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
>  caab7df 
> 
> Diff: https://reviews.apache.org/r/46148/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 46148: NPE when deleting a host

[Daniel Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46148/
---

(Updated ápr. 13, 2016, 3:04 du)


Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and 
Sebastian Toader.


Bugs: AMBARI-15862
https://issues.apache.org/jira/browse/AMBARI-15862


Repository: ambari


Description
---

When deleting a host, NPE may occur.
TopologyHostRequests are created with hostName=null at the first time, and when 
hosts are registered, then these null values are replaced with the correct host 
names.
In the case when a host is being deleted, a loop checks the host name for all 
the requests, and if there is a request with hostName=null, a NPE is thrown.
Swapping the sides of **equals** method can solve the problem, since the 
variable **hostname** is checked before and not null.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
 caab7df 

Diff: https://reviews.apache.org/r/46148/diff/


Testing
---


Thanks,

Daniel Gergely

Review Request 46148: NPE when deleting a host

[Daniel Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46148/
---

Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and 
Sebastian Toader.


Bugs: AMBARI-15862
https://issues.apache.org/jira/browse/AMBARI-15862


Repository: ambari


Description
---

When deleting a host, NPE may occur.
TopologyHostRequests are created with hostName=null at the first time, and when 
hosts are registered, then these null values are replaced with the correct host 
names.
In the case when a host is being deleted, a loop checks the host name for all 
the requests, and if there is a request with hostName=null, a NPE is thrown.
Swapping the sides of **equals** method can solve the problem, since the 
variable **hostname** is checked before and not null.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
 caab7df 

Diff: https://reviews.apache.org/r/46148/diff/


Testing
---


Thanks,

Daniel Gergely

Re: Review Request 46136: Unit Test Coverage For Alert Caching

[Jonathan Hurley]

> On April 13, 2016, 10:45 a.m., Robert Levas wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOCachedTest.java,
> >  line 47
> > 
> >
> > Why not `extend` `EasyMockSupport`?

Initially, I tried that; but replayAll wasn't working correctly.


> On April 13, 2016, 10:45 a.m., Robert Levas wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOCachedTest.java,
> >  line 182
> > 
> >
> > If extending EasyMockSupport, than this would be 
> > 
> > ```
> > replayAll();
> > ```

Some mocks are replayed before others; replayAll() seems to cause problems 
after you've already replayed some.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46136/#review128682
---


On April 12, 2016, 11:28 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46136/
> ---
> 
> (Updated April 12, 2016, 11:28 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-13569
> https://issues.apache.org/jira/browse/AMBARI-13569
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add unit tests for the caching of AlertCurrentEntity in the DAO.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOCachedTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/services/CachedAlertFlushServiceTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46136/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 46127: [PREVIEW] Add support for Rolling and Express Upgrade for Hive Server Interactive and LLAP

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46127/#review128685
---




ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml (line 
217)


Is this only for HDP 2.5?


- Jonathan Hurley


On April 12, 2016, 9:03 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46127/
> ---
> 
> (Updated April 12, 2016, 9:03 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Jonathan Hurley, Jayush Luniya, 
> Nate Cole, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-15850
> https://issues.apache.org/jira/browse/AMBARI-15850
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hive Server Interactive is a new component and needs to be included in the 
> Rolling and Express Upgrades for HDP 2.5 to 2.5.*
> 
> It also has instructions to restart LLAP app on Slider.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
>  2ba12b6 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  188f199 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  d909f6d 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  f878141 
>   
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/pre_upgrade.py
>  9d5868b 
>   ambari-server/src/main/resources/scripts/Ambaripreupload.py aff33d1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  6be568b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/tarball_map.json 
> b70af13 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  c05e33f 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 5503c1a 
> 
> Diff: https://reviews.apache.org/r/46127/diff/
> 
> 
> Testing
> ---
> 
> Verifying on RU and EU from HDP 2.5.0.0-x to HDP 2.5.0.0-y right now.
> 
> Python unit tests passed,
> --
> Total run:952
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 46127: [PREVIEW] Add support for Rolling and Express Upgrade for Hive Server Interactive and LLAP

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46127/#review128686
---


Ship it!




Ship It!

- Jonathan Hurley


On April 12, 2016, 9:03 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46127/
> ---
> 
> (Updated April 12, 2016, 9:03 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Jonathan Hurley, Jayush Luniya, 
> Nate Cole, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-15850
> https://issues.apache.org/jira/browse/AMBARI-15850
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hive Server Interactive is a new component and needs to be included in the 
> Rolling and Express Upgrades for HDP 2.5 to 2.5.*
> 
> It also has instructions to restart LLAP app on Slider.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
>  2ba12b6 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  188f199 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  d909f6d 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  f878141 
>   
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/pre_upgrade.py
>  9d5868b 
>   ambari-server/src/main/resources/scripts/Ambaripreupload.py aff33d1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  6be568b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/tarball_map.json 
> b70af13 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  c05e33f 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 5503c1a 
> 
> Diff: https://reviews.apache.org/r/46127/diff/
> 
> 
> Testing
> ---
> 
> Verifying on RU and EU from HDP 2.5.0.0-x to HDP 2.5.0.0-y right now.
> 
> Python unit tests passed,
> --
> Total run:952
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 46147: Fix for NullPointerException in LoggingSearchPropertyProvider

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46147/#review128684
---


Ship it!




Minor question on returned resources when no service is avail.


ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
 (line 128)


Does this cause an empty sub resource rendering in the JSON?


- Jonathan Hurley


On April 13, 2016, 10:28 a.m., Robert Nettleton wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46147/
> ---
> 
> (Updated April 13, 2016, 10:28 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Oliver Szabo, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15861
> https://issues.apache.org/jira/browse/AMBARI-15861
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This patch resolves AMBARI-15861. 
> 
> Last night's checkin of the initial LogSearch integration code in Ambari 
> caused a NullPointerException to occur in cluster deployments when LogSearch 
> is not available.  Currently, that would account for most deployment attempts 
> on trunk, so this issue will block successful cluster deployments on trunk 
> until it is resolved.  
> 
> This patch implements the following
> 
> 1. Adds a check for a null LoggingRequestHelper in the 
> LoggingSearchPropertyProvider implementation. 
> 2. Implements a new unit test to verify this fix.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
>  6b4a8a4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProviderTest.java
>  19c0756 
> 
> Diff: https://reviews.apache.org/r/46147/diff/
> 
> 
> Testing
> ---
> 
> 1. I manually verified that applying this fix to a trunk build will allow a 
> successful cluster deployment to occur, with no NullPointerExceptions 
> occurring, and I verified that the services started seem to be 
> installed/started as expected. 
> 2. Currently running ambari-server's "mvn clean test" suite, and will update 
> with results once that is completed.
> 
> 
> Thanks,
> 
> Robert Nettleton
> 
>

Re: Review Request 46136: Unit Test Coverage For Alert Caching

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46136/#review128682
---


Ship it!





ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOCachedTest.java
 (line 47)


Why not `extend` `EasyMockSupport`?



ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOCachedTest.java
 (line 182)


If extending EasyMockSupport, than this would be 

```
replayAll();
```


- Robert Levas


On April 12, 2016, 11:28 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46136/
> ---
> 
> (Updated April 12, 2016, 11:28 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-13569
> https://issues.apache.org/jira/browse/AMBARI-13569
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add unit tests for the caching of AlertCurrentEntity in the DAO.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOCachedTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/services/CachedAlertFlushServiceTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46136/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 46127: [PREVIEW] Add support for Rolling and Express Upgrade for Hive Server Interactive and LLAP

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46127/#review128679
---


Ship it!




I'll let you and Jayush work out the details of his issue, but I'm ok with the 
changes otherwise.

- Nate Cole


On April 12, 2016, 9:03 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46127/
> ---
> 
> (Updated April 12, 2016, 9:03 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Jonathan Hurley, Jayush Luniya, 
> Nate Cole, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-15850
> https://issues.apache.org/jira/browse/AMBARI-15850
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hive Server Interactive is a new component and needs to be included in the 
> Rolling and Express Upgrades for HDP 2.5 to 2.5.*
> 
> It also has instructions to restart LLAP app on Slider.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
>  2ba12b6 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  188f199 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  d909f6d 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  f878141 
>   
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/pre_upgrade.py
>  9d5868b 
>   ambari-server/src/main/resources/scripts/Ambaripreupload.py aff33d1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  6be568b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/tarball_map.json 
> b70af13 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  c05e33f 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 5503c1a 
> 
> Diff: https://reviews.apache.org/r/46127/diff/
> 
> 
> Testing
> ---
> 
> Verifying on RU and EU from HDP 2.5.0.0-x to HDP 2.5.0.0-y right now.
> 
> Python unit tests passed,
> --
> Total run:952
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 46136: Unit Test Coverage For Alert Caching

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46136/#review128678
---


Ship it!




Ship It!

- Nate Cole


On April 12, 2016, 11:28 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46136/
> ---
> 
> (Updated April 12, 2016, 11:28 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-13569
> https://issues.apache.org/jira/browse/AMBARI-13569
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add unit tests for the caching of AlertCurrentEntity in the DAO.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOCachedTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/services/CachedAlertFlushServiceTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46136/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 46147: Fix for NullPointerException in LoggingSearchPropertyProvider

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46147/#review128676
---


Ship it!




Ship It!

- Oliver Szabo


On April 13, 2016, 2:28 p.m., Robert Nettleton wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46147/
> ---
> 
> (Updated April 13, 2016, 2:28 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Oliver Szabo, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15861
> https://issues.apache.org/jira/browse/AMBARI-15861
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This patch resolves AMBARI-15861. 
> 
> Last night's checkin of the initial LogSearch integration code in Ambari 
> caused a NullPointerException to occur in cluster deployments when LogSearch 
> is not available.  Currently, that would account for most deployment attempts 
> on trunk, so this issue will block successful cluster deployments on trunk 
> until it is resolved.  
> 
> This patch implements the following
> 
> 1. Adds a check for a null LoggingRequestHelper in the 
> LoggingSearchPropertyProvider implementation. 
> 2. Implements a new unit test to verify this fix.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
>  6b4a8a4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProviderTest.java
>  19c0756 
> 
> Diff: https://reviews.apache.org/r/46147/diff/
> 
> 
> Testing
> ---
> 
> 1. I manually verified that applying this fix to a trunk build will allow a 
> successful cluster deployment to occur, with no NullPointerExceptions 
> occurring, and I verified that the services started seem to be 
> installed/started as expected. 
> 2. Currently running ambari-server's "mvn clean test" suite, and will update 
> with results once that is completed.
> 
> 
> Thanks,
> 
> Robert Nettleton
> 
>

Re: Review Request 46147: Fix for NullPointerException in LoggingSearchPropertyProvider

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46147/#review128675
---


Ship it!




Ship It!

- Sumit Mohanty


On April 13, 2016, 2:28 p.m., Robert Nettleton wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46147/
> ---
> 
> (Updated April 13, 2016, 2:28 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Oliver Szabo, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15861
> https://issues.apache.org/jira/browse/AMBARI-15861
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This patch resolves AMBARI-15861. 
> 
> Last night's checkin of the initial LogSearch integration code in Ambari 
> caused a NullPointerException to occur in cluster deployments when LogSearch 
> is not available.  Currently, that would account for most deployment attempts 
> on trunk, so this issue will block successful cluster deployments on trunk 
> until it is resolved.  
> 
> This patch implements the following
> 
> 1. Adds a check for a null LoggingRequestHelper in the 
> LoggingSearchPropertyProvider implementation. 
> 2. Implements a new unit test to verify this fix.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
>  6b4a8a4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProviderTest.java
>  19c0756 
> 
> Diff: https://reviews.apache.org/r/46147/diff/
> 
> 
> Testing
> ---
> 
> 1. I manually verified that applying this fix to a trunk build will allow a 
> successful cluster deployment to occur, with no NullPointerExceptions 
> occurring, and I verified that the services started seem to be 
> installed/started as expected. 
> 2. Currently running ambari-server's "mvn clean test" suite, and will update 
> with results once that is completed.
> 
> 
> Thanks,
> 
> Robert Nettleton
> 
>

Review Request 46147: Fix for NullPointerException in LoggingSearchPropertyProvider

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46147/
---

Review request for Ambari, Jonathan Hurley, Oliver Szabo, and Sumit Mohanty.


Bugs: AMBARI-15861
https://issues.apache.org/jira/browse/AMBARI-15861


Repository: ambari


Description
---

This patch resolves AMBARI-15861. 

Last night's checkin of the initial LogSearch integration code in Ambari caused 
a NullPointerException to occur in cluster deployments when LogSearch is not 
available.  Currently, that would account for most deployment attempts on 
trunk, so this issue will block successful cluster deployments on trunk until 
it is resolved.  

This patch implements the following

1. Adds a check for a null LoggingRequestHelper in the 
LoggingSearchPropertyProvider implementation. 
2. Implements a new unit test to verify this fix.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
 6b4a8a4 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProviderTest.java
 19c0756 

Diff: https://reviews.apache.org/r/46147/diff/


Testing
---

1. I manually verified that applying this fix to a trunk build will allow a 
successful cluster deployment to occur, with no NullPointerExceptions 
occurring, and I verified that the services started seem to be 
installed/started as expected. 
2. Currently running ambari-server's "mvn clean test" suite, and will update 
with results once that is completed.


Thanks,

Robert Nettleton

Re: Review Request 46144: AMBARI-15844: Add conf property UI to show warning of potential duplications among all confType for the service

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46144/#review128669
---


Ship it!




Ship It!

- Alexandr Antonenko


On April 13, 2016, 1:54 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46144/
> ---
> 
> (Updated April 13, 2016, 1:54 p.m.)
> 
> 
> Review request for Ambari and Alexandr Antonenko.
> 
> 
> Bugs: AMBARI-15844
> https://issues.apache.org/jira/browse/AMBARI-15844
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Same named properties are currently disallowed for the same configType for a 
> given service, this jira proposes to display a warning to remind user the 
> existence of same-named properties for the service among all configTypes.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/messages.js 2e4f648 
>   ambari-web/app/templates/common/configs/addPropertyWindow.hbs 61572fd 
>   ambari-web/app/views/common/configs/service_configs_by_category_view.js 
> b5d5b45 
> 
> Diff: https://reviews.apache.org/r/46144/diff/
> 
> 
> Testing
> ---
> 
> patch a truck cluster with UI changes, 
> 
> 1. add "zookeeper.znode.parent" to hbase-site, notice the UI shows the error 
> message about the property is a dup.
> This is to test the current error check still works.
> 
> 2. add "zookeeper.znode.parent" to hbase-policy.xml, notice the UI shows a 
> warning this time, about a same-named property is defined in hbase-site.xml. 
> This is to test the new behavior introduced via this JIRA.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Review Request 46144: AMBARI-15844: Add conf property UI to show warning of potential duplications among all confType for the service

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46144/
---

Review request for Ambari and Alexandr Antonenko.


Bugs: AMBARI-15844
https://issues.apache.org/jira/browse/AMBARI-15844


Repository: ambari


Description
---

Same named properties are currently disallowed for the same configType for a 
given service, this jira proposes to display a warning to remind user the 
existence of same-named properties for the service among all configTypes.


Diffs
-

  ambari-web/app/messages.js 2e4f648 
  ambari-web/app/templates/common/configs/addPropertyWindow.hbs 61572fd 
  ambari-web/app/views/common/configs/service_configs_by_category_view.js 
b5d5b45 

Diff: https://reviews.apache.org/r/46144/diff/


Testing
---

patch a truck cluster with UI changes, 

1. add "zookeeper.znode.parent" to hbase-site, notice the UI shows the error 
message about the property is a dup.
This is to test the current error check still works.

2. add "zookeeper.znode.parent" to hbase-policy.xml, notice the UI shows a 
warning this time, about a same-named property is defined in hbase-site.xml. 
This is to test the new behavior introduced via this JIRA.


Thanks,

Di Li

Re: Review Request 46143: Themes: Config placement is not respected in theme inheritance scenario

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46143/#review128663
---


Ship it!




Ship It!

- Andrew Onischuk


On April 13, 2016, 1:40 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46143/
> ---
> 
> (Updated April 13, 2016, 1:40 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro 
> Sen.
> 
> 
> Bugs: AMBARI-15860
> https://issues.apache.org/jira/browse/AMBARI-15860
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> Install ambari trunk bits
> Replace theme_version_2.json in HDP-2.5 HIVE service package with 
> theme_version_2.json
> Deploy a cluster with Hive service HDP-2.5 stack with ambari trunk bits
> Expected behavior: Interactive Query subsection in Hive service page has the 
> configs placed as defined in extended theme of HIVE service in HDP-2.5 stack
> Actual behavior: API and UI has configs in different order then what is 
> defined in the theme.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/Placement.java
>  e3708d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/ThemeConfiguration.java
>  a0d8907 
> 
> Diff: https://reviews.apache.org/r/46143/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 46143: Themes: Config placement is not respected in theme inheritance scenario

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46143/#review128664
---


Ship it!




Ship It!

- Dmytro Sen


On Апрель 13, 2016, 1:40 п.п., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46143/
> ---
> 
> (Updated Апрель 13, 2016, 1:40 п.п.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro 
> Sen.
> 
> 
> Bugs: AMBARI-15860
> https://issues.apache.org/jira/browse/AMBARI-15860
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> Install ambari trunk bits
> Replace theme_version_2.json in HDP-2.5 HIVE service package with 
> theme_version_2.json
> Deploy a cluster with Hive service HDP-2.5 stack with ambari trunk bits
> Expected behavior: Interactive Query subsection in Hive service page has the 
> configs placed as defined in extended theme of HIVE service in HDP-2.5 stack
> Actual behavior: API and UI has configs in different order then what is 
> defined in the theme.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/Placement.java
>  e3708d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/ThemeConfiguration.java
>  a0d8907 
> 
> Diff: https://reviews.apache.org/r/46143/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 46143: Themes: Config placement is not respected in theme inheritance scenario

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46143/
---

Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro Sen.


Bugs: AMBARI-15860
https://issues.apache.org/jira/browse/AMBARI-15860


Repository: ambari


Description
---

STR:
Install ambari trunk bits
Replace theme_version_2.json in HDP-2.5 HIVE service package with 
theme_version_2.json
Deploy a cluster with Hive service HDP-2.5 stack with ambari trunk bits
Expected behavior: Interactive Query subsection in Hive service page has the 
configs placed as defined in extended theme of HIVE service in HDP-2.5 stack
Actual behavior: API and UI has configs in different order then what is defined 
in the theme.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/theme/Placement.java 
e3708d8 
  
ambari-server/src/main/java/org/apache/ambari/server/state/theme/ThemeConfiguration.java
 a0d8907 

Diff: https://reviews.apache.org/r/46143/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 46017: AMBARI-15760 Add show_logs routines to Ranger Tagsync start/stop

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46017/#review128661
---


Ship it!




please make sure UT pass.

- Andrew Onischuk


On April 12, 2016, 5:01 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46017/
> ---
> 
> (Updated April 12, 2016, 5:01 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Gautam Borad.
> 
> 
> Bugs: AMBARI-15760
> https://issues.apache.org/jira/browse/AMBARI-15760
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add show_logs routines to the Ranger Tagsync start/stop functions for better 
> debugging.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py
>  9f4757b 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  9544ee8 
> 
> Diff: https://reviews.apache.org/r/46017/diff/
> 
> 
> Testing
> ---
> 
> Ran 253 tests in 7.377s
> 
> OK
> --
> Total run:944
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 45978: AMBARI-15806: Stack definition for Logsearch

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45978/#review128659
---


Ship it!




Ship It!

- Sebastian Toader


On April 13, 2016, 1:57 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45978/
> ---
> 
> (Updated April 13, 2016, 1:57 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin 
> Jetly, Jayush Luniya, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and 
> Yusaku Sako.
> 
> 
> Bugs: AMBARI-15806
> https://issues.apache.org/jira/browse/AMBARI-15806
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Logsearch support was splitted into 3 different commits: 
> https://github.com/apache/ambari/tree/branch-dev-logsearch
> - integrate logsearch module
> - ambari server REST implementation for logsearch
> - stack definition
> 
> This one is the stack definition.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
>  df46ce0 
>   ambari-server/src/main/java/org/apache/ambari/server/Role.java f72cc5b 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-audit_logs-solrconfig.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-service_logs-solrconfig.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-xml.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logfeeder.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_common.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_solr.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/solr.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/global.config.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/grok-patterns.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-accumulo.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ambari.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ams.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-atlas.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/co

Re: Review Request 45978: AMBARI-15806: Stack definition for Logsearch

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45978/
---

(Updated April 13, 2016, 11:57 a.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, 
Jayush Luniya, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and Yusaku 
Sako.


Changes
---

- more format changes
- added rco tests
- zoo.cfg generated from zookeeper service configurations


Bugs: AMBARI-15806
https://issues.apache.org/jira/browse/AMBARI-15806


Repository: ambari


Description
---

Logsearch support was splitted into 3 different commits: 
https://github.com/apache/ambari/tree/branch-dev-logsearch
- integrate logsearch module
- ambari server REST implementation for logsearch
- stack definition

This one is the stack definition.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
 df46ce0 
  ambari-server/src/main/java/org/apache/ambari/server/Role.java f72cc5b 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/alerts.json 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-site.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-audit_logs-solrconfig.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-service_logs-solrconfig.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-site.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-xml.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logfeeder.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_common.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_solr.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/solr.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/status_params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/global.config.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/grok-patterns.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-accumulo.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ambari.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ams.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-atlas.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-falcon.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hbase.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hdfs.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hive.json.j2

Re: Review Request 46141: Getting WARNING on ambari server setup + start

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46141/#review128638
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Квітень 13, 2016, 8:56 до полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46141/
> ---
> 
> (Updated Квітень 13, 2016, 8:56 до полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-15856
> https://issues.apache.org/jira/browse/AMBARI-15856
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Build #264
> 
> There is a warning being printed during setup and during start. This is using
> all default / simplest path thru.
> 
> 
> 
> 
> [root@c6401 ~]# ambari-server setup -s
> Using python  /usr/bin/python
> Setup ambari-server
> Checking SELinux...
> SELinux status is 'disabled'
> Customize user account for ambari-server daemon [y/n] (n)? 
> Adjusting ambari-server permissions and ownership...
> Checking firewall status...
> Checking JDK...
> [1] Oracle JDK 1.8 + Java Cryptography Extension (JCE) Policy Files 8
> [2] Oracle JDK 1.7 + Java Cryptography Extension (JCE) Policy Files 7
> [3] Custom JDK
> 
> ==
> Enter choice (1): 
> To download the Oracle JDK and the Java Cryptography Extension (JCE) 
> Policy Files you must accept the license terms found at 
> http://www.oracle.com/technetwork/java/javase/terms/license/index.html and 
> not accepting will cancel the Ambari Server setup and you must install the 
> JDK and JCE files manually.
> Do you accept the Oracle Binary Code License Agreement [y/n] (y)? 
> Downloading JDK from 
> http://public-repo-1.hortonworks.com/ARTIFACTS/jdk-8u60-linux-x64.tar.gz to 
> /var/lib/ambari-server/resources/jdk-8u60-linux-x64.tar.gz
> jdk-8u60-linux-x64.tar.gz... 100% (172.8 MB of 172.8 MB)
> Successfully downloaded JDK distribution to 
> /var/lib/ambari-server/resources/jdk-8u60-linux-x64.tar.gz
> Installing JDK to /usr/jdk64/
> Successfully installed JDK to /usr/jdk64/
> Downloading JCE Policy archive from 
> http://public-repo-1.hortonworks.com/ARTIFACTS/jce_policy-8.zip to 
> /var/lib/ambari-server/resources/jce_policy-8.zip
> 
> Successfully downloaded JCE Policy archive to 
> /var/lib/ambari-server/resources/jce_policy-8.zip
> Installing JCE policy...
> Completing setup...
> Configuring database...
> Enter advanced database configuration [y/n] (n)? 
> Configuring database...
> Default properties detected. Using built-in database.
> WARNING: Command chown  None /etc/ambari-server/conf/password.dat 
> returned exit code /etc/ambari-server/conf/password.dat with message: chown: 
> invalid user: `None'
> 
> Configuring ambari database...
> Checking PostgreSQL...
> Running initdb: This may take up to a minute.
> Initializing database: [  OK  ]
> 
> About to start PostgreSQL
> Configuring local database...
> Connecting to local database...done.
> Configuring PostgreSQL...
> Restarting PostgreSQL
> Extracting system views...
> ambari-admin-2.4.0.0.264.jar
> ..
> Adjusting ambari-server permissions and ownership...
> Ambari Server 'setup' completed successfully.
> [root@c6401 ~]# ambari-server start
> Using python  /usr/bin/python
> Starting ambari-server
> Ambari Server running with administrator privileges.
> Organizing resource files at /var/lib/ambari-server/resources...
> WARNING: Multiple versions of javax.servlet.jsp.jstl.jar found in java 
> class path (/usr/lib/ambari-server/javax.servlet.jsp.jstl-1.2.2.jar and 
> /usr/lib/ambari-server/javax.servlet.jsp.jstl-1.2.0.v201105211821.jar). 
>  Make sure that you include only one javax.servlet.jsp.jstl.jar in the 
> java class path 
> '/etc/ambari-server/conf:/usr/lib/ambari-server/*:/usr/share/java/postgresql-jdbc.jar'.
> Server PID at: /var/run/ambari-server/ambari-server.pid
> Server out at: /var/log/ambari-server/ambari-server.out
> Server log at: /var/log/ambari-server/ambari-server.log
> Waiting for server start.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverClassPath.py fdc1c12 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 446b083 
> 
> Diff: https://reviews.apache.org/r/46141/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 46141: Getting WARNING on ambari server setup + start

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46141/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-15856
https://issues.apache.org/jira/browse/AMBARI-15856


Repository: ambari


Description
---

Build #264

There is a warning being printed during setup and during start. This is using
all default / simplest path thru.




[root@c6401 ~]# ambari-server setup -s
Using python  /usr/bin/python
Setup ambari-server
Checking SELinux...
SELinux status is 'disabled'
Customize user account for ambari-server daemon [y/n] (n)? 
Adjusting ambari-server permissions and ownership...
Checking firewall status...
Checking JDK...
[1] Oracle JDK 1.8 + Java Cryptography Extension (JCE) Policy Files 8
[2] Oracle JDK 1.7 + Java Cryptography Extension (JCE) Policy Files 7
[3] Custom JDK

==
Enter choice (1): 
To download the Oracle JDK and the Java Cryptography Extension (JCE) Policy 
Files you must accept the license terms found at 
http://www.oracle.com/technetwork/java/javase/terms/license/index.html and not 
accepting will cancel the Ambari Server setup and you must install the JDK and 
JCE files manually.
Do you accept the Oracle Binary Code License Agreement [y/n] (y)? 
Downloading JDK from 
http://public-repo-1.hortonworks.com/ARTIFACTS/jdk-8u60-linux-x64.tar.gz to 
/var/lib/ambari-server/resources/jdk-8u60-linux-x64.tar.gz
jdk-8u60-linux-x64.tar.gz... 100% (172.8 MB of 172.8 MB)
Successfully downloaded JDK distribution to 
/var/lib/ambari-server/resources/jdk-8u60-linux-x64.tar.gz
Installing JDK to /usr/jdk64/
Successfully installed JDK to /usr/jdk64/
Downloading JCE Policy archive from 
http://public-repo-1.hortonworks.com/ARTIFACTS/jce_policy-8.zip to 
/var/lib/ambari-server/resources/jce_policy-8.zip

Successfully downloaded JCE Policy archive to 
/var/lib/ambari-server/resources/jce_policy-8.zip
Installing JCE policy...
Completing setup...
Configuring database...
Enter advanced database configuration [y/n] (n)? 
Configuring database...
Default properties detected. Using built-in database.
WARNING: Command chown  None /etc/ambari-server/conf/password.dat returned 
exit code /etc/ambari-server/conf/password.dat with message: chown: invalid 
user: `None'

Configuring ambari database...
Checking PostgreSQL...
Running initdb: This may take up to a minute.
Initializing database: [  OK  ]

About to start PostgreSQL
Configuring local database...
Connecting to local database...done.
Configuring PostgreSQL...
Restarting PostgreSQL
Extracting system views...
ambari-admin-2.4.0.0.264.jar
..
Adjusting ambari-server permissions and ownership...
Ambari Server 'setup' completed successfully.
[root@c6401 ~]# ambari-server start
Using python  /usr/bin/python
Starting ambari-server
Ambari Server running with administrator privileges.
Organizing resource files at /var/lib/ambari-server/resources...
WARNING: Multiple versions of javax.servlet.jsp.jstl.jar found in java 
class path (/usr/lib/ambari-server/javax.servlet.jsp.jstl-1.2.2.jar and 
/usr/lib/ambari-server/javax.servlet.jsp.jstl-1.2.0.v201105211821.jar). 
 Make sure that you include only one javax.servlet.jsp.jstl.jar in the java 
class path 
'/etc/ambari-server/conf:/usr/lib/ambari-server/*:/usr/share/java/postgresql-jdbc.jar'.
Server PID at: /var/run/ambari-server/ambari-server.pid
Server out at: /var/log/ambari-server/ambari-server.out
Server log at: /var/log/ambari-server/ambari-server.log
Waiting for server start.


Diffs
-

  ambari-server/src/main/python/ambari_server/serverClassPath.py fdc1c12 
  ambari-server/src/main/python/ambari_server/serverConfiguration.py 446b083 

Diff: https://reviews.apache.org/r/46141/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 45978: AMBARI-15806: Stack definition for Logsearch

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45978/#review128625
---


Ship it!




Ship It!

- Sebastian Toader


On April 12, 2016, 6:27 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45978/
> ---
> 
> (Updated April 12, 2016, 6:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin 
> Jetly, Jayush Luniya, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and 
> Yusaku Sako.
> 
> 
> Bugs: AMBARI-15806
> https://issues.apache.org/jira/browse/AMBARI-15806
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Logsearch support was splitted into 3 different commits: 
> https://github.com/apache/ambari/tree/branch-dev-logsearch
> - integrate logsearch module
> - ambari server REST implementation for logsearch
> - stack definition
> 
> This one is the stack definition.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
>  df46ce0 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-audit_logs-solrconfig.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-service_logs-solrconfig.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-xml.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logfeeder.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_common.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_solr.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/solr.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/global.config.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/grok-patterns.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-accumulo.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ambari.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ams.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-atlas.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-falcon.json.j2

Re: Review Request 45978: AMBARI-15806: Stack definition for Logsearch

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45978/#review128624
---




ambari-server/src/main/resources/stacks/HDP/2.3/services/LOGSEARCH/role_command_order.json
 (lines 1 - 8)


Can you add a unit test for role command order. This will be useful to 
catch early breaking changes done to role command order. 

See as an exmaple 
`StackManagerTest.testServicesWithRangerPluginRoleCommandOrder()`


- Sebastian Toader


On April 12, 2016, 6:27 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45978/
> ---
> 
> (Updated April 12, 2016, 6:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin 
> Jetly, Jayush Luniya, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and 
> Yusaku Sako.
> 
> 
> Bugs: AMBARI-15806
> https://issues.apache.org/jira/browse/AMBARI-15806
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Logsearch support was splitted into 3 different commits: 
> https://github.com/apache/ambari/tree/branch-dev-logsearch
> - integrate logsearch module
> - ambari server REST implementation for logsearch
> - stack definition
> 
> This one is the stack definition.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
>  df46ce0 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-audit_logs-solrconfig.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-service_logs-solrconfig.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-xml.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logfeeder.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_common.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_solr.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/solr.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/global.config.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/grok-patterns.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-accumulo.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ambari.json.j2
>  PRE-CREATION 
>   
> ambari-se

Re: Review Request 44704: CapSched View: Revamping the old UI

[Akhil PB]

> On April 4, 2016, 9:05 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js,
> >  line 19
> > 
> >
> > Looks like you can delete this file.
> > Even if the file name is queueMappingParser.js, this is same as 
> > queueMappingInterpreter.js.
> > Also correct th require.

This file is removed.


> On April 4, 2016, 9:05 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs,
> >  line 28
> > 
> >
> > Whay are we having an anchor tags inside link-to? And what is the 
> > purpose fo href="view.href".

Here link-to tag is li, not anchor. When link-to is clicked, ember would add 
active class to link-to element. Since we have tab structure, I have used this 
to show active tab whenever user clicks on tab.
Please refer 
http://stackoverflow.com/questions/11628489/emberjs-how-to-mark-active-menu-item-using-router-infrastructure


- Akhil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44704/#review126795
---


On April 13, 2016, 7:18 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44704/
> ---
> 
> (Updated April 13, 2016, 7:18 a.m.)
> 
> 
> Review request for Ambari and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-15384
> https://issues.apache.org/jira/browse/AMBARI-15384
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revamping the old capsched UI into new better one
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> ac679b7 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js 
> 16b7d0a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 05bb64c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a2d50b9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  be79229 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 25e2aa9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/a

Re: Review Request 44704: CapSched View: Revamping the old UI

[Akhil PB]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44704/
---

(Updated April 13, 2016, 7:18 a.m.)


Review request for Ambari and Sreenath Somarajapuram.


Changes
---

Fixed the review comments and updated diff with latest fixed patch.


Bugs: AMBARI-15384
https://issues.apache.org/jira/browse/AMBARI-15384


Repository: ambari


Description
---

Revamping the old capsched UI into new better one


Diffs (updated)
-

  contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
ac679b7 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
 PRE-CREATION 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js 
16b7d0a 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
 PRE-CREATION 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js 
PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js 
PRE-CREATION 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
05bb64c 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js a2d50b9 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
 be79229 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
25e2aa9 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs
 PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js
 PRE-CREATION 
  contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 
PRE-CREATION 
  
contrib/views/capacity-scheduler/src/main/resources/ui/app/views/queuesconf.js 
PRE-CREATION 

Diff: https://reviews.apache.org/r/44704/diff/


Testing
---

Manual unit testing


Thanks,

Akhil PB