Re: Review Request 51818: YAML Maps For Storm Are Not Being Escaped Correctly

------ On Sept. 12, 2016, 3:13 p.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51818/ >

Re: Review Request 51838: Do not execute stack-selector-tool after HDP component install on sysprepped hosts.

call. However, we should be allowed to invoke `hdp-select set all` as many times as we want, especially since it's being done within a lock. Perhaps there needs to be a Jira to track why it's failing and have it gracefully recover. - Jonathan Hurley On Sept. 13, 2016, 9:22 a.m., Sebast

Re: Review Request 51822: Add Ambari configuration options to support Kerberos token authentication

> On Sept. 13, 2016, 8:24 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > lines 5292-5294 > > <https://reviews.apache.org/r/51822/diff/1/?file=1497122#file1497122line5292> > > >

Re: Review Request 51822: Add Ambari configuration options to support Kerberos token authentication

> On Sept. 13, 2016, 8:24 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 2586 > > <https://reviews.apache.org/r/51822/diff/1/?file=1497122#file1497122line2586> > > > >

Re: Review Request 51822: Add Ambari configuration options to support Kerberos token authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51822/#review148785 --- Ship it! Ship It! - Jonathan Hurley On Sept. 13, 2016, 4:44

Re: Review Request 51705: Password in the configurations.json file in the ambari-agent cache is not encrypted

> This method is still inefficient in that it repeats the same work over and over for every command. It can simply cache the results of properties which are PASSWORD type and return that. - Jonathan Hurley On Sept. 12, 2016, 6:48 p.m., Anita Jebaraj wrote: > > -

Re: Review Request 51903: [PREVIEW] Atlas web UI alert after performing stack upgrade to HDP 2.5 and adding Atlas Service

and the `current_dir` is valid (indicates installed) - Jonathan Hurley On Sept. 14, 2016, 9:57 p.m., Alejandro Fernandez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request 51903: [PREVIEW] Atlas web UI alert after performing stack upgrade to HDP 2.5 and adding Atlas Service

> On Sept. 14, 2016, 10:49 p.m., Jonathan Hurley wrote: > > I think we can do better. Why not just use `os.path.exists` to check the > > `current_dir` structure. In the case of atlas, the psuedo code woudl read: > > > > if "/etc/atlas/conf" is a directory

Re: Review Request 51892: Create authentication filter to encapsulate the various Ambari authentication methods

g/r/51892/#comment216599> sp: warranted implementations - Jonathan Hurley On Sept. 15, 2016, 8:31 a.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 51915: AMBARI-18402 - Alert definition should include AGGREGATE source type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51915/#review149068 --- Ship it! Ship It! - Jonathan Hurley On Sept. 15, 2016, 10

Review Request 51916: YAML Maps Can Include Dashes and Other Non-Word Characters

--- mvn clean test Thanks, Jonathan Hurley

Review Request 51917: Upgrade Summary Endpoint Throws NPEs Due To JPA Cached Entities With Missing IDs

/ambari/server/actionmanager/TestActionDBAccessorImpl.java 0813dff Diff: https://reviews.apache.org/r/51917/diff/ Testing --- mvn clean test Thanks, Jonathan Hurley

Re: Review Request 51917: Upgrade Summary Endpoint Throws NPEs Due To JPA Cached Entities With Missing IDs

matically generated e-mail. To reply, visit: https://reviews.apache.org/r/51917/#review149071 ------- On Sept. 15, 2016, 12:15 p.m., Jonathan Hurley wrote: > > --- > This is an automatically gene

Re: Review Request 51903: [PREVIEW] Atlas web UI alert after performing stack upgrade to HDP 2.5 and adding Atlas Service

thinking Atlas needs to have its /etc/atlas/conf bootstrapped. Therefore, I am fine with this surgical approach. We need to open a Jira to remove this block of code now that it's no longer needed since we don't support HDP 2.1 - Jonathan Hurley On Sept. 14, 2016, 9:57 p.m.,

Re: Review Request 51382: AMBARI-18250

it. - Jonathan Hurley On Aug. 24, 2016, 2:25 p.m., Jay SenSharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 51961: Prerequisite checks should only check services that are getting upgraded

<https://reviews.apache.org/r/51961/#comment216788> %s but no param? - Jonathan Hurley On Sept. 16, 2016, 1:25 p.m., Nate Cole wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 51599: AMBARI-18292 Support dispatching notifications of assigned alert states for script-based alert dispatcher

> On Sept. 3, 2016, 3:17 p.m., Jonathan Hurley wrote: > > This is not the correct way to accomplish this. Instead, when you create > > the alert target, you can specify which alert states the alert target cares > > about: > > > > ``` > > { > &g

Re: Review Request 52068: Create authentication filter to perform Kerberos authentication for Ambari

about it? Could really help debugging issues in the future. - Jonathan Hurley On Sept. 20, 2016, 10:41 a.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https

Re: Review Request 52125: Re-enable orchestration to use VDF

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52125/#review149867 --- Ship it! Ship It! - Jonathan Hurley On Sept. 21, 2016, 1:12

Re: Review Request 52163: Enforce granular role-based access control for custom actions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52163/#review150009 --- Ship it! Ship It! - Jonathan Hurley On Sept. 22, 2016, 10

Re: Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error

you remove hte `,number,#` ? I believe it's needed to prevent formatting of the number using commas or periods. - Jonathan Hurley On Sept. 22, 2016, 7:08 a.m., wang yaoxin wrote: > > --- > This is an automatically generated e-m

Re: Review Request 52170: NPE when installing secure cluster via Blueprints due to null logger

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52170/#review150060 --- Ship it! Ship It! - Jonathan Hurley On Sept. 22, 2016, 2:33

Re: Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error

f 1 and possibly cause duplicates. You can simply skip this whole section of updating if the `resultSet.getLong("id")` is non-null/non-zero. You can then so something like this: `m_hcsId.set(NumberUtils.max(m_hcsId.get(), idKey)` - Jonathan Hurley On Sept. 27, 20

Re: Review Request 52282: RU/EU cannot start because ServiceCheckValidityCheck incorrectly calculates Service Checks that ran

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52282/#review150546 --- Ship it! Ship It! - Jonathan Hurley On Sept. 26, 2016, 5:53

Re: Review Request 52289: Regression: krb5JAASLogin.conf is not updated during secure BP install

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52289/#review150547 --- Ship it! Ship It! - Jonathan Hurley On Sept. 26, 2016, 8:09

Re: Review Request 52304: Scope and Services need to be used for orchestration

scope still partial? - Jonathan Hurley On Sept. 27, 2016, 12:54 p.m., Nate Cole wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Re: Review Request 52344: Ubuntu16 Requires libsnappy1v5 As a Dependency For Metrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52344/#review150711 --- Ship it! Ship It! - Jonathan Hurley On Sept. 28, 2016, 8:23

Review Request 52345: Remove Global Cluster Lock Shared Between Business Objects

time: 41:36 min [INFO] Finished at: 2016-09-27T14:21:22-04:00 [INFO] Final Memory: 40M/739M [INFO] ---- Thanks, Jonathan Hurley

Re: Review Request 52345: Remove Global Cluster Lock Shared Between Business Objects

-- [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 41:36 min [INFO] Finished at: 2016-09-27T14:21:22-04:00 [INFO] Final Memory: 40M/739M [INFO] ---- Thanks, Jonathan Hurley

Re: Review Request 52345: Remove Global Cluster Lock Shared Between Business Objects

o I never tried to get it officially added to our coding style wiki. - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52345/#review150714 -------

Re: Review Request 52346: Fix Authentication data is not available error in ConfigGroupResourceProviderTest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52346/#review150715 --- Ship it! Ship It! - Jonathan Hurley On Sept. 28, 2016, 9:42

Re: Review Request 52383: Clusters With Many Hosts Can Create Alerts With Text Too Large To Be Stored

bari/server/state/Alert.java (line 135) <https://reviews.apache.org/r/52383/#comment218927> Use \u2026 instead of '...' to represent a single character which can't be broken across lines. - Jonathan Hurley On Sept. 29, 2

Re: Review Request 52378: [AMBARI-18489] configs.sh has a spelling mistake inside the script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52378/#review150850 --- Ship it! Ship It! - Jonathan Hurley On Sept. 29, 2016, 2:01

Re: Review Request 52383: Clusters With Many Hosts Can Create Alerts With Text Too Large To Be Stored

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52383/#review150859 --- Ship it! Ship It! - Jonathan Hurley On Sept. 29, 2016, 10

Review Request 52425: Remove Unnecessary Locks Inside Of Cluster Business Object Implementations

/server/controller/internal/ClusterResourceProviderTest.java c7261ea ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java ec01b80 Diff: https://reviews.apache.org/r/52425/diff/ Testing --- PENDING Thanks, Jonathan Hurley

Re: Review Request 52425: Remove Unnecessary Locks Inside Of Cluster Business Object Implementations

185 - 209) <https://reviews.apache.org/r/52425/#comment219147> This is done on object construction now (yay) but because the factories reference each other (bo!), we have to initialize the cached objects a little smarter. So I just re-organized how the lists are populated. - Jonat

Re: Review Request 52425: Remove Unnecessary Locks Inside Of Cluster Business Object Implementations

x27;t think it was necessary to remove them. I could re-request them from Clusters in the case of invalidation. I really dislike this class. - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://

Re: Review Request 52504: AMBARI-18521 Stack upgrade fix for Ranger in secure env

grades/RangerKerberosConfigCalculation.java (line 185) <https://reviews.apache.org/r/52504/#comment219936> StringUtils.isBlank() - Jonathan Hurley On Oct. 4, 2016, 4:38 a.m., Mugdha Varadkar wrote: > > --- > This is an automatically gener

Re: Review Request 52482: Optimize ClustersDeadlockTest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52482/#review151522 --- Ship it! Ship It! - Jonathan Hurley On Oct. 5, 2016, 7:26

Review Request 52566: Remove Unnecessary Locks Inside Of Host Business Object Implementations

/state/cluster/ClusterTest.java b99277d ambari-server/src/test/java/org/apache/ambari/server/utils/StageUtilsTest.java 5d39841 Diff: https://reviews.apache.org/r/52566/diff/ Testing --- PENDING Thanks, Jonathan Hurley

Re: Review Request 52566: Remove Unnecessary Locks Inside Of Host Business Object Implementations

-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 99fc0a1 ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 243cb4f Diff: https://reviews.apache.org/r/52566/diff/ Testing --- PENDING Thanks, Jonathan Hurley

Re: Review Request 52566: Remove Unnecessary Locks Inside Of Host Business Object Implementations

] Thanks, Jonathan Hurley

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

server/logging/LockFactory.java (line 64) <https://reviews.apache.org/r/52636/#comment220429> Should have a default prefix. - Jonathan Hurley On Oct. 7, 2016, 12:25 p.m., Attila Doroszlai wrote: > > --- > Thi

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

> > (Updated Oct. 7, 2016, 12:25 p.m.) > > > Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Sandor Magyari, > and Sebastian Toader. > > > Repository: ambari > > > Description > --- > > 1. Create `Lock` and `Read

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

oc for whole class. ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java (lines 331 - 332) <https://reviews.apache.org/r/52636/#comment220435> Why is this a read/write lock? I don't think it's used with a reader anywhere. - Jonathan Hurley O

Review Request 52646: Remove Unnecessary Locks Inside Of Service Business Object Implementations

] [INFO] Total time: 23:42 min [INFO] Finished at: 2016-10-07T14:51:21-04:00 [INFO] Final Memory: 57M/742M [INFO] Thanks, Jonathan Hurley

Re: Review Request 52646: Remove Unnecessary Locks Inside Of Service Business Object Implementations

/HostComponentStateDAO.java (lines 177 - 180) <https://reviews.apache.org/r/52646/#comment220438> The DAO should not be in the business of removing dependenant objects; that should lie in the business layer (ServiceImpl) - Jonathan Hurley On Oct. 7, 2016, 3:04 p.m., Jonathan Hurley

Re: Review Request 52646: Remove Unnecessary Locks Inside Of Service Business Object Implementations

------ On Oct. 7, 2016, 3:04 p.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52646/ > ---

Re: Review Request 52646: Remove Unnecessary Locks Inside Of Service Business Object Implementations

ted e-mail. To reply, visit: https://reviews.apache.org/r/52646/#review151869 ------- On Oct. 7, 2016, 3:04 p.m., Jonathan Hurley wrote: > > --- > This is an

Re: Review Request 52183: Support creating/editing alert target which notification_type is ALERT_SCRIPT in web client

7;s not an area I'm familiar with. However, I do believe there are Jiras scoping a new "wizard" workflow for alerts in Ambari 3.0 which this may impact. - Jonathan Hurley On Sept. 22, 2016, 10:24 p.m., yao lei wrote: > > -

Re: Review Request 52752: Hive shows restart indicator after RU

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52752/#review152304 --- Ship it! Ship It! - Jonathan Hurley On Oct. 11, 2016, 5:13

Re: Review Request 52758: When multiple requests are running, aborting any will incorrectly abort all requests instead the desired one

- > > (Updated Oct. 11, 2016, 7:48 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan > Hurley, Nate Cole, and Sid Wagle. > > > Bugs: AMBARI-18576 > https://issues.apache.org/jira/browse/AMBARI-18576 > > > Repo

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

> On Oct. 7, 2016, 2:53 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/logging/LockFactory.java, > > line 50 > > <https://reviews.apache.org/r/52636/diff/1/?file=1526480#file1526480line50> > > > > There should be

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

that I think this should go alongside the other changes for AMBARI-18456 in branch-feature-AMBARI-18456. - Jonathan Hurley On Oct. 7, 2016, 4:21 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 52826: Increase forkCount for Ambari Server Unit Tests

> On Oct. 13, 2016, 9:40 a.m., Sumit Mohanty wrote: > > ambari-project/pom.xml, line 516 > > > > > > Why 1.5C? 1.5C means 1.5 x # of cores - so that lowered powered machines (like build machines) don't spawn too ma

Review Request 52833: RegionServer Registration Checks Fail During Upgrade If rDNS is Not Enabled

0.96.0.2.0/package/scripts/upgrade.py f1fa80c Diff: https://reviews.apache.org/r/52833/diff/ Testing --- Total run:1133 Total errors:0 Total failures:0 OK Thanks, Jonathan Hurley

Re: Review Request 52826: Increase forkCount for Ambari Server Unit Tests

> On Oct. 13, 2016, 9:40 a.m., Sumit Mohanty wrote: > > ambari-project/pom.xml, line 516 > > <https://reviews.apache.org/r/52826/diff/1/?file=1534261#file1534261line516> > > > > Why 1.5C? > > Jonathan Hurley wrote: > 1.5C means 1.5 x # of core

Re: Review Request 52833: RegionServer Registration Checks Fail During Upgrade If rDNS is Not Enabled

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52833/#review152531 ------- On Oct. 13, 2016, 11:19 a.m., Jonathan Hurley wrote: > > ---

Review Request 52837: Hive Rolling Upgrade Is No Longer Supported In Ambari

] BUILD SUCCESS [INFO] [INFO] Total time: 28:16 min [INFO] Finished at: 2016-10-13T12:18:24-04:00 [INFO] Final Memory: 60M/720M [INFO] Thanks, Jonathan

Re: Review Request 52837: Hive Rolling Upgrade Is No Longer Supported In Ambari

/CheckDescription.java (lines 293 - 298) <https://reviews.apache.org/r/52837/#comment221558> I'm open to new wording here if this isn't clear or needs more. - Jonathan Hurley On Oct. 13, 2016, 1:17 p.m., Jonat

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/#review152562 --- Ship it! Ship It! - Jonathan Hurley On Oct. 13, 2016, 2:01

Re: Review Request 52885: AMBARI-18594 - AMBARI-18051 Breaks Stack Upgrade Checks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52885/#review152682 --- Ship it! Ship It! - Jonathan Hurley On Oct. 14, 2016, 11:06

Review Request 52893: Remove Unnecessary Locks Inside Of ServiceComponent Business Object Implementations

/svccomphost/ServiceComponentHostTest.java 080886e Diff: https://reviews.apache.org/r/52893/diff/ Testing --- mvn clean test Thanks, Jonathan Hurley

Re: Review Request 52893: Remove Unnecessary Locks Inside Of ServiceComponent Business Object Implementations

] [INFO] Total time: 25:07 min [INFO] Finished at: 2016-10-14T15:08:29-04:00 [INFO] Final Memory: 57M/540M [INFO] Thanks, Jonathan Hurley

Re: Review Request 52851: rpm command broken on utility project

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52851/#review152728 --- Ship it! Ship It! - Jonathan Hurley On Oct. 13, 2016, 8:14

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

e.org/r/52839/ > ------- > > (Updated Oct. 13, 2016, 2:01 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, > and Sid Wagle. > > > Bugs: AMBARI-18592 > https://issue

Re: Review Request 52932: Ambari MIB Should Be Included with Installation Bits

g/r/52932/#comment222147> I think that perhaps we should now move this out of contrib and into resources directly since it's a first-class part of the product. - Jonathan Hurley On Oct. 17, 2016, 12:05 p.m., Dmytr

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

eviews.apache.org/r/52691/#comment222159> This feels very wrong to hard-code into something like a scheduler. It should be declarative somehow. Same for the other components below... - Jonathan Hurley On Oct. 16, 2016, 4:33 a.m., Sandor Magyari wrote: > >

Review Request 52987: Remove Unnecessary Locks Inside Of SCH Business Object Implementations

] [INFO] Total time: 22:28 min [INFO] Finished at: 2016-10-17T18:20:53-04:00 [INFO] Final Memory: 53M/475M [INFO] Thanks, Jonathan Hurley

Re: Review Request 52964: Optimize Service Checks to it picks a random host and prefers hosts with 0 active commands

/controller/AmbariCustomCommandExecutionHelper.java (line 616) <https://reviews.apache.org/r/52964/#comment222360> Why is this a Map ... Seems kind of odd that we track the # of commands running as a long. - Jonathan Hurley On Oct. 17, 2016, 8:36 p.m., Alejandro Fernandez

Re: Review Request 52932: Ambari MIB Should Be Included with Installation Bits

> On Oct. 17, 2016, 5:10 p.m., Jonathan Hurley wrote: > > ambari-server/pom.xml, line 44 > > <https://reviews.apache.org/r/52932/diff/1/?file=1539675#file1539675line44> > > > > I think that perhaps we should now move this out of contrib and into > >

Re: Review Request 52932: Ambari MIB Should Be Included with Installation Bits

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52932/#review153102 --- Ship it! Ship It! - Jonathan Hurley On Oct. 18, 2016, 10:27

Re: Review Request 52987: Remove Unnecessary Locks Inside Of SCH Business Object Implementations

ly, visit: https://reviews.apache.org/r/52987/#review153116 --- On Oct. 18, 2016, 8:23 a.m., Jonathan Hurley wrote: > > --- > This is an automatically gen

Re: Review Request 52964: Optimize Service Checks to it picks a random host and prefers hosts with 0 active commands

> This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52964/ > --- > > (Updated Oct. 18, 2016, 2:25 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Di L

Re: Review Request 52996: For rolling upgrade of Kafka 0.10.0.1, set configs for backward compatibility

about removing the two properties, could we just have a new stage right before finalization that does it automatically? I know it won't restart anything, but at least the configs will be correct. - Jonathan Hurley On Oct. 18, 2016, 8:57 p.m., Nate Cole

Re: Review Request 53060: Authorizations given to roles, should use generic role-based principals rather than hard-coded pseudo-role-based principals

-- > > (Updated Oct. 20, 2016, 10:20 a.m.) > > > Review request for Ambari, Aleksandr Kovalenko, DIPAYAN BHOWMICK, Jonathan > Hurley, Nate Cole, and Sebastian Toader. > > > Bugs: AMBARI-18635 > https://issues.apache.o

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52691/#review153414 --- Ship it! Ship It! - Jonathan Hurley On Oct. 18, 2016, 2:17

Review Request 53068: Alert Targets Cannot Be Updated Due To Transaction / Cache Timing Issues

Total time: 29:00 min [INFO] Finished at: 2016-10-20T12:37:48-04:00 [INFO] Final Memory: 57M/702M [INFO] Thanks, Jonathan Hurley

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

66/#comment222735> No need to check params.version - compare_versions does that already - Jonathan Hurley On Oct. 20, 2016, 12:26 p.m., Dmitro Lisnichenko wrote: > > --- > This is an automatically gene

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52636/#review153428 --- Ship it! Ship It! - Jonathan Hurley On Oct. 7, 2016, 4:21

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

> On Oct. 20, 2016, 1:34 p.m., Jonathan Hurley wrote: > > Ship It! branch-feature-AMBARI-18456 and trunk are in-sync - feel free to commit to trunk and branch-2.5. - Jonathan --- This is an automatically generated e-mail.

Re: Review Request 53090: Storm becomes stopped by itself after upgrade from 2.2.1.0 to 2.4.1.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53090/#review153558 --- Ship it! Ship It! - Jonathan Hurley On Oct. 21, 2016, 12:20

Re: Review Request 53101: While syncing with LDAP, username collisions should be handled based on configuration value

;https://reviews.apache.org/r/53101/#comment223124> You can use == with enums (makes it easier to read) - Jonathan Hurley On Oct. 24, 2016, 12:34 p.m., Robert Levas wrote: > > --- > This is an automatically g

Review Request 53142: Webhcat server start failed during EU with BindException

ong PID, and sbin/webhcat_server.sh not correctly stopping the daemon in order to test the behavior of the Execute statements. ------- Total run:1135 Total errors:0 Total failures:0 Thanks, Jonathan Hurley

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

;https://reviews.apache.org/r/53066/#comment223135> Same as above comment - why listen for a broader event, check instance type, and then return when you could just listen for the concrete event you care about? - Jonathan Hurley On Oct. 24, 2016

Re: Review Request 53101: While syncing with LDAP, username collisions should be handled based on configuration value

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53101/#review153798 --- Ship it! Ship It! - Jonathan Hurley On Oct. 25, 2016, 10:50

Re: Review Request 53066: Preview - HDP-2.5 installation allows ZKFC to advertise version

/events/listeners/upgrade/StackVersionListener.java (line 146) <https://reviews.apache.org/r/53066/#comment223261> Some JavaDoc here. - Jonathan Hurley On Oct. 25, 2016, 11:38 a.m., Dmitro Lisnichenko wrote: > > ---

Review Request 53185: Upgrade Configuration Packs Should Have an XSD

44f9e02 ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/config-upgrade.xml 90d64b4 ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/upgrades/config-upgrade.xml 90d64b4 Diff: https://reviews.apache.org/r/53185/diff/ Testing --- PENDING Thanks, Jonathan

Re: Review Request 53185: Upgrade Configuration Packs Should Have an XSD

at: 2016-10-26T11:12:42-04:00 [INFO] Final Memory: 54M/744M [INFO] Thanks, Jonathan Hurley

Re: Review Request 53192: Create HOST_ORDERED Upgrade Pack

n we please rename this to EXPRESS :) ambari-server/src/main/resources/upgrade-pack.xsd (line 30) <https://reviews.apache.org/r/53192/#comment223532> EXPRESS :) - Jonathan Hurley On Oct. 26, 2016, 1:05 p.m., Nate Cole wrote: > > --

Re: Review Request 53216: AMBARI-18711: Ambari-server: DB changes to enable/disable credential store support

/src/main/java/org/apache/ambari/server/state/ServiceImpl.java (line 361) <https://reviews.apache.org/r/53216/#comment223565> Always good to update the reference to the entity after a merge (in case it's used later on) desiredStateEntity = dao.merge(...) - Jonathan Hurl

Re: Review Request 53216: AMBARI-18711: Ambari-server: DB changes to enable/disable credential store support

> On Oct. 27, 2016, 1:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java, > > line 361 > > <https://reviews.apache.org/r/53216/diff/1/?file=1546993#file1546993line361> > > > > Always goo

Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

cycle/HDP/2.2.0/upgrades/upgrade_test_15388.xml 905def5 Diff: https://reviews.apache.org/r/53251/diff/ Testing --- PENDING Thanks, Jonathan Hurley

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

restrictive than normal xs:string types. It disallows empty strings and funky characters. ambari-server/src/main/resources/upgrade-pack.xsd (lines 142 - 152) <https://reviews.apache.org/r/53251/#comment223600> Noticed that XSD for execute-stage was missing, so I added it. - Jonath

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

t have. Do you think we need to add it now? - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53251/#review154120 --- On Oct. 2

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

-28T08:49:12-04:00 [INFO] Final Memory: 55M/762M [INFO] ---- Thanks, Jonathan Hurley

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

matter of time before someone wants to add a custom condition > > class. Could add CLASS or something here with a Condition interface that > > can take the cluster as an argument. > > Jonathan Hurley wrote: > That's true - we can have CLASS as a new type and en

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

251/#review154131 --- On Oct. 28, 2016, 10:18 a.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.o

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

D SUCCESS [INFO] [INFO] Total time: 22:57 min [INFO] Finished at: 2016-10-28T08:49:12-04:00 [INFO] Final Memory: 55M/762M [INFO] ---- Thanks, Jonathan Hurley

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

matter of time before someone wants to add a custom condition > > class. Could add CLASS or something here with a Condition interface that > > can take the cluster as an argument. > > Jonathan Hurley wrote: > That's true - we can have CLASS as a new type and en

<    1   2   3   4   5   6   7   8   9   10   >