Re: Review Request 58929: Create Database Schema for Improved User Account Management

2017-05-02 Thread Nate Cole
> On May 2, 2017, 3:58 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql > > Lines 296 (patched) > > <https://reviews.apache.org/r/58929/diff/1/?file=1705974#file1705974line300> > > > > Oracle 12 allows more than

Re: Review Request 58489: VersionAdvertised should be set to False by default in stack_tool.py

2017-05-03 Thread Nate Cole
atically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58489/ > --- > > (Updated April 19, 2017, 3:29 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush > Luniya, Nate Cole, and Sum

Review Request 58970: Repositories must be resolved correctly when installing new components

2017-05-03 Thread Nate Cole
/TestInstallPackages.py 5206ea351c Diff: https://reviews.apache.org/r/58970/diff/1/ Testing --- Manual. Automated pending. Thanks, Nate Cole

Re: Review Request 58970: Repositories must be resolved correctly when installing new components

2017-05-03 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58970/#review173787 ------- On May 3, 2017, 2:12 p.m., Nate Cole wrote: > > --

Re: Review Request 58969: Old Status Command Structured Output is Returned on Every Status Command Causing Upgrades to Fail

2017-05-03 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58969/#review173817 --- Ship it! Ship It! - Nate Cole On May 3, 2017, 2 p.m

Re: Review Request 59022: Propagate Component versions and states to Service

2017-05-05 Thread Nate Cole
/ambari/server/state/RepositoryVersionState.java Lines 106 (patched) <https://reviews.apache.org/r/59022/#comment247126> Maybe make this a float to make rearranging them less cumbersome. - Nate Cole On May 5, 2017, 10:33 a.m., Jonathan Hurley

Re: Review Request 59022: Propagate Component versions and states to Service

2017-05-05 Thread Nate Cole
> On May 5, 2017, 11 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java > > Lines 106 (patched) > > <https://reviews.apache.org/r/59022/diff/1/?file=1709347#file1709347line106> > > > > Mayb

Re: Review Request 59022: Propagate Component versions and states to Service

2017-05-05 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59022/#review174072 --- Ship it! Ship It! - Nate Cole On May 5, 2017, 1:55 p.m

Review Request 59066: Remove cluster_version use

2017-05-08 Thread Nate Cole
/diff/1/ Testing --- Manual. Automated pending. Thanks, Nate Cole

Re: Review Request 59066: Remove cluster_version use

2017-05-09 Thread Nate Cole
le=1710856#file1710856line401> > > > > Should this instead be across host versions for the repo now? I was hoping the cascade on entities would solve this problem, but I see the point. Will update. - Nate --- This is

Re: Review Request 59060: Host Version on Finalization Must Be Scoped Correctly Based on Upgrade Type

2017-05-09 Thread Nate Cole
satisfied via host_id/repo_id host_version1 -> repo1 'INSTALLED' host_version1 -> repo2 'CURRENT' - Nate Cole On May 8, 2017, 2:50 p.m., Jonathan Hurley wrote: > > --- > This is an au

Re: Review Request 59112: Repository Resource Providers Should Expose the Repository ID by Default on Minimal Responses

2017-05-10 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59112/#review174464 --- Ship it! Ship It! - Nate Cole On May 9, 2017, 5:07 p.m

Re: Review Request 58929: Create Database Schema for Improved User Account Management

2017-05-10 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58929/#review174466 --- What is the state of this review? - Nate Cole On May 3, 2017

Re: Review Request 59144: RU: RESTART SPARK2/SPARK2_CLIENT failed

2017-05-10 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59144/#review174544 --- Ship it! Ship It! - Nate Cole On May 10, 2017, 10:19 a.m

Re: Review Request 59176: Add missing 'cluster_host_info' column to 'request' table to MSSQL DDL

2017-05-11 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59176/#review174644 --- Ship it! Ship It! - Nate Cole On May 11, 2017, 9:17 a.m

Re: Review Request 59180: Cluster Repository State Is Not Calculated Correctly For Service/Patch Repos

2017-05-11 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59180/#review174659 --- Ship it! Ship It! - Nate Cole On May 11, 2017, 11:34 a.m

Re: Review Request 59192: Fallback Cluster Current Version Is Blank Which Causes Upgrade Errors

2017-05-11 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59192/#review174718 --- Ship it! Ship It! - Nate Cole On May 11, 2017, 2:21 p.m

Re: Review Request 59133: Journalnode should support bulk restart o start or stop in hosts' page

2017-05-12 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59133/#review174786 --- Please close this review if it has been pushed. - Nate Cole On

Re: Review Request 59277: Upgrades Should Be Associated With Repositories Instead of String Versions

2017-05-15 Thread Nate Cole
ed any hashCode()/equals() overrides here now that we're using them in a Set? - Nate Cole On May 15, 2017, 1:35 p.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 59329: Atlas web UI inaccessible after adding Atlas service on upgraded cluster with Hive because /etc/atlas/conf symlink was created ahead of time

2017-05-17 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59329/#review175281 --- Ship it! Ship It! - Nate Cole On May 17, 2017, 1:15 a.m

Re: Review Request 59345: Iterative Fixes For Patch/Service Upgrade Development

2017-05-17 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59345/#review175317 --- Ship it! Ship It! - Nate Cole On May 17, 2017, 2:56 p.m

Review Request 59369: Reduce Dependency on Cluster Desired Stack ID

2017-05-18 Thread Nate Cole
59369/diff/1/ Testing --- Manual: Install cluster; add service; run service checks; deploy both patch and full version; full and patch RU/EU. Automated pending unit test fixes. Thanks, Nate Cole

Re: Review Request 59369: Reduce Dependency on Cluster Desired Stack ID

2017-05-18 Thread Nate Cole
he way to get a handle to the service. - Nate --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59369/#review175390 --- On

Re: Review Request 59369: Reduce Dependency on Cluster Desired Stack ID

2017-05-18 Thread Nate Cole
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59369/#review175390 --- On May 18, 2017, 9:56 a.m., Nate Cole wrote: > > ---

Re: Review Request 59369: Reduce Dependency on Cluster Desired Stack ID

2017-05-18 Thread Nate Cole
in one of the spots and had enough. - Nate --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59369/#review175390 --- On May 18, 2017, 9:56 a.m., Nate Cole wrote: > > --

Re: Review Request 59400: Storm XML File has Invalid Characters Causing Exceptions on Server Startup

2017-05-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59400/#review175500 --- Ship it! Ship It! - Nate Cole On May 19, 2017, 10:22 a.m

Re: Review Request 59369: Reduce Dependency on Cluster Desired Stack ID

2017-05-23 Thread Nate Cole
Diff: https://reviews.apache.org/r/59369/diff/2/ Changes: https://reviews.apache.org/r/59369/diff/1-2/ Testing --- Manual: Install cluster; add service; run service checks; deploy both patch and full version; full and patch RU/EU. Automated pending unit test fixes. Thanks, Nate Cole

Re: Review Request 59491: AMBARI-19149. Code cleanup: identical catch blocks

2017-05-24 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59491/#review175970 --- Ship it! Ship It! - Nate Cole On May 23, 2017, 12:35 p.m

Re: Review Request 59534: Fix Unit Test Failures From Prior Patch/Service Upgrade Commits

2017-05-24 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59534/#review175972 --- Ship it! Ship It! - Nate Cole On May 24, 2017, 2:30 p.m

Re: Review Request 59612: AMBARI-21136: Upgrading Ambari to 2.5.1 stops Storm's nimbus in secure mode.

2017-05-26 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59612/#review176225 --- Ship it! Ship It! - Nate Cole On May 26, 2017, 4:24 p.m

Re: Review Request 59626: (PREVIEW) HDP deploy from public repo failed

2017-05-30 Thread Nate Cole
r the version error. - Nate Cole On May 29, 2017, 7:34 a.m., Dmitro Lisnichenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 59693: Upgrade Execution Commands Are Missing Service/Component For Action Commands

2017-05-31 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59693/#review176525 --- Ship it! Ship It! - Nate Cole On May 31, 2017, 4:55 p.m

Review Request 59694: Enabling Kerberos should use cluster stack id

2017-05-31 Thread Nate Cole
] [INFO] Total time: 30:28 min [INFO] Finished at: 2017-05-31T17:00:53-04:00 [INFO] Final Memory: 81M/1048M [INFO] Thanks, Nate Cole

Re: Review Request 59682: AMBARI-19149. Code cleanup: concatenation in debug messages, unnecessary toString calls

2017-06-01 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59682/#review176610 --- Ship it! Ship It! - Nate Cole On May 31, 2017, 7:07 a.m

Re: Review Request 59626: HDP deploy from public repo failed

2017-06-01 Thread Nate Cole
/functions/packages_analyzer.py Lines 118-126 (patched) <https://reviews.apache.org/r/59626/#comment250019> Can we target package lists by using the specific repo id? I think both zypper and yum allow using ONLY a repo id. For ubuntu we may need some magic. - Nate Cole On June 1, 2017,

Re: Review Request 59745: Host Versions Remain on CURRENT During STANDARD (Full) Upgrades

2017-06-05 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59745/#review176930 --- Ship it! Ship It! - Nate Cole On June 2, 2017, 8:47 a.m

Re: Review Request 59440: Part One: Specify the script directly in alert target for script-based alert dispatchers

2017-06-05 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59440/#review176931 --- Ship it! Ship It! - Nate Cole On June 1, 2017, 9:31 p.m

Re: Review Request 59812: Remove RepositoryVersionState of INIT

2017-06-05 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59812/#review176936 --- Ship it! Ship It! - Nate Cole On June 5, 2017, 2:34 p.m

Review Request 59818: Component command changes must include version numbers for all services

2017-06-05 Thread Nate Cole
] [INFO] Total time: 26:18 min [INFO] Finished at: 2017-06-05T17:32:00-04:00 [INFO] Final Memory: 76M/797M [INFO] Thanks, Nate Cole

Re: Review Request 59818: Component command changes must include version numbers for all services

2017-06-06 Thread Nate Cole
? I'd like to take the path-of-need here; if it turns out we need it, it would be simple enough to add. - Nate --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59818/#review177

Re: Review Request 59886: AMBARI-21195. Enforce minimum Maven version

2017-06-07 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59886/#review177215 --- Ship it! Ship It! - Nate Cole On June 7, 2017, 12:55 p.m

Re: Review Request 59626: HDP deploy from public repo failed

2017-06-12 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59626/#review177633 --- Ship it! Ship It! - Nate Cole On June 12, 2017, 9:38 a.m

Re: Review Request 59838: Stack advisor needs to recommend dependency for slaves and masters

2017-06-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59838/#review177782 --- Ship it! Ship It! - Nate Cole On June 7, 2017, 8:26 a.m

Review Request 60055: Support revert for patch upgrades

2017-06-13 Thread Nate Cole
sting --- Manual. Automated pending. Thanks, Nate Cole

Re: Review Request 60055: Support revert for patch upgrades

2017-06-13 Thread Nate Cole
[INFO] [INFO] Total time: 25:08 min [INFO] Finished at: 2017-06-13T17:18:07-04:00 [INFO] Final Memory: 73M/673M [INFO] Thanks, Nate Cole

Re: Review Request 59954: Drop JDK 7 support for Ambari Server and Ambari managed services (AMS, LogSearch, Infra)

2017-06-14 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59954/#review177880 --- Ship it! Ship It! - Nate Cole On June 13, 2017, 10:44 a.m

Re: Review Request 60055: Support revert for patch upgrades

2017-06-14 Thread Nate Cole
do. - Nate --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60055/#review177890 --- On June 13, 2017, 5:19 p.m., Nate Cole

Re: Review Request 60055: Support revert for patch upgrades

2017-06-14 Thread Nate Cole
[INFO] BUILD SUCCESS [INFO] [INFO] Total time: 25:08 min [INFO] Finished at: 2017-06-13T17:18:07-04:00 [INFO] Final Memory: 73M/673M [INFO] Thanks, Nate Cole

Re: Review Request 60055: Support revert for patch upgrades

2017-06-14 Thread Nate Cole
eviews.apache.org/r/60055/#review177917 --- On June 13, 2017, 5:19 p.m., Nate Cole wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 60120: Remove metainfo latest url

2017-06-15 Thread Nate Cole
/blob/trunk/ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java#L84-L107 If you take out those methods and start fixing compile errors then you should get the rest :) - Nate Cole On June 15, 2017, 10:15 a.m., Dmitro Lisnichenko

Re: Review Request 60120: Remove metainfo latest url

2017-06-16 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60120/#review178103 --- Ship it! Ship It! - Nate Cole On June 16, 2017, 9:07 a.m

Re: Review Request 59095: AMBARI-20967 - Remove Zookeeper as a required service from HDFS

2017-06-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59095/#review178229 --- Ship it! Ship It! - Nate Cole On June 6, 2017, 4:16 p.m

Re: Review Request 60011: Remove Zookeeper as a required service from YARN

2017-06-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60011/#review178230 --- Ship it! Ship It! - Nate Cole On June 12, 2017, 1:44 p.m

Re: Review Request 60156: AMBARI-21158. Eliminate Maven warnings

2017-06-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60156/#review178270 --- Ship it! Ship It! - Nate Cole On June 16, 2017, 12:17 p.m

Re: Review Request 60243: Cannot install Datanode/AppTimeLine server from ambari 3.0

2017-06-20 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60243/#review178383 --- Ship it! Ship It! - Nate Cole On June 20, 2017, 10:10 a.m

Review Request 60248: Service creation requires a repository id, not a string version

2017-06-20 Thread Nate Cole
] BUILD SUCCESS [INFO] [INFO] Total time: 27:58 min [INFO] Finished at: 2017-06-20T15:00:01-04:00 [INFO] Final Memory: 79M/756M [INFO] Thanks, Nate Cole

Re: Review Request 60277: Pausing An Upgrade In Progress Does Not Resume PENDING Tasks

2017-06-22 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60277/#review178663 --- Ship it! Ship It! - Nate Cole On June 22, 2017, 6:20 a.m

Re: Review Request 60358: Hivesevers's status shows issue for the thrift's port conflict, when hiveservers and spark thrift server installed in the same host.

2017-06-22 Thread Nate Cole
-services/SPARK/1.2.1/package/scripts/params.py Lines 152 (patched) <https://reviews.apache.org/r/60358/#comment252807> You will run into problems if this hasn't been defined. I would recommend a default("/...", ) instead. Also can add a test. - Nate Cole O

Re: Review Request 60676: Cluster Effective Version Can Be Cached Incorrectly During an Upgrade

2017-07-06 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60676/#review179812 --- Ship it! Ship It! - Nate Cole On July 6, 2017, 9:42 a.m

Re: Review Request 60745: Allow Services To Be Stopped During an EU Between Stack Vendors

2017-07-10 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60745/#review180069 --- Ship it! Ship It! - Nate Cole On July 10, 2017, 10:31 a.m

Re: Review Request 60810: Expected Values Like original_stack Are Missing On Downgrades

2017-07-12 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60810/#review180333 --- Ship it! Ship It! - Nate Cole On July 12, 2017, 1:32 p.m

Re: Review Request 60878: NPE during "Update Kerberos Descriptor"

2017-07-14 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60878/#review180572 --- Ship it! Ship It! - Nate Cole On July 14, 2017, 3:09 p.m

Re: Review Request 61036: Ambari upgrade should update unique constraints

2017-07-24 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61036/#review181208 --- Ship it! Ship It! - Nate Cole On July 21, 2017, 11:12 a.m

Re: Review Request 60995: Namenode restart - PID file delete happens before the call to check status

2017-07-24 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60995/#review181209 --- Ship it! Ship It! - Nate Cole On July 21, 2017, 11:23 a.m

Re: Review Request 61161: Stack Tools and Feature Should be Ignored in Blueprints

2017-07-26 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61161/#review181486 --- Ship it! Ship It! - Nate Cole On July 26, 2017, 4:31 p.m

Re: Review Request 61146: Replace Hard Coded stack-select Structures

2017-07-27 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61146/#review181578 --- Ship it! Ship It! - Nate Cole On July 26, 2017, 3:04 p.m

Re: Review Request 61206: Ambari Server Setup Code Fails Because of Missing Stack Upgrade

2017-07-28 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61206/#review181658 --- Ship it! Ship It! - Nate Cole On July 28, 2017, 5:01 a.m

Review Request 61266: Function ru_set_all is not working correctly due to changed command structure

2017-07-31 Thread Nate Cole
/upgrades/upgrade_test_HDP-250.xml PRE-CREATION Diff: https://reviews.apache.org/r/61266/diff/1/ Testing --- Manual. Automated pending. Thanks, Nate Cole

Re: Review Request 61266: Function ru_set_all is not working correctly due to changed command structure

2017-07-31 Thread Nate Cole
/upgrade_execute_task_test.xml PRE-CREATION ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_HDP-250.xml PRE-CREATION Diff: https://reviews.apache.org/r/61266/diff/2/ Changes: https://reviews.apache.org/r/61266/diff/1-2/ Testing --- Manual. Automated pending. Thanks, Nate

Re: Review Request 61266: Function ru_set_all is not working correctly due to changed command structure

2017-07-31 Thread Nate Cole
est_ru_set_all.py 8e03b7f26d > > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_execute_task_test.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_HDP-250.xml > PRE-CREATION > > > Diff: https://reviews.apache.org/r/61266/diff/2/ > > > Testing > --- > > Manual. Automated pending. > > > Thanks, > > Nate Cole > >

Re: Review Request 61276: Replace Hard Coded conf-select Structures

2017-08-02 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61276/#review181969 --- Ship it! Ship It! - Nate Cole On Aug. 1, 2017, 10:09 a.m

Re: Review Request 61317: Configs For Target Stack Are Not Created During Upgrade

2017-08-02 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61317/#review181975 --- Ship it! Ship It! - Nate Cole On Aug. 1, 2017, 8:32 p.m

Review Request 61381: When Adding a New Service the Repository ID is Required

2017-08-02 Thread Nate Cole
/ Testing --- Manual. Automated pending. Thanks, Nate Cole

Re: Review Request 61381: When Adding a New Service the Repository ID is Required

2017-08-02 Thread Nate Cole
vel message here just for sanity so we know what > > happened and what we're doing ... Ok - Nate --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61381/#revi

Re: Review Request 61381: When Adding a New Service the Repository ID is Required

2017-08-02 Thread Nate Cole
/ServiceResourceProviderTest.java a0c58eaf34 Diff: https://reviews.apache.org/r/61381/diff/2/ Changes: https://reviews.apache.org/r/61381/diff/1-2/ Testing --- Manual. Automated pending. Thanks, Nate Cole

Re: Review Request 61381: When Adding a New Service the Repository ID is Required

2017-08-02 Thread Nate Cole
] [INFO] Total time: 21:42.473s [INFO] Finished at: Wed Aug 02 14:21:26 EDT 2017 [INFO] Final Memory: 55M/675M [INFO] Thanks, Nate Cole

Re: Review Request 61396: Annotate upgrade packs for scope

2017-08-03 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61396/#review182091 --- Ship it! Ship It! - Nate Cole On Aug. 2, 2017, 10:03 p.m

Review Request 61407: Create VDF and xsd to support MAINT upgrades

2017-08-03 Thread Nate Cole
/version_builder.py 6d1689ac9c Diff: https://reviews.apache.org/r/61407/diff/1/ Testing --- Manual. Automated pending. Thanks, Nate Cole

Review Request 61459: Expose via API whether a service will participate in an upgrade

2017-08-07 Thread Nate Cole
://reviews.apache.org/r/61459/diff/1/ Testing --- Manual. Automated pending. Thanks, Nate Cole

Re: Review Request 61462: Update Orchestration to support MAINT

2017-08-07 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61462/#review182296 --- Ship it! Ship It! - Nate Cole On Aug. 7, 2017, 11:04 a.m

Re: Review Request 61490: Upgrade Pre-Checks Should Take PATCH/SERVICE Types Into Account

2017-08-08 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61490/#review182389 --- Ship it! Ship It! - Nate Cole On Aug. 7, 2017, 11:48 p.m

Review Request 61500: Service Checks Will Run Multiple Times In Patch/Service Upgrades

2017-08-08 Thread Nate Cole
24a3fa2ce2 ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_checks.xml f82b0258de Diff: https://reviews.apache.org/r/61500/diff/1/ Testing --- Manual. Automated pending. Thanks, Nate Cole

Re: Review Request 61500: Service Checks Will Run Multiple Times In Patch/Service Upgrades

2017-08-08 Thread Nate Cole
] Thanks, Nate Cole

Re: Review Request 61500: Service Checks Will Run Multiple Times In Patch/Service Upgrades

2017-08-09 Thread Nate Cole
[INFO] [INFO] Total time: 21:58.183s [INFO] Finished at: Tue Aug 08 11:36:30 EDT 2017 [INFO] Final Memory: 57M/637M [INFO] Thanks, Nate Cole

Review Request 61539: Can't register multiple PATCH versions

2017-08-09 Thread Nate Cole
/internal/VersionDefinitionResourceProviderTest.java a297d945ce Diff: https://reviews.apache.org/r/61539/diff/1/ Testing --- Manual. Automated pending. Thanks, Nate Cole

Re: Review Request 61616: AMBARI-21714. Intermittent unit test failure in ExecutionCommandWrapperTest

2017-08-14 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61616/#review182862 --- Ship it! Ship It! - Nate Cole On Aug. 14, 2017, 7:09 a.m

Re: Review Request 61605: Allow WEB alert accept custom HTTP codes

2017-08-14 Thread Nate Cole
/state/alert/AlertUri.java Lines 36-37 (patched) <https://reviews.apache.org/r/61605/#comment258810> Seems like a Set would be more appropriate - Nate Cole On Aug. 14, 2017, 9:23 a.m., Eugene Chekanskiy wrote: > > ---

Re: Review Request 61453: AMBARI-21634 Make sure Ambari also considers NIS users

2017-08-14 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61453/#review182865 --- Ship it! Ship It! - Nate Cole On Aug. 7, 2017, 6:45 a.m

Review Request 61619: Result of install_packages uses version string instead of repo_version_id

2017-08-14 Thread Nate Cole
--- Manual. Automated pending. Thanks, Nate Cole

Review Request 61623: Blueprint deployments failing without version string

2017-08-14 Thread Nate Cole
6332fbf169 ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java e92a6197f1 Diff: https://reviews.apache.org/r/61623/diff/1/ Testing --- Manual. Automated pending. Thanks, Nate Cole

Re: Review Request 61623: Blueprint deployments failing without version string

2017-08-14 Thread Nate Cole
Memory: 76M/2037M [INFO] Thanks, Nate Cole

Re: Review Request 61622: Begin Using Service Versions In Python stack_feature Code

2017-08-15 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61622/#review182995 --- Ship it! Ship It! - Nate Cole On Aug. 14, 2017, 5:01 p.m

Re: Review Request 61699: Parameterize Maven Surefire Build argLine

2017-08-17 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61699/#review183130 --- Ship it! Ship It! - Nate Cole On Aug. 17, 2017, 8:28 a.m

Re: Review Request 61695: Upgrade Associated Repository is Wrong for Downgrades and Patches

2017-08-17 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61695/#review183133 --- Ship it! Ship It! - Nate Cole On Aug. 16, 2017, 3:09 p.m

Re: Review Request 61660: Service and Patch Upgrade Catalog Changes for 2.6 - additional fixes

2017-08-17 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61660/#review183140 --- Ship it! Ship It! - Nate Cole On Aug. 17, 2017, 6:10 a.m

Review Request 61743: Use latest-vdf for default when version is unspecified

2017-08-18 Thread Nate Cole
E-CREATION ambari-server/src/test/resources/stacks/HDP/2.2.1/repos/repoinfo.xml PRE-CREATION ambari-server/src/test/resources/stacks/HDP/2.2.1/services/RANGER/alerts.json PRE-CREATION Diff: https://reviews.apache.org/r/61743/diff/1/ Testing --- Manual. Automated pending. Thanks, Nate Cole

Review Request 61767: VDF should support redhat-ppc6 and redhat-ppc7 OS types

2017-08-18 Thread Nate Cole
: ambari Description --- Simple xsd change. Diffs - ambari-server/src/main/resources/version_definition.xsd bef3739219 Diff: https://reviews.apache.org/r/61767/diff/1/ Testing --- Manual. Automated pending. Thanks, Nate Cole

Re: Review Request 61746: Prevent New Clusters from Being Provisioned With PATCH/MAINT Repos

2017-08-21 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61746/#review183325 --- Ship it! Ship It! - Nate Cole On Aug. 18, 2017, 9:23 p.m

Re: Review Request 61707: Pre-configure services when Kerberos is enabled to reduce number of core service restarts when services are added

2017-08-21 Thread Nate Cole
/api/services/AmbariMetaInfo.java Line 120 (original), 120-123 (patched) <https://reviews.apache.org/r/61707/#comment259366> I know we traditionally put this stuff in AmbariMetaInfo, but we should be moving this type of stuff into StackModule/StackDirectory. - Nate Cole On Aug. 17, 2

Re: Review Request 61785: When Matching New VDFs for Parent Repos only Consider STANDARD Types

2017-08-21 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61785/#review183355 --- Ship it! Ship It! - Nate Cole On Aug. 21, 2017, 11:54 a.m

<    3   4   5   6   7   8   9   10   11   >