testing - setting timezone in User Settings.
Slider view - application start time.
Tests ran clean for ambari-web
27834 tests complete (42 seconds)
154 tests pending
Tests ran clean for contrib/views/slider
Took 9506ms to run 345 tests. 345 passed, 0 failed.
Thanks,
Sangeeta Ravindran
it:
https://reviews.apache.org/r/47746/#review136003
---
On June 2, 2016, 10:16 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To rep
iew136501
---
On June 7, 2016, 5:23 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
ete (44 seconds)
154 tests pending
Thanks,
Sangeeta Ravindran
iew135491
---
On May 28, 2016, 5:16 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
iew135496
---
On May 28, 2016, 5:16 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
> On May 24, 2016, 12:25 a.m., Jaimin Jetly wrote:
> > Sangeeta Ravindran, Lets please add minified version of moment.js for
> > 2.13.0 version.
Hello Jaimin,
I have attached a new patch with the minified version of moment.js 2.13.0. Can
you please review?
Thanks,
Sangee
54c2df4
Diff: https://reviews.apache.org/r/49204/diff/
Testing
---
Manual testing.
Ran mvn test in ambari-web
28977 tests complete (36 seconds)
154 tests pending
Thanks,
Sangeeta Ravindran
g/r/44504/#review122718
---
On March 8, 2016, 5:50 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
manually.
Thanks,
Sangeeta Ravindran
g/r/45291/#review125277
---
On March 24, 2016, 3:27 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
che.org/r/47599/#review133961
---
On May 19, 2016, 4:02 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
time.
Tests ran clean for ambari-web
27834 tests complete (42 seconds)
154 tests pending
Tests ran clean for contrib/views/slider
Took 9506ms to run 345 tests. 345 passed, 0 failed.
Thanks,
Sangeeta Ravindran
iew133757
---
On May 18, 2016, 3:59 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
class for first column of view instance row to
col-sm-3;padding-left-30
Diffs
-
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
906eef5
Diff: https://reviews.apache.org/r/47539/diff/
Testing
---
Manual testing.
Thanks,
Sangeeta Ravindran
iew145653
---
On Aug. 12, 2016, 3:19 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
ed e-mail. To reply, visit:
https://reviews.apache.org/r/49385/#review140134
---
On June 30, 2016, 8:57 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automaticall
it:
https://reviews.apache.org/r/49393/#review140043
---
On June 29, 2016, 7:31 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:/
iew140804
---
On June 30, 2016, 8:57 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
Thanks,
Sangeeta Ravindran
lete (48 seconds)
154 tests pending
Thanks,
Sangeeta Ravindran
sources/ui/admin-web/app/views/urls/edit.html 1d0ff8c
Diff: https://reviews.apache.org/r/49393/diff/
Testing
---
Manual testing.
Ran mvn test.
Thanks,
Sangeeta Ravindran
ated e-mail. To reply, visit:
https://reviews.apache.org/r/49385/#review140134
---
On June 30, 2016, 8:57 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is a
contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js
df0c684
Diff: https://reviews.apache.org/r/55993/diff/
Testing
---
Manual Testing. Enabling disabling the * button. Ran mvn test.
Thanks,
Sangeeta Ravindran
/var/log/ambari-server/wfmanager-view
Thanks,
Sangeeta Ravindran
server/security/authorization/TestUsers.java
875fd46
Diff: https://reviews.apache.org/r/56503/diff/
Testing
---
Manual testing. Ran mvn test.
Thanks,
Sangeeta Ravindran
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55847/#review162666
---
Ship it!
Ship It!
- Sangeeta Ravindran
On Jan. 23, 2017, 4
Testing
---
Manual testing.
Thanks,
Sangeeta Ravindran
privilege.
Diffs
-
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js
9869d0b
Diff: https://reviews.apache.org/r/55586/diff/
Testing
---
Manual testing
Ran mvn test
Thanks,
Sangeeta Ravindran
/app/views/ambariViews/listTable.html
bc441cd
Diff: https://reviews.apache.org/r/51894/diff/
Testing
---
Manual testing with different types of view instances.
Currently there are no automated tests for ambari-admin.
Thanks,
Sangeeta Ravindran
files/2016/09/14/f1299304-2bad-42d2-8509-831aba536e9a__AMBARI-18378.patch
Thanks,
Sangeeta Ravindran
.
Diffs
-
ambari-web/app/utils/hosts.js e4a437c
Diff: https://reviews.apache.org/r/52396/diff/
Testing
---
Manual testing.
mvn clean test
30366 tests complete (45 seconds)
151 tests pending
There are existing test cases for validation of rackID.
Thanks,
Sangeeta Ravindran
0.75 secs)
Thanks,
Sangeeta Ravindran
iew150875
---
On Sept. 29, 2016, 4:40 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
g/r/52396/#review150877
---
On Sept. 29, 2016, 4:40 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
in diff files list. You were able
> > to build UI without this files ? UI should fail upon building because of
> > declared file that does not exist
>
> Sangeeta Ravindran wrote:
> Hi Aleksandr,
>
> I accidentally missed adding the file when I created th
/2016/10/04/32920075-a5ab-481b-bc47-e1be6b569605__AMBARI-17311.patch
Updated patch with review comments addressed
https://reviews.apache.org/media/uploaded/files/2016/10/04/674db481-c4e0-4afb-98cb-b051d785c710__AMBARI-17311.patch
Thanks,
Sangeeta Ravindran
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52456/#review151148
---
On Oct. 3, 2016, 4:44 p.m., Sangeeta Ravindran wrote:
>
> -
in diff files list. You were able
> > to build UI without this files ? UI should fail upon building because of
> > declared file that does not exist
>
> Sangeeta Ravindran wrote:
> Hi Aleksandr,
>
> I accidentally missed adding the file when I created th
-1f60-4a0c-9a49-0802a21c99fd__AMBARI-18476.patch
Thanks,
Sangeeta Ravindran
> On Sept. 18, 2016, 11:51 a.m., Alexandr Antonenko wrote:
> > Ship It!
>
> Sangeeta Ravindran wrote:
> Thank you Alexandr. Can you please help push the fix?
Thanks Alexandr for pushing
8378.patch
Thanks,
Sangeeta Ravindran
che.org/r/51894/#review149041
---
On Sept. 14, 2016, 6:55 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:/
g/r/51894/#review149364
---
On Sept. 16, 2016, 10:59 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
iew149466
---
On Sept. 16, 2016, 10:59 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
> On Sept. 29, 2016, 5:25 p.m., Alexandr Antonenko wrote:
> > Ship It!
>
> Sangeeta Ravindran wrote:
> Thanks Alexandr. Can you please help push the fix?
>
> Alexandr Antonenko wrote:
> done
Thank you. Closing the r
-ad3240502e7b__AMBARI-18476.patch
Thanks,
Sangeeta Ravindran
: https://reviews.apache.org/r/52455/diff/
Testing
---
Manual testing.
Tests in ambari admin project ran clean.
PhantomJS 1.9.7 (Linux): Executed 86 of 86 SUCCESS (0.771 secs / 0.75 secs)
Thanks,
Sangeeta Ravindran
/52456/diff/
Testing
---
Test cases have been updated to test with the new headers added.
Also did manual testing.
Thanks,
Sangeeta Ravindran
iew151039
---
On Sept. 29, 2016, 4:48 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
it. New patch has been uplaoded.
- Sangeeta
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52455/#review151170
---
On Oct.
iew151168
---
On Oct. 4, 2016, 4:45 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
g/r/52456/#review151944
---
On Oct. 4, 2016, 4:45 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
__AMBARI-18667.patch
Thanks,
Sangeeta Ravindran
24a-4dfa-9a71-2ca31528eb5e__AMBARI-18604.patch
Thanks,
Sangeeta Ravindran
b5d-f157db437624__AMBARI-18600.patch
Thanks,
Sangeeta Ravindran
g/r/53143/#review154163
---
On Oct. 27, 2016, 8:24 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
> On Oct. 9, 2016, 10:39 p.m., Robert Levas wrote:
> > Ship It!
>
> Sangeeta Ravindran wrote:
> Thank you Robert.
> Can you please help push the fix?
>
> Robert Levas wrote:
> Pushed to trunk:
>
> ```
> commit 34c5686c3a0f80
To reply, visit:
https://reviews.apache.org/r/53144/#review153740
---
On Oct. 24, 2016, 5:20 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail.
iew153564
---
On Oct. 21, 2016, 6:28 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
nks,
Sangeeta Ravindran
the update interval of
oss.sonatype.org has elapsed or updates are forced -> [Help 1]
Diffs
-
contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js
ce78e59
Diff: https://reviews.apache.org/r/53103/diff/
Testing
---
Manual tests.
Thanks,
Sangeeta Ravindran
sts.
Thanks,
Sangeeta Ravindran
trib/views/wfmanager/src/main/resources/ui/app/templates/components/job-details.hbs
872cdbb
Diff: https://reviews.apache.org/r/53144/diff/
Testing
---
Manual testing.
Test failures are unrelated to the changes in this patch.
Thanks,
Sangeeta Ravindran
ces/ui/app/templates/components/hdfs-browser.hbs
d3233b6
Diff: https://reviews.apache.org/r/53143/diff/
Testing
---
Manual Testing.
Test failures are not related to the changes in this patch.
Thanks,
Sangeeta Ravindran
r/53075/#review153593
---
On Oct. 21, 2016, 6:28 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> h
/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs
d3233b6
Diff: https://reviews.apache.org/r/53143/diff/
Testing
---
Manual Testing.
Test failures are not related to the changes in this patch.
Thanks,
Sangeeta Ravindran
nks,
Sangeeta Ravindran
e30>
> >
> > Should this one be checking for falsy instead of an exact null ?
same as previous comment. matches is a array.
- Sangeeta
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53075/#review153457
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53788/#review156162
---
Ship it!
Ship It!
- Sangeeta Ravindran
On Nov. 15, 2016, 10
-b144d728ee2d__AMBARI-18476_2.5patch
Thanks,
Sangeeta Ravindran
https://reviews.apache.org/media/uploaded/files/2016/11/16/0d18da03-21c2-4360-90fa-b144d728ee2d__AMBARI-18476_2.5patch
Final patch for ambari trunk
https://reviews.apache.org/media/uploaded/files/2016/11/16/72fbbb65-b7f4-4e7b-bbf8-63cf872cc725__AMBARI-18476_0411.patch
Thanks,
Sangeeta
for 2.5
https://reviews.apache.org/media/uploaded/files/2016/11/16/0d18da03-21c2-4360-90fa-b144d728ee2d__AMBARI-18476_2.5patch
Final patch for ambari trunk
https://reviews.apache.org/media/uploaded/files/2016/11/16/72fbbb65-b7f4-4e7b-bbf8-63cf872cc725__AMBARI-18476_0411.patch
Thanks,
Sangeeta
generated e-mail. To reply, visit:
https://reviews.apache.org/r/52455/#review154910
---
On Nov. 4, 2016, 9:23 a.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automaticall
, it is not
always an error notification.
- Sangeeta
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53103/#review154095
---
iew154096
---
On Oct. 27, 2016, 9:20 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
g/r/53104/#review154241
---
On Oct. 27, 2016, 9:20 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
> On Oct. 28, 2016, 7:09 p.m., DIPAYAN BHOWMICK wrote:
> > Ship It!
>
> Sangeeta Ravindran wrote:
> Thank you Dipayan. Can you please help push the fix?
>
> DIPAYAN BHOWMICK wrote:
> Done, committed to trunk, branch-2.5
Than
-9a49-0802a21c99fd__AMBARI-18476.patch
Patch based on latest code
https://reviews.apache.org/media/uploaded/files/2016/11/04/7fa50e96-c66b-4c5e-9321-13b623ab0710__AMBARI-18476.patch
Thanks,
Sangeeta Ravindran
iew153743
---
On Oct. 27, 2016, 8:24 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
-
contrib/views/slider/pom.xml bb1b150
Diff: https://reviews.apache.org/r/54815/diff/
Testing
---
Manual testing. View execution does not throw execption any more and
application can be added.
Thanks,
Sangeeta Ravindran
by default.
Fix is to set the start record to 0, if the total records is 0.
Diffs
-
contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js
78bc1c9
Diff: https://reviews.apache.org/r/55516/diff/
Testing
---
Manual testing.
Thanks,
Sangeeta Ravindran
the group type has been retrieved by
the REST call.
Diffs
-
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js
aa6af2a
Diff: https://reviews.apache.org/r/55523/diff/
Testing
---
Manual testing.
Ran mvn test.
Thanks,
Sangeeta Ravindran
ps://reviews.apache.org/r/55518/diff/
Testing
---
Manual test.
mvn test
Build failure is unrelated to the change. Also, I could not reproduce the build
failure. The capacity scheduler code compiles cleanly.
Thanks,
Sangeeta Ravindran
n.
Ran mvn test.
Thanks,
Sangeeta Ravindran
b5d-f157db437624__AMBARI-18600.patch
Thanks,
Sangeeta Ravindran
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54314/#review157801
---
Ship it!
Ship It!
- Sangeeta Ravindran
On Dec. 2, 2016, 6
,
Sangeeta Ravindran
-a69e7c1220d2__AMBARI-19206.patch
Thanks,
Sangeeta Ravindran
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58211/#review171157
---
Ship it!
Ship It!
- Sangeeta Ravindran
On April 5, 2017, 3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58423/#review171908
---
Ship it!
Ship It!
- Sangeeta Ravindran
On April 13, 2017, 6
js 4b9ec36
Diff: https://reviews.apache.org/r/58590/diff/1/
Testing
---
Manual Testing.
Added new test cases.
Thanks,
Sangeeta Ravindran
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58371/#review171898
---
Ship it!
Ship It!
- Sangeeta Ravindran
On April 11, 2017, 9
nodes.list namenodes count
is not exactly 2
Diffs
-
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
7e174a7
Diff: https://reviews.apache.org/r/58480/diff/1/
Testing
---
Manual testing.
Thanks,
Sangeeta Ravindran
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58534/#review172360
---
Ship it!
Ship It!
- Sangeeta Ravindran
On April 19, 2017, 4
ed patch based on your
suggestion and will attach it shortly.
- Sangeeta
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58590/#review172549
-----
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57346/#review168488
---
Ship it!
Ship It!
- Sangeeta Ravindran
On March 8, 2017, 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57168/#review168317
---
Ship it!
Ship It!
- Sangeeta Ravindran
On March 8, 2017, 5
/components/search-table.js
5f92d6f
Diff: https://reviews.apache.org/r/57429/diff/1/
Testing
---
Manual Tessting.
Build failure is unrelated.
Thanks,
Sangeeta Ravindran
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57709/#review169575
---
Ship it!
Ship It!
- Sangeeta Ravindran
On March 16, 2017
1 - 100 of 130 matches
Mail list logo
