---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50354/#review143267
---
Ship it!
Ship It!
- Sid Wagle
On July 22, 2016, 8:24 p.m
s as a separate 3.0 Jira.
- Sid Wagle
On July 22, 2016, 8:08 p.m., Aravindan Vijayan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
/ambari-metrics-collector
f75a8e5
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_service.py
eb1b6d7
Diff: https://reviews.apache.org/r/50203/diff/
Testing
---
Manually verified
Thanks,
Sid Wagle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49891/#review142757
---
Ship it!
Ship It!
- Sid Wagle
On July 19, 2016, 10:54 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50167/#review142664
---
Ship it!
Ship It!
- Sid Wagle
On July 18, 2016, 11:10 p.m
/ConfigHelper.java
(line 133)
<https://reviews.apache.org/r/49891/#comment208265>
Have you considered using a ConcurrentHashMap instead?
With these changes do we still need STALE_CONFIGS_CACHE_EXPIRATION_TIME ? This
expiration itself was a workaround for similar/same issue.
- Sid Wagle
O
nt about why it is on a separate thread is still relevant.
- Sid Wagle
On July 15, 2016, 10:26 a.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
> On July 15, 2016, 5:03 p.m., Sid Wagle wrote:
> > Ship It!
>
> Sid Wagle wrote:
> General question: Any reason why we started to see this now? Is it
> possible the postgres verion 9.2 does not suffer from this? We seem to be
> still installing postgresql-serve
> On July 15, 2016, 5:03 p.m., Sid Wagle wrote:
> > Ship It!
General question: Any reason why we started to see this now? Is it possible the
postgres verion 9.2 does not suffer from this? We seem to be still installing
postgresql-server-8.4.20-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50079/#review142395
---
Ship it!
Ship It!
- Sid Wagle
On July 15, 2016, 3:56 p.m
/server/applicationhistoryservice/metrics/timeline/availability/MetricCollectorHAController.java
84e4153
Diff: https://reviews.apache.org/r/50059/diff/
Testing
---
Unit test passed.
Thanks,
Sid Wagle
/availability/MetricCollectorHAController.java
84e4153
Diff: https://reviews.apache.org/r/50059/diff/
Testing
---
Unit test passed.
Thanks,
Sid Wagle
r/50048/diff/
Testing
---
Manually verified.
--
Ran 12 tests in 0.023s
OK
--
Total run:12
Total errors:0
Total failures:0
OK
Thanks,
Sid Wagle
/metrics/timeline/availability/MetricCollectorHAControllerTest.java
91ec305
Diff: https://reviews.apache.org/r/50045/diff/
Testing
---
Manually verified.
Unit test pass.
Thanks,
Sid Wagle
-services/AMBARI_METRICS/0.1.0/package/scripts/split_points.py
(line 108)
<https://reviews.apache.org/r/49995/#comment207806>
Can you leave a comment of 15% implicity give to MRM, not clear if you look
at the percentages.
- Sid Wagle
On July 14, 2016, 5:59 p.m., Aravindan Vijayan
splits as well since it is
a bigger table.
- Sid Wagle
On July 13, 2016, 10:58 p.m., Aravindan Vijayan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49971/#review142133
---
Ship it!
Ship It!
- Sid Wagle
On July 13, 2016, 10:24 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49735/#review142126
---
Ship it!
Ship It!
- Sid Wagle
On July 6, 2016, 11:45 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49786/#review141829
---
Ship it!
Ship It!
- Sid Wagle
On July 11, 2016, 8:14 p.m
/49786/#comment206972>
No unit testing of same metric multiple functions ?
- Sid Wagle
On July 8, 2016, 6:26 a.m., Aravindan Vijayan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48628/#review140861
---
Ship it!
Ship It!
- Sid Wagle
On July 5, 2016, 4:38 a.m
/stack_advisor.py
(line 1476)
<https://reviews.apache.org/r/49590/#comment206204>
Based on this impl, we would get 1 warning at a time vs getting all dir
with issues. Is this pattern consistent with other validations?
- Sid Wagle
On July 5, 2016, 2:38 p.m., Andrew Onischuk
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49590/#review140798
---
Ship it!
Ship It!
- Sid Wagle
On July 5, 2016, 2:38 p.m
group.
- Sid Wagle
On July 1, 2016, 3:32 p.m., Dmytro Sen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49514/
>
gt;
So both old and new properties are ok to be present at the same time?
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/ui_server.py
(line 96)
<https://reviews.apache.org/r/49514/#comment205761>
No check for stack name?
- Sid Wagle
On July 1,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49513/#review140369
---
Ship it!
Ship It!
- Sid Wagle
On July 1, 2016, 3:26 p.m
c/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
(line 460)
<https://reviews.apache.org/r/49513/#comment205753>
Consider rename to splitHostnamesInBatches.
- Sid Wagle
On July 1, 2016, 3:16 p.m., Dmyt
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49291/#review140069
---
Ship it!
Ship It!
- Sid Wagle
On June 29, 2016, 9:43 p.m
deCatalog240.java
(line 1749)
<https://reviews.apache.org/r/49291/#comment205272>
Is this reachable ?
- Sid Wagle
On June 28, 2016, 8:11 p.m., Nahappan Somasundaram wrote:
>
> ---
> This is an automatically gen
be change to use the
comma separated host:port field.
- Sid Wagle
On June 13, 2016, 10:24 a.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
> On June 28, 2016, 1:28 a.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java,
> > line 1650
> > <https://reviews.apache.org/r/49291/diff/1/?file=1431345#file1431345line1650>
> >
> > Should
ent205040>
Should probably make a less generic name. Also, shouldn't we allow any
component auto-start to be specified?
- Sid Wagle
On June 28, 2016, 12:24 a.m., Nahappan Somasundaram wrote:
>
> ---
> This is an automatic
> On June 27, 2016, 11:16 p.m., Sid Wagle wrote:
> > Ship It!
The Jira title does not correctly describe the intended fix.
- Sid
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.or
/controller/AmbariCustomCommandExecutionHelper.java
(line 985)
<https://reviews.apache.org/r/49241/#comment204787>
syntax issue : commandRetryDurationInt
- Sid Wagle
On June 27, 2016, 3:30 a.m., Sumit Mohanty
with no additional side-effect.
- Sid Wagle
On June 1, 2016, 7 p.m., Miklos Gergely wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48065/#review136413
---
Ship it!
- Sid Wagle
On June 3, 2016, 12:43 a.m., Jungtaek
> On June 7, 2016, 6:07 a.m., Sid Wagle wrote:
> > Changes look good, only thing to consider is the changes to the metric
> > name. Cluster Aggregation will not occur at topology level since appId =
> > topologyName for metrics with the same metric name. Is the metric name
/47747/diff/
Testing
---
All unit tests pass.
Thanks,
Sid Wagle
since such code path is non-existent.
- Sid Wagle
On May 19, 2016, 10:04 p.m., Nahappan Somasundaram wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47565/#review134377
---
Ship it!
Ship It!
- Sid Wagle
On May 19, 2016, 10:04 p.m
> On May 23, 2016, 3:49 p.m., Sid Wagle wrote:
> > Ship It!
Pushed to trunk on behalf on Qin Liu, REview can be closed. Thanks.
- Sid
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.or
tps://reviews.apache.org/r/47730/#comment199155>
This will collide due to Hadoop dependency in version 14.0.1, I faced a
problem here before. Can we make this shaded ?
- Sid Wagle
On May 23, 2016, 3:48 p.m., Dmytro Sen
/0.1.0/configuration/ams-site.xml
(line 557)
<https://reviews.apache.org/r/47595/#comment198740>
Any reason for chosing 3 seconds vs 5 ?
- Sid Wagle
On May 19, 2016, 2:43 p.m., Dmytro Sen wrote:
>
> ---
> This is a
site.xml
(line 557)
<https://reviews.apache.org/r/47595/#comment198739>
Units should be clear from name or description of property.
- Sid Wagle
On May 19, 2016, 2:43 p.m., Dmytro Sen wrote:
>
> ---
> This is an automatically
> On May 17, 2016, 1:52 a.m., Sid Wagle wrote:
> > Just realized I am missing UpgradeCatalog changes, will add subsequent
> > patch.
No need for upgrade steps since the Catalog deletes all standard deviation
alerts which get added back on server r
/takeover_files_mapping.json (line 2)
<https://reviews.apache.org/r/47456/#comment198178>
Lets add this for ams-hbase-env, ams-hbase-log4j,
- Sid Wagle
On May 17, 2016, 2:16 p.m., Andrew Onischuk wrote:
>
> ---
> This is an automatically g
subsequent patch.
- Sid Wagle
On May 17, 2016, 12:51 a.m., Sid Wagle wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
6.682s
OK
--
Total run:1016
Total errors:0
Total failures:0
OK
Thanks,
Sid Wagle
l errors:0
Total failures:0
OK
Thanks,
Sid Wagle
run:1016
Total errors:0
Total failures:0
OK
Thanks,
Sid Wagle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43126/#review133450
---
What about RCA tables not a part of Ambari DB ?
- Sid Wagle
---
--
Ran 261 tests in 6.699s
OK
--
Total run:1016
Total errors:0
Total failures:0
OK
Thanks,
Sid Wagle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47244/#review133281
---
Ship it!
Ship It!
- Sid Wagle
On May 13, 2016, 8:23 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47369/#review133280
---
Ship it!
Ship It!
- Sid Wagle
On May 13, 2016, 10:17 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46661/#review132801
---
Ship it!
Ship It!
- Sid Wagle
On May 11, 2016, 11:31 p.m
/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
(line 395)
<https://reviews.apache.org/r/47244/#comment196961>
Why not keep the same thread and just submit task to it?
- Sid Wagle
On May 11, 2016, 5 p.m., Aravindan Vijayan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47235/#review132667
---
Ship it!
Ship It!
- Sid Wagle
On May 11, 2016, 1:54 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47142/#review132514
---
Ship it!
Ship It!
- Sid Wagle
On May 10, 2016, 6:41 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47147/#review132490
---
Ship it!
Ship It!
- Sid Wagle
On May 10, 2016, 12:41 a.m
> On May 10, 2016, 12:27 a.m., Sid Wagle wrote:
> > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java,
> > line 308
> > <https://reviews.apache.org/r/47
opNCondition.java
(line 146)
<https://reviews.apache.org/r/47142/#comment196543>
Add javadoc for method
- Sid Wagle
On May 9, 2016, 11:50 p.m., Aravindan Vijayan wrote:
>
> ---
> This is an automatically generated e-mail. To
? Unless we are
always creating CG with configs and no hosts and then update request with hosts.
- Sid Wagle
On May 5, 2016, 3:55 p.m., Sebastian Toader wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46898/#review131440
---
Ship it!
Awesome !! We definetly needed this.
- Sid Wagle
based deploy with 0 hosts
added to the cluster and thereby it might be possible to have no requests
created. Not sure if it is relevant to this change though.
- Sid Wagle
On April 29, 2016, 11:08 p.m., Nate Cole wrote
364004#file1364004line92>
> >
> > Typically how long is the delay after which it will throw the exception.
10 seconds.
- Sid
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46703/#review130881
---
Ship it!
Ship It!
- Sid Wagle
On April 26, 2016, 3:13 p.m
/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java
ce865cf
Diff: https://reviews.apache.org/r/46751/diff/
Testing
---
Added a unit test. Manually verified the patch works on a cluster.
Thanks,
Sid Wagle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46714/#review130710
---
Ship it!
Ship It!
- Sid Wagle
On April 26, 2016, 10:03 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46602/#review130292
---
Ship it!
Ship It!
- Sid Wagle
On April 24, 2016, 4:40 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46508/#review129945
---
Ship it!
Ship It!
- Sid Wagle
On April 21, 2016, 7:10 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46496/#review129926
---
Ship it!
Ship It!
- Sid Wagle
On April 21, 2016, 3:51 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46500/#review129923
---
Ship it!
Ship It!
- Sid Wagle
On April 21, 2016, 5:01 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43926/#review129829
---
Ship it!
Ship It!
- Sid Wagle
On April 20, 2016, 6:45 p.m
/scripts/export_ams_metrics.py (line 140)
<https://reviews.apache.org/r/45739/#comment193285>
Better to set seriesStartTime = valid timstamp like now.
- Sid Wagle
On April 20, 2016, 1:44 p.m., Andrew Onischuk
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46413/#review129634
---
Ship it!
Ship It!
- Sid Wagle
On April 19, 2016, 10:08 p.m
--
Ran 246 tests in 6.541s
OK
--
Total run:928
Total errors:0
Total failures:0
OK
Thanks,
Sid Wagle
pdates tomorrow.
- Sid
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46355/#review129475
---
On April 19, 2016, 12:26 a.m.,
46355/diff/
Testing
---
--
Ran 246 tests in 6.541s
OK
--
Total run:928
Total errors:0
Total failures:0
OK
Thanks,
Sid Wagle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46342/#review129445
---
Ship it!
Ship It!
- Sid Wagle
On April 18, 2016, 10:24 p.m
/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
(line 354)
<https://reviews.apache.org/r/46342/#comment192850>
This Exception is dangerous to be thrown from the Sink is not handled by
the caller. We should be logging the exceotion and moving on.
- Sid Wagle
On Ap
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46137/#review129382
---
Ship it!
Ship It!
- Sid Wagle
On April 18, 2016, 5:39 p.m
(line 67)
<https://reviews.apache.org/r/46137/#comment192809>
It should not take long enough for upgrade to execute that will allow
remote debugging, don't you want a configurable supend action so JVM will pause
sufficiently ?
- Sid Wagle
On April 18, 2016, 5:14 p.m., Nahappan Somasu
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
> e5758bf
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2
> 6f32000
>
> Diff: https://reviews.apache.org/r/46238/diff/
>
>
> Testing
> ---
>
> All metrics Unit tests passed.
>
>
> Thanks,
>
> Sid Wagle
>
>
-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
e5758bf
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2
6f32000
Diff: https://reviews.apache.org/r/46238/diff/
Testing
---
All metrics Unit tests passed.
Thanks,
Sid Wagle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46218/#review128968
---
Ship it!
Ship It!
- Sid Wagle
On April 14, 2016, 7:27 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46219/#review128967
---
Ship it!
Ship It!
- Sid Wagle
On April 14, 2016, 7:40 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46047/#review128258
---
Ship it!
Ship It!
- Sid Wagle
On April 11, 2016, 9:32 p.m
ile.
- Sid
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45904/#review128100
---
On April 8, 2016, 8:56 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45980/#review128010
---
Ship it!
Ship It!
- Sid Wagle
On April 9, 2016, 4:46 p.m
r.
All alert unit test passed.
mvn clean test -Dtest=Alert* -Drat.ignoreErrors -DfailIfNoTests=false
Thanks,
Sid Wagle
his is a very dangerous query. This can literally return 10,000
> > entries.
>
> Sid Wagle wrote:
> Thanks for pointing that out, I will explore an explicit join query as a
> workaround to offload it back to the DB.
> For the issue regarding reccurence of this situa
n the system tests for the use case of delete cluster, etc.
- Sid
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45904/#review127772
-----------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45904/#review127728
---
On April 7, 2016, 11:34 p.m., Sid Wagle wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45845/#review127695
---
Ship it!
Ship It!
- Sid Wagle
On April 7, 2016, 8:21 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45846/#review127694
---
Ship it!
Ship It!
- Sid Wagle
On April 7, 2016, 11:38 p.m
99e
Diff: https://reviews.apache.org/r/45904/diff/
Testing
---
Manually verified on 1 node repro cluster.
All alert unit test passed.
mvn clean test -Dtest=Alert* -Drat.ignoreErrors -DfailIfNoTests=false
Thanks,
Sid Wagle
est passed.
mvn clean test -Dtest=Alert* -Drat.ignoreErrors -DfailIfNoTests=false
Thanks,
Sid Wagle
test=Alert* -Drat.ignoreErrors -DfailIfNoTests=false
Thanks,
Sid Wagle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45845/#review127512
---
Ship it!
Ship It!
- Sid Wagle
On April 6, 2016, 11:39 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45845/#review127511
---
No unit test changes ?
- Sid Wagle
On April 6, 2016, 11:39 p.m
401 - 500 of 513 matches
Mail list logo
