Re: Review Request 52554: AMBARI-18527 HostCleanup.py to be able to resolve wildcards in a dir or file path to a list of dirs and files

2016-10-05 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52554/#review151506 --- Ship it! Ship It! - Tim Thorpe On Oct. 5, 2016, 2:46 p.m

Review Request 52223: AMBARI-18051 - Services should be able to provide their own pre-req checks by supplying a jar file

2016-09-23 Thread Tim Thorpe
,StackManagerExtensionTest,ServiceModuleTest,StackManagerCommonServicesTest,StackManagerTest,StackManagerMiscTest Thanks, Tim Thorpe

Re: Review Request 51724: Add Kerberos HTTP SPNEGO authentication support to Ambari Metrics Monitor

2016-09-22 Thread Tim Thorpe
> On Sept. 22, 2016, 7:54 p.m., Robert Levas wrote: > > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py, > > lines 119-120 > > > > > > These shoud not be hardcoded. The aths to

Re: Review Request 51360: AMBARI-17999 Typo in property name "yarn.nodemanager.log.retain-second", should be "seconds"

2016-08-26 Thread Tim Thorpe
> On Aug. 24, 2016, 1:20 p.m., Tim Thorpe wrote: > > Ship It! > > Ying Zhang wrote: > Thanks Tim for the quick review. Would you please help to commit it when > you're available? It has been committed please close the review board and the

Re: Review Request 52260: AMBARI-18459: Print error messages if bulkcommand section of a component includes non-existing component

2016-09-27 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52260/#review150542 --- Ship it! Ship It! - Tim Thorpe On Sept. 26, 2016, 2:26 p.m

Re: Review Request 52457: Categorize unit tests so can run mvn test -P $PROFILE

2016-10-03 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52457/#review151161 --- Ship it! Ship It! - Tim Thorpe On Sept. 30, 2016, 11:10 p.m

Re: Review Request 52423: AMBARI-18499 Ability to remove broken symbolic links via HostCleanup.py

2016-09-30 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52423/#review151058 --- Ship it! Ship It! - Tim Thorpe On Sept. 30, 2016, 2:29 p.m

Review Request 53200: AMBARI-18686 - Falcon user shouldn't be added to Oozie admin list if Falcon is not installed

2016-10-26 Thread Tim Thorpe
n test Added 2 new test cases to test for falcon being installed and falcon not being installed Thanks, Tim Thorpe

Review Request 53265: AMBARI-18729 - Add PDF version of stack, extension and service definitions

2016-10-28 Thread Tim Thorpe
. The patch file is pretty useless. Diffs - contrib/doc/Apache_Ambari_Stack_Definition.pdf PRE-CREATION Diff: https://reviews.apache.org/r/53265/diff/ Testing --- None but had the document reviewed. Thanks, Tim Thorpe

Re: Review Request 53649: AMBARI-18838: Remove references to ganglias and nagios in Ambari agent source code

2016-11-10 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53649/#review155596 --- Ship it! Ship It! - Tim Thorpe On Nov. 10, 2016, 3:33 p.m

Re: Review Request 52876: AMBARI-18588 Ambari server should not crash with NPE when parsing HTTP response for YARN RM properties

2016-10-14 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52876/#review152680 --- Ship it! Ship It! - Tim Thorpe On Oct. 14, 2016, 2:44 p.m

Review Request 52885: AMBARI-18594 - AMBARI-18051 Breaks Stack Upgrade Checks

2016-10-14 Thread Tim Thorpe
ode modifications to first catch the ParentObjectNotFoundException without other code changes then I corrected the code to use the source stack version instead of the upgrade pack target. Thanks, Tim Thorpe

Re: Review Request 53086: AMBARI-18657 - Slider always creates storm slider conf directory

2016-10-21 Thread Tim Thorpe
/package/scripts/slider.py 406d076 Diff: https://reviews.apache.org/r/53086/diff/ Testing --- mvn clean test and installing with and without the storm slider client RPM. Thanks, Tim Thorpe

Re: Review Request 53086: AMBARI-18657 - Slider always creates storm slider conf directory

2016-10-21 Thread Tim Thorpe
RPM. Thanks, Tim Thorpe

Review Request 53086: AMBARI-18657 - Slider always creates storm slider conf directory

2016-10-21 Thread Tim Thorpe
://reviews.apache.org/r/53086/diff/ Testing --- mvn clean test and installing with and without the storm slider client RPM. Thanks, Tim Thorpe

Re: Review Request 54086: AMBARI-18987 A general preupgrade check on if services cannot be upgrade are installed

2016-11-25 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54086/#review156934 --- Ship it! Ship It! - Tim Thorpe On Nov. 25, 2016, 6:49 p.m

Re: Review Request 53958: AMBARI-18934 - Management packs should be able to link grafana dashboards and service metrics for custom services

2016-11-21 Thread Tim Thorpe
PRE-CREATION ambari-server/src/test/python/uninstall/stacks/2.0/files/metainfo1.xml PRE-CREATION ambari-server/src/test/python/uninstall/stacks/2.0/files/metainfo2.xml PRE-CREATION Diff: https://reviews.apache.org/r/53958/diff/ Testing --- mvn clean test Thanks, Tim Thorpe

Re: Review Request 53958: AMBARI-18934 - Management packs should be able to link grafana dashboards and service metrics for custom services

2016-11-21 Thread Tim Thorpe
/python/uninstall/stacks/2.0/files/metainfo2.xml PRE-CREATION Diff: https://reviews.apache.org/r/53958/diff/ Testing --- mvn clean test Thanks, Tim Thorpe

Review Request 53958: AMBARI-18934 - Management packs should be able to link grafana dashboards and service metrics for custom services

2016-11-21 Thread Tim Thorpe
/uninstall/stacks/2.0/files/metainfo1.xml PRE-CREATION ambari-server/src/test/python/uninstall/stacks/2.0/files/metainfo2.xml PRE-CREATION Diff: https://reviews.apache.org/r/53958/diff/ Testing --- mvn clean test Thanks, Tim Thorpe

Re: Review Request 54028: AMBARI-18962:Make check_package_condition in script.py overridable by services in stacks

2016-11-23 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54028/#review156747 --- Ship it! Ship It! - Tim Thorpe On Nov. 23, 2016, 3:35 p.m

Review Request 53984: AMBARI-18958 - License file issue with src/test/resources/stacks/HDP/2.2.0/services/GANGLIA/upgrades/HDP/rolling-upgrade.xml

2016-11-22 Thread Tim Thorpe
/rolling-upgrade.xml c2224dd Diff: https://reviews.apache.org/r/53984/diff/ Testing --- mvn clean test Thanks, Tim Thorpe

Re: Review Request 40082: AMBARI-9363: role_command_order.json should not be at stack level

2016-11-22 Thread Tim Thorpe
eviews.apache.org/r/40082/#review107839 ------- On Nov. 9, 2015, 3:47 p.m., Tim Thorpe wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 54028: AMBARI-18962:Make check_package_condition in script.py overridable by services in stacks

2016-11-24 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54028/#review156870 --- Ship it! Ship It! - Tim Thorpe On Nov. 24, 2016, 9:18 p.m

Re: Review Request 54123: AMBARI-18992: Stack version input text field on Register Version page should align properly even when resizing the page

2016-11-28 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54123/#review157025 --- Ship it! Ship It! - Tim Thorpe On Nov. 28, 2016, 1:40 p.m

Re: Review Request 54028: AMBARI-18962:Make check_package_condition in script.py overridable by services in stacks

2016-11-28 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54028/#review157138 --- Ship it! Ship It! - Tim Thorpe On Nov. 28, 2016, 9:04 p.m

Re: Review Request 53678: AMBARI-18846 - Custom services should be able to easily specify their own dashboards

2016-11-15 Thread Tim Thorpe
gt; > Can we avoid code dup here by making it a common datastructure? > > Sid Wagle wrote: > Sorry for the late review on this, maybe you could address this in some > other patch, not a significant issue. > > Tim Thorpe wrote: > Hi Sid, I'll fix this in a separat

Re: Review Request 53678: AMBARI-18846 - Custom services should be able to easily specify their own dashboards

2016-11-15 Thread Tim Thorpe
/dashboards/grafana-dashboards and resources/dashboards/service-metrics respectively, verified they were sync'd to the agents and the dashboards appeared on the grafana UI. Thanks, Tim Thorpe

Re: Review Request 53673: AMBARI-18852 HostCleanup.py to be able to stop processes owned by users or java processes

2016-11-15 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53673/#review155924 --- Ship it! Ship It! - Tim Thorpe On Nov. 15, 2016, 2:04 p.m

Re: Review Request 53798: AMBARI-18902 Minor typo fix in TimeliveMetricsStore class in AMS

2016-11-16 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53798/#review156050 --- Ship it! Ship It! - Tim Thorpe On Nov. 15, 2016, 10:33 p.m

Review Request 53808: AMBARI-18905 - Management pack purge option should support extensions

2016-11-16 Thread Tim Thorpe
: https://reviews.apache.org/r/53808/diff/ Testing --- mvn clean test -Dtest=StackManagerTest Total run:1163 Total errors:0 Total failures:0 Thanks, Tim Thorpe

Re: Review Request 53673: AMBARI-18852 HostCleanup.py to be able to stop processes owned by users or java processes

2016-11-11 Thread Tim Thorpe
158) <https://reviews.apache.org/r/53673/#comment225792> Should be pids owned by. Original is missing the 'n' - Tim Thorpe On Nov. 11, 2016, 3:50 p.m., Di Li wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 53678: AMBARI-18846 - Custom services should be able to easily specify their own dashboards

2016-11-14 Thread Tim Thorpe
test -Dtest=HostResourceProviderTest Manually added custom service dashboard and metrics to resources/dashboards/grafana-dashboards and resources/dashboards/service-metrics respectively, verified they were sync'd to the agents and the dashboards appeared on the grafana UI. Thanks, Tim Thorpe

Re: Review Request 53673: AMBARI-18852 HostCleanup.py to be able to stop processes owned by users or java processes

2016-11-14 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53673/#review155829 --- Ship it! Ship It! - Tim Thorpe On Nov. 11, 2016, 4:33 p.m

Re: Review Request 53678: AMBARI-18846 - Custom services should be able to easily specify their own dashboards

2016-11-14 Thread Tim Thorpe
l fix this in a separate JIRA. Good catch. - Tim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53678/#review155838 --------

Re: Review Request 53273: Not able to change the default port ambari server listens to

2016-11-01 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53273/#review154388 --- Ship it! Ship It! - Tim Thorpe On Nov. 1, 2016, 5:39 a.m

Review Request 53346: AMBARI-18765 - Services with invalid themes hang the UI when you attempt to add them

2016-11-01 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53346/ --- Review request for Ambari, Di Li and Jayush Luniya. Bugs: AMBARI-18765

Re: Review Request 53416: AMBARI-18746: Sqoop parameter hadoop_home is pointed to incorrect path in params_linux.py

2016-11-03 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53416/#review154705 --- Ship it! Ship It! - Tim Thorpe On Nov. 3, 2016, 1:09 a.m

Re: Review Request 53346: AMBARI-18765 - Services with invalid themes hang the UI when you attempt to add them

2016-11-03 Thread Tim Thorpe
2.4.2, 2.5 and trunk. - Tim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53346/#review154748 --- On Nov. 1, 2016, 6:47 p

Re: Review Request 53273: Not able to change the default port ambari server listens to

2016-10-31 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53273/#review154262 --- Ship it! Ship It! - Tim Thorpe On Oct. 28, 2016, 9:46 p.m

Review Request 54171: AMBARI-19018 - Services should be able to specify their own resources subdirs for sync'ing to agents

2016-11-29 Thread Tim Thorpe
: mvn clean test Thanks, Tim Thorpe

Re: Review Request 54543: AMBARI-19140 Ambari Server symbolic links has double // when root dir is just /

2016-12-08 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54543/#review158558 --- Ship it! Ship It! - Tim Thorpe On Dec. 8, 2016, 7:42 p.m

Re: Review Request 54675: AMBARI-19178 HostCleanup can't list process details on RHEL7

2016-12-13 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54675/#review159046 --- Ship it! Ship It! - Tim Thorpe On Dec. 12, 2016, 9:11 p.m

Re: Review Request 54665: AMBARI-19156 Install Packages fails with the old stack has services removed in the new stack

2016-12-14 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54665/#review159182 --- Ship it! Ship It! - Tim Thorpe On Dec. 13, 2016, 10:38 p.m

Re: Review Request 54665: AMBARI-19156 Install Packages fails with the old stack has services removed in the new stack

2016-12-12 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54665/#review158872 --- Ship it! Ship It! - Tim Thorpe On Dec. 12, 2016, 4:31 p.m

Re: Review Request 54874: AMBARI-19241 - Ambari python scripts should support hdfs download

2017-01-11 Thread Tim Thorpe
es thie curl command work when Kerberos / SSL is being used? Should > > you instead use curl_krb_request? > > Tim Thorpe wrote: > This is the same curl command which has been used for creating files in > HDFS, upload, querying the file status, etc... > I would assu

Re: Review Request 54874: AMBARI-19241 - Ambari python scripts should support hdfs download

2017-01-11 Thread Tim Thorpe
ps://reviews.apache.org/r/54874/#review161127 ----------- On Dec. 19, 2016, 9:24 p.m., Tim Thorpe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54874/ > -

Review Request 55460: AMBARI-19470 - Error in ru_execute_tasks.py - Logger has no attribute 'warn'

2017-01-12 Thread Tim Thorpe
rc/main/resources/custom_actions/scripts/ru_execute_tasks.py 8e526c5 Diff: https://reviews.apache.org/r/55460/diff/ Testing --- mvn clean test Thanks, Tim Thorpe

Re: Review Request 55481: Downgrade executes section if is not defined

2017-01-13 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55481/#review161508 --- Ship it! Ship It! - Tim Thorpe On Jan. 13, 2017, 1:42 a.m

Re: Review Request 55387: AMBARI-19446: Able to skip writing configuration files when the config type doesn't exist in the command JSON file

2017-01-10 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55387/#review161100 --- Ship it! Ship It! - Tim Thorpe On Jan. 10, 2017, 7 p.m., Di

Re: Review Request 54145: EU to message users to start YARN queues if work preserving recovery is disabled

2016-11-29 Thread Tim Thorpe
/nonrolling-upgrade-2.3.xml (line 41) <https://reviews.apache.org/r/54145/#comment227775> Shouldn't you change the message now that you only show it when work preserving recovery is not enabled? Also the message for the start can avoid the "if you stopped them" part. - Tim Tho

Re: Review Request 54121: AMBARI-18929 : Yarn service check fails when either resource manager is down in HA enabled cluster

2016-11-30 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54121/#review157397 --- Ship it! Ship It! - Tim Thorpe On Nov. 29, 2016, 3:56 a.m

Re: Review Request 54145: EU to message users to start YARN queues if work preserving recovery is disabled

2016-11-30 Thread Tim Thorpe
.3.xml (line 420) <https://reviews.apache.org/r/54145/#comment227999> Duplicates? With this section, do you really need the following section as well: UPGRADE Please start previously stopped YARN queues. - Tim Thorpe

Re: Review Request 54145: EU to message users to start YARN queues if work preserving recovery is disabled

2016-12-01 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54145/#review157583 --- Ship it! Ship It! - Tim Thorpe On Nov. 30, 2016, 11:54 p.m

Re: Review Request 55345: AMBARI-19406: Provide default value for hbase java io tmp dir

2017-01-09 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55345/#review160906 --- Ship it! Ship It! - Tim Thorpe On Jan. 9, 2017, 5:12 p.m

Re: Review Request 55344: AMBARI-19407: Provide default values for oozie nproc_limit and nofile_limit configuration

2017-01-09 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55344/#review160907 --- Ship it! Ship It! - Tim Thorpe On Jan. 9, 2017, 5:10 p.m

Review Request 54908: AMBARI-19258 - Extension directories are not properly sync'd to agent nodes

2016-12-20 Thread Tim Thorpe
. Thanks, Tim Thorpe

Re: Review Request 54864: AMBARI-19225 Ambari server should prints error messages to its log if it can't find property for given property attribute type

2016-12-19 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54864/#review159621 --- Ship it! Ship It! - Tim Thorpe On Dec. 19, 2016, 4:58 p.m

Re: Review Request 54994: Enable alert scripts from stack extensions

2016-12-22 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54994/#review160011 --- Ship it! Ship It! - Tim Thorpe On Dec. 22, 2016, 8:59 p.m

Re: Review Request 54815: Exception when running Slider view - java.lang.NoClassDefFoundError: org/apache/hadoop/yarn/api/protocolrecords/GetLabelsToNodesResponse

2016-12-19 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54815/#review159598 --- Ship it! Ship It! - Tim Thorpe On Dec. 17, 2016, 12:31 a.m

Review Request 54874: AMBARI-19241 - Ambari python scripts should support hdfs download

2016-12-19 Thread Tim Thorpe
and directories both when they existed locally and when they didn't. Thanks, Tim Thorpe

Re: Review Request 54872: AMBARI-19226 Provide default value for hdfs_tmp_dir parameter in HDFS params script.

2016-12-19 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54872/#review159651 --- Ship it! Ship It! - Tim Thorpe On Dec. 19, 2016, 7:52 p.m

Re: Review Request 54450: AMBARI-19114 Update hardcoded stack version warning to be more general than saying hdp

2016-12-06 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54450/#review158242 --- Ship it! Ship It! - Tim Thorpe On Dec. 6, 2016, 10:18 p.m

Re: Review Request 54902: AMBARI-19247 Add log to stack_select for details on which role to get version info

2016-12-20 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54902/#review159725 --- Ship it! Ship It! - Tim Thorpe On Dec. 20, 2016, 4:10 p.m

Re: Review Request 57686: AMBARI-20472 MapRed History server start does not create directories in HDFS when WEBHDFS is disabled.

2017-03-27 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57686/#review170183 --- Ship it! Ship It! - Tim Thorpe On March 20, 2017, 3:05 p.m

Re: Review Request 57917: AMBARI-20546 EU/RU service check should skip services that do not have config types

2017-03-27 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57917/#review170217 --- Ship it! Ship It! - Tim Thorpe On March 27, 2017, 8:09 p.m

Re: Review Request 57674: AMBARI-20461 override_uid should set to false when upgrading Ambari 2.1 to 2.2 or newer with custom stacks

2017-03-27 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57674/#review170155 --- Ship it! Ship It! - Tim Thorpe On March 23, 2017, 8:46 p.m

Re: Review Request 57579: AMBARI-20400 Yarn should not copy Tez and Slider tar ball if Tez and Sliders are not installed on the cluster

2017-03-30 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57579/#review170563 --- Ship it! Ship It! - Tim Thorpe On March 30, 2017, 1:49 a.m

Re: Review Request 57917: AMBARI-20546 EU/RU service check should skip services that do not have config types

2017-03-29 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57917/#review170426 --- Ship it! Ship It! - Tim Thorpe On March 29, 2017, 3:08 p.m

Re: Review Request 58002: AMBARI-20592 ServicePresences check should also check for services dropped from a release

2017-04-03 Thread Tim Thorpe
--- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58002/ > ------- > > (Updated March 28, 2017, 8:04 p.m.) > > > Review request for Ambari and Tim Thorpe. > > > Bugs: AMBARI-20592 > https://issues.apache.org/jir

Re: Review Request 58423: AMBARI-20757 - Selecting ignore service checks results in blank dialog box when hitting an error

2017-04-13 Thread Tim Thorpe
--- This was tested manually while testing upgrade. Thanks, Tim Thorpe

Re: Review Request 58423: AMBARI-20757 - Selecting ignore service checks results in blank dialog box when hitting an error

2017-04-13 Thread Tim Thorpe
--- This was tested manually while testing upgrade. Thanks, Tim Thorpe

Re: Review Request 58590: Provide an optional attribute for custom commands to allow using command name in operations window title

2017-04-20 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58590/#review172542 --- Has upgrade been tested? - Tim Thorpe On April 20, 2017, 7:53

Re: Review Request 58409: get_value_from_jmx constantly prints exception message in retry mechanism, which brings bad user experience

2017-04-13 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58409/#review171856 --- Ship it! Ship It! - Tim Thorpe On April 13, 2017, 4:16 a.m

Review Request 58152: AMBARI-20666 - beginning or ending commas in dfs.cluster.administrators cause trouble for starting services

2017-04-13 Thread Tim Thorpe
roup2," parts = re.split('\s', user_and_groups) if len(parts) == 1: parts.append("") users_list = parts[0].strip(",").split(",") if parts[0] else [] groups_list = parts[1].strip(",").split(",") if parts[1] else [] print users_list print groups_list Thanks, Tim Thorpe

Re: Review Request 58534: AMBARI-20784 Able to hide the "Why public repo not selected" when no stacks have repoinfo.xml with the "latest" section

2017-04-19 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58534/#review172355 --- Ship it! Ship It! - Tim Thorpe On April 19, 2017, 4:22 p.m

Re: Review Request 58420: AMBARI-20746 Change to warning log if Ambari doesn't have baseurls for Install Packages step before EU/RU

2017-04-13 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58420/#review171889 --- Ship it! Ship It! - Tim Thorpe On April 13, 2017, 3:59 p.m

Re: Review Request 58152: AMBARI-20666 - beginning or ending commas in dfs.cluster.administrators cause trouble for starting services

2017-04-13 Thread Tim Thorpe
.split('\s', user_and_groups) if len(parts) == 1: parts.append("") users_list = parts[0].strip(",").split(",") if parts[0] else [] groups_list = parts[1].strip(",").split(",") if parts[1] else [] print users_list print groups_list Thanks, Tim Thorpe

Review Request 58423: AMBARI-20757 - Selecting ignore service checks results in blank dialog box when hitting an error

2017-04-13 Thread Tim Thorpe
- ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs a86048e Diff: https://reviews.apache.org/r/58423/diff/1/ Testing --- This was tested manually while testing upgrade. Thanks, Tim Thorpe

Re: Review Request 57463: AMBARI-20365 Display Ranger DB backup instruction in sections on the manual step during RU

2017-03-09 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57463/#review168480 --- Ship it! Ship It! - Tim Thorpe On March 9, 2017, 2:27 p.m

Re: Review Request 57419: AMBARI-20347 Display Ranger DB backup instruction in sections on the manual step during EU and RU

2017-03-08 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57419/#review168314 --- Ship it! Ship It! - Tim Thorpe On March 8, 2017, 2:13 p.m

Re: Review Request 57419: AMBARI-20347 Display Ranger DB backup instruction in sections on the manual step during EU and RU

2017-03-09 Thread Tim Thorpe
ated e-mail. To reply, visit: > https://reviews.apache.org/r/57419/ > --- > > (Updated March 8, 2017, 2:13 p.m.) > > > Review request for Ambari and Tim Thorpe. > > > Bugs: AMBARI-20347 > https://issues.apache.org/jira/browse/AMBARI-

Re: Review Request 57463: AMBARI-20365 Display Ranger DB backup instruction in sections on the manual step during RU

2017-03-10 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57463/#review168639 --- Ship it! Ship It! - Tim Thorpe On March 10, 2017, 4:44 p.m

Re: Review Request 57419: AMBARI-20347 Display Ranger DB backup instruction in sections on the manual step during EU and RU

2017-03-08 Thread Tim Thorpe
-- On March 8, 2017, 2:13 p.m., Di Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57419/ > --- > > (Updated March 8, 2017, 2:13 p.m.) > > > Revie

Re: Review Request 58425: Remove Server attribute from the HTTP response headers

2017-04-13 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58425/#review171903 --- Ship it! Ship It! - Tim Thorpe On April 13, 2017, 5:16 p.m

Re: Review Request 61239: AMBARI-21611 Failed to install packages before EU on powerpc

2017-07-31 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61239/#review181826 --- Ship it! Ship It! - Tim Thorpe On July 31, 2017, 6:20 p.m

Re: Review Request 61371: AMBARI-21624. HDFS restart failed post Ambari upgrade when lzo compression was enabled

2017-08-02 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61371/#review181965 --- Ship it! Ship It! - Tim Thorpe On Aug. 2, 2017, 9:13 a.m

Re: Review Request 61283: AMBARI-21627. Cross-stack upgrade from IOP to HDP, ranger audit properties need to be deleted

2017-08-02 Thread Tim Thorpe
.org/r/61283/ > --- > > (Updated Aug. 1, 2017, 10:34 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Di Li, Sumit Mohanty, Sid Wagle, > and Tim Thorpe. > > > Bugs: AMBARI-21627 > https://issues.apache.org/jira/browse/AMBARI-21627 > > > Rep

Re: Review Request 61371: AMBARI-21624. HDFS restart failed post Ambari upgrade when lzo compression was enabled

2017-08-02 Thread Tim Thorpe
/4.2.5/services/HDFS/package/scripts/balancer-emulator/balancer.log Lines 1 (patched) <https://reviews.apache.org/r/61371/#comment257800> This should either be removed to avoid the license file issue or added to the exception list in the pom. - Tim Thorpe On Aug. 2, 2017, 9:13

Re: Review Request 61415: AMBARI-21654 Post Ambari upgrade, BI value add 4.2 services should still be able to restart

2017-08-03 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61415/#review182157 --- Ship it! Ship It! - Tim Thorpe On Aug. 3, 2017, 8:20 p.m

Re: Review Request 61403: AMBARI-21554. Regenerating keytabs fails in Stack Advisor after upgrading Ambari

2017-08-03 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61403/#review182101 --- Ship it! Ship It! - Tim Thorpe On Aug. 3, 2017, 12:54 p.m

Re: Review Request 60814: AMBARI-21461 Spark thrift server restart fails during migration EU

2017-07-13 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60814/#review180426 --- Ship it! Ship It! - Tim Thorpe On July 12, 2017, 9 p.m., Di

Re: Review Request 60866: AMBARI-21477: Remove Falcon proxy entries from Knox kerberos.json

2017-07-14 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60866/#review180526 --- Ship it! Ship It! - Tim Thorpe On July 14, 2017, 1:34 p.m

Re: Review Request 60691: AMBARI-21420 HBase master crashed during/post EU on an IOP4.2.5/HDP2.6 migrated cluster

2017-07-11 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60691/#review180181 --- Ship it! Ship It! - Tim Thorpe On July 10, 2017, 7:55 p.m

Re: Review Request 60754: AMBARI-21439 Hive/MapRed2 restart fails after Ambari upgrade

2017-07-11 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60754/#review180180 --- Ship it! Ship It! - Tim Thorpe On July 10, 2017, 9:40 p.m

Re: Review Request 60807: AMBARI-21453 Restart Hive after Install Packages fails with err on Condition with name 'should_install_mysl_connector'

2017-07-12 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60807/#review180330 --- Ship it! Ship It! - Tim Thorpe On July 12, 2017, 4:55 p.m

Review Request 60945: AMBARI-21509 - BigInsights/4.2 upgrade to HDP uses function take_snapshot but that doesn't exist in 4.2's hbase_upgrade.py

2017-07-18 Thread Tim Thorpe
/hbase_upgrade.py 610f527 Diff: https://reviews.apache.org/r/60945/diff/1/ Testing --- modify the script and retry the upgrade from where it failed when the function wasn't found Thanks, Tim Thorpe

Re: Review Request 60986: AMBARI-21528. Zookeeper server has incorrect memory setting, missing m in Xmx value

2017-07-20 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60986/#review181035 --- Ship it! Ship It! - Tim Thorpe On July 20, 2017, 12:13 a.m

Re: Review Request 61000: AMBARI-21527 Restart of MR2 History Server failed due to wrong NameNode RPC address

2017-07-20 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61000/#review181059 --- Ship it! Ship It! - Tim Thorpe On July 20, 2017, 4:54 p.m

Re: Review Request 61049: AMBARI-21553 Oozie server failed to restart post IOP 4.2 migration

2017-07-21 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61049/#review181139 --- Ship it! Ship It! - Tim Thorpe On July 21, 2017, 7:59 p.m

Re: Review Request 61050: AMBARI-21555 Hive restart fails to restart MySQL after Ambari upgrade against IOP 4.2.5

2017-07-21 Thread Tim Thorpe
t; > (Updated July 21, 2017, 8:18 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sid Wagle, > and Tim Thorpe. > > > Bugs: AMBARI-21555 > https://issues.apache.org/jira/browse/AMBARI-21555 > > > Repository: ambari >

<    1   2   3   >