Re: Review Request 61813: Storm Service should not have ranger 'ranger-admin-site' and 'ranger-ugsync-site' dependencies

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61813/#review183494
---


Ship it!




Ship It!

- Juanjo  Marron


On Aug. 22, 2017, 1:42 p.m., Jay SenSharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61813/
> ---
> 
> (Updated Aug. 22, 2017, 1:42 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Juanjo  Marron, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21779
> https://issues.apache.org/jira/browse/AMBARI-21779
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Storm Service should not include the following ""
> 
> ranger-ugsync-site
> ranger-admin-site
> 
> Else making any configuration change in Ranger service (for example: "Ranger 
> User Info") will ask Storm service to be restarted.
> 
> Looks like as part of JIRA "AMBARI-16250"  this dependency was added in bulk 
> by mistake.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/metainfo.xml 
> 0c62c1a 
>   
> ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/metainfo.xml 
> 1bc23e4 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/metainfo.xml 
> 084eac2 
>   ambari-server/src/main/resources/common-services/STORM/1.1.0/metainfo.xml 
> 94f5ca3 
> 
> 
> Diff: https://reviews.apache.org/r/61813/diff/1/
> 
> 
> Testing
> ---
> 
> .
> 
> 
> Thanks,
> 
> Jay SenSharma
> 
>

Re: Review Request 61043: AMBARI-21325: Quicklink support through Knox

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61043/#review181235
---


Ship it!




It looks good to me. It is similar to the change set included as part of IOP 
supporting QuickLinks through Knox.
Can we make sure all the tests run by HadoopQA pass, even if they are not 
related to this change?

- Juanjo  Marron


On July 21, 2017, 6:57 p.m., Chandana Mirashi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61043/
> ---
> 
> (Updated July 21, 2017, 6:57 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Juanjo  Marron, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21325
> https://issues.apache.org/jira/browse/AMBARI-21325
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add quicklink support through Knox.
> Changes:
> 1. Add new json properties knox_url, knox_path, supports_knox
>a. knox_url: template to be used for urls that are proxied through Knox 
>b. knox_path: Knox gateway path that will be added to the proxy url.
>c. supports_knox: whether link will be redirected through Knox
> 2. Add above json properties to quicklinks.json
> 3. Add HDFSUI & DATANODE,YARNUI & NODEUI, JOBHISTORYUI, HBASEUI, OOZIEUI, 
> SPARKUI services to Knox topology template.
> 4. Automate protocol and port added to Knox topology file. Based on whether 
> SSL is enabled for the services listed above, the port and protocol in 
> params_linux.py will be updated.
> 5. Update quick_view_link_view.js so that when Knox is installed and 
> support_knox is true, quicklink url follows knox url template specified in 
> the quicklinks.json for the service/component.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java
>  1d2e712 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  4558069 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/quicklinks/quicklinks.json
>  5568122 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/quicklinks/quicklinks.json
>  a4216e3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/quicklinks/quicklinks.json
>  81e7cbe 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks-mapred/quicklinks.json
>  36f71b5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks/quicklinks.json
>  0aca8e3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml
>  df4c1b4 
>   ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json 1805c3b 
>   ambari-web/app/views/common/quick_view_link_view.js e39f230 
> 
> 
> Diff: https://reviews.apache.org/r/61043/diff/1/
> 
> 
> Testing
> ---
> 
> 1. ambari-server: mvn test
> 2. mvn -DskipSurefireTests -Dpython.test.mask=test_knox_gateway.py test
> 3. ambari-web: mvn test
>  21213 passing (54s)
>  128 pending
> 
> 
> Thanks,
> 
> Chandana Mirashi
> 
>

Re: Review Request 60844: Support migration of LDAP users & groups to PAM

[Juanjo Marron]

> On July 13, 2017, 8:52 p.m., Juanjo  Marron wrote:
> >
> 
> Juanjo  Marron wrote:
> Ship it!

Reviewd with Tuong Truong.
This is similar to the logic we were supporting in IOP for LDAP to PAM 
migration.

Thanks for working on it


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60844/#review180470
---


On July 13, 2017, 4:03 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60844/
> ---
> 
> (Updated July 13, 2017, 4:03 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Anita Jebaraj, Balázs Bence Sári, 
> Di Li, Eugene Chekanskiy, Juanjo  Marron, Laszlo Puskas, Sebastian Toader, 
> and Tuong.
> 
> 
> Bugs: AMBARI-19038
> https://issues.apache.org/jira/browse/AMBARI-19038
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After PAM has been declared as the authentication mechanism for Ambari 
> clients (for example, the Ambari Server web-based UI) where previously the 
> mechanism was LDAP, a migration process is needed to converts the LDAP users 
> and groups to PAM users and groups.  
> 
> This facility may be invoked using:
> 
> ```
> ambari-server migrate-ldap-pam
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js
>  c61e71cc33 
>   ambari-server/pom.xml b1179a4847 
>   ambari-server/sbin/ambari-server cc1c923a43 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/LdapToPamMigrationHelper.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  83edccc04b 
>   ambari-server/src/main/python/ambari-server.py 71459fb2d3 
>   ambari-server/src/main/python/ambari_server/setupActions.py 142a4d7cc4 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 17d10256fc 
> 
> 
> Diff: https://reviews.apache.org/r/60844/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 60844: Support migration of LDAP users & groups to PAM

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60844/#review180473
---


Ship it!




Ship It!

- Juanjo  Marron


On July 13, 2017, 4:03 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60844/
> ---
> 
> (Updated July 13, 2017, 4:03 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Anita Jebaraj, Balázs Bence Sári, 
> Di Li, Eugene Chekanskiy, Juanjo  Marron, Laszlo Puskas, Sebastian Toader, 
> and Tuong.
> 
> 
> Bugs: AMBARI-19038
> https://issues.apache.org/jira/browse/AMBARI-19038
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After PAM has been declared as the authentication mechanism for Ambari 
> clients (for example, the Ambari Server web-based UI) where previously the 
> mechanism was LDAP, a migration process is needed to converts the LDAP users 
> and groups to PAM users and groups.  
> 
> This facility may be invoked using:
> 
> ```
> ambari-server migrate-ldap-pam
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js
>  c61e71cc33 
>   ambari-server/pom.xml b1179a4847 
>   ambari-server/sbin/ambari-server cc1c923a43 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/LdapToPamMigrationHelper.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  83edccc04b 
>   ambari-server/src/main/python/ambari-server.py 71459fb2d3 
>   ambari-server/src/main/python/ambari_server/setupActions.py 142a4d7cc4 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 17d10256fc 
> 
> 
> Diff: https://reviews.apache.org/r/60844/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 60844: Support migration of LDAP users & groups to PAM

[Juanjo Marron]

> On July 13, 2017, 8:52 p.m., Juanjo  Marron wrote:
> >

Ship it!


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60844/#review180470
---


On July 13, 2017, 4:03 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60844/
> ---
> 
> (Updated July 13, 2017, 4:03 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Anita Jebaraj, Balázs Bence Sári, 
> Di Li, Eugene Chekanskiy, Juanjo  Marron, Laszlo Puskas, Sebastian Toader, 
> and Tuong.
> 
> 
> Bugs: AMBARI-19038
> https://issues.apache.org/jira/browse/AMBARI-19038
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After PAM has been declared as the authentication mechanism for Ambari 
> clients (for example, the Ambari Server web-based UI) where previously the 
> mechanism was LDAP, a migration process is needed to converts the LDAP users 
> and groups to PAM users and groups.  
> 
> This facility may be invoked using:
> 
> ```
> ambari-server migrate-ldap-pam
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js
>  c61e71cc33 
>   ambari-server/pom.xml b1179a4847 
>   ambari-server/sbin/ambari-server cc1c923a43 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/LdapToPamMigrationHelper.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  83edccc04b 
>   ambari-server/src/main/python/ambari-server.py 71459fb2d3 
>   ambari-server/src/main/python/ambari_server/setupActions.py 142a4d7cc4 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 17d10256fc 
> 
> 
> Diff: https://reviews.apache.org/r/60844/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 60844: Support migration of LDAP users & groups to PAM

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60844/#review180470
---



- Juanjo  Marron


On July 13, 2017, 4:03 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60844/
> ---
> 
> (Updated July 13, 2017, 4:03 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Anita Jebaraj, Balázs Bence Sári, 
> Di Li, Eugene Chekanskiy, Juanjo  Marron, Laszlo Puskas, Sebastian Toader, 
> and Tuong.
> 
> 
> Bugs: AMBARI-19038
> https://issues.apache.org/jira/browse/AMBARI-19038
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After PAM has been declared as the authentication mechanism for Ambari 
> clients (for example, the Ambari Server web-based UI) where previously the 
> mechanism was LDAP, a migration process is needed to converts the LDAP users 
> and groups to PAM users and groups.  
> 
> This facility may be invoked using:
> 
> ```
> ambari-server migrate-ldap-pam
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js
>  c61e71cc33 
>   ambari-server/pom.xml b1179a4847 
>   ambari-server/sbin/ambari-server cc1c923a43 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/LdapToPamMigrationHelper.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  83edccc04b 
>   ambari-server/src/main/python/ambari-server.py 71459fb2d3 
>   ambari-server/src/main/python/ambari_server/setupActions.py 142a4d7cc4 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 17d10256fc 
> 
> 
> Diff: https://reviews.apache.org/r/60844/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 58671: check_ambari_permissions.py does not run for all the files and directories listed

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58671/
---

(Updated April 24, 2017, 4:36 p.m.)


Review request for Ambari, Alejandro Fernandez, Aravindan Vijayan, Di Li, and 
Vitalyi Brodetskyi.


Bugs: AMBARI-20825
https://issues.apache.org/jira/browse/AMBARI-20825


Repository: ambari


Description (updated)
---

ambari-server/src/main/resources/scripts/check_ambari_permissions.py script 
introduced in branch 2.5.0 and published here 
(https://cwiki.apache.org/confluence/display/AMBARI/Ambari+Vulnerabilities#AmbariVulnerabilities-FixedinAmbari2.5.0)
 to solve Public Vulnerability:
https://nvd.nist.gov/vuln/detail/CVE-2017-5642 works only partially. 
There is a bug and it only handles the last directory/file when there are 
multiple directories/files listed.
So the vulnerability is not totally resolved. 
For example files under /etc/ambari-server/conf/ such as ambari.properties are 
not revised


Diffs
-

  ambari-server/src/main/resources/scripts/check_ambari_permissions.py 638f65f 


Diff: https://reviews.apache.org/r/58671/diff/1/


Testing
---

Manual testing on a 2.4.2 cluster with permission issues


Thanks,

Juanjo  Marron

Review Request 58671: check_ambari_permissions.py does not run for all the files and directories listed

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58671/
---

Review request for Ambari, Aravindan Vijayan, Di Li, and Vitalyi Brodetskyi.


Bugs: AMBARI-20825
https://issues.apache.org/jira/browse/AMBARI-20825


Repository: ambari


Description
---

ambari-server/src/main/resources/scripts/check_ambari_permissions.py script 
introduced in branch 2.5.0 and published here 
(https://cwiki.apache.org/confluence/display/AMBARI/Ambari+Vulnerabilities#AmbariVulnerabilities-FixedinAmbari2.5.0)
 to solve Public Vulnerability:
https://nvd.nist.gov/vuln/detail/CVE-2017-5642 work sonly partially. 
There is a bug and it only handles the last directory/file when there are 
multiple directories/files listed.
So the vulnerability is not totally resolved. 
For example files under /etc/ambari-server/conf/ such as ambari.properties are 
not revised


Diffs
-

  ambari-server/src/main/resources/scripts/check_ambari_permissions.py 638f65f 


Diff: https://reviews.apache.org/r/58671/diff/1/


Testing
---

Manual testing on a 2.4.2 cluster with permission issues


Thanks,

Juanjo  Marron

Re: Review Request 56673: Perform Kinit on Kafka Start

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56673/#review171354
---


Ship it!




Ship It!

- Juanjo  Marron


On April 6, 2017, 11:04 p.m., Bharat Viswanadham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56673/
> ---
> 
> (Updated April 6, 2017, 11:04 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Juanjo  Marron.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Perform Kinit on Kafka Start
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py
>  0901730 
> 
> 
> Diff: https://reviews.apache.org/r/56673/diff/1/
> 
> 
> Testing
> ---
> 
> Kerberoized the cluster and then checked for kafka user the kinit has 
> performed or not.
> ran the command klist for kafka user and able to see cached ticket under 
> kafka user
> [root@idyll1 ~]# su kafka
> [kafka@idyll1 root]$ klist
> Ticket cache: FILE:/tmp/krb5cc_1004
> Default principal: kafka/idyll1.fyre.ibm@ibm.com
> 
> Valid starting ExpiresService principal
> 02/14/17 10:21:41  02/15/17 10:21:41  krbtgt/ibm@ibm.com
>   renew until 02/14/17 10:21:41
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>

Re: Review Request 57429: WFM: Page numbers on workflow dashboard are not calculated correctly

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57429/#review169028
---


Ship it!




Ship It!

- Juanjo  Marron


On March 15, 2017, 4:33 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57429/
> ---
> 
> (Updated March 15, 2017, 4:33 p.m.)
> 
> 
> Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Gaurav Nagar, Juanjo  
> Marron, and Nitiraj Rathore.
> 
> 
> Bugs: AMBARI-20352
> https://issues.apache.org/jira/browse/AMBARI-20352
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When the number of workflows exceeds 15, you can see additional pages in the 
> workflow dashboard.
> The pag number calculation is not correct. On page 2, the page number is 
> displayed as 1.665.
> 
> This is because roundedStart is not calculated based on the number of records 
> a page holds (jobs.pageSize).
> 
> var roundedStart = this.get('jobs.start') - this.get('jobs.start') % 10;
> 
> Fix is to use the jobs.pageSize instead.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-table.js 
> 5f92d6f 
> 
> 
> Diff: https://reviews.apache.org/r/57429/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Tessting.
> Build failure is unrelated.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 53103: Workflow Designer View: When logs are empty, you see the spinner, instead of a message

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53103/#review157438
---


Ship it!




Ship It!

- Juanjo  Marron


On Nov. 30, 2016, 6:43 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53103/
> ---
> 
> (Updated Nov. 30, 2016, 6:43 p.m.)
> 
> 
> Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Juanjo  Marron, Pallav 
> Kulshreshtha, Venkat Ranganathan, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18600
> https://issues.apache.org/jira/browse/AMBARI-18600
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In the workflow designer view instance, if there is no log available for the 
> workflow, then the spinner is seen giving the impression that logs are still 
> being retrieved. This happens for all the logs, viz. the job log, error log 
> and audit log.
> 
> A message sould be displayed when there are no messages in the log.
> 
> The test failure for this patch is caused by an existing issue unrelated to 
> this patch.
> 
> Failed to execute goal on project wfmanager: Could not resolve dependencies 
> for project org.apache.ambari.contrib.views:wfmanager:jar:0.1.0.0-SNAPSHOT: 
> Failure to find 
> org.apache.ambari.contrib.views:ambari-views-commons:jar:2.0.0.0-SNAPSHOT in 
> https://oss.sonatype.org/content/groups/staging was cached in the local 
> repository, resolution will not be reattempted until the update interval of 
> oss.sonatype.org has elapsed or updates are forced -> [Help 1]
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 
> e403dc4 
> 
> Diff: https://reviews.apache.org/r/53103/diff/
> 
> 
> Testing
> ---
> 
> Manual tests.
> 
> 
> File Attachments
> 
> 
> C:\Sangeeta\Work\BigData\Ambari\Jira Submissions\18600
>   
> https://reviews.apache.org/media/uploaded/files/2016/10/27/5b87e2e8-23e1-456c-ab5d-f157db437624__AMBARI-18600.patch
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 48766: MySQL service status needs to be more robust

[Juanjo Marron]

> On Aug. 3, 2016, 12:33 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py,
> >  line 36
> > <https://reviews.apache.org/r/48766/diff/2/?file=1421794#file1421794line36>
> >
> > What happens if pid_file is None?

In case pid_file is not in the mysqladmin variables output, mysql_pid_file will 
remain None (as initialized) and the Failure ("Output of '{0}' didn't contain 
pid_file. Output: '{1}'").format(cmd, output)  will be raised

Also, if  check_process_status(pid_file) is called with None the method defined 
on resource_management/libraries/functions/check_process_status.py will log the 
info and raise ComponentIsNotRunning() exception

I think we are fine if pid_file is None


> On Aug. 3, 2016, 12:33 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py,
> >  line 59
> > <https://reviews.apache.org/r/48766/diff/2/?file=1421794#file1421794line59>
> >
> > This needs to check that output is not None

I added this output verification on the new patch submitted


> On Aug. 3, 2016, 12:33 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py,
> >  line 60
> > <https://reviews.apache.org/r/48766/diff/2/?file=1421794#file1421794line60>
> >
> > Remove parentheses and check >= 0
> > Further, before accessing index 3, should check the length.
> > 
> > To make this a bit more robust, please put a try-catch around it, but 
> > still raise Fail if code is non-zero.

I changed the if condition to check >= 0 and validate the list lenght before 
splitting it.

Regarding the no-zero code, we should not forget we are checking the service 
status, so MySQL can be started or stopped at this time   
When mysql is stopped, mysqladmin variables will return error code (!=0) and 
the following output:

Output of 'mysqladmin variables' didn't contain pid_file. Output: mysqladmin: 
connect to server at 'localhost' failed
error: 'Can't connect to local MySQL server through socket 
'/var/lib/mysql/mysql.sock' (2)'
Check that mysqld is running and that the socket: '/var/lib/mysql/mysql.sock' 
exists!

And I believe it shouldnt be considered as an error or catched as an excpetion, 
it just means MySQL is in a stopped state.
pid_file will be None and check_process_status will handle it as 
ComponentIsNotRunning


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48766/#review144569
---


On Aug. 5, 2016, 9:49 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48766/
> ---
> 
> (Updated Aug. 5, 2016, 9:49 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Dmitro 
> Lisnichenko.
> 
> 
> Bugs: AMBARI-13238
> https://issues.apache.org/jira/browse/AMBARI-13238
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The MySQL service status in mysql_service.py simply checks for a process with 
> name mysqld. In our environment, a different service ran another MySQL 
> instance on that node and as a result, the status of the MySQL service in 
> Hive showed green (because it could find a mysqld process) even though the 
> instance used by Hive wasn't started. That also made the "Start Service" 
> action for Hive fail, because the metastore service couldn't connect to the 
> MySQL database.
> 
> The proposed fix makes the service check more robust by retrieving the 
> pid_file of the MySQL instance first by running "mysqladmin variables" and 
> parsing out the pid_file. Then it checks if the process exists. 
> 
> A new pacth is proposed based on the reviews added to the original one 
> (https://reviews.apache.org/r/39146/)
> 
> The patch relies now on the pid (similar to other status check). mysql 
> pid_file is not known a priori (it is not a service property similar to other 
> ambari components) and it depends on the OS. 
> The pid file location is obatined with  "mysqladmin variables" command (which 
> seems recognized by all the Ambari supported OS). 
> The Hive MySQL server instance is started without passing in any parameters 
> so It uses the default configuration. Any other MySQL instance that could be 
> running on the machine would need to be started wi

Re: Review Request 48766: MySQL service status needs to be more robust

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48766/
---

(Updated Aug. 5, 2016, 9:49 p.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Dmitro 
Lisnichenko.


Changes
---

New patch replying to Alejandro's review


Bugs: AMBARI-13238
https://issues.apache.org/jira/browse/AMBARI-13238


Repository: ambari


Description
---

The MySQL service status in mysql_service.py simply checks for a process with 
name mysqld. In our environment, a different service ran another MySQL instance 
on that node and as a result, the status of the MySQL service in Hive showed 
green (because it could find a mysqld process) even though the instance used by 
Hive wasn't started. That also made the "Start Service" action for Hive fail, 
because the metastore service couldn't connect to the MySQL database.

The proposed fix makes the service check more robust by retrieving the pid_file 
of the MySQL instance first by running "mysqladmin variables" and parsing out 
the pid_file. Then it checks if the process exists. 

A new pacth is proposed based on the reviews added to the original one 
(https://reviews.apache.org/r/39146/)

The patch relies now on the pid (similar to other status check). mysql pid_file 
is not known a priori (it is not a service property similar to other ambari 
components) and it depends on the OS. 
The pid file location is obatined with  "mysqladmin variables" command (which 
seems recognized by all the Ambari supported OS). 
The Hive MySQL server instance is started without passing in any parameters so 
It uses the default configuration. Any other MySQL instance that could be 
running on the machine would need to be started with explicit config.
Hence just running mysqladmin will return the values for the Hive MySQL 
instance.
The pid dile name is parsed by a new method which has been created to obatin it 
from the mysqladmin variables return.
The status relies now on check_process_status() wich is already an ambari 
function.
Unit Test have been modified accordingly to avoid the pgrep verification that 
could create conflicts with others mysql instances working on the same node.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py
 7862774 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_mysql_server.py 827f6f7 

Diff: https://reviews.apache.org/r/48766/diff/


Testing
---

+1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12810584/AMBARI-13238.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7367//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7367//console
This message is automatically generated.


Thanks,

Juanjo  Marron

Re: Review Request 48766: MySQL service status needs to be more robust

[Juanjo Marron]

> On June 16, 2016, 10:52 p.m., Andrew Onischuk wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py,
> >  line 63
> > <https://reviews.apache.org/r/48766/diff/2/?file=1421794#file1421794line63>
> >
> > Else should go into for, not if (in case break didn't execute). 
> > 
> > Also (if code == 0) line is not needed since checked_call checks for 
> > non-zero return code itself and throws a reasonable exception in that case.
> 
> Andrew Onischuk wrote:
> Just to be easier to understand here is what I mean:
> 
> def get_mysql_pid_file():
>   cmd = 'mysqladmin variables'
>   code, output = shell.checked_call(cmd)
> 
>   for line in output.splitlines():
> if (line.find("pid_file") != -1):
>   mysql_pid_file  = line.split()[3].strip()
>   break
> else:
>   raise Fail(format("Output of '{cmd}' didn't contain pid_file. 
> Output: {output}"))  
>   return mysql_pid_file
> 
> Andrew Onischuk wrote:
> Juanjo sorry for bothering you so much with this issues. I just feel like 
> this is something which we should fix to be able debug problems in this place 
> more simply in future.
> 
> Juanjo  Marron wrote:
> No problem Andrew! I totally understand the process and it does not 
> bother me at all. These reviews the best way to find a good solution.
> 
> Correct me if I'm wrong, but I dont think this last solution is not  
> working since status action will fail to get the mysqld file. 
> Iterating line by line the mysqladmin variables output, which looks like 
> following: 
> 
> 
> +-+---+
> | Variable_name   | Value 
> |
> 
> +-+---+
> | auto_increment_increment| 1 
> |
> | auto_increment_offset   | 1 
> |
> | autocommit  | ON
> |
> | automatic_sp_privileges | ON
> |
> | back_log| 50
> |
> | basedir | /usr/ 
> |
> | big_tables  | OFF   
> |
> | binlog_cache_size   | 32768 
> |
> 
>  . 
>  
> | old_passwords   | OFF   
> |
> | open_files_limit| 1024  
> |
> | optimizer_prune_level   | 1 
> |
> | optimizer_search_depth  | 62
> |
> | optimizer_switch| 
> index_merge=on,index_merge_union=on,index_merge_sort_union=on,index_merge_intersection=on
>  |
> | pid_file| /var/run/mysqld/mysqld.pid
> |
> | plugin_dir  | /usr/lib64/mysql/plugin   
> |
> | port| 3306  
> |
> | preload_buffer_size | 32768 
> |
> | profiling   | O

Re: Review Request 48766: MySQL service status needs to be more robust

[Juanjo Marron]

> On June 16, 2016, 10:52 p.m., Andrew Onischuk wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py,
> >  line 63
> > <https://reviews.apache.org/r/48766/diff/2/?file=1421794#file1421794line63>
> >
> > Else should go into for, not if (in case break didn't execute). 
> > 
> > Also (if code == 0) line is not needed since checked_call checks for 
> > non-zero return code itself and throws a reasonable exception in that case.
> 
> Andrew Onischuk wrote:
> Just to be easier to understand here is what I mean:
> 
> def get_mysql_pid_file():
>   cmd = 'mysqladmin variables'
>   code, output = shell.checked_call(cmd)
> 
>   for line in output.splitlines():
> if (line.find("pid_file") != -1):
>   mysql_pid_file  = line.split()[3].strip()
>   break
> else:
>   raise Fail(format("Output of '{cmd}' didn't contain pid_file. 
> Output: {output}"))  
>   return mysql_pid_file
> 
> Andrew Onischuk wrote:
> Juanjo sorry for bothering you so much with this issues. I just feel like 
> this is something which we should fix to be able debug problems in this place 
> more simply in future.
> 
> Juanjo  Marron wrote:
> No problem Andrew! I totally understand the process and it does not 
> bother me at all. These reviews the best way to find a good solution.
> 
> Correct me if I'm wrong, but I dont think this last solution is not  
> working since status action will fail to get the mysqld file. 
> Iterating line by line the mysqladmin variables output, which looks like 
> following: 
> 
> 
> +-+---+
> | Variable_name   | Value 
> |
> 
> +-+---+
> | auto_increment_increment| 1 
> |
> | auto_increment_offset   | 1 
> |
> | autocommit  | ON
> |
> | automatic_sp_privileges | ON
> |
> | back_log| 50
> |
> | basedir | /usr/ 
> |
> | big_tables  | OFF   
> |
> | binlog_cache_size   | 32768 
> |
> 
>  . 
>  
> | old_passwords   | OFF   
> |
> | open_files_limit| 1024  
> |
> | optimizer_prune_level   | 1 
> |
> | optimizer_search_depth  | 62
> |
> | optimizer_switch| 
> index_merge=on,index_merge_union=on,index_merge_sort_union=on,index_merge_intersection=on
>  |
> | pid_file| /var/run/mysqld/mysqld.pid
> |
> | plugin_dir  | /usr/lib64/mysql/plugin   
> |
> | port| 3306  
> |
> | preload_buffer_size | 32768 
> |
> | profiling   | O

Re: Review Request 49895: AMBARI-17631: preinstall-check script should use AMBARI-AGENT REST API for the list of agents

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49895/#review141961
---


Ship it!




Ship It!

- Juanjo  Marron


On July 12, 2016, 4:48 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49895/
> ---
> 
> (Updated July 12, 2016, 4:48 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Juanjo  Marron.
> 
> 
> Bugs: AMBARI-17631
> https://issues.apache.org/jira/browse/AMBARI-17631
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> it should use the existing services/AMBARI/components/AMBARI-AGENT rest api 
> for the list of agents
> 
> 
> Diffs
> -
> 
>   contrib/utils/preinstall-check/src/main/python/preinstall_checker.py 
> 7ff7e4c 
> 
> Diff: https://reviews.apache.org/r/49895/diff/
> 
> 
> Testing
> ---
> 
> Run the script against a cluster just Ambari server and Ambari Agent nodes 
> installed.verify the script can get the correct list of ambari agents.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 49930: AMBARI-17614 Clean up import * for AMBARI_METRICS services

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49930/#review141805
---


Ship it!




Ship It!

- Juanjo  Marron


On July 11, 2016, 10:59 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49930/
> ---
> 
> (Updated July 11, 2016, 10:59 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jayush Luniya, and Juanjo  
> Marron.
> 
> 
> Bugs: AMBARI-17614
> https://issues.apache.org/jira/browse/AMBARI-17614
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py
>  and 
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py
> uses `from resource_management import *`. It increases code tracking 
> difficulty.
> I think this is related to AMBARI-16101
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py
>  7dc66b2 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py
>  fa4e8a4 
> 
> Diff: https://reviews.apache.org/r/49930/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 49735: AMBARI-17570 Lack of importing ClientComponentHasNoStatus

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49735/#review141106
---


Ship it!




Ship It!

- Juanjo  Marron


On July 6, 2016, 11:45 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49735/
> ---
> 
> (Updated July 6, 2016, 11:45 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Juanjo  
> Marron.
> 
> 
> Bugs: AMBARI-17570
> https://issues.apache.org/jira/browse/AMBARI-17570
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some of the *_client.py files (e.g. 
> ambari/ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py)
>  don't import ClientComponentHasNoStatus while it is used. It should be 
> imported.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py
>  1e7ed1f3 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py
>  f8c33dd 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py
>  93d244d 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py
>  1f85fc0 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py
>  5a398db 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
>  7c5b6e0 
>   
> ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py
>  111f4d2 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py
>  99314ec 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/zookeeper_client.py
>  fac92e1 
> 
> Diff: https://reviews.apache.org/r/49735/diff/
> 
> 
> Testing
> ---
> 
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12816319/AMBARI-17570.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7710//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7710//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 48766: MySQL service status needs to be more robust

[Juanjo Marron]

> On June 16, 2016, 10:52 p.m., Andrew Onischuk wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py,
> >  line 63
> > <https://reviews.apache.org/r/48766/diff/2/?file=1421794#file1421794line63>
> >
> > Else should go into for, not if (in case break didn't execute). 
> > 
> > Also (if code == 0) line is not needed since checked_call checks for 
> > non-zero return code itself and throws a reasonable exception in that case.
> 
> Andrew Onischuk wrote:
> Just to be easier to understand here is what I mean:
> 
> def get_mysql_pid_file():
>   cmd = 'mysqladmin variables'
>   code, output = shell.checked_call(cmd)
> 
>   for line in output.splitlines():
> if (line.find("pid_file") != -1):
>   mysql_pid_file  = line.split()[3].strip()
>   break
> else:
>   raise Fail(format("Output of '{cmd}' didn't contain pid_file. 
> Output: {output}"))  
>   return mysql_pid_file
> 
> Andrew Onischuk wrote:
> Juanjo sorry for bothering you so much with this issues. I just feel like 
> this is something which we should fix to be able debug problems in this place 
> more simply in future.
> 
> Juanjo  Marron wrote:
> No problem Andrew! I totally understand the process and it does not 
> bother me at all. These reviews the best way to find a good solution.
> 
> Correct me if I'm wrong, but I dont think this last solution is not  
> working since status action will fail to get the mysqld file. 
> Iterating line by line the mysqladmin variables output, which looks like 
> following: 
> 
> 
> +-+---+
> | Variable_name   | Value 
> |
> 
> +-+---+
> | auto_increment_increment| 1 
> |
> | auto_increment_offset   | 1 
> |
> | autocommit  | ON
> |
> | automatic_sp_privileges | ON
> |
> | back_log| 50
> |
> | basedir | /usr/ 
> |
> | big_tables  | OFF   
> |
> | binlog_cache_size   | 32768 
> |
> 
>  . 
>  
> | old_passwords   | OFF   
> |
> | open_files_limit| 1024  
> |
> | optimizer_prune_level   | 1 
> |
> | optimizer_search_depth  | 62
> |
> | optimizer_switch| 
> index_merge=on,index_merge_union=on,index_merge_sort_union=on,index_merge_intersection=on
>  |
> | pid_file| /var/run/mysqld/mysqld.pid
> |
> | plugin_dir  | /usr/lib64/mysql/plugin   
> |
> | port| 3306  
> |
> | preload_buffer_size | 32768 
> |
> | profiling   | O

Re: Review Request 48766: MySQL service status needs to be more robust

[Juanjo Marron]

f (line.find("pid_file") != -1):
mysql_pid_file  = line.split()[3].strip()
break
  if mysql_pid_file is None:
raise Fail(format("Output of '{cmd}' didn't contain pid_file. Output: 
{output}"))  
  return mysql_pid_file

 we will be breaking the restart logic (I tested it).

When mysql is stopped, mysqladmin variables will return error code (!=0) and 
the following output:

Output of 'mysqladmin variables' didn't contain pid_file. Output: mysqladmin: 
connect to server at 'localhost' failed
error: 'Can't connect to local MySQL server through socket 
'/var/lib/mysql/mysql.sock' (2)'
Check that mysqld is running and that the socket: '/var/lib/mysql/mysql.sock' 
exists!

And it shouldnt be considered as an error, just is a stopped status. After 
that,  status action should allow the start to run and complete the restart 
action. 
Now we are breaking it. Status when stopped is throwing exception on 
shell.checked_call() and the start never runs,

Start and Stop actions when run individually are still working fine they are 
not aware of the pid file, just status checks it.

Fot this reason, I still consider we shouldnt throw an exception if mysqladmin 
variables returns error code. So using shell.call() should be enough.
And just in the case when mysqladmin variables runs properly (code ==0), search 
for pid_file and if not found  that's when the Fail excpetion needs to be 
raised.

Also if mysqladmin variables fails mysql_pid_file = None still needs to be 
retruned, because when checking the status and the service is stopped, the 
check_process_status() will be able to read a None and return  
ComponentNonRunning exception, which is the expected behavour.

Said all that, this is my new proposal:

def get_mysql_pid_file():
  mysql_pid_file = None
  cmd = 'mysqladmin variables'
  code, output = shell.call(cmd)
  if code == 0:
for line in output.splitlines():
   if (line.find("pid_file") != -1):
  mysql_pid_file  = line.split()[3].strip()
  break
if mysql_pid_file is None:
   raise Fail("Output of '{0}' didn't contain pid_file. Output: 
'{1}'").format(cmd, output)  
  return mysql_pid_file


I tested start, stop, and restart and seems to be working fine.

Please, let me know what do you think and I will upload the patch if your 
feedback is positive


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48766/#review138115
---


On June 16, 2016, 9:20 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48766/
> ---
> 
> (Updated June 16, 2016, 9:20 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Dmitro 
> Lisnichenko.
> 
> 
> Bugs: AMBARI-13238
> https://issues.apache.org/jira/browse/AMBARI-13238
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The MySQL service status in mysql_service.py simply checks for a process with 
> name mysqld. In our environment, a different service ran another MySQL 
> instance on that node and as a result, the status of the MySQL service in 
> Hive showed green (because it could find a mysqld process) even though the 
> instance used by Hive wasn't started. That also made the "Start Service" 
> action for Hive fail, because the metastore service couldn't connect to the 
> MySQL database.
> 
> The proposed fix makes the service check more robust by retrieving the 
> pid_file of the MySQL instance first by running "mysqladmin variables" and 
> parsing out the pid_file. Then it checks if the process exists. 
> 
> A new pacth is proposed based on the reviews added to the original one 
> (https://reviews.apache.org/r/39146/)
> 
> The patch relies now on the pid (similar to other status check). mysql 
> pid_file is not known a priori (it is not a service property similar to other 
> ambari components) and it depends on the OS. 
> The pid file location is obatined with  "mysqladmin variables" command (which 
> seems recognized by all the Ambari supported OS). 
> The Hive MySQL server instance is started without passing in any parameters 
> so It uses the default configuration. Any other MySQL instance that could be 
> running on the machine would need to be started with explicit config.
> Hence just running mysqladmin will return the values for the Hive MySQL 
> instance.
> The pid dile name is parsed by a new method which has been created to obatin 
> it from the mysqladmin variables return.
> The status re

Re: Review Request 48766: MySQL service status needs to be more robust

[Juanjo Marron]

> On June 15, 2016, 11:44 p.m., Andrew Onischuk wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py,
> >  line 54
> > <https://reviews.apache.org/r/48766/diff/1/?file=1420515#file1420515line54>
> >
> > We should probably do a checked_call here to give an exception with a 
> > good information in case we cannot do this.
> >     
> > Also why to we need timeout here?
> 
> Juanjo  Marron wrote:
> Hi Andrew!
> Thanks for the quick review
> 
> I will remove the timeout. I saw several ps -ef calls fixing the timeout 
> and I thought it could be appropiate.
> 
> Regarding the check call. I dont know if I followed you , but:
> If the shell call  fails in the mysqladmin command, mysql_pid_file will 
> be None (meaning mysql service is not running) and check_process_status() 
> will throw ComponentIsNotRunning exception as expected
> I could capture a log message:
> else:
> Logger.warning('mysql process not running')
>     
> but I think it will be reduntant with the exception.
> 
> What do you think?
> 
> Juanjo  Marron wrote:
> Ohh I see, I guess you are refering to shell.checked_call() for testing. 
> I was not aware of this resource. (Always learning, sorry)
> Any good eaxmple I could follow?
> 
> Thanks
> 
> Andrew Onischuk wrote:
> Can we do something like this:
> 
> 
> def get_mysql_pid_file():
>   cmd = 'mysqladmin variables'
>   code, output = shell.checked_call(cmd)
>   
>   for line in output.splitlines():
> if (line.find("pid_file") != -1):
>   mysql_pid_file  = line.split()[3].strip()
>   break
>   else:
> raise Fail(format("Output of '{cmd}' didn't contain pid_file. 
> Output: {output}"))  
>   return mysql_pid_file 
>   
>   
> Also please make sure 'mysqladmin variables' is accessible on 
> Suse/Ubuntu/Centos.

Added new diff following Andrew intructions

Thanks for the comments


- Juanjo


-----------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48766/#review137885
---


On June 16, 2016, 9:20 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48766/
> ---
> 
> (Updated June 16, 2016, 9:20 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Dmitro 
> Lisnichenko.
> 
> 
> Bugs: AMBARI-13238
> https://issues.apache.org/jira/browse/AMBARI-13238
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The MySQL service status in mysql_service.py simply checks for a process with 
> name mysqld. In our environment, a different service ran another MySQL 
> instance on that node and as a result, the status of the MySQL service in 
> Hive showed green (because it could find a mysqld process) even though the 
> instance used by Hive wasn't started. That also made the "Start Service" 
> action for Hive fail, because the metastore service couldn't connect to the 
> MySQL database.
> 
> The proposed fix makes the service check more robust by retrieving the 
> pid_file of the MySQL instance first by running "mysqladmin variables" and 
> parsing out the pid_file. Then it checks if the process exists. 
> 
> A new pacth is proposed based on the reviews added to the original one 
> (https://reviews.apache.org/r/39146/)
> 
> The patch relies now on the pid (similar to other status check). mysql 
> pid_file is not known a priori (it is not a service property similar to other 
> ambari components) and it depends on the OS. 
> The pid file location is obatined with  "mysqladmin variables" command (which 
> seems recognized by all the Ambari supported OS). 
> The Hive MySQL server instance is started without passing in any parameters 
> so It uses the default configuration. Any other MySQL instance that could be 
> running on the machine would need to be started with explicit config.
> Hence just running mysqladmin will return the values for the Hive MySQL 
> instance.
> The pid dile name is parsed by a new method which has been created to obatin 
> it from the mysqladmin variables return.
> The status relies now on check_process_status() wich is already an ambari 
> function.

Re: Review Request 48766: MySQL service status needs to be more robust

[Juanjo Marron]

on that 
could create conflicts with others mysql instances working on the same node.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py
 7862774 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_mysql_server.py 827f6f7 

Diff: https://reviews.apache.org/r/48766/diff/


Testing
---

+1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12810584/AMBARI-13238.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7367//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7367//console
This message is automatically generated.


Thanks,

Juanjo  Marron

Re: Review Request 48766: MySQL service status needs to be more robust

[Juanjo Marron]

> On June 15, 2016, 11:44 p.m., Andrew Onischuk wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py,
> >  line 54
> > <https://reviews.apache.org/r/48766/diff/1/?file=1420515#file1420515line54>
> >
> > We should probably do a checked_call here to give an exception with a 
> > good information in case we cannot do this.
> >     
> > Also why to we need timeout here?
> 
> Juanjo  Marron wrote:
> Hi Andrew!
> Thanks for the quick review
> 
> I will remove the timeout. I saw several ps -ef calls fixing the timeout 
> and I thought it could be appropiate.
> 
> Regarding the check call. I dont know if I followed you , but:
> If the shell call  fails in the mysqladmin command, mysql_pid_file will 
> be None (meaning mysql service is not running) and check_process_status() 
> will throw ComponentIsNotRunning exception as expected
> I could capture a log message:
> else:
> Logger.warning('mysql process not running')
> 
> but I think it will be reduntant with the exception.
> 
> What do you think?

Ohh I see, I guess you are refering to shell.checked_call() for testing. I was 
not aware of this resource. (Always learning, sorry)
Any good eaxmple I could follow?

Thanks


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48766/#review137885
---


On June 15, 2016, 10:39 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48766/
> ---
> 
> (Updated June 15, 2016, 10:39 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Dmitro 
> Lisnichenko.
> 
> 
> Bugs: AMBARI-13238
> https://issues.apache.org/jira/browse/AMBARI-13238
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The MySQL service status in mysql_service.py simply checks for a process with 
> name mysqld. In our environment, a different service ran another MySQL 
> instance on that node and as a result, the status of the MySQL service in 
> Hive showed green (because it could find a mysqld process) even though the 
> instance used by Hive wasn't started. That also made the "Start Service" 
> action for Hive fail, because the metastore service couldn't connect to the 
> MySQL database.
> 
> The proposed fix makes the service check more robust by retrieving the 
> pid_file of the MySQL instance first by running "mysqladmin variables" and 
> parsing out the pid_file. Then it checks if the process exists. 
> 
> A new pacth is proposed based on the reviews added to the original one 
> (https://reviews.apache.org/r/39146/)
> 
> The patch relies now on the pid (similar to other status check). mysql 
> pid_file is not known a priori (it is not a service property similar to other 
> ambari components) and it depends on the OS. 
> The pid file location is obatined with  "mysqladmin variables" command (which 
> seems recognized by all the Ambari supported OS). 
> The Hive MySQL server instance is started without passing in any parameters 
> so It uses the default configuration. Any other MySQL instance that could be 
> running on the machine would need to be started with explicit config.
> Hence just running mysqladmin will return the values for the Hive MySQL 
> instance.
> The pid dile name is parsed by a new method which has been created to obatin 
> it from the mysqladmin variables return.
> The status relies now on check_process_status() wich is already an ambari 
> function.
> Unit Test have been modified accordingly to avoid the pgrep verification that 
> could create conflicts with others mysql instances working on the same node.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py
>  7862774 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_mysql_server.py 
> 827f6f7 
> 
> Diff: https://reviews.apache.org/r/48766/diff/
> 
> 
> Testing
> ---
> 
> +1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12810584/AMBARI-13238.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 1 new or modified test files.
> +1 javac. The applied patc

Re: Review Request 48766: MySQL service status needs to be more robust

[Juanjo Marron]

> On June 15, 2016, 11:44 p.m., Andrew Onischuk wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py,
> >  line 54
> > <https://reviews.apache.org/r/48766/diff/1/?file=1420515#file1420515line54>
> >
> > We should probably do a checked_call here to give an exception with a 
> > good information in case we cannot do this.
> > 
> > Also why to we need timeout here?

Hi Andrew!
Thanks for the quick review

I will remove the timeout. I saw several ps -ef calls fixing the timeout and I 
thought it could be appropiate.

Regarding the check call. I dont know if I followed you , but:
If the shell call  fails in the mysqladmin command, mysql_pid_file will be None 
(meaning mysql service is not running) and check_process_status() will throw 
ComponentIsNotRunning exception as expected
I could capture a log message:
else:
Logger.warning('mysql process not running')

but I think it will be reduntant with the exception.

What do you think?


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48766/#review137885
-----------


On June 15, 2016, 10:39 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48766/
> ---
> 
> (Updated June 15, 2016, 10:39 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Dmitro 
> Lisnichenko.
> 
> 
> Bugs: AMBARI-13238
> https://issues.apache.org/jira/browse/AMBARI-13238
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The MySQL service status in mysql_service.py simply checks for a process with 
> name mysqld. In our environment, a different service ran another MySQL 
> instance on that node and as a result, the status of the MySQL service in 
> Hive showed green (because it could find a mysqld process) even though the 
> instance used by Hive wasn't started. That also made the "Start Service" 
> action for Hive fail, because the metastore service couldn't connect to the 
> MySQL database.
> 
> The proposed fix makes the service check more robust by retrieving the 
> pid_file of the MySQL instance first by running "mysqladmin variables" and 
> parsing out the pid_file. Then it checks if the process exists. 
> 
> A new pacth is proposed based on the reviews added to the original one 
> (https://reviews.apache.org/r/39146/)
> 
> The patch relies now on the pid (similar to other status check). mysql 
> pid_file is not known a priori (it is not a service property similar to other 
> ambari components) and it depends on the OS. 
> The pid file location is obatined with  "mysqladmin variables" command (which 
> seems recognized by all the Ambari supported OS). 
> The Hive MySQL server instance is started without passing in any parameters 
> so It uses the default configuration. Any other MySQL instance that could be 
> running on the machine would need to be started with explicit config.
> Hence just running mysqladmin will return the values for the Hive MySQL 
> instance.
> The pid dile name is parsed by a new method which has been created to obatin 
> it from the mysqladmin variables return.
> The status relies now on check_process_status() wich is already an ambari 
> function.
> Unit Test have been modified accordingly to avoid the pgrep verification that 
> could create conflicts with others mysql instances working on the same node.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py
>  7862774 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_mysql_server.py 
> 827f6f7 
> 
> Diff: https://reviews.apache.org/r/48766/diff/
> 
> 
> Testing
> ---
> 
> +1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12810584/AMBARI-13238.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 1 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7367//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7367//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Review Request 48766: MySQL service status needs to be more robust

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48766/
---

Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Dmitro 
Lisnichenko.


Bugs: AMBARI-13238
https://issues.apache.org/jira/browse/AMBARI-13238


Repository: ambari


Description
---

The MySQL service status in mysql_service.py simply checks for a process with 
name mysqld. In our environment, a different service ran another MySQL instance 
on that node and as a result, the status of the MySQL service in Hive showed 
green (because it could find a mysqld process) even though the instance used by 
Hive wasn't started. That also made the "Start Service" action for Hive fail, 
because the metastore service couldn't connect to the MySQL database.

The proposed fix makes the service check more robust by retrieving the pid_file 
of the MySQL instance first by running "mysqladmin variables" and parsing out 
the pid_file. Then it checks if the process exists. 

A new pacth is proposed based on the reviews added to the original one 
(https://reviews.apache.org/r/39146/)

The patch relies now on the pid (similar to other status check). mysql pid_file 
is not known a priori (it is not a service property similar to other ambari 
components) and it depends on the OS. 
The pid file location is obatined with  "mysqladmin variables" command (which 
seems recognized by all the Ambari supported OS). 
The Hive MySQL server instance is started without passing in any parameters so 
It uses the default configuration. Any other MySQL instance that could be 
running on the machine would need to be started with explicit config.
Hence just running mysqladmin will return the values for the Hive MySQL 
instance.
The pid dile name is parsed by a new method which has been created to obatin it 
from the mysqladmin variables return.
The status relies now on check_process_status() wich is already an ambari 
function.
Unit Test have been modified accordingly to avoid the pgrep verification that 
could create conflicts with others mysql instances working on the same node.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py
 7862774 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_mysql_server.py 827f6f7 

Diff: https://reviews.apache.org/r/48766/diff/


Testing
---

+1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12810584/AMBARI-13238.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7367//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7367//console
This message is automatically generated.


Thanks,

Juanjo  Marron

Re: Review Request 48184: clean up import * for SPARK2 service scripts in common-services

[Juanjo Marron]

> On June 7, 2016, 6:45 p.m., Alejandro Fernandez wrote:
> > Ship It!
> 
> Juanjo  Marron wrote:
> I dont have privileges to commit. Could someone deliver it to trunk so I 
> can mark the JIRA https://issues.apache.org/jira/browse/AMBARI-16101 as 
> complete, please?
> Thanks
> 
> Jayush Luniya wrote:
> Will commit

Thanks Jayush!


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48184/#review136516
---


On June 7, 2016, 4:09 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48184/
> ---
> 
> (Updated June 7, 2016, 4:09 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16916
> https://issues.apache.org/jira/browse/AMBARI-16916
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for SPARK2 service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/job_history_server.py
>  b3720f0 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
>  3316f78 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/service_check.py
>  694f046 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py
>  9316ba9 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_client.py
>  434b4b1 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
>  2eae3e7 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_thrift_server.py
>  be65986 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/status_params.py
>  4196638 
> 
> Diff: https://reviews.apache.org/r/48184/diff/
> 
> 
> Testing
> ---
> 
> added a comment - 7 minutes ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12807806/AMBARI-16916.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7156//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7156//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 48184: clean up import * for SPARK2 service scripts in common-services

[Juanjo Marron]

> On June 7, 2016, 6:45 p.m., Alejandro Fernandez wrote:
> > Ship It!

I dont have privileges to commit. Could someone deliver it to trunk so I can 
mark the JIRA https://issues.apache.org/jira/browse/AMBARI-16101 as complete, 
please?
Thanks


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48184/#review136516
---


On June 7, 2016, 4:09 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48184/
> ---
> 
> (Updated June 7, 2016, 4:09 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16916
> https://issues.apache.org/jira/browse/AMBARI-16916
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for SPARK2 service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/job_history_server.py
>  b3720f0 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
>  3316f78 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/service_check.py
>  694f046 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py
>  9316ba9 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_client.py
>  434b4b1 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
>  2eae3e7 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_thrift_server.py
>  be65986 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/status_params.py
>  4196638 
> 
> Diff: https://reviews.apache.org/r/48184/diff/
> 
> 
> Testing
> ---
> 
> added a comment - 7 minutes ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12807806/AMBARI-16916.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7156//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7156//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Review Request 48184: clean up import * for SPARK2 service scripts in common-services

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48184/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.


Bugs: AMBARI-16916
https://issues.apache.org/jira/browse/AMBARI-16916


Repository: ambari


Description
---

Python code at at common-services level used generic imports form 
resource_management (from resource_management import *)
Ideally, for easier code tracking and performance, these import should be more 
specific, such as: 
from resource_management.libraries.script.script import Script
from resource_management.core.resources.system import Directory
This patch cleans up import * from resource_management for SPARK2 service 
scripts in common-services


Diffs
-

  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/job_history_server.py
 b3720f0 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
 3316f78 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/service_check.py
 694f046 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py
 9316ba9 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_client.py
 434b4b1 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
 2eae3e7 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_thrift_server.py
 be65986 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/status_params.py
 4196638 

Diff: https://reviews.apache.org/r/48184/diff/


Testing
---

added a comment - 7 minutes ago
-1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12807806/AMBARI-16916.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7156//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7156//console
This message is automatically generated.


Thanks,

Juanjo  Marron

Re: Review Request 47653: clean up import * for OOZIE service scripts in common-services

[Juanjo Marron]

> On June 1, 2016, 2:33 a.m., Jayush Luniya wrote:
> > Patch doesnt apply cleanly. Can you rebase the patch and resolve conflicts?
> 
> Juanjo  Marron wrote:
> New patch submitted to https://issues.apache.org/jira/browse/AMBARI-16672.
> Waiting for HAdoop QA review

Patch applied cleanly by Hadoop QA

Hadoop QA added a comment - Yesterday
-1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12807512/AMBARI-16672.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7125//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7125//console
This message is automatically generated.


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47653/#review135750
---


On May 20, 2016, 6:14 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47653/
> ---
> 
> (Updated May 20, 2016, 6:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16672
> https://issues.apache.org/jira/browse/AMBARI-16672
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for OOzie service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
>  b3c6537 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
>  3060353 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  75924c5 
> 
> Diff: https://reviews.apache.org/r/47653/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> OOZIE fresh installation and service check
> 
> Hadoop QA added a comment - 4 minutes ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12804552/AMBARI-16672.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6920//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6920//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47923: clean up import * for SPARK service scripts in common-services

[Juanjo Marron]

> On June 1, 2016, 2:53 a.m., Jayush Luniya wrote:
> > Patch doesnt apply cleanly. Can you rebase the patch?
> 
> Juanjo  Marron wrote:
> Patch submitted to https://issues.apache.org/jira/browse/AMBARI-16797.
> Waiting for Hadoop QA review

Patch applied cleanly by Hadoop QA

Hadoop QA added a comment - 6 minutes ago
-1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12807525/AMBARI-16797.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7124//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7124//console
This message is automatically generated.


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47923/#review135754
---


On May 26, 2016, 11:04 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47923/
> ---
> 
> (Updated May 26, 2016, 11:04 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16797
> https://issues.apache.org/jira/browse/AMBARI-16797
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for SPARK service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/job_history_server.py
>  bccd714 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  c5f3eb6 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py
>  694f046 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_spark.py
>  eca8534 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_client.py
>  3838061 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_thrift_server.py
>  9311454 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/status_params.py
>  86e7f7d 
> 
> Diff: https://reviews.apache.org/r/47923/diff/
> 
> 
> Testing
> ---
> 
> Passed mvn clean test -DskipSurefireTests
> PIG fresh installation and service check
> 
> Hadoop QA added a comment - 1 hour ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12805785/AMBARI-16797.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6981//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6981//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47923: clean up import * for SPARK service scripts in common-services

[Juanjo Marron]

> On June 1, 2016, 2:53 a.m., Jayush Luniya wrote:
> > Patch doesnt apply cleanly. Can you rebase the patch?

Patch submitted to https://issues.apache.org/jira/browse/AMBARI-16797.
Waiting for Hadoop QA review


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47923/#review135754
---


On May 26, 2016, 11:04 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47923/
> ---
> 
> (Updated May 26, 2016, 11:04 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16797
> https://issues.apache.org/jira/browse/AMBARI-16797
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for SPARK service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/job_history_server.py
>  bccd714 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  c5f3eb6 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py
>  694f046 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_spark.py
>  eca8534 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_client.py
>  3838061 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_thrift_server.py
>  9311454 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/status_params.py
>  86e7f7d 
> 
> Diff: https://reviews.apache.org/r/47923/diff/
> 
> 
> Testing
> ---
> 
> Passed mvn clean test -DskipSurefireTests
> PIG fresh installation and service check
> 
> Hadoop QA added a comment - 1 hour ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12805785/AMBARI-16797.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6981//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6981//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47653: clean up import * for OOZIE service scripts in common-services

[Juanjo Marron]

> On June 1, 2016, 2:33 a.m., Jayush Luniya wrote:
> > Patch doesnt apply cleanly. Can you rebase the patch and resolve conflicts?

New patch submitted to https://issues.apache.org/jira/browse/AMBARI-16672.
Waiting for HAdoop QA review


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47653/#review135750
---


On May 20, 2016, 6:14 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47653/
> ---
> 
> (Updated May 20, 2016, 6:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16672
> https://issues.apache.org/jira/browse/AMBARI-16672
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for OOzie service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
>  b3c6537 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
>  3060353 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  75924c5 
> 
> Diff: https://reviews.apache.org/r/47653/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> OOZIE fresh installation and service check
> 
> Hadoop QA added a comment - 4 minutes ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12804552/AMBARI-16672.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6920//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6920//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47963: clean up import * for YARN service

[Juanjo Marron]

> On June 1, 2016, 5:49 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py,
> >  line 91
> > <https://reviews.apache.org/r/47963/diff/1/?file=1397177#file1397177line91>
> >
> > @Juanjo, it looks like check_process_status is not imported for YARN 
> > nodemanager and will cause problems. Can you submit an addendum patch with 
> > this change?
> 
> Juanjo  Marron wrote:
> Hi Jayush, 
> Yes, ill work on fixing it. Can you tell me when you hit this issue for 
> verification, please?

New patch AMBARI-16849-2.patch added to solve missing import 
check_process_status for YARN nodemanager service:
https://issues.apache.org/jira/browse/AMBARI-16849


Created new review board
https://reviews.apache.org/r/48143/


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47963/#review135820
-------


On May 27, 2016, 4:33 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47963/
> ---
> 
> (Updated May 27, 2016, 4:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16849
> https://issues.apache.org/jira/browse/AMBARI-16849
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for YARN service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py
>  4ec6aa7 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py
>  34c683a 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py
>  44015bf 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py
>  13172ee 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py
>  3ea3d75 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
>  7be49d5 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager_upgrade.py
>  1c886f9 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_windows.py
>  0f8ce73 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py
>  b1179b9 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  792a681 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  0e2c519 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py
>  4d65a40 
> 
> Diff: https://reviews.apache.org/r/47963/diff/
> 
> 
> Testing
> ---
> 
> Passed mvn clean test -DskipSurefireTests
> YARN fresh installation and service check
> 
> Hadoop QA added a comment - Yesterday
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12806423/AMBARI-16849.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7005//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7005//console
> This message is automatically generated.
> Reply
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 48143: Missing import check_process_status for YARN nodemanager service

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48143/
---

(Updated June 1, 2016, 6:26 p.m.)


Review request for Ambari and Jayush Luniya.


Summary (updated)
-

Missing import check_process_status for YARN nodemanager service


Bugs: AMBARI-16849
https://issues.apache.org/jira/browse/AMBARI-16849


Repository: ambari


Description (updated)
---

Missing import check_process_status for YARN nodemanager service


Diffs
-

  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
 038ccb9 

Diff: https://reviews.apache.org/r/48143/diff/


Testing
---

Added after Jayush Luniya comment on https://reviews.apache.org/r/47963


Thanks,

Juanjo  Marron

Review Request 48143: Missing import check_process_status for HDFS nodemanager service

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48143/
---

Review request for Ambari and Jayush Luniya.


Bugs: AMBARI-16849
https://issues.apache.org/jira/browse/AMBARI-16849


Repository: ambari


Description
---

Missing import check_process_status for HDFS nodemanager service


Diffs
-

  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
 038ccb9 

Diff: https://reviews.apache.org/r/48143/diff/


Testing
---

Added after Jayush Luniya comment on https://reviews.apache.org/r/47963


Thanks,

Juanjo  Marron

Re: Review Request 47963: clean up import * for YARN service

[Juanjo Marron]

> On June 1, 2016, 5:49 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py,
> >  line 91
> > <https://reviews.apache.org/r/47963/diff/1/?file=1397177#file1397177line91>
> >
> > @Juanjo, it looks like check_process_status is not imported for YARN 
> > nodemanager and will cause problems. Can you submit an addendum patch with 
> > this change?

Hi Jayush, 
Yes, ill work on fixing it. Can you tell me when you hit this issue for 
verification, please?


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47963/#review135820
-----------


On May 27, 2016, 4:33 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47963/
> ---
> 
> (Updated May 27, 2016, 4:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16849
> https://issues.apache.org/jira/browse/AMBARI-16849
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for YARN service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py
>  4ec6aa7 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py
>  34c683a 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py
>  44015bf 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py
>  13172ee 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py
>  3ea3d75 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
>  7be49d5 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager_upgrade.py
>  1c886f9 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_windows.py
>  0f8ce73 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py
>  b1179b9 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  792a681 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  0e2c519 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py
>  4d65a40 
> 
> Diff: https://reviews.apache.org/r/47963/diff/
> 
> 
> Testing
> ---
> 
> Passed mvn clean test -DskipSurefireTests
> YARN fresh installation and service check
> 
> Hadoop QA added a comment - Yesterday
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12806423/AMBARI-16849.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7005//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7005//console
> This message is automatically generated.
> Reply
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47964: clean up import * for ZOOKEEPER service

[Juanjo Marron]

> On June 1, 2016, 3:07 a.m., Jayush Luniya wrote:
> > Ship It!

Thanks for the reviews and fo commitying to trunk


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47964/#review135757
---


On May 27, 2016, 4:36 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47964/
> ---
> 
> (Updated May 27, 2016, 4:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16850
> https://issues.apache.org/jira/browse/AMBARI-16850
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for ZOOKEEPER service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/params_windows.py
>  c36e152 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/service_check.py
>  622a5eb 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/zookeeper.py
>  e0ba54b 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/zookeeper_client.py
>  de4d6e1 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/zookeeper_service.py
>  9f943d7 
> 
> Diff: https://reviews.apache.org/r/47964/diff/
> 
> 
> Testing
> ---
> 
> Passed mvn clean test -DskipSurefireTests
> ZOOKEEPER fresh installation and service check
> 
> Hadoop QA added a comment - Yesterday
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12806418/AMBARI-16850.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7006//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7006//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Review Request 47965: clean up import * for RANGER service

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47965/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.


Bugs: AMBARI-16743
https://issues.apache.org/jira/browse/AMBARI-16743


Repository: ambari


Description
---

Python code at at common-services level used generic imports form 
resource_management (from resource_management import *)
Ideally, for easier code tracking and performance, these import should be more 
specific, such as: 
from resource_management.libraries.script.script import Script
from resource_management.core.resources.system import Directory
This patch cleans up import * from resource_management for RANGER service 
scripts in common-services


Diffs
-

  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py
 2c7bd3c 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py
 3dc4914 

Diff: https://reviews.apache.org/r/47965/diff/


Testing
---

Hadoop QA added a comment - 3 hours ago
-1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12806494/AMBARI-16743.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7015//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7015//console
This message is automatically generated.


Thanks,

Juanjo  Marron

Review Request 47964: clean up import * for ZOOKEEPER service

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47964/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.


Bugs: AMBARI-16850
https://issues.apache.org/jira/browse/AMBARI-16850


Repository: ambari


Description
---

Python code at at common-services level used generic imports form 
resource_management (from resource_management import *)
Ideally, for easier code tracking and performance, these import should be more 
specific, such as: 
from resource_management.libraries.script.script import Script
from resource_management.core.resources.system import Directory
This patch cleans up import * from resource_management for ZOOKEEPER service 
scripts in common-services


Diffs
-

  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/params_windows.py
 c36e152 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/service_check.py
 622a5eb 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/zookeeper.py
 e0ba54b 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/zookeeper_client.py
 de4d6e1 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/zookeeper_service.py
 9f943d7 

Diff: https://reviews.apache.org/r/47964/diff/


Testing
---

Passed mvn clean test -DskipSurefireTests
ZOOKEEPER fresh installation and service check

Hadoop QA added a comment - Yesterday
-1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12806418/AMBARI-16850.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7006//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7006//console
This message is automatically generated.


Thanks,

Juanjo  Marron

Review Request 47963: clean up import * for YARN service

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47963/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.


Bugs: AMBARI-16849
https://issues.apache.org/jira/browse/AMBARI-16849


Repository: ambari


Description
---

Python code at at common-services level used generic imports form 
resource_management (from resource_management import *)
Ideally, for easier code tracking and performance, these import should be more 
specific, such as: 
from resource_management.libraries.script.script import Script
from resource_management.core.resources.system import Directory
This patch cleans up import * from resource_management for YARN service scripts 
in common-services


Diffs
-

  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py
 4ec6aa7 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py
 34c683a 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py
 44015bf 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py
 13172ee 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py
 3ea3d75 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
 7be49d5 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager_upgrade.py
 1c886f9 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_windows.py
 0f8ce73 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py
 b1179b9 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
 792a681 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
 0e2c519 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py
 4d65a40 

Diff: https://reviews.apache.org/r/47963/diff/


Testing
---

Passed mvn clean test -DskipSurefireTests
YARN fresh installation and service check

Hadoop QA added a comment - Yesterday
-1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12806423/AMBARI-16849.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7005//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7005//console
This message is automatically generated.
Reply


Thanks,

Juanjo  Marron

Review Request 47962: clean up import * for STORM, TEZ and ZEPPELIN services

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47962/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.


Bugs: AMBARI-16848
https://issues.apache.org/jira/browse/AMBARI-16848


Repository: ambari


Description
---

Python code at at common-services level used generic imports form 
resource_management (from resource_management import *)
Ideally, for easier code tracking and performance, these import should be more 
specific, such as: 
from resource_management.libraries.script.script import Script
from resource_management.core.resources.system import Directory
This patch cleans up import * from resource_management for PIG service scripts 
in common-servicesPython code at at common-services level used generic imports 
form resource_management (from resource_management import *)
Ideally, for easier code tracking and performance, these import should be more 
specific, such as: 
from resource_management.libraries.script.script import Script
from resource_management.core.resources.system import Directory
This patch cleans up import * from resource_management for STORM, TEZ and 
ZEPPELIN service scripts in common-services


Diffs
-

  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_windows.py
 88e6246 
  
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez.py
 198674d 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/service_check.py
 5dfdcad 

Diff: https://reviews.apache.org/r/47962/diff/


Testing
---

Passed mvn clean test -DskipSurefireTests
STORM, TEZ and ZEPPELIN  fresh installation and service check

Hadoop QA added a comment - Yesterday
-1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12806417/AMBARI-16848.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7000//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7000//console
This message is automatically generated.


Thanks,

Juanjo  Marron

Review Request 47934: clean up import * for SLIDER service scripts in common-services

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47934/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.


Bugs: AMBARI-16744
https://issues.apache.org/jira/browse/AMBARI-16744


Repository: ambari


Description
---

Python code at at common-services level used generic imports form 
resource_management (from resource_management import *)
Ideally, for easier code tracking and performance, these import should be more 
specific, such as: 
from resource_management.libraries.script.script import Script
from resource_management.core.resources.system import Directory
This patch cleans up import * from resource_management for SLIDER service 
scripts in common-services


Diffs
-

  
ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params_windows.py
 fdb8160 
  
ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/service_check.py
 91e4959 
  
ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider.py
 8d80700 
  
ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py
 13f7848 

Diff: https://reviews.apache.org/r/47934/diff/


Testing
---

Passed mvn clean test -DskipSurefireTests
SLIDER fresh installation and service check

Hadoop QA added a comment - 18 minutes ago
-1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12805250/AMBARI-16744.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6988//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6988//console
This message is automatically generated.
Reply


Thanks,

Juanjo  Marron

Review Request 47923: clean up import * for SPARK service scripts in common-services

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47923/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.


Bugs: AMBARI-16797
https://issues.apache.org/jira/browse/AMBARI-16797


Repository: ambari


Description
---

Python code at at common-services level used generic imports form 
resource_management (from resource_management import *)
Ideally, for easier code tracking and performance, these import should be more 
specific, such as: 
from resource_management.libraries.script.script import Script
from resource_management.core.resources.system import Directory
This patch cleans up import * from resource_management for SPARK service 
scripts in common-services


Diffs
-

  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/job_history_server.py
 bccd714 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
 c5f3eb6 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py
 694f046 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_spark.py
 eca8534 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_client.py
 3838061 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_thrift_server.py
 9311454 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/status_params.py
 86e7f7d 

Diff: https://reviews.apache.org/r/47923/diff/


Testing
---

Passed mvn clean test -DskipSurefireTests
PIG fresh installation and service check

Hadoop QA added a comment - 1 hour ago
-1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12805785/AMBARI-16797.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6981//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6981//console
This message is automatically generated.


Thanks,

Juanjo  Marron

Review Request 47922: clean up import * for KNOX service scripts in common-services

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47922/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.


Bugs: AMBARI-16669
https://issues.apache.org/jira/browse/AMBARI-16669


Repository: ambari


Description
---

Python code at at common-services level used generic imports form 
resource_management (from resource_management import *)
Ideally, for easier code tracking and performance, these import should be more 
specific, such as: 
from resource_management.libraries.script.script import Script
from resource_management.core.resources.system import Directory
This patch cleans up import * from resource_management for KNOX service scripts 
in common-services


Diffs
-

  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py
 fbd879f 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py
 1917369 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_ldap.py
 dee0154 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 5d454de 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_windows.py
 e7a3747 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/service_check.py
 5e9b89e 

Diff: https://reviews.apache.org/r/47922/diff/


Testing
---

Passed mvn clean test -DskipSurefireTests
KNOX fresh installation and service check

Hadoop QA added a comment - 7 minutes ago
-1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12805363/AMBARI-16669.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6985//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6985//console
This message is automatically generated.


Thanks,

Juanjo  Marron

Review Request 47669: import missing check_process_status

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47669/
---

Review request for Ambari, Alejandro Fernandez and Jayush Luniya.


Bugs: AMBARI-16362
https://issues.apache.org/jira/browse/AMBARI-16362


Repository: ambari


Description
---

Several import check_process_status were missed in previous cleanUp commits


Diffs
-

  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_master.py
 c045a91 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_regionserver.py
 8735b2d 
  
ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/ganglia_monitor.py
 26f96c7 
  
ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/ganglia_server.py
 246b1d9 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
 f63886e 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
 3376ac9 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py
 3421053 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
 091997e 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
 08cb722 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_server.py
 7fe02ab 

Diff: https://reviews.apache.org/r/47669/diff/


Testing
---

Thanks to Alejandro comment on AMBARI-16362, several import  
check_process_status missing were found.

Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py",
 line 151, in 
SNameNode().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 254, in execute
method(env)
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 665, in restart
self.status(env)
  File 
"/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py",
 line 61, in status
snamenode(action="status")
  File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", 
line 89, in thunk
return fn(*args, **kwargs)
  File 
"/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py",
 line 52, in snamenode
check_process_status(status_params.snamenode_pid_file)
NameError: global name 'check_process_status' is not defined


It was not captured on the UTs, fresh installation and service_check tests


Thanks,

Juanjo  Marron

Review Request 47653: clean up import * for OOZIE service scripts in common-services

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47653/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.


Bugs: AMBARI-16672
https://issues.apache.org/jira/browse/AMBARI-16672


Repository: ambari


Description
---

Python code at at common-services level used generic imports form 
resource_management (from resource_management import *)
Ideally, for easier code tracking and performance, these import should be more 
specific, such as: 
from resource_management.libraries.script.script import Script
from resource_management.core.resources.system import Directory
This patch cleans up import * from resource_management for OOzie service 
scripts in common-services


Diffs
-

  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
 b3c6537 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
 3060353 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 75924c5 

Diff: https://reviews.apache.org/r/47653/diff/


Testing
---

Pass mvn clean test -DskipSurefireTests
OOZIE fresh installation and service check

Hadoop QA added a comment - 4 minutes ago
-1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12804552/AMBARI-16672.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6920//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6920//console
This message is automatically generated.


Thanks,

Juanjo  Marron

Re: Review Request 47560: clean up import * for Kerberos service scripts in common-services

[Juanjo Marron]

> On May 19, 2016, 9:51 p.m., Jayush Luniya wrote:
> > Ship It!
> 
> Jayush Luniya wrote:
> @Juanjo 
> Committed all your patches.

Thanks a lot Jayush
More coming


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47560/#review134050
---


On May 18, 2016, 10:14 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47560/
> ---
> 
> (Updated May 18, 2016, 10:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16645
> https://issues.apache.org/jira/browse/AMBARI-16645
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for Hive service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py
>  e06b13f 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
>  906d521 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/service_check.py
>  7c09171 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/status_params.py
>  bbae4a3 
> 
> Diff: https://reviews.apache.org/r/47560/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> Kerberos client installation 
> 
> Hadoop QA added a comment - 7 minutes ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12803967/AMBARI-16645.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6885//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6885//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Review Request 47619: clean up import * for MAHOUT service scripts in common-services

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47619/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.


Bugs: AMBARI-16671
https://issues.apache.org/jira/browse/AMBARI-16671


Repository: ambari


Description
---

Python code at at common-services level used generic imports form 
resource_management (from resource_management import *)
Ideally, for easier code tracking and performance, these import should be more 
specific, such as: 
from resource_management.libraries.script.script import Script
from resource_management.core.resources.system import Directory
This patch cleans up import * from resource_management for Hive service scripts 
in common-services


Diffs
-

  
ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout.py
 f2c3c18 
  
ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py
 b6fc153 
  
ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py
 11a85e1 

Diff: https://reviews.apache.org/r/47619/diff/


Testing
---

Pass mvn clean test -DskipSurefireTests
MAHOUT fresh installation and service check

Hadoop QA added a comment - 2 hours ago
-1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12804463/AMBARI-16671.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6906//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6906//console


Thanks,

Juanjo  Marron

Re: Review Request 47560: clean up import * for Kerberos service scripts in common-services

[Juanjo Marron]

> On May 18, 2016, 10:16 p.m., Alejandro Fernandez wrote:
> > Ship It!

Can someone please ship this patch for me? I do not have committer privileges


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47560/#review133823
---


On May 18, 2016, 10:14 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47560/
> ---
> 
> (Updated May 18, 2016, 10:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16645
> https://issues.apache.org/jira/browse/AMBARI-16645
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for Hive service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py
>  e06b13f 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
>  906d521 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/service_check.py
>  7c09171 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/status_params.py
>  bbae4a3 
> 
> Diff: https://reviews.apache.org/r/47560/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> Kerberos client installation 
> 
> Hadoop QA added a comment - 7 minutes ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12803967/AMBARI-16645.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6885//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6885//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47477: clean up import * for HDFS service scripts in common-services

[Juanjo Marron]

> On May 18, 2016, 5:24 p.m., Alejandro Fernandez wrote:
> > Ship It!

Can someone please ship this patch for me? I do not have committer privileges


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47477/#review133767
---


On May 18, 2016, 4:49 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47477/
> ---
> 
> (Updated May 18, 2016, 4:49 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16362
> https://issues.apache.org/jira/browse/AMBARI-16362
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for HDFS service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
>  79c32e4 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py
>  1264284 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py
>  d9b76b8 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_datanode.py
>  a22fb99 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py
>  500ed15 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
>  9c5a124 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  b37f413 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_windows.py
>  da00985 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py
>  737ae04 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py
>  30eee07 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
>  ceee738 
> 
> Diff: https://reviews.apache.org/r/47477/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> HDFS fresh installation and service check
> Hadoop QA:
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12803107/AMBARI-16362.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6870//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6870//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47475: clean up import * for Hive service scripts in common-services

[Juanjo Marron]

> On May 18, 2016, 10:35 p.m., Matt wrote:
> > Ship It!

Can someone please ship this patch for me? I do not have committer privileges


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47475/#review133824
---


On May 18, 2016, 4:48 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47475/
> ---
> 
> (Updated May 18, 2016, 4:48 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16189
> https://issues.apache.org/jira/browse/AMBARI-16189
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for Hive service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat.py
>  45dcbe7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py
>  b37698e 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_service_check.py
>  07b4095 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py
>  da49450 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  e8532da 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
>  d0dd9bb 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_server.py
>  851dc02 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py
>  8b98ed1 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_users.py
>  c023548 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_utils.py
>  5006b56 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_windows.py
>  880fdb5 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/service_check.py
>  f7304f7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py
>  3acbc7b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
>  34687c4 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py
>  c24db4c 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
>  8e80d48 
> 
> Diff: https://reviews.apache.org/r/47475/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> HIVE fresh installation and service check
> 
> 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6869
> 
> 
> Hadoop QA added a comment - 8 minutes ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12802696/AMBARI-16189.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6869//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6869//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47541: clean up import * for HBase service scripts in common-services

[Juanjo Marron]

> On May 18, 2016, 10:35 p.m., Matt wrote:
> > Ship It!

Can someone please ship this patch for me? I do not have committer privileges


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47541/#review133825
---


On May 18, 2016, 4:41 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47541/
> ---
> 
> (Updated May 18, 2016, 4:41 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16408
> https://issues.apache.org/jira/browse/AMBARI-16408
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for Hive service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
>  d2f28f5 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py
>  f35a570 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_decommission.py
>  022465a 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
>  840411f 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
>  4001912 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_service.py
>  a6904f6 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_upgrade.py
>  2dc9883 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_windows.py
>  7d634cb 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py
>  6ecb58e 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/upgrade.py
>  b1a19e6 
> 
> Diff: https://reviews.apache.org/r/47541/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> Hbase fresh installation and service check
> 
> Hadoop QA added a comment - 2 hours ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12803349/AMBARI-16408.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6878//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6878//console
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47475: clean up import * for Hive service scripts in common-services

[Juanjo Marron]

> On May 18, 2016, 5:25 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py,
> >  line 27
> > <https://reviews.apache.org/r/47475/diff/1/?file=1385679#file1385679line27>
> >
> > How was this working before?

Python was importing it from functions in general, but I think it is a good 
practice to be more specific

There are plenty of exmaples in the.py common-services code. Other working 
example is: 
from resource_management.libraries.functions import Direction
where Direction is actually defined in from 
resource_management.libraries.functions.constants


Thanks for the review Alex


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47475/#review133768
-------


On May 18, 2016, 4:48 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47475/
> ---
> 
> (Updated May 18, 2016, 4:48 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16189
> https://issues.apache.org/jira/browse/AMBARI-16189
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for Hive service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat.py
>  45dcbe7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py
>  b37698e 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_service_check.py
>  07b4095 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py
>  da49450 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  e8532da 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
>  d0dd9bb 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_server.py
>  851dc02 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py
>  8b98ed1 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_users.py
>  c023548 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_utils.py
>  5006b56 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_windows.py
>  880fdb5 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/service_check.py
>  f7304f7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py
>  3acbc7b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
>  34687c4 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py
>  c24db4c 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
>  8e80d48 
> 
> Diff: https://reviews.apache.org/r/47475/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> HIVE fresh installation and service check
> 
> 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6869
> 
> 
> Hadoop QA added a comment - 8 minutes ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12802696/AMBARI-16189.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of java

Re: Review Request 47477: clean up import * for HDFS service scripts in common-services

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47477/
---

(Updated May 18, 2016, 4:49 p.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.


Bugs: AMBARI-16362
https://issues.apache.org/jira/browse/AMBARI-16362


Repository: ambari


Description
---

Python code at at common-services level used generic imports form 
resource_management (from resource_management import *)
Ideally, for easier code tracking and performance, these import should be more 
specific, such as: 
from resource_management.libraries.script.script import Script
from resource_management.core.resources.system import Directory
This patch cleans up import * from resource_management for HDFS service scripts 
in common-services


Diffs
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
 79c32e4 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py
 1264284 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py
 d9b76b8 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_datanode.py
 a22fb99 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py
 500ed15 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
 9c5a124 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
 b37f413 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_windows.py
 da00985 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py
 737ae04 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py
 30eee07 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
 ceee738 

Diff: https://reviews.apache.org/r/47477/diff/


Testing
---

Pass mvn clean test -DskipSurefireTests
HDFS fresh installation and service check
Hadoop QA:
-1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12803107/AMBARI-16362.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6870//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6870//console
This message is automatically generated.


Thanks,

Juanjo  Marron

Re: Review Request 47475: clean up import * for Hive service scripts in common-services

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47475/
---

(Updated May 18, 2016, 4:48 p.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.


Bugs: AMBARI-16189
https://issues.apache.org/jira/browse/AMBARI-16189


Repository: ambari


Description
---

Python code at at common-services level used generic imports form 
resource_management (from resource_management import *)
Ideally, for easier code tracking and performance, these import should be more 
specific, such as: 
from resource_management.libraries.script.script import Script
from resource_management.core.resources.system import Directory
This patch cleans up import * from resource_management for Hive service scripts 
in common-services


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat.py
 45dcbe7 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py
 b37698e 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_service_check.py
 07b4095 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py
 da49450 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
 e8532da 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
 d0dd9bb 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_server.py
 851dc02 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py
 8b98ed1 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_users.py
 c023548 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_utils.py
 5006b56 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_windows.py
 880fdb5 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/service_check.py
 f7304f7 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py
 3acbc7b 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
 34687c4 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py
 c24db4c 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
 8e80d48 

Diff: https://reviews.apache.org/r/47475/diff/


Testing
---

Pass mvn clean test -DskipSurefireTests
HIVE fresh installation and service check


https://builds.apache.org/job/Ambari-trunk-test-patch/6869


Hadoop QA added a comment - 8 minutes ago
-1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12802696/AMBARI-16189.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6869//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6869//console
This message is automatically generated.


Thanks,

Juanjo  Marron

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

[Juanjo Marron]

> On April 29, 2016, 10:34 p.m., Jayush Luniya wrote:
> > I think we need more testing on this apart from unit tests to ensure all 
> > imports are there.
> 
> Juanjo  Marron wrote:
> Hi Jayush,
> 
> Thanks for the review.
> I'll add this couple of missing imports to ACCUMULO service check
> 
> I reviewed UTs, I did a fresh installation, no service-check run though. 
> Ill do service check as well from now. Any other test you think can be 
> required?
> 
> Also, Atlas installation was failing in trunk (even without this change 
> set) so I would need to retry on top of a stable trunk versions
> 
> Juanjo  Marron wrote:
> Please, wait review for now, more test on these services is being 
> performed
> Thanks
> 
> Juanjo  Marron wrote:
> Hi Jasyuh, please could you review the final patch?
> 
> Thanks
> 
> Jayush Luniya wrote:
> @Juanjo,
> I am out of office and will review this patch tomorrow once I am back.

Great! Thanks


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46853/#review131209
---


On May 3, 2016, 6:12 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46853/
> ---
> 
> (Updated May 3, 2016, 6:12 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16175
> https://issues.apache.org/jira/browse/AMBARI-16175
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This  subtask cleans up import * from resource_management and replace it for 
> specific imports for:
> Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py
>  09a3d90 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_service.py
>  33d3273 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/service_check.py
>  a7067cb 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
>  3c3d804 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_service.py
>  eb1b6d7 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py
>  7fb9715 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_master.py
>  b769a0d 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_regionserver.py
>  cf0efef 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_service.py
>  4d0d7f3 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py
>  a5abe1c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  32b8fdb 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params_linux.py
>  21b491d 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py
>  3c4bffc 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py
>  2bdb4c0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  43c1ea6 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
>  4b08cbc 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  defd6f0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py
>  194a3fb 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py
>  4c54214 
>   
>

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

[Juanjo Marron]

/status_params.py
 0c69ca9 

Diff: https://reviews.apache.org/r/46853/diff/


Testing (updated)
---

Sucessfull tests by Hadoop QA
Manual fresh installation and service checks


Thanks,

Juanjo  Marron

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

[Juanjo Marron]

/status_params.py
 0c69ca9 

Diff: https://reviews.apache.org/r/46853/diff/


Testing
---

Sucessfull tests by Hadoop QA


Thanks,

Juanjo  Marron

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

[Juanjo Marron]

> On May 3, 2016, 12:32 a.m., Matt wrote:
> > Ship It!

Waiting for Hadoop QA to have new patch available with installation and service 
checks tests performed
Will upload it soon.
Thanks for the review


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46853/#review131430
---


On April 30, 2016, 12:51 a.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46853/
> ---
> 
> (Updated April 30, 2016, 12:51 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-16175
> https://issues.apache.org/jira/browse/AMBARI-16175
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This  subtask cleans up import * from resource_management and replace it for 
> specific imports for:
> Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py
>  09a3d90 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_service.py
>  33d3273 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/service_check.py
>  a7067cb 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
>  3c3d804 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_service.py
>  eb1b6d7 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py
>  7fb9715 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_master.py
>  b769a0d 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_regionserver.py
>  cf0efef 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_service.py
>  4d0d7f3 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py
>  a5abe1c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  32b8fdb 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params_linux.py
>  21b491d 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py
>  3c4bffc 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py
>  2bdb4c0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  43c1ea6 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
>  4b08cbc 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  defd6f0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py
>  194a3fb 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py
>  4c54214 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py
>  64ace1a 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
>  a201619 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server_upgrade.py
>  6277086 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_windows.py
>  b213028 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/service_check.py
>  473b7c3 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py
>  9df2ba6 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_check.py
>  25

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

[Juanjo Marron]

> On April 29, 2016, 10:34 p.m., Jayush Luniya wrote:
> > I think we need more testing on this apart from unit tests to ensure all 
> > imports are there.
> 
> Juanjo  Marron wrote:
> Hi Jayush,
> 
> Thanks for the review.
> I'll add this couple of missing imports to ACCUMULO service check
> 
> I reviewed UTs, I did a fresh installation, no service-check run though. 
> Ill do service check as well from now. Any other test you think can be 
> required?
> 
> Also, Atlas installation was failing in trunk (even without this change 
> set) so I would need to retry on top of a stable trunk versions

Please, wait review for now, more test on these services is being performed
Thanks


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46853/#review131209
-----------


On April 30, 2016, 12:51 a.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46853/
> ---
> 
> (Updated April 30, 2016, 12:51 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-16175
> https://issues.apache.org/jira/browse/AMBARI-16175
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This  subtask cleans up import * from resource_management and replace it for 
> specific imports for:
> Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py
>  09a3d90 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_service.py
>  33d3273 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/service_check.py
>  a7067cb 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
>  3c3d804 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_service.py
>  eb1b6d7 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py
>  7fb9715 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_master.py
>  b769a0d 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_regionserver.py
>  cf0efef 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_service.py
>  4d0d7f3 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py
>  a5abe1c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  32b8fdb 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params_linux.py
>  21b491d 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py
>  3c4bffc 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py
>  2bdb4c0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  43c1ea6 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
>  4b08cbc 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  defd6f0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py
>  194a3fb 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py
>  4c54214 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py
>  64ace1a 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
>  a201619 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.

Re: Review Request 46445: Refactor get_stack_to_component() method

[Juanjo Marron]

/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py
 30184d9 
  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py
 0e5fd1d 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/drpc_server.py
 acd7529 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py
 296b78f 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus_prod.py
 108b8c1 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py
 db921cb 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py
 c1a0f04 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor_prod.py
 0577e4b 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/ui_server.py
 b7fec9b 
  
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py
 9627de7 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py
 3b4d134 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py
 9b8c5c0 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py
 6eb04fb 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
 6837c27 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
 b046c4c 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py
 2518f1e 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py
 193a7da 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py
 abbe6b7 

Diff: https://reviews.apache.org/r/46445/diff/


Testing (updated)
---

mvn clean test -DskipSurefireTests

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ... SUCCESS [8.252s]
[INFO] Apache Ambari Project POM . SUCCESS [0.359s]
[INFO] Ambari Web  SUCCESS [1:24.139s]
[INFO] Ambari Views .. SUCCESS [7.257s]
[INFO] Ambari Admin View . SUCCESS [22.415s]
[INFO] ambari-metrics  SUCCESS [0.542s]
[INFO] Ambari Metrics Common . SUCCESS [1.357s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [2.101s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [1.261s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [1.347s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [3.235s]
[INFO] Ambari Metrics Collector .. SUCCESS [29.070s]
[INFO] Ambari Metrics Monitor  SUCCESS [2.343s]
[INFO] Ambari Metrics Grafana  SUCCESS [19.393s]
[INFO] Ambari Metrics Assembly ... SUCCESS [30.671s]
[INFO] Ambari Server . SUCCESS [1:36.263s]
[INFO] Ambari Functional Tests ... SUCCESS [2.558s]
[INFO] Ambari Agent .. SUCCESS [13.846s]
[INFO] Ambari Client . SUCCESS [0.332s]
[INFO] Ambari Python Client .. SUCCESS [0.906s]
[INFO] Ambari Groovy Client .. SUCCESS [15.671s]
[INFO] Ambari Shell .. SUCCESS [0.255s]
[INFO] Ambari Python Shell ... SUCCESS [0.086s]
[INFO] Ambari Groovy Shell ... SUCCESS [11.117s]
[INFO] ambari-logsearch .. SUCCESS [0.802s]
[INFO] Ambari Logsearch Portal ... SUCCESS [4.722s]
[INFO] Ambari Logsearch Log Feeder ... SUCCESS [1.520s]
[INFO] Ambari Logsearch Appender . SUCCESS [0.391s]
[INFO] Ambari Logsearch Assembly . SUCCESS [0.185s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 6:03.806s
[INFO] Finished at: Fri Apr 22 15:48:12 PDT 2016
[INFO] Final Memory: 124M/686M


Additionally Build #6552 was successful: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6552/


Thanks,

Juanjo  Marron

Re: Review Request 46445: Refactor get_stack_to_component() method

[Juanjo Marron]

> On April 22, 2016, 6:27 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/script/script.py,
> >  line 155
> > <https://reviews.apache.org/r/46445/diff/1/?file=1353289#file1353289line155>
> >
> > Should add "pass" for it to be a complete function
> 
> Jayush Luniya wrote:
> +1

Thanks both for the review.

Anyway I need to recreate the patch and test it again since it is now creating 
conflicts with this JIRA:
https://issues.apache.org/jira/browse/AMBARI-16014 which has been committed 
yesterday


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46445/#review130152
-----------


On April 20, 2016, 4:35 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46445/
> ---
> 
> (Updated April 20, 2016, 4:35 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-15609
> https://issues.apache.org/jira/browse/AMBARI-15609
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The original intention of the get_stack_to_component function was to have a 
> dictionary where the key was the stack name.
> At service level we always return the same key no matter what, then we should 
> just return the string with the component name and no need to check 
> params.stack_name
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 31d7b2a 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_client.py
>  ebfacf2 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_script.py
>  1004d23 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py
>  14a12d3 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
>  a5990a2 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py
>  75b5de4 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
>  86bf3b6 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py
>  1bd99da 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py
>  b72e648 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
>  5833773 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
>  37dd0a1 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py
>  7d639ec 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
>  ffaf4ea 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py
>  9f62d29 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
>  ac73eaf 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  c8acae3 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py
>  ca2e3ef 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py
>  4a6f144 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py
>  6c41fc2 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py
>  6af0cd3 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
>  8adff0a 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
>  9ba8619 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  9d011a0 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
>  482f0be 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py
>  41074db 
>   
> ambari-server/src/main/resou

Review Request 46445: Refactor get_stack_to_component() method

[Juanjo Marron]

/service_check.py
 f4f0302 
  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py
 0e5fd1d 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/drpc_server.py
 1f88898 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py
 b700349 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus_prod.py
 1956120 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py
 e080794 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py
 bd9aade 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor_prod.py
 aa79ee3 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/ui_server.py
 c7a62d9 
  
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py
 ca13c6e 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py
 fdb5be5 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py
 e9ee529 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py
 16f43dc 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
 dd6b130 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
 141b11a 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py
 1fdd9d6 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py
 3043c45 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py
 fee0e83 

Diff: https://reviews.apache.org/r/46445/diff/


Testing
---

mvn clean test -DskipSurefireTests
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ... SUCCESS [52.199s]
[INFO] Apache Ambari Project POM . SUCCESS [1.008s]
[INFO] Ambari Web  SUCCESS [1:55.020s]
[INFO] Ambari Views .. SUCCESS [10.201s]
[INFO] Ambari Admin View . SUCCESS [28.427s]
[INFO] ambari-metrics  SUCCESS [1.984s]
[INFO] Ambari Metrics Common . SUCCESS [2.614s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.273s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [1.014s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [1.121s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [3.095s]
[INFO] Ambari Metrics Collector .. SUCCESS [44.049s]
[INFO] Ambari Metrics Monitor  SUCCESS [4.723s]
[INFO] Ambari Metrics Grafana  SUCCESS [25.620s]
[INFO] Ambari Metrics Assembly ... SUCCESS [46.641s]
[INFO] Ambari Server . SUCCESS [2:37.916s]
[INFO] Ambari Functional Tests ... SUCCESS [2.405s]
[INFO] Ambari Agent .. SUCCESS [17.269s]
[INFO] Ambari Client . SUCCESS [0.428s]
[INFO] Ambari Python Client .. SUCCESS [1.825s]
[INFO] Ambari Groovy Client .. SUCCESS [22.088s]
[INFO] Ambari Shell .. SUCCESS [0.389s]
[INFO] Ambari Python Shell ... SUCCESS [0.116s]
[INFO] Ambari Groovy Shell ... SUCCESS [13.794s]
[INFO] ambari-logsearch .. SUCCESS [2.336s]
[INFO] Ambari Logsearch Portal ... SUCCESS [8.900s]
[INFO] Ambari Logsearch Log Feeder ... SUCCESS [2.282s]
[INFO] Ambari Logsearch Appender . SUCCESS [0.502s]
[INFO] Ambari Logsearch Assembly . SUCCESS [0.425s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 9:34.234s
[INFO] Finished at: Tue Apr 19 17:05:47 PDT 2016
[INFO] Final Memory: 124M/560M


Additionally Build #6552 was successful: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6552/


Thanks,

Juanjo  Marron

Re: Review Request 45778: AMBARI-15577: Stack Featurize HIVE service

[Juanjo Marron]

] 
[INFO] Total time: 6:35.996s
[INFO] Finished at: Wed Apr 06 01:38:42 PDT 2016
[INFO] Final Memory: 112M/721M


Thanks,

Juanjo  Marron

Re: Review Request 45778: AMBARI-15577: Stack Featurize HIVE service

[Juanjo Marron]

> On April 6, 2016, 7:04 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py,
> >  line 113
> > <https://reviews.apache.org/r/45778/diff/1/?file=1326879#file1326879line113>
> >
> > Keep cmd as a list

command changed back to list type.
 
  Initially I followed other examples on hive_service_interactive.py, such as:
  
  pid_file = format("{hive_pid_dir}/{hive_interactive_pid}")
  cmd = format("{start_hiveserver2_interactive_path} 
{hive_pid_dir}/hive-server2-interactive.out 
{hive_log_dir}/hive-server2-interactive.err {pid_file} 
{hive_server_interactive_conf_dir} {hive_log_dir}"


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45778/#review127295
-------


On April 5, 2016, 9:46 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45778/
> ---
> 
> (Updated April 5, 2016, 9:46 p.m.)
> 
> 
> Review request for Ambari and Jayush Luniya.
> 
> 
> Bugs: AMBARI-15577
> https://issues.apache.org/jira/browse/AMBARI-15577
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Featurize HDP specific logic from HIVE service
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  f7d817a 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  41508b4 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py
>  42485b6 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py
>  941b70c 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_service_check.py
>  4153821 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  3c51d39 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py
>  ba2a129 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
>  7fee2b3 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
>  f7f1377 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  e1c0c42 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_upgrade.py
>  8045528 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
>  3aa6536 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
>  9f32d16 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  70b8921 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  d71e061 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py
>  b95f6f3 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
>  b0a876d 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py
>  10e0990 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  7a3c12e 
> 
> Diff: https://reviews.apache.org/r/45778/diff/
> 
> 
> Testing
> ---
> 
> --
> Ran 253 tests in 6.681s
> 
> OK
> --
> Failed tests:
> FAIL: test_stop_during_upgrade (test_hive_server.TestHiveServer)
> --
> Traceback (most recent call last):
>   File "/home/jmarron/git/ambari/ambari-common/src/test/python/mock/mock.py", 
> line 1199, in patched
> return func(*args, **keywargs)
>   File 
> "/home/jmarron/git/ambari/ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py",
>  line 761, in test_stop_during_upgrade
> tries=1, user='hive')
>   File 
> "/home/jmarron/git/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py&

Review Request 45778: AMBARI-15577: Stack Featurize HIVE service

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45778/
---

Review request for Ambari and Jayush Luniya.


Bugs: AMBARI-15577
https://issues.apache.org/jira/browse/AMBARI-15577


Repository: ambari


Description
---

Featurize HDP specific logic from HIVE service


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 f7d817a 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 41508b4 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py
 42485b6 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py
 941b70c 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_service_check.py
 4153821 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 3c51d39 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py
 ba2a129 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
 7fee2b3 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
 f7f1377 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 e1c0c42 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_upgrade.py
 8045528 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
 3aa6536 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
 9f32d16 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 70b8921 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
 d71e061 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py
 b95f6f3 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
 b0a876d 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py
 10e0990 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 7a3c12e 

Diff: https://reviews.apache.org/r/45778/diff/


Testing
---

--
Ran 253 tests in 6.681s

OK
--
Failed tests:
FAIL: test_stop_during_upgrade (test_hive_server.TestHiveServer)
--
Traceback (most recent call last):
  File "/home/jmarron/git/ambari/ambari-common/src/test/python/mock/mock.py", 
line 1199, in patched
return func(*args, **keywargs)
  File 
"/home/jmarron/git/ambari/ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py",
 line 761, in test_stop_during_upgrade
tries=1, user='hive')
  File 
"/home/jmarron/git/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py",
 line 262, in assertResourceCalledByIndex
self.assertEquals(name, resource.name)
AssertionError: 'hive --config /usr/hdp/current/hive-server2/conf/conf.server 
--service hiveserver2 --deregister 1.2.1.2.3.0.0-2434' != 'hive --config 
/etc/hive/conf.server --service hiveserver2 --deregister 1.2.1.2.3.0.0-2434'

--
Total run:933
Total errors:0
Total failures:1


Thanks,

Juanjo  Marron

Re: Review Request 45522: AMBARI-14472: Stack Featurize Oozie Service

[Juanjo Marron]

> On March 31, 2016, 6:12 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py,
> >  line 114
> > <https://reviews.apache.org/r/45522/diff/1/?file=1320297#file1320297line114>
> >
> > Let me check if this restriction for 2.2.1.0 is Oozie specific.
> 
> Juanjo  Marron wrote:
> Maintained  for now in the new patch. Please, let me know if it needs to 
> be edited
> 
> Jayush Luniya wrote:
> @Juanjo. I didnt get a chance to look into this. For now lets leave these 
> feature as LZO itself and since your logic is correct go ahead with the 
> change. We can rename if required the feature to oozie_lzo or something like 
> that if this is Oozie specific.
> 
> Juanjo  Marron wrote:
> Thanks @Jayush.
> I did that and the new patch was uploaded and it is available to be 
> reviewed and committed
> 
> Jayush Luniya wrote:
> Yes, committed to trunk

Thanks!


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45522/#review126274
-------


On April 1, 2016, 5:31 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45522/
> ---
> 
> (Updated April 1, 2016, 5:31 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-14472
> https://issues.apache.org/jira/browse/AMBARI-14472
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack Featurize Oozie Service
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  175b889 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  6169699 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py
>  90851c8 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  3b01802 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
>  4fc50d2 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
>  e9da71b 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py
>  2db3672 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  ce44d5c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/status_params.py
>  a08ae3a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  fd3fbde 
> 
> Diff: https://reviews.apache.org/r/45522/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test -DskipSurefireTests 
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> --------
> [INFO] Total time: 3:58.802s
> [INFO] Finished at: Wed Mar 30 18:57:06 PDT 2016
> [INFO] Final Memory: 110M/796M
> [INFO] 
> 
> [root@localhost ambari]#
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 45522: AMBARI-14472: Stack Featurize OozieService

[Juanjo Marron]

> On March 31, 2016, 6:26 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json,
> >  line 123
> > <https://reviews.apache.org/r/45522/diff/1/?file=1320301#file1320301line123>
> >
> > Rename to oozie_create_hive_tez_configs instead?

Renamed to OOZIE_CREATE_HIVE_TEZ_CONFIGS = oozie_create_hive_tez_configs


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45522/#review126277
---


On March 31, 2016, 2:50 a.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45522/
> ---
> 
> (Updated March 31, 2016, 2:50 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-14472
> https://issues.apache.org/jira/browse/AMBARI-14472
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack Featurize Oozie Service
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  54fbb8e 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  ac2dbd9 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 4cbf2d7 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py
>  90851c8 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  3b01802 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
>  4fc50d2 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
>  e9da71b 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py
>  2db3672 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  ce44d5c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/status_params.py
>  a08ae3a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  974ddd7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  1c80663 
> 
> Diff: https://reviews.apache.org/r/45522/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test -DskipSurefireTests 
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> --------
> [INFO] Total time: 3:58.802s
> [INFO] Finished at: Wed Mar 30 18:57:06 PDT 2016
> [INFO] Final Memory: 110M/796M
> [INFO] 
> 
> [root@localhost ambari]#
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Review Request 45522: AMBARI-14472: Stack Featurize OozieService

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45522/
---

Review request for Ambari, Alejandro Fernandez and Jayush Luniya.


Bugs: AMBARI-14472
https://issues.apache.org/jira/browse/AMBARI-14472


Repository: ambari


Description
---

Stack Featurize Oozie Service


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 54fbb8e 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 ac2dbd9 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 
4cbf2d7 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py
 90851c8 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 3b01802 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
 4fc50d2 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
 e9da71b 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py
 2db3672 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 ce44d5c 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/status_params.py
 a08ae3a 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
974ddd7 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 1c80663 

Diff: https://reviews.apache.org/r/45522/diff/


Testing
---

mvn clean test -DskipSurefireTests 

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 3:58.802s
[INFO] Finished at: Wed Mar 30 18:57:06 PDT 2016
[INFO] Final Memory: 110M/796M
[INFO] 
[root@localhost ambari]#


Thanks,

Juanjo  Marron

Re: Review Request 45470: AMBARI-15578: Stack Featurize Atlas Service

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45470/#review126192
---


Ship it!




Ship It!

- Juanjo  Marron


On March 30, 2016, 5:15 a.m., Jayush Luniya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45470/
> ---
> 
> (Updated March 30, 2016, 5:15 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Juanjo  Marron, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15578
> https://issues.apache.org/jira/browse/AMBARI-15578
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack Featurize Atlas Service
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  da34696 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py
>  8fabaac 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
>  b6374f9 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  097765e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  86e5971 
> 
> Diff: https://reviews.apache.org/r/45470/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test -DskipSurefireTests
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 54.063s
> [INFO] Finished at: Tue Mar 29 22:06:24 PDT 2016
> [INFO] Final Memory: 63M/1108M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jayush Luniya
> 
>

Re: Review Request 45470: AMBARI-15578: Stack Featurize Atlas Service

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45470/#review126157
---




ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 (line 107)
<https://reviews.apache.org/r/45470/#comment189057>

Is it rolling_upgrade related or the version where Atlas was introduced in 
the stack?

{
  "name": "atlas",
  "description": "Atlas Service support",
  "min_version": "2.3.0.0"
}

I think rolling upgrade and config versioning could be added as features 
later on when supported


- Juanjo  Marron


On March 30, 2016, 5:15 a.m., Jayush Luniya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45470/
> ---
> 
> (Updated March 30, 2016, 5:15 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Juanjo  Marron, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15578
> https://issues.apache.org/jira/browse/AMBARI-15578
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack Featurize Atlas Service
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  da34696 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py
>  8fabaac 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
>  b6374f9 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  097765e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  86e5971 
> 
> Diff: https://reviews.apache.org/r/45470/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test -DskipSurefireTests
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 54.063s
> [INFO] Finished at: Tue Mar 29 22:06:24 PDT 2016
> [INFO] Final Memory: 63M/1108M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jayush Luniya
> 
>

Review Request 45460: AMBARI-15582: Stack Featurize Sqoop Service

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45460/
---

Review request for Ambari, Alejandro Fernandez and Jayush Luniya.


Bugs: AMBARI-15582
https://issues.apache.org/jira/browse/AMBARI-15582


Repository: ambari


Description
---

Stack Featurize Sqoop Service


Diffs
-

  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py
 7048a9f 
  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/service_check.py
 c0d0e8c 
  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py
 06ffae4 

Diff: https://reviews.apache.org/r/45460/diff/


Testing
---

mvn clean test -DskipSurefireTests

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ... SUCCESS [32.207s]
[INFO] Apache Ambari Project POM . SUCCESS [0.396s]
[INFO] Ambari Web  SUCCESS [1:47.531s]
[INFO] Ambari Views .. SUCCESS [7.682s]
[INFO] Ambari Admin View . SUCCESS [17.513s]
[INFO] ambari-metrics  SUCCESS [0.512s]
[INFO] Ambari Metrics Common . SUCCESS [1.426s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [2.267s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [0.934s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [1.038s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [2.352s]
[INFO] Ambari Metrics Collector .. SUCCESS [27.534s]
[INFO] Ambari Metrics Monitor  SUCCESS [3.420s]
[INFO] Ambari Metrics Grafana  SUCCESS [19.307s]
[INFO] Ambari Metrics Assembly ... SUCCESS [25.785s]
[INFO] Ambari Server . SUCCESS [2:07.627s]
[INFO] Ambari Functional Tests ... SUCCESS [2.877s]
[INFO] Ambari Agent .. SUCCESS [16.321s]
[INFO] Ambari Client . SUCCESS [0.062s]
[INFO] Ambari Python Client .. SUCCESS [1.494s]
[INFO] Ambari Groovy Client .. SUCCESS [25.255s]
[INFO] Ambari Shell .. SUCCESS [0.078s]
[INFO] Ambari Python Shell ... SUCCESS [0.138s]
[INFO] Ambari Groovy Shell ... SUCCESS [13.391s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 7:18.415s
[INFO] Finished at: Tue Mar 29 16:21:24 PDT 2016
[INFO] Final Memory: 111M/707M
[INFO] 


Thanks,

Juanjo  Marron

Re: Review Request 45338: AMBARI-15053: Stack Featurize YARN and MR services

[Juanjo Marron]

> On March 28, 2016, 6:28 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py,
> >  line 22
> > <https://reviews.apache.org/r/45338/diff/1/?file=1315009#file1315009line22>
> >
> > Can we remove the import *?
> 
> Juanjo  Marron wrote:
> Most of the service scripts still include the from resource_management 
> import * line. 
> I found 123 matches searching in common-services.
> It would be great to clean up the extra/non use imports, but if 
> @afernandez agrees, I think it is out of the scope of this stack 
> featuraization work

I tried to remove the from resource_management import * line and other specific 
imports are missed, such as Script ot Fail.
It would require additional validation.
Ill create a new JIRA for imports clean up ate common-services level


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45338/#review125695
-------


On March 28, 2016, 4:09 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45338/
> ---
> 
> (Updated March 28, 2016, 4:09 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15053
> https://issues.apache.org/jira/browse/AMBARI-15053
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Featurize HDP specific logic from YARN and MR service
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  f766a82 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  2f0e6bf 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py
>  2966581 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py
>  53b0e53 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py
>  9fc1e32 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
>  fd14d0f 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  52f42b0 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
>  e51ca8a 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  83bf460 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  4110d39 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py
>  d300279 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  97bd19c 
> 
> Diff: https://reviews.apache.org/r/45338/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test -DskipSurefireTests
> 
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ... SUCCESS [17.789s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.379s]
> [INFO] Ambari Web  SUCCESS [1:28.925s]
> [INFO] Ambari Views .. SUCCESS [7.096s]
> [INFO] Ambari Admin View . SUCCESS [18.829s]
> [INFO] ambari-metrics  SUCCESS [0.358s]
> [INFO] Ambari Metrics Common . SUCCESS [1.222s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [2.142s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [0.640s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.800s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [2.858s]
> [INFO] Ambari Metrics Collector .. SUCCESS [30.150s]
> [INFO] Ambari Metrics Monitor  SUCCESS [3.053s]
> [INFO] Ambari Metrics Grafana  SUCCESS [20.581s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [39.513s]
> [INFO] Ambari Server . SUCCESS [1:42

Re: Review Request 45338: AMBARI-15053: Stack Featurize YARN and MR services

[Juanjo Marron]

> On March 28, 2016, 6:28 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py,
> >  line 56
> > <https://reviews.apache.org/r/45338/diff/1/?file=1315011#file1315011line56>
> >
> > The point of this function was to have a dictionary with the key being 
> > each possible stack name. If we always return "hadoop-client", might as 
> > well just return it as a string no matter what.

The didct value is changing depending the component. The key is always the same 
("HDP" and stack_name now).

Since several services were already pushed to trunk with this same approcah, I 
would propose to solve first stack featurization for all the services and 
create a new JIRA to modify get_stack_to_component() after that.

I think the method def get_stack_to_component(self): in script.py can be 
redefined to obtain the stack_name at script.py level (method def 
get_stack_name()) and to return just a string with the component name at 
service level.


> On March 28, 2016, 6:28 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py,
> >  line 22
> > <https://reviews.apache.org/r/45338/diff/1/?file=1315009#file1315009line22>
> >
> > Can we remove the import *?

Most of the service scripts still include the from resource_management import * 
line. 
I found 123 matches searching in common-services.
It would be great to clean up the extra/non use imports, but if @afernandez 
agrees, I think it is out of the scope of this stack featuraization work


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45338/#review125695
---


On March 28, 2016, 4:09 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45338/
> ---
> 
> (Updated March 28, 2016, 4:09 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15053
> https://issues.apache.org/jira/browse/AMBARI-15053
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Featurize HDP specific logic from YARN and MR service
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  f766a82 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  2f0e6bf 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py
>  2966581 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py
>  53b0e53 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py
>  9fc1e32 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
>  fd14d0f 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  52f42b0 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
>  e51ca8a 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  83bf460 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  4110d39 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py
>  d300279 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  97bd19c 
> 
> Diff: https://reviews.apache.org/r/45338/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test -DskipSurefireTests
> 
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ... SUCCESS [17.789s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.379s]
> [INFO] Ambari Web  SUCCESS [1:28.925s]
> [INFO] Ambari Views .. SUCCESS [7.096s]
> [INFO] Ambari Admin View . SUCCESS [18.829s]
> [INFO] ambari-metrics  SUCCESS [0.358s]
> [INFO] Ambari Metrics Common ..

Review Request 45338: AMBARI-15053: Stack Featurize YARN & MR services

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45338/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Bugs: AMBARI-15053
https://issues.apache.org/jira/browse/AMBARI-15053


Repository: ambari


Description
---

Featurize HDP specific logic from YARN & MR service


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 f766a82 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 2f0e6bf 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py
 2966581 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py
 53b0e53 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py
 9fc1e32 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
 fd14d0f 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 52f42b0 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
 e51ca8a 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
 83bf460 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
 4110d39 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py
 d300279 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 97bd19c 

Diff: https://reviews.apache.org/r/45338/diff/


Testing
---

mvn clean test -DskipSurefireTests

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ... SUCCESS [17.789s]
[INFO] Apache Ambari Project POM . SUCCESS [0.379s]
[INFO] Ambari Web  SUCCESS [1:28.925s]
[INFO] Ambari Views .. SUCCESS [7.096s]
[INFO] Ambari Admin View . SUCCESS [18.829s]
[INFO] ambari-metrics  SUCCESS [0.358s]
[INFO] Ambari Metrics Common . SUCCESS [1.222s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [2.142s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [0.640s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [0.800s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [2.858s]
[INFO] Ambari Metrics Collector .. SUCCESS [30.150s]
[INFO] Ambari Metrics Monitor  SUCCESS [3.053s]
[INFO] Ambari Metrics Grafana  SUCCESS [20.581s]
[INFO] Ambari Metrics Assembly ... SUCCESS [39.513s]
[INFO] Ambari Server . SUCCESS [1:42.265s]
[INFO] Ambari Functional Tests ... SUCCESS [2.830s]
[INFO] Ambari Agent .. SUCCESS [9.914s]
[INFO] Ambari Client . SUCCESS [0.286s]
[INFO] Ambari Python Client .. SUCCESS [1.151s]
[INFO] Ambari Groovy Client .. SUCCESS [17.175s]
[INFO] Ambari Shell .. SUCCESS [0.251s]
[INFO] Ambari Python Shell ... SUCCESS [0.157s]
[INFO] Ambari Groovy Shell ... SUCCESS [10.952s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 6:20.634s
[INFO] Finished at: Thu Mar 25 11:22:15 PDT 2016
[INFO] Final Memory: 112M/531M


Thanks,

Juanjo  Marron

Re: Review Request 45254: Apply the stack featurization prototype detailed on AMBARI-13364 to TEZ service

[Juanjo Marron]

> On March 24, 2016, 6:59 p.m., Jayush Luniya wrote:
> > Ship It!
> 
> Jayush Luniya wrote:
> Committed to trunk

Thanks for the review and for commiting!


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45254/#review125316
---


On March 24, 2016, 6:22 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45254/
> ---
> 
> (Updated March 24, 2016, 6:22 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-15137
> https://issues.apache.org/jira/browse/AMBARI-15137
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Apply the stack featurization prototype detailed on AMBARI-13364 to TEZ 
> service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py
>  0165c0b 
>   
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/pre_upgrade.py
>  1faedf9 
>   
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py
>  c0c66af 
>   
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py
>  e770d9b 
> 
> Diff: https://reviews.apache.org/r/45254/diff/
> 
> 
> Testing
> ---
> 
> TEZ fresh installation
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 45254: Apply the stack featurization prototype detailed on AMBARI-13364 to TEZ service

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45254/
---

(Updated March 24, 2016, 6:22 p.m.)


Review request for Ambari, Alejandro Fernandez and Jayush Luniya.


Changes
---

Solved last review comments:
- parameterize get_stack_to_component()
- Remove unused imports


Bugs: AMBARI-15137
https://issues.apache.org/jira/browse/AMBARI-15137


Repository: ambari


Description
---

Apply the stack featurization prototype detailed on AMBARI-13364 to TEZ service


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py
 0165c0b 
  
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/pre_upgrade.py
 1faedf9 
  
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py
 c0c66af 
  
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py
 e770d9b 

Diff: https://reviews.apache.org/r/45254/diff/


Testing
---

TEZ fresh installation


Thanks,

Juanjo  Marron

Re: Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45141/
---

(Updated March 22, 2016, 11:13 p.m.)


Review request for Ambari, Alejandro Fernandez and Jayush Luniya.


Changes
---

Uploaded new patch solving last set of comments


Bugs: AMBARI-14435
https://issues.apache.org/jira/browse/AMBARI-14435


Repository: ambari


Description
---

Apply the  stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER 
service plus the comments and reviews received on:
https://reviews.apache.org/r/44933/

This patch removes the hardcoded stack versions in ZK common-services code 
(centralized version and parameterized stack configurations will be faced in 
other JIRAS)

stack_features is now a property in .json format in 
HDP/2.0.6/properties/stack_features.json
With the structure:
{
"stack_features": [
{ "name": "feature1", "description" : "Feature1 support", "min_version" : 
"Y.Y.Y.Y" , "max_version" : "X.X.X.X"}
, 
...
]
}
where min_version/max_version are optional constraints.

The upgrade constants, such has ROLLING_UPGRADE = "rolling_upgrade" has been 
added to in a new StackFeature in 
resource_management/libraries/functions/constants.py

It is added as part of the HDP stack configurations on 
/HDP/2.0.6/configuration/cluster-env.xml, introducing a new stack_features 
property

New resource_management/libraries/functions/stack_fetaures.py has been 
introduced to parse the json file and called from service code to check if the 
stack supports the required feature.

The stack version used in params_linux.py comparison is  
stack_version_formatted = hostLevelParams\stack_version


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 0adaef9 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/params_linux.py
 9ff9125 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/status_params.py
 9ae8440 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper.py
 5712ce4 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py
 25ace24 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py
 d5b6898 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_service.py
 6fe0772 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
5f77f48 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 PRE-CREATION 

Diff: https://reviews.apache.org/r/45141/diff/


Testing
---

Zookeeper fresh installation on top of latest trunk


Thanks,

Juanjo  Marron

Re: Review Request 44933: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

[Juanjo Marron]

> On March 21, 2016, 8:01 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper.py,
> >  line 40
> > <https://reviews.apache.org/r/44933/diff/1/?file=1301830#file1301830line40>
> >
> > Add constants to 
> > ambari/ambari-common/src/main/python/resource_management/libraries/functions/constants.py
> > 
> > class StackFeatures:
> >   ROLLING_UPGRADE = "rolling_upgrade"

Added new review request with all the new design changes: 
https://reviews.apache.org/r/45141/

Im not sure how is the right procedure in this case, but it was hard to me to 
keep track of the diff changes after the new prototype design


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44933/#review124636
-----------


On March 22, 2016, 1:03 a.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44933/
> ---
> 
> (Updated March 22, 2016, 1:03 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-14435
> https://issues.apache.org/jira/browse/AMBARI-14435
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Apply the  stack featurization prototype  detailed on AMBARI-13364 to 
> ZOOKEEPER service.
> This patch removes the hardcoded stack versions in ZK common-services code 
> (centralized version and parameterized stack configurations will be faced in 
> other JIRAS)
> stack_features is now a property in .json format in 
> configuration/cluster-env.xml for each stack version.
> With the structure:
> {
> "stack_features": [
> { "name": "feature1", "description" : "Feature1 support", "min_version" : 
> "Y.Y.Y.Y" , "max_version" : "X.X.X.X"}
> , 
> ...
> ]
> }
> where min_version/max_version are optional constraints.
> New resource_management/libraries/functions/stack_fetaures.py has been 
> introduced to parse the json file and called from service code to check if 
> the stack supports the required feature.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_fetaures.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/params_linux.py
>  9ff9125 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/status_params.py
>  d18e4d7 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper.py
>  5712ce4 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py
>  25ace24 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py
>  d5b6898 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_service.py
>  6fe0772 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  3fb82e9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/configuration/cluster-env.xml 
> f1fa4de 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/configuration/cluster-env.xml 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44933/diff/
> 
> 
> Testing
> ---
> 
> Zookeeper fresh installation has been tested using HDP stack 2.3 and 
> AMBARI-13364 branch code.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45141/
---

Review request for Ambari, Alejandro Fernandez and Jayush Luniya.


Bugs: AMBARI-14435
https://issues.apache.org/jira/browse/AMBARI-14435


Repository: ambari


Description
---

Apply the  stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER 
service plus the comments and reviews received on:
https://reviews.apache.org/r/44933/

This patch removes the hardcoded stack versions in ZK common-services code 
(centralized version and parameterized stack configurations will be faced in 
other JIRAS)

stack_features is now a property in .json format in 
HDP/2.0.6/properties/stack_features.json
With the structure:
{
"stack_features": [
{ "name": "feature1", "description" : "Feature1 support", "min_version" : 
"Y.Y.Y.Y" , "max_version" : "X.X.X.X"}
, 
...
]
}
where min_version/max_version are optional constraints.

The upgrade constants, such has ROLLING_UPGRADE = "rolling_upgrade" has been 
added to in a new StackFeature in 
resource_management/libraries/functions/constants.py

It is added as part of the HDP stack configurations on 
/HDP/2.0.6/configuration/cluster-env.xml, introducing a new stack_features 
property

New resource_management/libraries/functions/stack_fetaures.py has been 
introduced to parse the json file and called from service code to check if the 
stack supports the required feature.

The stack version used in params_linux.py comparison is  
stack_version_formatted = hostLevelParams\stack_version


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 0adaef9 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/params_linux.py
 9ff9125 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/status_params.py
 9ae8440 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper.py
 5712ce4 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py
 25ace24 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py
 d5b6898 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_service.py
 6fe0772 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
5f77f48 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 PRE-CREATION 

Diff: https://reviews.apache.org/r/45141/diff/


Testing
---

Zookeeper fresh installation on top of latest trunk


Thanks,

Juanjo  Marron

Re: Review Request 44933: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44933/
---

(Updated March 22, 2016, 1:03 a.m.)


Review request for Ambari, Alejandro Fernandez and Jayush Luniya.


Bugs: AMBARI-14435
https://issues.apache.org/jira/browse/AMBARI-14435


Repository: ambari


Description
---

Apply the  stack featurization prototype  detailed on AMBARI-13364 to ZOOKEEPER 
service.
This patch removes the hardcoded stack versions in ZK common-services code 
(centralized version and parameterized stack configurations will be faced in 
other JIRAS)
stack_features is now a property in .json format in 
configuration/cluster-env.xml for each stack version.
With the structure:
{
"stack_features": [
{ "name": "feature1", "description" : "Feature1 support", "min_version" : 
"Y.Y.Y.Y" , "max_version" : "X.X.X.X"}
, 
...
]
}
where min_version/max_version are optional constraints.
New resource_management/libraries/functions/stack_fetaures.py has been 
introduced to parse the json file and called from service code to check if the 
stack supports the required feature.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/stack_fetaures.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/params_linux.py
 9ff9125 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/status_params.py
 d18e4d7 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper.py
 5712ce4 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py
 25ace24 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py
 d5b6898 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_service.py
 6fe0772 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
3fb82e9 
  ambari-server/src/main/resources/stacks/HDP/2.2/configuration/cluster-env.xml 
f1fa4de 
  ambari-server/src/main/resources/stacks/HDP/2.3/configuration/cluster-env.xml 
PRE-CREATION 

Diff: https://reviews.apache.org/r/44933/diff/


Testing
---

Zookeeper fresh installation has been tested using HDP stack 2.3 and 
AMBARI-13364 branch code.


Thanks,

Juanjo  Marron

Review Request 44933: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44933/
---

Review request for Ambari, Alejandro Fernandez and Jayush Luniya.


Bugs: AMBARI-14435
https://issues.apache.org/jira/browse/AMBARI-14435


Repository: ambari


Description
---

Apply the  stack featurization prototype  detailed on AMBARI-13364 to ZOOKEEPER 
service.
This patch removes the hardcoded stack versions in ZK common-services code 
(centralized version and parameterized stack configurations will be faced in 
other JIRAS)
stack_features is now a property in .json format in 
configuration/cluster-env.xml for each stack version.
With the structure:
{
"stack_features": [
{ "name": "feature1", "description" : "Feature1 support", "min_version" : 
"Y.Y.Y.Y" , "max_version" : "X.X.X.X"}
, 
...
]
}
where min_version/max_version are optional constraints.
New resource_management/libraries/functions/stack_fetaures.py has been 
introduced to parse the json file and called from service code to check if the 
stack supports the required feature.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/stack_fetaures.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/params_linux.py
 9ff9125 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/status_params.py
 d18e4d7 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper.py
 5712ce4 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py
 25ace24 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py
 d5b6898 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_service.py
 6fe0772 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
3fb82e9 
  ambari-server/src/main/resources/stacks/HDP/2.2/configuration/cluster-env.xml 
f1fa4de 
  ambari-server/src/main/resources/stacks/HDP/2.3/configuration/cluster-env.xml 
PRE-CREATION 

Diff: https://reviews.apache.org/r/44933/diff/


Testing
---

Zookeeper fresh installation has been tested using HDP stack 2.3 and 
AMBARI-13364 branch code.


Thanks,

Juanjo  Marron

Re: Review Request 44933: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

[Juanjo Marron]

> On March 18, 2016, 9:25 p.m., Jayush Luniya wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/stack_fetaures.py,
> >  line 1
> > <https://reviews.apache.org/r/44933/diff/1/?file=1301827#file1301827line1>
> >
> > Minor, fix typo in file name

OK.Thanks. I'll solve it in the next patch replacing this one


> On March 18, 2016, 9:25 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/params_linux.py,
> >  line 53
> > <https://reviews.apache.org/r/44933/diff/1/?file=1301828#file1301828line53>
> >
> > Will things might work out in regular install, I think there is going 
> > to be a problem here during upgrades.
> > 
> > Lets say we are doing EU from HDP-2.1 to HDP-2.2
> > the command.json file for the command will have 
> > hostLevelParams/current_version = 2.1.0.0-1234
> > hostLevelParams/version = 2.2.0.0-5678
> > commandParams/stack_version = 2.2
> > configurations/cluster-env/stack_features = "snappy" (HDP-2.1 version 
> > of stack_features)
> > 
> > So the check will fail.
> > 
> > @Alejandro is my understanding correct? I can try out the upgrade to 
> > verify too. 
> > 
> > BTW, @Juanjo Script.is_stack_greater* functions use 
> > commandParams/stack_version whereas you are changing it to current_version
> 
> Jayush Luniya wrote:
> @Juanjo, 
> Alejandro and I had a chat on this. Given the upgrade scenario, it would 
> be best to have a single stack_features list for a stack and maintain a 
> min_version and max_version for the feature instead of breaking down the list 
> of stack features for each stack version. That way we will not run into 
> issues with upgrades where we would sometimes need the upgradeFromVersion 
> stack_features list and sometimes we would need the upgradeToVersion 
> stack_features list.

@Jayush,
@Alejandro
So If I understand properly, the idea is to create a xml file, let's say 
stack_features.xml  under 
ambari-server/src/main/resources/stacks/HDP/configuration,  for example. It 
will be common to all the HDP stacks.
Inside the xml I  can add  the json file content and read it using the new 
feature to support external properties file whicj Jayush is creating in 
https://reviews.apache.org/r/44835. 



stack_features

List of features supported by the stack
VALUE_FROM_PROPERTY_FILE

stack_features.json
json




And stack_fetaures.json will be:

{
"stack_features": [
{ "name": "snappy", "description" : "Snappy compressor/decompressor 
support" , "min_version" : "2.0.0.0" , "max_version" : "2.2.0.0" }
,
{ "name": "upgrade", "description" : "Upgrade support", 
"min_version" : "2.2.0.0" }
,
{ "name": "ranger", "description" : "Ranger Service support", 
"min_version" : "2.2.0.0" }
]
}


This stack_features.xml file will be read from params.py and stack_features.py 
(new resource_management script) will make sure the stack_version for a 
specific feature is in the range [min_version - max_version]. Ill let 
max_version as optional argument since the re will be features working from 
min_version until now and the next versions.


Also, regarding the use of commandParams/stack_version. I would need to declare 
it? it is needed? I mean is it diff from stack_version_unformatted, 
stack_version_formatted , current_version or version that are already defined?


> On March 18, 2016, 9:25 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml,
> >  line 25
> > <https://reviews.apache.org/r/44933/diff/1/?file=1301834#file1301834line25>
> >
> > FYI, in https://reviews.apache.org/r/44835/ I added a feature to 
> > support external properties file for complete structures like these. So you 
> > can create a json file at HDP/2.0.6/properties/stack_features.json and 
> > reference it in the config property xml file. I will be committing those 
> > changes soon.

I saw the example of stack_tools.json in https://reviews.apache.org/r/44835/.
It would work even if the stack_fetaures.json file is defined out of the stack, 
under HDP/configuration/stack_fetautes for example?


- Juanjo


---
This is an automatically genera