---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31171/#review73291
---
On Feb. 19, 2015, 11:58 p.m., Maxim Khutornenko wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31240/#review73343
---
Ship it!
Ship It!
- Maxim Khutornenko
On Feb. 20, 2015, 10:29
On Feb. 21, 2015, 12:43 a.m., Bill Farner wrote:
src/test/java/org/apache/aurora/scheduler/async/OfferManagerImplTest.java,
line 80
https://reviews.apache.org/r/30891/diff/5-6/?file=867194#file867194line80
This is kinda weird, what's the motivation here?
Maxim Khutornenko
On Feb. 21, 2015, 12:39 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java,
line 199
https://reviews.apache.org/r/31248/diff/1/?file=871335#file871335line199
Use StringBuilder instead to avoid heap churn.
Bill Farner wrote
Thanks,
Maxim Khutornenko
On Feb. 21, 2015, 12:39 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java,
line 199
https://reviews.apache.org/r/31248/diff/1/?file=871335#file871335line199
Use StringBuilder instead to avoid heap churn.
Bill Farner wrote
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
/aurora/scheduler/thrift/ThriftIT.java
2b8a9e443e1c50ba7a11556bbcaf4dc5bb694dd4
Diff: https://reviews.apache.org/r/31241/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
---
On Feb. 20, 2015, 10:31 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31241
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30891/#review73208
---
On Feb. 20, 2015, 11:58 p.m., Maxim Khutornenko wrote
(e.g.
task_store_ASSIGNED).
- Maxim Khutornenko
On Feb. 21, 2015, 12:04 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31248
On Feb. 21, 2015, 12:39 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java,
line 199
https://reviews.apache.org/r/31248/diff/1/?file=871335#file871335line199
Use StringBuilder instead to avoid heap churn.
Bill Farner wrote
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31171/#review73064
---
On Feb. 19, 2015, 12:27 a.m., Maxim Khutornenko wrote
: https://reviews.apache.org/r/31171/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
Thanks,
Maxim Khutornenko
shouldn't it rather be select_update_row_id?
- Maxim Khutornenko
On Feb. 17, 2015, 11:06 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31136
,
Maxim Khutornenko
decisions about its contents. Have you considered having the
`acceptor` own this behavior?
Maxim Khutornenko wrote:
Well, I don't really see why it has Queue in its name in the first
place :) It does not really act like one. It accepts offers by iterating over
the entire collection
ce59bee302ee2323b65622635b8b51d965dd6507
Diff: https://reviews.apache.org/r/31029/diff/
Testing
---
https://github.com/maxim111333/incubator-aurora/blob/pulse_docs/docs/client-commands.md#user-content-coordinated-job-updates-beta
Thanks,
Maxim Khutornenko
beta-update status devcluster/www-data/prod/hello
INFO]
No updates found for job devcluster/www-data/prod/hello
INFO] Command terminated with error code 6
```
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30891/#review72429
---
On Feb. 13, 2015, 2:27 a.m., Maxim Khutornenko wrote
```
Thanks,
Maxim Khutornenko
status devcluster/www-data/prod/hello
INFO]
No updates found for job devcluster/www-data/prod/hello
INFO] Command terminated with error code 6
```
Thanks,
Maxim Khutornenko
---
On Feb. 13, 2015, 9:54 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31022/
---
(Updated Feb. 13
:38 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30890/
---
(Updated Feb. 11, 2015, 9:38 p.m
/aurora/scheduler/filter/SchedulingFilterImplTest.java
52ee7c1e3742d9315c7e7aaa77677121e1e9288d
Diff: https://reviews.apache.org/r/30890/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
/
Testing
---
Thanks,
Maxim Khutornenko
.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30890/#review72300
---
On Feb. 13, 2015, 12:58 a.m., Maxim Khutornenko wrote
/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
/scheduler/filter/SchedulingFilterImplTest.java
52ee7c1e3742d9315c7e7aaa77677121e1e9288d
Diff: https://reviews.apache.org/r/30890/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
52ee7c1e3742d9315c7e7aaa77677121e1e9288d
Diff: https://reviews.apache.org/r/30890/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30890/#review72274
---
@ReviewBot retry
- Maxim Khutornenko
On Feb. 12, 2015, 6:05 p.m
/populated_deprecation/docs/thrift-deprecation.md
Thanks,
Maxim Khutornenko
?
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29117/#review72291
---
On Feb. 13, 2015, 12:35 a.m., Maxim Khutornenko wrote
/scheduler/async/TaskSchedulerImplTest.java
d0e11932e8b5ba1393279137c8465a308e1d6bf5
src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java
74e31334bc139c47eb8b0beee46ee7bad62a2f80
Diff: https://reviews.apache.org/r/30891/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim
odd for an enum value to be considered a 'group'. (When i hear group
i think collection.)
Maxim Khutornenko wrote:
VetoType is used to describe the particular type of veto applied. This
enum denotes similar typed Veto groups. I am fine changing it to something
else if VetoGroup
/scheduler/async/TaskSchedulerImplTest.java
d0e11932e8b5ba1393279137c8465a308e1d6bf5
src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java
74e31334bc139c47eb8b0beee46ee7bad62a2f80
Diff: https://reviews.apache.org/r/30891/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim
/diff/
Testing
---
./pants test.pytest src/test/python/apache/aurora/client::
Thanks,
Maxim Khutornenko
, visit:
https://reviews.apache.org/r/30225/#review71879
---
On Feb. 7, 2015, 2:43 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
89765ac3d34a827d3748fb96a275d78e9d1b8b72
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java
41d422939209d0808235128e4242c11e8ef25969
Diff: https://reviews.apache.org/r/30225/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
On Feb. 5, 2015, 12:01 a.m., Bill Farner wrote:
Can you see any opportunity to break this diff apart? As it stands i'm
having a hard time giving a thoughtful review. Perhaps you can start by
introducing the `Assignment` class?
Maxim Khutornenko wrote:
I'd really prefer keeping
89765ac3d34a827d3748fb96a275d78e9d1b8b72
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java
41d422939209d0808235128e4242c11e8ef25969
Diff: https://reviews.apache.org/r/30225/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30225/#review72014
---
On Feb. 11, 2015, 7:19 p.m., Maxim Khutornenko wrote
/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325/#review71904
---
On Feb. 10, 2015, 12:53 a.m., Maxim Khutornenko wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325/#review71878
---
On Feb. 10, 2015, 12:53 a.m., Maxim Khutornenko wrote
://reviews.apache.org/r/30325/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
src/jmh/java/org/apache/aurora/benchmark/Tasks.java
1a35f9ee9e8e76def0f9bf5454cf8cbdf6a89c25
Diff: https://reviews.apache.org/r/30895/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
52ee7c1e3742d9315c7e7aaa77677121e1e9288d
Diff: https://reviews.apache.org/r/30890/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
5647349854a5e04de749c4d809684a0066d4da06
src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java
6cc13231560996b144101eba36577f49017aba06
Diff: https://reviews.apache.org/r/30891/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
/TaskSchedulerTest.java
6cc13231560996b144101eba36577f49017aba06
src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java
411a55a8d85f60bb2703468f2d69b64b2736eee4
Diff: https://reviews.apache.org/r/30888/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325/#review71840
---
On Feb. 10, 2015, 12:53 a.m., Maxim Khutornenko wrote
: https://reviews.apache.org/r/30325/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30888/#review72026
---
On Feb. 11, 2015, 9:38 p.m., Maxim Khutornenko wrote
---
On Feb. 11, 2015, 1:19 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30461/
---
(Updated
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30891/#review72030
---
On Feb. 11, 2015, 9:38 p.m., Maxim Khutornenko wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325/#review72060
---
On Feb. 11, 2015, 11:35 p.m., Maxim Khutornenko wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30461/#review72091
---
@ReviewBot retry
- Maxim Khutornenko
On Feb. 11, 2015, 1:19 a.m
2a9d36ab2c01960dc5384fc3ed90df4e11c0b12a
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
ee329496adf051de717d42c60410c0469f7e90da
Diff: https://reviews.apache.org/r/30913/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30859/#review71898
---
Ship it!
Ship It!
- Maxim Khutornenko
On Feb. 11, 2015, 1:14
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30858/#review71918
---
Ship it!
Ship It!
- Maxim Khutornenko
On Feb. 11, 2015, 1:08
, visit:
https://reviews.apache.org/r/30461/#review70662
---
On Jan. 30, 2015, 10:31 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30461/#review70701
---
On Jan. 30, 2015, 10:31 p.m., Maxim Khutornenko wrote
/
Testing
---
./pants test.pytest src/test/python/apache/aurora/client::
Thanks,
Maxim Khutornenko
support single and multi-role assignments. This is going to be
especially critical when the mesos dynamic reservation [1] lands.
[1] -
https://docs.google.com/document/d/1e3j69pfBgtc8xM00DhcuiMl6ImkEB5na0TzOMyzrg8A/edit#
- Maxim Khutornenko
On Feb. 10, 2015, 12:49 a.m., lozh...@ebay.com
2b5383f3c56927bc42ab47c0a5c7c4b1d41af6dd
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
c6fe218c709c73dbd4c3aeeb94e211ee6cdf9a0d
Diff: https://reviews.apache.org/r/30804/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
/aop/ForwardingThrift.java
4bf63921f8aa4be943b2b9a7b0be9fb33f7762db
Diff: https://reviews.apache.org/r/30325/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
back to the
coordinator role if direct auth fails.
This is an unfortunate state of affairs, and hopefully the move to
shiro dramatically improves all this.
Maxim Khutornenko wrote:
I don't see how it's necessarily better. Pulsing can always be done under
UPDATE_COORDINATOR
Diff: https://reviews.apache.org/r/30325/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
/30804/#review71707
---
On Feb. 9, 2015, 7:57 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30804
/org/apache/aurora/scheduler/updater/JobUpdaterIT.java
41d422939209d0808235128e4242c11e8ef25969
Diff: https://reviews.apache.org/r/30225/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30225/#review71245
---
On Feb. 5, 2015, 2:34 a.m., Maxim Khutornenko wrote
On Feb. 4, 2015, 1:47 a.m., Maxim Khutornenko wrote:
src/test/python/apache/aurora/client/cli/test_cron.py, line 138
https://reviews.apache.org/r/30586/diff/2/?file=846914#file846914line138
You may want to drop unused CLUSTER patching in other tests as well.
Zameer Manji wrote
7d0a7438b4a517e5e0d44f4e99aceb1a6d19f987
Diff: https://reviews.apache.org/r/30225/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
/#review71063
---
On Feb. 4, 2015, 5:24 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30225
://reviews.apache.org/media/uploaded/files/2014/12/03/2f73b94a-5ba9-43b6-922e-e9e4ec18d0bb__StaticVetoFiltering.png
Thanks,
Maxim Khutornenko
no asynchronous transition to the 'blocked' states, they're triggered
either by a tardy pulse or another external action. I think this would be
surprising behavior, and the scheduler should automatically transition to
these states without any external input.
Maxim Khutornenko wrote
no asynchronous transition to the 'blocked' states, they're triggered
either by a tardy pulse or another external action. I think this would be
surprising behavior, and the scheduler should automatically transition to
these states without any external input.
Maxim Khutornenko wrote
/aurora/client/cli/test_cron.py
https://reviews.apache.org/r/30586/#comment116769
Why not just `api.schedule_cron.mock_calls == [call(...)]`?
- Maxim Khutornenko
On Feb. 5, 2015, 2:08 a.m., Zameer Manji wrote
/test_health_checker.py
https://reviews.apache.org/r/30647/#comment116768
Any chance to have test coverage for the other two metrics?
- Maxim Khutornenko
On Feb. 5, 2015, 1:46 a.m., Brian Wickman wrote:
---
This is an automatically generated e-mail
automatically transition to
these states without any external input.
Maxim Khutornenko wrote:
I think avoid acquisition of a write lock here is a good goal to aim
for. If, for example, we are already holding the write lock for a large
snapshot, we could cause it to appear as though we
---
On Feb. 4, 2015, 5:24 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30225
src/test/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterTest.java
7d0a7438b4a517e5e0d44f4e99aceb1a6d19f987
Diff: https://reviews.apache.org/r/30225/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
-43b6-922e-e9e4ec18d0bb__StaticVetoFiltering.png
Thanks,
Maxim Khutornenko
to
shiro dramatically improves all this.
Maxim Khutornenko wrote:
I don't see how it's necessarily better. Pulsing can always be done under
UPDATE_COORDINATOR membership, which is specifically covering heartbeats
only. The isAdmin() requires ROOT that opens up everything else, including
? There is another test
`test_simple_successful_create_job_open_page` that you can model after.
- Maxim Khutornenko
On Feb. 3, 2015, 11:20 p.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/
---
(Updated Jan. 29, 2015, 9:26 p.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Bugs: AURORA-330
https://issues.apache.org/jira/browse/AURORA-330
Repository: aurora
Description
---
Deny attempts to create a job update
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30389/#review70865
---
Ship it!
Ship It!
- Maxim Khutornenko
On Feb. 3, 2015, 11:53
https://reviews.apache.org/r/30586/#comment116361
You may want to drop unused CLUSTER patching in other tests as well.
- Maxim Khutornenko
On Feb. 4, 2015, 1:14 a.m., Zameer Manji wrote:
---
This is an automatically generated e-mail
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30535/#review70680
---
Ship it!
Ship It!
- Maxim Khutornenko
On Feb. 3, 2015, 12:42
On Feb. 3, 2015, 12:48 a.m., Maxim Khutornenko wrote:
The ticket suggests a possibility of the optimization route. Would you mind
commenting why you decided to remove it after all?
Bill Farner wrote:
Sure. Kevin rightly pointed out that it's odd for us to check this _one_
you mind
commenting why you decided to remove it after all?
- Maxim Khutornenko
On Feb. 3, 2015, 12:42 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30535
---
On Jan. 30, 2015, 5:23 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30480/#review70584
---
Ship it!
Ship It!
- Maxim Khutornenko
On Jan. 31, 2015, 8:31
o.a.a.b.SchedulingBenchmarks.PreemptorFallbackForLargeClusterBenchmark.runBenchmark
avgt 100 68178760.746 ± 3225821.640 ns/op
```
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/#review70587
---
@ReviewBot retry
- Maxim Khutornenko
On Feb. 2, 2015, 5:39 p.m
---
On Jan. 30, 2015, 5:23 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325
/test_updater_util.py
fe3ac49491ca710761632405ac09de0cc0d038a5
Diff: https://reviews.apache.org/r/30461/diff/
Testing (updated)
---
./pants test.pytest src/test/python/apache/aurora/client::
Thanks,
Maxim Khutornenko
101 - 200 of 1219 matches
Mail list logo
