Diff: https://reviews.apache.org/r/22788/diff/
Testing
---
gradle build
Thanks,
Maxim Khutornenko
., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22790/
---
(Updated June 19, 2014, 9:33 p.m.)
Review
-Pq build
./pants src/test/python:all
Thanks,
Maxim Khutornenko
On June 16, 2014, 9:45 p.m., Maxim Khutornenko wrote:
src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182
https://reviews.apache.org/r/22457/diff/3/?file=609592#file609592line181
I don't think it's enough to json-serialize a thrift task. This is
bound to set/dict
On June 16, 2014, 9:45 p.m., Maxim Khutornenko wrote:
src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182
https://reviews.apache.org/r/22457/diff/3/?file=609592#file609592line181
I don't think it's enough to json-serialize a thrift task. This is
bound to set/dict
On June 16, 2014, 9:45 p.m., Maxim Khutornenko wrote:
src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182
https://reviews.apache.org/r/22457/diff/3/?file=609592#file609592line181
I don't think it's enough to json-serialize a thrift task. This is
bound to set/dict
/client/api:sla
Thanks,
Maxim Khutornenko
On June 16, 2014, 9:45 p.m., Maxim Khutornenko wrote:
src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182
https://reviews.apache.org/r/22457/diff/3/?file=609592#file609592line181
I don't think it's enough to json-serialize a thrift task. This is
bound to set/dict
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22662/#review45952
---
Ship it!
Ship It!
- Maxim Khutornenko
On June 17, 2014, 2:19
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22408/#review45813
---
Ship it!
Ship It!
- Maxim Khutornenko
On June 10, 2014, 1:45
p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22483/
---
(Updated June 13, 2014, 8:17 p.m
-5163e81d082a__locks.png
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22611/#review45717
---
Ship it!
Ship It!
- Maxim Khutornenko
On June 15, 2014, 9:38
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22489/#review45617
---
Ship it!
Ship It!
- Maxim Khutornenko
On June 13, 2014, 5:20
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22483/#review45645
---
On June 11, 2014, 11:32 p.m., Maxim Khutornenko wrote
Attachments
locks
https://reviews.apache.org/media/uploaded/files/2014/06/11/df79d764-1850-40fe-8a78-5163e81d082a__locks.png
Thanks,
Maxim Khutornenko
https://reviews.apache.org/r/22489/#comment80371
We now have two places where the filter logic is replicated. Do you really
need it here?
- Maxim Khutornenko
On June 12, 2014, 1:21 a.m., Kevin Sweeney wrote
/SchedulerThriftInterface.java
https://reviews.apache.org/r/22429/#comment80372
s/taskByInstance/tasksByInstance
- Maxim Khutornenko
On June 12, 2014, 5:38 p.m., David McLaughlin wrote:
---
This is an automatically generated e-mail
https://reviews.apache.org/r/22489/#comment80470
There is quite a bit of redundancy here. Why not follow the LoadingCache
approach (e.g. the one in TaskVars)? It would be much more compact without the
drawback of increased visibility.
- Maxim Khutornenko
On June 13, 2014, 12:34 a.m., Kevin
On June 13, 2014, 1:07 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/async/Preemptor.java, line 114
https://reviews.apache.org/r/22489/diff/1-2/?file=607874#file607874line114
There is quite a bit of redundancy here. Why not follow the
LoadingCache
://reviews.apache.org/r/22448/#comment80262
You might want to encapsulate this into a helper method..
- Maxim Khutornenko
On June 11, 2014, 6:32 p.m., David McLaughlin wrote:
---
This is an automatically generated e-mail. To reply, visit
---
On June 11, 2014, 5:04 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167
/r/22167/diff/
Testing
---
./pants src/tests/python:all
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22448/#review45419
---
Ship it!
Ship It!
- Maxim Khutornenko
On June 11, 2014, 7:55
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22483/#review45447
---
On June 11, 2014, 11:32 p.m., Maxim Khutornenko wrote
it with okResponse(...)?
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
https://reviews.apache.org/r/22429/#comment80317
How about a test returning empty result in case job key has no match?
- Maxim Khutornenko
On June 10, 2014, 6:44 p.m., David McLaughlin wrote
://reviews.apache.org/r/22167/#review45109
---
On June 4, 2014, 1:46 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
, 2014, 1:46 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/
---
(Updated June 4, 2014, 1:46 a.m
/test_maintenance.py
dd56b8d1feddb48a741e1a855833eb577cea67ab
src/test/python/apache/aurora/client/commands/util.py
84784171816797f3a4fa4c5238d19b626e68ff44
Diff: https://reviews.apache.org/r/22167/diff/
Testing
---
./pants src/tests/python:all
Thanks,
Maxim Khutornenko
/test_maintenance.py
dd56b8d1feddb48a741e1a855833eb577cea67ab
src/test/python/apache/aurora/client/commands/util.py
84784171816797f3a4fa4c5238d19b626e68ff44
Diff: https://reviews.apache.org/r/22167/diff/
Testing
---
./pants src/tests/python:all
Thanks,
Maxim Khutornenko
? The time period over which a certain percentage of
tasks must have been up all the time? Time period over which a percentage
of tasks must have been up for at least some amount of time?
Maxim Khutornenko wrote:
The override comments here are intentionally vague to discourage
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167/#review45175
---
Ping, Brian/Joe.
- Maxim Khutornenko
On June 9, 2014, 11:10 p.m
extra space
- Maxim Khutornenko
On June 6, 2014, 3:38 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22023
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20285/#review44931
---
Ship it!
Ship It!
- Maxim Khutornenko
On June 4, 2014, 10:50
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19767/#review44932
---
Kevin, could you please mark it as submitted?
- Maxim Khutornenko
/commands:admin
Thanks,
Maxim Khutornenko
/client/api/updater.py
de7912ce10f04d9e4c73faac4198741f47189258
src/test/python/apache/aurora/client/api/test_updater.py
0ee342c848e15666d34fd38d3cd22574b9346ee3
Diff: https://reviews.apache.org/r/22334/diff/
Testing
---
./pants src/test/python:all
Thanks,
Maxim Khutornenko
/test/python/apache/aurora/client/commands/test_admin.py
40b873b0c1e91d0bc3b40e60c7a6077b50b47a2b
Diff: https://reviews.apache.org/r/22281/diff/
Testing
---
./pants src/test/python/apache/aurora/client/commands:admin
Thanks,
Maxim Khutornenko
/client/commands:admin
Thanks,
Maxim Khutornenko
/cron.py
https://reviews.apache.org/r/22023/#comment79251
A similar pattern but without raising an error. Perhaps something like
check_and_log_custom_error(self, resp, context)?
- Maxim Khutornenko
On June 4, 2014, 1:08 p.m., Mark Chu-Carroll wrote
/22167/#review44684
---
On June 3, 2014, 12:26 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22167
/test_maintenance.py
dd56b8d1feddb48a741e1a855833eb577cea67ab
src/test/python/apache/aurora/client/commands/util.py
84784171816797f3a4fa4c5238d19b626e68ff44
Diff: https://reviews.apache.org/r/22167/diff/
Testing
---
./pants src/tests/python:all
Thanks,
Maxim Khutornenko
/22094/diff/
Testing
---
Thanks,
Maxim Khutornenko
/22094/diff/
Testing
---
Thanks,
Maxim Khutornenko
On May 29, 2014, 11:58 a.m., Mark Chu-Carroll wrote:
Why?
Right now, I do a lot of debugging of the client using vagrant. My typical
workflow is:
- Make the change in my git workspace.
- Commit it to a branch.
- vagrant ssh into the virtual cluster
- git pull /vagrant mybranch
/test_end_to_end.sh
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22007/#review44262
---
Ship it!
Ship It!
- Maxim Khutornenko
On May 29, 2014, 4:32 a.m
/22032/#comment78651
Perhaps just referencing the vagrant.md instead?
- Maxim Khutornenko
On May 29, 2014, 7:30 p.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22056/#review44298
---
Ship it!
Ship It!
- Maxim Khutornenko
On May 29, 2014, 9:30 p.m
https://reviews.apache.org/r/21951/#comment78448
Do we really want to start using Locale everywhere when dealing with string
conversion? It might be better to just make it a pre-requisite for the Aurora
rather than handling it in code.
- Maxim Khutornenko
On May 28, 2014, 12:57 a.m., Bill
On May 28, 2014, 4:26 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/http/Utilization.java, line 164
https://reviews.apache.org/r/21951/diff/1/?file=595644#file595644line164
Do we really want to start using Locale everywhere when dealing with
string
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21849/#review43976
---
Ship it!
Ship It!
- Maxim Khutornenko
On May 23, 2014, 8:26 p.m
://reviews.apache.org/r/21830/#comment78223
Would it make sense to change it to list instead? I can imagine how the
order may be helpful here in troubleshooting multi-message errors.
- Maxim Khutornenko
On May 23, 2014, 7:30 p.m., Bill Farner wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21440/#review43979
---
Ping Brian, Mark.
- Maxim Khutornenko
On May 23, 2014, 1:19 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21741/#review43980
---
Ping Mark, Joe.
- Maxim Khutornenko
On May 23, 2014, 1:12 a.m
On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java,
line 49
https://reviews.apache.org/r/21830/diff/2/?file=590896#file590896line49
We don't inline @Inject with methods, why here?
Bill Farner wrote
On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote:
src/main/thrift/org/apache/aurora/gen/api.thrift, line 471
https://reviews.apache.org/r/21830/diff/2/?file=590911#file590911line471
Would it make sense to change it to list instead? I can imagine how the
order may be helpful
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21440/#review44016
---
On May 23, 2014, 1:19 a.m., Maxim Khutornenko wrote
/test_end_to_end.sh
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21741/#review44015
---
On May 23, 2014, 1:12 a.m., Maxim Khutornenko wrote
---
./pants src/test/python:all
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21945/#review44085
---
Ship it!
Ship It!
- Maxim Khutornenko
On May 28, 2014, 12:22
4eb081a5648203ac148d50850d5e4f6b310d3562
Diff: https://reviews.apache.org/r/21952/diff/
Testing
---
./pants src/test/python:all
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21945/#review44086
---
This is on master now.
- Maxim Khutornenko
On May 28, 2014, 12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21741/#review43724
---
Ping.
- Maxim Khutornenko
On May 21, 2014, 12:24 a.m., Maxim
/python:all
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21455/#review43769
---
Ship it!
Ship It!
- Maxim Khutornenko
On May 22, 2014, 7:46 p.m
/python:all
Thanks,
Maxim Khutornenko
Thanks,
Maxim Khutornenko
that findbugs does not
already do? My only concern is build performance. That said, if it does not
take long to run I am in.
- Maxim Khutornenko
On May 21, 2014, 6:05 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail
://reviews.apache.org/r/21597/#review43569
---
On May 19, 2014, 5:58 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21597
/test_end_to_end.sh
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21440/#review43523
---
On May 15, 2014, 10:52 p.m., Maxim Khutornenko wrote
/maintenance.py
68d63a12bb92bb2f50ae45363513892ad9bbb1ff
src/test/python/apache/aurora/admin/test_host_maintenance.py
18bf6223adb6b64cc76c2810abc317ef063e16e2
Diff: https://reviews.apache.org/r/21781/diff/
Testing
---
./pants src/test/python:all
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21753/#review43657
---
Ship it!
Ship It!
- Maxim Khutornenko
On May 21, 2014, 8:02 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21132/#review43518
---
Ship it!
Ship It!
- Maxim Khutornenko
On May 13, 2014, 6:27 p.m
On May 15, 2014, 11:04 p.m., Maxim Khutornenko wrote:
build.gradle, line 235
https://reviews.apache.org/r/21455/diff/1/?file=581766#file581766line235
How about a custom target instead? Having something like gradle
build_cq would be easier to remember for use outside of jenkins
On May 15, 2014, 11:04 p.m., Maxim Khutornenko wrote:
build.gradle, line 235
https://reviews.apache.org/r/21455/diff/1/?file=581766#file581766line235
How about a custom target instead? Having something like gradle
build_cq would be easier to remember for use outside of jenkins
86b6775e51cab1214a6cae01145f19f08cc74499
src/test/python/apache/aurora/client/commands/test_admin_sla.py
df007f2e0de70cd6c3295119d7ef3877cfce036d
Diff: https://reviews.apache.org/r/21741/diff/
Testing
---
./pants src/test/python:all
Thanks,
Maxim Khutornenko
On May 16, 2014, 4 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java, line
43
https://reviews.apache.org/r/21132/diff/3/?file=580759#file580759line43
Breaking the abstraction by having a JobKeyMapper here is quite
unfortunate
/diff/
Testing
---
./pants src/test/python:all
Thanks,
Maxim Khutornenko
On May 19, 2014, 9:11 p.m., Mark Chu-Carroll wrote:
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 258
https://reviews.apache.org/r/21383/diff/3/?file=584301#file584301line258
There are tests of scheduleCronJob and descheduleCronJob below.
build
gradle run
Thanks,
Maxim Khutornenko
---
./pants src/test/python:all
Thanks,
Maxim Khutornenko
. To reply, visit:
https://reviews.apache.org/r/21297/#review43056
---
On May 14, 2014, 11:46 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit
p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21297/
---
(Updated May 14, 2014, 11:46 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21502/#review43183
---
Ship it!
Ship It!
- Maxim Khutornenko
On May 15, 2014, 10:56
the dependency?
Something like:
locks(..., FK:lock_key_id)
lock_keys(lock_key_id, lock_type, FK:lock_type_id - job_key_id)
job_keys(job_key_id, ...)
- Maxim Khutornenko
On May 13, 2014, 6:27 p.m., David McLaughlin wrote
/#review43046
---
On May 14, 2014, 6:49 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21440
How about a custom target instead? Having something like gradle build_cq
would be easier to remember for use outside of jenkins script.
- Maxim Khutornenko
On May 14, 2014, 8:31 p.m., Bill Farner wrote:
---
This is an automatically
., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21440/
---
(Updated May 14, 2014, 6:49 p.m.)
Review
://reviews.apache.org/r/21297/#review43014
---
On May 14, 2014, 8:01 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
---
./pants src/test/python:all
Thanks,
Maxim Khutornenko
-mail. To reply, visit:
https://reviews.apache.org/r/21349/#review43055
---
On May 14, 2014, 9:58 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19767/#review43061
---
Ship it!
Ship It!
- Maxim Khutornenko
On May 15, 2014, 12:08
Thanks,
Maxim Khutornenko
/test/python/apache/aurora/client/test_config.py
8ef08685c317c3f9dae799dfb6bdced7077a8778
Diff: https://reviews.apache.org/r/21297/diff/
Testing
---
./pants src/test/python:all
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21352/#review42834
---
Ship it!
Ship It!
- Maxim Khutornenko
On May 13, 2014, 12:06
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21297/#review42887
---
On May 10, 2014, 1:15 a.m., Maxim Khutornenko wrote
---
On May 13, 2014, 10:09 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21349
901 - 1000 of 1219 matches
Mail list logo
