Re: Review Request 24871: Converting perform_maintenance_hosts into host_drain.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24871/#review51306
---



src/main/python/apache/aurora/admin/host_maintenance.py
<https://reviews.apache.org/r/24871/#comment89470>

If we're no longer wrapping a full maintenance process (which is fine) we 
shouldn't do the callback anymore. (It'll remove some complexity here, and we 
can just make the callers worry about formatting and such)



src/main/python/apache/aurora/client/commands/maintenance.py
<https://reviews.apache.org/r/24871/#comment89472>

ack on this- it'd be nice to still have a '1-command-for-all-the-things' 
but that's aight


- Joe Smith


On Aug. 21, 2014, 4:23 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24871/
> ---
> 
> (Updated Aug. 21, 2014, 4:23 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-43
> https://issues.apache.org/jira/browse/AURORA-43
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Converting perform_maintenance_hosts into host_drain.
> 
> Also, renaming maintenance commands to address AURORA-43.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/admin_util.py 
> 31ec2b1fb06e1ad5f8c00978b091e7ab01fbb7ab 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> 162f9afea67e409d784e436c96f55ceed0537ca1 
>   src/main/python/apache/aurora/client/commands/maintenance.py 
> a54f0f663590033989db0d2cf3521453bf87de6a 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 
> d8aeffb5035a55ced485318444002141dada5bfc 
>   src/test/python/apache/aurora/client/commands/test_maintenance.py 
> a748c0183997a59f1773a2be62ec17f6c11ddd3a 
> 
> Diff: https://reviews.apache.org/r/24871/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 24871: Converting perform_maintenance_hosts into host_drain.

[Joe Smith]

> On Aug. 22, 2014, 11:39 a.m., Joe Smith wrote:
> > src/main/python/apache/aurora/admin/host_maintenance.py, line 187
> > <https://reviews.apache.org/r/24871/diff/2/?file=68#file68line187>
> >
> > If we're no longer wrapping a full maintenance process (which is fine) 
> > we shouldn't do the callback anymore. (It'll remove some complexity here, 
> > and we can just make the callers worry about formatting and such)
> 
> Maxim Khutornenko wrote:
> I don't see why we should remove it. This is a nice to have feature, 
> which adds flexibility in case someone needs to run a post-drain script. 
> What's pressing the removal?

Keeping the callback here isn't necessary- instead of specifying a callback, 
the caller of this should just operate on the hosts once this function returns 
and hosts are drained.

(It was only useful before since it was sandwiched inbetween the 
drain/end_maintenance, but now the end_maintenance is gone)


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24871/#review51306
---


On Aug. 21, 2014, 4:23 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24871/
> -------
> 
> (Updated Aug. 21, 2014, 4:23 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-43
> https://issues.apache.org/jira/browse/AURORA-43
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Converting perform_maintenance_hosts into host_drain.
> 
> Also, renaming maintenance commands to address AURORA-43.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/admin_util.py 
> 31ec2b1fb06e1ad5f8c00978b091e7ab01fbb7ab 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> 162f9afea67e409d784e436c96f55ceed0537ca1 
>   src/main/python/apache/aurora/client/commands/maintenance.py 
> a54f0f663590033989db0d2cf3521453bf87de6a 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 
> d8aeffb5035a55ced485318444002141dada5bfc 
>   src/test/python/apache/aurora/client/commands/test_maintenance.py 
> a748c0183997a59f1773a2be62ec17f6c11ddd3a 
> 
> Diff: https://reviews.apache.org/r/24871/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 24871: Converting perform_maintenance_hosts into host_drain.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24871/#review51331
---

Ship it!


Thank you!!

- Joe Smith


On Aug. 22, 2014, 2:26 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24871/
> ---
> 
> (Updated Aug. 22, 2014, 2:26 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-43
> https://issues.apache.org/jira/browse/AURORA-43
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Converting perform_maintenance_hosts into host_drain.
> 
> Also, renaming maintenance commands to address AURORA-43.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/admin_util.py 
> 31ec2b1fb06e1ad5f8c00978b091e7ab01fbb7ab 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> 162f9afea67e409d784e436c96f55ceed0537ca1 
>   src/main/python/apache/aurora/client/commands/maintenance.py 
> a54f0f663590033989db0d2cf3521453bf87de6a 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 
> d8aeffb5035a55ced485318444002141dada5bfc 
>   src/test/python/apache/aurora/client/commands/test_maintenance.py 
> a748c0183997a59f1773a2be62ec17f6c11ddd3a 
> 
> Diff: https://reviews.apache.org/r/24871/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 25208: Increment Mesos version to 0.20.0

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25208/
---

Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Brian Wickman.


Bugs: AURORA-674
https://issues.apache.org/jira/browse/AURORA-674


Repository: aurora


Description
---

There's an API change when moving the python executor to 0.20.0, which should 
deserve extra scrutiny. 


Diffs
-

  3rdparty/python/BUILD edc446e6d76d53a4c10a703cf6e84e29b8d42366 
  build.gradle 66c8205c8354048c398623edf7ba75e721376b01 
  examples/vagrant/provision-dev-cluster.sh 
2ce74f8a6dc663b62d254bc9d3a5c06cb412107f 
  src/main/python/apache/aurora/executor/BUILD 
c1c50dbcdcaa56f8ff970ceac59d5db537e1d048 
  src/main/python/apache/aurora/executor/aurora_executor.py 
8985aeb60e2c890113ea7d25039cdab5b7c9a19e 
  src/main/python/apache/aurora/executor/bin/BUILD 
93517150db96600c92ea25c0de29ec20736d72f7 
  src/main/python/apache/aurora/executor/common/BUILD 
0a4d35afcbfca8730d8bb7373795f9b3b6a74fd7 
  src/main/python/apache/aurora/executor/common/health_checker.py 
671f4970d4637b8cb68ec89e5dfe96a2f4cd077b 
  src/main/python/apache/aurora/executor/common/kill_manager.py 
6e482cfa7d2e081804fe6992527bae0ac5b65080 
  src/main/python/apache/aurora/executor/common/status_checker.py 
eda30e38d34adc5c78b828d0aea31f0721bf9b20 
  src/main/python/apache/aurora/executor/executor_base.py 
c632b77d972f76f3e260bb7413aa6100cda46607 
  src/main/python/apache/aurora/executor/gc_executor.py 
c45d5eb9a99e310e0716abd626ca34615f63b0ae 
  src/main/python/apache/aurora/executor/thermos_task_runner.py 
03a40e63573322f2d40e59a8ce84e9b9a1b90aa6 
  src/test/python/apache/aurora/executor/BUILD 
3152ec0c0e7dfaec5d756542a89243756b27725d 
  src/test/python/apache/aurora/executor/common/BUILD 
6316c7fc724c8e2245f5ce1a93c4a2daecd9f26b 
  src/test/python/apache/aurora/executor/common/test_health_checker.py 
baeaba29e7679203d83f6ea81455973baf07f324 
  src/test/python/apache/aurora/executor/common/test_kill_manager.py 
PRE-CREATION 
  src/test/python/apache/aurora/executor/common/test_status_checker.py 
6ca4fd469bdc7cd21033ccdea460292463bc1cf8 
  src/test/python/apache/aurora/executor/test_executor_base.py PRE-CREATION 
  src/test/python/apache/aurora/executor/test_gc_executor.py 
0b2278a94667ca4d43e8a84649ed5312acacf7bb 
  src/test/python/apache/aurora/executor/test_status_manager.py PRE-CREATION 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
55747a19478572e39d1f00f799727d3c3db174c9 
  src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
f7af70fda8fef91018ff9d10dc1db6d43fd16ac7 

Diff: https://reviews.apache.org/r/25208/diff/


Testing
---

$ ./gradlew test

[tw-mbp13-jsmith aurora (yasumoto/mesos_0.20.0)]$ 
./build-support/python/checkstyle-check && ./pants 
./src/test/python/apache/aurora/executor:all
src.test.python.apache.aurora.executor.common.announcer 
.   SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox 
.   SUCCESS
src.test.python.apache.aurora.executor.common.health_checker
.   SUCCESS
src.test.python.apache.aurora.executor.common.status_checker
.   SUCCESS
src.test.python.apache.aurora.executor.common.task_info 
.   SUCCESS
src.test.python.apache.aurora.executor.executor_base
.   SUCCESS
src.test.python.apache.aurora.executor.executor_detector
.   SUCCESS
src.test.python.apache.aurora.executor.executor_vars
.   SUCCESS
src.test.python.apache.aurora.executor.gc_executor  
.   SUCCESS
src.test.python.apache.aurora.executor.status_manager   
.   SUCCESS
src.test.python.apache.aurora.executor.thermos_executor 
.   SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner  
.   SUCCESS


Thanks,

Joe Smith

Re: Review Request 25208: Increment Mesos version to 0.20.0

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25208/
---

(Updated Aug. 29, 2014, 4:58 p.m.)


Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Brian Wickman.


Changes
---

Add try/catch around imports to support the migration in most (all?) places


Bugs: AURORA-674
https://issues.apache.org/jira/browse/AURORA-674


Repository: aurora


Description
---

There's an API change when moving the python executor to 0.20.0, which should 
deserve extra scrutiny. 


Diffs (updated)
-

  3rdparty/python/BUILD edc446e6d76d53a4c10a703cf6e84e29b8d42366 
  build.gradle 66c8205c8354048c398623edf7ba75e721376b01 
  examples/vagrant/provision-dev-cluster.sh 
2ce74f8a6dc663b62d254bc9d3a5c06cb412107f 
  src/main/python/apache/aurora/executor/BUILD 
c1c50dbcdcaa56f8ff970ceac59d5db537e1d048 
  src/main/python/apache/aurora/executor/aurora_executor.py 
8985aeb60e2c890113ea7d25039cdab5b7c9a19e 
  src/main/python/apache/aurora/executor/bin/BUILD 
93517150db96600c92ea25c0de29ec20736d72f7 
  src/main/python/apache/aurora/executor/common/BUILD 
0a4d35afcbfca8730d8bb7373795f9b3b6a74fd7 
  src/main/python/apache/aurora/executor/common/health_checker.py 
671f4970d4637b8cb68ec89e5dfe96a2f4cd077b 
  src/main/python/apache/aurora/executor/common/kill_manager.py 
6e482cfa7d2e081804fe6992527bae0ac5b65080 
  src/main/python/apache/aurora/executor/common/status_checker.py 
eda30e38d34adc5c78b828d0aea31f0721bf9b20 
  src/main/python/apache/aurora/executor/executor_base.py 
c632b77d972f76f3e260bb7413aa6100cda46607 
  src/main/python/apache/aurora/executor/gc_executor.py 
c45d5eb9a99e310e0716abd626ca34615f63b0ae 
  src/main/python/apache/aurora/executor/thermos_task_runner.py 
03a40e63573322f2d40e59a8ce84e9b9a1b90aa6 
  src/test/python/apache/aurora/executor/BUILD 
3152ec0c0e7dfaec5d756542a89243756b27725d 
  src/test/python/apache/aurora/executor/common/BUILD 
6316c7fc724c8e2245f5ce1a93c4a2daecd9f26b 
  src/test/python/apache/aurora/executor/common/test_health_checker.py 
baeaba29e7679203d83f6ea81455973baf07f324 
  src/test/python/apache/aurora/executor/common/test_kill_manager.py 
PRE-CREATION 
  src/test/python/apache/aurora/executor/common/test_status_checker.py 
6ca4fd469bdc7cd21033ccdea460292463bc1cf8 
  src/test/python/apache/aurora/executor/test_executor_base.py PRE-CREATION 
  src/test/python/apache/aurora/executor/test_gc_executor.py 
0b2278a94667ca4d43e8a84649ed5312acacf7bb 
  src/test/python/apache/aurora/executor/test_status_manager.py PRE-CREATION 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
55747a19478572e39d1f00f799727d3c3db174c9 
  src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
f7af70fda8fef91018ff9d10dc1db6d43fd16ac7 

Diff: https://reviews.apache.org/r/25208/diff/


Testing
---

$ ./gradlew test

[tw-mbp13-jsmith aurora (yasumoto/mesos_0.20.0)]$ 
./build-support/python/checkstyle-check && ./pants 
./src/test/python/apache/aurora/executor:all
src.test.python.apache.aurora.executor.common.announcer 
.   SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox 
.   SUCCESS
src.test.python.apache.aurora.executor.common.health_checker
.   SUCCESS
src.test.python.apache.aurora.executor.common.status_checker
.   SUCCESS
src.test.python.apache.aurora.executor.common.task_info 
.   SUCCESS
src.test.python.apache.aurora.executor.executor_base
.   SUCCESS
src.test.python.apache.aurora.executor.executor_detector
.   SUCCESS
src.test.python.apache.aurora.executor.executor_vars
.   SUCCESS
src.test.python.apache.aurora.executor.gc_executor  
.   SUCCESS
src.test.python.apache.aurora.executor.status_manager   
.   SUCCESS
src.test.python.apache.aurora.executor.thermos_executor 
.   SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner  
.   SUCCESS


Thanks,

Joe Smith

Re: Review Request 25208: Increment Mesos version to 0.20.0

[Joe Smith]

ython/apache/aurora/executor:all
src.test.python.apache.aurora.executor.common.announcer 
.   SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox 
.   SUCCESS
src.test.python.apache.aurora.executor.common.health_checker
.   SUCCESS
src.test.python.apache.aurora.executor.common.status_checker
.   SUCCESS
src.test.python.apache.aurora.executor.common.task_info 
.   SUCCESS
src.test.python.apache.aurora.executor.executor_base
.   SUCCESS
src.test.python.apache.aurora.executor.executor_detector
.   SUCCESS
src.test.python.apache.aurora.executor.executor_vars
.   SUCCESS
src.test.python.apache.aurora.executor.gc_executor  
.   SUCCESS
src.test.python.apache.aurora.executor.status_manager   
.   SUCCESS
src.test.python.apache.aurora.executor.thermos_executor 
.   SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner  
.   SUCCESS


Thanks,

Joe Smith

Re: Review Request 25175: Fix possible deadlock in TaskRunner.collect_updates.

[Joe Smith]

> On Aug. 28, 2014, 4:49 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/thermos/core/runner.py, line 821
> > 
> >
> > *Regression test y/n ?*
> > Definitely yes from me.

+1


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25175/#review51852
---


On Aug. 28, 2014, 4:34 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25175/
> ---
> 
> (Updated Aug. 28, 2014, 4:34 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-669
> https://issues.apache.org/jira/browse/AURORA-669
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix possible deadlock in TaskRunner.collect_updates.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/thermos/core/runner.py 
> ec4cdb788a1e24a590b262ba8dbd044cf31fc198 
> 
> Diff: https://reviews.apache.org/r/25175/diff/
> 
> 
> Testing
> ---
> 
> Regression test y/n ?
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 25208: Increment Mesos version to 0.20.0

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25208/
---

(Updated Sept. 2, 2014, 5:45 p.m.)


Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Brian Wickman.


Changes
---

Worked with Zameer to upgrade the vagrant devcluster to Ubuntu 14.04 (the 
latest LTS release)


Bugs: AURORA-674
https://issues.apache.org/jira/browse/AURORA-674


Repository: aurora


Description
---

There's an API change when moving the python executor to 0.20.0, which should 
deserve extra scrutiny. 


Diffs (updated)
-

  3rdparty/python/BUILD edc446e6d76d53a4c10a703cf6e84e29b8d42366 
  Vagrantfile c8cb2d440330780c10eeff47d46cc1a3f1aa4910 
  build.gradle 66c8205c8354048c398623edf7ba75e721376b01 
  examples/vagrant/provision-dev-cluster.sh 
2ce74f8a6dc663b62d254bc9d3a5c06cb412107f 
  src/main/python/apache/aurora/executor/BUILD 
c1c50dbcdcaa56f8ff970ceac59d5db537e1d048 
  src/main/python/apache/aurora/executor/aurora_executor.py 
8985aeb60e2c890113ea7d25039cdab5b7c9a19e 
  src/main/python/apache/aurora/executor/bin/BUILD 
93517150db96600c92ea25c0de29ec20736d72f7 
  src/main/python/apache/aurora/executor/bin/gc_executor_main.py 
bc20dad1e5434a98fb51ab052efa8ced760e74e0 
  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
aacc19a3bd272b08dee8a77d7a64490d0fcad3fa 
  src/main/python/apache/aurora/executor/common/BUILD 
0a4d35afcbfca8730d8bb7373795f9b3b6a74fd7 
  src/main/python/apache/aurora/executor/common/health_checker.py 
671f4970d4637b8cb68ec89e5dfe96a2f4cd077b 
  src/main/python/apache/aurora/executor/common/kill_manager.py 
6e482cfa7d2e081804fe6992527bae0ac5b65080 
  src/main/python/apache/aurora/executor/common/status_checker.py 
eda30e38d34adc5c78b828d0aea31f0721bf9b20 
  src/main/python/apache/aurora/executor/executor_base.py 
c632b77d972f76f3e260bb7413aa6100cda46607 
  src/main/python/apache/aurora/executor/gc_executor.py 
c45d5eb9a99e310e0716abd626ca34615f63b0ae 
  src/main/python/apache/aurora/executor/thermos_task_runner.py 
03a40e63573322f2d40e59a8ce84e9b9a1b90aa6 
  src/test/python/apache/aurora/executor/BUILD 
3152ec0c0e7dfaec5d756542a89243756b27725d 
  src/test/python/apache/aurora/executor/common/BUILD 
6316c7fc724c8e2245f5ce1a93c4a2daecd9f26b 
  src/test/python/apache/aurora/executor/common/test_executor_timeout.py 
PRE-CREATION 
  src/test/python/apache/aurora/executor/common/test_health_checker.py 
baeaba29e7679203d83f6ea81455973baf07f324 
  src/test/python/apache/aurora/executor/common/test_kill_manager.py 
PRE-CREATION 
  src/test/python/apache/aurora/executor/common/test_status_checker.py 
6ca4fd469bdc7cd21033ccdea460292463bc1cf8 
  src/test/python/apache/aurora/executor/test_executor_base.py PRE-CREATION 
  src/test/python/apache/aurora/executor/test_gc_executor.py 
0b2278a94667ca4d43e8a84649ed5312acacf7bb 
  src/test/python/apache/aurora/executor/test_status_manager.py PRE-CREATION 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
55747a19478572e39d1f00f799727d3c3db174c9 
  src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
f7af70fda8fef91018ff9d10dc1db6d43fd16ac7 

Diff: https://reviews.apache.org/r/25208/diff/


Testing
---

$ ./gradlew test

[tw-mbp13-jsmith aurora (yasumoto/mesos_0.20.0)]$ 
./build-support/python/checkstyle-check && ./pants 
./src/test/python/apache/aurora/executor:all
src.test.python.apache.aurora.executor.common.announcer 
.   SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox 
.   SUCCESS
src.test.python.apache.aurora.executor.common.health_checker
.   SUCCESS
src.test.python.apache.aurora.executor.common.status_checker
.   SUCCESS
src.test.python.apache.aurora.executor.common.task_info 
.   SUCCESS
src.test.python.apache.aurora.executor.executor_base
.   SUCCESS
src.test.python.apache.aurora.executor.executor_detector
.   SUCCESS
src.test.python.apache.aurora.executor.executor_vars
.   SUCCESS
src.test.python.apache.aurora.executor.gc_executor  
.   SUCCESS
src.test.python.apache.aurora.executor.status_manager   
.   SUCCESS
src.test.python.apache.aurora.executor.thermos_executor 
.   SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner  
.   SUCCESS


Thanks,

Joe Smith

Re: Review Request 25208: Increment Mesos version to 0.20.0

[Joe Smith]

> On Sept. 2, 2014, 11:08 a.m., Brian Wickman wrote:
> > the test coverage is a great improvement.  thanks joe!
> > 
> > what's the status of mesos.native + the e2e test?  abi incompatible with 
> > our vagrant image?

Still working on it- Zameer claims success, but I'm waiting to pull down + 
provision the new image. Zameer is going to work on pre-provisioning a dev 
image so we can just pull it down and not wait for it to apt-get install the 
whole world.


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25208/#review52049
-------


On Sept. 2, 2014, 5:45 p.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25208/
> ---
> 
> (Updated Sept. 2, 2014, 5:45 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Brian 
> Wickman.
> 
> 
> Bugs: AURORA-674
> https://issues.apache.org/jira/browse/AURORA-674
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> There's an API change when moving the python executor to 0.20.0, which should 
> deserve extra scrutiny. 
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD edc446e6d76d53a4c10a703cf6e84e29b8d42366 
>   Vagrantfile c8cb2d440330780c10eeff47d46cc1a3f1aa4910 
>   build.gradle 66c8205c8354048c398623edf7ba75e721376b01 
>   examples/vagrant/provision-dev-cluster.sh 
> 2ce74f8a6dc663b62d254bc9d3a5c06cb412107f 
>   src/main/python/apache/aurora/executor/BUILD 
> c1c50dbcdcaa56f8ff970ceac59d5db537e1d048 
>   src/main/python/apache/aurora/executor/aurora_executor.py 
> 8985aeb60e2c890113ea7d25039cdab5b7c9a19e 
>   src/main/python/apache/aurora/executor/bin/BUILD 
> 93517150db96600c92ea25c0de29ec20736d72f7 
>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py 
> bc20dad1e5434a98fb51ab052efa8ced760e74e0 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> aacc19a3bd272b08dee8a77d7a64490d0fcad3fa 
>   src/main/python/apache/aurora/executor/common/BUILD 
> 0a4d35afcbfca8730d8bb7373795f9b3b6a74fd7 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 671f4970d4637b8cb68ec89e5dfe96a2f4cd077b 
>   src/main/python/apache/aurora/executor/common/kill_manager.py 
> 6e482cfa7d2e081804fe6992527bae0ac5b65080 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> eda30e38d34adc5c78b828d0aea31f0721bf9b20 
>   src/main/python/apache/aurora/executor/executor_base.py 
> c632b77d972f76f3e260bb7413aa6100cda46607 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> c45d5eb9a99e310e0716abd626ca34615f63b0ae 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 03a40e63573322f2d40e59a8ce84e9b9a1b90aa6 
>   src/test/python/apache/aurora/executor/BUILD 
> 3152ec0c0e7dfaec5d756542a89243756b27725d 
>   src/test/python/apache/aurora/executor/common/BUILD 
> 6316c7fc724c8e2245f5ce1a93c4a2daecd9f26b 
>   src/test/python/apache/aurora/executor/common/test_executor_timeout.py 
> PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> baeaba29e7679203d83f6ea81455973baf07f324 
>   src/test/python/apache/aurora/executor/common/test_kill_manager.py 
> PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/test_status_checker.py 
> 6ca4fd469bdc7cd21033ccdea460292463bc1cf8 
>   src/test/python/apache/aurora/executor/test_executor_base.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/test_gc_executor.py 
> 0b2278a94667ca4d43e8a84649ed5312acacf7bb 
>   src/test/python/apache/aurora/executor/test_status_manager.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> 55747a19478572e39d1f00f799727d3c3db174c9 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
> f7af70fda8fef91018ff9d10dc1db6d43fd16ac7 
> 
> Diff: https://reviews.apache.org/r/25208/diff/
> 
> 
> Testing
> ---
> 
> $ ./gradlew test
> 
> [tw-mbp13-jsmith aurora (yasumoto/mesos_0.20.0)]$ 
> ./build-support/python/checkstyle-check && ./pants 
> ./src/test/python/apache/aurora/executor:all
> src.test.python.apache.aurora.executor.common.announcer   
>   .   SUCCESS
> src.test.python.apache.aurora.executor.common.directory_sandbox   
>   .   SUCCESS
> src.test.python.apache.aurora.executor.common.health_checker  
>   .   SUCCESS
> src.test.python

Re: Review Request 25208: Increment Mesos version to 0.20.0

[Joe Smith]

> On Sept. 2, 2014, 11:08 a.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/executor/thermos_task_runner.py, lines 45-50
> > <https://reviews.apache.org/r/25208/diff/3/?file=672643#file672643line45>
> >
> > should these be
> > 
> > mesos_pb2.TASK_LOST
> > mesos_pb2.TASK_KILLED
> > 
> > ...etc?

Absolutely- great catch!


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25208/#review52049
-------


On Sept. 2, 2014, 5:45 p.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25208/
> ---
> 
> (Updated Sept. 2, 2014, 5:45 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Brian 
> Wickman.
> 
> 
> Bugs: AURORA-674
> https://issues.apache.org/jira/browse/AURORA-674
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> There's an API change when moving the python executor to 0.20.0, which should 
> deserve extra scrutiny. 
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD edc446e6d76d53a4c10a703cf6e84e29b8d42366 
>   Vagrantfile c8cb2d440330780c10eeff47d46cc1a3f1aa4910 
>   build.gradle 66c8205c8354048c398623edf7ba75e721376b01 
>   examples/vagrant/provision-dev-cluster.sh 
> 2ce74f8a6dc663b62d254bc9d3a5c06cb412107f 
>   src/main/python/apache/aurora/executor/BUILD 
> c1c50dbcdcaa56f8ff970ceac59d5db537e1d048 
>   src/main/python/apache/aurora/executor/aurora_executor.py 
> 8985aeb60e2c890113ea7d25039cdab5b7c9a19e 
>   src/main/python/apache/aurora/executor/bin/BUILD 
> 93517150db96600c92ea25c0de29ec20736d72f7 
>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py 
> bc20dad1e5434a98fb51ab052efa8ced760e74e0 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> aacc19a3bd272b08dee8a77d7a64490d0fcad3fa 
>   src/main/python/apache/aurora/executor/common/BUILD 
> 0a4d35afcbfca8730d8bb7373795f9b3b6a74fd7 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 671f4970d4637b8cb68ec89e5dfe96a2f4cd077b 
>   src/main/python/apache/aurora/executor/common/kill_manager.py 
> 6e482cfa7d2e081804fe6992527bae0ac5b65080 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> eda30e38d34adc5c78b828d0aea31f0721bf9b20 
>   src/main/python/apache/aurora/executor/executor_base.py 
> c632b77d972f76f3e260bb7413aa6100cda46607 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> c45d5eb9a99e310e0716abd626ca34615f63b0ae 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 03a40e63573322f2d40e59a8ce84e9b9a1b90aa6 
>   src/test/python/apache/aurora/executor/BUILD 
> 3152ec0c0e7dfaec5d756542a89243756b27725d 
>   src/test/python/apache/aurora/executor/common/BUILD 
> 6316c7fc724c8e2245f5ce1a93c4a2daecd9f26b 
>   src/test/python/apache/aurora/executor/common/test_executor_timeout.py 
> PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> baeaba29e7679203d83f6ea81455973baf07f324 
>   src/test/python/apache/aurora/executor/common/test_kill_manager.py 
> PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/test_status_checker.py 
> 6ca4fd469bdc7cd21033ccdea460292463bc1cf8 
>   src/test/python/apache/aurora/executor/test_executor_base.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/test_gc_executor.py 
> 0b2278a94667ca4d43e8a84649ed5312acacf7bb 
>   src/test/python/apache/aurora/executor/test_status_manager.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> 55747a19478572e39d1f00f799727d3c3db174c9 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
> f7af70fda8fef91018ff9d10dc1db6d43fd16ac7 
> 
> Diff: https://reviews.apache.org/r/25208/diff/
> 
> 
> Testing
> ---
> 
> $ ./gradlew test
> 
> [tw-mbp13-jsmith aurora (yasumoto/mesos_0.20.0)]$ 
> ./build-support/python/checkstyle-check && ./pants 
> ./src/test/python/apache/aurora/executor:all
> src.test.python.apache.aurora.executor.common.announcer   
>   .   SUCCESS
> src.test.python.apache.aurora.executor.common.directory_sandbox   
>   .   SUCCESS
> src.test.python.apache.aurora.executor.common.health_checker  
>   .   SUCCESS
> src.test.python.apache.aurora.executor.common.status_checker  
>   

Re: Review Request 25208: Increment Mesos version to 0.20.0

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25208/
---

(Updated Sept. 2, 2014, 6:45 p.m.)


Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Brian Wickman.


Changes
---

Running another round of e2e tests, but please take a look in the meantime!


Bugs: AURORA-674
https://issues.apache.org/jira/browse/AURORA-674


Repository: aurora


Description
---

There's an API change when moving the python executor to 0.20.0, which should 
deserve extra scrutiny. 


Diffs (updated)
-

  3rdparty/python/BUILD edc446e6d76d53a4c10a703cf6e84e29b8d42366 
  Vagrantfile c8cb2d440330780c10eeff47d46cc1a3f1aa4910 
  build.gradle 66c8205c8354048c398623edf7ba75e721376b01 
  examples/vagrant/provision-dev-cluster.sh 
2ce74f8a6dc663b62d254bc9d3a5c06cb412107f 
  src/main/python/apache/aurora/executor/BUILD 
c1c50dbcdcaa56f8ff970ceac59d5db537e1d048 
  src/main/python/apache/aurora/executor/aurora_executor.py 
8985aeb60e2c890113ea7d25039cdab5b7c9a19e 
  src/main/python/apache/aurora/executor/bin/BUILD 
93517150db96600c92ea25c0de29ec20736d72f7 
  src/main/python/apache/aurora/executor/bin/gc_executor_main.py 
bc20dad1e5434a98fb51ab052efa8ced760e74e0 
  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
aacc19a3bd272b08dee8a77d7a64490d0fcad3fa 
  src/main/python/apache/aurora/executor/common/BUILD 
0a4d35afcbfca8730d8bb7373795f9b3b6a74fd7 
  src/main/python/apache/aurora/executor/common/health_checker.py 
671f4970d4637b8cb68ec89e5dfe96a2f4cd077b 
  src/main/python/apache/aurora/executor/common/kill_manager.py 
6e482cfa7d2e081804fe6992527bae0ac5b65080 
  src/main/python/apache/aurora/executor/common/status_checker.py 
eda30e38d34adc5c78b828d0aea31f0721bf9b20 
  src/main/python/apache/aurora/executor/executor_base.py 
c632b77d972f76f3e260bb7413aa6100cda46607 
  src/main/python/apache/aurora/executor/gc_executor.py 
c45d5eb9a99e310e0716abd626ca34615f63b0ae 
  src/main/python/apache/aurora/executor/thermos_task_runner.py 
03a40e63573322f2d40e59a8ce84e9b9a1b90aa6 
  src/test/python/apache/aurora/executor/BUILD 
3152ec0c0e7dfaec5d756542a89243756b27725d 
  src/test/python/apache/aurora/executor/common/BUILD 
6316c7fc724c8e2245f5ce1a93c4a2daecd9f26b 
  src/test/python/apache/aurora/executor/common/test_executor_timeout.py 
PRE-CREATION 
  src/test/python/apache/aurora/executor/common/test_health_checker.py 
baeaba29e7679203d83f6ea81455973baf07f324 
  src/test/python/apache/aurora/executor/common/test_kill_manager.py 
PRE-CREATION 
  src/test/python/apache/aurora/executor/common/test_status_checker.py 
6ca4fd469bdc7cd21033ccdea460292463bc1cf8 
  src/test/python/apache/aurora/executor/test_executor_base.py PRE-CREATION 
  src/test/python/apache/aurora/executor/test_gc_executor.py 
0b2278a94667ca4d43e8a84649ed5312acacf7bb 
  src/test/python/apache/aurora/executor/test_status_manager.py PRE-CREATION 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
55747a19478572e39d1f00f799727d3c3db174c9 
  src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
f7af70fda8fef91018ff9d10dc1db6d43fd16ac7 

Diff: https://reviews.apache.org/r/25208/diff/


Testing
---

$ ./gradlew test

[tw-mbp13-jsmith aurora (yasumoto/mesos_0.20.0)]$ 
./build-support/python/checkstyle-check && ./pants 
./src/test/python/apache/aurora/executor:all
src.test.python.apache.aurora.executor.common.announcer 
.   SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox 
.   SUCCESS
src.test.python.apache.aurora.executor.common.health_checker
.   SUCCESS
src.test.python.apache.aurora.executor.common.status_checker
.   SUCCESS
src.test.python.apache.aurora.executor.common.task_info 
.   SUCCESS
src.test.python.apache.aurora.executor.executor_base
.   SUCCESS
src.test.python.apache.aurora.executor.executor_detector
.   SUCCESS
src.test.python.apache.aurora.executor.executor_vars
.   SUCCESS
src.test.python.apache.aurora.executor.gc_executor  
.   SUCCESS
src.test.python.apache.aurora.executor.status_manager   
.   SUCCESS
src.test.python.apache.aurora.executor.thermos_executor 
.   SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner  
.   SUCCESS


Thanks,

Joe Smith

Re: Review Request 25206: Fix aurora run in end to end tests.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25206/#review52121
---

Ship it!



src/test/sh/org/apache/aurora/e2e/test_run.sh
<https://reviews.apache.org/r/25206/#comment90865>

aurora job run?


- Joe Smith


On Aug. 29, 2014, 4:17 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25206/
> ---
> 
> (Updated Aug. 29, 2014, 4:17 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Tobias 
> Weingartner.
> 
> 
> Bugs: AURORA-676
> https://issues.apache.org/jira/browse/AURORA-676
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix aurora run in end to end tests.
> 
> 
> Diffs
> -
> 
>   examples/vagrant/upstart/mesos-slave.conf 
> e53d545f3a66383c12ed1e7de6b1eef2dbad1541 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> fa5568e5d34e1a8b2db78b4c9d009ed3d47ed04f 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
> 14a0b62c1b06179211d79f35a9c6df162c9a5999 
>   src/test/sh/org/apache/aurora/e2e/test_run.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25206/diff/
> 
> 
> Testing
> ---
> 
> $ bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> Unfortunately the v2 client end to end tests are currently broken (filed 
> https://issues.apache.org/jira/browse/AURORA-677), but I verified that the 
> test for aurora task run works in that script as well.
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 25206: Fix aurora run in end to end tests.

[Joe Smith]

> On Sept. 2, 2014, 6:47 p.m., Joe Smith wrote:
> > src/test/sh/org/apache/aurora/e2e/test_run.sh, line 23
> > <https://reviews.apache.org/r/25206/diff/1/?file=672554#file672554line23>
> >
> > aurora job run?

Kevin and Toby, can you two take a look at this ASAP? I'd like to have the e2e 
tests fixed before I ship https://reviews.apache.org/r/25208/


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25206/#review52121
---


On Aug. 29, 2014, 4:17 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25206/
> ---
> 
> (Updated Aug. 29, 2014, 4:17 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Tobias 
> Weingartner.
> 
> 
> Bugs: AURORA-676
> https://issues.apache.org/jira/browse/AURORA-676
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix aurora run in end to end tests.
> 
> 
> Diffs
> -
> 
>   examples/vagrant/upstart/mesos-slave.conf 
> e53d545f3a66383c12ed1e7de6b1eef2dbad1541 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> fa5568e5d34e1a8b2db78b4c9d009ed3d47ed04f 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
> 14a0b62c1b06179211d79f35a9c6df162c9a5999 
>   src/test/sh/org/apache/aurora/e2e/test_run.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25206/diff/
> 
> 
> Testing
> ---
> 
> $ bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> Unfortunately the v2 client end to end tests are currently broken (filed 
> https://issues.apache.org/jira/browse/AURORA-677), but I verified that the 
> test for aurora task run works in that script as well.
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 25208: Increment Mesos version to 0.20.0

[Joe Smith]

new HTTP connection (1): 192.168.33.7
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Detected RUNNING instance 2
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Instance 1 has been up and healthy for at least 10 seconds
 INFO] Examining instance: 3
 INFO] Adding instance: 3
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Added: 3
 INFO] Watching instances: [3]
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Detected RUNNING instance 3
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Instance 2 has been up and healthy for at least 10 seconds
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Instance 3 has been up and healthy for at least 10 seconds
 INFO] Update successful
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Response from scheduler: OK (message: None)
Connection to 127.0.0.1 closed.
+ echo '== Validating announce'
== Validating announce
+ validate_serverset /aurora/vagrant/test/http_example
+ local retcode=0
+ vagrant ssh -c 'env SERVERSET=/aurora/vagrant/test/http_example 
PEX_INTERPRETER=1 aurora 
/vagrant/src/test/sh/org/apache/aurora/e2e/validate_serverset.py'
Announced members: [u'member_01', u'member_02', 
u'member_00', u'member_03']
Announced members: [u'member_02', u'member_00', 
u'member_03']
Announced members: [u'member_02', u'member_00', 
u'member_03', u'member_04']
Exception in thread Thread-3 (most likely raised during interpreter shutdown):
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 810, in __bootstrap_inner
  File "/usr/lib/python2.7/threading.py", line 763, in run
  File 
"/home/vagrant/.pex/install/kazoo-1.3.1-py2-none-any.whl.08501d46b91fe837d206a7a4e416a61bcf205214/kazoo-1.3.1-py2-none-any.whl/kazoo/protocol/connection.py",
 line 465, in zk_loop
  File 
"/home/vagrant/.pex/install/kazoo-1.3.1-py2-none-any.whl.08501d46b91fe837d206a7a4e416a61bcf205214/kazoo-1.3.1-py2-none-any.whl/kazoo/retry.py",
 line 122, in __call__
  File 
"/home/vagrant/.pex/install/kazoo-1.3.1-py2-none-any.whl.08501d46b91fe837d206a7a4e416a61bcf205214/kazoo-1.3.1-py2-none-any.whl/kazoo/protocol/connection.py",
 line 484, in _connect_loop
  File 
"/home/vagrant/.pex/install/kazoo-1.3.1-py2-none-any.whl.08501d46b91fe837d206a7a4e416a61bcf205214/kazoo-1.3.1-py2-none-any.whl/kazoo/protocol/connection.py",
 line 534, in _connect_attempt
: 'NoneType' object has no attribute 'CLOSED'
Connection to 127.0.0.1 closed.
+ retcode=1
+ [[ 1 = 1 ]]
+ echo 'Validated announced job.'
Validated announced job.
+ return 0
++ vagrant ssh -c 'aurora run devcluster/vagrant/test/http_example '\''pwd'\'''
++ wc -l


Thanks,

Joe Smith

Re: Review Request 25206: Fix aurora run in end to end tests.

[Joe Smith]

> On Sept. 2, 2014, 6:47 p.m., Joe Smith wrote:
> > src/test/sh/org/apache/aurora/e2e/test_run.sh, line 23
> > <https://reviews.apache.org/r/25206/diff/1/?file=672554#file672554line23>
> >
> >     aurora job run?
> 
> Joe Smith wrote:
> Kevin and Toby, can you two take a look at this ASAP? I'd like to have 
> the e2e tests fixed before I ship https://reviews.apache.org/r/25208/
> 
> Joshua Cohen wrote:
> It defaults to 'aurora run', for the aurora1 client, but we pass in 
> 'aurora2 job run' from the test_end_to_end_v2.sh script. Are you saying to 
> switch the default (or maybe I should just remove the default altogether)?

I was saying switch the default so it's the new syntax


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25206/#review52121
---


On Aug. 29, 2014, 4:17 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25206/
> ---
> 
> (Updated Aug. 29, 2014, 4:17 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Tobias 
> Weingartner.
> 
> 
> Bugs: AURORA-676
> https://issues.apache.org/jira/browse/AURORA-676
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix aurora run in end to end tests.
> 
> 
> Diffs
> -
> 
>   examples/vagrant/upstart/mesos-slave.conf 
> e53d545f3a66383c12ed1e7de6b1eef2dbad1541 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> fa5568e5d34e1a8b2db78b4c9d009ed3d47ed04f 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
> 14a0b62c1b06179211d79f35a9c6df162c9a5999 
>   src/test/sh/org/apache/aurora/e2e/test_run.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25206/diff/
> 
> 
> Testing
> ---
> 
> $ bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> Unfortunately the v2 client end to end tests are currently broken (filed 
> https://issues.apache.org/jira/browse/AURORA-677), but I verified that the 
> test for aurora task run works in that script as well.
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 25208: Increment Mesos version to 0.20.0

[Joe Smith]

> On Sept. 3, 2014, 10:42 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/executor/thermos_task_runner.py, line 23
> > <https://reviews.apache.org/r/25208/diff/5/?file=674717#file674717line23>
> >
> > "mesos_pb2" looks a bit cryptic here. How about the approach you sued 
> > elsewhere:
> > "from mesos.interface.mesos_pb2 import TaskState"

I'd like to keep it this way, as we don't want to clobber Thermos' thrift's 
TaskState[1]

[1] 
https://github.com/apache/incubator-aurora/blob/master/src/main/thrift/org/apache/thermos/thermos_internal.thrift#L57


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25208/#review52198
-------


On Sept. 2, 2014, 9:06 p.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25208/
> ---
> 
> (Updated Sept. 2, 2014, 9:06 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Brian 
> Wickman.
> 
> 
> Bugs: AURORA-674
> https://issues.apache.org/jira/browse/AURORA-674
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> There's an API change when moving the python executor to 0.20.0, which should 
> deserve extra scrutiny. 
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD edc446e6d76d53a4c10a703cf6e84e29b8d42366 
>   Vagrantfile c8cb2d440330780c10eeff47d46cc1a3f1aa4910 
>   build.gradle 66c8205c8354048c398623edf7ba75e721376b01 
>   examples/vagrant/provision-dev-cluster.sh 
> 2ce74f8a6dc663b62d254bc9d3a5c06cb412107f 
>   src/main/python/apache/aurora/executor/BUILD 
> c1c50dbcdcaa56f8ff970ceac59d5db537e1d048 
>   src/main/python/apache/aurora/executor/aurora_executor.py 
> 8985aeb60e2c890113ea7d25039cdab5b7c9a19e 
>   src/main/python/apache/aurora/executor/bin/BUILD 
> 93517150db96600c92ea25c0de29ec20736d72f7 
>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py 
> bc20dad1e5434a98fb51ab052efa8ced760e74e0 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> aacc19a3bd272b08dee8a77d7a64490d0fcad3fa 
>   src/main/python/apache/aurora/executor/common/BUILD 
> 0a4d35afcbfca8730d8bb7373795f9b3b6a74fd7 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 671f4970d4637b8cb68ec89e5dfe96a2f4cd077b 
>   src/main/python/apache/aurora/executor/common/kill_manager.py 
> 6e482cfa7d2e081804fe6992527bae0ac5b65080 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> eda30e38d34adc5c78b828d0aea31f0721bf9b20 
>   src/main/python/apache/aurora/executor/executor_base.py 
> c632b77d972f76f3e260bb7413aa6100cda46607 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> c45d5eb9a99e310e0716abd626ca34615f63b0ae 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 03a40e63573322f2d40e59a8ce84e9b9a1b90aa6 
>   src/test/python/apache/aurora/executor/BUILD 
> 3152ec0c0e7dfaec5d756542a89243756b27725d 
>   src/test/python/apache/aurora/executor/common/BUILD 
> 6316c7fc724c8e2245f5ce1a93c4a2daecd9f26b 
>   src/test/python/apache/aurora/executor/common/test_executor_timeout.py 
> PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> baeaba29e7679203d83f6ea81455973baf07f324 
>   src/test/python/apache/aurora/executor/common/test_kill_manager.py 
> PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/test_status_checker.py 
> 6ca4fd469bdc7cd21033ccdea460292463bc1cf8 
>   src/test/python/apache/aurora/executor/test_executor_base.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/test_gc_executor.py 
> 0b2278a94667ca4d43e8a84649ed5312acacf7bb 
>   src/test/python/apache/aurora/executor/test_status_manager.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> 55747a19478572e39d1f00f799727d3c3db174c9 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
> f7af70fda8fef91018ff9d10dc1db6d43fd16ac7 
> 
> Diff: https://reviews.apache.org/r/25208/diff/
> 
> 
> Testing
> ---
> 
> $ ./gradlew test
> 
> [tw-mbp13-jsmith aurora (yasumoto/mesos_0.20.0)]$ 
> ./build-support/python/checkstyle-check && ./pants 
> ./src/test/python/apache/aurora/executor:all
> src.test.python.apache.aurora.executor.common.announcer   
>   .   SUCCESS
> src.test.python.apache.aurora.executor.common.directory_sandbox 

Re: Review Request 25208: Increment Mesos version to 0.20.0

[Joe Smith]

 [u'member_02', u'member_00', 
u'member_03', u'member_04']
Exception in thread Thread-3 (most likely raised during interpreter shutdown):
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 810, in __bootstrap_inner
  File "/usr/lib/python2.7/threading.py", line 763, in run
  File 
"/home/vagrant/.pex/install/kazoo-1.3.1-py2-none-any.whl.08501d46b91fe837d206a7a4e416a61bcf205214/kazoo-1.3.1-py2-none-any.whl/kazoo/protocol/connection.py",
 line 465, in zk_loop
  File 
"/home/vagrant/.pex/install/kazoo-1.3.1-py2-none-any.whl.08501d46b91fe837d206a7a4e416a61bcf205214/kazoo-1.3.1-py2-none-any.whl/kazoo/retry.py",
 line 122, in __call__
  File 
"/home/vagrant/.pex/install/kazoo-1.3.1-py2-none-any.whl.08501d46b91fe837d206a7a4e416a61bcf205214/kazoo-1.3.1-py2-none-any.whl/kazoo/protocol/connection.py",
 line 484, in _connect_loop
  File 
"/home/vagrant/.pex/install/kazoo-1.3.1-py2-none-any.whl.08501d46b91fe837d206a7a4e416a61bcf205214/kazoo-1.3.1-py2-none-any.whl/kazoo/protocol/connection.py",
 line 534, in _connect_attempt
: 'NoneType' object has no attribute 'CLOSED'
Connection to 127.0.0.1 closed.
+ retcode=1
+ [[ 1 = 1 ]]
+ echo 'Validated announced job.'
Validated announced job.
+ return 0
++ vagrant ssh -c 'aurora run devcluster/vagrant/test/http_example '\''pwd'\'''
++ wc -l


Thanks,

Joe Smith

Review Request 25337: Preserve executor HealthCheckerThread name

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/
---

Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian 
Wickman.


Bugs: AURORA-682
https://issues.apache.org/jira/browse/AURORA-682


Repository: aurora


Description
---

Preserve executor HealthCheckerThread name


Diffs
-

  src/main/python/apache/aurora/executor/common/health_checker.py 
603fff35b839c6f53d9379ec047d7d8135a1c65b 
  src/test/python/apache/aurora/executor/common/test_health_checker.py 
490d4c8b5c434f9d6f032d931e35c483b3a5b676 

Diff: https://reviews.apache.org/r/25337/diff/


Testing
---

[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants 
./src/test/python/apache/aurora/executor/common:health_checker
Build operating on top level addresses: 
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/executor/common/BUILD,
 health_checker)])
 test 
session starts 
=
platform darwin -- Python 2.7.8 -- py-1.4.23 -- pytest-2.6.1
plugins: cov, timeout
collected 4 items 

src/test/python/apache/aurora/executor/common/test_health_checker.py 

== 4 passed in 
1.54 seconds ==
src.test.python.apache.aurora.executor.common.health_checker
.   SUCCESS

Tests in vagrant image


Thanks,

Joe Smith

Re: Review Request 25346: Specify required vagrant version in Vagrantfile.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25346/#review52334
---

Ship it!


thanks!

- Joe Smith


On Sept. 4, 2014, 11:48 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25346/
> ---
> 
> (Updated Sept. 4, 2014, 11:48 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-683
> https://issues.apache.org/jira/browse/AURORA-683
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Specify required vagrant version in Vagrantfile.
> 
> 
> Diffs
> -
> 
>   Vagrantfile ea0b25294f0efeec745dc8612e4d7d02979079cc 
> 
> Diff: https://reviews.apache.org/r/25346/diff/
> 
> 
> Testing
> ---
> 
> vagant up
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 25337: Preserve executor HealthCheckerThread name

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/
---

(Updated Sept. 4, 2014, 5:24 p.m.)


Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian 
Wickman.


Bugs: AURORA-682
https://issues.apache.org/jira/browse/AURORA-682


Repository: aurora


Description
---

Preserve executor HealthCheckerThread name


Diffs (updated)
-

  src/main/python/apache/aurora/executor/common/health_checker.py 
603fff35b839c6f53d9379ec047d7d8135a1c65b 
  src/test/python/apache/aurora/executor/common/BUILD 
3229facf40070929adabb57fef667ab11bf3d1ec 
  src/test/python/apache/aurora/executor/common/fixtures.py PRE-CREATION 
  src/test/python/apache/aurora/executor/common/test_health_checker.py 
490d4c8b5c434f9d6f032d931e35c483b3a5b676 
  src/test/python/apache/aurora/executor/common/test_task_info.py 
344fd675c9a1ef9c88e39c16ac0f1dd50a9c1632 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
f6ca4dfd0fd262361709361c48c93799837e0a54 

Diff: https://reviews.apache.org/r/25337/diff/


Testing (updated)
---

###STILL RUNNING E2E TESTS

[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ 
./build-support/python/isort-run 
[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ 
./build-support/python/checkstyle-check 
[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants 
./src/test/python/apache/aurora/executor:all
src.test.python.apache.aurora.executor.common.announcer 
.   SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox 
.   SUCCESS
src.test.python.apache.aurora.executor.common.executor_timeout  
.   SUCCESS
src.test.python.apache.aurora.executor.common.health_checker
.   SUCCESS
src.test.python.apache.aurora.executor.common.status_checker
.   SUCCESS
src.test.python.apache.aurora.executor.common.task_info 
.   SUCCESS
src.test.python.apache.aurora.executor.executor_base
.   SUCCESS
src.test.python.apache.aurora.executor.executor_detector
.   SUCCESS
src.test.python.apache.aurora.executor.executor_vars
.   SUCCESS
src.test.python.apache.aurora.executor.gc_executor  
.   SUCCESS
src.test.python.apache.aurora.executor.status_manager   
.   SUCCESS
src.test.python.apache.aurora.executor.thermos_executor 
.   SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner  
.   SUCCESS


Thanks,

Joe Smith

Re: Review Request 25337: Preserve executor HealthCheckerThread name

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/
---

(Updated Sept. 4, 2014, 5:43 p.m.)


Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian 
Wickman.


Changes
---

Great catch Zameer!

[tw-172-25-20-192 aurora (yasumoto/fix_health_checker_name)]$ ./pants 
./src/test/python/apache/aurora/executor:thermos_executor
Build operating on top level addresses: 
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/executor/BUILD,
 thermos_executor)])

 test session starts 
=
platform darwin -- Python 2.7.8 -- py-1.4.23 -- pytest-2.6.1
plugins: cov, timeout
collected 15 items 

src/test/python/apache/aurora/executor/test_thermos_executor.py ...

=
 15 passed in 38.03 seconds 
=
src.test.python.apache.aurora.executor.thermos_executor 
.   SUCCESS


Bugs: AURORA-682
https://issues.apache.org/jira/browse/AURORA-682


Repository: aurora


Description
---

Preserve executor HealthCheckerThread name


Diffs (updated)
-

  src/main/python/apache/aurora/executor/common/health_checker.py 
603fff35b839c6f53d9379ec047d7d8135a1c65b 
  src/test/python/apache/aurora/executor/common/BUILD 
3229facf40070929adabb57fef667ab11bf3d1ec 
  src/test/python/apache/aurora/executor/common/fixtures.py PRE-CREATION 
  src/test/python/apache/aurora/executor/common/test_health_checker.py 
490d4c8b5c434f9d6f032d931e35c483b3a5b676 
  src/test/python/apache/aurora/executor/common/test_task_info.py 
344fd675c9a1ef9c88e39c16ac0f1dd50a9c1632 

Diff: https://reviews.apache.org/r/25337/diff/


Testing
---

###STILL RUNNING E2E TESTS

[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ 
./build-support/python/isort-run 
[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ 
./build-support/python/checkstyle-check 
[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants 
./src/test/python/apache/aurora/executor:all
src.test.python.apache.aurora.executor.common.announcer 
.   SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox 
.   SUCCESS
src.test.python.apache.aurora.executor.common.executor_timeout  
.   SUCCESS
src.test.python.apache.aurora.executor.common.health_checker
.   SUCCESS
src.test.python.apache.aurora.executor.common.status_checker
.   SUCCESS
src.test.python.apache.aurora.executor.common.task_info 
.   SUCCESS
src.test.python.apache.aurora.executor.executor_base
.   SUCCESS
src.test.python.apache.aurora.executor.executor_detector
.   SUCCESS
src.test.python.apache.aurora.executor.executor_vars
.   SUCCESS
src.test.python.apache.aurora.executor.gc_executor  
.   SUCCESS
src.test.python.apache.aurora.executor.status_manager   
.   SUCCESS
src.test.python.apache.aurora.executor.thermos_executor 
.   SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner  
.   SUCCESS


Thanks,

Joe Smith

Re: Review Request 25337: Preserve executor HealthCheckerThread name

[Joe Smith]

> On Sept. 4, 2014, 5:39 p.m., Zameer Manji wrote:
> > src/test/python/apache/aurora/executor/test_thermos_executor.py, line 395
> > <https://reviews.apache.org/r/25337/diff/2/?file=679158#file679158line395>
> >
> > I don't think this is supposed to be here.

whew, still pass.


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52387
-------


On Sept. 4, 2014, 5:43 p.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25337/
> ---
> 
> (Updated Sept. 4, 2014, 5:43 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian 
> Wickman.
> 
> 
> Bugs: AURORA-682
> https://issues.apache.org/jira/browse/AURORA-682
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Preserve executor HealthCheckerThread name
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 603fff35b839c6f53d9379ec047d7d8135a1c65b 
>   src/test/python/apache/aurora/executor/common/BUILD 
> 3229facf40070929adabb57fef667ab11bf3d1ec 
>   src/test/python/apache/aurora/executor/common/fixtures.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> 490d4c8b5c434f9d6f032d931e35c483b3a5b676 
>   src/test/python/apache/aurora/executor/common/test_task_info.py 
> 344fd675c9a1ef9c88e39c16ac0f1dd50a9c1632 
> 
> Diff: https://reviews.apache.org/r/25337/diff/
> 
> 
> Testing
> ---
> 
> ###STILL RUNNING E2E TESTS
> 
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ 
> ./build-support/python/isort-run 
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ 
> ./build-support/python/checkstyle-check 
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants 
> ./src/test/python/apache/aurora/executor:all
> src.test.python.apache.aurora.executor.common.announcer   
>   .   SUCCESS
> src.test.python.apache.aurora.executor.common.directory_sandbox   
>   .   SUCCESS
> src.test.python.apache.aurora.executor.common.executor_timeout
>   .   SUCCESS
> src.test.python.apache.aurora.executor.common.health_checker  
>   .   SUCCESS
> src.test.python.apache.aurora.executor.common.status_checker  
>   .   SUCCESS
> src.test.python.apache.aurora.executor.common.task_info   
>   .   SUCCESS
> src.test.python.apache.aurora.executor.executor_base  
>   .   SUCCESS
> src.test.python.apache.aurora.executor.executor_detector  
>   .   SUCCESS
> src.test.python.apache.aurora.executor.executor_vars  
>   .   SUCCESS
> src.test.python.apache.aurora.executor.gc_executor
>   .   SUCCESS
> src.test.python.apache.aurora.executor.status_manager         
>   .   SUCCESS
> src.test.python.apache.aurora.executor.thermos_executor   
>   .   SUCCESS
> src.test.python.apache.aurora.executor.thermos_task_runner
>   .   SUCCESS
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Re: Review Request 25337: Preserve executor HealthCheckerThread name

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/
---

(Updated Sept. 4, 2014, 6:20 p.m.)


Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian 
Wickman.


Changes
---

Wickman's suggestions


Bugs: AURORA-682
https://issues.apache.org/jira/browse/AURORA-682


Repository: aurora


Description
---

Preserve executor HealthCheckerThread name


Diffs (updated)
-

  src/main/python/apache/aurora/executor/common/health_checker.py 
603fff35b839c6f53d9379ec047d7d8135a1c65b 
  src/test/python/apache/aurora/executor/common/BUILD 
3229facf40070929adabb57fef667ab11bf3d1ec 
  src/test/python/apache/aurora/executor/common/fixtures.py PRE-CREATION 
  src/test/python/apache/aurora/executor/common/test_health_checker.py 
490d4c8b5c434f9d6f032d931e35c483b3a5b676 
  src/test/python/apache/aurora/executor/common/test_task_info.py 
344fd675c9a1ef9c88e39c16ac0f1dd50a9c1632 

Diff: https://reviews.apache.org/r/25337/diff/


Testing
---

###STILL RUNNING E2E TESTS

[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ 
./build-support/python/isort-run 
[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ 
./build-support/python/checkstyle-check 
[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants 
./src/test/python/apache/aurora/executor:all
src.test.python.apache.aurora.executor.common.announcer 
.   SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox 
.   SUCCESS
src.test.python.apache.aurora.executor.common.executor_timeout  
.   SUCCESS
src.test.python.apache.aurora.executor.common.health_checker
.   SUCCESS
src.test.python.apache.aurora.executor.common.status_checker
.   SUCCESS
src.test.python.apache.aurora.executor.common.task_info 
.   SUCCESS
src.test.python.apache.aurora.executor.executor_base
.   SUCCESS
src.test.python.apache.aurora.executor.executor_detector
.   SUCCESS
src.test.python.apache.aurora.executor.executor_vars
.   SUCCESS
src.test.python.apache.aurora.executor.gc_executor  
.   SUCCESS
src.test.python.apache.aurora.executor.status_manager   
.   SUCCESS
src.test.python.apache.aurora.executor.thermos_executor 
.   SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner  
.   SUCCESS


Thanks,

Joe Smith

Re: Review Request 25337: Preserve executor HealthCheckerThread name

[Joe Smith]

> On Sept. 4, 2014, 5:50 p.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/executor/common/health_checker.py, lines 
> > 131-132
> > <https://reviews.apache.org/r/25337/diff/2/?file=679153#file679153line131>
> >
> > make _healthy and _reason non-private

done


> On Sept. 4, 2014, 5:50 p.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/executor/common/health_checker.py, line 136
> > <https://reviews.apache.org/r/25337/diff/2/?file=679153#file679153line136>
> >
> > super(HealthChecker, self).start()

done


> On Sept. 4, 2014, 5:50 p.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/executor/common/health_checker.py, line 141
> > <https://reviews.apache.org/r/25337/diff/2/?file=679153#file679153line141>
> >
> > think you'll need an extra newline here for checkstyle to not complain

done


> On Sept. 4, 2014, 5:50 p.m., Brian Wickman wrote:
> > src/test/python/apache/aurora/executor/common/test_health_checker.py, line 
> > 188
> > <https://reviews.apache.org/r/25337/diff/2/?file=679156#file679156line188>
> >
> > the + is superfluous

done


> On Sept. 4, 2014, 5:50 p.m., Brian Wickman wrote:
> > src/test/python/apache/aurora/executor/test_thermos_executor.py, line 395
> > <https://reviews.apache.org/r/25337/diff/2/?file=679158#file679158line395>
> >
> > derp?

should be updated already, thanks


> On Sept. 4, 2014, 5:50 p.m., Brian Wickman wrote:
> > src/test/python/apache/aurora/executor/common/test_health_checker.py, line 
> > 171
> > <https://reviews.apache.org/r/25337/diff/2/?file=679156#file679156line171>
> >
> > all of these attributes should likely be public or read-only properties 
> > of private attributes

done


> On Sept. 4, 2014, 5:50 p.m., Brian Wickman wrote:
> > src/test/python/apache/aurora/executor/common/test_health_checker.py, line 
> > 158
> > <https://reviews.apache.org/r/25337/diff/2/?file=679156#file679156line158>
> >
> > please obtain an ephemeral port here instead.  who is to say that port 
> > 9001 is not running a service that accepts the health check protocol?  or 
> > at the very least, create a mock HttpSignaler

mocked


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52389
---


On Sept. 4, 2014, 6:20 p.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25337/
> ---
> 
> (Updated Sept. 4, 2014, 6:20 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian 
> Wickman.
> 
> 
> Bugs: AURORA-682
> https://issues.apache.org/jira/browse/AURORA-682
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Preserve executor HealthCheckerThread name
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 603fff35b839c6f53d9379ec047d7d8135a1c65b 
>   src/test/python/apache/aurora/executor/common/BUILD 
> 3229facf40070929adabb57fef667ab11bf3d1ec 
>   src/test/python/apache/aurora/executor/common/fixtures.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> 490d4c8b5c434f9d6f032d931e35c483b3a5b676 
>   src/test/python/apache/aurora/executor/common/test_task_info.py 
> 344fd675c9a1ef9c88e39c16ac0f1dd50a9c1632 
> 
> Diff: https://reviews.apache.org/r/25337/diff/
> 
> 
> Testing
> ---
> 
> ###STILL RUNNING E2E TESTS
> 
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ 
> ./build-support/python/isort-run 
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ 
> ./build-support/python/checkstyle-check 
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants 
> ./src/test/python/apache/aurora/executor:all
> src.test.python.apache.aurora.executor.common.announcer   
>   .   SUCCESS
> src.test.python.apache.aurora.executor.common.directory_sandbox   
>   .   SUCCESS
> src.test.python.apache.aurora.executor.common.executor_timeout
>   .   SUCCESS
> src.test.python.apache.aurora.executor.common.health_checker  
>   .   SUCCESS
> src.test.python.apache.aurora.executor.common.status_checker  
>   .   SUCCESS
> src.test.python.apache.aurora.ex

Re: Review Request 25337: Preserve executor HealthCheckerThread name

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/
---

(Updated Sept. 4, 2014, 8 p.m.)


Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian 
Wickman.


Changes
---

dRob's suggestions


Bugs: AURORA-682
https://issues.apache.org/jira/browse/AURORA-682


Repository: aurora


Description
---

Preserve executor HealthCheckerThread name


Diffs (updated)
-

  src/main/python/apache/aurora/executor/common/health_checker.py 
603fff35b839c6f53d9379ec047d7d8135a1c65b 
  src/test/python/apache/aurora/executor/common/BUILD 
3229facf40070929adabb57fef667ab11bf3d1ec 
  src/test/python/apache/aurora/executor/common/fixtures.py PRE-CREATION 
  src/test/python/apache/aurora/executor/common/test_health_checker.py 
490d4c8b5c434f9d6f032d931e35c483b3a5b676 
  src/test/python/apache/aurora/executor/common/test_task_info.py 
344fd675c9a1ef9c88e39c16ac0f1dd50a9c1632 

Diff: https://reviews.apache.org/r/25337/diff/


Testing
---

###STILL RUNNING E2E TESTS

[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ 
./build-support/python/isort-run 
[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ 
./build-support/python/checkstyle-check 
[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants 
./src/test/python/apache/aurora/executor:all
src.test.python.apache.aurora.executor.common.announcer 
.   SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox 
.   SUCCESS
src.test.python.apache.aurora.executor.common.executor_timeout  
.   SUCCESS
src.test.python.apache.aurora.executor.common.health_checker
.   SUCCESS
src.test.python.apache.aurora.executor.common.status_checker
.   SUCCESS
src.test.python.apache.aurora.executor.common.task_info 
.   SUCCESS
src.test.python.apache.aurora.executor.executor_base
.   SUCCESS
src.test.python.apache.aurora.executor.executor_detector
.   SUCCESS
src.test.python.apache.aurora.executor.executor_vars
.   SUCCESS
src.test.python.apache.aurora.executor.gc_executor  
.   SUCCESS
src.test.python.apache.aurora.executor.status_manager   
.   SUCCESS
src.test.python.apache.aurora.executor.thermos_executor 
.   SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner  
.   SUCCESS


Thanks,

Joe Smith

Re: Review Request 25337: Preserve executor HealthCheckerThread name

[Joe Smith]

> On Sept. 4, 2014, 6:23 p.m., David Robinson wrote:
> > src/test/python/apache/aurora/executor/common/test_health_checker.py, line 
> > 60
> > <https://reviews.apache.org/r/25337/diff/3/?file=679164#file679164line60>
> >
> > Why do you need to cast num_calls?

leftover from the previous test (I believe), thanks


> On Sept. 4, 2014, 6:23 p.m., David Robinson wrote:
> > src/main/python/apache/aurora/executor/common/health_checker.py, lines 28-30
> > <https://reviews.apache.org/r/25337/diff/3/?file=679161#file679161line28>
> >
> > Docstring, one variable per line so the style is consistent, and 
> > perhaps change the order so it's consistent with HealthChecker()? eg, s/ 
> > initial_interval_secs, interval_secs/ interval_secs, initial_interval_secs/ 
> > and update the caller to match.

Let me know if this is what you had in mind!


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52395
---


On Sept. 4, 2014, 8 p.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25337/
> ---
> 
> (Updated Sept. 4, 2014, 8 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian 
> Wickman.
> 
> 
> Bugs: AURORA-682
> https://issues.apache.org/jira/browse/AURORA-682
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Preserve executor HealthCheckerThread name
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 603fff35b839c6f53d9379ec047d7d8135a1c65b 
>   src/test/python/apache/aurora/executor/common/BUILD 
> 3229facf40070929adabb57fef667ab11bf3d1ec 
>   src/test/python/apache/aurora/executor/common/fixtures.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> 490d4c8b5c434f9d6f032d931e35c483b3a5b676 
>   src/test/python/apache/aurora/executor/common/test_task_info.py 
> 344fd675c9a1ef9c88e39c16ac0f1dd50a9c1632 
> 
> Diff: https://reviews.apache.org/r/25337/diff/
> 
> 
> Testing
> ---
> 
> ###STILL RUNNING E2E TESTS
> 
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ 
> ./build-support/python/isort-run 
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ 
> ./build-support/python/checkstyle-check 
> [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants 
> ./src/test/python/apache/aurora/executor:all
> src.test.python.apache.aurora.executor.common.announcer   
>   .   SUCCESS
> src.test.python.apache.aurora.executor.common.directory_sandbox   
>   .   SUCCESS
> src.test.python.apache.aurora.executor.common.executor_timeout
>   .   SUCCESS
> src.test.python.apache.aurora.executor.common.health_checker  
>   .   SUCCESS
> src.test.python.apache.aurora.executor.common.status_checker  
>   .   SUCCESS
> src.test.python.apache.aurora.executor.common.task_info   
>   .   SUCCESS
> src.test.python.apache.aurora.executor.executor_base  
>   .   SUCCESS
> src.test.python.apache.aurora.executor.executor_detector  
>   .   SUCCESS
> src.test.python.apache.aurora.executor.executor_vars  
>   .   SUCCESS
> src.test.python.apache.aurora.executor.gc_executor
>   .   SUCCESS
> src.test.python.apache.aurora.executor.status_manager 
>   .   SUCCESS
> src.test.python.apache.aurora.executor.thermos_executor   
>   .   SUCCESS
> src.test.python.apache.aurora.executor.thermos_task_runner
>   .   SUCCESS
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Re: Review Request 25337: Preserve executor HealthCheckerThread name

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/
---

(Updated Sept. 5, 2014, 9:32 a.m.)


Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian 
Wickman.


Changes
---

Checkstyle


Bugs: AURORA-682
https://issues.apache.org/jira/browse/AURORA-682


Repository: aurora


Description
---

Preserve executor HealthCheckerThread name


Diffs (updated)
-

  src/main/python/apache/aurora/executor/common/health_checker.py 
603fff35b839c6f53d9379ec047d7d8135a1c65b 
  src/test/python/apache/aurora/executor/common/BUILD 
3229facf40070929adabb57fef667ab11bf3d1ec 
  src/test/python/apache/aurora/executor/common/fixtures.py PRE-CREATION 
  src/test/python/apache/aurora/executor/common/test_health_checker.py 
490d4c8b5c434f9d6f032d931e35c483b3a5b676 
  src/test/python/apache/aurora/executor/common/test_task_info.py 
344fd675c9a1ef9c88e39c16ac0f1dd50a9c1632 

Diff: https://reviews.apache.org/r/25337/diff/


Testing
---

###STILL RUNNING E2E TESTS

[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ 
./build-support/python/isort-run 
[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ 
./build-support/python/checkstyle-check 
[tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants 
./src/test/python/apache/aurora/executor:all
src.test.python.apache.aurora.executor.common.announcer 
.   SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox 
.   SUCCESS
src.test.python.apache.aurora.executor.common.executor_timeout  
.   SUCCESS
src.test.python.apache.aurora.executor.common.health_checker
.   SUCCESS
src.test.python.apache.aurora.executor.common.status_checker
.   SUCCESS
src.test.python.apache.aurora.executor.common.task_info 
.   SUCCESS
src.test.python.apache.aurora.executor.executor_base
.   SUCCESS
src.test.python.apache.aurora.executor.executor_detector
.   SUCCESS
src.test.python.apache.aurora.executor.executor_vars
.   SUCCESS
src.test.python.apache.aurora.executor.gc_executor  
.   SUCCESS
src.test.python.apache.aurora.executor.status_manager   
.   SUCCESS
src.test.python.apache.aurora.executor.thermos_executor 
.   SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner  
.   SUCCESS


Thanks,

Joe Smith

Re: Review Request 25466: Upgrade Aurora to psutil 2.1.1

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25466/#review52674
---

Ship it!


awesome

- Joe Smith


On Sept. 8, 2014, 7:13 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25466/
> ---
> 
> (Updated Sept. 8, 2014, 7:13 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Kevin Sweeney.
> 
> 
> Bugs: AURORA-412
> https://issues.apache.org/jira/browse/AURORA-412
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade Aurora to psutil 2.1.1
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 5e96b91aa11567f51ed599c9d585f3af4e4e7127 
>   src/main/python/apache/aurora/executor/executor_vars.py 
> 7665a77ca13bbbc337e345356b70f12357692f3d 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> 572c106038602b795a5b6bf08b2b85cf4b6bfec6 
>   src/main/python/apache/thermos/core/helper.py 
> 9e4a8fb70df984d175129cb49025b3c222a64679 
>   src/main/python/apache/thermos/monitoring/process_collector_psutil.py 
> 298459bab01d2c01bef1d69c1150ff2d5737ebbf 
>   src/test/python/apache/thermos/core/test_helper.py 
> 58096119e1b412afa36a09da5759c5223a5b5d75 
> 
> Diff: https://reviews.apache.org/r/25466/diff/
> 
> 
> Testing
> ---
> 
> Ran tests on OS X but not yet on Linux.  There is adequate coverage.
> 
> ==edit, Linux test output==
> 
> src.test.python.apache.thermos.bin.test_thermos   
>   .   SUCCESS
> src.test.python.apache.thermos.common.test_pathspec   
>   .   SUCCESS
> src.test.python.apache.thermos.common.test_planner
>   .   SUCCESS
> src.test.python.apache.thermos.common.test_task_planner   
>   .   SUCCESS
> src.test.python.apache.thermos.config.test_schema 
>   .   SUCCESS
> src.test.python.apache.thermos.core.test_angry
>   .   SUCCESS
> src.test.python.apache.thermos.core.test_ephemerals   
>   .   SUCCESS
> src.test.python.apache.thermos.core.test_failing_runner   
>   .   SUCCESS
> src.test.python.apache.thermos.core.test_failure_limit
>   .   SUCCESS
> src.test.python.apache.thermos.core.test_finalization 
>   .   SUCCESS
> src.test.python.apache.thermos.core.test_helper   
>   .   SUCCESS
> src.test.python.apache.thermos.core.test_process  
>   .   SUCCESS
> src.test.python.apache.thermos.core.test_runner_integration   
>   .   SUCCESS
> src.test.python.apache.thermos.core.test_staged_kill  
>   .   SUCCESS
> src.test.python.apache.thermos.monitoring.test_disk   
>   .   SUCCESS
> src.test.python.apache.aurora.admin.admin_util
>   .   SUCCESS
> src.test.python.apache.aurora.admin.host_maintenance  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.api  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.disambiguator
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher 
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.mux  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.quota_check  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.restarter
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client 
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.sla  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.updater  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.updater_util 
>   .   SUCCESS
> src.test.python.apache.aurora.client.binding_helper   
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.api  

Re: Review Request 25519: Adding "get_scheduler" admin command.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25519/#review52945
---


can you also add e2e test coverage?

- Joe Smith


On Sept. 10, 2014, 12:53 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25519/
> ---
> 
> (Updated Sept. 10, 2014, 12:53 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Zameer Manji.
> 
> 
> Bugs: AURORA-692
> https://issues.apache.org/jira/browse/AURORA-692
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding "get_scheduler" admin command.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 0ba07611b1a367f7157b91a1d4b65b1af176 
>   src/main/python/apache/aurora/client/commands/admin.py 
> bc9a9eee9a187f2c895e70a093871f0b795931c4 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 630f662ad2ffb8d192299d98c612ad4892161081 
>   src/test/python/apache/aurora/client/commands/test_admin.py 
> 94e736fb80c3fd7f103437c24f33d7c4451a6969 
>   src/test/python/apache/aurora/client/commands/util.py 
> 21b8830df5a3eccc7d36067369fc16cc5fd9de2a 
> 
> Diff: https://reviews.apache.org/r/25519/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 25519: Adding "get_scheduler" admin command.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25519/#review52968
---

Ship it!


Ship It!

- Joe Smith


On Sept. 10, 2014, 3:43 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25519/
> ---
> 
> (Updated Sept. 10, 2014, 3:43 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Zameer Manji.
> 
> 
> Bugs: AURORA-692
> https://issues.apache.org/jira/browse/AURORA-692
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding "get_scheduler" admin command.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 0ba07611b1a367f7157b91a1d4b65b1af176 
>   src/main/python/apache/aurora/client/commands/admin.py 
> bc9a9eee9a187f2c895e70a093871f0b795931c4 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 630f662ad2ffb8d192299d98c612ad4892161081 
>   src/test/python/apache/aurora/client/commands/test_admin.py 
> 94e736fb80c3fd7f103437c24f33d7c4451a6969 
>   src/test/python/apache/aurora/client/commands/util.py 
> 21b8830df5a3eccc7d36067369fc16cc5fd9de2a 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 989801cfcbd19109ac140b01cd3024d70c78c829 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
> 0965b5c8cb89eb36c6e15108c702c39dd68268be 
> 
> Diff: https://reviews.apache.org/r/25519/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 25582: Fix error in client "task ssh" command when the job isn't found.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25582/#review53184
---



src/test/python/apache/aurora/client/cli/test_task_run.py
<https://reviews.apache.org/r/25582/#comment92646>

test_ssh_job_not_found



src/test/python/apache/aurora/client/cli/test_task_run.py
<https://reviews.apache.org/r/25582/#comment92647>

"Test the ssh command for proper behavior when no tasks are found within a 
job" or something, I think


- Joe Smith


On Sept. 12, 2014, 7:34 a.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25582/
> ---
> 
> (Updated Sept. 12, 2014, 7:34 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Bugs: aurora-706
> https://issues.apache.org/jira/browse/aurora-706
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix error in client "task ssh" command when the job isn't found.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/task.py 
> 91175facdc8c9fd59ab66781f86ee8b5940a 
>   src/main/python/apache/aurora/client/commands/ssh.py 
> 37a90089b72b86c82466f1819e7881a36bb2f214 
>   src/test/python/apache/aurora/client/cli/test_task_run.py 
> 8d9ef0543c1ab514d6f039ba63a1d417a4a90a1b 
>   src/test/python/apache/aurora/client/commands/test_ssh.py 
> 4070b710b005c91fe08dd7906cd93bf3a8cdba9e 
> 
> Diff: https://reviews.apache.org/r/25582/diff/
> 
> 
> Testing
> ---
> 
> Added new tests to catch this case;
> Ran all client unit tests, all tests pass.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 25582: Fix error in client "task ssh" command when the job isn't found.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25582/#review53189
---

Ship it!


Ship It!

- Joe Smith


On Sept. 12, 2014, 10:17 a.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25582/
> ---
> 
> (Updated Sept. 12, 2014, 10:17 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Bugs: aurora-706
> https://issues.apache.org/jira/browse/aurora-706
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix error in client "task ssh" command when the job isn't found.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/task.py 
> 91175facdc8c9fd59ab66781f86ee8b5940a 
>   src/main/python/apache/aurora/client/commands/ssh.py 
> 37a90089b72b86c82466f1819e7881a36bb2f214 
>   src/test/python/apache/aurora/client/cli/test_task_run.py 
> 8d9ef0543c1ab514d6f039ba63a1d417a4a90a1b 
>   src/test/python/apache/aurora/client/commands/test_ssh.py 
> 4070b710b005c91fe08dd7906cd93bf3a8cdba9e 
> 
> Diff: https://reviews.apache.org/r/25582/diff/
> 
> 
> Testing
> ---
> 
> Added new tests to catch this case;
> Ran all client unit tests, all tests pass.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 25582: Fix error in client "task ssh" command when the job isn't found.

[Joe Smith]

> On Sept. 12, 2014, 10:09 a.m., Joe Smith wrote:
> > src/test/python/apache/aurora/client/cli/test_task_run.py, line 228
> > <https://reviews.apache.org/r/25582/diff/1/?file=687672#file687672line228>
> >
> > "Test the ssh command for proper behavior when no tasks are found 
> > within a job" or something, I think
> 
> Joshua Cohen wrote:
> I'd go so far as to suggest that docstrings on test methods are probably 
> not necessary. This exemplifies why, they just get copied/pasted from other 
> tests and end up not accurately describing what each test does. I'd vote for 
> descriptive test case names and do away with docstrings entirely.
> 
> David McLaughlin wrote:
> +1

Yeah, that's probably the right move overall, though I'm okay with docstrings 
for test methods if they give a bit more clarification as opposed to increasing 
an already-long test-method name.


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25582/#review53184
---


On Sept. 12, 2014, 10:17 a.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25582/
> ---
> 
> (Updated Sept. 12, 2014, 10:17 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Bugs: aurora-706
> https://issues.apache.org/jira/browse/aurora-706
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix error in client "task ssh" command when the job isn't found.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/task.py 
> 91175facdc8c9fd59ab66781f86ee8b5940a 
>   src/main/python/apache/aurora/client/commands/ssh.py 
> 37a90089b72b86c82466f1819e7881a36bb2f214 
>   src/test/python/apache/aurora/client/cli/test_task_run.py 
> 8d9ef0543c1ab514d6f039ba63a1d417a4a90a1b 
>   src/test/python/apache/aurora/client/commands/test_ssh.py 
> 4070b710b005c91fe08dd7906cd93bf3a8cdba9e 
> 
> Diff: https://reviews.apache.org/r/25582/diff/
> 
> 
> Testing
> ---
> 
> Added new tests to catch this case;
> Ran all client unit tests, all tests pass.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 25543: Update to pants 0.0.23.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25543/#review53242
---

Ship it!


awesome- thanks!

- Joe Smith


On Sept. 11, 2014, 9:13 a.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25543/
> ---
> 
> (Updated Sept. 11, 2014, 9:13 a.m.)
> 
> 
> Review request for Aurora, Joe Smith and Brian Wickman.
> 
> 
> Bugs: aurora-695
> https://issues.apache.org/jira/browse/aurora-695
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> - Update build files for the new syntax, which no longer requires
>   'pants(...)' around target names.
> - Remove no-longer-supported "timeout" from python_tests.
> 
> 
> Diffs
> -
> 
>   pants 4f9c351888afa1a779415730240093c3dee25dfb 
>   src/main/python/apache/aurora/admin/BUILD 
> 7a100d1a4a74aae034082f34db051c9cc31f8540 
>   src/main/python/apache/aurora/client/BUILD 
> bf196bf86b36db0d72f8e096260c9a900f74d07c 
>   src/main/python/apache/aurora/client/api/BUILD 
> 70ad38e34f14c6d54b71c8f4b2138f085658110e 
>   src/main/python/apache/aurora/client/bin/BUILD 
> 43d747956df0611b0880f64df9955d5f5806901c 
>   src/main/python/apache/aurora/client/cli/BUILD 
> ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 
>   src/main/python/apache/aurora/client/commands/BUILD 
> cc16923909a7b26b0f3ac0b47bb37dafdbbf502e 
>   src/main/python/apache/aurora/client/hooks/BUILD 
> 9471c4cba5175296030747301e246a65a39aa203 
>   src/main/python/apache/aurora/common/BUILD 
> b879b15127d6691b35880074fd0ceacd866a61ed 
>   src/main/python/apache/aurora/common/auth/BUILD 
> 7e96cb2258711b2e2925d18ad9435fa986e86bca 
>   src/main/python/apache/aurora/config/BUILD 
> 4f8fad80114ddabac8b25f70bba00119228ec675 
>   src/main/python/apache/aurora/config/schema/BUILD 
> 69d60aebd2a9aa353497406ae578a9997323b07e 
>   src/main/python/apache/aurora/executor/BUILD 
> 1ad8f82cdce85cf228c53e088171918e36ed536d 
>   src/main/python/apache/aurora/executor/bin/BUILD 
> aeb8aee6f50a0d89714626e933699c0a13b363d9 
>   src/main/python/apache/aurora/executor/common/BUILD 
> 335ebc4809096c5f128846cd846d33910a777968 
>   src/main/python/apache/thermos/BUILD 
> 0dc035f759dd9949997f0c979b3556a350cf8df7 
>   src/main/python/apache/thermos/bin/BUILD 
> 669f9930a3590184dc0f8b5c15c36168e715eb03 
>   src/main/python/apache/thermos/common/BUILD 
> 6015f9e9a23f71bf6dede1f4698fe63dbb4dcfaa 
>   src/main/python/apache/thermos/config/BUILD 
> 0531f92ea569ffe36817b645a17fab7a712e5897 
>   src/main/python/apache/thermos/core/BUILD 
> 0d1d339d55ee6a569297614ac734661e5caf7ea4 
>   src/main/python/apache/thermos/monitoring/BUILD 
> 79da0d5cef9436d4a3d83075910decfc93e422a6 
>   src/main/python/apache/thermos/observer/BUILD 
> 49b844ffc1b1d5911fc28d14294d088c3d0b6e4b 
>   src/main/python/apache/thermos/observer/bin/BUILD 
> 044ca66b18282daf17a4198ff369d954e14c9b6d 
>   src/main/python/apache/thermos/observer/http/BUILD 
> 901ad9c61e4dd1c61f5fbf4467becb8c881a64ed 
>   src/main/python/apache/thermos/testing/BUILD 
> dc328a63788381307576b5a43ecdc704bb764473 
>   src/main/thrift/org/apache/aurora/gen/BUILD 
> 947504ec1f9582496952b23e66d7f5f20a168ce7 
>   src/test/python/BUILD f01efff2e4982a475221b5739dfe1e8fd1a41d92 
>   src/test/python/apache/aurora/BUILD 
> 6555b984a713ef786aef5688b206ae9d8017c48d 
>   src/test/python/apache/aurora/admin/BUILD 
> 5e170d6c15a95e2511b69e18a255d7364c2e7a4d 
>   src/test/python/apache/aurora/client/BUILD 
> 831a72d39b27ca2aca466a38914bbf40ff94 
>   src/test/python/apache/aurora/client/api/BUILD 
> b4f08c6192e6bf6b38665197e98db7235751ae86 
>   src/test/python/apache/aurora/client/cli/BUILD 
> e1f9ebf96774b8f5c75de8570c6ba87d953ab649 
>   src/test/python/apache/aurora/client/commands/BUILD 
> 17933dedfa08c9d12c369087bf801e7c35cdde9b 
>   src/test/python/apache/aurora/client/hooks/BUILD 
> f7856a2d5dc7e5d1edc480f64d5db97d88c71b70 
>   src/test/python/apache/aurora/common/BUILD 
> e949ba8859d5567c62623bec9d5ba86a8463fbaa 
>   src/test/python/apache/aurora/config/BUILD 
> 37bbd27e13a2a3589faff7285f04e3c44ca57eeb 
>   src/test/python/apache/aurora/executor/BUILD 
> 4d43e256ad131223cc1ac36a406d42a979a8a2dd 
>   src/test/python/apache/aurora/executor/common/BUILD 
> 7d8934046b56ac2c0c16440cfc571dc370767a14 
>   src/test/python/apache/thermos/BUILD 
> cb93a4622e33ef96855b89a7c138f42033368950 
>   src/test/python/apache/thermos/bin/BUILD 

Re: Review Request 25175: Fix possible deadlock in TaskRunner.collect_updates.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25175/#review53367
---

Ship it!


Ship It!

- Joe Smith


On Sept. 15, 2014, 11:08 a.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25175/
> ---
> 
> (Updated Sept. 15, 2014, 11:08 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-669
> https://issues.apache.org/jira/browse/AURORA-669
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix possible deadlock in TaskRunner.collect_updates.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/thermos/core/runner.py 
> ec4cdb788a1e24a590b262ba8dbd044cf31fc198 
> 
> Diff: https://reviews.apache.org/r/25175/diff/
> 
> 
> Testing
> ---
> 
> Filed https://issues.apache.org/jira/browse/AURORA-709 to track adding test 
> coverage for this.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 25667: Removing host_drain delay.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25667/#review53419
---

Ship it!


Ship It!

- Joe Smith


On Sept. 15, 2014, 3:04 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25667/
> ---
> 
> (Updated Sept. 15, 2014, 3:04 p.m.)
> 
> 
> Review request for Aurora and Joe Smith.
> 
> 
> Bugs: AURORA-714
> https://issues.apache.org/jira/browse/AURORA-714
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Removing host_drain delay.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> 29745a37279cf471c8effd86d25e05dff26547b0 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 
> f2c5b7fafd8296441b5ebd6b1e5d6106554e7bd4 
> 
> Diff: https://reviews.apache.org/r/25667/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 25673: Fixing broken test.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25673/#review53427
---

Ship it!


Ship It!

- Joe Smith


On Sept. 15, 2014, 3:56 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25673/
> ---
> 
> (Updated Sept. 15, 2014, 3:56 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Apparently ./pants src/test/python:all does not stop anymore when a test 
> failure is encountered and my console window is too small to notice the 
> failure up top. 
> 
> 
> Diffs
> -
> 
>   src/test/python/apache/aurora/client/commands/test_maintenance.py 
> 2151f02828f6a349d93dbc9ad1bf522891172e34 
> 
> Diff: https://reviews.apache.org/r/25673/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python/apache/aurora/client/commands::
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 26015: Skip past irrelevant jobs when running cron show command.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26015/#review54497
---

Ship it!


Thanks for the test case!


src/main/python/apache/aurora/client/cli/cron.py
<https://reviews.apache.org/r/26015/#comment94681>

Mainly confirming for myself- but this follows the expected behavior- if a 
job is the right name, but not a cron: INVALID_PARAMETER. If there are no jobs 
matching the name: INVALID_PARAMETER.


- Joe Smith


On Sept. 24, 2014, 7:03 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26015/
> ---
> 
> (Updated Sept. 24, 2014, 7:03 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-753
> https://issues.apache.org/jira/browse/AURORA-753
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Skip past irrelevant jobs when running cron show command.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/cron.py 
> 3416c8e1932056725880f2007b60d77112759428 
>   src/test/python/apache/aurora/client/cli/test_cron.py 
> f488432cd68cc68fab8fce968e8605625ea3f56a 
> 
> Diff: https://reviews.apache.org/r/26015/diff/
> 
> 
> Testing
> ---
> 
> Reproduced issue in a test case, now passes:
> ./pants src/test/python/apache/aurora/client/cli:cron
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 26044: Run python style checks in jenkins.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26044/#review54570
---

Ship it!


Ship It!

- Joe Smith


On Sept. 25, 2014, 11:09 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26044/
> ---
> 
> (Updated Sept. 25, 2014, 11:09 a.m.)
> 
> 
> Review request for Aurora and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Run python style checks in jenkins.
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/build.sh 850e08b1b82f368d452e3928eed8cbaadb418449 
> 
> Diff: https://reviews.apache.org/r/26044/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 25970: Adding support for retryable storage errors.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25970/#review54573
---



src/test/python/apache/aurora/client/api/test_scheduler_client.py
<https://reviews.apache.org/r/25970/#comment94757>

Isn't this not needed if you're specifying a side_effect?


- Joe Smith


On Sept. 25, 2014, 11:34 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25970/
> ---
> 
> (Updated Sept. 25, 2014, 11:34 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-187
> https://issues.apache.org/jira/browse/AURORA-187
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding a new ERROR_RETRYABLE thrift response type to enable response-aware 
> retrying in scheduler_client. 
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java
>  671dbd1b14e759f02f655909857099368255f214 
>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
> 775564e1de0bec7fcfd96ea5ee3ee4948567e58f 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 
> a21ab901d86f74d5bc22bfffc09029c99d3a398f 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> ec632516655bbca4782e01310518843ce8aca27e 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 2376a5e530b12fbbebb4cfc7555656ae07795518 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  21e8a8ba5c47f549133ea339899bf0e5097ccbb9 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 527448f882c12fe9bb51ce2a0a4c330188838282 
> 
> Diff: https://reviews.apache.org/r/25970/diff/
> 
> 
> Testing
> ---
> 
> gradle -Pq build
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 26089: Renaming update to beta-update in client v2

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26089/#review54704
---

Ship it!


Ship It!

- Joe Smith


On Sept. 26, 2014, 10:53 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26089/
> ---
> 
> (Updated Sept. 26, 2014, 10:53 a.m.)
> 
> 
> Review request for Aurora, Joe Smith and Bill Farner.
> 
> 
> Bugs: AURORA-757
> https://issues.apache.org/jira/browse/AURORA-757
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Renaming update to beta-update in client v2
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/update.py 
> c6cb98fe6aa42310090167796c971856d3dc177f 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 4fb1623e497b9741ae2a350deb20030dd4036506 
> 
> Diff: https://reviews.apache.org/r/26089/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/tests/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 26137: Fix help for new update command.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26137/#review54953
---



src/main/python/apache/aurora/client/cli/update.py
<https://reviews.apache.org/r/26137/#comment95276>

Could you update a test case to catch accessing these as properties to 
catch accidental regressions?


- Joe Smith


On Sept. 29, 2014, 8:05 a.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26137/
> ---
> 
> (Updated Sept. 29, 2014, 8:05 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Bugs: aurora-748
> https://issues.apache.org/jira/browse/aurora-748
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix help for new update command.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/update.py 
> b4dd792dc12f19424c620f4d91748113e272f0c9 
> 
> Diff: https://reviews.apache.org/r/26137/diff/
> 
> 
> Testing
> ---
> 
> manual testing.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 26233: Add a monitoring guide.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26233/#review55091
---

Ship it!


Wow.

- Joe Smith


On Oct. 1, 2014, 10:27 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26233/
> ---
> 
> (Updated Oct. 1, 2014, 10:27 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-634
> https://issues.apache.org/jira/browse/AURORA-634
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a monitoring guide.
> 
> 
> Diffs
> -
> 
>   docs/deploying-aurora-scheduler.md 9b6d526b22f2e39dfe95f494720f550d0b67d176 
>   docs/monitoring.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26233/diff/
> 
> 
> Testing
> ---
> 
> Rendered here: 
> https://github.com/wfarner/incubator-aurora/blob/wfarner/monitoring_guide/docs/monitoring.md
> 
> I'm not terribly happy about the organization at the bottom, specifically the 
> wrapping of rate ratio. Happy to rework if anybody has a suggestion.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 26137: Fix help for new update command.

[Joe Smith]

> On Sept. 29, 2014, 11:32 p.m., Joe Smith wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 45
> > <https://reviews.apache.org/r/26137/diff/1/?file=708198#file708198line45>
> >
> > Could you update a test case to catch accessing these as properties to 
> > catch accidental regressions?
> 
> David McLaughlin wrote:
> Piggy backing this issue to add that my ship it is pending a test for 
> this command at least?
> 
> Mark Chu-Carroll wrote:
> I don't know of any way to write a single test that would always catch 
> this.

Rebased off your diff:

[tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ git diff
diff --git a/src/main/python/apache/aurora/client/cli/update.py 
b/src/main/python/apache/aurora/client/cli/update.py
index 41475a7..ef07a11 100644
--- a/src/main/python/apache/aurora/client/cli/update.py
+++ b/src/main/python/apache/aurora/client/cli/update.py
@@ -42,7 +42,6 @@ class StartUpdate(Verb):
   INSTANCES_SPEC_ARGUMENT, CONFIG_ARGUMENT
 ]
 
-  @property
   def help(self):
 return textwrap.dedent("""\
 Start a scheduler-driven rolling upgrade on a running job, using the 
update
diff --git a/src/test/python/apache/aurora/client/cli/test_update.py 
b/src/test/python/apache/aurora/client/cli/test_update.py
index eeed774..1a38ffe 100644
--- a/src/test/python/apache/aurora/client/cli/test_update.py
+++ b/src/test/python/apache/aurora/client/cli/test_update.py
@@ -23,6 +23,7 @@ from apache.aurora.client.api.quota_check import QuotaCheck
 from apache.aurora.client.api.scheduler_mux import SchedulerMux
 from apache.aurora.client.cli import EXIT_INVALID_CONFIGURATION, EXIT_OK
 from apache.aurora.client.cli.client import AuroraCommandLine
+from apache.aurora.client.cli.update import StartUpdate
 from apache.aurora.client.cli.util import AuroraClientCommandTest, 
FakeAuroraCommandContext, IOMock
 from apache.aurora.config import AuroraConfig
 
@@ -301,6 +302,10 @@ class TestUpdateCommand(AuroraClientCommandTest):
   'Update completed successfully']
   assert mock_err.get() == []
 
+  def test_update_start_help(self):
+start = StartUpdate()
+assert 'Start a scheduler-driven rolling' in start.help
+
   @classmethod
   def assert_correct_addinstance_calls(cls, api):
 assert api.addInstances.call_count == 20
[tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ ./pants 
./src/test/python/apache/aurora/client/cli:job
Build operating on top level addresses: 
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD,
 job)])

 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 61 items 

src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py ..
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py 
src/test/python/apache/aurora/client/cli/test_open.py .
src/test/python/apache/aurora/client/cli/test_restart.py 
src/test/python/apache/aurora/client/cli/test_status.py ...
src/test/python/apache/aurora/client/cli/test_update.py ..F...

==
 FAILURES 
==
__
 TestUpdateCommand.test_update_start_help 
__

self = 

def test_update_start_help(self):
  start = StartUpdate()
> assert 'Start a scheduler-driven rolling' in start.help
E TypeError: argument of type 'instancemethod' is not iterable

src/test/python/apache/aurora/client/cli/test_update.py:307: TypeError

 1 failed, 60 passed in 6.07 seconds 
=
src.test.python.apache.aurora.client.cli.job
.   FA

Re: Review Request 26308: Fix exit condition for RPC loop, fix test_status_api_failure test.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26308/#review55319
---



src/test/python/apache/aurora/client/cli/test_api_from_cli.py
<https://reviews.apache.org/r/26308/#comment95691>

you need to set a spec here

Mock(SchedulerClient)


- Joe Smith


On Oct. 2, 2014, 7:38 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26308/
> ---
> 
> (Updated Oct. 2, 2014, 7:38 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fixes two problems:
> 
> - mocking was incorrect in `test_status_api_failure`.  Turns out that Mock 
> objects were being passed around and somehow resulted in the test case 
> passing.
> - use of `threading.Event()` was broken in scheduler_client.py.  I don't 
> think it's possible to enter those branches.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> b400cb2dbdb35077fc2c4a6e161c2959a9217317 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 1cbfbf86e903d890baac7d34461109f9beaff442 
>   src/test/python/apache/aurora/client/cli/test_api_from_cli.py 
> 78f21d2f20cf71fa2dfe0614885d44d2948decd2 
> 
> Diff: https://reviews.apache.org/r/26308/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all -vxs
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 25972: Make thermos more cognizant of user deletions

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25972/#review55371
---


Looks great- thanks!


src/test/python/apache/thermos/core/test_helper.py
<https://reviews.apache.org/r/25972/#comment95731>

from psutil._common import puids


- Joe Smith


On Oct. 3, 2014, 10:55 a.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25972/
> ---
> 
> (Updated Oct. 3, 2014, 10:55 a.m.)
> 
> 
> Review request for Aurora, Joe Smith and Kevin Sweeney.
> 
> 
> Bugs: AURORA-175
> https://issues.apache.org/jira/browse/AURORA-175
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is changes 1 of 2 for AURORA-175.  The second change adds an exit status 
> contract between Aurora and Thermos.
> 
> This change allows a process in the Thermos state machine to go directly from 
> WAITING -> FAILED if the user associated with that process has been deleted.  
> It also persists a 'uid' field to the Thermos RunnerHeader so that we can 
> check against process UIDs which in theory have higher fidelity than 
> usernames.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/thermos/common/ckpt.py 
> 7df179b135e896d52655667f0707850a4bc33068 
>   src/main/python/apache/thermos/core/helper.py 
> 82c68f3af424d3309db3816080465edd1ff1a87c 
>   src/main/python/apache/thermos/core/process.py 
> 4889e636c2fa7325852684cecd87a2123714144d 
>   src/main/python/apache/thermos/core/runner.py 
> 31f40713ec32c0626566899caec76f2a9985c7bf 
>   src/main/thrift/org/apache/thermos/thermos_internal.thrift 
> 0cea1057230b367c9d55b773854453cee2f9fce0 
>   src/test/python/apache/thermos/core/test_helper.py 
> 53f1e467283b45598b3f1865951c42b13579a512 
>   src/test/python/apache/thermos/core/test_process.py 
> 223393d62d85dbcd3da3c2ca0d5558e8209aa1d1 
> 
> Diff: https://reviews.apache.org/r/25972/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 26308: Fix exit condition for RPC loop, fix test_status_api_failure test.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26308/#review55405
---



src/test/python/apache/aurora/client/cli/test_api_from_cli.py
<https://reviews.apache.org/r/26308/#comment95761>

Can you also assert that this was called?



src/test/python/apache/aurora/client/cli/test_api_from_cli.py
<https://reviews.apache.org/r/26308/#comment95762>

can you instead .assert_called_once_with() ?


- Joe Smith


On Oct. 2, 2014, 9:52 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26308/
> ---
> 
> (Updated Oct. 2, 2014, 9:52 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fixes two problems:
> 
> - mocking was incorrect in `test_status_api_failure`.  Turns out that Mock 
> objects were being passed around and somehow resulted in the test case 
> passing.
> - use of `threading.Event()` was broken in scheduler_client.py.  I don't 
> think it's possible to enter those branches.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> b400cb2dbdb35077fc2c4a6e161c2959a9217317 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 1cbfbf86e903d890baac7d34461109f9beaff442 
>   src/test/python/apache/aurora/client/cli/test_api_from_cli.py 
> 78f21d2f20cf71fa2dfe0614885d44d2948decd2 
> 
> Diff: https://reviews.apache.org/r/26308/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all -vxs
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 25972: Make thermos more cognizant of user deletions

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25972/#review55410
---

Ship it!


Ship It!

- Joe Smith


On Oct. 3, 2014, 3:16 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25972/
> ---
> 
> (Updated Oct. 3, 2014, 3:16 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Kevin Sweeney.
> 
> 
> Bugs: AURORA-175
> https://issues.apache.org/jira/browse/AURORA-175
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is changes 1 of 2 for AURORA-175.  The second change adds an exit status 
> contract between Aurora and Thermos.
> 
> This change allows a process in the Thermos state machine to go directly from 
> WAITING -> FAILED if the user associated with that process has been deleted.  
> It also persists a 'uid' field to the Thermos RunnerHeader so that we can 
> check against process UIDs which in theory have higher fidelity than 
> usernames.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/thermos/common/ckpt.py 
> 7df179b135e896d52655667f0707850a4bc33068 
>   src/main/python/apache/thermos/core/helper.py 
> 82c68f3af424d3309db3816080465edd1ff1a87c 
>   src/main/python/apache/thermos/core/process.py 
> 4889e636c2fa7325852684cecd87a2123714144d 
>   src/main/python/apache/thermos/core/runner.py 
> 31f40713ec32c0626566899caec76f2a9985c7bf 
>   src/main/thrift/org/apache/thermos/thermos_internal.thrift 
> 0cea1057230b367c9d55b773854453cee2f9fce0 
>   src/test/python/apache/thermos/core/test_helper.py 
> 53f1e467283b45598b3f1865951c42b13579a512 
>   src/test/python/apache/thermos/core/test_process.py 
> 223393d62d85dbcd3da3c2ca0d5558e8209aa1d1 
> 
> Diff: https://reviews.apache.org/r/25972/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 26137: Fix help for new update command.

[Joe Smith]

> On Sept. 29, 2014, 11:32 p.m., Joe Smith wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 45
> > <https://reviews.apache.org/r/26137/diff/1/?file=708198#file708198line45>
> >
> > Could you update a test case to catch accessing these as properties to 
> > catch accidental regressions?
> 
> David McLaughlin wrote:
> Piggy backing this issue to add that my ship it is pending a test for 
> this command at least?
> 
> Mark Chu-Carroll wrote:
> I don't know of any way to write a single test that would always catch 
> this.
> 
> Joe Smith wrote:
> Rebased off your diff:
> 
> [tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ git diff
> diff --git a/src/main/python/apache/aurora/client/cli/update.py 
> b/src/main/python/apache/aurora/client/cli/update.py
> index 41475a7..ef07a11 100644
> --- a/src/main/python/apache/aurora/client/cli/update.py
> +++ b/src/main/python/apache/aurora/client/cli/update.py
> @@ -42,7 +42,6 @@ class StartUpdate(Verb):
>INSTANCES_SPEC_ARGUMENT, CONFIG_ARGUMENT
>  ]
>  
> -  @property
>def help(self):
>  return textwrap.dedent("""\
>  Start a scheduler-driven rolling upgrade on a running job, using 
> the update
> diff --git a/src/test/python/apache/aurora/client/cli/test_update.py 
> b/src/test/python/apache/aurora/client/cli/test_update.py
> index eeed774..1a38ffe 100644
> --- a/src/test/python/apache/aurora/client/cli/test_update.py
> +++ b/src/test/python/apache/aurora/client/cli/test_update.py
> @@ -23,6 +23,7 @@ from apache.aurora.client.api.quota_check import 
> QuotaCheck
>  from apache.aurora.client.api.scheduler_mux import SchedulerMux
>  from apache.aurora.client.cli import EXIT_INVALID_CONFIGURATION, EXIT_OK
>  from apache.aurora.client.cli.client import AuroraCommandLine
> +from apache.aurora.client.cli.update import StartUpdate
>  from apache.aurora.client.cli.util import AuroraClientCommandTest, 
> FakeAuroraCommandContext, IOMock
>  from apache.aurora.config import AuroraConfig
>  
> @@ -301,6 +302,10 @@ class TestUpdateCommand(AuroraClientCommandTest):
>'Update completed successfully']
>assert mock_err.get() == []
>  
> +  def test_update_start_help(self):
> +start = StartUpdate()
> +assert 'Start a scheduler-driven rolling' in start.help
> +
>@classmethod
>def assert_correct_addinstance_calls(cls, api):
>  assert api.addInstances.call_count == 20
> [tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ ./pants 
> ./src/test/python/apache/aurora/client/cli:job
> Build operating on top level addresses: 
> set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD,
>  job)])
> 
> 
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.25 -- pytest-2.6.3
> plugins: cov, timeout
> collected 61 items 
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ..
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py 
> src/test/python/apache/aurora/client/cli/test_open.py .
> src/test/python/apache/aurora/client/cli/test_restart.py 
> src/test/python/apache/aurora/client/cli/test_status.py ...
> src/test/python/apache/aurora/client/cli/test_update.py ..F...
> 
> 
> ==
>  FAILURES 
> ==
> 
> __
>  TestUpdateCommand.test_update_start_help 
> __
&g

Review Request 26372: Update as property

[Joe Smith]

--
 Captured stderr call 

log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
=
 1 failed, 5 passed in 0.88 seconds 
=========
src.test.python.apache.aurora.client.cli.help   
.   FAILURE


Thanks,

Joe Smith

Re: Review Request 26372: Test all the nouns and verbs within the Aurora Command Line for help output

[Joe Smith]

t')) in []
E+  where [] = .transcript

src/test/python/apache/aurora/client/cli/test_help.py:50: AssertionError

 Captured stderr call 

log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
log(ERROR): Unknown error: sequence item 24: expected string, instancemethod 
found
=
 1 failed, 5 passed in 0.88 seconds 
=========
src.test.python.apache.aurora.client.cli.help   
.   FAILURE


Thanks,

Joe Smith

Review Request 26378: Upgrade to pants 0.0.24

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26378/
---

Review request for Aurora, Joshua Cohen, Brian Wickman, and Zameer Manji.


Bugs: AURORA-363
https://issues.apache.org/jira/browse/AURORA-363


Repository: aurora


Description
---

Upgrade to pants 0.0.24


Diffs
-

  pants 61468a9ea51f3abe7db48f605f8623321005c3a8 
  pants.ini f6461c2ba2f7506204db66b56b6c858c65286790 

Diff: https://reviews.apache.org/r/26378/diff/


Testing
---

[tw-172-25-132-201 aurora (yasumoto/pants_0.0.24)]$ 
./build-support/jenkins/build.sh 


Thanks,

Joe Smith

Re: Review Request 26378: Upgrade to pants 0.0.24

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26378/
---

(Updated Oct. 6, 2014, 12:53 p.m.)


Review request for Aurora, Joshua Cohen, Brian Wickman, and Zameer Manji.


Changes
---

Added changelog (thanks for the nudge, Zameer!)


Bugs: AURORA-363
https://issues.apache.org/jira/browse/AURORA-363


Repository: aurora


Description (updated)
---

Upgrade to pants 0.0.24

The biggest highlight from the changelog at 
https://pypi.python.org/pypi/pantsbuild.pants/0.0.24 is this will enforce 
python2.7 across the repository.


Diffs
-

  pants 61468a9ea51f3abe7db48f605f8623321005c3a8 
  pants.ini f6461c2ba2f7506204db66b56b6c858c65286790 

Diff: https://reviews.apache.org/r/26378/diff/


Testing
---

[tw-172-25-132-201 aurora (yasumoto/pants_0.0.24)]$ 
./build-support/jenkins/build.sh 


Thanks,

Joe Smith

Re: Review Request 26424: Disable requests http connection logging.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26424/#review55698
---

Ship it!



src/test/python/apache/aurora/common/test_transport.py
<https://reviews.apache.org/r/26424/#comment96076>

I think this can be removed- we're validating what we want here. Although 
I'm not quite a fan of this global state being modified via module import, I'm 
not sure we need to have an entirely separate test file that gets executed just 
to check the before/after.


- Joe Smith


On Oct. 7, 2014, 12:58 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26424/
> ---
> 
> (Updated Oct. 7, 2014, 12:58 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Bill Farner.
> 
> 
> Bugs: AURORA-770
> https://issues.apache.org/jira/browse/AURORA-770
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Disable requests http connection logging.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/common/transport.py 
> 6f7c355d725b5e537cc4ae471170eaa8431da326 
>   src/test/python/apache/aurora/common/test_transport.py 
> c722eae2d04dec90e9c772f49c578184a2bdf76c 
> 
> Diff: https://reviews.apache.org/r/26424/diff/
> 
> 
> Testing
> ---
> 
> Added hokey test, ran hokey test.
> 
> Also verified the lack of http connection logs when running client commands 
> directly.
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 26424: Disable requests http connection logging.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26424/#review55727
---

Ship it!


Aha, here we go. Thanks!!

- Joe Smith


On Oct. 7, 2014, 1:32 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26424/
> ---
> 
> (Updated Oct. 7, 2014, 1:32 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Bill Farner.
> 
> 
> Bugs: AURORA-770
> https://issues.apache.org/jira/browse/AURORA-770
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Disable requests http connection logging.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/common/transport.py 
> 6f7c355d725b5e537cc4ae471170eaa8431da326 
>   src/test/python/apache/aurora/common/test_transport.py 
> c722eae2d04dec90e9c772f49c578184a2bdf76c 
> 
> Diff: https://reviews.apache.org/r/26424/diff/
> 
> 
> Testing
> ---
> 
> Added hokey test, ran hokey test.
> 
> Also verified the lack of http connection logs when running client commands 
> directly.
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 26432: Reject new GC tasks when shutting down

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26432/#review55839
---

Ship it!


Awesome

- Joe Smith


On Oct. 8, 2014, 10:28 a.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26432/
> ---
> 
> (Updated Oct. 8, 2014, 10:28 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Bill Farner, and Brian Wickman.
> 
> 
> Bugs: AURORA-807
> https://issues.apache.org/jira/browse/AURORA-807
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Reject new GC tasks when shutting down
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> 80ce6dc93e17f01c95a84ee8bef2ce87cafa88c0 
>   src/test/python/apache/aurora/executor/test_gc_executor.py 
> d90dc68ec1526110a484cfc2b6c4658abdc2e871 
> 
> Diff: https://reviews.apache.org/r/26432/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python/apache/aurora/executor:gc_executor
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 26308: Fix exit condition for RPC loop, fix test_status_api_failure test.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26308/#review55858
---

Ship it!


Ship It!

- Joe Smith


On Oct. 4, 2014, 10:55 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26308/
> ---
> 
> (Updated Oct. 4, 2014, 10:55 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fixes two problems:
> 
> - mocking was incorrect in `test_status_api_failure`.  Turns out that Mock 
> objects were being passed around and somehow resulted in the test case 
> passing.
> - use of `threading.Event()` was broken in scheduler_client.py.  I don't 
> think it's possible to enter those branches.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 26300792594e4005dacc139a9f89711b8a66ab61 
>   src/main/python/apache/aurora/client/api/command_runner.py 
> a1fed5fc75dde3a79c840515e6daa4741156ef97 
>   src/main/python/apache/aurora/client/api/job_monitor.py 
> 18d5c0381d43fc7b24bae4b2e5e6fdc774a74b52 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 311c954f1db245b75192d00c6aca0721085fbf32 
>   src/main/python/apache/aurora/client/api/updater.py 
> bf608981c2f2e7960b68c3fbda144277a59a3d40 
>   src/main/python/apache/aurora/common/aurora_job_key.py 
> a7ca7b6df6b9566b3ce617283ccac948deb2eb83 
>   src/test/python/apache/aurora/client/api/test_job_monitor.py 
> 5b26539f86a0a82f72753a803a769eda77cbc332 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 1835843f1795b0530874ec561582df17acfbce65 
>   src/test/python/apache/aurora/client/api/test_updater.py 
> 6905831b23a84320e7f41843efd62b86da366c0b 
>   src/test/python/apache/aurora/client/cli/test_api_from_cli.py 
> 78f21d2f20cf71fa2dfe0614885d44d2948decd2 
>   src/test/python/apache/aurora/client/cli/test_cancel_update.py 
> c15e142930c9474c7873dd931261b6ab4eb5967f 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 3acd2ba0d8bd8c71d4c0a9d71a035fc974fa20c3 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 6e55188bdfc576506848605debb391288e696fe3 
>   src/test/python/apache/aurora/client/cli/test_diff.py 
> e1a6f764830e06c73d0bc10a3b5da67219da836c 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> e3a366bf67074e50787394cad58d5e01359b641e 
>   src/test/python/apache/aurora/client/cli/test_logging.py 
> 6285fbb07442291c2dc4096e68eb285c98994097 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> bd30b11022ee0d1fb38da9f6efd4d9c5923b7d13 
>   src/test/python/apache/aurora/client/cli/test_task_run.py 
> 1ce9a632874e818eee71573cd481842affae3615 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> 85b1db19d89967a741bfba7964eeb368426f0b61 
>   src/test/python/apache/aurora/client/commands/test_admin.py 
> 1192556c027dc3adf16bb37adeac7798cf9ef93d 
>   src/test/python/apache/aurora/client/commands/test_cancel_update.py 
> 5f05ef7c0643d189de3de38c75aae58c2a3814a4 
>   src/test/python/apache/aurora/client/commands/test_create.py 
> 7503345ea1c0f224a894ce02cc2c2d8719574e32 
>   src/test/python/apache/aurora/client/commands/test_diff.py 
> 8f5da7d2bca9b0486b635afe49d3885151624e12 
>   src/test/python/apache/aurora/client/commands/test_hooks.py 
> 0861f13b13a8406950ba953efba0ffae186a8253 
>   src/test/python/apache/aurora/client/commands/test_kill.py 
> c0a6fd44c5691cde50746ffdec325bb11a33469a 
>   src/test/python/apache/aurora/client/commands/test_run.py 
> e97b5156609f80a4170028e780bcd891e56983ff 
>   src/test/python/apache/aurora/client/commands/test_ssh.py 
> c5ca66e378bfc97c40a406a758ae4dfaef8ab2c8 
>   src/test/python/apache/aurora/client/commands/test_status.py 
> bda1f28d544ae48428129f8167d8632ef27f5fba 
>   src/test/python/apache/aurora/client/commands/test_update.py 
> af2cbc7f88287201a472ba36902b00d90bc77d3b 
> 
> Diff: https://reviews.apache.org/r/26308/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all -vxs
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 26431: Moving post_drain script execution into host_maintenance.py

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26431/#review55859
---



src/test/python/apache/aurora/client/commands/test_maintenance.py
<https://reviews.apache.org/r/26431/#comment96235>

can this be a mock that we assert gets called 3 times?

(This test is a little bit of an integration test since it goes in and is 
also testing perform_maintenace, but a full refactor of this test may be too 
much for now)


- Joe Smith


On Oct. 7, 2014, 5:13 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26431/
> ---
> 
> (Updated Oct. 7, 2014, 5:13 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-806
> https://issues.apache.org/jira/browse/AURORA-806
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Moving post_drain script functionality into host_maintenance.py to support 
> per batch execution.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> 9c2a9f77109791da574e1624d27b6b7096a2678e 
>   src/main/python/apache/aurora/client/commands/maintenance.py 
> e465d973e9f764076e18491e1691d44303c0f388 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 
> 40228df59e43bc6034f2dc651c166a0c4b78aea8 
>   src/test/python/apache/aurora/client/commands/test_maintenance.py 
> d86aaf677804301fa5ddf1f76dba552f4fafb8c3 
> 
> Diff: https://reviews.apache.org/r/26431/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 26424: Disable requests http connection logging.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26424/#review55860
---

Ship it!


Inlining inside `__init__` WFM. thanks!

- Joe Smith


On Oct. 8, 2014, 9:54 a.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26424/
> ---
> 
> (Updated Oct. 8, 2014, 9:54 a.m.)
> 
> 
> Review request for Aurora, Joe Smith and Bill Farner.
> 
> 
> Bugs: AURORA-770
> https://issues.apache.org/jira/browse/AURORA-770
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> .
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/common/transport.py 
> 6f7c355d725b5e537cc4ae471170eaa8431da326 
>   src/test/python/apache/aurora/common/test_transport.py 
> c722eae2d04dec90e9c772f49c578184a2bdf76c 
> 
> Diff: https://reviews.apache.org/r/26424/diff/
> 
> 
> Testing
> ---
> 
> Added hokey test, ran hokey test.
> 
> Also verified the lack of http connection logs when running client commands 
> directly.
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26458/#review55899
---



src/main/python/apache/aurora/admin/host_maintenance.py
<https://reviews.apache.org/r/26458/#comment96275>

Is this provided so external modules can interact with the maintenance?



src/main/python/apache/aurora/admin/host_maintenance.py
<https://reviews.apache.org/r/26458/#comment96274>

move out to its own method?



src/main/python/apache/aurora/admin/host_maintenance.py
<https://reviews.apache.org/r/26458/#comment96277>

Maybe just raise a normal exception instead? :)

(and maybe log which hosts weren't moved?)



src/test/python/apache/aurora/admin/test_host_maintenance.py
<https://reviews.apache.org/r/26458/#comment96279>

can you assert on how many times this was called?


- Joe Smith


On Oct. 8, 2014, 2:40 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26458/
> ---
> 
> (Updated Oct. 8, 2014, 2:40 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Brian Wickman.
> 
> 
> Bugs: AURORA-820
> https://issues.apache.org/jira/browse/AURORA-820
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Throttling status check calls now at a predefined 5 second interval with a 
> max timeout of 5 minutes.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> 9c2a9f77109791da574e1624d27b6b7096a2678e 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 
> 40228df59e43bc6034f2dc651c166a0c4b78aea8 
> 
> Diff: https://reviews.apache.org/r/26458/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 26431: Moving post_drain script execution into host_maintenance.py

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26431/#review55911
---

Ship it!


Thanks!

- Joe Smith


On Oct. 8, 2014, 4:46 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26431/
> ---
> 
> (Updated Oct. 8, 2014, 4:46 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-806
> https://issues.apache.org/jira/browse/AURORA-806
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Moving post_drain script functionality into host_maintenance.py to support 
> per batch execution.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> 9c2a9f77109791da574e1624d27b6b7096a2678e 
>   src/main/python/apache/aurora/client/commands/maintenance.py 
> e465d973e9f764076e18491e1691d44303c0f388 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 
> 40228df59e43bc6034f2dc651c166a0c4b78aea8 
> 
> Diff: https://reviews.apache.org/r/26431/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 26333: Add exit status contract between thermos runner and aurora executor.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26333/#review56446
---

Ship it!


Ship It!

- Joe Smith


On Oct. 6, 2014, 11:12 a.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26333/
> ---
> 
> (Updated Oct. 6, 2014, 11:12 a.m.)
> 
> 
> Review request for Aurora, Joe Smith and Kevin Sweeney.
> 
> 
> Bugs: AURORA-175
> https://issues.apache.org/jira/browse/AURORA-175
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adds an exit status contract between the ThermosTaskRunner and the 
> thermos_runner.pex so that we can discriminate between losses / failures.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/BUILD 
> 5f0ef7c12479fe2bbdebc3dacdd6ce5aa4910413 
>   src/main/python/apache/aurora/executor/thermos_runner.py 
> 396753e0f95ce1342dba05ea1897a6842e6547df 
>   src/main/python/apache/aurora/executor/thermos_statuses.py PRE-CREATION 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 7b346e253677ee9b42c57782f7f67ff63b6a0083 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> f6ca4dfd0fd262361709361c48c93799837e0a54 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
> 8e4042b29dce8a815c5995b9e2701c95fe3f034b 
> 
> Diff: https://reviews.apache.org/r/26333/diff/
> 
> 
> Testing
> ---
> 
> Added tests.  Refers to Process.UnknownUserError which is added in 
> https://reviews.apache.org/r/25972/ but not available here.
> 
> Update: ran build-support/jenkins/build.sh after the merge of 25972 and it 
> passed.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26458/#review56774
---



src/test/python/apache/aurora/client/commands/test_maintenance.py
<https://reviews.apache.org/r/26458/#comment97177>

mock_wait.assert_called_once_with


- Joe Smith


On Oct. 10, 2014, 3 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26458/
> ---
> 
> (Updated Oct. 10, 2014, 3 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Brian Wickman.
> 
> 
> Bugs: AURORA-820
> https://issues.apache.org/jira/browse/AURORA-820
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Throttling status check calls now at a predefined 5 second interval with a 
> max timeout of 5 minutes.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> 9c2a9f77109791da574e1624d27b6b7096a2678e 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 
> 40228df59e43bc6034f2dc651c166a0c4b78aea8 
>   src/test/python/apache/aurora/client/commands/test_maintenance.py 
> d86aaf677804301fa5ddf1f76dba552f4fafb8c3 
> 
> Diff: https://reviews.apache.org/r/26458/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 26383: Health Check Disabler

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/#review56886
---


Two nits related to mocking, but this looks good to me!

Can you also add a note to the [Health Checking section of the User 
Guide](https://github.com/apache/incubator-aurora/blob/master/docs/user-guide.md#user-content-http-health-checking-and-graceful-shutdown)
 describing how a user can/should do this? Maybe something like:

```markdown
*** Snoozing Health Checks

If you need to pause your health check, you can do so by touching a file inside 
of your sandbox, named `.healthchecksnooze`

As long as that file is present, health checks will be disabled, enabling users 
to gather core dumps or other performance measurments without worrying about 
Aurora's health check killing their process
```


src/test/python/apache/aurora/executor/common/test_health_checker.py
<https://reviews.apache.org/r/26383/#comment97324>

can you try `spec_set=SandboxInterface` instead?



src/test/python/apache/aurora/executor/common/test_health_checker.py
<https://reviews.apache.org/r/26383/#comment97325>

```python
@mock.patch('os.path', spec_set=os.path)
```
    
    Here and below.


- Joe Smith


On Oct. 13, 2014, 1:53 p.m., David Pan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26383/
> ---
> 
> (Updated Oct. 13, 2014, 1:53 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Brian Wickman, and Zameer Manji.
> 
> 
> Bugs: AURORA-795
> https://issues.apache.org/jira/browse/AURORA-795
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The health check disabler allows health checks for a job to be snoozed 
> temporarily by touching a snooze file in the job's sandbox.  The appropriate 
> unit tests were modified/added.
> 
> The corresponding JIRA ticket is the following:
> https://issues.apache.org/jira/browse/AURORA-795
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 4980411c847d12655cbb363404707ebd9f0bd163 
>   src/test/python/apache/aurora/executor/common/BUILD 
> c7f7a003c865d479ba6e3cd7b5349322f884f653 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> aa36415fa891fc523a3a376ffeca5d3cd5ceabec 
> 
> Diff: https://reviews.apache.org/r/26383/diff/
> 
> 
> Testing
> ---
> 
> On vagrant in ~/aurora, I ran
> ./pants src/test/python/apache/aurora/executor::
> 
> 
> Thanks,
> 
> David Pan
> 
>

Review Request 26802: Set a default for the error log dir

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26802/
---

Review request for Aurora, Maxim Khutornenko, Bill Farner, and Zameer Manji.


Bugs: AURORA-827
https://issues.apache.org/jira/browse/AURORA-827


Repository: aurora


Description
---

Set a default for the error log dir

This has been a weird  issue to wrap my head around, it's really using lots of 
low-level systems (writing tracebacks to files) so I feel like I've done some 
weird things in the tests. Feedback and critque welcome + appreciated.


Diffs
-

  src/main/python/apache/aurora/client/cli/__init__.py 
da9d5b6ba4d22ba1f444341b97bbcfaf7889a4a8 
  src/test/python/apache/aurora/client/cli/BUILD 
d33e86643a59879c115876c98bd1dc19aa7ae61c 
  src/test/python/apache/aurora/client/cli/test_aurora_command_line.py 
PRE-CREATION 

Diff: https://reviews.apache.org/r/26802/diff/


Testing
---

[tw-172-25-132-201 aurora (yasumoto/error_log_dir_default)]$ ./pants 
src/test/python/apache/aurora/client/cli:aurora_command_line
Build operating on top level addresses: 
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD,
 aurora_command_line)])
 test 
session starts 
=
platform darwin -- Python 2.7.5 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 1 items 

src/test/python/apache/aurora/client/cli/test_aurora_command_line.py .

== 1 passed in 
0.63 seconds ==
src.test.python.apache.aurora.client.cli.aurora_command_line
.   SUCCESS


Thanks,

Joe Smith

Review Request 26809: Add a metric to track how many slaves do not provide sufficent resources to launch a GC Executor

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26809/
---

Review request for Aurora, Kevin Sweeney and Bill Farner.


Bugs: AURORA-843
https://issues.apache.org/jira/browse/AURORA-843


Repository: aurora


Description
---

Add a metric to track how many slaves do not provide sufficent resources to 
launch a GC Executor


Diffs
-

  src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
cfab57896f9c76754ba3b42742504fb7e7a2cf79 
  src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 
f2d153f446247032ad9d8d173fb70870dbfdcca1 

Diff: https://reviews.apache.org/r/26809/diff/


Testing
---

./gradlew -Pq build


Thanks,

Joe Smith

Re: Review Request 26809: Add a metric to count offers that do not provide sufficent resources to launch a GC Executor

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26809/
---

(Updated Oct. 16, 2014, 10:07 a.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

wfarner's suggestion


Summary (updated)
-

Add a metric to count offers that do not provide sufficent resources to launch 
a GC Executor


Bugs: AURORA-843
https://issues.apache.org/jira/browse/AURORA-843


Repository: aurora


Description (updated)
---

Add a metric to count offers that do not provide sufficent resources to launch 
a GC Executor


Diffs
-

  src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
cfab57896f9c76754ba3b42742504fb7e7a2cf79 
  src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 
f2d153f446247032ad9d8d173fb70870dbfdcca1 

Diff: https://reviews.apache.org/r/26809/diff/


Testing
---

./gradlew -Pq build


Thanks,

Joe Smith

Re: Review Request 26802: Set a default for the error log dir

[Joe Smith]

> On Oct. 16, 2014, 10 a.m., Bill Farner wrote:
> > src/main/python/apache/aurora/client/cli/__init__.py, line 114
> > <https://reviews.apache.org/r/26802/diff/1/?file=722890#file722890line114>
> >
> > Can you try to remove noqa, and if it is suppressing an error, leave a 
> > comment indicating why the pyflakes errors are suppressed?

Yep, these should've been classmethods.


> On Oct. 16, 2014, 10 a.m., Bill Farner wrote:
> > src/main/python/apache/aurora/client/cli/__init__.py, line 118
> > <https://reviews.apache.org/r/26802/diff/1/?file=722890#file722890line118>
> >
> > Ditto
> > 
> > 
> > also, more concise:
> > 
> > return Context.ERROR_LOG_DIR or '.'

Done.


> On Oct. 16, 2014, 10 a.m., Bill Farner wrote:
> > src/test/python/apache/aurora/client/cli/BUILD, line 140
> > <https://reviews.apache.org/r/26802/diff/1/?file=722891#file722891line140>
> >
> > remove extra newline

Done.


> On Oct. 16, 2014, 10 a.m., Bill Farner wrote:
> > src/test/python/apache/aurora/client/cli/test_aurora_command_line.py, line 
> > 34
> > <https://reviews.apache.org/r/26802/diff/1/?file=722892#file722892line34>
> >
> > I'm not sure what the right answer is here, and we may be too far down 
> > the monkeypatch road to change tacks in this effort, but overriding 
> > builtins feels like a special kind of abstraction violation.
> > 
> > Do any other reviewers know the lay of the land well enough to suggest 
> > a better way?  Ideally we would be injecting this functionallity rather 
> > than patching it, but i don't want to turn a small fix into a giant yak 
> > shave.
> 
> Maxim Khutornenko wrote:
> Seems like the appropriate use of patching given the current 
> implementation. Refactoring here would only hurt readability and would rather 
> feel unnatural.
> 
> Joshua Cohen wrote:
> +1, I'm not an expert on what is or isn't pythonic, but this certainly 
> seems in line with how I've done testing in other dynamic languages. I'm not 
> sure cluttering up the interface with explicit injection points for 
> dependencies is warranted/necessary when you can just patch them in tests?

Unless we switch to using interfaces and injection, patching is indeed a 
~recommended approach.


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26802/#review56929
---


On Oct. 15, 2014, 11:02 p.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26802/
> ---
> 
> (Updated Oct. 15, 2014, 11:02 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-827
> https://issues.apache.org/jira/browse/AURORA-827
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Set a default for the error log dir
> 
> This has been a weird  issue to wrap my head around, it's really using lots 
> of low-level systems (writing tracebacks to files) so I feel like I've done 
> some weird things in the tests. Feedback and critque welcome + appreciated.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> da9d5b6ba4d22ba1f444341b97bbcfaf7889a4a8 
>   src/test/python/apache/aurora/client/cli/BUILD 
> d33e86643a59879c115876c98bd1dc19aa7ae61c 
>   src/test/python/apache/aurora/client/cli/test_aurora_command_line.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26802/diff/
> 
> 
> Testing
> ---
> 
> [tw-172-25-132-201 aurora (yasumoto/error_log_dir_default)]$ ./pants 
> src/test/python/apache/aurora/client/cli:aurora_command_line
> Build operating on top level addresses: 
> set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD,
>  aurora_command_line)])
>  test 
> session starts 
> =
> platform darwin -- Python 2.7.5 -- py-1.4.25 -- pytest-2.6.3
> plugins: cov, timeout
> collected 1 items 
> 
> src/test/python/apache/aurora/client/cli/test_aurora_command_line.py .
> 
> == 1 passed 
> in 0.63 seconds 
> ==
> src.test.python.apache.aurora.client.cli.aurora_command_line  
>   .   SUCCESS
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Re: Review Request 26802: Set a default for the error log dir

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26802/
---

(Updated Oct. 16, 2014, 10:51 a.m.)


Review request for Aurora, Maxim Khutornenko, Bill Farner, and Zameer Manji.


Changes
---

Review feedback (thanks!)


Bugs: AURORA-827
https://issues.apache.org/jira/browse/AURORA-827


Repository: aurora


Description
---

Set a default for the error log dir

This has been a weird  issue to wrap my head around, it's really using lots of 
low-level systems (writing tracebacks to files) so I feel like I've done some 
weird things in the tests. Feedback and critque welcome + appreciated.


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/__init__.py 
da9d5b6ba4d22ba1f444341b97bbcfaf7889a4a8 
  src/test/python/apache/aurora/client/cli/BUILD 
d33e86643a59879c115876c98bd1dc19aa7ae61c 
  src/test/python/apache/aurora/client/cli/test_aurora_command_line.py 
PRE-CREATION 

Diff: https://reviews.apache.org/r/26802/diff/


Testing
---

[tw-172-25-132-201 aurora (yasumoto/error_log_dir_default)]$ ./pants 
src/test/python/apache/aurora/client/cli:aurora_command_line
Build operating on top level addresses: 
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD,
 aurora_command_line)])
 test 
session starts 
=
platform darwin -- Python 2.7.5 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 1 items 

src/test/python/apache/aurora/client/cli/test_aurora_command_line.py .

== 1 passed in 
0.63 seconds ==
src.test.python.apache.aurora.client.cli.aurora_command_line
.   SUCCESS


Thanks,

Joe Smith

Re: Review Request 26802: Set a default for the error log dir

[Joe Smith]

> On Oct. 16, 2014, 10:24 a.m., Maxim Khutornenko wrote:
> > src/test/python/apache/aurora/client/cli/test_aurora_command_line.py, line 
> > 31
> > <https://reviews.apache.org/r/26802/diff/1/?file=722892#file722892line31>
> >
> > Expand 'm' to something more meaningful?

Done


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26802/#review56942
-----------


On Oct. 15, 2014, 11:02 p.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26802/
> ---
> 
> (Updated Oct. 15, 2014, 11:02 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-827
> https://issues.apache.org/jira/browse/AURORA-827
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Set a default for the error log dir
> 
> This has been a weird  issue to wrap my head around, it's really using lots 
> of low-level systems (writing tracebacks to files) so I feel like I've done 
> some weird things in the tests. Feedback and critque welcome + appreciated.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> da9d5b6ba4d22ba1f444341b97bbcfaf7889a4a8 
>   src/test/python/apache/aurora/client/cli/BUILD 
> d33e86643a59879c115876c98bd1dc19aa7ae61c 
>   src/test/python/apache/aurora/client/cli/test_aurora_command_line.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26802/diff/
> 
> 
> Testing
> ---
> 
> [tw-172-25-132-201 aurora (yasumoto/error_log_dir_default)]$ ./pants 
> src/test/python/apache/aurora/client/cli:aurora_command_line
> Build operating on top level addresses: 
> set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD,
>  aurora_command_line)])
>  test 
> session starts 
> =
> platform darwin -- Python 2.7.5 -- py-1.4.25 -- pytest-2.6.3
> plugins: cov, timeout
> collected 1 items 
> 
> src/test/python/apache/aurora/client/cli/test_aurora_command_line.py .
> 
> ====== 1 passed 
> in 0.63 seconds 
> ==
> src.test.python.apache.aurora.client.cli.aurora_command_line  
>   .   SUCCESS
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Re: Review Request 26802: Set a default for the error log dir

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26802/
---

(Updated Oct. 16, 2014, 1:22 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
---

Removing zmanji per request (thanks for being upfront!)


Bugs: AURORA-827
https://issues.apache.org/jira/browse/AURORA-827


Repository: aurora


Description
---

Set a default for the error log dir

This has been a weird  issue to wrap my head around, it's really using lots of 
low-level systems (writing tracebacks to files) so I feel like I've done some 
weird things in the tests. Feedback and critque welcome + appreciated.


Diffs
-

  src/main/python/apache/aurora/client/cli/__init__.py 
da9d5b6ba4d22ba1f444341b97bbcfaf7889a4a8 
  src/test/python/apache/aurora/client/cli/BUILD 
d33e86643a59879c115876c98bd1dc19aa7ae61c 
  src/test/python/apache/aurora/client/cli/test_aurora_command_line.py 
PRE-CREATION 

Diff: https://reviews.apache.org/r/26802/diff/


Testing
---

[tw-172-25-132-201 aurora (yasumoto/error_log_dir_default)]$ ./pants 
src/test/python/apache/aurora/client/cli:aurora_command_line
Build operating on top level addresses: 
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD,
 aurora_command_line)])
 test 
session starts 
=
platform darwin -- Python 2.7.5 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 1 items 

src/test/python/apache/aurora/client/cli/test_aurora_command_line.py .

== 1 passed in 
0.63 seconds ==
src.test.python.apache.aurora.client.cli.aurora_command_line
.   SUCCESS


Thanks,

Joe Smith

Review Request 26828: Remove info logging when users request json output

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26828/
---

Review request for Aurora, Bill Farner and Zameer Manji.


Bugs: AURORA-860
https://issues.apache.org/jira/browse/AURORA-860


Repository: aurora


Description
---

Remove info logging when users request json output


Diffs
-

  src/main/python/apache/aurora/client/api/__init__.py 
d12132f8ee64a390c9b5b4c9ab26b5e4b2b1bb59 
  src/main/python/apache/aurora/client/cli/context.py 
4e94a4e3017f3b2ace38d6d8ce68c3c778c8cd0e 
  src/main/python/apache/aurora/client/cli/jobs.py 
0277cbed4b7eb927d6e5823b4b41d90b366f81d0 
  src/test/python/apache/aurora/client/cli/BUILD 
d33e86643a59879c115876c98bd1dc19aa7ae61c 
  src/test/python/apache/aurora/client/cli/test_status.py 
c704daec5a6eee73c7092a201b168881853908e8 

Diff: https://reviews.apache.org/r/26828/diff/


Testing
---

[tw-172-25-132-201 aurora (jsmith/status_json)]$  ./pants 
./src/test/python/apache/aurora/client/cli:status
Build operating on top level addresses: 
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD,
 status)])

 test session starts 
=
platform darwin -- Python 2.7.5 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 12 items 

src/test/python/apache/aurora/client/cli/test_status.py 

=
 12 passed in 1.34 seconds 
==
src.test.python.apache.aurora.client.cli.status 
.   SUCCESS


Thanks,

Joe Smith

Re: Review Request 26828: Remove info logging when users request json output

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26828/
---

(Updated Oct. 16, 2014, 2:40 p.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
---

alex's catch


Bugs: AURORA-860
https://issues.apache.org/jira/browse/AURORA-860


Repository: aurora


Description
---

Remove info logging when users request json output


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/__init__.py 
d12132f8ee64a390c9b5b4c9ab26b5e4b2b1bb59 
  src/main/python/apache/aurora/client/cli/context.py 
4e94a4e3017f3b2ace38d6d8ce68c3c778c8cd0e 
  src/main/python/apache/aurora/client/cli/jobs.py 
0277cbed4b7eb927d6e5823b4b41d90b366f81d0 
  src/test/python/apache/aurora/client/cli/BUILD 
d33e86643a59879c115876c98bd1dc19aa7ae61c 
  src/test/python/apache/aurora/client/cli/test_status.py 
c704daec5a6eee73c7092a201b168881853908e8 

Diff: https://reviews.apache.org/r/26828/diff/


Testing (updated)
---

[tw-172-25-132-201 aurora (jsmith/status_json)]$ ./pants 
./src/test/python/apache/aurora/client/cli:job


Thanks,

Joe Smith

Re: Review Request 26828: Remove info logging when users request json output

[Joe Smith]

> On Oct. 16, 2014, 2:38 p.m., Alex Levenson wrote:
> > src/main/python/apache/aurora/client/api/__init__.py, line 107
> > <https://reviews.apache.org/r/26828/diff/1/?file=723414#file723414line107>
> >
> > might want to be consistent with "squelch" and "clean_output"? Choose 
> > one, or even call it "suppress_logging" or something like that?

Great call, thanks.


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26828/#review57004
-------


On Oct. 16, 2014, 2:31 p.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26828/
> ---
> 
> (Updated Oct. 16, 2014, 2:31 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-860
> https://issues.apache.org/jira/browse/AURORA-860
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove info logging when users request json output
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> d12132f8ee64a390c9b5b4c9ab26b5e4b2b1bb59 
>   src/main/python/apache/aurora/client/cli/context.py 
> 4e94a4e3017f3b2ace38d6d8ce68c3c778c8cd0e 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0277cbed4b7eb927d6e5823b4b41d90b366f81d0 
>   src/test/python/apache/aurora/client/cli/BUILD 
> d33e86643a59879c115876c98bd1dc19aa7ae61c 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> c704daec5a6eee73c7092a201b168881853908e8 
> 
> Diff: https://reviews.apache.org/r/26828/diff/
> 
> 
> Testing
> ---
> 
> [tw-172-25-132-201 aurora (jsmith/status_json)]$  ./pants 
> ./src/test/python/apache/aurora/client/cli:status
> Build operating on top level addresses: 
> set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD,
>  status)])
> 
>  test session starts 
> =
> platform darwin -- Python 2.7.5 -- py-1.4.25 -- pytest-2.6.3
> plugins: cov, timeout
> collected 12 items 
> 
> src/test/python/apache/aurora/client/cli/test_status.py 
> 
> =
>  12 passed in 1.34 seconds 
> ==========
> src.test.python.apache.aurora.client.cli.status   
>   .   SUCCESS
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Re: Review Request 26383: Health Check Disabler

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/#review57007
---

Ship it!


LGTM, thanks!

Since wickman is out, you may want to add maxim to the review instead.


docs/user-guide.md
<https://reviews.apache.org/r/26383/#comment97446>

Mind adding:

WARNING: Remember to remove this when you are done, otherwise your instance 
will have permanently disabled health checks.


- Joe Smith


On Oct. 16, 2014, 9:47 a.m., David Pan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26383/
> ---
> 
> (Updated Oct. 16, 2014, 9:47 a.m.)
> 
> 
> Review request for Aurora, Joe Smith, Brian Wickman, and Zameer Manji.
> 
> 
> Bugs: AURORA-795
> https://issues.apache.org/jira/browse/AURORA-795
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The health check disabler allows health checks for a job to be snoozed 
> temporarily by touching a snooze file in the job's sandbox.  The appropriate 
> unit tests were modified/added.
> 
> The corresponding JIRA ticket is the following:
> https://issues.apache.org/jira/browse/AURORA-795
> 
> 
> Diffs
> -
> 
>   docs/user-guide.md e12ee89b043e34d06348ae3ddbbe8363244fca7c 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 4980411c847d12655cbb363404707ebd9f0bd163 
>   src/test/python/apache/aurora/executor/common/BUILD 
> c7f7a003c865d479ba6e3cd7b5349322f884f653 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> aa36415fa891fc523a3a376ffeca5d3cd5ceabec 
> 
> Diff: https://reviews.apache.org/r/26383/diff/
> 
> 
> Testing
> ---
> 
> On vagrant in ~/aurora, I ran
> ./pants src/test/python/apache/aurora/executor::
> 
> 
> Thanks,
> 
> David Pan
> 
>

Re: Review Request 26828: Remove info logging when users request json output

[Joe Smith]

> On Oct. 16, 2014, 2:43 p.m., Zameer Manji wrote:
> > I feel we will need to revisit the json output in the future to ensure that 
> > we don't have to do this process for every subcommand.

Agreed.


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26828/#review57008
---


On Oct. 16, 2014, 2:40 p.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26828/
> ---
> 
> (Updated Oct. 16, 2014, 2:40 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-860
> https://issues.apache.org/jira/browse/AURORA-860
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove info logging when users request json output
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> d12132f8ee64a390c9b5b4c9ab26b5e4b2b1bb59 
>   src/main/python/apache/aurora/client/cli/context.py 
> 4e94a4e3017f3b2ace38d6d8ce68c3c778c8cd0e 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0277cbed4b7eb927d6e5823b4b41d90b366f81d0 
>   src/test/python/apache/aurora/client/cli/BUILD 
> d33e86643a59879c115876c98bd1dc19aa7ae61c 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> c704daec5a6eee73c7092a201b168881853908e8 
> 
> Diff: https://reviews.apache.org/r/26828/diff/
> 
> 
> Testing
> ---
> 
> [tw-172-25-132-201 aurora (jsmith/status_json)]$ ./pants 
> ./src/test/python/apache/aurora/client/cli:job
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Re: Review Request 26828: Remove info logging when users request json output

[Joe Smith]

> On Oct. 16, 2014, 4:22 p.m., Alex Levenson wrote:
> > Sorry all, I may have reported this one too early -- I think the log.info 
> > statements are going to stderr, in which case anyone parsing the json 
> > output that's sent to stdout should have no problems.

No worries- thanks for kicking the tires and helping make aurora better! :)


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26828/#review57044
---


On Oct. 16, 2014, 2:40 p.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26828/
> ---
> 
> (Updated Oct. 16, 2014, 2:40 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-860
> https://issues.apache.org/jira/browse/AURORA-860
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove info logging when users request json output
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> d12132f8ee64a390c9b5b4c9ab26b5e4b2b1bb59 
>   src/main/python/apache/aurora/client/cli/context.py 
> 4e94a4e3017f3b2ace38d6d8ce68c3c778c8cd0e 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0277cbed4b7eb927d6e5823b4b41d90b366f81d0 
>   src/test/python/apache/aurora/client/cli/BUILD 
> d33e86643a59879c115876c98bd1dc19aa7ae61c 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> c704daec5a6eee73c7092a201b168881853908e8 
> 
> Diff: https://reviews.apache.org/r/26828/diff/
> 
> 
> Testing
> ---
> 
> [tw-172-25-132-201 aurora (jsmith/status_json)]$ ./pants 
> ./src/test/python/apache/aurora/client/cli:job
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Re: Review Request 26852: Use mesos.native egg from ~kevints

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26852/#review57099
---

Ship it!


pending successful e2e test results.

thanks!

- Joe Smith


On Oct. 16, 2014, 6:50 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26852/
> ---
> 
> (Updated Oct. 16, 2014, 6:50 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-863
> https://issues.apache.org/jira/browse/AURORA-863
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use mesos.native egg from ~kevints
> 
> 
> Diffs
> -
> 
>   examples/vagrant/provision-dev-cluster.sh 
> 740bc212ba604b2c64af92eba1be41e8ed3fdbde 
> 
> Diff: https://reviews.apache.org/r/26852/diff/
> 
> 
> Testing
> ---
> 
> (Awaiting e2e test results 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh)
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26458/#review57164
---

Ship it!


Ship It!

- Joe Smith


On Oct. 17, 2014, 8:48 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26458/
> ---
> 
> (Updated Oct. 17, 2014, 8:48 a.m.)
> 
> 
> Review request for Aurora, Joe Smith and Brian Wickman.
> 
> 
> Bugs: AURORA-820
> https://issues.apache.org/jira/browse/AURORA-820
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Throttling status check calls now at a predefined 5 second interval with a 
> max timeout of 5 minutes.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> 9c2a9f77109791da574e1624d27b6b7096a2678e 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 
> 40228df59e43bc6034f2dc651c166a0c4b78aea8 
>   src/test/python/apache/aurora/client/commands/test_maintenance.py 
> d86aaf677804301fa5ddf1f76dba552f4fafb8c3 
> 
> Diff: https://reviews.apache.org/r/26458/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 27066: Follow the pantsbuild pants_support_baseurls for OS X Yosemite support.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27066/
---

Review request for Aurora, Kevin Sweeney and Bill Farner.


Bugs: AURORA-867
https://issues.apache.org/jira/browse/AURORA-867


Repository: aurora


Description
---

Follow the pantsbuild pants_support_baseurls for OS X Yosemite support.


Diffs
-

  pants.ini 03f7af4fdb7f46c716da2c7e1da98ae5607e5d3c 

Diff: https://reviews.apache.org/r/27066/diff/


Testing
---

22:19:24 incubator-aurora $ ./pants ./src/test/python/apache/aurora/admin:all

BinaryNotFound: Failed to fetch binary ('bin/thrift', '0.5.0-finagle', 
u'thrift') from any source: (Failed to fetch binary from 
http://maven.twttr.com/twitter-commons/pants/build-support/bin/thrift/mac/10.10/0.5.0-finagle/thrift:
 HTTP Error 404: Not Found)

After change:

22:40:44 incubator-aurora $ ./pants ./src/test/python/apache/aurora/admin:all
Build operating on top level addresses: 
set([BuildFileAddress(/Users/joe/Development/incubator-aurora/src/test/python/apache/aurora/admin/BUILD,
 all)])
===
 test session starts 

platform darwin -- Python 2.7.6 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 11 items 

src/test/python/apache/aurora/admin/test_host_maintenance.py ...


 11 passed in 2.13 seconds 
=
===
 test session starts 

platform darwin -- Python 2.7.6 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 2 items 

src/test/python/apache/aurora/admin/test_admin_util.py ..

=
 2 passed in 1.40 seconds 
=
src.test.python.apache.aurora.admin.admin_util  
.   SUCCESS
src.test.python.apache.aurora.admin.host_maintenance    
.   SUCCESS


Thanks,

Joe Smith

Re: Review Request 27058: Add specs to instances of Mock in Python tests.

[Joe Smith]

> On Oct. 22, 2014, 4:24 p.m., Mark Chu-Carroll wrote:
> > src/test/python/apache/aurora/client/cli/test_command_hooks.py, line 252
> > 
> >
> > I don't think this needs to be a mock at all - I'm pretty sure that you 
> > can just populate a real Response object directly. It looks like a lot of 
> > the others are like this.
> 
> Kevin Sweeney wrote:
> +1, and since the thrift structs work off dynamic properties, spec is 
> useless here. Calling the generated kwargs constructor gives you better 
> coverage here, as you can't accidentally create a thrift struct with a field 
> that doesn't exist without a TypeError
> 
> Maxim Khutornenko wrote:
> That's not true. Spec works just fine with thrift objects. For example, 
> adding 'spec=TaskConfig' generates an error where the same test would 
> previously pass:
> 
> AttributeError: Mock object has no attribute 'executorConfig'
> 
> David McLaughlin wrote:
> This is the behavior I observed as well. For example, see where I had to 
> update failure_count to failureCount because I added the spec. 
> 
> I'd really prefer a separate ticket for swapping out mocks for real 
> thrift objects.

+1 on specs for thrift structs.

@dmcg: I'm good with a separate JIRA if you cut it and add the 'newbie' label.


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27058/#review57926
---


On Oct. 22, 2014, 4:18 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27058/
> ---
> 
> (Updated Oct. 22, 2014, 4:18 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Zameer Manji.
> 
> 
> Bugs: AURORA-248
> https://issues.apache.org/jira/browse/AURORA-248
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use of Mock() without a specification considered harmful. I went through and 
> updated as many mocks as I could. 
> 
> Any remaining can be classified as:
> 
> 1) Mocks of classes that cannot be spec'd. Almost all instances of 
> SchedulerProxy, which uses __getattr__ to delegate to the read or write 
> client. 
> 2) Primitives like strings and callback functions or data objects like dicts 
> and pystachio structs.
> 3) Weird mocks that broke code where they really shouldn't have (off the top 
> of my head - in test_diff.py and commands/test_run.py) - both when they were 
> spec'd and when they were replaced with real thrift structs. 
> 
> 
> The remaining offenders:
> 
> $ grep -r --include="*.py" "Mock()" src/test/python 
> src/test/python/apache/aurora/admin/test_host_maintenance.py:
> mock_callback = mock.Mock()
> src/test/python/apache/aurora/admin/test_host_maintenance.py:
> mock_callback = mock.Mock()
> src/test/python/apache/aurora/client/api/test_api.py:mock_proxy = Mock()
> src/test/python/apache/aurora/client/api/test_api.py:mock_get = Mock()
> src/test/python/apache/aurora/client/api/test_api.py:mock_task_config = 
> Mock()
> src/test/python/apache/aurora/client/api/test_job_monitor.py:
> self._scheduler = Mock()
> src/test/python/apache/aurora/client/api/test_quota_check.py:
> self._scheduler = Mock()
> src/test/python/apache/aurora/client/api/test_scheduler_client.py:
> client._connect_scheduler = mock.MagicMock()
> src/test/python/apache/aurora/client/api/test_sla.py:self._scheduler = 
> Mock()
> src/test/python/apache/aurora/client/api/test_task_util.py:scheduler = 
> Mock()
> src/test/python/apache/aurora/client/cli/test_diff.py:  job = Mock()
> src/test/python/apache/aurora/client/cli/test_diff.py:  
> job.assignedTask.task.executorConfig.data = Mock()
> src/test/python/apache/aurora/client/cli/test_diff.py:
> patch('json.loads', return_value=Mock())) as (_, _, subprocess_patch, _):
> src/test/python/apache/aurora/client/cli/test_diff.py:
> patch('json.loads', return_value=Mock())) as (
> src/test/python/apache/aurora/client/cli/test_diff.py:
> patch('json.loads', return_value=Mock())) as (
> src/test/python/apache/aurora/client/cli/test_inspect.py:raw_config = 
> Mock()
> src/test/python/apache/aurora/client/cli/test_inspect.py:mock_task = 
> Mock()
> src/test/python/apache/aurora/client/cli/test_inspect.py:mock_process = 
> Mock()
> src/test/python/apache/aurora/client/cli/test_kill.py:
> mock_scheduler_proxy = Mock()
> src/test/python/apache/aurora/client/cli/test_kill.py:
> mock_scheduler_proxy = Mock()
> src/test/python/apache/aurora/client/cli/test_kill.py:
> mock_scheduler_proxy = Mock()
> src/test/python/apache/aurora/client/cli/test_kill.py:
> mock_scheduler_proxy = Mock()
> src/t

Review Request 27114: Move from github to bintray for pants support binaries.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27114/
---

Review request for Aurora, John Sirois, Kevin Sweeney, and Bill Farner.


Repository: aurora


Description
---

Move from github to bintray for pants support binaries.

This is from advice from jsirois on 
https://groups.google.com/d/msg/pants-devel/khP3TuSqWmo/nLqgc671Og0J


Diffs
-

  pants.ini 6f49f94236d1e1ed721578365173c96dc4420b02 

Diff: https://reviews.apache.org/r/27114/diff/


Testing
---

[tw-mbp13-jsmith aurora (yasumoto/pants_bintray)]$ ./pants 
./src/test/python/apache/aurora/admin:all
Build operating on top level addresses: 
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/admin/BUILD,
 all)])

 test session starts 
=
platform darwin -- Python 2.7.6 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 11 items 

src/test/python/apache/aurora/admin/test_host_maintenance.py ...

=
 11 passed in 0.62 seconds 
==

 test session starts 
=
platform darwin -- Python 2.7.6 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 2 items 

src/test/python/apache/aurora/admin/test_admin_util.py ..

==
 2 passed in 0.19 seconds 
==
src.test.python.apache.aurora.admin.admin_util  
.   SUCCESS
src.test.python.apache.aurora.admin.host_maintenance
.   SUCCESS


Thanks,

Joe Smith

Re: Review Request 27114: Move from github to bintray for pants support binaries.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27114/
---

(Updated Oct. 23, 2014, 3:19 p.m.)


Review request for Aurora, John Sirois, Kevin Sweeney, and Bill Farner.


Changes
---

Actually use https


Repository: aurora


Description
---

Move from github to bintray for pants support binaries.

This is from advice from jsirois on 
https://groups.google.com/d/msg/pants-devel/khP3TuSqWmo/nLqgc671Og0J


Diffs (updated)
-

  pants.ini 6f49f94236d1e1ed721578365173c96dc4420b02 

Diff: https://reviews.apache.org/r/27114/diff/


Testing
---

[tw-mbp13-jsmith aurora (yasumoto/pants_bintray)]$ ./pants 
./src/test/python/apache/aurora/admin:all
Build operating on top level addresses: 
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/admin/BUILD,
 all)])

 test session starts 
=
platform darwin -- Python 2.7.6 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 11 items 

src/test/python/apache/aurora/admin/test_host_maintenance.py ...

=
 11 passed in 0.62 seconds 
==

 test session starts 
=
platform darwin -- Python 2.7.6 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 2 items 

src/test/python/apache/aurora/admin/test_admin_util.py ..

==
 2 passed in 0.19 seconds 
==
src.test.python.apache.aurora.admin.admin_util  
.   SUCCESS
src.test.python.apache.aurora.admin.host_maintenance
.   SUCCESS


Thanks,

Joe Smith

Re: Review Request 27114: Move from github to bintray for pants support binaries.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27114/
---

(Updated Oct. 23, 2014, 3:19 p.m.)


Review request for Aurora, John Sirois, Kevin Sweeney, and Bill Farner.


Changes
---

Use https


Repository: aurora


Description
---

Move from github to bintray for pants support binaries.

This is from advice from jsirois on 
https://groups.google.com/d/msg/pants-devel/khP3TuSqWmo/nLqgc671Og0J


Diffs (updated)
-

  pants.ini 6f49f94236d1e1ed721578365173c96dc4420b02 

Diff: https://reviews.apache.org/r/27114/diff/


Testing
---

[tw-mbp13-jsmith aurora (yasumoto/pants_bintray)]$ ./pants 
./src/test/python/apache/aurora/admin:all
Build operating on top level addresses: 
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/admin/BUILD,
 all)])

 test session starts 
=
platform darwin -- Python 2.7.6 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 11 items 

src/test/python/apache/aurora/admin/test_host_maintenance.py ...

=
 11 passed in 0.62 seconds 
==

 test session starts 
=
platform darwin -- Python 2.7.6 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 2 items 

src/test/python/apache/aurora/admin/test_admin_util.py ..

==
 2 passed in 0.19 seconds 
==
src.test.python.apache.aurora.admin.admin_util  
.   SUCCESS
src.test.python.apache.aurora.admin.host_maintenance
.   SUCCESS


Thanks,

Joe Smith

Review Request 27129: Upgrade psutil to 2.1.3

[Joe Smith]

src.test.python.apache.aurora.config.test_base  
.   SUCCESS
src.test.python.apache.aurora.config.test_constraint_parsing
.   SUCCESS
src.test.python.apache.aurora.config.test_loader
.   SUCCESS
src.test.python.apache.aurora.config.test_thrift
.   SUCCESS
src.test.python.apache.aurora.executor.common.announcer 
.   SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox 
.   SUCCESS
src.test.python.apache.aurora.executor.common.executor_timeout  
.   SUCCESS
src.test.python.apache.aurora.executor.common.health_checker
.   SUCCESS
src.test.python.apache.aurora.executor.common.status_checker
.   SUCCESS
src.test.python.apache.aurora.executor.common.task_info 
.   SUCCESS
src.test.python.apache.aurora.executor.executor_base
.   SUCCESS
src.test.python.apache.aurora.executor.executor_detector
.   SUCCESS
src.test.python.apache.aurora.executor.executor_vars
.   SUCCESS
src.test.python.apache.aurora.executor.gc_executor  
.   SUCCESS
src.test.python.apache.aurora.executor.status_manager   
.   SUCCESS
src.test.python.apache.aurora.executor.thermos_executor 
.   SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner  
.   SUCCESS
src.test.python.apache.thermos.bin.test_thermos 
.   SUCCESS
src.test.python.apache.thermos.common.test_pathspec 
.   SUCCESS
src.test.python.apache.thermos.common.test_planner  
.   SUCCESS
src.test.python.apache.thermos.common.test_task_planner 
.   SUCCESS
src.test.python.apache.thermos.config.test_schema   
.   SUCCESS
src.test.python.apache.thermos.core.test_angry  
.   SUCCESS
src.test.python.apache.thermos.core.test_ephemerals 
.   SUCCESS
src.test.python.apache.thermos.core.test_failing_runner 
.   SUCCESS
src.test.python.apache.thermos.core.test_failure_limit  
.   SUCCESS
src.test.python.apache.thermos.core.test_finalization   
.   SUCCESS
src.test.python.apache.thermos.core.test_helper 
.   SUCCESS
src.test.python.apache.thermos.core.test_process
.   SUCCESS
src.test.python.apache.thermos.core.test_runner_integration 
.   SUCCESS
src.test.python.apache.thermos.core.test_staged_kill
.   SUCCESS
src.test.python.apache.thermos.monitoring.test_disk 
.   SUCCESS


Thanks,

Joe Smith

Review Request 27182: Add a test for the thermos resource module

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27182/
---

Review request for Aurora and Kevin Sweeney.


Repository: aurora


Description
---

Add a test for the thermos resource module


Diffs
-

  src/main/python/apache/thermos/monitoring/monitor.py 
8f87f5ffc39c87e87ff78b941ea30df7138bd1ef 
  src/test/python/apache/thermos/monitoring/BUILD 
33d6bba43aff6d62b2646491f004475c27ed99db 
  src/test/python/apache/thermos/monitoring/test_resource.py PRE-CREATION 

Diff: https://reviews.apache.org/r/27182/diff/


Testing
---

[tw-mbp13-jsmith aurora (yasumoto/psutil_2.1.3)]$ ./pants 
./src/test/python/apache/thermos/monitoring:test_resource
Build operating on top level addresses: 
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/thermos/monitoring/BUILD,
 test_resource)])

 test session starts 
=
platform darwin -- Python 2.7.6 -- py-1.4.26 -- pytest-2.6.4
plugins: cov, timeout
collected 5 items 

src/test/python/apache/thermos/monitoring/test_resource.py .

==
 5 passed in 0.21 seconds 
==
src.test.python.apache.thermos.monitoring.test_resource 
.   SUCCESS


Thanks,

Joe Smith

Re: Review Request 27188: Use ship-it instead of +/-1.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27188/#review58480
---

Ship it!


Ship It!

- Joe Smith


On Oct. 24, 2014, 8:17 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27188/
> ---
> 
> (Updated Oct. 24, 2014, 8:17 p.m.)
> 
> 
> Review request for Aurora and Jake Farrell.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use ship-it instead of +/-1.
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/review_feedback.py 
> 9d22358608d0d52019df0c4c5b96b08d0f157c43 
> 
> Diff: https://reviews.apache.org/r/27188/diff/
> 
> 
> Testing
> ---
> 
> None yet, will do a dry run Monday before committing.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 27182: Add a test for the thermos resource module

[Joe Smith]

> On Oct. 27, 2014, 12:46 p.m., Kevin Sweeney wrote:
> > src/test/python/apache/thermos/monitoring/test_resource.py, line 64
> > <https://reviews.apache.org/r/27182/diff/1/?file=733141#file733141line64>
> >
> > patching a private method assumes intimate knowledge of the class under 
> > test and suggests refactoring

Not quite- if this were for a different test then I'd agree, but since we're 
actually testing TaskResourceMonitor, we'll want to mock out that behavior (and 
test it separately) to ensure this method is using it right.

(At some point in the TestTaskResourceMonitor we'll need to mock out this 
behavior- so there will always be a patch around this spot)


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27182/#review58668
-------


On Oct. 24, 2014, 5:12 p.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27182/
> ---
> 
> (Updated Oct. 24, 2014, 5:12 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a test for the thermos resource module
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/thermos/monitoring/monitor.py 
> 8f87f5ffc39c87e87ff78b941ea30df7138bd1ef 
>   src/test/python/apache/thermos/monitoring/BUILD 
> 33d6bba43aff6d62b2646491f004475c27ed99db 
>   src/test/python/apache/thermos/monitoring/test_resource.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27182/diff/
> 
> 
> Testing
> ---
> 
> [tw-mbp13-jsmith aurora (yasumoto/psutil_2.1.3)]$ ./pants 
> ./src/test/python/apache/thermos/monitoring:test_resource
> Build operating on top level addresses: 
> set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/thermos/monitoring/BUILD,
>  test_resource)])
> 
>  test session starts 
> =
> platform darwin -- Python 2.7.6 -- py-1.4.26 -- pytest-2.6.4
> plugins: cov, timeout
> collected 5 items 
> 
> src/test/python/apache/thermos/monitoring/test_resource.py .
> 
> ==
>  5 passed in 0.21 seconds 
> ==========
> src.test.python.apache.thermos.monitoring.test_resource   
>   .   SUCCESS
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Re: Review Request 27710: Remove stracktrace redirection.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27710/#review60454
---

Ship it!


Ship It!

- Joe Smith


On Nov. 6, 2014, 3:40 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27710/
> ---
> 
> (Updated Nov. 6, 2014, 3:40 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Joe Smith, and Bill Farner.
> 
> 
> Bugs: AURORA-896
> https://issues.apache.org/jira/browse/AURORA-896
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove stracktrace redirection.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 6e553d8af459e575b2d62282a3bc0d1e266203d8 
>   src/main/python/apache/aurora/client/cli/standalone_client.py 
> b7c8de66d6e4664b536911f826e36a984e8d0fef 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 31fa56f5edcfc97903725ab27ccc12c6a8f39ffc 
> 
> Diff: https://reviews.apache.org/r/27710/diff/
> 
> 
> Testing
> ---
> 
> Example raising exception
> 
> vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job killall 
> devcluster/www-data/test/cron_hello_world
> Fatal error running command:
> Traceback (most recent call last):
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/__init__.py", line 
> 394, in _execute
> result = noun.execute(context)
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/__init__.py", line 
> 481, in execute
> return self.verbs[context.options.verb].execute(context)
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/jobs.py", line 393, 
> in execute
> raise ValueError()
> ValueError
> 
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 27894: Bump commons version.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27894/#review60903
---

Ship it!


Ship It!

- Joe Smith


On Nov. 11, 2014, 4:26 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27894/
> ---
> 
> (Updated Nov. 11, 2014, 4:26 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Bump commons version.
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 5e96b91aa11567f51ed599c9d585f3af4e4e7127 
> 
> Diff: https://reviews.apache.org/r/27894/diff/
> 
> 
> Testing
> ---
> 
> ./pants build src/test/python:all
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 29132: get_client_version should never be allowed to run unpatched in test.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29132/#review65340
---


Maybe this is actually legitimate tho? Perhaps we do want to catch PEX-INFO 
formatting changes?

- Joe Smith


On Dec. 16, 2014, 4:57 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29132/
> ---
> 
> (Updated Dec. 16, 2014, 4:57 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> get_client_version should never be allowed to run unpatched in test.
> 
> 
> Diffs
> -
> 
>   src/test/python/apache/aurora/client/cli/test_help.py 
> 1576edcaf0f59911c1c7aec42052d5ebfe41caac 
> 
> Diff: https://reviews.apache.org/r/29132/diff/
> 
> 
> Testing
> ---
> 
> get_client_version tries to get the PEX-INFO of sys.argv[0], which is usually 
> pants when running tests (!)  if the format of PEX-INFO changes to a new 
> version of pants (as is the case for pants 0.0.25), then tests will start 
> failing with an inscrutible error.  instead, just patch get_client_version to 
> something sensible.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 29132: get_client_version should never be allowed to run unpatched in test.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29132/#review65430
---

Ship it!


Ship It!

- Joe Smith


On Dec. 16, 2014, 4:57 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29132/
> ---
> 
> (Updated Dec. 16, 2014, 4:57 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> get_client_version should never be allowed to run unpatched in test.
> 
> 
> Diffs
> -
> 
>   src/test/python/apache/aurora/client/cli/test_help.py 
> 1576edcaf0f59911c1c7aec42052d5ebfe41caac 
> 
> Diff: https://reviews.apache.org/r/29132/diff/
> 
> 
> Testing
> ---
> 
> get_client_version tries to get the PEX-INFO of sys.argv[0], which is usually 
> pants when running tests (!)  if the format of PEX-INFO changes to a new 
> version of pants (as is the case for pants 0.0.25), then tests will start 
> failing with an inscrutible error.  instead, just patch get_client_version to 
> something sensible.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 29171: Fix test_executor_vars so that it doesn't attempt to get a real PEX-INFO.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29171/#review65431
---

Ship it!


Ship It!

- Joe Smith


On Dec. 17, 2014, 12:31 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29171/
> ---
> 
> (Updated Dec. 17, 2014, 12:31 p.m.)
> 
> 
> Review request for Aurora and Joe Smith.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix test_executor_vars so that it doesn't attempt to get a real PEX-INFO.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/executor_vars.py 
> 7c018271724ffab2ff6930e5802a48b50a39dded 
>   src/test/python/apache/aurora/executor/BUILD 
> 3095f2a148b21365ea2f500039adb5710a187fa1 
>   src/test/python/apache/aurora/executor/test_executor_vars.py 
> af1c7b7d78b89ae713d6db96cf766b596fa91c55 
> 
> Diff: https://reviews.apache.org/r/29171/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python/apache/aurora/executor:executor_vars -v
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 29286: Fix BUILD files in apache.aurora.admin and apache.aurora.client.api.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29286/#review65729
---

Ship it!


Ship It!

- Joe Smith


On Dec. 19, 2014, 7:05 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29286/
> ---
> 
> (Updated Dec. 19, 2014, 7:05 p.m.)
> 
> 
> Review request for Aurora and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix BUILD files in apache.aurora.admin and apache.aurora.client.api.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/BUILD 
> f874264bdf07a9cbb2f0990739be3c95f851b040 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> 8fa5182fae509493def7175635fbe1cb79fa3eec 
>   src/main/python/apache/aurora/client/api/BUILD 
> 65e5a85e23c4c698356c8b45c45943e560c1bcd5 
>   src/main/python/apache/aurora/client/api/command_runner.py 
> 48cb567c2098620e0ee322fe9528e167ce7c7c62 
>   src/main/python/apache/aurora/client/api/disambiguator.py 
> 6a78ccd44533ef327f751a08c9e2e16555354d97 
>   src/test/python/apache/aurora/admin/BUILD 
> 3a216809d1e31247f7d01451fcc7fd877a4c1fb2 
>   src/test/python/apache/aurora/client/api/BUILD 
> 2c0c4070cc1f1784b1d4e7f9cd8aac236e97be75 
>   src/test/python/apache/aurora/client/api/test_task_util.py 
> 048aff6874259810efea463df1ca2a1fdc419ca1 
> 
> Diff: https://reviews.apache.org/r/29286/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 29423: Fixes typo in Developing Aurora Client documentation.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29423/#review66166
---

Ship it!


Ship It!

- Joe Smith


On Dec. 25, 2014, 10:16 p.m., Dave Lester wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29423/
> ---
> 
> (Updated Dec. 25, 2014, 10:16 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fixes typo in Developing Aurora Client documentation.
> 
> 
> Diffs
> -
> 
>   docs/developing-aurora-client.md b9912bce44d65ddd7f1e35f0ea9356a89d5fe767 
> 
> Diff: https://reviews.apache.org/r/29423/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dave Lester
> 
>

Re: Review Request 29426: Fixes markdown formatting in Vagrant documentation.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29426/#review66167
---

Ship it!


Ship It!

- Joe Smith


On Dec. 25, 2014, 11:28 p.m., Dave Lester wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29426/
> ---
> 
> (Updated Dec. 25, 2014, 11:28 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fixes markdown formatting in Vagrant documentation.
> 
> 
> Diffs
> -
> 
>   docs/vagrant.md c3632eebfe4c65d7dec6fd6cd02b45308691914d 
> 
> Diff: https://reviews.apache.org/r/29426/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dave Lester
> 
>

Re: Review Request 29866: Upgrade pants to 0.0.27

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/#review67987
---

Ship it!


Rad


pants
<https://reviews.apache.org/r/29866/#comment112102>

good idea


- Joe Smith


On Jan. 13, 2015, 4:15 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29866/
> ---
> 
> (Updated Jan. 13, 2015, 4:15 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Ports aurora repo to use pants 0.0.27 using the new pants new command 
> processor.
> 
> 
> Diffs
> -
> 
>   .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 
>   build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
>   build-support/pants_requirements.txt 
> 9a790f973cc7560980d43d5a1097338ff88a0397 
>   build-support/python/make-pycharm-virtualenv 
> 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 
>   build-support/python/update-pants-requirements 
> 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 
>   build-support/release/make-python-sdists 
> 2f437d33928cc429a79aedb00247d472953fbb95 
>   docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd 
>   examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
>   pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
>   src/main/python/apache/aurora/executor/common/resource_manager.py 
> bf69e7e60ae4dd857243d8b040a70daca008ea28 
>   
> src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py
>  e3c766f9b7bf989c0790281231957947d2cda52a 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
> f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c 
> 
> Diff: https://reviews.apache.org/r/29866/diff/
> 
> 
> Testing
> ---
> 
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 29171: Fix test_executor_vars so that it doesn't attempt to get a real PEX-INFO.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29171/#review70692
---


/nudge

- Joe Smith


On Dec. 17, 2014, 12:31 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29171/
> ---
> 
> (Updated Dec. 17, 2014, 12:31 p.m.)
> 
> 
> Review request for Aurora and Joe Smith.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix test_executor_vars so that it doesn't attempt to get a real PEX-INFO.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/executor_vars.py 
> 7c018271724ffab2ff6930e5802a48b50a39dded 
>   src/test/python/apache/aurora/executor/BUILD 
> 3095f2a148b21365ea2f500039adb5710a187fa1 
>   src/test/python/apache/aurora/executor/test_executor_vars.py 
> af1c7b7d78b89ae713d6db96cf766b596fa91c55 
> 
> Diff: https://reviews.apache.org/r/29171/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python/apache/aurora/executor:executor_vars -v
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Review Request 30649: Upgrade pants to 0.0.28

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30649/
---

Review request for Aurora and Brian Wickman.


Bugs: AURORA-1104
https://issues.apache.org/jira/browse/AURORA-1104


Repository: aurora


Description
---

Upgrade pants to 0.0.28


Diffs
-

  .pantsversion 24ff85581f81976c5f70fe1a8c3c0f62b5275c91 
  build-support/pants_requirements.txt fb9a2d2dd5f17b3523eea1e4a7a77d69feddff39 

Diff: https://reviews.apache.org/r/30649/diff/


Testing
---

Reviewed the diff [for 
twitter/commons](https://github.com/twitter/commons/commit/574d79891d74a3a142e1db6b085b4c7e13c67659#diff-570e3786705ee6965f4f2f72c715382bR194)
 and

```
$ ./pants test.pytest --no-fast ./src/test/python/apache/aurora:all
```


Thanks,

Joe Smith

Re: Review Request 30649: Upgrade pants to 0.0.28

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30649/
---

(Updated Feb. 4, 2015, 8:07 p.m.)


Review request for Aurora and Brian Wickman.


Bugs: AURORA-1104
https://issues.apache.org/jira/browse/AURORA-1104


Repository: aurora


Description (updated)
---

Upgrade pants to 0.0.28

pants
=

[0.0.28 changelog](https://pypi.python.org/pypi/pantsbuild.pants/0.0.28) and 
selected highlights:

* bump virtualenv version to 12.0.5 RB #1621
* Make ‘setup-py’ show up in ‘./pants goal goals’ RB #1466
* Support use of pytest’s –pdb mode RB #1570
* Upgrade pex dependency to 0.8.4

Pick up several perf wins
Pick up fix that allows pex to read older pexes
RB #1648 RB #1693
* Refactor setting of PYTHONPATH in pants.ini RB #1586


Diffs
-

  .pantsversion 24ff85581f81976c5f70fe1a8c3c0f62b5275c91 
  build-support/pants_requirements.txt fb9a2d2dd5f17b3523eea1e4a7a77d69feddff39 

Diff: https://reviews.apache.org/r/30649/diff/


Testing (updated)
---

Reviewed the diff [for 
twitter/commons](https://github.com/twitter/commons/commit/574d79891d74a3a142e1db6b085b4c7e13c67659#diff-570e3786705ee6965f4f2f72c715382bR194)

```
$ ./pants test.pytest --no-fast ./src/test/python/apache/aurora:all
```


Thanks,

Joe Smith