[GitHub] [helix] github-actions[bot] commented on issue #2599: [Failed CI Test] testWorkflowRunningTime(org.apache.helix.integration.task.TestWorkflowTimeout)

2023-09-03 Thread via GitHub
github-actions[bot] commented on issue #2599: URL: https://github.com/apache/helix/issues/2599#issuecomment-1704318268 This test fails in: https://github.com/apache/helix/actions/runs/6064343585 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] github-actions[bot] commented on issue #2572: [Failed CI Test] testIncreaseResourcePartitionWeight(org.apache.helix.integration.rebalancer.WagedRebalancer.TestWagedClusterExpansion)

2023-09-02 Thread via GitHub
github-actions[bot] commented on issue #2572: URL: https://github.com/apache/helix/issues/2572#issuecomment-1703989872 This test fails in: https://github.com/apache/helix/actions/runs/6061302555 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] github-actions[bot] commented on issue #2545: [Failed CI Test] testAggregateMetrics(org.apache.helix.monitoring.mbeans.TestClusterAggregateMetrics)

2023-09-02 Thread via GitHub
github-actions[bot] commented on issue #2545: URL: https://github.com/apache/helix/issues/2545#issuecomment-1703989871 This test fails in: https://github.com/apache/helix/actions/runs/6061302555 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] xyuanlu commented on pull request #2611: [apache/helix] -- fixes #2590 Changed Log level to DEBUG for the top-state metrics logs.

2023-09-05 Thread via GitHub
xyuanlu commented on PR #2611: URL: https://github.com/apache/helix/pull/2611#issuecomment-1707137119 Just wondering, any particular reason why we want to change to debug level? From this PR https://github.com/apache/helix/pull/2603#discussion_r1302269166, it looks like the log is not

[GitHub] [helix] jadami10 commented on issue #2594: On-demand Rebalance API

2023-09-05 Thread via GitHub
jadami10 commented on issue #2594: URL: https://github.com/apache/helix/issues/2594#issuecomment-1707161980 Pinot actually picked up the latest version of helix [last week](https://github.com/apache/pinot/pull/11450). But my question was more around what necessitated this feature, if you

[GitHub] [helix] himanshukandwal commented on pull request #2611: [apache/helix] -- fixes #2590 Changed Log level to DEBUG for the top-state metrics logs.

2023-09-05 Thread via GitHub
himanshukandwal commented on PR #2611: URL: https://github.com/apache/helix/pull/2611#issuecomment-1707269928 > Just wondering, any particular reason why we want to change to debug level? From this PR [#2603 (comment)](https://github.com/apache/helix/pull/2603#discussion_r1302269166), it

[GitHub] [helix] jiajunwang commented on issue #2594: On-demand Rebalance API

2023-09-05 Thread via GitHub
jiajunwang commented on issue #2594: URL: https://github.com/apache/helix/issues/2594#issuecomment-1707384167 Delayed time window is configurable, I think setting up a small (or zero) delayed time window resolves your problem? Best Regards, Jiajun On Tue, Sep 5, 2023

[GitHub] [helix] MarkGaox commented on a diff in pull request #2587: Fix flaky test TestP2PNoDuplicatedMessage

2023-09-05 Thread via GitHub
MarkGaox commented on code in PR #2587: URL: https://github.com/apache/helix/pull/2587#discussion_r1316708010 ## helix-core/src/test/java/org/apache/helix/integration/messaging/TestP2PNoDuplicatedMessage.java: ## @@ -159,25 +159,38 @@ public void

[GitHub] [helix] github-actions[bot] commented on issue #2582: [Failed CI Test] testDeleteJob(org.apache.helix.rest.server.TestJobAccessor)

2023-09-04 Thread via GitHub
github-actions[bot] commented on issue #2582: URL: https://github.com/apache/helix/issues/2582#issuecomment-1705866634 This test fails in: https://github.com/apache/helix/actions/runs/6078652773 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] xyuanlu commented on a diff in pull request #2612: MetaClientCache API's

2023-09-06 Thread via GitHub
xyuanlu commented on code in PR #2612: URL: https://github.com/apache/helix/pull/2612#discussion_r1318031465 ## meta-client/src/main/java/org/apache/helix/metaclient/api/MetaClientCacheInterface.java: ## @@ -0,0 +1,56 @@ +package org.apache.helix.metaclient.api; + +/* + *

[GitHub] [helix] xyuanlu commented on a diff in pull request #2612: MetaClientCache API's

2023-09-06 Thread via GitHub
xyuanlu commented on code in PR #2612: URL: https://github.com/apache/helix/pull/2612#discussion_r1318030880 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClientCache.java: ## @@ -0,0 +1,121 @@ +package org.apache.helix.metaclient.impl.zk; + +/* + *

[GitHub] [helix] xyuanlu commented on a diff in pull request #2612: MetaClientCache API's

2023-09-06 Thread via GitHub
xyuanlu commented on code in PR #2612: URL: https://github.com/apache/helix/pull/2612#discussion_r1318030563 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClientCache.java: ## @@ -0,0 +1,121 @@ +package org.apache.helix.metaclient.impl.zk; + +/* + *

[GitHub] [helix] xyuanlu commented on a diff in pull request #2612: MetaClientCache API's

2023-09-06 Thread via GitHub
xyuanlu commented on code in PR #2612: URL: https://github.com/apache/helix/pull/2612#discussion_r1318031208 ## meta-client/src/main/java/org/apache/helix/metaclient/api/MetaClientCacheInterface.java: ## @@ -0,0 +1,56 @@ +package org.apache.helix.metaclient.api; + +/* + *

[GitHub] [helix] github-actions[bot] commented on issue #2551: [Failed CI Test] testP2PStateTransitionEnabled(org.apache.helix.integration.messaging.TestP2PNoDuplicatedMessage)

2023-09-06 Thread via GitHub
github-actions[bot] commented on issue #2551: URL: https://github.com/apache/helix/issues/2551#issuecomment-1709231412 This test fails in: https://github.com/apache/helix/actions/runs/6102235345 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] jadami10 commented on issue #2594: On-demand Rebalance API

2023-09-06 Thread via GitHub
jadami10 commented on issue #2594: URL: https://github.com/apache/helix/issues/2594#issuecomment-1709352953 yup this answers it! https://github.com/apache/pinot/pull/11509 does just that for Pinot. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [helix] xyuanlu merged pull request #2587: Fix flaky test TestP2PNoDuplicatedMessage

2023-09-06 Thread via GitHub
xyuanlu merged PR #2587: URL: https://github.com/apache/helix/pull/2587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [helix] xyuanlu commented on a diff in pull request #2612: MetaClientCache API's

2023-09-10 Thread via GitHub
xyuanlu commented on code in PR #2612: URL: https://github.com/apache/helix/pull/2612#discussion_r1321001219 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/factory/ZkMetaClientFactory.java: ## @@ -36,4 +38,17 @@ public MetaClientInterface

[GitHub] [helix] xyuanlu commented on a diff in pull request #2612: MetaClientCache API's

2023-09-10 Thread via GitHub
xyuanlu commented on code in PR #2612: URL: https://github.com/apache/helix/pull/2612#discussion_r1321001470 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClientCache.java: ## @@ -0,0 +1,104 @@ +package org.apache.helix.metaclient.impl.zk; + +/* + *

[GitHub] [helix] Jackie-Jiang opened a new issue, #2613: ZkBaseDataAccessor.doSet() cannot properly throw ZkBadVersionException

2023-09-10 Thread via GitHub
Jackie-Jiang opened a new issue, #2613: URL: https://github.com/apache/helix/issues/2613 See this comment: https://github.com/apache/helix/commit/654636e54268907deb2e12d32913455cc543b436#r126985918 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [helix] Marcosrico commented on a diff in pull request #2612: MetaClientCache API's

2023-09-11 Thread via GitHub
Marcosrico commented on code in PR #2612: URL: https://github.com/apache/helix/pull/2612#discussion_r1321779348 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClientCache.java: ## @@ -0,0 +1,104 @@ +package org.apache.helix.metaclient.impl.zk; + +/* + *

[GitHub] [helix] Marcosrico commented on a diff in pull request #2612: MetaClientCache API's

2023-09-11 Thread via GitHub
Marcosrico commented on code in PR #2612: URL: https://github.com/apache/helix/pull/2612#discussion_r1321778158 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/factory/ZkMetaClientFactory.java: ## @@ -36,4 +38,17 @@ public MetaClientInterface

[GitHub] [helix] desaikomal opened a new pull request, #2614: Fix the behavior when underlying ZK throws BadVersion exception

2023-09-11 Thread via GitHub
desaikomal opened a new pull request, #2614: URL: https://github.com/apache/helix/pull/2614 ### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: Fixes #2613 ### Description - [ ] Here are some details about my

[GitHub] [helix] GrantPSpencer commented on a diff in pull request #2607: Add method to create full key path if it does not exist

2023-09-11 Thread via GitHub
GrantPSpencer commented on code in PR #2607: URL: https://github.com/apache/helix/pull/2607#discussion_r1322070722 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -115,6 +118,86 @@ public void create(String key, Object data,

[GitHub] [helix] GrantPSpencer commented on a diff in pull request #2607: Add method to create full key path if it does not exist

2023-09-11 Thread via GitHub
GrantPSpencer commented on code in PR #2607: URL: https://github.com/apache/helix/pull/2607#discussion_r1322070270 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -115,6 +118,86 @@ public void create(String key, Object data,

[GitHub] [helix] xyuanlu commented on a diff in pull request #2612: MetaClientCache API's

2023-09-11 Thread via GitHub
xyuanlu commented on code in PR #2612: URL: https://github.com/apache/helix/pull/2612#discussion_r1322092359 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/factory/ZkMetaClientFactory.java: ## @@ -36,4 +38,17 @@ public MetaClientInterface

[GitHub] [helix] xyuanlu commented on a diff in pull request #2612: MetaClientCache API's

2023-09-11 Thread via GitHub
xyuanlu commented on code in PR #2612: URL: https://github.com/apache/helix/pull/2612#discussion_r1322091003 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClientCache.java: ## @@ -0,0 +1,104 @@ +package org.apache.helix.metaclient.impl.zk; + +/* + *

[GitHub] [helix] desaikomal commented on pull request #2614: Fix the behavior when underlying ZK throws BadVersion exception

2023-09-11 Thread via GitHub
desaikomal commented on PR #2614: URL: https://github.com/apache/helix/pull/2614#issuecomment-1714838353 Thanks @xyuanlu for the review. This change is ready to be merged. Commit message: Fix the 'BadVersion' exception handling in doSet() code path. -- This is an automated message from

[GitHub] [helix] xyuanlu opened a new pull request, #2615: change operation orth to enable

2023-09-11 Thread via GitHub
xyuanlu opened a new pull request, #2615: URL: https://github.com/apache/helix/pull/2615 ### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: (#200 - Link your issue number here: You can write "Fixes #XXX". Please use the

[GitHub] [helix] Marcosrico commented on a diff in pull request #2612: MetaClientCache API's

2023-09-11 Thread via GitHub
Marcosrico commented on code in PR #2612: URL: https://github.com/apache/helix/pull/2612#discussion_r1322259647 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClientCache.java: ## @@ -0,0 +1,104 @@ +package org.apache.helix.metaclient.impl.zk; + +/* + *

[GitHub] [helix] github-actions[bot] commented on issue #2572: [Failed CI Test] testIncreaseResourcePartitionWeight(org.apache.helix.integration.rebalancer.WagedRebalancer.TestWagedClusterExpansion)

2023-09-14 Thread via GitHub
github-actions[bot] commented on issue #2572: URL: https://github.com/apache/helix/issues/2572#issuecomment-1718871255 This test fails in: https://github.com/apache/helix/actions/runs/6181052947 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] github-actions[bot] commented on issue #2573: [Failed CI Test] testEnqueueJobsThrottle(org.apache.helix.task.TestTaskCreateThrottling)

2023-09-13 Thread via GitHub
github-actions[bot] commented on issue #2573: URL: https://github.com/apache/helix/issues/2573#issuecomment-1718655043 This test fails in: https://github.com/apache/helix/actions/runs/6179267136 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] junkaixue commented on a diff in pull request #2615: Change instance operation orthogonal to instance enable

2023-09-13 Thread via GitHub
junkaixue commented on code in PR #2615: URL: https://github.com/apache/helix/pull/2615#discussion_r1325349306 ## helix-core/src/main/java/org/apache/helix/controller/rebalancer/DelayedAutoRebalancer.java: ## @@ -194,6 +200,17 @@ public IdealState computeNewIdealState(String

[GitHub] [helix] junkaixue merged pull request #2280: Bump jackson-databind from 2.12.6.1 to 2.12.7.1 in /helix-view-aggregator

2023-09-13 Thread via GitHub
junkaixue merged PR #2280: URL: https://github.com/apache/helix/pull/2280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [helix] junkaixue commented on a diff in pull request #2607: Add method to create full key path if it does not exist

2023-09-13 Thread via GitHub
junkaixue commented on code in PR #2607: URL: https://github.com/apache/helix/pull/2607#discussion_r1325342670 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -115,6 +118,86 @@ public void create(String key, Object data,

[GitHub] [helix] junkaixue commented on a diff in pull request #2607: Add method to create full key path if it does not exist

2023-09-13 Thread via GitHub
junkaixue commented on code in PR #2607: URL: https://github.com/apache/helix/pull/2607#discussion_r1325343901 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/util/ZkMetaClientUtil.java: ## @@ -358,4 +358,25 @@ public static MetaClientException.ReturnCode

[GitHub] [helix] github-actions[bot] commented on issue #2438: [Failed CI Test] testHelixViewAggregator(org.apache.helix.view.integration.TestHelixViewAggregator)

2023-09-14 Thread via GitHub
github-actions[bot] commented on issue #2438: URL: https://github.com/apache/helix/issues/2438#issuecomment-1719545113 This test fails in: https://github.com/apache/helix/actions/runs/6185176187 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] xyuanlu commented on pull request #2615: Change instance operation orthogonal to instance enable

2023-09-16 Thread via GitHub
xyuanlu commented on PR #2615: URL: https://github.com/apache/helix/pull/2615#issuecomment-1722264189 This change has been approved by @junkaixue Commit message: Change instance operation orthogonal to instance enable -- This is an automated message from the Apache Git Service. To

[GitHub] [helix] himanshukandwal opened a new issue, #2616: [Testing] -- Improve Helix CI Tests Performance and Structure.

2023-09-16 Thread via GitHub
himanshukandwal opened a new issue, #2616: URL: https://github.com/apache/helix/issues/2616 **Is your feature request related to a problem? Please describe.** Helix CI Test Source code has organically grown a lot, with lot of boilerplate code that can be simplified and organized in way

[GitHub] [helix] himanshukandwal commented on a diff in pull request #2617: [apache/helix] -- Fixed #2616, Simplified Test Code structure.

2023-09-16 Thread via GitHub
himanshukandwal commented on code in PR #2617: URL: https://github.com/apache/helix/pull/2617#discussion_r1328008122 ## helix-core/src/test/java/org/apache/helix/TestHelixConfigAccessor.java: ## @@ -30,7 +31,7 @@ import org.testng.Assert; import org.testng.annotations.Test;

[GitHub] [helix] himanshukandwal opened a new pull request, #2617: [apache/helix] -- Fixed #2616, Simplified Test Code structure.

2023-09-16 Thread via GitHub
himanshukandwal opened a new pull request, #2617: URL: https://github.com/apache/helix/pull/2617 ### Issues - [X] My PR addresses the following Helix issues and references them in the PR description: #2616 ### Description - [x] Here are some details about my PR,

[GitHub] [helix] xyuanlu merged pull request #2615: Change instance operation orthogonal to instance enable

2023-09-16 Thread via GitHub
xyuanlu merged PR #2615: URL: https://github.com/apache/helix/pull/2615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [helix] xyuanlu merged pull request #2602: Fix TestClusterAggregateMetrics

2023-09-16 Thread via GitHub
xyuanlu merged PR #2602: URL: https://github.com/apache/helix/pull/2602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [helix] zpinto commented on a diff in pull request #2610: Change TopStateHandoffReportStage to be an Async Stage

2023-08-31 Thread via GitHub
zpinto commented on code in PR #2610: URL: https://github.com/apache/helix/pull/2610#discussion_r1312184466 ## helix-core/src/test/java/org/apache/helix/controller/stages/BaseStageTest.java: ## @@ -209,7 +210,11 @@ protected void runStage(ClusterEvent event, Stage stage) {

[GitHub] [helix] zpinto commented on a diff in pull request #2610: Change TopStateHandoffReportStage to be an Async Stage

2023-08-31 Thread via GitHub
zpinto commented on code in PR #2610: URL: https://github.com/apache/helix/pull/2610#discussion_r1312082626 ## helix-core/src/test/java/org/apache/helix/controller/stages/BaseStageTest.java: ## @@ -209,7 +210,11 @@ protected void runStage(ClusterEvent event, Stage stage) {

[GitHub] [helix] zpinto commented on pull request #2610: Change TopStateHandoffReportStage to be an Async Stage

2023-08-31 Thread via GitHub
zpinto commented on PR #2610: URL: https://github.com/apache/helix/pull/2610#issuecomment-1701912245 This PR is ready to be merged. Final Commit Message: In some cases TopStateHandoffReportStage is taking a very long portion of the total pipeline execution time. In order to speed

[GitHub] [helix] himanshukandwal opened a new pull request, #2611: [apache/helix] -- fixes #2590 Changed Log level to DEBUG for the top-state metrics logs.

2023-08-31 Thread via GitHub
himanshukandwal opened a new pull request, #2611: URL: https://github.com/apache/helix/pull/2611 ### Issues - [x] My PR addresses the following Helix issues and references them in the PR description: #2590 ### Description - [x] Here are some details about my PR,

[GitHub] [helix] GrantPSpencer commented on a diff in pull request #2607: Add method to create full key path if it does not exist

2023-08-31 Thread via GitHub
GrantPSpencer commented on code in PR #2607: URL: https://github.com/apache/helix/pull/2607#discussion_r1312382899 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -115,6 +117,42 @@ public void create(String key, Object data,

[GitHub] [helix] github-actions[bot] commented on issue #2599: [Failed CI Test] testWorkflowRunningTime(org.apache.helix.integration.task.TestWorkflowTimeout)

2023-08-31 Thread via GitHub
github-actions[bot] commented on issue #2599: URL: https://github.com/apache/helix/issues/2599#issuecomment-1702035474 This test fails in: https://github.com/apache/helix/actions/runs/6043798268 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] github-actions[bot] commented on issue #2545: [Failed CI Test] testAggregateMetrics(org.apache.helix.monitoring.mbeans.TestClusterAggregateMetrics)

2023-08-31 Thread via GitHub
github-actions[bot] commented on issue #2545: URL: https://github.com/apache/helix/issues/2545#issuecomment-1702170478 This test fails in: https://github.com/apache/helix/actions/runs/6044963957 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] github-actions[bot] commented on issue #2599: [Failed CI Test] testWorkflowRunningTime(org.apache.helix.integration.task.TestWorkflowTimeout)

2023-08-31 Thread via GitHub
github-actions[bot] commented on issue #2599: URL: https://github.com/apache/helix/issues/2599#issuecomment-1702170480 This test fails in: https://github.com/apache/helix/actions/runs/6044963957 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] junkaixue merged pull request #2610: Change TopStateHandoffReportStage to be an Async Stage

2023-08-31 Thread via GitHub
junkaixue merged PR #2610: URL: https://github.com/apache/helix/pull/2610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [helix] junkaixue commented on a diff in pull request #2610: Change TopStateHandoffReportStage to be an Async Stage

2023-08-31 Thread via GitHub
junkaixue commented on code in PR #2610: URL: https://github.com/apache/helix/pull/2610#discussion_r1311908163 ## helix-core/src/test/java/org/apache/helix/controller/stages/BaseStageTest.java: ## @@ -209,7 +210,11 @@ protected void runStage(ClusterEvent event, Stage stage) {

[GitHub] [helix] github-actions[bot] commented on issue #2572: [Failed CI Test] testIncreaseResourcePartitionWeight(org.apache.helix.integration.rebalancer.WagedRebalancer.TestWagedClusterExpansion)

2023-09-01 Thread via GitHub
github-actions[bot] commented on issue #2572: URL: https://github.com/apache/helix/issues/2572#issuecomment-1703649738 This test fails in: https://github.com/apache/helix/actions/runs/6055128600 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] junkaixue commented on a diff in pull request #2609: Add support for providing default Instance Config to be used with auto-join and auto-reg

2023-09-01 Thread via GitHub
junkaixue commented on code in PR #2609: URL: https://github.com/apache/helix/pull/2609#discussion_r1313708994 ## helix-core/src/main/java/org/apache/helix/util/HelixUtil.java: ## @@ -533,21 +533,38 @@ public static long getSystemPropertyAsLong(String propertyKey, long

[GitHub] [helix] jadami10 commented on issue #2594: On-demand Rebalance API

2023-09-01 Thread via GitHub
jadami10 commented on issue #2594: URL: https://github.com/apache/helix/issues/2594#issuecomment-1703295557 @MarkGaox, I'm curious if this API is coming about for Pinot or some other system. I linked a Pinot issue to your PR as well -- This is an automated message from the Apache Git

[GitHub] [helix] xyuanlu merged pull request #2614: Fix the behavior when underlying ZK throws BadVersion exception

2023-09-12 Thread via GitHub
xyuanlu merged PR #2614: URL: https://github.com/apache/helix/pull/2614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [helix] xyuanlu closed issue #2613: ZkBaseDataAccessor.doSet() cannot properly throw ZkBadVersionException

2023-09-12 Thread via GitHub
xyuanlu closed issue #2613: ZkBaseDataAccessor.doSet() cannot properly throw ZkBadVersionException URL: https://github.com/apache/helix/issues/2613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [helix] github-actions[bot] commented on issue #2582: [Failed CI Test] testDeleteJob(org.apache.helix.rest.server.TestJobAccessor)

2023-09-12 Thread via GitHub
github-actions[bot] commented on issue #2582: URL: https://github.com/apache/helix/issues/2582#issuecomment-1715816875 This test fails in: https://github.com/apache/helix/actions/runs/6159171052 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] xyuanlu commented on a diff in pull request #2612: MetaClientCache API's

2023-09-12 Thread via GitHub
xyuanlu commented on code in PR #2612: URL: https://github.com/apache/helix/pull/2612#discussion_r1323293082 ## meta-client/src/main/java/org/apache/helix/metaclient/factories/MetaClientCacheConfig.java: ## @@ -0,0 +1,52 @@ +package org.apache.helix.metaclient.factories; + +/*

[GitHub] [helix] Marcosrico commented on a diff in pull request #2612: MetaClientCache API's

2023-09-12 Thread via GitHub
Marcosrico commented on code in PR #2612: URL: https://github.com/apache/helix/pull/2612#discussion_r1323511788 ## meta-client/src/main/java/org/apache/helix/metaclient/factories/MetaClientCacheConfig.java: ## @@ -0,0 +1,52 @@ +package org.apache.helix.metaclient.factories; +

[GitHub] [helix] Marcosrico commented on pull request #2612: MetaClientCache API's

2023-09-12 Thread via GitHub
Marcosrico commented on PR #2612: URL: https://github.com/apache/helix/pull/2612#issuecomment-1716359780 PR approved by @xyuanlu Commit message: MetaClientCache Part 1 - API's, configs, and builders -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [helix] xyuanlu commented on a diff in pull request #2612: MetaClientCache API's

2023-09-12 Thread via GitHub
xyuanlu commented on code in PR #2612: URL: https://github.com/apache/helix/pull/2612#discussion_r1323522423 ## meta-client/src/main/java/org/apache/helix/metaclient/factories/MetaClientFactory.java: ## @@ -49,4 +50,20 @@ public MetaClientInterface

[GitHub] [helix] xyuanlu merged pull request #2612: MetaClientCache API's

2023-09-12 Thread via GitHub
xyuanlu merged PR #2612: URL: https://github.com/apache/helix/pull/2612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [helix] github-actions[bot] commented on issue #2571: [Failed CI Test] testExists(org.apache.helix.rest.server.TestZooKeeperAccessor)

2023-09-13 Thread via GitHub
github-actions[bot] commented on issue #2571: URL: https://github.com/apache/helix/issues/2571#issuecomment-1717741746 This test fails in: https://github.com/apache/helix/actions/runs/6172200183 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] junkaixue commented on a diff in pull request #2615: Change instance operation orthogonal to instance enable

2023-09-13 Thread via GitHub
junkaixue commented on code in PR #2615: URL: https://github.com/apache/helix/pull/2615#discussion_r1324845689 ## helix-core/src/main/java/org/apache/helix/controller/rebalancer/DelayedAutoRebalancer.java: ## @@ -193,6 +197,14 @@ public IdealState computeNewIdealState(String

[GitHub] [helix] github-actions[bot] commented on issue #2498: [Failed CI Test] testDistributedController(org.apache.helix.integration.manager.TestConsecutiveZkSessionExpiry)

2023-09-07 Thread via GitHub
github-actions[bot] commented on issue #2498: URL: https://github.com/apache/helix/issues/2498#issuecomment-1710228640 This test fails in: https://github.com/apache/helix/actions/runs/6109465685 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] Marcosrico commented on pull request #2612: MetaClientCache API's

2023-09-07 Thread via GitHub
Marcosrico commented on PR #2612: URL: https://github.com/apache/helix/pull/2612#issuecomment-1710818643 After an offline discussion we agreed on a couple comments for this design: 1. There is no need for the apis (start, close, and rebuild cache) in the MetaClientCacheInterface, as

[GitHub] [helix] junkaixue commented on a diff in pull request #2607: Add method to create full key path if it does not exist

2023-09-07 Thread via GitHub
junkaixue commented on code in PR #2607: URL: https://github.com/apache/helix/pull/2607#discussion_r1319081463 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -115,6 +118,86 @@ public void create(String key, Object data,

[GitHub] [helix] github-actions[bot] commented on issue #2498: [Failed CI Test] testDistributedController(org.apache.helix.integration.manager.TestConsecutiveZkSessionExpiry)

2023-09-09 Thread via GitHub
github-actions[bot] commented on issue #2498: URL: https://github.com/apache/helix/issues/2498#issuecomment-1712520816 This test fails in: https://github.com/apache/helix/actions/runs/6130759938 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] zpinto opened a new pull request, #2610: Change TopStateHandoffReportStage to be an Async Stage

2023-08-31 Thread via GitHub
zpinto opened a new pull request, #2610: URL: https://github.com/apache/helix/pull/2610 Change TopStateHandoffReportStage to be an Async Stage as it is the slowest stage in the pipeline. ### Description In some cases TopStateHandoffReportStage is taking up to 1/3 of the total

[GitHub] [helix] github-actions[bot] commented on issue #2438: [Failed CI Test] testHelixViewAggregator(org.apache.helix.view.integration.TestHelixViewAggregator)

2023-08-30 Thread via GitHub
github-actions[bot] commented on issue #2438: URL: https://github.com/apache/helix/issues/2438#issuecomment-1700280312 This test fails in: https://github.com/apache/helix/actions/runs/6031434164 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] junkaixue commented on a diff in pull request #2609: Add support for providing default Instance Config to be used with auto-join and auto-reg

2023-08-29 Thread via GitHub
junkaixue commented on code in PR #2609: URL: https://github.com/apache/helix/pull/2609#discussion_r1309463509 ## helix-core/src/main/java/org/apache/helix/HelixManagerProperty.java: ## @@ -55,12 +58,13 @@ public HelixManagerProperty(Properties helixManagerProperties,

[GitHub] [helix] junkaixue commented on a diff in pull request #2607: Add method to create full key path if it does not exist

2023-08-29 Thread via GitHub
junkaixue commented on code in PR #2607: URL: https://github.com/apache/helix/pull/2607#discussion_r1309466872 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -115,6 +117,42 @@ public void create(String key, Object data,

[GitHub] [helix] junkaixue commented on a diff in pull request #2600: [apache/helix] -- Fixes #2596 Removed usage of FJP in identification of missing active node.

2023-08-29 Thread via GitHub
junkaixue commented on code in PR #2600: URL: https://github.com/apache/helix/pull/2600#discussion_r1309467652 ## helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java: ## @@ -450,22 +452,17 @@ protected Map emergencyRebalance(

[GitHub] [helix] github-actions[bot] commented on issue #2422: [Failed CI Test] testDifferentTasks(org.apache.helix.integration.task.TestIndependentTaskRebalancer)

2023-08-29 Thread via GitHub
github-actions[bot] commented on issue #2422: URL: https://github.com/apache/helix/issues/2422#issuecomment-1698392046 This test fails in: https://github.com/apache/helix/actions/runs/6018917961 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] MarkGaox commented on pull request #2602: Fix TestClusterAggregateMetrics

2023-09-13 Thread via GitHub
MarkGaox commented on PR #2602: URL: https://github.com/apache/helix/pull/2602#issuecomment-1718467773 Thanks @zpinto @xyuanlu for the review. This commit ready to be merged. Final Commit Message: Fix flaky test TestClusterAggregateMetrics -- This is an automated message from

[GitHub] [helix] Marcosrico opened a new pull request, #2612: MetaClientCache API's

2023-09-06 Thread via GitHub
Marcosrico opened a new pull request, #2612: URL: https://github.com/apache/helix/pull/2612 …ion. Just app's no impl. ### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: (#200 - Link your issue number here: You can

[GitHub] [helix] MarkGaox commented on issue #2594: On-demand Rebalance API

2023-09-06 Thread via GitHub
MarkGaox commented on issue #2594: URL: https://github.com/apache/helix/issues/2594#issuecomment-1709081211 Suppose that the delay window configuration is set to be 16 hours, the min active replica is 2, and the replication factor is 3. When a node is brought down for maintenance, it's

[GitHub] [helix] xyuanlu merged pull request #2611: [apache/helix] -- fixes #2590 Changed Log level to DEBUG for the top-state metrics logs.

2023-09-06 Thread via GitHub
xyuanlu merged PR #2611: URL: https://github.com/apache/helix/pull/2611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [helix] himanshukandwal commented on pull request #2611: [apache/helix] -- fixes #2590 Changed Log level to DEBUG for the top-state metrics logs.

2023-09-06 Thread via GitHub
himanshukandwal commented on PR #2611: URL: https://github.com/apache/helix/pull/2611#issuecomment-1709011832 This PR is ready to be merged. Final Commit Message: Changed Log level to DEBUG for the top-state metrics logs, to avoid logging for every partition. -- This is an

Re: [PR] Fix partitionAssignment API failing due to NPE when no resource config [helix]

2023-10-11 Thread via GitHub
GrantPSpencer commented on code in PR #2653: URL: https://github.com/apache/helix/pull/2653#discussion_r1355447583 ## helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ResourceAssignmentOptimizerAccessor.java: ## @@ -359,8 +359,10 @@ private void

Re: [PR] Fix partitionAssignment API failing due to NPE when no resource config [helix]

2023-10-11 Thread via GitHub
GrantPSpencer commented on code in PR #2653: URL: https://github.com/apache/helix/pull/2653#discussion_r1355519744 ## helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ResourceAssignmentOptimizerAccessor.java: ## @@ -359,8 +359,10 @@ private void

[I] Cross-zone Stoppable Check [helix]

2023-10-11 Thread via GitHub
MarkGaox opened a new issue, #2655: URL: https://github.com/apache/helix/issues/2655 **Is your feature request related to a problem? Please describe.** A clear and concise description of what the problem is. The current limitation of the stoppable check API restricts the evaluation of

Re: [PR] Fix partitionAssignment API failing due to NPE when no resource config [helix]

2023-10-11 Thread via GitHub
desaikomal commented on code in PR #2653: URL: https://github.com/apache/helix/pull/2653#discussion_r1355664729 ## helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ResourceAssignmentOptimizerAccessor.java: ## @@ -359,8 +359,10 @@ private void

Re: [PR] Fix partitionAssignment API failing due to NPE when no resource config [helix]

2023-10-11 Thread via GitHub
GrantPSpencer commented on code in PR #2653: URL: https://github.com/apache/helix/pull/2653#discussion_r1355521390 ## helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ResourceAssignmentOptimizerAccessor.java: ## @@ -359,8 +359,10 @@ private void

Re: [PR] Fix partitionAssignment API failing due to NPE when no resource config [helix]

2023-10-11 Thread via GitHub
desaikomal commented on code in PR #2653: URL: https://github.com/apache/helix/pull/2653#discussion_r1355480088 ## helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ResourceAssignmentOptimizerAccessor.java: ## @@ -359,8 +359,10 @@ private void

Re: [PR] Fix partitionAssignment API failing due to NPE when no resource config [helix]

2023-10-11 Thread via GitHub
desaikomal commented on code in PR #2653: URL: https://github.com/apache/helix/pull/2653#discussion_r1355314738 ## helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ResourceAssignmentOptimizerAccessor.java: ## @@ -359,8 +359,10 @@ private void

[PR] Refactor stoppable check logic for enhanced zone analysis [helix]

2023-10-11 Thread via GitHub
MarkGaox opened a new pull request, #2654: URL: https://github.com/apache/helix/pull/2654 ### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: (#200 - Link your issue number here: You can write "Fixes #XXX". Please use the

Re: [PR] Merge feature branch [helix]

2023-10-16 Thread via GitHub
xyuanlu merged PR #2647: URL: https://github.com/apache/helix/pull/2647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [Failed CI Test] testDeactivateCluster(org.apache.helix.tools.TestHelixAdminCli) [helix]

2023-10-16 Thread via GitHub
github-actions[bot] commented on issue #2642: URL: https://github.com/apache/helix/issues/2642#issuecomment-1765566231 This test fails in: https://github.com/apache/helix/actions/runs/6540799657 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Bump jackson-databind from 2.12.6.1 to 2.12.7.1 in /helix-rest [helix]

2023-10-13 Thread via GitHub
xyuanlu closed pull request #2281: Bump jackson-databind from 2.12.6.1 to 2.12.7.1 in /helix-rest URL: https://github.com/apache/helix/pull/2281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump jackson-databind from 2.12.6.1 to 2.12.7.1 in /helix-rest [helix]

2023-10-13 Thread via GitHub
dependabot[bot] commented on PR #2281: URL: https://github.com/apache/helix/pull/2281#issuecomment-1761769388 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Bump tree-kill from 1.2.0 to 1.2.2 in /helix-front [helix]

2023-10-13 Thread via GitHub
xyuanlu closed pull request #2156: Bump tree-kill from 1.2.0 to 1.2.2 in /helix-front URL: https://github.com/apache/helix/pull/2156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump tree-kill from 1.2.0 to 1.2.2 in /helix-front [helix]

2023-10-13 Thread via GitHub
dependabot[bot] commented on PR #2156: URL: https://github.com/apache/helix/pull/2156#issuecomment-1761769445 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Bump jackson-databind from 2.12.6.1 to 2.12.7.1 in /zookeeper-api [helix]

2023-10-13 Thread via GitHub
xyuanlu closed pull request #2283: Bump jackson-databind from 2.12.6.1 to 2.12.7.1 in /zookeeper-api URL: https://github.com/apache/helix/pull/2283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Bump jackson-databind from 2.12.6.1 to 2.12.7.1 in /zookeeper-api [helix]

2023-10-13 Thread via GitHub
dependabot[bot] commented on PR #2283: URL: https://github.com/apache/helix/pull/2283#issuecomment-1761769233 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Bump jackson-databind from 2.12.6.1 to 2.12.7.1 in /metadata-store-directory-common [helix]

2023-10-13 Thread via GitHub
xyuanlu closed pull request #2282: Bump jackson-databind from 2.12.6.1 to 2.12.7.1 in /metadata-store-directory-common URL: https://github.com/apache/helix/pull/2282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Bump jackson-databind from 2.12.6.1 to 2.12.7.1 in /metadata-store-directory-common [helix]

2023-10-13 Thread via GitHub
dependabot[bot] commented on PR #2282: URL: https://github.com/apache/helix/pull/2282#issuecomment-1761769293 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Bump jackson-databind from 2.12.6.1 to 2.12.7.1 in /helix-core [helix]

2023-10-13 Thread via GitHub
xyuanlu closed pull request #2284: Bump jackson-databind from 2.12.6.1 to 2.12.7.1 in /helix-core URL: https://github.com/apache/helix/pull/2284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump jackson-databind from 2.12.6.1 to 2.12.7.1 in /helix-core [helix]

2023-10-13 Thread via GitHub
dependabot[bot] commented on PR #2284: URL: https://github.com/apache/helix/pull/2284#issuecomment-1761768778 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

  1   2   3   4   5   6   7   8   9   10   >