[Impala-ASF-CR] IMPALA-6969: add AC last queued cause to profile

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10731 ) Change subject: IMPALA-6969: add AC last queued cause to profile .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7141 (part 1): clean up handling of default/dummy partition

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10711 ) Change subject: IMPALA-7141 (part 1): clean up handling of default/dummy partition .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-7140 (part 2). Create skeleton for LocalFsTable

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10712 ) Change subject: IMPALA-7140 (part 2). Create skeleton for LocalFsTable .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10630 ) Change subject: IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog .. Patch Set 9: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-7141 (part 2). Extract interfaces for partition pruning without loading

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10631 ) Change subject: IMPALA-7141 (part 2). Extract interfaces for partition pruning without loading .. Patch Set 9: Build

[Impala-ASF-CR] IMPALA-7115: set a default THREAD RESERVATION LIMIT value

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10628 ) Change subject: IMPALA-7115: set a default THREAD_RESERVATION_LIMIT value .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7115: set a default THREAD RESERVATION LIMIT value

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10628 ) Change subject: IMPALA-7115: set a default THREAD_RESERVATION_LIMIT value .. IMPALA-7115: set a default

[Impala-ASF-CR] IMPALA-110 (part 1): Refactor ExecNode::buffer pool client

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10493 ) Change subject: IMPALA-110 (part 1): Refactor ExecNode::buffer_pool_client_ .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-110 (part 1): Refactor ExecNode::buffer pool client

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10493 ) Change subject: IMPALA-110 (part 1): Refactor ExecNode::buffer_pool_client_ .. IMPALA-110 (part 1): Refactor

[Impala-ASF-CR] IMPALA-6969: add AC last queued cause to profile

2018-06-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10731 ) Change subject: IMPALA-6969: add AC last queued cause to profile .. Patch Set 6: Code-Review+2 Will do a dry run while waiting for

[Impala-ASF-CR] IMPALA-6969: add AC last queued cause to profile

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10731 ) Change subject: IMPALA-6969: add AC last queued cause to profile .. Patch Set 5: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6969: add AC last queued cause to profile

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10731 ) Change subject: IMPALA-6969: add AC last queued cause to profile .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-6969: add AC last queued cause to profile

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10731 ) Change subject: IMPALA-6969: add AC last queued cause to profile .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-1760: Implement shutdown command

2018-06-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/10744 ) Change subject: IMPALA-1760: Implement shutdown command .. IMPALA-1760: Implement shutdown command This allows graceful shutdown of

[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10668 ) Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests .. IMPALA-2746: part 1: enable LSAN for many

[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10668 ) Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests .. Patch Set 10: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10751 ) Change subject: IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed .. IMPALA-7182: [DOCS] Insecure

[Impala-ASF-CR] IMPALA-6969: add AC last queued cause to profile

2018-06-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10731 ) Change subject: IMPALA-6969: add AC last queued cause to profile .. Patch Set 5: Code-Review+2 Bikram, could you take another quick look

[Impala-ASF-CR] IMPALA-6969: add AC last queued cause to profile

2018-06-18 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10731 to look at the new patch set (#5). Change subject: IMPALA-6969: add AC last queued cause to profile ..

[Impala-ASF-CR] IMPALA-6969: add AC last queued cause to profile

2018-06-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10731 ) Change subject: IMPALA-6969: add AC last queued cause to profile .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7141 (part 1): clean up handling of default/dummy partition

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10711 ) Change subject: IMPALA-7141 (part 1): clean up handling of default/dummy partition .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10630 ) Change subject: IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 12: (4 comments) Looks

[Impala-ASF-CR] IMPALA-110 (part 2): Refactor PartitionedAggregationNode

2018-06-18 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 ) Change subject: IMPALA-110 (part 2): Refactor PartitionedAggregationNode .. Patch Set 2: > > I think that's probably unnecessary

[Impala-ASF-CR] IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10751 ) Change subject: IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7115: set a default THREAD RESERVATION LIMIT value

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10628 ) Change subject: IMPALA-7115: set a default THREAD_RESERVATION_LIMIT value .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-7115: set a default THREAD RESERVATION LIMIT value

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10628 ) Change subject: IMPALA-7115: set a default THREAD_RESERVATION_LIMIT value .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7115: set a default THREAD RESERVATION LIMIT value

2018-06-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10628 ) Change subject: IMPALA-7115: set a default THREAD_RESERVATION_LIMIT value .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed

2018-06-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10751 ) Change subject: IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7181: Fix flaky test shell/test shell commandline.py::TestImpalaShell::test socket opening

2018-06-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10747 ) Change subject: IMPALA-7181: Fix flaky test shell/test_shell_commandline.py::TestImpalaShell::test_socket_opening .. Patch Set 6:

[Impala-ASF-CR] IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed

2018-06-18 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10751 ) Change subject: IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed

2018-06-18 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10751 ) Change subject: IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed .. Patch Set 1: Fixed a nesting error -- To view,

[Impala-ASF-CR] IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed

2018-06-18 Thread Alex Rodoni (Code Review)
Hello Michael Ho, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10751 to look at the new patch set (#2). Change subject: IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed

[Impala-ASF-CR] IMPALA-6969: add AC last queued cause to profile

2018-06-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10731 ) Change subject: IMPALA-6969: add AC last queued cause to profile .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7151: Rework ephemeral port assignment for be tests

2018-06-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10740 ) Change subject: IMPALA-7151: Rework ephemeral port assignment for be tests .. Patch Set 2: This is stacked on top of

[Impala-ASF-CR] IMPALA-7169: Prevent HDFS from checkpointing trash until 3000 AD

2018-06-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10742 ) Change subject: IMPALA-7169: Prevent HDFS from checkpointing trash until 3000 AD .. Patch Set 2: Code-Review+1 I'm a little late to

[Impala-ASF-CR] IMPALA-6969: add AC last queued cause to profile

2018-06-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10731 ) Change subject: IMPALA-6969: add AC last queued cause to profile .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-6969: add AC last queued cause to profile

2018-06-18 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10731 to look at the new patch set (#4). Change subject: IMPALA-6969: add AC last queued cause to profile ..

[Impala-ASF-CR] IMPALA-7046: introduce "global" debug actions

2018-06-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10690 ) Change subject: IMPALA-7046: introduce "global" debug_actions .. Patch Set 8: i think this is ready for review again. -- To view, visit

[Impala-ASF-CR] IMPALA-7171: [DOCS] Hints for Kudu insert and upsert

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10737 ) Change subject: IMPALA-7171: [DOCS] Hints for Kudu insert and upsert .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7171: [DOCS] Hints for Kudu insert and upsert

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10737 ) Change subject: IMPALA-7171: [DOCS] Hints for Kudu insert and upsert .. IMPALA-7171: [DOCS] Hints for Kudu insert and

[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests

2018-06-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10442 ) Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. IMPALA-6802 (part 4): Clean up authorization tests The

[Impala-ASF-CR] IMPALA-7180: Pin Impala CDH dependencies

2018-06-18 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10748 Change subject: IMPALA-7180: Pin Impala CDH dependencies .. IMPALA-7180: Pin Impala CDH dependencies For profile=3 Pin the CDH

[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests

2018-06-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10442 ) Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. Patch Set 5: Seems ok to go ahead and merge. There haven't been

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-06-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 19: Are we ready to go ahead and merge? Would be good to

[Impala-ASF-CR] IMPALA-7171: [DOCS] Hints for Kudu insert and upsert

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10737 ) Change subject: IMPALA-7171: [DOCS] Hints for Kudu insert and upsert .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-7181: Fix flaky test shell/test shell commandline.py::TestImpalaShell::test socket opening

2018-06-18 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/10747 ) Change subject: IMPALA-7181: Fix flaky test shell/test_shell_commandline.py::TestImpalaShell::test_socket_opening .. Patch Set 6: (2

[Impala-ASF-CR] IMPALA-7181: Fix flaky test shell/test shell commandline.py::TestImpalaShell::test socket opening

2018-06-18 Thread Vincent Tran (Code Review)
Hello Philip Zeyliger, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10747 to look at the new patch set (#6). Change subject: IMPALA-7181: Fix flaky test shell/test_shell_commandline.py::TestImpalaShell::test_socket_opening

[Impala-ASF-CR] IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed

2018-06-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10751 ) Change subject: IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7046: introduce "global" debug actions

2018-06-18 Thread Dan Hecht (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10690 to look at the new patch set (#8). Change subject: IMPALA-7046: introduce "global" debug_actions .. IMPALA-7046:

[Impala-ASF-CR] IMPALA-7115: set a default THREAD RESERVATION LIMIT value

2018-06-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10628 ) Change subject: IMPALA-7115: set a default THREAD_RESERVATION_LIMIT value .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-7115: set a default THREAD RESERVATION LIMIT value

2018-06-18 Thread Tim Armstrong (Code Review)
Hello Csaba Ringhofer, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10628 to look at the new patch set (#3). Change subject: IMPALA-7115: set a default THREAD_RESERVATION_LIMIT value

[Impala-ASF-CR] IMPALA-7119: Restart whole minicluster when HDFS replication stalls

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10665 ) Change subject: IMPALA-7119: Restart whole minicluster when HDFS replication stalls .. Patch Set 4: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-7119: Restart whole minicluster when HDFS replication stalls

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10665 ) Change subject: IMPALA-7119: Restart whole minicluster when HDFS replication stalls .. IMPALA-7119: Restart whole

[Impala-ASF-CR] IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed

2018-06-18 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10751 Change subject: IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed .. IMPALA-7182: [DOCS] Insecure clusters with public

[Impala-ASF-CR] IMPALA-7161: Fix impala-config.sh's handling of JAVA HOME

2018-06-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10702 ) Change subject: IMPALA-7161: Fix impala-config.sh's handling of JAVA_HOME .. IMPALA-7161: Fix impala-config.sh's handling of

[Impala-ASF-CR] IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed by default

2018-06-18 Thread Alex Rodoni (Code Review)
Alex Rodoni has abandoned this change. ( http://gerrit.cloudera.org:8080/10750 ) Change subject: IMPALA-7182: [DOCS] Insecure clusters with public IPs not allowed by default .. Abandoned -- To view, visit

[Impala-ASF-CR] IMPALA-7161: Fix impala-config.sh's handling of JAVA HOME

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10702 ) Change subject: IMPALA-7161: Fix impala-config.sh's handling of JAVA_HOME .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-110 (part 1): Refactor ExecNode::buffer pool client

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10493 ) Change subject: IMPALA-110 (part 1): Refactor ExecNode::buffer_pool_client_ .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-110 (part 1): Refactor ExecNode::buffer pool client

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10493 ) Change subject: IMPALA-110 (part 1): Refactor ExecNode::buffer_pool_client_ .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-110 (part 2): Refactor PartitionedAggregationNode

2018-06-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 ) Change subject: IMPALA-110 (part 2): Refactor PartitionedAggregationNode .. Patch Set 2: > I think that's probably unnecessary (hopefully

[Impala-ASF-CR] IMPALA-6969: add AC last queued cause to profile

2018-06-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10731 ) Change subject: IMPALA-6969: add AC last queued cause to profile .. Patch Set 3: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-110 (part 1): Refactor ExecNode::buffer pool client

2018-06-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10493 ) Change subject: IMPALA-110 (part 1): Refactor ExecNode::buffer_pool_client_ .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6969: add AC last queued cause to profile

2018-06-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10731 ) Change subject: IMPALA-6969: add AC last queued cause to profile .. Patch Set 3: Carry +1 -- To view, visit

[Impala-ASF-CR] IMPALA-6969: add AC last queued cause to profile

2018-06-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10731 ) Change subject: IMPALA-6969: add AC last queued cause to profile .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-6969: add AC last queued cause to profile

2018-06-18 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10731 to look at the new patch set (#2). Change subject: IMPALA-6969: add AC last queued cause to profile ..

[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests

2018-06-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10668 ) Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests .. Patch Set 9: Ran ASAN tests one more time to make sure

[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10668 ) Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests .. Patch Set 10: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10668 ) Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-7181: Fix flaky test shell/test shell commandline.py::TestImpalaShell::test socket opening

2018-06-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10747 ) Change subject: IMPALA-7181: Fix flaky test shell/test_shell_commandline.py::TestImpalaShell::test_socket_opening .. Patch Set 3:

[Impala-ASF-CR] IMPALA-7046: introduce "global" debug actions

2018-06-18 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10690 ) Change subject: IMPALA-7046: introduce "global" debug_actions .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-7046: introduce "global" debug actions

2018-06-18 Thread Dan Hecht (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10690 to look at the new patch set (#7). Change subject: IMPALA-7046: introduce "global" debug_actions .. IMPALA-7046:

[Impala-ASF-CR] IMPALA-7171: [DOCS] Hints for Kudu insert and upsert

2018-06-18 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10737 ) Change subject: IMPALA-7171: [DOCS] Hints for Kudu insert and upsert .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7181: Fix flaky test shell/test shell commandline.py::TestImpalaShell::test socket opening

2018-06-18 Thread Vincent Tran (Code Review)
Hello Philip Zeyliger, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10747 to look at the new patch set (#5). Change subject: IMPALA-7181: Fix flaky test shell/test_shell_commandline.py::TestImpalaShell::test_socket_opening

[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6812: Fix flaky Kudu scan tests

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10503 ) Change subject: IMPALA-6812: Fix flaky Kudu scan tests .. IMPALA-6812: Fix flaky Kudu scan tests Many of our Kudu

[Impala-ASF-CR] IMPALA-7181: Fix flaky test shell/test shell commandline.py::TestImpalaShell::test socket opening

2018-06-18 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/10747 ) Change subject: IMPALA-7181: Fix flaky test shell/test_shell_commandline.py::TestImpalaShell::test_socket_opening .. Patch Set 4:

[Impala-ASF-CR] IMPALA-7181: Fix flaky test shell/test shell commandline.py::TestImpalaShell::test socket opening

2018-06-18 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/10747 ) Change subject: IMPALA-7181: Fix flaky test shell/test_shell_commandline.py::TestImpalaShell::test_socket_opening .. Patch Set 2: (2

[Impala-ASF-CR] IMPALA-7181: Fix flaky test shell/test shell commandline.py::TestImpalaShell::test socket opening

2018-06-18 Thread Vincent Tran (Code Review)
Hello Philip Zeyliger, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10747 to look at the new patch set (#3). Change subject: IMPALA-7181: Fix flaky test shell/test_shell_commandline.py::TestImpalaShell::test_socket_opening

[Impala-ASF-CR] IMPALA-7169: Prevent HDFS from checkpointing trash until 3000 AD

2018-06-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10742 ) Change subject: IMPALA-7169: Prevent HDFS from checkpointing trash until 3000 AD .. Patch Set 2: Code-Review+2 The flakiness

[Impala-ASF-CR] IMPALA-7181: Fix flaky test shell/test shell commandline.py::TestImpalaShell::test socket opening

2018-06-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10747 ) Change subject: IMPALA-7181: Fix flaky test shell/test_shell_commandline.py::TestImpalaShell::test_socket_opening .. Patch Set 2:

[Impala-ASF-CR] IMPALA-110 (part 2): Refactor PartitionedAggregationNode

2018-06-18 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 ) Change subject: IMPALA-110 (part 2): Refactor PartitionedAggregationNode .. Patch Set 2: > > (14 comments) > > > > While

[Impala-ASF-CR] IMPALA-7174: fix test cancellation for RELEASE builds

2018-06-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10722 ) Change subject: IMPALA-7174: fix test_cancellation for RELEASE builds .. Patch Set 4: I thought we weren't maintaining the branch.

[Impala-ASF-CR] IMPALA-7174: fix test cancellation for RELEASE builds

2018-06-18 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10722 ) Change subject: IMPALA-7174: fix test_cancellation for RELEASE builds .. Patch Set 4: Cherrypick to 2.x? (Not a clean pick) -- To

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-18 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 7: > Do we plan to port it to

[Impala-ASF-CR] IMPALA-7181: Fix flaky test shell/test shell commandline.py::TestImpalaShell::test socket opening

2018-06-18 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/10747 ) Change subject: IMPALA-7181: Fix flaky test shell/test_shell_commandline.py::TestImpalaShell::test_socket_opening .. Patch Set 1: (3

[Impala-ASF-CR] IMPALA-7181: Fix flaky test shell/test shell commandline.py::TestImpalaShell::test socket opening

2018-06-18 Thread Vincent Tran (Code Review)
Hello Philip Zeyliger, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10747 to look at the new patch set (#2). Change subject: IMPALA-7181: Fix flaky test shell/test_shell_commandline.py::TestImpalaShell::test_socket_opening

[Impala-ASF-CR] IMPALA-7169: Prevent HDFS from checkpointing trash until 3000 AD

2018-06-18 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10742 ) Change subject: IMPALA-7169: Prevent HDFS from checkpointing trash until 3000 AD .. Patch Set 2: > fyi, the build failure is related to

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-18 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 7: Do we plan to port it to 2.x?

[Impala-ASF-CR] IMPALA-7140 (part 5): support fetching file info for FS tables

2018-06-18 Thread Todd Lipcon (Code Review)
Hello Tianyi Wang, Vuk Ercegovac, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10749 to review the following change. Change subject: IMPALA-7140 (part 5): support fetching file info for FS tables

[Impala-ASF-CR] IMPALA-7140 (part 3): load partitions for FS tables

2018-06-18 Thread Todd Lipcon (Code Review)
Hello Tianyi Wang, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10713 to look at the new patch set (#4). Change subject: IMPALA-7140 (part 3): load partitions for FS tables

[Impala-ASF-CR] IMPALA-110 (part 1): Refactor ExecNode::buffer pool client

2018-06-18 Thread Thomas Marshall (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10493 to look at the new patch set (#4). Change subject: IMPALA-110 (part 1): Refactor ExecNode::buffer_pool_client_

[Impala-ASF-CR] IMPALA-110 (part 1): Refactor ExecNode::buffer pool client

2018-06-18 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10493 ) Change subject: IMPALA-110 (part 1): Refactor ExecNode::buffer_pool_client_ .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-110 (part 1): Refactor ExecNode::buffer pool client

2018-06-18 Thread Thomas Marshall (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10493 to look at the new patch set (#3). Change subject: IMPALA-110 (part 1): Refactor ExecNode::buffer_pool_client_

[Impala-ASF-CR] IMPALA-7181: Fix flaky test shell/test shell commandline.py::TestImpalaShell::test socket opening

2018-06-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10747 ) Change subject: IMPALA-7181: Fix flaky test shell/test_shell_commandline.py::TestImpalaShell::test_socket_opening .. Patch Set 1:

[Impala-ASF-CR] IMPALA-7140 (part 3): load partitions for FS tables

2018-06-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10713 ) Change subject: IMPALA-7140 (part 3): load partitions for FS tables .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-6969: add AC last queued cause to profile

2018-06-18 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10731 ) Change subject: IMPALA-6969: add AC last queued cause to profile .. Patch Set 1: Code-Review+1 (3 comments) lgtm, just a few nits.

[Impala-ASF-CR] IMPALA-7119: Restart whole minicluster when HDFS replication stalls

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10665 ) Change subject: IMPALA-7119: Restart whole minicluster when HDFS replication stalls .. Patch Set 4: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-7119: Restart whole minicluster when HDFS replication stalls

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10665 ) Change subject: IMPALA-7119: Restart whole minicluster when HDFS replication stalls .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-7161: Fix impala-config.sh's handling of JAVA HOME

2018-06-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10702 ) Change subject: IMPALA-7161: Fix impala-config.sh's handling of JAVA_HOME .. Patch Set 3: Build started:

  1   2   >