[Impala-ASF-CR] IMPALA-10184: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables

2020-10-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16512 ) Change subject: IMPALA-10184: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables .. Patch Set 7: (1 comment) I had to

[Impala-ASF-CR] IMPALA-10184: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables

2020-10-02 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, wangsheng, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16512 to look at the new patch set (#7). Change subject: IMPALA-10184: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables

[Impala-ASF-CR] IMPALA-10184: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables

2020-10-02 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, wangsheng, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16512 to look at the new patch set (#6). Change subject: IMPALA-10184: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables

[Impala-ASF-CR] IMPALA-10184: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables

2020-09-30 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, wangsheng, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16512 to look at the new patch set (#5). Change subject: IMPALA-10184: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables

[Impala-ASF-CR] IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables

2020-09-30 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16512 ) Change subject: IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables

2020-09-30 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, wangsheng, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16512 to look at the new patch set (#4). Change subject: IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables

[Impala-ASF-CR] IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables

2020-09-30 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, wangsheng, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16512 to look at the new patch set (#3). Change subject: IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-30 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 20: Code-Review+2 Those XFAIL failures can be

[Impala-ASF-CR] IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables

2020-09-29 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16512 ) Change subject: IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables

2020-09-29 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, wangsheng, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16512 to look at the new patch set (#2). Change subject: IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables

[Impala-ASF-CR] IMPALA-10175: Extend error msg when CAST(FORMAT) fails for DATE

2020-09-28 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16473 ) Change subject: IMPALA-10175: Extend error msg when CAST(FORMAT) fails for DATE .. IMPALA-10175: Extend error msg when

[Impala-ASF-CR] IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables

2020-09-28 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16512 Change subject: IMPALA-10187: Add PARTITON BY SPEC to SHOW CREATE TABLE for Iceberg Tables .. IMPALA-10187: Add PARTITON BY SPEC to

[Impala-ASF-CR] IMPALA-10175: Extend error msg when CAST(FORMAT) fails for DATE

2020-09-23 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16473 ) Change subject: IMPALA-10175: Extend error msg when CAST(FORMAT) fails for DATE .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-23 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 10: I see some Iceberg test related failures as

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 8: Code-Review+2 (2 comments) Thx for your

[Impala-ASF-CR] IMPALA-10175: Extend error msg when CAST(FORMAT) fails for DATE

2020-09-22 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16473 to look at the new patch set (#7). Change subject: IMPALA-10175: Extend error msg when CAST(FORMAT) fails for DATE

[Impala-ASF-CR] IMPALA-10175: Extend error msg when CAST(FORMAT) fails for DATE

2020-09-18 Thread Gabor Kaszab (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16473 to look at the new patch set (#4). Change subject: IMPALA-10175: Extend error msg when CAST(FORMAT) fails for DATE

[Impala-ASF-CR] IMPALA-10175: Extend error msg when CAST(FORMAT) fails for DATE

2020-09-18 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16473 ) Change subject: IMPALA-10175: Extend error msg when CAST(FORMAT) fails for DATE .. Patch Set 4: (2 comments) Carry +2 from Zoltan

[Impala-ASF-CR] IMPALA-10175: Extend error msg when CAST(FORMAT) fails for DATE

2020-09-18 Thread Gabor Kaszab (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16473 to look at the new patch set (#2). Change subject: IMPALA-10175: Extend error msg when CAST(FORMAT) fails for DATE

[Impala-ASF-CR] Generate test-classpath.txt

2020-09-18 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded a new patch set (#4) to the change originally created by Zoltan Borok-Nagy. ( http://gerrit.cloudera.org:8080/16450 ) Change subject: Generate test-classpath.txt .. Generate test-classpath.txt

[Impala-ASF-CR] IMPALA-10175: Extend error msg when CAST(FORMAT) fails for DATE

2020-09-18 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16473 Change subject: IMPALA-10175: Extend error msg when CAST(FORMAT) fails for DATE .. IMPALA-10175: Extend error msg when CAST(FORMAT)

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-17 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 2: (6 comments) Thanks for the changes! I have

[Impala-ASF-CR] [DOCS] Fix timezone related section in impala timestamp.xml

2020-09-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16432 ) Change subject: [DOCS] Fix timezone related section in impala_timestamp.xml .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-10164: Supporting HadoopCatalog for Iceberg table

2020-09-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 ) Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table .. Patch Set 1: (8 comments) Thanks for taking care of this

[Impala-ASF-CR] IMPALA-10012: ds hll sketch() results ascii codec decoding error fix

2020-09-05 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16418 ) Change subject: IMPALA-10012: ds_hll_sketch() results ascii codec decoding error fix .. IMPALA-10012: ds_hll_sketch() results

[Impala-ASF-CR] IMPALA-10012: ds hll sketch() results ascii codec decoding error fix

2020-09-05 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16418 ) Change subject: IMPALA-10012: ds_hll_sketch() results ascii codec decoding error fix .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10133:Implement ds hll stringify function.

2020-09-03 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16382 ) Change subject: IMPALA-10133:Implement ds_hll_stringify function. .. IMPALA-10133:Implement ds_hll_stringify function. This

[Impala-ASF-CR] IMPALA-10107:(1/3)Implement ds hll stringify function.

2020-09-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16382 ) Change subject: IMPALA-10107:(1/3)Implement ds_hll_stringify function. .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10107:(1/3)Implement ds hll stringify function.

2020-09-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16382 ) Change subject: IMPALA-10107:(1/3)Implement ds_hll_stringify function. .. Patch Set 1: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-10106: Upgrade DataSketches to version 2.1.0

2020-09-01 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16360 ) Change subject: IMPALA-10106: Upgrade DataSketches to version 2.1.0 .. Patch Set 5: Code-Review+2 Let's not wait further and merge

[Impala-ASF-CR] IMPALA-10108: Implement ds kll stringify function

2020-08-28 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16370 ) Change subject: IMPALA-10108: Implement ds_kll_stringify function .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10108: Implement ds kll stringify function

2020-08-27 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16370 ) Change subject: IMPALA-10108: Implement ds_kll_stringify function .. Patch Set 4: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-10108: Implement ds kll stringify function

2020-08-26 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16370 ) Change subject: IMPALA-10108: Implement ds_kll_stringify function .. Patch Set 3: (5 comments) For me reading this code review

[Impala-ASF-CR] IMPALA-10106: Upgrade DataSketches in be/src/thirdparty

2020-08-26 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16360 ) Change subject: IMPALA-10106: Upgrade DataSketches in be/src/thirdparty .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-9482 Support for BINARY columns

2020-08-26 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16066 ) Change subject: IMPALA-9482 Support for BINARY columns .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-10020: Implement ds kll cdf as string() function

2020-08-25 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16359 ) Change subject: IMPALA-10020: Implement ds_kll_cdf_as_string() function .. Patch Set 3: Code-Review+2 Carry +2 from Csaba -- To

[Impala-ASF-CR] IMPALA-10019: Implement ds kll pmf as string() function

2020-08-25 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16336 ) Change subject: IMPALA-10019: Implement ds_kll_pmf_as_string() function .. Patch Set 4: Code-Review+2 PS4 is a rebase with master.

[Impala-ASF-CR] IMPALA-10019: Implement ds kll pmf as string() function

2020-08-25 Thread Gabor Kaszab (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16336 to look at the new patch set (#4). Change subject: IMPALA-10019: Implement ds_kll_pmf_as_string() function

[Impala-ASF-CR] IMPALA-9482 Support for BINARY columns

2020-08-25 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16066 ) Change subject: IMPALA-9482 Support for BINARY columns .. Patch Set 7: (1 comment) I only checked the FE part of the patch. Will

[Impala-ASF-CR] IMPALA-10106: Update DataSketches

2020-08-25 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16360 ) Change subject: IMPALA-10106: Update DataSketches .. Patch Set 2: (2 comments) I did some research and it seems that the 2.1.0

[Impala-ASF-CR] IMPALA-10020: Implement ds kll cdf as string() function

2020-08-25 Thread Gabor Kaszab (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16359 to look at the new patch set (#2). Change subject: IMPALA-10020: Implement ds_kll_cdf_as_string() function

[Impala-ASF-CR] IMPALA-10019: Implement ds kll pmf as string() function

2020-08-25 Thread Gabor Kaszab (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16336 to look at the new patch set (#3). Change subject: IMPALA-10019: Implement ds_kll_pmf_as_string() function

[Impala-ASF-CR] IMPALA-10020: Implement ds kll cdf as string() function

2020-08-25 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16359 Change subject: IMPALA-10020: Implement ds_kll_cdf_as_string() function .. IMPALA-10020: Implement ds_kll_cdf_as_string() function This

[Impala-ASF-CR] IMPALA-10019: Implement ds kll pmf as string() function

2020-08-24 Thread Gabor Kaszab (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16336 to look at the new patch set (#2). Change subject: IMPALA-10019: Implement ds_kll_pmf_as_string() function

[Impala-ASF-CR] IMPALA-9962: Implement ds kll quantiles as string() function

2020-08-24 Thread Gabor Kaszab (Code Review)
Hello Adam Tamas, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16324 to look at the new patch set (#7). Change subject: IMPALA-9962: Implement ds_kll_quantiles_as_string() function

[Impala-ASF-CR] IMPALA-10019: Implement ds kll pmf() function

2020-08-13 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16336 Change subject: IMPALA-10019: Implement ds_kll_pmf() function .. IMPALA-10019: Implement ds_kll_pmf() function This is the support for

[Impala-ASF-CR] IMPALA-9962: Implement ds kll quantiles() function

2020-08-13 Thread Gabor Kaszab (Code Review)
Hello Adam Tamas, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16324 to look at the new patch set (#6). Change subject: IMPALA-9962: Implement ds_kll_quantiles() function

[Impala-ASF-CR] IMPALA-9962: Implement ds kll quantiles() function

2020-08-13 Thread Gabor Kaszab (Code Review)
Hello Adam Tamas, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16324 to look at the new patch set (#5). Change subject: IMPALA-9962: Implement ds_kll_quantiles() function

[Impala-ASF-CR] IMPALA-9962: Implement ds kll quantiles() function

2020-08-13 Thread Gabor Kaszab (Code Review)
Hello Adam Tamas, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16324 to look at the new patch set (#4). Change subject: IMPALA-9962: Implement ds_kll_quantiles() function

[Impala-ASF-CR] IMPALA-9962: Implement ds kll quantiles() function

2020-08-12 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16324 ) Change subject: IMPALA-9962: Implement ds_kll_quantiles() function .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-9962: Implement ds kll quantiles() function

2020-08-12 Thread Gabor Kaszab (Code Review)
Hello Adam Tamas, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16324 to look at the new patch set (#3). Change subject: IMPALA-9962: Implement ds_kll_quantiles() function

[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command fails

2020-08-11 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16322 ) Change subject: IMPALA-10066: Fix test_cancellation_mid_command fails .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9962: Implement ds kll quantiles() function

2020-08-11 Thread Gabor Kaszab (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16324 to look at the new patch set (#2). Change subject: IMPALA-9962: Implement ds_kll_quantiles() function ..

[Impala-ASF-CR] IMPALA-9962: Implement ds kll quantiles() function

2020-08-11 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16324 ) Change subject: IMPALA-9962: Implement ds_kll_quantiles() function .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-9962: Implement ds kll quantiles() function

2020-08-11 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16324 Change subject: IMPALA-9962: Implement ds_kll_quantiles() function .. IMPALA-9962: Implement ds_kll_quantiles() function This function

[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command fails

2020-08-11 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16322 ) Change subject: IMPALA-10066: Fix test_cancellation_mid_command fails .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-10054: Fix flakiness in test multiple sort run bytes limits

2020-08-11 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16301 ) Change subject: IMPALA-10054: Fix flakiness in test_multiple_sort_run_bytes_limits .. Patch Set 4: Apparently, the job failed during

[Impala-ASF-CR] IMPALA-10017: Implement ds kll union() function

2020-08-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16267 ) Change subject: IMPALA-10017: Implement ds_kll_union() function .. Patch Set 7: Code-Review+2 Carry +2 from Csaba -- To view, visit

[Impala-ASF-CR] IMPALA-10017: Implement ds kll union() function

2020-08-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16267 ) Change subject: IMPALA-10017: Implement ds_kll_union() function .. Patch Set 7: PS7 is rebase with master -- To view, visit

[Impala-ASF-CR] IMPALA-10017: Implement ds kll union() function

2020-08-07 Thread Gabor Kaszab (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16267 to look at the new patch set (#7). Change subject: IMPALA-10017: Implement ds_kll_union() function

[Impala-ASF-CR] IMPALA-10017: Implement ds kll union() function

2020-08-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16267 ) Change subject: IMPALA-10017: Implement ds_kll_union() function .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-10017: Implement ds kll union() function

2020-08-07 Thread Gabor Kaszab (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16267 to look at the new patch set (#6). Change subject: IMPALA-10017: Implement ds_kll_union() function

[Impala-ASF-CR] IMPALA-10017: Implement ds kll union() function

2020-08-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16267 ) Change subject: IMPALA-10017: Implement ds_kll_union() function .. Patch Set 5: PS5 is a rebase with master. -- To view, visit

[Impala-ASF-CR] IMPALA-10017: Implement ds kll union() function

2020-08-07 Thread Gabor Kaszab (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16267 to look at the new patch set (#5). Change subject: IMPALA-10017: Implement ds_kll_union() function

[Impala-ASF-CR] IMPALA-10018: Implement ds kll rank() function

2020-08-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16283 ) Change subject: IMPALA-10018: Implement ds_kll_rank() function .. Patch Set 4: Code-Review+2 PS4 is a rebase with master. I carry the

[Impala-ASF-CR] IMPALA-10018: Implement ds kll rank() function

2020-08-07 Thread Gabor Kaszab (Code Review)
Hello Adam Tamas, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16283 to look at the new patch set (#4). Change subject: IMPALA-10018: Implement ds_kll_rank() function

[Impala-ASF-CR] IMPALA-10017: Implement ds kll union() function

2020-08-06 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16267 ) Change subject: IMPALA-10017: Implement ds_kll_union() function .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-10017: Implement ds kll union() function

2020-08-06 Thread Gabor Kaszab (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16267 to look at the new patch set (#4). Change subject: IMPALA-10017: Implement ds_kll_union() function

[Impala-ASF-CR] IMPALA-10018: Implement ds kll rank() function

2020-08-06 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16283 ) Change subject: IMPALA-10018: Implement ds_kll_rank() function .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-9963: Implement ds kll n() function

2020-08-06 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16259 ) Change subject: IMPALA-9963: Implement ds_kll_n() function .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-10018: Implement ds kll rank() function

2020-08-04 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16283 ) Change subject: IMPALA-10018: Implement ds_kll_rank() function .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10018: Implement ds kll rank() function

2020-08-04 Thread Gabor Kaszab (Code Review)
Hello Adam Tamas, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16283 to look at the new patch set (#2). Change subject: IMPALA-10018: Implement ds_kll_rank() function

[Impala-ASF-CR] IMPALA-9963: Implement ds kll n() function

2020-08-04 Thread Gabor Kaszab (Code Review)
Hello Adam Tamas, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16259 to look at the new patch set (#4). Change subject: IMPALA-9963: Implement ds_kll_n() function

[Impala-ASF-CR] IMPALA-10018: Implement ds kll rank() function

2020-08-04 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16283 Change subject: IMPALA-10018: Implement ds_kll_rank() function .. IMPALA-10018: Implement ds_kll_rank() function ds_kll_rank() receives

[Impala-ASF-CR] IMPALA-10017: Implement ds kll union() function

2020-07-31 Thread Gabor Kaszab (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16267 to look at the new patch set (#2). Change subject: IMPALA-10017: Implement ds_kll_union() function ..

[Impala-ASF-CR] IMPALA-10017: Implement ds kll union() function

2020-07-31 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16267 Change subject: IMPALA-10017: Implement ds_kll_union() function .. IMPALA-10017: Implement ds_kll_union() function This function

[Impala-ASF-CR] IMPALA-9963: Implement ds kll n() function

2020-07-31 Thread Gabor Kaszab (Code Review)
Hello Adam Tamas, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16259 to look at the new patch set (#2). Change subject: IMPALA-9963: Implement ds_kll_n() function

[Impala-ASF-CR] IMPALA-9959: Implement ds kll sketch() and ds kll quantile() functions

2020-07-30 Thread Gabor Kaszab (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16235 to look at the new patch set (#8). Change subject: IMPALA-9959: Implement ds_kll_sketch() and ds_kll_quantile() functions

[Impala-ASF-CR] IMPALA-9963: Implement ds kll n() function

2020-07-30 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16259 Change subject: IMPALA-9963: Implement ds_kll_n() function .. IMPALA-9963: Implement ds_kll_n() function This functions receives a

[Impala-ASF-CR] IMPALA-9959: Implement ds kll sketch() and ds kll quantile() functions

2020-07-30 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16235 ) Change subject: IMPALA-9959: Implement ds_kll_sketch() and ds_kll_quantile() functions .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-9959: Implement ds kll sketch() and ds kll quantile() functions

2020-07-30 Thread Gabor Kaszab (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16235 to look at the new patch set (#7). Change subject: IMPALA-9959: Implement ds_kll_sketch() and ds_kll_quantile() functions

[Impala-ASF-CR] IMPALA-9942: DataSketches HLL shouldn't take empty strings as distinct values

2020-07-28 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16226 ) Change subject: IMPALA-9942: DataSketches HLL shouldn't take empty strings as distinct values .. Patch Set 5: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-9942: DataSketches HLL shouldn't take empty strings as distinct values

2020-07-28 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16226 ) Change subject: IMPALA-9942: DataSketches HLL shouldn't take empty strings as distinct values .. Patch Set 4: (6 comments) I have

[Impala-ASF-CR] IMPALA-9959: Implement ds kll sketch() and ds kll quantile() functions

2020-07-28 Thread Gabor Kaszab (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16235 to look at the new patch set (#6). Change subject: IMPALA-9959: Implement ds_kll_sketch() and ds_kll_quantile() functions

[Impala-ASF-CR] IMPALA-9959: Implement ds kll sketch() and ds kll quantile() functions

2020-07-28 Thread Gabor Kaszab (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16235 to look at the new patch set (#5). Change subject: IMPALA-9959: Implement ds_kll_sketch() and ds_kll_quantile() functions

[Impala-ASF-CR] IMPALA-9882: Import KLL functionality from Apache DataSketches

2020-07-27 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16196 ) Change subject: IMPALA-9882: Import KLL functionality from Apache DataSketches .. Patch Set 8: Code-Review+2 (4 comments) Carry +2

[Impala-ASF-CR] IMPALA-9882: Import KLL functionality from Apache DataSketches

2020-07-27 Thread Gabor Kaszab (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16196 to look at the new patch set (#8). Change subject: IMPALA-9882: Import KLL functionality from Apache DataSketches

[Impala-ASF-CR] IMPALA-9959: Implement ds kll sketch() and ds kll quantile() functions

2020-07-24 Thread Gabor Kaszab (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16235 to look at the new patch set (#2). Change subject: IMPALA-9959: Implement ds_kll_sketch() and ds_kll_quantile() functions

[Impala-ASF-CR] IMPALA-9959: Implement ds kll sketch() and ds kll quantile() functions

2020-07-24 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16235 Change subject: IMPALA-9959: Implement ds_kll_sketch() and ds_kll_quantile() functions .. IMPALA-9959: Implement ds_kll_sketch() and

[Impala-ASF-CR] IMPALA-9882: Import KLL functionality from Apache DataSketches

2020-07-23 Thread Gabor Kaszab (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16196 to look at the new patch set (#6). Change subject: IMPALA-9882: Import KLL functionality from Apache DataSketches

[Impala-ASF-CR] IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex types)

2020-07-22 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16228 ) Change subject: IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex types) .. Patch Set 2: Code-Review+1 (5

[Impala-ASF-CR] IMPALA-9882: Import KLL functionality from Apache DataSketches

2020-07-22 Thread Gabor Kaszab (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16196 to look at the new patch set (#5). Change subject: IMPALA-9882: Import KLL functionality from Apache DataSketches

[Impala-ASF-CR] IMPALA-9882: Import KLL functionality from Apache DataSketches

2020-07-21 Thread Gabor Kaszab (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16196 to look at the new patch set (#4). Change subject: IMPALA-9882: Import KLL functionality from Apache DataSketches

[Impala-ASF-CR] IMPALA-9942: DataSketches HLL shouldn't take empty strings as distinct values

2020-07-21 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16226 ) Change subject: IMPALA-9942: DataSketches HLL shouldn't take empty strings as distinct values .. Patch Set 2: (7 comments) Thanks

[Impala-ASF-CR] IMPALA-9882: Import KLL functionality from Apache DataSketches

2020-07-17 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16196 ) Change subject: IMPALA-9882: Import KLL functionality from Apache DataSketches .. Patch Set 3: In PS3 I've put this patch on top of

[Impala-ASF-CR] IMPALA-9882: Import KLL functionality from Apache DataSketches

2020-07-17 Thread Gabor Kaszab (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16196 to look at the new patch set (#3). Change subject: IMPALA-9882: Import KLL functionality from Apache DataSketches

[Impala-ASF-CR] IMPALA-9882: Import KLL functionality from Apache DataSketches

2020-07-14 Thread Gabor Kaszab (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16196 to look at the new patch set (#2). Change subject: IMPALA-9882: Import KLL functionality from Apache DataSketches

[Impala-ASF-CR] IMPALA-9882: Import DataSketches KLL library

2020-07-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16196 Change subject: IMPALA-9882: Import DataSketches KLL library .. IMPALA-9882: Import DataSketches KLL library I updated our snapshot of

[Impala-ASF-CR] IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix

2020-07-14 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16179 ) Change subject: IMPALA-9941: ExprTest.CastExprs fails when running with ASAN fix .. Patch Set 5: (2 comments) The patch seems fine.

<    1   2   3   4   5   6   7   8   9   10   >