[Impala-ASF-CR] IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9125 ) Change subject: IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace() .. Patch Set 3: Code-Review+1 Carry +1 -- To view, visi

[Impala-ASF-CR] IMPALA-4835: prerequisite buffer pool changes

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9097 ) Change subject: IMPALA-4835: prerequisite buffer pool changes .. Patch Set 2: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 9: (6 comments) http://gerrit.cloudera.org:8080/#/c/8914/

[Impala-ASF-CR] IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9125 to look at the new patch set (#3). Change subject: IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace() ...

[Impala-ASF-CR] IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9125 ) Change subject: IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] KUDU-2270: Add a flag to control logging in RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9121 ) Change subject: KUDU-2270: Add a flag to control logging in RpczStore::LogTrace() .. Patch Set 2: (2 comments) http://gerrit.cloudera.or

[Impala-ASF-CR] KUDU-2270: Add a flag to control logging in RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9121 ) Change subject: KUDU-2270: Add a flag to control logging in RpczStore::LogTrace() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] KUDU-2270: Add a flag to control logging in RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Hello Lars Volker, Kudu Jenkins, Sailesh Mukil, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9121 to look at the new patch set (#2). Change subject: KUDU-2270: Add a flag to control logging in RpczStore::LogTrace() ..

[Impala-ASF-CR] IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9125 ) Change subject: IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace() .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9125 to look at the new patch set (#2). Change subject: IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace() ...

[Impala-ASF-CR] IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9125 Change subject: IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace() .. IMPALA-6356: Reduce amount of logging from RpczStore::Lo

[native-toolchain-CR] Build old versions of gperftools and thrift.

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9122 ) Change subject: Build old versions of gperftools and thrift. .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8

[native-toolchain-CR] Build old versions of gperftools and thrift.

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9122 ) Change subject: Build old versions of gperftools and thrift. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9122/1/build

[Impala-ASF-CR] KUDU-2270: Add a flag to control logging in RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9121 ) Change subject: KUDU-2270: Add a flag to control logging in RpczStore::LogTrace() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] KUDU-2270: Add a flag to control logging in RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9121 ) Change subject: KUDU-2270: Add a flag to control logging in RpczStore::LogTrace() .. Patch Set 1: Clean cherry-pick. -- To view, visit

[Impala-ASF-CR] KUDU-2270: Add a flag to control logging in RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9121 ) Change subject: KUDU-2270: Add a flag to control logging in RpczStore::LogTrace() .. Removed reviewer Kudu Jenkins. -- To view, vi

[Impala-ASF-CR] KUDU-2270: Add a flag to control logging in RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has removed Todd Lipcon from this change. ( http://gerrit.cloudera.org:8080/9121 ) Change subject: KUDU-2270: Add a flag to control logging in RpczStore::LogTrace() .. Removed reviewer Todd Lipcon. -- To view, visi

[Impala-ASF-CR] KUDU-2270: Add a flag to control logging in RpczStore::LogTrace()

2018-01-24 Thread Michael Ho (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9121 to review the following change. Change subject: KUDU-2270: Add a flag to control logging in RpczStore::LogTrace() ..

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/895

[native-toolchain-CR] Build old versions of gperftools and thrift.

2018-01-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9120 ) Change subject: Build old versions of gperftools and thrift. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9120/1/build

[Impala-ASF-CR] IMPALA-6395: Add a flag for data stream sender's buffer size

2018-01-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9026 ) Change subject: IMPALA-6395: Add a flag for data stream sender's buffer size .. Patch Set 2: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-6395: Add a flag for data stream sender's buffer size

2018-01-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9026 ) Change subject: IMPALA-6395: Add a flag for data stream sender's buffer size .. Patch Set 2: GVO failed with IMPALA-6399 -- To view, vis

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 12: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9060 ) Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions .. Patch Set 4: Code-Review+2 (3 comments) http://gerr

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 11: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 7: (13 comments) Looking good. Some minor comments. http

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9060 ) Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions .. Patch Set 3: (2 comments) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2018-01-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. Patch Set 5: Code-Review+2 (2 comments) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/895

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9060 ) Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions .. Patch Set 1: (1 comment) Did we intentionally not u

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9060 ) Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions .. Patch Set 1: (2 comments) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/895

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2018-01-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. Patch Set 4: (15 comments) http://gerrit.cloudera.org:8080/#/c/84

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 10: GVO failed due to https://

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 10: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-01-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 16: Sorry. Will start on it today. -- To view, vis

[Impala-ASF-CR] IMPALA-5528: Bump total thread cache size when KRPC is enabled

2018-01-18 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9058 Change subject: IMPALA-5528: Bump total thread cache size when KRPC is enabled .. IMPALA-5528: Bump total thread cache size when KRPC is ena

[Impala-ASF-CR] Revert "IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC"

2018-01-18 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9057 Change subject: Revert "IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC" .. Revert "IMPALA-5528: Upgrade GPerfTools to

[Impala-ASF-CR] IMPALA-2397: Use atomics for IntGauge and IntCounter

2018-01-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9012 ) Change subject: IMPALA-2397: Use atomics for IntGauge and IntCounter .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/901

[Impala-ASF-CR] IMPALA-2397: Use atomics for IntGauge and IntCounter

2018-01-17 Thread Michael Ho (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9012 to look at the new patch set (#3). Change subject: IMPALA-2397: Use atomics for IntGauge and IntCounter ...

[Impala-ASF-CR] IMPALA-2397: Use atomics for metrics

2018-01-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9012 ) Change subject: IMPALA-2397: Use atomics for metrics .. Patch Set 2: (10 comments) http://gerrit.cloudera.org:8080/#/c/9012/1/be/src/util

[Impala-ASF-CR] IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing

2018-01-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9006 ) Change subject: IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing .. Patch Set 3: Code-Review+2 (1 comment) ht

[Impala-ASF-CR] IMPALA-2397: Use atomics for metrics

2018-01-16 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9012 ) Change subject: IMPALA-2397: Use atomics for metrics .. IMPALA-2397: Use atomics for metrics This change removes the spinlock in IntGauge an

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/895

[Impala-ASF-CR] IMPALA-6395: Add a flag for data stream sender's buffer size

2018-01-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9026 ) Change subject: IMPALA-6395: Add a flag for data stream sender's buffer size .. Patch Set 1: My understanding is that the existing logic d

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8914/3

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 9: (2 comments) http://gerrit

[Impala-ASF-CR] IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing

2018-01-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9006 ) Change subject: IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing .. Patch Set 3: (1 comment) http://gerrit.cl

[Impala-ASF-CR] IMPALA-6395: Add a flag for data stream sender's buffer size

2018-01-12 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9026 Change subject: IMPALA-6395: Add a flag for data stream sender's buffer size .. IMPALA-6395: Add a flag for data stream sender's buffer size

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 8: (3 comments) Looking good.

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2018-01-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/843

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 3: (10 comments) http://gerrit.cloudera.org:8080/#/c/89

[Impala-ASF-CR] KUDU-2256: Add GetTransferSize() to RpcContext

2018-01-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9019 ) Change subject: KUDU-2256: Add GetTransferSize() to RpcContext .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing

2018-01-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9006 ) Change subject: IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing .. Patch Set 3: (1 comment) http://gerrit.cl

[Impala-ASF-CR] IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC

2018-01-11 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8991 to look at the new patch set (#5). Change subject: IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC .

[Impala-ASF-CR] IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC

2018-01-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8991 ) Change subject: IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC .. Patch Set 4: PS4 moves the initialization to ExecE

[Impala-ASF-CR] IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC

2018-01-11 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8991 to look at the new patch set (#4). Change subject: IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC .

[Impala-ASF-CR] IMPALA-2397: Use atomics for metrics

2018-01-11 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9012 Change subject: IMPALA-2397: Use atomics for metrics .. IMPALA-2397: Use atomics for metrics This change removes the spinlock in IntGauge a

[Impala-ASF-CR] IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC

2018-01-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8991 ) Change subject: IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC .. Patch Set 3: (1 comment) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC

2018-01-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8991 ) Change subject: IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC .. Patch Set 2: (2 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC

2018-01-10 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8991 to look at the new patch set (#3). Change subject: IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC .

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time

2018-01-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

2018-01-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/ ) Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking. .. Patch Set 3: Code-Review+2

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time

2018-01-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

2018-01-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/ ) Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking. .. Patch Set 2: Code-Review+2 (

[Impala-ASF-CR] IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC

2018-01-09 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8991 to look at the new patch set (#2). Change subject: IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC .

[Impala-ASF-CR] IMPALA-5528: Tune TCMalloc for KRPC

2018-01-09 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8991 Change subject: IMPALA-5528: Tune TCMalloc for KRPC .. IMPALA-5528: Tune TCMalloc for KRPC KRPC in general tends to put more pressure on th

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time

2018-01-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/8

[Impala-ASF-CR] IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking.

2018-01-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/ ) Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking. .. Patch Set 2: (1 comment) Th

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 7: (4 comments) http://gerrit

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time

2018-01-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/8

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time

2018-01-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time .. Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-6290: limit ScannerContext to 1 buffer at a time

2018-01-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8814 ) Change subject: IMPALA-6290: limit ScannerContext to 1 buffer at a time .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/8914/

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 1: Can you please add a BE test for it ? -- To view, v

[Impala-ASF-CR] IMPALA-6362: avoid Reservation/MemTracker deadlock

2018-01-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8933 ) Change subject: IMPALA-6362: avoid Reservation/MemTracker deadlock .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-6362: avoid Reservation/MemTracker deadlock

2018-01-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8933 ) Change subject: IMPALA-6362: avoid Reservation/MemTracker deadlock .. Patch Set 1: Code-Review+1 Fix makes sense to me. Not sure if there

[Impala-ASF-CR] IMPALA-6362: avoid Reservation/MemTracker deadlock

2018-01-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8933 ) Change subject: IMPALA-6362: avoid Reservation/MemTracker deadlock .. Patch Set 1: Meta comment: if we have lock ranking to enforce lock o

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2018-01-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 19: Build failed due to failed test: 21:45:15 ] FAIL

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2018-01-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. Patch Set 1: The backport for KUDU-2228 is merged now. -- To vie

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2018-01-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/8

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2018-01-03 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 19: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2018-01-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 18: Code-Review+2 (4 comments) http://gerrit.cloudera.

[Impala-ASF-CR] KUDU-2228: Make Messenger options configurable

2018-01-02 Thread Michael Ho (Code Review)
Hello Lars Volker, Dan Burkert, Kudu Jenkins, Sailesh Mukil, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8878 to look at the new patch set (#3). Change subject: KUDU-2228: Make Messenger options configurable ...

[Impala-ASF-CR] KUDU-2228: Make Messenger options configurable

2018-01-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8878 ) Change subject: KUDU-2228: Make Messenger options configurable .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8878/2/be

[Impala-ASF-CR] IMPALA-5528: Add a flag to tune TCMalloc total thread caches size

2018-01-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8906 ) Change subject: IMPALA-5528: Add a flag to tune TCMalloc total thread caches size .. Patch Set 3: Carry Tim's +2. -- To view, visit htt

[Impala-ASF-CR] IMPALA-5528: Add a flag to tune TCMalloc total thread caches size

2018-01-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8906 ) Change subject: IMPALA-5528: Add a flag to tune TCMalloc total thread caches size .. Patch Set 3: Code-Review+2 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-5528: Add a flag to tune TCMalloc total thread caches size

2018-01-02 Thread Michael Ho (Code Review)
Hello Lars Volker, Sailesh Mukil, Tim Armstrong, Joe McDonnell, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8906 to look at the new patch set (#3). Change subject: IMPALA-5528: Add a flag to tune TCMalloc total thread caches size ..

[Impala-ASF-CR] IMPALA-5528: Add a flag to tune TCMalloc total thread caches size

2018-01-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8906 ) Change subject: IMPALA-5528: Add a flag to tune TCMalloc total thread caches size .. Patch Set 2: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-5557: Disable rpc default keepalive time ms

2017-12-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8910 ) Change subject: IMPALA-5557: Disable rpc_default_keepalive_time_ms .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-5557: Disable rpc default keepalive time ms

2017-12-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8910 ) Change subject: IMPALA-5557: Disable rpc_default_keepalive_time_ms .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8910/1

[Impala-ASF-CR] IMPALA-5557: Disable rpc default keepalive time ms

2017-12-22 Thread Michael Ho (Code Review)
Hello Lars Volker, Sailesh Mukil, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8910 to look at the new patch set (#2). Change subject: IMPALA-5557: Disable rpc_default_keepalive_time_ms ..

[Impala-ASF-CR] IMPALA-5528: Add a flag to tune TCMalloc total thread caches size

2017-12-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8906 ) Change subject: IMPALA-5528: Add a flag to tune TCMalloc total thread caches size .. Patch Set 2: To answer your question about testing:

[Impala-ASF-CR] IMPALA-5528: Add a flag to tune TCMalloc total thread caches size

2017-12-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8906 ) Change subject: IMPALA-5528: Add a flag to tune TCMalloc total thread caches size .. Patch Set 2: (4 comments) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-5528: Add a flag to tune TCMalloc total thread caches size

2017-12-22 Thread Michael Ho (Code Review)
Hello Lars Volker, Sailesh Mukil, Tim Armstrong, Joe McDonnell, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8906 to look at the new patch set (#2). Change subject: IMPALA-5528: Add a flag to tune TCMalloc total thread caches size ..

[native-toolchain-CR] Add GPerfTools 2.6.3 to toolchain

2017-12-22 Thread Michael Ho (Code Review)
Michael Ho has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8918 ) Change subject: Add GPerfTools 2.6.3 to toolchain .. Add GPerfTools 2.6.3 to toolchain This is the latest release of GPerfTools. I

[native-toolchain-CR] Add GPerfTools 2.6.3 to toolchain

2017-12-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8918 ) Change subject: Add GPerfTools 2.6.3 to toolchain .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/8918 To un

[native-toolchain-CR] Add GPerfTools 2.6.3 to toolchain

2017-12-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8918 ) Change subject: Add GPerfTools 2.6.3 to toolchain .. Patch Set 1: Verified the build with a private toolchain packaging Jenkins job. --

[Impala-ASF-CR] IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module

2017-12-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8541 ) Change subject: IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module .. Patch Set 13: (1 comment) http://gerrit.clou

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 10: LGTM ! Will let Tim do a pass on it too. -- To v

<    5   6   7   8   9   10   11   12   >