[Impala-ASF-CR] IMPALA-9867: Add Support for Spilling to S3: Milestone 1

2020-10-23 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16318 ) Change subject: IMPALA-9867: Add Support for Spilling to S3: Milestone 1 .. Patch Set 17: (13 comments)

[Impala-ASF-CR] IMPALA-9870: impala-shell 'summary' to show original and retried queries

2020-10-23 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16502 ) Change subject: IMPALA-9870: impala-shell 'summary' to show original and retried queries .. Patch Set 5: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7097 Print EC info in the query plan and profile

2020-10-20 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16587 ) Change subject: IMPALA-7097 Print EC info in the query plan and profile .. Patch Set 6: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9910: [DOCS] Add fault tolerance docs

2020-10-20 Thread Sahil Takiar (Code Review)
Hello Thomas Tauber-Marshall, Shajini Thayasingh, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16610 to look at the new patch set (#3). Change subject: IMPALA-9910: [DOCS] Add fault tolerance docs

[Impala-ASF-CR] IMPALA-9910: [DOCS] Add fault tolerance docs

2020-10-20 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16610 ) Change subject: IMPALA-9910: [DOCS] Add fault tolerance docs .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-10178 Run-time profile shall report skews

2020-10-20 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16474 ) Change subject: IMPALA-10178 Run-time profile shall report skews .. Patch Set 44: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9910: [DOCS] Add fault tolerance docs

2020-10-19 Thread Sahil Takiar (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16610 to look at the new patch set (#2). Change subject: IMPALA-9910: [DOCS] Add fault tolerance docs ..

[Impala-ASF-CR] IMPALA-10178 Run-time profile shall report skews

2020-10-19 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16474 ) Change subject: IMPALA-10178 Run-time profile shall report skews .. Patch Set 42: Code-Review+2 (1 comment) minor nit

[Impala-ASF-CR] IMPALA-9910: [DOCS] Add fault tolerance docs

2020-10-19 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16610 Change subject: IMPALA-9910: [DOCS] Add fault tolerance docs .. IMPALA-9910: [DOCS] Add fault tolerance docs Adds a few basic docs for

[Impala-ASF-CR] IMPALA-10007: Impala development environment does not support Ubuntu 20.04

2020-10-19 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16241 ) Change subject: IMPALA-10007: Impala development environment does not support Ubuntu 20.04 .. Patch Set 8: Code-Review+2 Carrying +2.

[Impala-ASF-CR] IMPALA-7097 Print EC info in the query plan and profile

2020-10-19 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16587 ) Change subject: IMPALA-7097 Print EC info in the query plan and profile .. Patch Set 5: Code-Review+1 A few more nits, otherwise LGTM.

[Impala-ASF-CR] IMPALA-7097 Print EC info in the query plan and profile

2020-10-19 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16587 ) Change subject: IMPALA-7097 Print EC info in the query plan and profile .. Patch Set 1: (3 comments)

[Impala-ASF-CR] [WIP] IMPALA-7097 Print EC info in the query plan and profile

2020-10-13 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16587 ) Change subject: [WIP] IMPALA-7097 Print EC info in the query plan and profile .. Patch Set 1: (4 comments) general approach looks

[Impala-ASF-CR] IMPALA-9870: impala-shell 'summary' to show original and retried queries

2020-10-13 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16502 ) Change subject: IMPALA-9870: impala-shell 'summary' to show original and retried queries .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-9339: Revise explanation of RowMaterializationTimer

2020-10-13 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16593 Change subject: IMPALA-9339: Revise explanation of RowMaterializationTimer .. IMPALA-9339: Revise explanation of RowMaterializationTimer

[Impala-ASF-CR] IMPALA-10180: Add average size of fetch requests in runtime profile

2020-10-12 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16585 Change subject: IMPALA-10180: Add average size of fetch requests in runtime profile .. IMPALA-10180: Add average size of fetch requests

[Impala-ASF-CR] IMPALA-10178 Run-time profile shall report skews

2020-10-12 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16474 ) Change subject: IMPALA-10178 Run-time profile shall report skews .. Patch Set 41: Code-Review+1 (6 comments) mostly nits, otherwise

[Impala-ASF-CR] IMPALA-9485: Enable file handle cache for EC files

2020-10-08 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16567 ) Change subject: IMPALA-9485: Enable file handle cache for EC files .. Patch Set 2: > This makes sense to me. > > It is nice to

[Impala-ASF-CR] IMPALA-9485: Enable file handle cache for EC files

2020-10-08 Thread Sahil Takiar (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16567 to look at the new patch set (#2). Change subject: IMPALA-9485: Enable file handle cache for EC files

[Impala-ASF-CR] IMPALA-9485: Enable file handle cache for EC files

2020-10-08 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16567 ) Change subject: IMPALA-9485: Enable file handle cache for EC files .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-9485: Enable file handle cache for EC files

2020-10-08 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16567 Change subject: IMPALA-9485: Enable file handle cache for EC files .. IMPALA-9485: Enable file handle cache for EC files This is

[Impala-ASF-CR] IMPALA-10016: Split jars for Impala exec and coord Docker images

2020-10-08 Thread Sahil Takiar (Code Review)
Sahil Takiar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16320 ) Change subject: IMPALA-10016: Split jars for Impala exec and coord Docker images .. IMPALA-10016: Split jars for Impala exec

[Impala-ASF-CR] IMPALA-10016: Split jars for Impala exec and coord Docker images

2020-10-08 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16320 ) Change subject: IMPALA-10016: Split jars for Impala exec and coord Docker images .. Patch Set 9: Code-Review+2 Carrying +2 from Tim.

[Impala-ASF-CR] IMPALA-10016: Split jars for Impala exec and coord Docker images

2020-10-08 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16320 ) Change subject: IMPALA-10016: Split jars for Impala exec and coord Docker images .. Patch Set 9: * Rebased * Fixed some bugs from a

[Impala-ASF-CR] IMPALA-10016: Split jars for Impala exec and coord Docker images

2020-10-08 Thread Sahil Takiar (Code Review)
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16320 to look at the new patch set (#9). Change subject: IMPALA-10016: Split jars for Impala exec and coord Docker images

[Impala-ASF-CR] IMPALA-10016: Split jars for Impala exec and coord Docker images

2020-10-08 Thread Sahil Takiar (Code Review)
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16320 to look at the new patch set (#8). Change subject: IMPALA-10016: Split jars for Impala exec and coord Docker images

[Impala-ASF-CR] IMPALA-9664: Fix typo in test event processing.py

2020-10-05 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16547 ) Change subject: IMPALA-9664: Fix typo in test_event_processing.py .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10202: Enable file handle cache for ABFS files

2020-10-01 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16532 ) Change subject: IMPALA-10202: Enable file handle cache for ABFS files .. Patch Set 1: > This looks good to me. > > If you haven't

[Impala-ASF-CR] IMPALA-10202: Enable file handle cache for ABFS files

2020-10-01 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16532 Change subject: IMPALA-10202: Enable file handle cache for ABFS files .. IMPALA-10202: Enable file handle cache for ABFS files Like

[Impala-ASF-CR] IMPALA-10178 Run-time profile shall report skews

2020-10-01 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16474 ) Change subject: IMPALA-10178 Run-time profile shall report skews .. Patch Set 31: (1 comment)

[Impala-ASF-CR] IMPALA-10178 Run-time profile shall report skews

2020-10-01 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16474 ) Change subject: IMPALA-10178 Run-time profile shall report skews .. Patch Set 34: > Uploaded patch set 34: Patch Set 33 was rebased.

[Impala-ASF-CR] IMPALA-10178 Run-time profile shall report skews

2020-10-01 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16474 ) Change subject: IMPALA-10178 Run-time profile shall report skews .. Patch Set 34: (1 comment)

[Impala-ASF-CR] IMPALA-9606: ABFS reads should use hdfsPreadFully

2020-10-01 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16531 Change subject: IMPALA-9606: ABFS reads should use hdfsPreadFully .. IMPALA-9606: ABFS reads should use hdfsPreadFully Similar to

[Impala-ASF-CR] IMPALA-3335: Allow single-node optimization with joins

2020-09-30 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16521 ) Change subject: IMPALA-3335: Allow single-node optimization with joins .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-9867: Add Support for Spilling to S3: Milestone 1

2020-09-30 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16318 ) Change subject: IMPALA-9867: Add Support for Spilling to S3: Milestone 1 .. Patch Set 13: (5 comments)

[Impala-ASF-CR] IMPALA-9930 (part 2): Introduce new admission control rpc service

2020-09-30 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16412 ) Change subject: IMPALA-9930 (part 2): Introduce new admission control rpc service .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-9930 (part 2): Introduce new admission control rpc service

2020-09-30 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16412 ) Change subject: IMPALA-9930 (part 2): Introduce new admission control rpc service .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-3335: Allow single-node optimization with joins

2020-09-30 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16521 ) Change subject: IMPALA-3335: Allow single-node optimization with joins .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-3335: Allow single-node optimization with joins

2020-09-30 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16521 ) Change subject: IMPALA-3335: Allow single-node optimization with joins .. Patch Set 2: > The code change looks good, i think looping

[Impala-ASF-CR] IMPALA-3335: Allow single-node optimization with joins

2020-09-30 Thread Sahil Takiar (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16521 to look at the new patch set (#2). Change subject: IMPALA-3335: Allow single-node optimization with joins

[Impala-ASF-CR] IMPALA-3335: Allow single-node optimization with joins

2020-09-29 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16521 ) Change subject: IMPALA-3335: Allow single-node optimization with joins .. Patch Set 1: @Tim - do you remember the source of the hangs

[Impala-ASF-CR] IMPALA-3335: Allow single-node optimization with joins

2020-09-29 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16521 Change subject: IMPALA-3335: Allow single-node optimization with joins .. IMPALA-3335: Allow single-node optimization with joins Enable

[Impala-ASF-CR] IMPALA-10178 Run-time profile shall report skews

2020-09-29 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16474 ) Change subject: IMPALA-10178 Run-time profile shall report skews .. Patch Set 31: (2 comments)

[Impala-ASF-CR] IMPALA-10016: Split jars for Impala exec and coord Docker images

2020-09-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16320 ) Change subject: IMPALA-10016: Split jars for Impala exec and coord Docker images .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10016: Split jars for Impala exec and coord Docker images

2020-09-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16320 ) Change subject: IMPALA-10016: Split jars for Impala exec and coord Docker images .. Patch Set 6: > > (1 comment) > > > > The code

[Impala-ASF-CR] IMPALA-10016: Split jars for Impala exec and coord Docker images

2020-09-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16320 ) Change subject: IMPALA-10016: Split jars for Impala exec and coord Docker images .. Patch Set 6: Rebased and resolved a bunch of

[Impala-ASF-CR] IMPALA-10016: Split jars for Impala exec and coord Docker images

2020-09-24 Thread Sahil Takiar (Code Review)
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16320 to look at the new patch set (#6). Change subject: IMPALA-10016: Split jars for Impala exec and coord Docker images

[Impala-ASF-CR] IMPALA-10016: Split jars for Impala exec and coord Docker images

2020-09-24 Thread Sahil Takiar (Code Review)
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16320 to look at the new patch set (#5). Change subject: IMPALA-10016: Split jars for Impala exec and coord Docker images

[Impala-ASF-CR] IMPALA-10178 Run-time profile shall report skews

2020-09-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16474 ) Change subject: IMPALA-10178 Run-time profile shall report skews .. Patch Set 21: (1 comment)

[Impala-ASF-CR] IMPALA-10178 Run-time profile shall report skews

2020-09-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16474 ) Change subject: IMPALA-10178 Run-time profile shall report skews .. Patch Set 21: (3 comments)

[Impala-ASF-CR] IMPALA-9930 (part 1): Initial refactor for admission control service

2020-09-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16411 ) Change subject: IMPALA-9930 (part 1): Initial refactor for admission control service .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar

2020-09-23 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16459 ) Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ .. Patch Set 6: I'm not really sure what happened in

[Impala-ASF-CR] IMPALA-9046: Profile counter that indicates if a JVM pause occurred

2020-09-22 Thread Sahil Takiar (Code Review)
Sahil Takiar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16414 ) Change subject: IMPALA-9046: Profile counter that indicates if a JVM pause occurred .. IMPALA-9046: Profile counter that

[Impala-ASF-CR] IMPALA-9046: Profile counter that indicates if a JVM pause occurred

2020-09-22 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16414 ) Change subject: IMPALA-9046: Profile counter that indicates if a JVM pause occurred .. Patch Set 5: Verified+1 Code-Review+2 Carrying

[Impala-ASF-CR] IMPALA-9046: Profile counter that indicates if a JVM pause occurred

2020-09-22 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16414 ) Change subject: IMPALA-9046: Profile counter that indicates if a JVM pause occurred .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-9046: Profile counter that indicates if a JVM pause occurred

2020-09-22 Thread Sahil Takiar (Code Review)
Hello Tamas Mate, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16414 to look at the new patch set (#5). Change subject: IMPALA-9046: Profile counter that indicates if a JVM pause occurred

[Impala-ASF-CR] IMPALA-9046: Profile counter that indicates if a JVM pause occurred

2020-09-22 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16414 ) Change subject: IMPALA-9046: Profile counter that indicates if a JVM pause occurred .. Patch Set 4: > This makes sense to me. My one

[Impala-ASF-CR] IMPALA-9046: Profile counter that indicates if a JVM pause occurred

2020-09-22 Thread Sahil Takiar (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16414 to look at the new patch set (#4). Change subject: IMPALA-9046: Profile counter that indicates if a JVM pause occurred

[Impala-ASF-CR] IMPALA-9227: Add coverage for query retries caused by RPC failure

2020-09-21 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16456 ) Change subject: IMPALA-9227: Add coverage for query retries caused by RPC failure .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar

2020-09-21 Thread Sahil Takiar (Code Review)
Hello Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16459 to look at the new patch set (#4). Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_

[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar

2020-09-21 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16459 ) Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar

2020-09-21 Thread Sahil Takiar (Code Review)
Hello Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16459 to look at the new patch set (#2). Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_

[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar

2020-09-17 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16459 ) Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-9229: impala-shell 'profile' to show original and retried queries

2020-09-17 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16406 ) Change subject: IMPALA-9229: impala-shell 'profile' to show original and retried queries .. Patch Set 8: Hit IMPALA-9923 again --

[Impala-ASF-CR] IMPALA-9229: impala-shell 'profile' to show original and retried queries

2020-09-16 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16406 ) Change subject: IMPALA-9229: impala-shell 'profile' to show original and retried queries .. Patch Set 8: Hit IMPALA-9923 -- To

[Impala-ASF-CR] IMPALA-10170: Data race on Webserver::UrlHandler::is on nav bar

2020-09-16 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16459 Change subject: IMPALA-10170: Data race on Webserver::UrlHandler::is_on_nav_bar_ .. IMPALA-10170: Data race on

[Impala-ASF-CR] IMPALA-9229: impala-shell 'profile' to show original and retried queries

2020-09-16 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16406 ) Change subject: IMPALA-9229: impala-shell 'profile' to show original and retried queries .. Patch Set 7: Code-Review+2 Carrying +2.

[Impala-ASF-CR] IMPALA-9229: impala-shell 'profile' to show original and retried queries

2020-09-16 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16406 ) Change subject: IMPALA-9229: impala-shell 'profile' to show original and retried queries .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-9229: impala-shell 'profile' to show original and retried queries

2020-09-16 Thread Sahil Takiar (Code Review)
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16406 to look at the new patch set (#7). Change subject: IMPALA-9229: impala-shell 'profile' to show original and retried queries

[Impala-ASF-CR] IMPALA-9229: impala-shell 'profile' to show original and retried queries

2020-09-15 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16406 ) Change subject: IMPALA-9229: impala-shell 'profile' to show original and retried queries .. Patch Set 2: reviewers* -- To view,

[Impala-ASF-CR] IMPALA-9229: impala-shell 'profile' to show original and retried queries

2020-09-15 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16406 ) Change subject: IMPALA-9229: impala-shell 'profile' to show original and retried queries .. Patch Set 2: > Do you plan to let anyone

[Impala-ASF-CR] IMPALA-9229: impala-shell 'profile' to show original and retried queries

2020-09-15 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16406 ) Change subject: IMPALA-9229: impala-shell 'profile' to show original and retried queries .. Patch Set 2: (9 comments)

[Impala-ASF-CR] IMPALA-9229: impala-shell 'profile' to show original and retried queries

2020-09-15 Thread Sahil Takiar (Code Review)
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16406 to look at the new patch set (#6). Change subject: IMPALA-9229: impala-shell 'profile' to show original and retried queries

[Impala-ASF-CR] IMPALA-9636: Don't run retried query on the blacklisted nodes

2020-09-15 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16369 ) Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes .. Patch Set 19: Code-Review+2 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-9636: Don't run retried query on the blacklisted nodes

2020-09-14 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16369 ) Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes .. Patch Set 18: (1 comment)

[Impala-ASF-CR] IMPALA-9636: Don't run retried query on the blacklisted nodes

2020-09-14 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16369 ) Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes .. Patch Set 17: Code-Review+1 (1 comment) just one

[Impala-ASF-CR] IMPALA-9636: Don't run retried query on the blacklisted nodes

2020-09-14 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16369 ) Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes .. Patch Set 16: (2 comments)

[Impala-ASF-CR] IMPALA-9930 (part 1): Initial refactor for admission control service

2020-09-14 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16411 ) Change subject: IMPALA-9930 (part 1): Initial refactor for admission control service .. Patch Set 2: (6 comments)

[Impala-ASF-CR] IMPALA-9636: Don't run retried query on the blacklisted nodes

2020-09-14 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16369 ) Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes .. Patch Set 16: (3 comments)

[Impala-ASF-CR] IMPALA-9636: Don't run retried query on the blacklisted nodes

2020-09-11 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16369 ) Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes .. Patch Set 13: (4 comments) looking better, still

[Impala-ASF-CR] IMPALA-9636: Don't run retried query on the blacklisted nodes

2020-09-10 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16369 ) Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes .. Patch Set 11: (3 comments)

[Impala-ASF-CR] IMPALA-9740, IMPALA-9403: Fix remaining custom cluster TSAN errors

2020-09-10 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16426 ) Change subject: IMPALA-9740, IMPALA-9403: Fix remaining custom cluster TSAN errors .. Patch Set 3: Failed due to a Jenkins issue,

[Impala-ASF-CR] IMPALA-9229: impala-shell 'profile' to show original and retried queries

2020-09-09 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16406 ) Change subject: IMPALA-9229: impala-shell 'profile' to show original and retried queries .. Patch Set 3: (12 comments) I updated the

[Impala-ASF-CR] IMPALA-9229: impala-shell 'profile' to show original and retried queries

2020-09-09 Thread Sahil Takiar (Code Review)
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16406 to look at the new patch set (#4). Change subject: IMPALA-9229: impala-shell 'profile' to show original and retried queries

[Impala-ASF-CR] IMPALA-9229: impala-shell 'profile' to show original and retried queries

2020-09-09 Thread Sahil Takiar (Code Review)
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16406 to look at the new patch set (#3). Change subject: IMPALA-9229: impala-shell 'profile' to show original and retried queries

[Impala-ASF-CR] IMPALA-9740, IMPALA-9403: Fix remaining custom cluster TSAN errors

2020-09-09 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16426 ) Change subject: IMPALA-9740, IMPALA-9403: Fix remaining custom cluster TSAN errors .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-9740, IMPALA-9403: Fix remaining custom cluster TSAN errors

2020-09-09 Thread Sahil Takiar (Code Review)
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16426 to look at the new patch set (#2). Change subject: IMPALA-9740, IMPALA-9403: Fix remaining custom cluster TSAN errors

[Impala-ASF-CR] IMPALA-10129 Data race in MemTracker::GetTopNQueriesAndUpdatePoolStats

2020-09-08 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16408 ) Change subject: IMPALA-10129 Data race in MemTracker::GetTopNQueriesAndUpdatePoolStats .. Patch Set 5: Code-Review+2 Hit IMPALA-9351

[Impala-ASF-CR] IMPALA-9740, IMPALA-9403: Fix remaining custom cluster TSAN errors

2020-09-08 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16426 Change subject: IMPALA-9740, IMPALA-9403: Fix remaining custom cluster TSAN errors .. IMPALA-9740, IMPALA-9403: Fix remaining custom

[Impala-ASF-CR] IMPALA-9636: Don't run retried query on the blacklisted nodes

2020-09-08 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16369 ) Change subject: IMPALA-9636: Don't run retried query on the blacklisted nodes .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-10124 admission-controller-test fails with no such file or directory error

2020-09-08 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16404 ) Change subject: IMPALA-10124 admission-controller-test fails with no such file or directory error .. Patch Set 2: Code-Review+2 Yeah,

[Impala-ASF-CR] IMPALA-10129 Data race in MemTracker::GetTopNQueriesAndUpdatePoolStats

2020-09-08 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16408 ) Change subject: IMPALA-10129 Data race in MemTracker::GetTopNQueriesAndUpdatePoolStats .. Patch Set 4: Code-Review+2 -- To view,

[Impala-ASF-CR] WIP IMPALA-9046: Profile counter that indicates if a JVM pause occurred

2020-09-03 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16414 ) Change subject: WIP IMPALA-9046: Profile counter that indicates if a JVM pause occurred .. Patch Set 2: @Tim wanted to validate this

[Impala-ASF-CR] WIP IMPALA-9046: Profile counter that indicates if a JVM pause occurred

2020-09-03 Thread Sahil Takiar (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16414 to look at the new patch set (#2). Change subject: WIP IMPALA-9046: Profile counter that indicates if a JVM pause occurred

[Impala-ASF-CR] WIP IMPALA-9046: Profile counter that indicates if a JVM pause occurred

2020-09-03 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16414 ) Change subject: WIP IMPALA-9046: Profile counter that indicates if a JVM pause occurred .. Patch Set 1: (1 comment)

[Impala-ASF-CR] WIP IMPALA-9046: Profile counter that indicates if a JVM pause occurred

2020-09-03 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16414 Change subject: WIP IMPALA-9046: Profile counter that indicates if a JVM pause occurred .. WIP IMPALA-9046: Profile counter that

[Impala-ASF-CR] IMPALA-9229: impala-shell 'profile' to show original and retried queries

2020-09-03 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16406 ) Change subject: IMPALA-9229: impala-shell 'profile' to show original and retried queries .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-9229: impala-shell 'profile' to show original and retried queries

2020-09-03 Thread Sahil Takiar (Code Review)
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16406 to look at the new patch set (#2). Change subject: IMPALA-9229: impala-shell 'profile' to show original and retried queries

[Impala-ASF-CR] IMPALA-10129 Data race in MemTracker::GetTopNQueriesAndUpdatePoolStats

2020-09-03 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16408 ) Change subject: IMPALA-10129 Data race in MemTracker::GetTopNQueriesAndUpdatePoolStats .. Patch Set 4: (1 comment)

[Impala-ASF-CR] WIP IMPALA-9229: impala-shell 'profile' to show original and retried queries

2020-09-02 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16406 Change subject: WIP IMPALA-9229: impala-shell 'profile' to show original and retried queries .. WIP IMPALA-9229: impala-shell 'profile'

  1   2   3   4   5   6   7   8   9   10   >