[Impala-ASF-CR] IMPALA-5904: Add tsan full option and fix several TSAN bugs

2020-01-28 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15116 ) Change subject: IMPALA-5904: Add tsan_full option and fix several TSAN bugs .. Patch Set 1: > > Does ignore_noninstrumented_modules wor

[Impala-ASF-CR] IMPALA-5904: Add tsan full option and fix several TSAN bugs

2020-01-28 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15116 ) Change subject: IMPALA-5904: Add tsan_full option and fix several TSAN bugs .. Patch Set 1: > Does ignore_noninstrumented_modules work

[Impala-ASF-CR] IMPALA-5904: Add tsan full option and fix several TSAN bugs

2020-01-28 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15116 ) Change subject: IMPALA-5904: Add tsan_full option and fix several TSAN bugs .. Patch Set 1: A few things I could use input on: * When

[Impala-ASF-CR] IMPALA-5904: Add tsan full option and fix several TSAN bugs

2020-01-28 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15116 Change subject: IMPALA-5904: Add tsan_full option and fix several TSAN bugs .. IMPALA-5904: Add tsan_full option and fix several TSAN bug

[Impala-ASF-CR] IMPALA-9334: Log node blacklisting removals in ClusterMembershipMgr

2020-01-27 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15110 ) Change subject: IMPALA-9334: Log node blacklisting removals in ClusterMembershipMgr .. Patch Set 1: (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-9334: Log node blacklisting removals in ClusterMembershipMgr

2020-01-27 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15110 Change subject: IMPALA-9334: Log node blacklisting removals in ClusterMembershipMgr .. IMPALA-9334: Log node blacklisting removals in Cl

[Impala-ASF-CR] IMPALA-9199: Add support for single query retries on cluster membership changes

2020-01-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14824 ) Change subject: IMPALA-9199: Add support for single query retries on cluster membership changes .. Patch Set 5: (1 comment) * Fixing

[Impala-ASF-CR] IMPALA-9199: Add support for single query retries on cluster membership changes

2020-01-24 Thread Sahil Takiar (Code Review)
Hello Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14824 to look at the new patch set (#5). Change subject: IMPALA-9199: Add support for single query retries on cluster membership changes ...

[Impala-ASF-CR] IMPALA-9199: Add support for single query retries on cluster membership changes

2020-01-24 Thread Sahil Takiar (Code Review)
Hello Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14824 to look at the new patch set (#4). Change subject: IMPALA-9199: Add support for single query retries on cluster membership changes ...

[Impala-ASF-CR] IMPALA-9199: Add support for single query retries on cluster membership changes

2020-01-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14824 ) Change subject: IMPALA-9199: Add support for single query retries on cluster membership changes .. Patch Set 1: (6 comments) Pretty m

[Impala-ASF-CR] IMPALA-9199: Add support for single query retries on cluster membership changes

2020-01-24 Thread Sahil Takiar (Code Review)
Hello Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14824 to look at the new patch set (#3). Change subject: IMPALA-9199: Add support for single query retries on cluster membership changes ...

[Impala-ASF-CR] IMPALA-9199: Add support for single query retries on cluster membership changes

2020-01-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has removed Michael Ho from this change. ( http://gerrit.cloudera.org:8080/14824 ) Change subject: IMPALA-9199: Add support for single query retries on cluster membership changes .. Removed reviewer Michael Ho. -

[Impala-ASF-CR] IMPALA-9199: Add support for single query retries on cluster membership changes

2020-01-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14824 ) Change subject: IMPALA-9199: Add support for single query retries on cluster membership changes .. IMPALA-9199: Add support for single qu

[Impala-ASF-CR] IMPALA-9068: Use different directories for external vs managed warehouse

2020-01-23 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15026 ) Change subject: IMPALA-9068: Use different directories for external vs managed warehouse .. Patch Set 6: Code-Review+2 -- To view, vi

[Impala-ASF-CR] IMPALA-9068: Use different directories for external vs managed warehouse

2020-01-23 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15026 ) Change subject: IMPALA-9068: Use different directories for external vs managed warehouse .. Patch Set 3: Code-Review+1 (2 comments) L

[Impala-ASF-CR] IMPALA-8778: Support Apache Hudi Read Optimized Table

2020-01-22 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14711 ) Change subject: IMPALA-8778: Support Apache Hudi Read Optimized Table .. Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-8778: Support Apache Hudi Read Optimized Table

2020-01-21 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14711 ) Change subject: IMPALA-8778: Support Apache Hudi Read Optimized Table .. Patch Set 16: (12 comments) does this allow writing to Hudi P

[Impala-ASF-CR] IMPALA-8205: Support number of true and false statistics for boolean column

2020-01-21 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14666 ) Change subject: IMPALA-8205: Support number of true and false statistics for boolean column .. Patch Set 6: (8 comments) does this i

[Impala-ASF-CR] IMPALA-9068: Use different directories for external vs managed warehouse

2020-01-20 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15026 ) Change subject: IMPALA-9068: Use different directories for external vs managed warehouse .. Patch Set 3: (1 comment) http://gerrit.cl

[Impala-ASF-CR] IMPALA-9068: Use different directories for external vs managed warehouse

2020-01-17 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15026 ) Change subject: IMPALA-9068: Use different directories for external vs managed warehouse .. Patch Set 3: (4 comments) http://gerrit.c

[Impala-ASF-CR] IMPALA-9296: Move AuxErrorInfo to StatefulStatus

2020-01-16 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15046 ) Change subject: IMPALA-9296: Move AuxErrorInfo to StatefulStatus .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/1504

[Impala-ASF-CR] IMPALA-9296: Move AuxErrorInfo to StatefulStatus

2020-01-16 Thread Sahil Takiar (Code Review)
Hello Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15046 to look at the new patch set (#2). Change subject: IMPALA-9296: Move AuxErrorInfo to StatefulStatus ...

[Impala-ASF-CR] IMPALA-9296: Move AuxErrorInfo to StatefulStatus

2020-01-15 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15046 Change subject: IMPALA-9296: Move AuxErrorInfo to StatefulStatus .. IMPALA-9296: Move AuxErrorInfo to StatefulStatus This patch moves Au

[Impala-ASF-CR] IMPALA-9295: Read aux error info regardless of overall query status

2020-01-14 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15027 ) Change subject: IMPALA-9295: Read aux error info regardless of overall query status .. Patch Set 3: Code-Review+2 Carrying +2 -- To

[Impala-ASF-CR] IMPALA-9295: Read aux error info regardless of overall query status

2020-01-14 Thread Sahil Takiar (Code Review)
Hello Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15027 to look at the new patch set (#3). Change subject: IMPALA-9295: Read aux error info regardless of overall query status ...

[Impala-ASF-CR] IMPALA-9295: Read aux error info regardless of overall query status

2020-01-14 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15027 ) Change subject: IMPALA-9295: Read aux error info regardless of overall query status .. Patch Set 2: Test failure is unrelated (IMPALA-

[Impala-ASF-CR] IMPALA-9295: Read aux error info regardless of overall query status

2020-01-13 Thread Sahil Takiar (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15027 to look at the new patch set (#2). Change subject: IMPALA-9295: Read aux error info regardless of overall query status ...

[Impala-ASF-CR] IMPALA-9295: Read aux error info regardless of overall query status

2020-01-13 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15027 ) Change subject: IMPALA-9295: Read aux error info regardless of overall query status .. Patch Set 1: (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-9295: Read aux error info regardless of overall query status

2020-01-13 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15027 Change subject: IMPALA-9295: Read aux error info regardless of overall query status .. IMPALA-9295: Read aux error info regardless of ov

[Impala-ASF-CR] IMPALA-9267: Fix DCHECK in ClientRequestState::UpdateNonErrorExecState

2020-01-13 Thread Sahil Takiar (Code Review)
Sahil Takiar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14991 ) Change subject: IMPALA-9267: Fix DCHECK in ClientRequestState::UpdateNonErrorExecState .. IMPALA-9267: Fix DCHECK in ClientRequ

[Impala-ASF-CR] IMPALA-9293: [DOCS] Impala Doc: Revise explanation of HDFS trashcan usage on S3

2020-01-13 Thread Sahil Takiar (Code Review)
Sahil Takiar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15022 ) Change subject: IMPALA-9293: [DOCS] Impala Doc: Revise explanation of HDFS trashcan usage on S3 .. IMPALA-9293: [DOCS] Impala D

[Impala-ASF-CR] IMPALA-8501: Fix race condition on port in RpcMgrTest

2020-01-13 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14997 ) Change subject: IMPALA-8501: Fix race condition on port in RpcMgrTest .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-9262: De-flake TestBlacklist::test kill impalad with running queries

2020-01-13 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14985 ) Change subject: IMPALA-9262: De-flake TestBlacklist::test_kill_impalad_with_running_queries .. Patch Set 3: Code-Review+2 Carrying +2.

[Impala-ASF-CR] IMPALA-9262: De-flake TestBlacklist::test kill impalad with running queries

2020-01-13 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14985 ) Change subject: IMPALA-9262: De-flake TestBlacklist::test_kill_impalad_with_running_queries .. Patch Set 3: (1 comment) http://gerrit

[Impala-ASF-CR] IMPALA-9262: De-flake TestBlacklist::test kill impalad with running queries

2020-01-13 Thread Sahil Takiar (Code Review)
Hello Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14985 to look at the new patch set (#3). Change subject: IMPALA-9262: De-flake TestBlacklist::test_kill_impalad_with_running_queries ...

[Impala-ASF-CR] IMPALA-9293: [DOCS] Impala Doc: Revise explanation of HDFS trashcan usage on S3

2020-01-13 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15022 Change subject: IMPALA-9293: [DOCS] Impala Doc: Revise explanation of HDFS trashcan usage on S3 .. IMPALA-9293: [DOCS] Impala Doc: Revis

[Impala-ASF-CR] IMPALA-9267: Fix DCHECK in ClientRequestState::UpdateNonErrorExecState

2020-01-13 Thread Sahil Takiar (Code Review)
Hello Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14991 to look at the new patch set (#2). Change subject: IMPALA-9267: Fix DCHECK in ClientRequestState::UpdateNonErrorExecState

[Impala-ASF-CR] IMPALA-9267: Fix DCHECK in ClientRequestState::UpdateNonErrorExecState

2020-01-13 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14991 ) Change subject: IMPALA-9267: Fix DCHECK in ClientRequestState::UpdateNonErrorExecState .. Patch Set 1: (1 comment) http://gerrit.clou

[Impala-ASF-CR] IMPALA-9262: De-flake TestBlacklist::test kill impalad with running queries

2020-01-13 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14985 ) Change subject: IMPALA-9262: De-flake TestBlacklist::test_kill_impalad_with_running_queries .. Patch Set 2: Verified+1 Carrying Jenkin

[Impala-ASF-CR] IMPALA-9262: De-flake TestBlacklist::test kill impalad with running queries

2020-01-13 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14985 ) Change subject: IMPALA-9262: De-flake TestBlacklist::test_kill_impalad_with_running_queries .. Patch Set 1: (2 comments) Test ran suc

[Impala-ASF-CR] IMPALA-9262: De-flake TestBlacklist::test kill impalad with running queries

2020-01-13 Thread Sahil Takiar (Code Review)
Hello Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14985 to look at the new patch set (#2). Change subject: IMPALA-9262: De-flake TestBlacklist::test_kill_impalad_with_running_queries ...

[Impala-ASF-CR] IMPALA-9267: Fix DCHECK in ClientRequestState::UpdateNonErrorExecState

2020-01-08 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14991 Change subject: IMPALA-9267: Fix DCHECK in ClientRequestState::UpdateNonErrorExecState .. IMPALA-9267: Fix DCHECK in ClientRequestState:

[Impala-ASF-CR] IMPALA-9262: De-flake TestBlacklist::test kill impalad with running queries

2020-01-07 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14985 Change subject: IMPALA-9262: De-flake TestBlacklist::test_kill_impalad_with_running_queries .. IMPALA-9262: De-flake TestBlacklist::test

[Impala-ASF-CR] IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails

2019-12-18 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14677 ) Change subject: IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails .. Patch Set 12: (7 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails

2019-12-18 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14677 to look at the new patch set (#13). Change subject: IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails

[Impala-ASF-CR] IMPALA-7117: Lower debug level for HDFS S3 connector back to INFO

2019-12-18 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14926 Change subject: IMPALA-7117: Lower debug level for HDFS S3 connector back to INFO .. IMPALA-7117: Lower debug level for HDFS S3 connecto

[Impala-ASF-CR] IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails

2019-12-16 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14677 ) Change subject: IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails .. Patch Set 12: > Depends on the particular

[Impala-ASF-CR] IMPALA-8547: get json object fails to get value for numeric key

2019-12-16 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14905 ) Change subject: IMPALA-8547: get_json_object fails to get value for numeric key .. Patch Set 1: (1 comment) Thanks for the contributio

[Impala-ASF-CR] IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails

2019-12-13 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14677 ) Change subject: IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails .. Patch Set 12: Responding to comments from

[Impala-ASF-CR] IMPALA-9138: Classify certain errors as retryable

2019-12-12 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14882 ) Change subject: IMPALA-9138: Classify certain errors as retryable .. Patch Set 2: Updated patch addressing Thomas' comments. The most

[Impala-ASF-CR] IMPALA-9138: Classify certain errors as retryable

2019-12-12 Thread Sahil Takiar (Code Review)
Hello Thomas Tauber-Marshall, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14882 to look at the new patch set (#2). Change subject: IMPALA-9138: Classify certain errors as retryable .

[Impala-ASF-CR] IMPALA-9138: Classify certain errors as retryable

2019-12-12 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14882 ) Change subject: IMPALA-9138: Classify certain errors as retryable .. Patch Set 1: > (1 comment) Yeah, that is a good point wrt one fra

[Impala-ASF-CR] IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails

2019-12-12 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14677 ) Change subject: IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails .. Patch Set 12: (4 comments) Updated patch.

[Impala-ASF-CR] IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails

2019-12-12 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14677 to look at the new patch set (#12). Change subject: IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails

[Impala-ASF-CR] IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails

2019-12-11 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14677 ) Change subject: IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails .. Patch Set 10: (11 comments) Addressed all

[Impala-ASF-CR] IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails

2019-12-11 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14677 to look at the new patch set (#11). Change subject: IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails

[Impala-ASF-CR] IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails

2019-12-11 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14677 ) Change subject: IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails .. Patch Set 10: (1 comment) http://gerrit.c

[Impala-ASF-CR] IMPALA-6894: Use an internal representation of query states in ClientRequestState

2019-12-11 Thread Sahil Takiar (Code Review)
Sahil Takiar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14744 ) Change subject: IMPALA-6894: Use an internal representation of query states in ClientRequestState .. IMPALA-6894: Use an intern

[Impala-ASF-CR] IMPALA-6894: Use an internal representation of query states in ClientRequestState

2019-12-11 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14744 ) Change subject: IMPALA-6894: Use an internal representation of query states in ClientRequestState .. Patch Set 11: Code-Review+2 -- T

[Impala-ASF-CR] IMPALA-6894: Use an internal representation of query states in ClientRequestState

2019-12-11 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14744 ) Change subject: IMPALA-6894: Use an internal representation of query states in ClientRequestState .. Patch Set 11: Carrying +2. -- T

[Impala-ASF-CR] IMPALA-9138: Classify certain errors as retryable

2019-12-10 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14882 ) Change subject: IMPALA-9138: Classify certain errors as retryable .. Patch Set 1: There has been some back on forth on whether this is

[Impala-ASF-CR] IMPALA-9124 [POC][WIP]: Transparently retry queries that fail due to cluster membership changes

2019-12-10 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14824 ) Change subject: IMPALA-9124 [POC][WIP]: Transparently retry queries that fail due to cluster membership changes .. Patch Set 1: Whoops

[Impala-ASF-CR] IMPALA-9124 [POC][WIP]: Transparently retry queries that fail due to cluster membership changes

2019-12-10 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14824 Change subject: IMPALA-9124 [POC][WIP]: Transparently retry queries that fail due to cluster membership changes .. IMPALA-9124 [POC][WIP

[Impala-ASF-CR] IMPALA-9138: Classify certain errors as retryable

2019-12-10 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14882 Change subject: IMPALA-9138: Classify certain errors as retryable .. IMPALA-9138: Classify certain errors as retryable This patch modifi

[Impala-ASF-CR] IMPALA-6894: Use an internal representation of query states in ClientRequestState

2019-12-10 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14744 ) Change subject: IMPALA-6894: Use an internal representation of query states in ClientRequestState .. Patch Set 10: (1 comment) http:/

[Impala-ASF-CR] IMPALA-6894: Use an internal representation of query states in ClientRequestState

2019-12-10 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14744 to look at the new patch set (#10). Change subject: IMPALA-6894: Use an internal representation of query states in ClientR

[Impala-ASF-CR] IMPALA-6894: Use an internal representation of query states in ClientRequestState

2019-12-10 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14744 ) Change subject: IMPALA-6894: Use an internal representation of query states in ClientRequestState .. Patch Set 9: I'm not entirely sur

[Impala-ASF-CR] IMPALA-9209: Fix flakiness in test end data stream error

2019-12-10 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14870 ) Change subject: IMPALA-9209: Fix flakiness in test_end_data_stream_error .. Patch Set 1: Code-Review+2 (3 comments) Minor comments, ot

[Impala-ASF-CR] IMPALA-6894: Use an internal representation of query states in ClientRequestState

2019-12-09 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14744 to look at the new patch set (#9). Change subject: IMPALA-6894: Use an internal representation of query states in ClientRe

[Impala-ASF-CR] IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails

2019-12-09 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14677 ) Change subject: IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails .. Patch Set 9: (7 comments) http://gerrit.c

[Impala-ASF-CR] IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails

2019-12-09 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14677 to look at the new patch set (#10). Change subject: IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails .

[Impala-ASF-CR] IMPALA-9124: ImpalaServer and ClientRequestState refactoring

2019-12-09 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14755 ) Change subject: IMPALA-9124: ImpalaServer and ClientRequestState refactoring .. Patch Set 11: Code-Review+2 Fixing build failure (forgo

[Impala-ASF-CR] IMPALA-9124: ImpalaServer and ClientRequestState refactoring

2019-12-09 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14755 to look at the new patch set (#11). Change subject: IMPALA-9124: ImpalaServer and ClientRequestState refactoring .

[Impala-ASF-CR] IMPALA-9124: ImpalaServer and ClientRequestState refactoring

2019-12-03 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14755 ) Change subject: IMPALA-9124: ImpalaServer and ClientRequestState refactoring .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-9124: ImpalaServer and ClientRequestState refactoring

2019-12-03 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14755 to look at the new patch set (#9). Change subject: IMPALA-9124: ImpalaServer and ClientRequestState refactoring ..

[Impala-ASF-CR] IMPALA-9124: ImpalaServer and ClientRequestState refactoring

2019-12-03 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14755 to look at the new patch set (#8). Change subject: IMPALA-9124: ImpalaServer and ClientRequestState refactoring ..

[Impala-ASF-CR] IMPALA-9124: ImpalaServer and ClientRequestState refactoring

2019-12-03 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14755 ) Change subject: IMPALA-9124: ImpalaServer and ClientRequestState refactoring .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-9124: ImpalaServer and ClientRequestState refactoring

2019-12-03 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14755 to look at the new patch set (#7). Change subject: IMPALA-9124: ImpalaServer and ClientRequestState refactoring ..

[Impala-ASF-CR] IMPALA-9124: ImpalaServer and ClientRequestState refactoring

2019-12-03 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14755 ) Change subject: IMPALA-9124: ImpalaServer and ClientRequestState refactoring .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails

2019-12-03 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/14677 ) Change subject: IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails .. IMPALA-9137: Blacklist node if a DataStreamSe

[Impala-ASF-CR] IMPALA-6894: Use an internal representation of query states in ClientRequestState

2019-12-03 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/14744 ) Change subject: IMPALA-6894: Use an internal representation of query states in ClientRequestState .. IMPALA-6894: Use an internal represe

[Impala-ASF-CR] IMPALA-9124: ImpalaServer and ClientRequestState refactoring

2019-12-03 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/14755 ) Change subject: IMPALA-9124: ImpalaServer and ClientRequestState refactoring .. IMPALA-9124: ImpalaServer and ClientRequestState refactori

[Impala-ASF-CR] IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails

2019-12-02 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14677 ) Change subject: IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails .. Patch Set 8: Added a new test and fixed a

[Impala-ASF-CR] IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails

2019-12-02 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14677 to look at the new patch set (#8). Change subject: IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails ..

[Impala-ASF-CR] IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails

2019-12-02 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14677 to look at the new patch set (#7). Change subject: IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails ..

[Impala-ASF-CR] IMPALA-6894: Use an internal representation of query states in ClientRequestState

2019-12-02 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14744 ) Change subject: IMPALA-6894: Use an internal representation of query states in ClientRequestState .. Patch Set 5: Code-Review+2 Carryi

[Impala-ASF-CR] IMPALA-6894: Use an internal representation of query states in ClientRequestState

2019-12-02 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14744 ) Change subject: IMPALA-6894: Use an internal representation of query states in ClientRequestState .. Patch Set 5: Removed the new asse

[Impala-ASF-CR] IMPALA-6894: Use an internal representation of query states in ClientRequestState

2019-12-02 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14744 to look at the new patch set (#5). Change subject: IMPALA-6894: Use an internal representation of query states in ClientRe

[Impala-ASF-CR] IMPALA-9124: ImpalaServer and ClientRequestState refactoring

2019-11-27 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14755 ) Change subject: IMPALA-9124: ImpalaServer and ClientRequestState refactoring .. Patch Set 5: I decided to remove the changes to the Imp

[Impala-ASF-CR] IMPALA-9124: ImpalaServer and ClientRequestState refactoring

2019-11-27 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14755 to look at the new patch set (#5). Change subject: IMPALA-9124: ImpalaServer and ClientRequestState refactoring ..

[Impala-ASF-CR] IMPALA-9202: Fix flakiness in test executor groups

2019-11-27 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14810 ) Change subject: IMPALA-9202: Fix flakiness in test_executor_groups .. Patch Set 1: Code-Review+1 LGTM -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails

2019-11-27 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14677 ) Change subject: IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails .. Patch Set 3: Basically re-wrote the patch.

[Impala-ASF-CR] IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails

2019-11-27 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14677 to look at the new patch set (#6). Change subject: IMPALA-9137: Blacklist node if a DataStreamService RPC to the node fails ..

[Impala-ASF-CR] IMPALA-9181: Serialize TQueryCtx once per query

2019-11-26 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14777 ) Change subject: IMPALA-9181: Serialize TQueryCtx once per query .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-9181: Serialize TQueryCtx once per query

2019-11-26 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14777 ) Change subject: IMPALA-9181: Serialize TQueryCtx once per query .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14777/

[Impala-ASF-CR] IMPALA-9137, IMPALA-9138: Mark failed RPCs as retryable and update blacklist

2019-11-25 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14677 ) Change subject: IMPALA-9137, IMPALA-9138: Mark failed RPCs as retryable and update blacklist .. Patch Set 3: (2 comments) http://gerr

[Impala-ASF-CR] IMPALA-9124: ImpalaServer and ClientRequestState refactoring

2019-11-25 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14755 to look at the new patch set (#4). Change subject: IMPALA-9124: ImpalaServer and ClientRequestState refactoring ..

[Impala-ASF-CR] IMPALA-9124: ImpalaServer and ClientRequestState refactoring

2019-11-25 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14755 ) Change subject: IMPALA-9124: ImpalaServer and ClientRequestState refactoring .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-9124: ImpalaServer and ClientRequestState refactoring

2019-11-25 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14755 to look at the new patch set (#3). Change subject: IMPALA-9124: ImpalaServer and ClientRequestState refactoring ..

[Impala-ASF-CR] IMPALA-9085: [DOCS] Refactored impala s3.xml

2019-11-25 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14627 ) Change subject: IMPALA-9085: [DOCS] Refactored impala_s3.xml .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.or

<    1   2   3   4   5   6   7   8   9   10   >