[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups .. Patch Set 16: Code-Review+2 (2

[Impala-ASF-CR] IMPALA-8806: Add metrics to improve observability of executor groups

2019-08-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13979 ) Change subject: IMPALA-8806: Add metrics to improve observability of executor groups .. Patch Set 4: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8806: Add metrics to improve observability of executor groups

2019-08-04 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13979 ) Change subject: IMPALA-8806: Add metrics to improve observability of executor groups .. Patch Set 2: Code-Review+1 (3 comments)

[Impala-ASF-CR] IMPALA-8615: [DOCS] Document the scalable admission control parameters

2019-07-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13906 ) Change subject: IMPALA-8615: [DOCS] Document the scalable admission control parameters .. Patch Set 2: (1 comment) This basically

[Impala-ASF-CR] IMPALA-8615: [DOCS] Document the scalable admission control parameters

2019-07-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13906 ) Change subject: IMPALA-8615: [DOCS] Document the scalable admission control parameters .. Patch Set 3: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-5149: Provide query profile in JSON format

2019-07-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13801 ) Change subject: IMPALA-5149: Provide query profile in JSON format .. Patch Set 8: Should the json include the explicit version

[Impala-ASF-CR] IMPALA-8858: Add metrics tracking num queries running on executor groups

2019-09-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add metrics tracking num queries running on executor groups .. Patch Set 19: Code-Review+2 Reviewed

[Impala-ASF-CR] IMPALA-8928: Add MEM LIMIT EXECUTORS query option

2019-09-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14294 ) Change subject: IMPALA-8928: Add MEM_LIMIT_EXECUTORS query option .. Patch Set 1: Code-Review+2 (2 comments) This looks nice and

[Impala-ASF-CR] IMPALA-8065 Edit OS version and Kernel version in OSInfo

2019-11-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 ) Change subject: IMPALA-8065 Edit OS version and Kernel version in OSInfo .. Patch Set 6: (2 comments) Still a few things to think

[Impala-ASF-CR] IMPALA-8065 Change the format OS version and Kernel version dispalyed in OSInfo

2019-11-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 ) Change subject: IMPALA-8065 Change the format OS version and Kernel version dispalyed in OSInfo .. Patch Set 7: (3 comments)

[Impala-ASF-CR] IMPALA-8065 Edit OS version and Kernel version in OSInfo

2019-10-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 ) Change subject: IMPALA-8065 Edit OS version and Kernel version in OSInfo .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8065 Add OS version and Kernel version in OSInfo

2019-10-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 ) Change subject: IMPALA-8065 Add OS version and Kernel version in OSInfo .. Patch Set 3: (8 comments) Code looks good, Comments and

[Impala-ASF-CR] IMPALA-8065 Change the format OS version and Kernel version dispalyed in OSInfo

2019-11-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 ) Change subject: IMPALA-8065 Change the format OS version and Kernel version dispalyed in OSInfo .. Patch Set 8: The code all seems

[Impala-ASF-CR] IMPALA-8065: Add OS distribution name in OSInfo

2019-11-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 ) Change subject: IMPALA-8065: Add OS distribution name in OSInfo .. Patch Set 9: Code-Review+2 Thanks Xiaomeng LGTM -- To view,

[Impala-ASF-CR] IMPALA-9151: Maintain cluster size in ExecutorMembershipSnapshot

2019-11-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14756 ) Change subject: IMPALA-9151: Maintain cluster size in ExecutorMembershipSnapshot .. Patch Set 1: Code-Review+2 (5 comments) LGTM I

[Impala-ASF-CR] IMPALA-7550: Add documentation to profile counters

2019-12-04 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14837 ) Change subject: IMPALA-7550: Add documentation to profile counters .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Update gitignore files

2019-12-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14858 ) Change subject: Update gitignore files .. Patch Set 1: Code-Review+2 LGTM -- To view, visit http://gerrit.cloudera.org:8080/14858

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-10-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571: harden QueryEventHook execution .. Patch Set 28: (5 comments) Just a few replies to your useful

[Impala-ASF-CR] IMPALA-7504 ParseKerberosPrincipal() should use krb5 parse name() instead

2019-10-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14433 ) Change subject: IMPALA-7504 ParseKerberosPrincipal() should use krb5_parse_name() instead .. Patch Set 4: (1 comment) Commit

[Impala-ASF-CR] IMPALA-7504/KUDU-2979 ParseKerberosPrincipal() should use krb5 parse name() instead

2019-10-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14433 ) Change subject: IMPALA-7504/KUDU-2979 ParseKerberosPrincipal() should use krb5_parse_name() instead .. Patch Set 5: (7 comments)

[Impala-ASF-CR] IMPALA-9034: fix distcc+ccache

2019-10-15 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14408 ) Change subject: IMPALA-9034: fix distcc+ccache .. Patch Set 3: Code-Review+2 (1 comment) Thanks for fixing the lock-up

[Impala-ASF-CR] IMPALA-7504 ParseKerberosPrincipal() should use krb5 parse name() instead

2019-10-15 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14433 ) Change subject: IMPALA-7504 ParseKerberosPrincipal() should use krb5_parse_name() instead .. Patch Set 2: (10 comments) Thanks for

[Impala-ASF-CR] IMPALA-7504/KUDU-2979 ParseKerberosPrincipal() should use krb5 parse name() instead

2019-10-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14433 ) Change subject: IMPALA-7504/KUDU-2979 ParseKerberosPrincipal() should use krb5_parse_name() instead .. Patch Set 7: Code-Review+2

[Impala-ASF-CR] IMPALA-8065 OSInfo produces somewhat misleading output when running in container

2019-10-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 ) Change subject: IMPALA-8065 OSInfo produces somewhat misleading output when running in container .. Patch Set 2: (7 comments)

[Impala-ASF-CR] IMPALA-7504/KUDU-2979 ParseKerberosPrincipal() should use krb5 parse name() instead

2019-10-23 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14433 ) Change subject: IMPALA-7504/KUDU-2979 ParseKerberosPrincipal() should use krb5_parse_name() instead .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-10-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571: harden QueryEventHook execution .. Patch Set 28: (25 comments) Hi Radford. As Bharath and Fredy have

[Impala-ASF-CR] IMPALA-8065 OSInfo produces somewhat misleading output when running in container

2019-10-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 ) Change subject: IMPALA-8065 OSInfo produces somewhat misleading output when running in container .. Patch Set 1: (2 comments) A

[Impala-ASF-CR] IMPALA-8998: admission control accounting for mt dop

2019-10-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14357 ) Change subject: IMPALA-8998: admission control accounting for mt_dop .. Patch Set 12: (2 comments)

[Impala-ASF-CR] IMPALA-9034: fix distcc+ccache

2019-10-11 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14408 ) Change subject: IMPALA-9034: fix distcc+ccache .. Patch Set 1: Code-Review+2 This LGTM. ... when I took this code and ran with it I

[Impala-ASF-CR] IMPALA-9240: add HTTP code handling to THttpClient.

2019-12-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14924 ) Change subject: IMPALA-9240: add HTTP code handling to THttpClient. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-9240: add HTTP code handling to THttpClient.

2019-12-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14924 ) Change subject: IMPALA-9240: add HTTP code handling to THttpClient. .. Patch Set 3: Code-Review+2 pull forward +2 -- To view,

[Impala-ASF-CR] IMPALA-9240: add HTTP code handling to THttpClient.

2019-12-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/14924 ) Change subject: IMPALA-9240: add HTTP code handling to THttpClient. .. IMPALA-9240: add HTTP code handling to THttpClient. Before this

[Impala-ASF-CR] IMPALA-9240: add HTTP code handling to THttpClient.

2019-12-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14924 Change subject: IMPALA-9240: add HTTP code handling to THttpClient. .. IMPALA-9240: add HTTP code handling to THttpClient. Before

[Impala-ASF-CR] IMPALA-9240: add HTTP code handling to THttpClient.

2019-12-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14924 ) Change subject: IMPALA-9240: add HTTP code handling to THttpClient. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-9240: add HTTP code handling to THttpClient.

2019-12-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14924 ) Change subject: IMPALA-9240: add HTTP code handling to THttpClient. .. IMPALA-9240: add HTTP code handling to THttpClient. Before this

[Impala-ASF-CR] IMPALA-9384: Improve Impala shell usability by automatically enable live progress in the interactive mode

2020-02-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15219 ) Change subject: IMPALA-9384: Improve Impala shell usability by automatically enable live_progress in the interactive mode .. Patch

[Impala-ASF-CR] IMPALA-9075: Add support for reading zstd text files

2020-02-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15023 ) Change subject: IMPALA-9075: Add support for reading zstd text files .. Patch Set 8: Code-Review+2 LGTM thanks Xiaomeng and Abhishek

[Impala-ASF-CR] IMPALA-8852: Skip short-circuit config check for dedicated coordinator

2020-02-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15173 ) Change subject: IMPALA-8852: Skip short-circuit config check for dedicated coordinator .. Patch Set 10: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-9389: [DOCS] Support reading zstd text files

2020-02-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15304 ) Change subject: IMPALA-9389: [DOCS] Support reading zstd text files .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9384: Improve Impala shell usability by automatically enable live progress in the interactive mode

2020-02-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15219 ) Change subject: IMPALA-9384: Improve Impala shell usability by automatically enable live_progress in the interactive mode .. Patch

[Impala-ASF-CR] IMPALA-9431 [DOCS] Update docs to reflect Deflate is supported for text files

2020-03-04 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15310 ) Change subject: IMPALA-9431 [DOCS] Update docs to reflect Deflate is supported for text files .. Patch Set 3: (1 comment) A quick

[Impala-ASF-CR] IMPALA-9384: Improve Impala shell usability by enabling live progress in interactive mode

2020-03-03 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15219 ) Change subject: IMPALA-9384: Improve Impala shell usability by enabling live_progress in interactive mode .. Patch Set 3: (3

[Impala-ASF-CR] IMPALA-9431 [DOCS] Update docs to reflect Deflate is supported for text files

2020-03-06 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15310 ) Change subject: IMPALA-9431 [DOCS] Update docs to reflect Deflate is supported for text files .. Patch Set 5: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-9389: [DOCS] Support reading zstd text files

2020-02-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15304 ) Change subject: IMPALA-9389: [DOCS] Support reading zstd text files .. Patch Set 2: (1 comment) I think (Abhishek and Xiaomeng to

[Impala-ASF-CR] IMPALA-9075: Add support for reading zstd text files

2020-01-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15023 ) Change subject: IMPALA-9075: Add support for reading zstd text files .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8852: Skipping short-circuit config check for coordinator only

2020-02-06 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15173 ) Change subject: IMPALA-8852: Skipping short-circuit config check for coordinator only .. Patch Set 2: (5 comments) Thanks for the

[Impala-ASF-CR] IMPALA-9075: Add support for reading zstd text files

2020-01-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15023 ) Change subject: IMPALA-9075: Add support for reading zstd text files .. Patch Set 5: Code-Review+1 LGTM, @arawat will review to +2

[Impala-ASF-CR] IMPALA-8852: Skip short-circuit config check for coordinator-only mode

2020-02-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15173 ) Change subject: IMPALA-8852: Skip short-circuit config check for coordinator-only mode .. Patch Set 3: Code-Review+1 LGTM Giving +1

[Impala-ASF-CR] IMPALA-9075: Add support for reading zstd text files

2020-01-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15023 ) Change subject: IMPALA-9075: Add support for reading zstd text files .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8852: Skip short-circuit config check for coordinator-only mode

2020-02-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15173 ) Change subject: IMPALA-8852: Skip short-circuit config check for coordinator-only mode .. Patch Set 4: Code-Review+2 LGTM, thanks

[Impala-ASF-CR] IMPALA-9274: cyclic barrier implementation

2020-01-03 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14973 ) Change subject: IMPALA-9274: cyclic barrier implementation .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-9241: Remove pid files on successful shutdown of minicluster

2019-12-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14950 ) Change subject: IMPALA-9241: Remove pid files on successful shutdown of minicluster .. Patch Set 1: Code-Review+2 LGTM -- To

[Impala-ASF-CR] IMPALA-9666 Correct a log message in TestImpalaShellInteractive

2020-04-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15751 Change subject: IMPALA-9666 Correct a log message in TestImpalaShellInteractive .. IMPALA-9666 Correct a log message in

[Impala-ASF-CR] IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode.

2020-04-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15752 Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode. .. IMPALA-9540 Test that

[Impala-ASF-CR] IMPALA-9665: Fixed database not found errors in query test.test insert

2020-04-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15766 ) Change subject: IMPALA-9665: Fixed database not found errors in query_test.test_insert .. Patch Set 1: Looks good, will wait for

[Impala-ASF-CR] IMPALA-9665: Fixed database not found errors in query test.test insert

2020-04-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15766 ) Change subject: IMPALA-9665: Fixed database not found errors in query_test.test_insert .. Patch Set 2: Code-Review+2 LGTM -- To

[Impala-ASF-CR] IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly

2020-03-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15607 ) Change subject: IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly .. Patch Set 2: (2 comments)

[native-toolchain-CR] Patch Thrift to 0.9.3-p8 to remove a duplicate 'Host' header in http messages.

2020-03-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15620 Change subject: Patch Thrift to 0.9.3-p8 to remove a duplicate 'Host' header in http messages. .. Patch Thrift to 0.9.3-p8 to remove

[Impala-ASF-CR] IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly

2020-04-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15607 ) Change subject: IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly .. Patch Set 3: Code-Review+2

[native-toolchain-CR] Patch Thrift to 0.9.3-p8 to remove a duplicate 'Host' header in http messages.

2020-04-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15620 ) Change subject: Patch Thrift to 0.9.3-p8 to remove a duplicate 'Host' header in http messages. .. Patch Set 1: Verified+1 -- To

[native-toolchain-CR] Patch Thrift to 0.9.3-p8 to remove a duplicate 'Host' header in http messages.

2020-04-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15620 ) Change subject: Patch Thrift to 0.9.3-p8 to remove a duplicate 'Host' header in http messages. .. Patch Thrift to 0.9.3-p8

[Impala-ASF-CR] IMPALA-9681: Fix LdapImpalaShellTest

2020-04-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15777 ) Change subject: IMPALA-9681: Fix LdapImpalaShellTest .. Patch Set 1: Code-Review+2 Thanks for fixing this -- To view, visit

[Impala-ASF-CR] IMPALA-9574: support ubuntu 18.04 base image

2020-04-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15765 ) Change subject: IMPALA-9574: support ubuntu 18.04 base image .. Patch Set 2: Code-Review+2 (1 comment) LGTM

[Impala-ASF-CR] IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode.

2020-04-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15752 ) Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode. .. Patch Set 1: (1

[Impala-ASF-CR] IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode.

2020-05-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15752 ) Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode. .. Patch Set 1: (1

[Impala-ASF-CR] IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode.

2020-05-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/15752 ) Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode. .. IMPALA-9540 Test that

[Impala-ASF-CR] IMPALA-9743: Fix ExprCardinalityTest may not be marked as in test env

2020-05-23 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15982 ) Change subject: IMPALA-9743: Fix ExprCardinalityTest may not be marked as in test env .. Patch Set 1: Code-Review+2 LGTM -- To

[Impala-ASF-CR] IMPALA-10244: Make non-scalable failures to dequeue observable.

2020-10-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16613 Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable. .. IMPALA-10244: Make non-scalable failures to dequeue

[Impala-ASF-CR] IMPALA-10244: Make non-scalable failures to dequeue observable.

2020-10-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16613 ) Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable. .. IMPALA-10244: Make non-scalable failures to dequeue

[Impala-ASF-CR] IMPALA-7714: try to avoid be test crash in statestore

2020-08-14 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16341 ) Change subject: IMPALA-7714: try to avoid be test crash in statestore .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7714: try to avoid be test crash in statestore

2020-08-14 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16341 ) Change subject: IMPALA-7714: try to avoid be test crash in statestore .. Patch Set 2: Code-Review+2 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-10244: Make non-scalable failures to dequeue observable.

2020-10-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16613 ) Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable. .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-9909: Print body of http error code in Impala Shell.

2020-08-03 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16269 Change subject: IMPALA-9909: Print body of http error code in Impala Shell. .. IMPALA-9909: Print body of http error code in Impala

[Impala-ASF-CR] IMPALA-9909: Print body of http error code in Impala Shell.

2020-08-03 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16269 ) Change subject: IMPALA-9909: Print body of http error code in Impala Shell. .. IMPALA-9909: Print body of http error code in Impala

[Impala-ASF-CR] IMPALA-10052: Expose daemon health endpoint for statestore and catalog

2020-08-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16295 ) Change subject: IMPALA-10052: Expose daemon health endpoint for statestore and catalog .. Patch Set 2: Code-Review+2 LGTM -- To

[Impala-ASF-CR] IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode.

2020-06-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15752 ) Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode. .. Patch Set 5:

[Impala-ASF-CR] IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode.

2020-06-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/15752 ) Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode. .. IMPALA-9540 Test that

[Impala-ASF-CR] IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode.

2020-06-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/15752 ) Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode. .. IMPALA-9540 Test that

[Impala-ASF-CR] IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode.

2020-06-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/15752 ) Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate "Host" headers in http mode. .. IMPALA-9540 Test that

[Impala-ASF-CR] IMPALA-3695: Remove KUDU IS SUPPORTED

2020-06-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16085 ) Change subject: IMPALA-3695: Remove KUDU_IS_SUPPORTED .. Patch Set 4: Code-Review+2 This looks safe and a good cleanup. I did look

[Impala-ASF-CR] IMPALA-9871: Simplify OS version matching for SLES in bootstrap toolchain.py

2020-06-23 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16102 ) Change subject: IMPALA-9871: Simplify OS version matching for SLES in bootstrap_toolchain.py .. Patch Set 1: Code-Review+2 LGTM

[Impala-ASF-CR] IMPALA-9829: Add Write Metrics for Spilling

2020-06-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16083 ) Change subject: IMPALA-9829: Add Write Metrics for Spilling .. Patch Set 10: (13 comments) Good change! I like the detailed unit

[Impala-ASF-CR] IMPALA-9790: option to use resolved hostname everywhere

2020-06-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16108 ) Change subject: IMPALA-9790: option to use resolved hostname everywhere .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9829: Add Write Metrics for Spilling

2020-06-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16083 ) Change subject: IMPALA-9829: Add Write Metrics for Spilling .. Patch Set 13: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9885: debug action for planner

2020-06-23 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16104 ) Change subject: IMPALA-9885: debug action for planner .. Patch Set 2: Code-Review+2 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-9077: Remove scalable admission control configs

2020-06-08 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16039 ) Change subject: IMPALA-9077: Remove scalable admission control configs .. Patch Set 4: Code-Review+2 (2 comments) This looks pretty

[Impala-ASF-CR] IMPALA-10006: handle non-writable /opt/impala/logs

2020-07-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16237 ) Change subject: IMPALA-10006: handle non-writable /opt/impala/logs .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10373: Run impala docker containers with uid/gid 1000

2020-12-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16807 ) Change subject: IMPALA-10373: Run impala docker containers with uid/gid 1000 .. Patch Set 1: Code-Review+2 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-10309: Use sleep time from a Retry-After header in Impala Shell

2020-11-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16702 ) Change subject: IMPALA-10309: Use sleep time from a Retry-After header in Impala Shell .. IMPALA-10309: Use sleep time from a

[Impala-ASF-CR] IMPALA-10309: Use sleep time from a Retry-After header in Impala Shell

2020-11-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16702 ) Change subject: IMPALA-10309: Use sleep time from a Retry-After header in Impala Shell .. IMPALA-10309: Use sleep time from a

[Impala-ASF-CR] IMPALA-10309: Use sleep time from a Retry-After header in Impala Shell

2020-11-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16702 Change subject: IMPALA-10309: Use sleep time from a Retry-After header in Impala Shell .. IMPALA-10309: Use sleep time from a

[Impala-ASF-CR] IMPALA-10249: Fix the flaky TestImpalaShell.test queries closed test.

2020-11-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16743 Change subject: IMPALA-10249: Fix the flaky TestImpalaShell.test_queries_closed test. .. IMPALA-10249: Fix the flaky

[Impala-ASF-CR] IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to 0.11.0-p4

2020-11-09 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16700 ) Change subject: IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to 0.11.0-p4 .. Patch Set 2: Code-Review+2 LGTM -- To

[Impala-ASF-CR] IMPALA-10244: Make non-scalable failures to dequeue observable.

2020-10-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16613 ) Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable. .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-10244: Make non-scalable failures to dequeue observable.

2020-10-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16613 ) Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable. .. IMPALA-10244: Make non-scalable failures to dequeue

[Impala-ASF-CR] IMPALA-10244: Make non-scalable failures to dequeue observable.

2020-10-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16613 ) Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10244: Make non-scalable failures to dequeue observable.

2020-10-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16613 ) Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable. .. IMPALA-10244: Make non-scalable failures to dequeue

[Impala-ASF-CR] IMPALA-10244: Make non-scalable failures to dequeue observable.

2020-10-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16613 ) Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10303: Fix warnings from impala-shell with --quiet

2020-10-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16673 ) Change subject: IMPALA-10303: Fix warnings from impala-shell with --quiet .. Patch Set 2: Code-Review+2 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-10447: Add a newline when exporting shell output to a file.

2021-01-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16966 Change subject: IMPALA-10447: Add a newline when exporting shell output to a file. .. IMPALA-10447: Add a newline when exporting

<    1   2   3   4   5   6   7   >