[Impala-ASF-CR] IMPALA-7961: Avoid adding unmodified objects to DDL response

2019-02-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12428 ) Change subject: IMPALA-7961: Avoid adding unmodified objects to DDL response .. Patch Set 6: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7961: Avoid adding unmodified objects to DDL response

2019-02-13 Thread Bharath Vissapragada (Code Review)
Hello Paul Rogers, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12428 to look at the new patch set (#6). Change subject: IMPALA-7961: Avoid adding unmodified objects to DDL response

[Impala-ASF-CR] IMPALA-7976 : Add a flag to disable sync using events at a table level

2019-02-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12365 ) Change subject: IMPALA-7976 : Add a flag to disable sync using events at a table level .. Patch Set 8: Code-Review+1 I didn't

[Impala-ASF-CR] IMPALA-7560: Improve selectivity estimate for !=

2019-02-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12427 ) Change subject: IMPALA-7560: Improve selectivity estimate for != .. Patch Set 3: Code-Review+2 (3 comments) Couple of nits.

[Impala-ASF-CR] IMPALA-7961: Avoid adding unmodified objects to DDL response

2019-02-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12428 ) Change subject: IMPALA-7961: Avoid adding unmodified objects to DDL response .. Patch Set 7: Looks like this change introduced

[Impala-ASF-CR] IMPALA-7927: Enhance Rewritten SQL in test files

2019-02-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12033 ) Change subject: IMPALA-7927: Enhance Rewritten SQL in test files .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7935: Disable /catalog object endpoint when local catalog mode is enabled.

2019-02-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 ) Change subject: IMPALA-7935: Disable /catalog_object endpoint when local_catalog_mode is enabled. .. Patch Set 1: (6

[Impala-ASF-CR] IMPALA-8177: Log DDL failures in coordinator logs

2019-02-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12414 ) Change subject: IMPALA-8177: Log DDL failures in coordinator logs .. Patch Set 4: Paul, this patch is just about the error

[Impala-ASF-CR] IMPALA-8177: Log DDL failures in coordinator logs

2019-02-10 Thread Bharath Vissapragada (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12414 to look at the new patch set (#4). Change subject: IMPALA-8177: Log DDL failures in coordinator logs

[Impala-ASF-CR] IMPALA-8177: Log DDL failures in coordinator logs

2019-02-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12414 ) Change subject: IMPALA-8177: Log DDL failures in coordinator logs .. Patch Set 4: Code-Review+2 There were merge conflicts.

[Impala-ASF-CR] Additions to .gitignore

2019-02-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12430 ) Change subject: Additions to .gitignore .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12430

[Impala-ASF-CR] IMPALA-7961: Avoid adding unmodified objects to DDL response

2019-02-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12428 Change subject: IMPALA-7961: Avoid adding unmodified objects to DDL response .. IMPALA-7961: Avoid adding unmodified objects to

[Impala-ASF-CR] IMPALA-7961: Avoid adding unmodified objects to DDL response

2019-02-14 Thread Bharath Vissapragada (Code Review)
Hello Paul Rogers, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12428 to look at the new patch set (#8). Change subject: IMPALA-7961: Avoid adding unmodified objects to DDL response

[Impala-ASF-CR] IMPALA-7961: Avoid adding unmodified objects to DDL response

2019-02-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12428 ) Change subject: IMPALA-7961: Avoid adding unmodified objects to DDL response .. Patch Set 8: Code-Review+2 Turns out the lock

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-02-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: IMPALA-5872: Testcase builder for query planner .. Patch Set 7: (9 comments) Thanks for your comments. I need

[Impala-ASF-CR] Enable full stacktrace logging with surefire

2019-02-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12370 Change subject: Enable full stacktrace logging with surefire .. Enable full stacktrace logging with surefire By default,

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-02-05 Thread Bharath Vissapragada (Code Review)
Hello Greg Rahn, Paul Rogers, Fredy Wijaya, Balazs Jeszenszky, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12221 to look at the new patch set (#7). Change subject: IMPALA-5872: Testcase builder for query planner

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

2019-02-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12248 ) Change subject: IMPALA-8095: Detailed expression cardinality tests .. Patch Set 7: (1 comment) Lgtm, just one pending

[Impala-ASF-CR] IMPALA-8156: Add format options to the EXPLAIN statement

2019-02-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12340 ) Change subject: IMPALA-8156: Add format options to the EXPLAIN statement .. Patch Set 1: (7 comments) I think this is super

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-02-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: IMPALA-5872: Testcase builder for query planner .. Patch Set 7: (1 comment) Fixed the tests that failed in

[Impala-ASF-CR] IMPALA-8181: Abbreviate row counts in EXPLAIN

2019-02-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12438 ) Change subject: IMPALA-8181: Abbreviate row counts in EXPLAIN .. Patch Set 6: Code-Review+2 (2 comments) Feel free to carry

[Impala-ASF-CR] IMPALA-8163: Add banner showing for local catalog mode when enabled.

2019-02-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12413 ) Change subject: IMPALA-8163: Add banner showing for local catalog mode when enabled. .. Patch Set 5: (4 comments) A bunch of

[Impala-ASF-CR] IMPALA-8177: Log DDL failures in coordinator logs

2019-02-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12414 ) Change subject: IMPALA-8177: Log DDL failures in coordinator logs .. Patch Set 2: I logged it at ERROR severity since we are

[Impala-ASF-CR] IMPALA-8163: Add banner showing local catalog mode on web UI when enabled.

2019-02-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12413 ) Change subject: IMPALA-8163: Add banner showing local catalog mode on web UI when enabled. .. Patch Set 10: Code-Review+2 --

[Impala-ASF-CR] IMPALA-6897: Catalog server web-ui should expose top-n tables with most number of file. The commit includes: Add functions in CatalogUsageMonitor to monitor and report the catalog

2019-02-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12483 ) Change subject: IMPALA-6897: Catalog server web-ui should expose top-n tables with most number of file. The commit includes: Add functions in CatalogUsageMonitor to monitor and report the

[Impala-ASF-CR] IMPALA-8181: Abbreviate row counts in EXPLAIN

2019-02-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12438 ) Change subject: IMPALA-8181: Abbreviate row counts in EXPLAIN .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-7970 : Add support for metastore event based automatic invalidate

2019-01-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12118 ) Change subject: IMPALA-7970 : Add support for metastore event based automatic invalidate .. Patch Set 27: Code-Review+2

[Impala-ASF-CR] IMPALA-7970 : Add support for metastore event based automatic invalidate

2019-01-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12118 ) Change subject: IMPALA-7970 : Add support for metastore event based automatic invalidate .. Patch Set 28: Code-Review+2 --

[Impala-ASF-CR] IMPALA-8135: Bump maven-surefire-plugin version to 2.20

2019-01-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12295 ) Change subject: IMPALA-8135: Bump maven-surefire-plugin version to 2.20 .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7540. Intern most repetitive strings and network addresses in catalog

2019-01-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11158 ) Change subject: IMPALA-7540. Intern most repetitive strings and network addresses in catalog .. Patch Set 4: Code-Review+2

[Impala-ASF-CR](2.x) IMPALA-6479: Update DESCRIBE to respect column privileges

2019-01-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12292 ) Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges .. Patch Set 1: Code-Review-1 This is a

[Impala-ASF-CR] IMPALA-8135: Bump maven-surefire-plugin version to 2.20

2019-01-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12295 ) Change subject: IMPALA-8135: Bump maven-surefire-plugin version to 2.20 .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Revert "IMPALA-7992: Revert "Symbolize stacktraces in debug builds.""

2019-01-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12300 ) Change subject: Revert "IMPALA-7992: Revert "Symbolize stacktraces in debug builds."" .. Patch Set 1: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-7970 : Add support for metastore event based automatic invalidate

2019-01-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12118 ) Change subject: IMPALA-7970 : Add support for metastore event based automatic invalidate .. Patch Set 25: (12 comments)

[Impala-ASF-CR] IMPALA-8093: Profiles prefix counters inconsistently

2019-01-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12287 ) Change subject: IMPALA-8093: Profiles prefix counters inconsistently .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-8058: Fallback for HBase key scan range estimation

2019-01-25 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12192 ) Change subject: IMPALA-8058: Fallback for HBase key scan range estimation .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

2019-01-25 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12248 ) Change subject: IMPALA-8095: Detailed expression cardinality tests .. Patch Set 5: (5 comments) Just some clarifying

[Impala-ASF-CR] IMPALA-8093: Prefix time series counters with a hyphen

2019-01-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12296 ) Change subject: IMPALA-8093: Prefix time series counters with a hyphen .. Patch Set 1: (1 comment) As discussed, we usually

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-01-31 Thread Bharath Vissapragada (Code Review)
Hello Greg Rahn, Paul Rogers, Fredy Wijaya, Balazs Jeszenszky, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12221 to look at the new patch set (#5). Change subject: IMPALA-5872: Testcase builder for query planner

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-01-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: IMPALA-5872: Testcase builder for query planner .. Patch Set 5: I did not rebase yet so that reviewers can

[Impala-ASF-CR] IMPALA-7934: Switch to java.util.Base64 implementation

2019-01-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12250 ) Change subject: IMPALA-7934: Switch to java.util.Base64 implementation .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-01-31 Thread Bharath Vissapragada (Code Review)
Hello Greg Rahn, Paul Rogers, Fredy Wijaya, Balazs Jeszenszky, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12221 to look at the new patch set (#4). Change subject: IMPALA-5872: Testcase builder for query planner

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-01-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: IMPALA-5872: Testcase builder for query planner .. Patch Set 3: (13 comments)

[Impala-ASF-CR] IMPALA-8093: Prefix time series counters with a hyphen

2019-01-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12296 ) Change subject: IMPALA-8093: Prefix time series counters with a hyphen .. Patch Set 4: Code-Review+1 (2 comments) Lars, can

[Impala-ASF-CR] IMPALA-7540. Intern most repetitive strings and network addresses in catalog

2019-02-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11158 ) Change subject: IMPALA-7540. Intern most repetitive strings and network addresses in catalog .. IMPALA-7540. Intern

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-02-04 Thread Bharath Vissapragada (Code Review)
Hello Greg Rahn, Paul Rogers, Fredy Wijaya, Balazs Jeszenszky, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12221 to look at the new patch set (#6). Change subject: IMPALA-5872: Testcase builder for query planner

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-02-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: IMPALA-5872: Testcase builder for query planner .. Patch Set 5: (8 comments)

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-02-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: IMPALA-5872: Testcase builder for query planner .. Patch Set 6: (2 comments) Rebased on the master. The

[Impala-ASF-CR] IMPALA-8150: Fix buggy AuditingTest::TestAccessEventsOnAuthFailure

2019-02-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12334 ) Change subject: IMPALA-8150: Fix buggy AuditingTest::TestAccessEventsOnAuthFailure .. Patch Set 5: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8034: Improve planner tests

2019-02-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12145 ) Change subject: IMPALA-8034: Improve planner tests .. Patch Set 3: (11 comments) Great coverage. Tried to double check as

[Impala-ASF-CR] IMPALA-8150: Fix buggy AuditingTest::TestAccessEventsOnAuthFailure

2019-02-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12334 ) Change subject: IMPALA-8150: Fix buggy AuditingTest::TestAccessEventsOnAuthFailure .. Patch Set 4: (3 comments)

[Impala-ASF-CR] WIP: Refactor file descriptor loading code

2019-04-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: WIP: Refactor file descriptor loading code .. Patch Set 2: is it still a WIP or is this ready for review? --

[Impala-ASF-CR] IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode

2019-04-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12989 ) Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode .. Patch Set 2:

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 6: (18 comments)

[Impala-ASF-CR] IMPALA-8395: Parse older formats of /proc/net/dev correctly

2019-04-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12954 ) Change subject: IMPALA-8395: Parse older formats of /proc/net/dev correctly .. Patch Set 1: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-8395: Parse older formats of /proc/net/dev correctly

2019-04-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12954 ) Change subject: IMPALA-8395: Parse older formats of /proc/net/dev correctly .. Patch Set 1: (1 comment)

[Impala-ASF-CR] WIP: Refactor file descriptor loading code

2019-04-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: WIP: Refactor file descriptor loading code .. Patch Set 2: (5 comments) refactor generally makes sense to me.

[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile

2019-04-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12940 ) Change subject: IMPALA-7322: Add storage wait time to profile .. Patch Set 3: (14 comments)

[Impala-ASF-CR] IMPALA-6718: Add support for column-level permissions on views

2019-04-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12959 ) Change subject: IMPALA-6718: Add support for column-level permissions on views .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8346: Specify hadoop user explicitly during data load

2019-04-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 ) Change subject: IMPALA-8346: Specify hadoop user explicitly during data load .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6718: Add support for column-level permissions on views

2019-04-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12959 ) Change subject: IMPALA-6718: Add support for column-level permissions on views .. Patch Set 3: (3 comments) sorry for the

[Impala-ASF-CR] IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger

2019-04-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12927 ) Change subject: IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger .. Patch Set 6: (4

[Impala-ASF-CR] Initial support for recursive file listing within a partition

2019-04-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12991 ) Change subject: Initial support for recursive file listing within a partition .. Patch Set 1: (7 comments) Generally looks

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 14: (4 comments)

[Impala-ASF-CR] IMPALA-8338 : Check CREATION TIME in event processor to avoid incorrect deletion of Database objects.

2019-04-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12938 ) Change subject: IMPALA-8338 : Check CREATION_TIME in event processor to avoid incorrect deletion of Database objects. .. Patch

[Impala-ASF-CR] IMPALA-6718: Add support for column-level permissions on views

2019-04-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12959 ) Change subject: IMPALA-6718: Add support for column-level permissions on views .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 16: (5 comments) lgtm, can +2

[Impala-ASF-CR] Log scanner Open() errors

2019-04-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13018 Change subject: Log scanner Open() errors .. Log scanner Open() errors While the status is propagated to the runtime profile,

[Impala-ASF-CR] IMPALA-6718: Add support for column-level permissions on views

2019-04-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12959 ) Change subject: IMPALA-6718: Add support for column-level permissions on views .. Patch Set 6: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8338 : Check CREATION TIME in event processor to avoid incorrect deletion of Database objects.

2019-04-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12938 ) Change subject: IMPALA-8338 : Check CREATION_TIME in event processor to avoid incorrect deletion of Database objects. .. Patch

[Impala-ASF-CR] IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger

2019-04-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12927 ) Change subject: IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger .. Patch Set 7:

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 16: (1 comment)

[Impala-ASF-CR] IMPALA-8338 : Check CREATION TIME while processing DROP DATABASE events.

2019-04-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12938 ) Change subject: IMPALA-8338 : Check CREATION_TIME while processing DROP_DATABASE events. .. Patch Set 14: Code-Review+2 --

[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing

2019-04-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13056 ) Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-8430: Fix flakiness in testCreateDropCreateDatabase

2019-04-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13058 ) Change subject: IMPALA-8430: Fix flakiness in testCreateDropCreateDatabase .. Patch Set 1: Code-Review+1 (2 comments) Vihang,

[Impala-ASF-CR] IMPALA-8430: Fix flakiness in testCreateDropCreateDatabase

2019-04-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13058 ) Change subject: IMPALA-8430: Fix flakiness in testCreateDropCreateDatabase .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 18: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-8426: Logging error in DROP TABLE event processing

2019-04-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13056 ) Change subject: IMPALA-8426: Logging error in DROP_TABLE event processing .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8430: Fix flakiness in testCreateDropCreateDatabase

2019-04-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13058 ) Change subject: IMPALA-8430: Fix flakiness in testCreateDropCreateDatabase .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 19: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 13: (1 comment)

[Impala-ASF-CR] Refactor file descriptor loading code

2019-04-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 ) Change subject: Refactor file descriptor loading code .. Patch Set 4: (6 comments) Looks pretty good to me, a bunch of nits

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 13: (12 comments) I think we

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 14: (9 comments) Some more

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally

2019-04-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 ) Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally .. Patch Set 5: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7972 Detect self-events to avoid unnecessary invalidates

2019-03-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12591 ) Change subject: IMPALA-7972 Detect self-events to avoid unnecessary invalidates .. Patch Set 17: Code-Review+2 -- To view,

[Impala-ASF-CR] Remove "Could not transfer" exclusion in mvn-quiet.sh

2019-06-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13647 ) Change subject: Remove "Could not transfer" exclusion in mvn-quiet.sh .. Patch Set 1: Code-Review+2 Seems reasonable to me,

[Impala-ASF-CR] IMPALA-8599: Create a Maven module for query event hook API

2019-06-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13653 ) Change subject: IMPALA-8599: Create a Maven module for query event hook API .. Patch Set 2: Code-Review+1 (1 comment) I'm not

[Impala-ASF-CR] WIP: IMPALA-7434. Handle invalidation races in CatalogdMetaProvider

2019-06-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13664 ) Change subject: WIP: IMPALA-7434. Handle invalidation races in CatalogdMetaProvider .. Patch Set 1: I'm trying to understand

[Impala-ASF-CR] IMPALA-8667. Remove --pull incremental stats flag

2019-06-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13671 ) Change subject: IMPALA-8667. Remove --pull_incremental_stats flag .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7534. Handle invalidation races in CatalogdMetaProvider

2019-06-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13664 ) Change subject: IMPALA-7534. Handle invalidation races in CatalogdMetaProvider .. Patch Set 2: (4 comments) Sorry, I got

[Impala-ASF-CR] IMPALA-7534. Handle invalidation races in CatalogdMetaProvider

2019-06-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13664 ) Change subject: IMPALA-7534. Handle invalidation races in CatalogdMetaProvider .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile

2019-06-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12940 ) Change subject: IMPALA-7322: Add storage wait time to profile .. Patch Set 10: Yongzhi, feel free to rebase when you get a

[Impala-ASF-CR] IMPALA-7534. Handle invalidation races in CatalogdMetaProvider

2019-06-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13664 ) Change subject: IMPALA-7534. Handle invalidation races in CatalogdMetaProvider .. Patch Set 4: Code-Review+1 (4 comments)

[Impala-ASF-CR] IMPALA-8663 : [WIP] FileMetadataLoader should skip listing files in hidden and tmp directories

2019-06-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13665 ) Change subject: IMPALA-8663 : [WIP] FileMetadataLoader should skip listing files in hidden and tmp directories .. Patch Set 2:

[Impala-ASF-CR] IMPALA-7322: Add storage wait time to profile

2019-06-24 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12940 ) Change subject: IMPALA-7322: Add storage wait time to profile .. Patch Set 12: Code-Review+2 (3 comments)

[native-toolchain-CR] SSL client support for THttpClient py implementation

2019-06-25 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13725 ) Change subject: SSL client support for THttpClient py implementation .. Patch Set 1: Oops, I think I added the wrong patch

[native-toolchain-CR] SSL client support for THttpClient py implementation

2019-06-25 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13725 Change subject: SSL client support for THttpClient py implementation .. SSL client support for THttpClient py implementation

[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py

2019-06-25 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13713 ) Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py .. Patch Set 7: Code-Review+2 (2 comments) Thanks for

[native-toolchain-CR] SSL client support for THttpClient py implementation

2019-06-25 Thread Bharath Vissapragada (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13725 to look at the new patch set (#2). Change subject: SSL client support for THttpClient py implementation .. SSL

<    2   3   4   5   6   7   8   9   10   >