[Impala-ASF-CR] IMPALA-5051: Add INT64 timestamp write support in Parquet

2019-02-13 Thread Csaba Ringhofer (Code Review)
Hello Zoltan Borok-Nagy, Zoltan Ivanfi, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12247 to look at the new patch set (#8). Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet

[Impala-ASF-CR] IMPALA-5051: Add INT64 timestamp write support in Parquet

2019-02-13 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12247 ) Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet .. Patch Set 8: (1 comment) About the last 3 patch sets:

[Impala-ASF-CR] IMPALA-5051: Add INT64 timestamp write support in Parquet

2019-02-13 Thread Csaba Ringhofer (Code Review)
Hello Zoltan Borok-Nagy, Zoltan Ivanfi, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12247 to look at the new patch set (#6). Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet

[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2019-02-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7368: Add initial support for DATE type

2019-02-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12481 ) Change subject: IMPALA-7368: Add initial support for DATE type .. Patch Set 3: (9 comments)

[Impala-ASF-CR] IMPALA-7368: Add initial support for DATE type

2019-02-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12481 ) Change subject: IMPALA-7368: Add initial support for DATE type .. Patch Set 3: (4 comments) I ran through the non-test cpp code.

[Impala-ASF-CR] IMPALA-8108: Impala query returns TIMESTAMP values in different types

2019-02-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12498 ) Change subject: IMPALA-8108: Impala query returns TIMESTAMP values in different types .. Patch Set 3: (3 comments) Some high

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-02-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12267 ) Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-7087: Read Parquet decimal columns with lower precision/scale than table metadata

2019-01-29 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12163 ) Change subject: IMPALA-7087: Read Parquet decimal columns with lower precision/scale than table metadata .. Patch Set 3: (2

[Impala-ASF-CR] IMPALA-5051: Add INT64 timestamp write support in Parquet

2019-01-30 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12247 ) Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet .. Patch Set 5: Some update: There are two design

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-01-31 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12267 ) Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-4356,IMPALA-7331: codegen all ScalarExprs

2019-04-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12797 ) Change subject: IMPALA-4356,IMPALA-7331: codegen all ScalarExprs .. Patch Set 8: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-5843: Use page index in Parquet files to skip pages

2019-04-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12065 ) Change subject: IMPALA-5843: Use page index in Parquet files to skip pages .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-5051: Add INT64 timestamp write support in Parquet

2019-04-08 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, Zoltan Ivanfi, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12247 to look at the new patch set (#17). Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet

[Impala-ASF-CR] IMPALA-5051: Add INT64 timestamp write support in Parquet

2019-04-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12247 ) Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet .. Patch Set 18: Code-Review+2 Carry +2 -- To view,

[Impala-ASF-CR] IMPALA-5051: Add INT64 timestamp write support in Parquet

2019-04-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12247 ) Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet .. IMPALA-5051: Add INT64 timestamp write support

[Impala-ASF-CR] IMPALA-8381: WIP - Optimize ParquetPlainEncoder::DecodeBatch() for simple types

2019-04-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12985 ) Change subject: IMPALA-8381: WIP - Optimize ParquetPlainEncoder::DecodeBatch() for simple types .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-5843: Use page index in Parquet files to skip pages

2019-04-12 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12065 ) Change subject: IMPALA-5843: Use page index in Parquet files to skip pages .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-5843: Use page index in Parquet files to skip pages

2019-04-12 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12065 ) Change subject: IMPALA-5843: Use page index in Parquet files to skip pages .. Patch Set 11: (5 comments)

[Impala-ASF-CR] IMPALA-7368: Add initial support for DATE type

2019-04-16 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12481 ) Change subject: IMPALA-7368: Add initial support for DATE type .. Patch Set 21: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-5843: Use page index in Parquet files to skip pages

2019-04-16 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12065 ) Change subject: IMPALA-5843: Use page index in Parquet files to skip pages .. Patch Set 12: Code-Review+1 (5 comments)

[Impala-ASF-CR] IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0

2019-04-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13005 ) Change subject: IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0 .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0

2019-04-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13005 ) Change subject: IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0 .. Patch Set 3: Sorry, I didn't refresh before

[Impala-ASF-CR] IMPALA-5843: Use page index in Parquet files to skip pages

2019-04-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12065 ) Change subject: IMPALA-5843: Use page index in Parquet files to skip pages .. Patch Set 14: (2 comments)

[Impala-ASF-CR] IMPALA-7368: Add initial support for DATE type

2019-04-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12481 ) Change subject: IMPALA-7368: Add initial support for DATE type .. Patch Set 22: Code-Review+1 -- To view, visit

[native-toolchain-CR] POC: IMPALA-7085: Extend CCTZ's interface with get offset()

2019-04-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12992 Change subject: POC: IMPALA-7085: Extend CCTZ's interface with get_offset() .. POC: IMPALA-7085: Extend CCTZ's interface with

[native-toolchain-CR] POC: IMPALA-7085: Extend CCTZ's interface with get offset()

2019-04-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12992 ) Change subject: POC: IMPALA-7085: Extend CCTZ's interface with get_offset() .. POC: IMPALA-7085: Extend CCTZ's interface with

[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2019-03-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. Patch Set 3: I like the current solution, but I think that it

[Impala-ASF-CR] IMPALA-7936: Enable better control over Parquet writing

2019-05-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13361 ) Change subject: IMPALA-7936: Enable better control over Parquet writing .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-8369: Add HIVE MAJOR VERSION section to planner tests + some fixes

2019-05-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13414 ) Change subject: IMPALA-8369: Add HIVE_MAJOR_VERSION section to planner tests + some fixes .. Patch Set 4: Code-Review+2 Carry +2

[Impala-ASF-CR] IMPALA-8369: Add HIVE MAJOR VERSION section to planner tests + some fixes

2019-05-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13414 ) Change subject: IMPALA-8369: Add HIVE_MAJOR_VERSION section to planner tests + some fixes .. IMPALA-8369: Add

[Impala-ASF-CR] IMPALA-8585: Fix for upgraded + compacted acid tables

2019-05-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13427 ) Change subject: IMPALA-8585: Fix for upgraded + compacted acid tables .. IMPALA-8585: Fix for upgraded + compacted acid

[Impala-ASF-CR] IMPALA-8585: Fix StmtMetadataLoaderTest when compiled against Hive 3

2019-05-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13444 ) Change subject: IMPALA-8585: Fix StmtMetadataLoaderTest when compiled against Hive 3 .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8578: part 1: reduce dependencies on *metrics.h

2019-06-04 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13491 ) Change subject: IMPALA-8578: part 1: reduce dependencies on *metrics.h .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8369: Add HIVE MAJOR VERSION section to EE tests + some fixes

2019-06-03 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13472 ) Change subject: IMPALA-8369: Add HIVE_MAJOR_VERSION section to EE tests + some fixes .. IMPALA-8369: Add HIVE_MAJOR_VERSION

[Impala-ASF-CR] IMPALA-8369: Add HIVE MAJOR VERSION section to EE tests + some fixes

2019-05-31 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13472 ) Change subject: IMPALA-8369: Add HIVE_MAJOR_VERSION section to EE tests + some fixes .. Patch Set 2: Restarting tests as the

[Impala-ASF-CR] IMPALA-7369: part 1: Implement TRUNC, DATE TRUNC, EXTRACT, DATE PART functions for DATE

2019-05-31 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13363 ) Change subject: IMPALA-7369: part 1: Implement TRUNC, DATE_TRUNC, EXTRACT, DATE_PART functions for DATE .. Patch Set 7:

[Impala-ASF-CR] IMPALA-8369: Fix HMS integration tests for Hive 3

2019-05-31 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13475 ) Change subject: IMPALA-8369: Fix HMS integration tests for Hive 3 .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8585: Add tests for partitioned ACID tables

2019-05-28 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13428 ) Change subject: IMPALA-8585: Add tests for partitioned ACID tables .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8369: Add HIVE MAJOR VERSION section to EE tests + some fixes

2019-05-30 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13472 Change subject: IMPALA-8369: Add HIVE_MAJOR_VERSION section to EE tests + some fixes .. IMPALA-8369: Add HIVE_MAJOR_VERSION section

[Impala-ASF-CR] IMPALA-7369: part 1: Implement TRUNC, DATE TRUNC, EXTRACT, DATE PART functions for DATE

2019-05-30 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13363 ) Change subject: IMPALA-7369: part 1: Implement TRUNC, DATE_TRUNC, EXTRACT, DATE_PART functions for DATE .. Patch Set 5:

[Impala-ASF-CR] IMPALA-8369: Add HIVE MAJOR VERSION section to EE tests + some fixes

2019-05-30 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13472 to look at the new patch set (#2). Change subject: IMPALA-8369: Add HIVE_MAJOR_VERSION section to EE tests + some fixes

[Impala-ASF-CR] IMPALA-8585: Add tests for partitioned ACID tables

2019-05-28 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13428 ) Change subject: IMPALA-8585: Add tests for partitioned ACID tables .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-7369: part 1: Implement TRUNC, DATE TRUNC, EXTRACT, DATE PART functions for DATE

2019-05-28 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13363 ) Change subject: IMPALA-7369: part 1: Implement TRUNC, DATE_TRUNC, EXTRACT, DATE_PART functions for DATE .. Patch Set 3: (3

[Impala-ASF-CR] IMPALA-8450: Add support for zstd and lz4 in parquet

2019-05-28 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13396 ) Change subject: IMPALA-8450: Add support for zstd and lz4 in parquet .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-8369: Fix HMS integration tests for Hive 3

2019-05-30 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13475 ) Change subject: IMPALA-8369: Fix HMS integration tests for Hive 3 .. Patch Set 2: Code-Review+2 (4 comments) Just a few nits.

[Impala-ASF-CR] IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE

2019-06-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13648 ) Change subject: IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE .. Patch Set 1: (7 comments) The

[Impala-ASF-CR] IMPALA-8369: Bump CDP BUILD NUMBER and re-enable test max nesting depth

2019-06-25 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13723 Change subject: IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth .. IMPALA-8369: Bump CDP_BUILD_NUMBER and

[Impala-ASF-CR] IMPALA-8585: Fix upgraded table related tests in AcidUtilsTest

2019-06-25 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13730 Change subject: IMPALA-8585: Fix upgraded table related tests in AcidUtilsTest .. IMPALA-8585: Fix upgraded table related tests in

[Impala-ASF-CR] IMPALA-8593: Prohibit write operations for bucketed tables

2019-06-12 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13558 ) Change subject: IMPALA-8593: Prohibit write operations for bucketed tables .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE

2019-06-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13648 ) Change subject: IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE .. Patch Set 2: Code-Review+1 (1

[Impala-ASF-CR] IMPALA-8636: Implement INSERT for insert-only ACID tables

2019-06-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13559 ) Change subject: IMPALA-8636: Implement INSERT for insert-only ACID tables .. Patch Set 5: (14 comments)

[Impala-ASF-CR] IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE

2019-06-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13648 ) Change subject: IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE .. Patch Set 3: (3 comments)

[Impala-ASF-CR] Backport KUDU-2871 (part 1): disable TLS 1.3.

2019-06-20 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13689 Change subject: Backport KUDU-2871 (part 1): disable TLS 1.3. .. Backport KUDU-2871 (part 1): disable TLS 1.3. Change-Id:

[Impala-ASF-CR] IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE

2019-06-24 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13648 ) Change subject: IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8636: Implement INSERT for insert-only ACID tables

2019-06-24 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13559 ) Change subject: IMPALA-8636: Implement INSERT for insert-only ACID tables .. Patch Set 7: (7 comments)

[Impala-ASF-CR] IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE

2019-06-24 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13648 ) Change subject: IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE .. Patch Set 5: Code-Review+2 (1

[Impala-ASF-CR] IMPALA-8524: Avoid calling "hive" via command line in EE tests

2019-05-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13282 ) Change subject: IMPALA-8524: Avoid calling "hive" via command line in EE tests .. IMPALA-8524: Avoid calling "hive" via

[Impala-ASF-CR] IMPALA-8369: Fixing some core tests in Hive environment

2019-05-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13283 ) Change subject: IMPALA-8369: Fixing some core tests in Hive environment .. Patch Set 4: (1 comment) It turned out the -1 file in

[Impala-ASF-CR] IMPALA-8369: Fixing some core tests in Hive environment

2019-05-10 Thread Csaba Ringhofer (Code Review)
Hello Vihang Karajgaonkar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13283 to look at the new patch set (#4). Change subject: IMPALA-8369: Fixing some core tests in Hive environment

[Impala-ASF-CR] [IMPALA-8435] Prohibit operations on full transactional table.

2019-05-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13253 ) Change subject: [IMPALA-8435] Prohibit operations on full transactional table. .. Patch Set 3: (3 comments)

[Impala-ASF-CR] WIP: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader

2019-05-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13328 Change subject: WIP: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader .. WIP: IMPALA-6433: Part 1: Extract

[Impala-ASF-CR] WIP: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader

2019-05-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has abandoned this change. ( http://gerrit.cloudera.org:8080/13328 ) Change subject: WIP: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader .. Abandoned This was pushed a bit to early

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

2019-05-22 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 ) Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests .. Patch Set 2: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-8450: Add support for zstd and lz4 in parquet

2019-05-22 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13396 ) Change subject: IMPALA-8450: Add support for zstd and lz4 in parquet .. Patch Set 6: (6 comments)

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

2019-05-22 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 ) Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests .. Patch Set 1: Code-Review+2 Ouch, I only

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-22 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. Patch Set 14: (6 comments)

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded a new patch set (#17) to the change originally created by Sudhanshu Arora. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. acid: Filter

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded a new patch set (#18) to the change originally created by Sudhanshu Arora. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. acid: Filter

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. Patch Set 18: Code-Review+1 Patch set 17 is only indentation

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

2019-05-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 ) Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests .. Patch Set 4: Code-Review+2 -- To view,

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. Patch Set 19: > Looks like some of the test failures from patch

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded a new patch set (#19) to the change originally created by Sudhanshu Arora. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. acid: Filter

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded a new patch set (#20) to the change originally created by Sudhanshu Arora. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. acid: Filter

[Impala-ASF-CR] acid: Filter unwanted files based on ACID state.

2019-05-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13334 ) Change subject: acid: Filter unwanted files based on ACID state. .. Patch Set 20: (1 comment) Patch set 20 fixes tests that use

[Impala-ASF-CR] IMPALA-8369: Add HIVE MAJOR VERSION section to planner tests + some fixes

2019-05-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13414 Change subject: IMPALA-8369: Add HIVE_MAJOR_VERSION section to planner tests + some fixes .. IMPALA-8369: Add HIVE_MAJOR_VERSION

[Impala-ASF-CR] IMPALA-8369: Add HIVE MAJOR VERSION section to planner tests + some fixes

2019-05-24 Thread Csaba Ringhofer (Code Review)
Hello Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13414 to look at the new patch set (#3). Change subject: IMPALA-8369: Add HIVE_MAJOR_VERSION section to planner tests + some fixes

[Impala-ASF-CR] IMPALA-8585: Fix for upgraded + compacted acid tables

2019-05-24 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13427 to look at the new patch set (#2). Change subject: IMPALA-8585: Fix for upgraded + compacted acid tables

[Impala-ASF-CR] IMPALA-8585: Fix for upgraded + compacted acid tables

2019-05-24 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13427 ) Change subject: IMPALA-8585: Fix for upgraded + compacted acid tables .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8585: Fix for upgraded + compacted acid tables

2019-05-24 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13427 Change subject: IMPALA-8585: Fix for upgraded + compacted acid tables .. IMPALA-8585: Fix for upgraded + compacted acid tables

[Impala-ASF-CR] IMPALA-7369: part 1: Implement TRUNC, DATE TRUNC, EXTRACT, DATE PART functions for DATE

2019-05-20 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13363 ) Change subject: IMPALA-7369: part 1: Implement TRUNC, DATE_TRUNC, EXTRACT, DATE_PART functions for DATE .. Patch Set 2: (4

[Impala-ASF-CR] IMPALA-7369: part 1: Implement TRUNC, DATE TRUNC, EXTRACT, DATE PART functions for DATE

2019-05-20 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13363 ) Change subject: IMPALA-7369: part 1: Implement TRUNC, DATE_TRUNC, EXTRACT, DATE_PART functions for DATE .. Patch Set 2: (2

[Impala-ASF-CR] IMPALA-8524: Avoid calling "hive" via command line in EE tests

2019-05-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13282 Change subject: IMPALA-8524: Avoid calling "hive" via command line in EE tests .. IMPALA-8524: Avoid calling "hive" via command line

[Impala-ASF-CR] IMPALA-8369: Fixing some core tests in Hive environment

2019-05-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13283 ) Change subject: IMPALA-8369: Fixing some core tests in Hive environment .. Patch Set 3: (2 comments) It turned out that the

[Impala-ASF-CR] IMPALA-4658: Potential race if compiler reorders ReachedLimit() usage.

2019-05-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13178 ) Change subject: IMPALA-4658: Potential race if compiler reorders ReachedLimit() usage. .. Patch Set 7: Code-Review+1 The change

[Impala-ASF-CR] IMPALA-7936: Enable better control over Parquet writing

2019-05-21 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13361 ) Change subject: IMPALA-7936: Enable better control over Parquet writing .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7936: Enable better control over Parquet writing

2019-05-21 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13361 ) Change subject: IMPALA-7936: Enable better control over Parquet writing .. Patch Set 1: (1 comment)

[Impala-ASF-CR] WIP: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader

2019-05-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13329 ) Change subject: WIP: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader .. Patch Set 3: I do not understand

[Impala-ASF-CR] WIP: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader

2019-05-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13329 Change subject: WIP: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader .. WIP: IMPALA-6433: Part 1: Extract

[Impala-ASF-CR] WIP: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader

2019-05-14 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13329 to look at the new patch set (#2). Change subject: WIP: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader

[Impala-ASF-CR] IMPALA-7370: DATE: Read/Write to parquet.

2019-04-30 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13189 ) Change subject: IMPALA-7370: DATE: Read/Write to parquet. .. Patch Set 2: (8 comments)

[Impala-ASF-CR] IMPALA-8467: ParquetPlainEncoder::Decode leads to multiple test failures in ASAN builds

2019-04-29 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13176 ) Change subject: IMPALA-8467: ParquetPlainEncoder::Decode leads to multiple test failures in ASAN builds .. Patch Set 2:

[Impala-ASF-CR] IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive

2019-04-29 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13177 to look at the new patch set (#2). Change subject: IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive

[Impala-ASF-CR] IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive

2019-04-29 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13177 Change subject: IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive .. IMPALA-8468: buildall.sh should warn that

[Impala-ASF-CR] IMPALA-8467: ParquetPlainEncoder::Decode leads to multiple test failures in ASAN builds

2019-04-29 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13176 ) Change subject: IMPALA-8467: ParquetPlainEncoder::Decode leads to multiple test failures in ASAN builds .. Patch Set 3:

[Impala-ASF-CR] IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive

2019-04-29 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13177 to look at the new patch set (#3). Change subject: IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive

[Impala-ASF-CR] IMPALA-8409: Fix row-size for STRING columns with unknown stats

2019-04-30 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13190 Change subject: IMPALA-8409: Fix row-size for STRING columns with unknown stats .. IMPALA-8409: Fix row-size for STRING columns with

[Impala-ASF-CR] IMPALA-8409: Fix row-size for STRING columns with unknown stats

2019-04-30 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13190 to look at the new patch set (#2). Change subject: IMPALA-8409: Fix row-size for STRING columns with unknown stats

[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13236 ) Change subject: IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for Hive 3 support .. Patch Set 3: Code-Review+2 (1

[Impala-ASF-CR] IMPALA-8369 (part 3): Hive 3: fix test permanent udfs.py for Hive 3 support

2019-05-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13236 ) Change subject: IMPALA-8369 (part 3): Hive 3: fix test_permanent_udfs.py for Hive 3 support .. Patch Set 4: Code-Review+2 -- To

<    1   2   3   4   5   6   7   8   9   10   >