[Impala-ASF-CR] IMPALA-8741: Speed up bit unpacking by vectorisation

2019-07-24 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13807 ) Change subject: IMPALA-8741: Speed up bit unpacking by vectorisation .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-8741: Speed up bit unpacking by vectorisation

2019-07-24 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13807 ) Change subject: IMPALA-8741: Speed up bit unpacking by vectorisation .. Patch Set 4: > (2 comments) > > Thanks for the fixes. I th

[Impala-ASF-CR] IMPALA-8741: Speed up bit unpacking by vectorisation

2019-07-24 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13807 ) Change subject: IMPALA-8741: Speed up bit unpacking by vectorisation .. Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-8794: Skipping testPiggyback* in Hive 3 builds

2019-07-25 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13920 Change subject: IMPALA-8794: Skipping testPiggyback* in Hive 3 builds .. IMPALA-8794: Skipping testPiggyback* in Hive 3 builds The te

[Impala-ASF-CR] IMPALA-8585: Skip most ACID EE tests in non-HDFS builds

2019-07-25 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13921 Change subject: IMPALA-8585: Skip most ACID EE tests in non-HDFS builds .. IMPALA-8585: Skip most ACID EE tests in non-HDFS builds Cu

[Impala-ASF-CR] IMPALA-8585: Skip most ACID EE tests in non-HDFS builds

2019-07-25 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13921 to look at the new patch set (#2). Change subject: IMPALA-8585: Skip most ACID EE tests in non-HDFS builds

[Impala-ASF-CR] IMPALA-8636: Implement INSERT for insert-only ACID tables

2019-07-25 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13559 ) Change subject: IMPALA-8636: Implement INSERT for insert-only ACID tables .. Patch Set 15: Code-Review+2 (3 comments) Only minor co

[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables

2019-07-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 ) Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables .. Patch Set 3: -Code-Review -- To view, visit http:/

[Impala-ASF-CR] IMPALA-8636: Implement INSERT for insert-only ACID tables

2019-07-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13559 ) Change subject: IMPALA-8636: Implement INSERT for insert-only ACID tables .. Patch Set 17: Code-Review+2 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-8636: Implement INSERT for insert-only ACID tables

2019-07-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13559 ) Change subject: IMPALA-8636: Implement INSERT for insert-only ACID tables .. Patch Set 19: Code-Review+2 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-8808: Add query option default transactional type

2019-07-30 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13954 Change subject: IMPALA-8808: Add query option default_transactional_type .. IMPALA-8808: Add query option default_transactional_type

[Impala-ASF-CR] IMPALA-8808: Add query option default transactional type

2019-07-30 Thread Csaba Ringhofer (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13954 to look at the new patch set (#2). Change subject: IMPALA-8808: Add query option default_transactional_type

[Impala-ASF-CR] IMPALA-8808: Add query option default transactional type

2019-07-30 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13954 ) Change subject: IMPALA-8808: Add query option default_transactional_type .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-8810: Fix ExplainTest when Orc support is disabled

2019-07-30 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13956 Change subject: IMPALA-8810: Fix ExplainTest when Orc support is disabled .. IMPALA-8810: Fix ExplainTest when Orc support is disabled

[Impala-ASF-CR] IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment

2019-07-31 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13963 Change subject: IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment .. IMPALA-8817: Fix TestTestcaseBuilder tests on n

[Impala-ASF-CR] IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment

2019-07-31 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13963 to look at the new patch set (#2). Change subject: IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment

[Impala-ASF-CR] IMPALA-8808: Add query option default transactional type

2019-07-31 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13954 ) Change subject: IMPALA-8808: Add query option default_transactional_type .. IMPALA-8808: Add query option default_transaction

[Impala-ASF-CR] IMPALA-8600 Refresh transactional tables

2019-07-31 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13938 ) Change subject: IMPALA-8600 Refresh transactional tables .. Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/13938/6//

[Impala-ASF-CR] IMPALA-8600 Refresh transactional tables

2019-07-31 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13938 ) Change subject: IMPALA-8600 Refresh transactional tables .. Patch Set 6: > (7 comments) I am 100% sure -> I am NOT 100% sure :D -

[Impala-ASF-CR] IMPALA-8636: fix flakiness of ACID INSERT tests

2019-08-01 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13966 ) Change subject: IMPALA-8636: fix flakiness of ACID INSERT tests .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8600: Refresh transactional tables

2019-08-01 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13938 ) Change subject: IMPALA-8600: Refresh transactional tables .. Patch Set 8: Code-Review+2 Thanks for the changes! -- To view, visit

[Impala-ASF-CR] IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment

2019-08-01 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13963 to look at the new patch set (#3). Change subject: IMPALA-8817: Fix TestTestcaseBuilder tests on non-HDFS environment

[Impala-ASF-CR] WIP IMPALA-8637: Implement transaction handling and locking for ACID queries

2019-08-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13968 ) Change subject: WIP IMPALA-8637: Implement transaction handling and locking for ACID queries .. Patch Set 2: (3 comments) http://g

[Impala-ASF-CR] WIP IMPALA-8637: Implement transaction handling and locking for ACID queries

2019-08-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13968 ) Change subject: WIP IMPALA-8637: Implement transaction handling and locking for ACID queries .. Patch Set 2: (1 comment) http://ge

[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1318335

2019-08-05 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14005 Change subject: Bump CDP_BUILD_NUMBER to 1318335 .. Bump CDP_BUILD_NUMBER to 1318335 The main reason for bumping is to include HIVE-2

[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1318335

2019-08-05 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14005 to look at the new patch set (#2). Change subject: Bump CDP_BUILD_NUMBER to 1318335 .. Bump CDP_BUILD_NUMB

[Impala-ASF-CR] IMPALA-8637: Implement transaction handling and locking for ACID queries

2019-08-05 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13968 ) Change subject: IMPALA-8637: Implement transaction handling and locking for ACID queries .. Patch Set 3: (3 comments) http://gerri

[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1318335

2019-08-06 Thread Csaba Ringhofer (Code Review)
Hello Vihang Karajgaonkar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14005 to look at the new patch set (#3). Change subject: Bump CDP_BUILD_NUMBER to 1318335 ..

[Impala-ASF-CR] IMPALA-8600 AnalyzerTest.TestAnalyzeTransactional() test fix

2019-08-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14017 ) Change subject: IMPALA-8600 AnalyzerTest.TestAnalyzeTransactional() test fix .. Patch Set 2: Code-Review+2 (1 comment) http://gerri

[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1318335

2019-08-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14005 ) Change subject: Bump CDP_BUILD_NUMBER to 1318335 .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/14005/2/tests/cus

[Impala-ASF-CR] IMPALA-8833 - Check failed in BatchedBitReader::UnpackBatch()

2019-08-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14019 ) Change subject: IMPALA-8833 - Check failed in BatchedBitReader::UnpackBatch() .. Patch Set 2: Code-Review+1 (1 comment) http://gerr

[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1318335

2019-08-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14005 ) Change subject: Bump CDP_BUILD_NUMBER to 1318335 .. Patch Set 3: I would prefer to keep this as a minimal change (version bump + qui

[Impala-ASF-CR] IMPALA-8600: Fix test acid compaction

2019-08-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14027 ) Change subject: IMPALA-8600: Fix test_acid_compaction .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-8840: Check failed: num bytes <= sizeof(T) (5 vs. 4)

2019-08-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14029 ) Change subject: IMPALA-8840: Check failed: num_bytes <= sizeof(T) (5 vs. 4) .. Patch Set 2: Code-Review+2 -- To view, visit http://

[Impala-ASF-CR] IMPALA-8637: Implement transaction handling and locking for ACID queries

2019-08-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13968 ) Change subject: IMPALA-8637: Implement transaction handling and locking for ACID queries .. Patch Set 7: (1 comment) http://gerrit

[Impala-ASF-CR] IMPALA-8637: Implement transaction handling and locking for ACID queries

2019-08-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13968 ) Change subject: IMPALA-8637: Implement transaction handling and locking for ACID queries .. Patch Set 10: Code-Review+2 (4 comments

[Impala-ASF-CR] WIP: IMPALA-8842: Change column stat HMS calls to accommodate HIVE-22046.

2019-08-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14032 ) Change subject: WIP: IMPALA-8842: Change column stat HMS calls to accommodate HIVE-22046. .. Patch Set 1: (3 comments) http://gerr

[Impala-ASF-CR] IMPALA-8840: Check failed: num bytes <= sizeof(T) (5 vs. 4)

2019-08-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14029 ) Change subject: IMPALA-8840: Check failed: num_bytes <= sizeof(T) (5 vs. 4) .. IMPALA-8840: Check failed: num_bytes <= sizeof

[Impala-ASF-CR] IMPALA-8637: Implement transaction handling and locking for ACID queries

2019-08-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13968 ) Change subject: IMPALA-8637: Implement transaction handling and locking for ACID queries .. Patch Set 11: Code-Review+2 -- To view

[Impala-ASF-CR] WIP: IMPALA-8842: Change column stat HMS calls to accommodate HIVE-22046.

2019-08-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14032 ) Change subject: WIP: IMPALA-8842: Change column stat HMS calls to accommodate HIVE-22046. .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues

2019-08-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14004 ) Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-8796: Restrict bit unpacking to unsigned integer types

2019-08-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14031 ) Change subject: IMPALA-8796: Restrict bit unpacking to unsigned integer types .. Patch Set 1: Code-Review+2 -- To view, visit http:

[Impala-ASF-CR] IMPALA-8846: Undefined behaviour in RleEncoder::Put

2019-08-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14042 ) Change subject: IMPALA-8846: Undefined behaviour in RleEncoder::Put .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-8839: Remove COLUMN STATS ACCURATE from properties

2019-08-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14037 ) Change subject: IMPALA-8839: Remove COLUMN_STATS_ACCURATE from properties .. Patch Set 3: (15 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala

2019-08-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14021 ) Change subject: IMPALA-8811 IMPALA-8813: [DOCS] Document the ACID support in Impala .. Patch Set 6: (2 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-8839: Remove COLUMN STATS ACCURATE from properties

2019-08-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14037 ) Change subject: IMPALA-8839: Remove COLUMN_STATS_ACCURATE from properties .. Patch Set 4: Code-Review+1 (2 comments) Besides the bu

[Impala-ASF-CR] IMPALA-8823: DROP TABLE support for insert-only ACID tables

2019-08-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14038 ) Change subject: IMPALA-8823: DROP TABLE support for insert-only ACID tables .. Patch Set 7: Code-Review+1 (5 comments) I am ok with

[Impala-ASF-CR] IMPALA-8839: Remove COLUMN STATS ACCURATE from properties

2019-08-12 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14037 ) Change subject: IMPALA-8839: Remove COLUMN_STATS_ACCURATE from properties .. Patch Set 5: Code-Review+1 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-8823: DROP TABLE support for insert-only ACID tables

2019-08-13 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14038 ) Change subject: IMPALA-8823: DROP TABLE support for insert-only ACID tables .. Patch Set 5: (6 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-8823: DROP TABLE support for insert-only ACID tables

2019-08-13 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14038 ) Change subject: IMPALA-8823: DROP TABLE support for insert-only ACID tables .. Patch Set 10: Code-Review+2 (1 comment) http://gerri

[Impala-ASF-CR] DRAFT: IMPALA-8836: Support COMPUTE STATS on insert only ACID tables

2019-08-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14066 Change subject: DRAFT: IMPALA-8836: Support COMPUTE STATS on insert only ACID tables .. DRAFT: IMPALA-8836: Support COMPUTE STATS on

[Impala-ASF-CR] IMPALA-8842 part 1: Accommodate HIVE-22046 - Step 2.

2019-08-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14043 ) Change subject: IMPALA-8842 part 1: Accommodate HIVE-22046 - Step 2. .. Patch Set 4: Code-Review+1 (3 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8849: fix IllegalStateException with VARCHAR

2019-08-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14062 ) Change subject: IMPALA-8849: fix IllegalStateException with VARCHAR .. Patch Set 3: Code-Review+2 (1 comment) Thanks for fixing my

[Impala-ASF-CR] IMPALA-8842 part 1: (Hive3) Use 'engine' field in HMS stat API

2019-08-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14043 ) Change subject: IMPALA-8842 part 1: (Hive3) Use 'engine' field in HMS stat API .. Patch Set 6: Code-Review+2 (1 comment) http://ger

[Impala-ASF-CR] DRAFT: IMPALA-8836: Support COMPUTE STATS on insert only ACID tables

2019-08-15 Thread Csaba Ringhofer (Code Review)
Hello Yongzhi Chen, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14066 to look at the new patch set (#3). Change subject: DRAFT: IMPALA-8836: Support COMPUTE STATS on insert only ACID tables

[Impala-ASF-CR] DRAFT: IMPALA-8836: Support COMPUTE STATS on insert only ACID tables

2019-08-15 Thread Csaba Ringhofer (Code Review)
Hello Yongzhi Chen, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14066 to look at the new patch set (#4). Change subject: DRAFT: IMPALA-8836: Support COMPUTE STATS on insert only ACID tables

[Impala-ASF-CR] DRAFT: IMPALA-8836: Support COMPUTE STATS on insert only ACID tables

2019-08-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14066 ) Change subject: DRAFT: IMPALA-8836: Support COMPUTE STATS on insert only ACID tables .. Patch Set 4: (2 comments) Fixed Hive 2 bui

[Impala-ASF-CR] DRAFT: IMPALA-8836: Support COMPUTE STATS on insert only ACID tables

2019-08-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14066 ) Change subject: DRAFT: IMPALA-8836: Support COMPUTE STATS on insert only ACID tables .. Patch Set 2: (1 comment) http://gerrit.clo

[Impala-ASF-CR] DRAFT: IMPALA-8836: Support COMPUTE STATS on insert only ACID tables

2019-08-15 Thread Csaba Ringhofer (Code Review)
Hello Yongzhi Chen, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14066 to look at the new patch set (#5). Change subject: DRAFT: IMPALA-8836: Support COMPUTE STATS on insert only ACID tables

[Impala-ASF-CR] DRAFT: IMPALA-8836: Support COMPUTE STATS on insert only ACID tables

2019-08-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14066 ) Change subject: DRAFT: IMPALA-8836: Support COMPUTE STATS on insert only ACID tables .. Patch Set 5: Patch set 5 is a fix for the b

[Impala-ASF-CR] DRAFT: IMPALA-8836: Support COMPUTE STATS on insert only ACID tables

2019-08-16 Thread Csaba Ringhofer (Code Review)
Hello Yongzhi Chen, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14066 to look at the new patch set (#6). Change subject: DRAFT: IMPALA-8836: Support COMPUTE STATS on insert only ACID tables

[Impala-ASF-CR] DRAFT: IMPALA-8836: Support COMPUTE STATS on insert only ACID tables

2019-08-16 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14066 ) Change subject: DRAFT: IMPALA-8836: Support COMPUTE STATS on insert only ACID tables .. Patch Set 6: PS6 is rebase + conflict resol

[Impala-ASF-CR] IMPALA-8836: Support COMPUTE STATS on insert only ACID tables

2019-08-16 Thread Csaba Ringhofer (Code Review)
Hello Yongzhi Chen, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14066 to look at the new patch set (#7). Change subject: IMPALA-8836: Support COMPUTE STATS on insert only ACID tables

[Impala-ASF-CR] IMPALA-8836: Support COMPUTE STATS on insert only ACID tables

2019-08-16 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14066 ) Change subject: IMPALA-8836: Support COMPUTE STATS on insert only ACID tables .. Patch Set 7: PS7 changed the updating of the partit

[Impala-ASF-CR] IMPALA-8841: Try to fix Tez related dataload flakiness

2019-08-16 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14081 Change subject: IMPALA-8841: Try to fix Tez related dataload flakiness .. IMPALA-8841: Try to fix Tez related dataload flakiness The

[Impala-ASF-CR] IMPALA-8796: Restrict bit unpacking to unsigned integer types

2019-08-16 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14031 ) Change subject: IMPALA-8796: Restrict bit unpacking to unsigned integer types .. IMPALA-8796: Restrict bit unpacking to unsig

[Impala-ASF-CR] IMPALA-8841: Try to fix Tez related dataload flakiness

2019-08-16 Thread Csaba Ringhofer (Code Review)
Hello Anonymous Coward (521), Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14081 to look at the new patch set (#2). Change subject: IMPALA-8841: Try to fix Tez related dataload flakiness .

[Impala-ASF-CR] IMPALA-8836: Support COMPUTE STATS on insert only ACID tables

2019-08-16 Thread Csaba Ringhofer (Code Review)
Hello Yongzhi Chen, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14066 to look at the new patch set (#8). Change subject: IMPALA-8836: Support COMPUTE STATS on insert only ACID tables .

[Impala-ASF-CR] IMPALA-8836: Support COMPUTE STATS on insert only ACID tables

2019-08-16 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14066 ) Change subject: IMPALA-8836: Support COMPUTE STATS on insert only ACID tables .. Patch Set 8: Code-Review+2 Carry +2 -- To view, v

[Impala-ASF-CR] IMPALA-8836: Support COMPUTE STATS on insert only ACID tables

2019-08-16 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14066 ) Change subject: IMPALA-8836: Support COMPUTE STATS on insert only ACID tables .. Patch Set 7: (9 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] Fix test event processing.py on Hive-3

2019-08-16 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14082 ) Change subject: Fix test_event_processing.py on Hive-3 .. Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-8841: Try to fix Tez related dataload flakiness

2019-08-16 Thread Csaba Ringhofer (Code Review)
Hello Vihang Karajgaonkar, Anonymous Coward (521), Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14081 to look at the new patch set (#3). Change subject: IMPALA-8841: Try to fix Tez related dataload flakiness

[Impala-ASF-CR] IMPALA-8841: Try to fix Tez related dataload flakiness

2019-08-16 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14081 ) Change subject: IMPALA-8841: Try to fix Tez related dataload flakiness .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-8793: Implement TRUNCATE for insert-only ACID tables

2019-08-16 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14071 ) Change subject: IMPALA-8793: Implement TRUNCATE for insert-only ACID tables .. Patch Set 2: (5 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-8875: fix test drop column maintains stats with Hive 3

2019-08-22 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14123 Change subject: IMPALA-8875: fix test_drop_column_maintains_stats with Hive 3 .. IMPALA-8875: fix test_drop_column_maintains_stats wit

[Impala-ASF-CR] WIP IMPALA-8851 : Do not throw authorization exception in drop if exists queries

2019-08-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14121 ) Change subject: WIP IMPALA-8851 : Do not throw authorization exception in drop if exists queries .. WIP IMPALA-8851 : Do not throw aut

[Impala-ASF-CR] WIP IMPALA-8851 : Do not throw authorization exception in drop if exists queries

2019-08-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded a new patch set (#1). ( http://gerrit.cloudera.org:8080/14121 ) Change subject: WIP IMPALA-8851 : Do not throw authorization exception in drop if exists queries .. WIP IMPALA-8851 : Do not throw aut

[Impala-ASF-CR] IMPALA-8793: Implement TRUNCATE for insert-only ACID tables

2019-08-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14071 ) Change subject: IMPALA-8793: Implement TRUNCATE for insert-only ACID tables .. Patch Set 4: Code-Review+2 (2 comments) http://gerri

[Impala-ASF-CR] IMPALA-8842 part 2: (Hive3) Use 'engine' field in HMS stat API

2019-08-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14108 ) Change subject: IMPALA-8842 part 2: (Hive3) Use 'engine' field in HMS stat API .. Patch Set 1: (2 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-8889: Fix error messages for unsupported operations on acid tables

2019-08-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14133 ) Change subject: IMPALA-8889: Fix error messages for unsupported operations on acid tables .. Patch Set 1: Code-Review+2 (2 comments

[Impala-ASF-CR] IMPALA-8793: Implement TRUNCATE for insert-only ACID tables

2019-08-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14071 ) Change subject: IMPALA-8793: Implement TRUNCATE for insert-only ACID tables .. Patch Set 5: Code-Review+2 (2 comments) http://gerri

[Impala-ASF-CR] WIP IMPALA-8851 : Do not throw authorization exception in drop if exists queries

2019-08-26 Thread Csaba Ringhofer (Code Review)
Hello Vihang Karajgaonkar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14121 to look at the new patch set (#3). Change subject: WIP IMPALA-8851 : Do not throw authorization exception in drop if exists queries .

[Impala-ASF-CR] IMPALA-8896: fix alterPartitionsWithTransaction() that emitted too many alter tables.

2019-08-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14148 ) Change subject: IMPALA-8896: fix alterPartitionsWithTransaction() that emitted too many alter tables. .. Patch Set 1: Code-Review+2

[Impala-ASF-CR] IMPALA-8889: Fix error messages for unsupported operations on acid tables

2019-08-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14133 ) Change subject: IMPALA-8889: Fix error messages for unsupported operations on acid tables .. IMPALA-8889: Fix error messages

[Impala-ASF-CR] IMPALA-8851 : Do not throw authorization exception in drop if exists queries

2019-08-27 Thread Csaba Ringhofer (Code Review)
Hello Vihang Karajgaonkar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14121 to look at the new patch set (#4). Change subject: IMPALA-8851 : Do not throw authorization exception in drop if exists queries ..

[Impala-ASF-CR] IMPALA-8793: Implement TRUNCATE for insert-only ACID tables

2019-08-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14071 ) Change subject: IMPALA-8793: Implement TRUNCATE for insert-only ACID tables .. Patch Set 10: Code-Review+2 (1 comment) http://gerri

[Impala-ASF-CR] IMPALA-8851: Do not throw authorization exception in drop if exists queries

2019-08-27 Thread Csaba Ringhofer (Code Review)
Hello Vihang Karajgaonkar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14121 to look at the new patch set (#5). Change subject: IMPALA-8851: Do not throw authorization exception in drop if exists queries ...

[Impala-ASF-CR] IMPALA-8851: Do not throw authorization exception in drop if exists queries

2019-08-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14121 ) Change subject: IMPALA-8851: Do not throw authorization exception in drop if exists queries .. Patch Set 5: (9 comments) http://ge

[Impala-ASF-CR] IMPALA-8851: Do not throw authorization exception in drop if exists queries

2019-08-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14121 ) Change subject: IMPALA-8851: Do not throw authorization exception in drop if exists queries .. Patch Set 5: (1 comment) http://ger

[Impala-ASF-CR] IMPALA-8851: Do not throw authorization exception in drop if exists queries

2019-08-27 Thread Csaba Ringhofer (Code Review)
Hello Vihang Karajgaonkar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14121 to look at the new patch set (#6). Change subject: IMPALA-8851: Do not throw authorization exception in drop if exists queries ...

[Impala-ASF-CR] IMPALA-8851: Do not throw authorization exception in drop if exists queries

2019-08-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14121 ) Change subject: IMPALA-8851: Do not throw authorization exception in drop if exists queries .. Patch Set 6: (1 comment) http://ger

[Impala-ASF-CR] IMPALA-8851: Do not throw authorization exception in drop if exists queries

2019-08-27 Thread Csaba Ringhofer (Code Review)
Hello Vihang Karajgaonkar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14121 to look at the new patch set (#7). Change subject: IMPALA-8851: Do not throw authorization exception in drop if exists queries ...

[Impala-ASF-CR] IMPALA-8851: Do not throw authorization exception in drop if exists queries

2019-08-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14121 ) Change subject: IMPALA-8851: Do not throw authorization exception in drop if exists queries .. Patch Set 6: (3 comments) http://ge

[Impala-ASF-CR] IMPALA-8851: Do not throw authorization exception in drop if exists queries

2019-08-27 Thread Csaba Ringhofer (Code Review)
Hello Vihang Karajgaonkar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14121 to look at the new patch set (#8). Change subject: IMPALA-8851: Do not throw authorization exception in drop if exists queries ...

[Impala-ASF-CR] IMPALA-8851: Do not throw authorization exception in drop if exists queries

2019-08-28 Thread Csaba Ringhofer (Code Review)
Hello Vihang Karajgaonkar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14121 to look at the new patch set (#9). Change subject: IMPALA-8851: Do not throw authorization exception in drop if exists queries ...

[Impala-ASF-CR] IMPALA-8851: Do not throw authorization exception in drop if exists queries

2019-08-28 Thread Csaba Ringhofer (Code Review)
Hello Vihang Karajgaonkar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14121 to look at the new patch set (#10). Change subject: IMPALA-8851: Do not throw authorization exception in drop if exists queries ..

[Impala-ASF-CR] IMPALA-8851: Do not throw authorization exception in drop if exists queries

2019-08-28 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14121 ) Change subject: IMPALA-8851: Do not throw authorization exception in drop if exists queries .. Patch Set 10: (2 comments) PS 9 add

[Impala-ASF-CR] WIP: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader

2019-08-29 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/13329 ) Change subject: WIP: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader .. WIP: IMPALA-6433: Part 1: Extract pag

[Impala-ASF-CR] IMPALA-9228: ORC scanner reads rows into scratch batch

2020-03-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15104 ) Change subject: IMPALA-9228: ORC scanner reads rows into scratch batch .. Patch Set 8: Code-Review+2 (4 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-4080 [part 5]: Invoke close on Exprs from plan nodes and sink configs where they were created

2020-03-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15318 ) Change subject: IMPALA-4080 [part 5]: Invoke close on Exprs from plan nodes and sink configs where they were created .. Patch Set 2:

<    1   2   3   4   5   6   7   8   9   10   >