[Impala-ASF-CR] IMPALA-9714: Fix edge cases in SimpleLogger and add test

2020-05-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15861 Change subject: IMPALA-9714: Fix edge cases in SimpleLogger and add test .. IMPALA-9714: Fix edge cases in SimpleLogger and add test Si

[Impala-ASF-CR] Filter out "Checksum validation failed" messages during the maven build

2020-05-05 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15775 to look at the new patch set (#3). Change subject: Filter out "Checksum validation failed" messages during the maven build ...

[Impala-ASF-CR] IMPALA-9199: Add support for single query retries on cluster membership changes

2020-05-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14824 ) Change subject: IMPALA-9199: Add support for single query retries on cluster membership changes .. Patch Set 16: (4 comments) Took a

[Impala-ASF-CR] IMPALA-3926: part 2: avoid setting LD LIBRARY PATH

2020-05-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14494 ) Change subject: IMPALA-3926: part 2: avoid setting LD_LIBRARY_PATH .. Patch Set 20: Code-Review+2 This all looks good to me. Good to s

[Impala-ASF-CR] IMPALA-9199: Add support for single query retries on cluster membership changes

2020-05-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14824 ) Change subject: IMPALA-9199: Add support for single query retries on cluster membership changes .. Patch Set 21: Code-Review+1 (2 com

[Impala-ASF-CR] IMPALA-9731: Remove USE CDP HIVE�lse and Hive 2 support

2020-05-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15869 ) Change subject: IMPALA-9731: Remove USE_CDP_HIVE=false and Hive 2 support .. Patch Set 3: GVO failure is IMPALA-9729, not related to t

[Impala-ASF-CR] IMPALA-9731: Remove USE CDP HIVE�lse and Hive 2 support

2020-05-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15869 Change subject: IMPALA-9731: Remove USE_CDP_HIVE=false and Hive 2 support .. IMPALA-9731: Remove USE_CDP_HIVE=false and Hive 2 support

[Impala-ASF-CR] Revert "IMPALA-9718: Delete pkg resources from IMPALA HOME/shell/"

2020-05-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15881 Change subject: Revert "IMPALA-9718: Delete pkg_resources from IMPALA_HOME/shell/" .. Revert "IMPALA-9718: Delete pkg_resources from IM

[Impala-ASF-CR] Revert "IMPALA-9718: Delete pkg resources from IMPALA HOME/shell/"

2020-05-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15881 ) Change subject: Revert "IMPALA-9718: Delete pkg_resources from IMPALA_HOME/shell/" .. Revert "IMPALA-9718: Delete pkg_resource

[Impala-ASF-CR] Revert "IMPALA-9718: Delete pkg resources from IMPALA HOME/shell/"

2020-05-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15881 ) Change subject: Revert "IMPALA-9718: Delete pkg_resources from IMPALA_HOME/shell/" .. Patch Set 1: Verified+1 The tests that were fai

[Impala-ASF-CR] Only build ext-py directories tracked by git for make shell tarball.sh

2020-05-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15886 Change subject: Only build ext-py directories tracked by git for make_shell_tarball.sh .. Only build ext-py directories tracked by git

[Impala-ASF-CR] IMPALA-9714: Fix edge cases in SimpleLogger and add test

2020-05-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15861 ) Change subject: IMPALA-9714: Fix edge cases in SimpleLogger and add test .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] Revert "IMPALA-8980: Remove functional*.alltypesinsert from EE tests"

2020-05-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15902 Change subject: Revert "IMPALA-8980: Remove functional*.alltypesinsert from EE tests" .. Revert "IMPALA-8980: Remove functional*.alltyp

[Impala-ASF-CR] Revert "IMPALA-9665: Fixed database not found errors in query test.test insert"

2020-05-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15901 Change subject: Revert "IMPALA-9665: Fixed database not found errors in query_test.test_insert" .. Revert "IMPALA-9665: Fixed database

[Impala-ASF-CR] IMPALA-9708: Remove Sentry support

2020-05-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15833 Change subject: IMPALA-9708: Remove Sentry support .. IMPALA-9708: Remove Sentry support Impala 4 decided to drop Sentry support in fav

[Impala-ASF-CR] IMPALA-9714: Fix edge cases in SimpleLogger and add test

2020-05-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15861 ) Change subject: IMPALA-9714: Fix edge cases in SimpleLogger and add test .. Patch Set 2: (3 comments) I addressed some comments and t

[Impala-ASF-CR] IMPALA-9714: Fix edge cases in SimpleLogger and add test

2020-05-11 Thread Joe McDonnell (Code Review)
Hello Thomas Tauber-Marshall, Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15861 to look at the new patch set (#3). Change subject: IMPALA-9714: Fix edge cases in SimpleLogger and add test .

[Impala-ASF-CR] Revert "IMPALA-8980: Remove functional*.alltypesinsert from EE tests"

2020-05-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has abandoned this change. ( http://gerrit.cloudera.org:8080/15902 ) Change subject: Revert "IMPALA-8980: Remove functional*.alltypesinsert from EE tests" .. Abandoned Already synced up, and the fix for IMPALA-9

[Impala-ASF-CR] Revert "IMPALA-9665: Fixed database not found errors in query test.test insert"

2020-05-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has abandoned this change. ( http://gerrit.cloudera.org:8080/15901 ) Change subject: Revert "IMPALA-9665: Fixed database not found errors in query_test.test_insert" .. Abandoned Already synced up, and the fix fo

[Impala-ASF-CR] IMPALA-9714: Fix edge cases in SimpleLogger and add test

2020-05-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15861 ) Change subject: IMPALA-9714: Fix edge cases in SimpleLogger and add test .. IMPALA-9714: Fix edge cases in SimpleLogger and add

[Impala-ASF-CR] IMPALA-9435: Usability enhancements for data cache access trace

2020-05-14 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15914 to look at the new patch set (#3). Change subject: IMPALA-9435: Usability enhancements for data cache access trace

[Impala-ASF-CR] IMPALA-9435: Usability enhancements for data cache access trace

2020-05-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15914 ) Change subject: IMPALA-9435: Usability enhancements for data cache access trace .. Patch Set 3: (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-9435: Usability enhancements for data cache access trace

2020-05-14 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15914 to look at the new patch set (#4). Change subject: IMPALA-9435: Usability enhancements for data cache access trace

[Impala-ASF-CR] IMPALA-9708: Remove Sentry support

2020-05-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/15833 ) Change subject: IMPALA-9708: Remove Sentry support .. IMPALA-9708: Remove Sentry support Impala 4 decided to drop Sentry support in favo

[Impala-ASF-CR] IMPALA-9679: Remove some jars from Docker images

2020-05-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15753 ) Change subject: IMPALA-9679: Remove some jars from Docker images .. Patch Set 9: Code-Review+2 This looks good to me. -- To view, vi

[Impala-ASF-CR] Only build ext-py directories tracked by git for make shell tarball.sh

2020-05-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15886 ) Change subject: Only build ext-py directories tracked by git for make_shell_tarball.sh .. Patch Set 1: > Isn't this going to cause pr

[Impala-ASF-CR] Only build ext-py directories tracked by git for make shell tarball.sh

2020-05-14 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15886 to look at the new patch set (#2). Change subject: Only build ext-py directories tracked by git for make_shell_tarball.sh

[Impala-ASF-CR] Only build ext-py directories tracked by git for make shell tarball.sh

2020-05-14 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15886 to look at the new patch set (#3). Change subject: Only build ext-py directories tracked by git for make_shell_tarball.sh

[Impala-ASF-CR] Only build ext-py directories tracked by git for make shell tarball.sh

2020-05-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15886 ) Change subject: Only build ext-py directories tracked by git for make_shell_tarball.sh .. Patch Set 2: (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-9192: Move Avro-Java and Parquet dependencies to the CDP version

2020-05-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15933 ) Change subject: IMPALA-9192: Move Avro-Java and Parquet dependencies to the CDP version .. Patch Set 1: Code-Review+2 (1 comment) Th

[Impala-ASF-CR] IMPALA-9708: Remove Sentry support

2020-05-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15833 ) Change subject: IMPALA-9708: Remove Sentry support .. Patch Set 5: > Hi Joe, thank you for the effort to remove Sentry support! > >

[Impala-ASF-CR] [WIP] IMPALA-9433: File handle cache improvements.

2020-05-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15699 ) Change subject: [WIP] IMPALA-9433: File handle cache improvements. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15

[Impala-ASF-CR] IMPALA-9749: ASAN builds should not run FE tests.

2020-05-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15921 ) Change subject: IMPALA-9749: ASAN builds should not run FE tests. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/159

[Impala-ASF-CR] IMPALA-9708: Remove Sentry support

2020-05-19 Thread Joe McDonnell (Code Review)
Hello Quanlong Huang, Fang-Yu Rao, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15833 to look at the new patch set (#6). Change subject: IMPALA-9708: Remove Sentry support ..

[Impala-ASF-CR] IMPALA-9708: Remove Sentry support

2020-05-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15833 ) Change subject: IMPALA-9708: Remove Sentry support .. Patch Set 5: > (1 comment) > > Thanks for doing the cleanup! Is this the part-

[Impala-ASF-CR] IMPALA-9708: Remove Sentry support

2020-05-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15833 ) Change subject: IMPALA-9708: Remove Sentry support .. Patch Set 7: Code-Review+2 The way that I'm thinking about this change is that t

[Impala-ASF-CR] IMPALA-9761: Fix GCC7 ambiguous else warning for gtest macros

2020-05-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15964 Change subject: IMPALA-9761: Fix GCC7 ambiguous else warning for gtest macros .. IMPALA-9761: Fix GCC7 ambiguous else warning for gtest

[Impala-ASF-CR] IMPALA-9708: Remove Sentry support

2020-05-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15833 ) Change subject: IMPALA-9708: Remove Sentry support .. IMPALA-9708: Remove Sentry support Impala 4 decided to drop Sentry suppo

[Impala-ASF-CR] IMPALA-9777: Use Impala to do text tpcds.store sales load

2020-05-22 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15980 to look at the new patch set (#2). Change subject: IMPALA-9777: Use Impala to do text tpcds.store_sales load ..

[Impala-ASF-CR] IMPALA-9760: Add NATIVE PACKAGES HOME to prepare for GCC7

2020-05-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15991 Change subject: IMPALA-9760: Add NATIVE_PACKAGES_HOME to prepare for GCC7 .. IMPALA-9760: Add NATIVE_PACKAGES_HOME to prepare for GCC7

[Impala-ASF-CR] IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores

2020-05-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15993 Change subject: IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores .. IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores When

[Impala-ASF-CR] IMPALA-9415: Switch result set size calculations from capacity() to size()

2020-05-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15992 Change subject: IMPALA-9415: Switch result set size calculations from capacity() to size() .. IMPALA-9415: Switch result set size calcu

[Impala-ASF-CR] IMPALA-9107 (part 2): Add script to use the m2 archive tarball

2020-05-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15735 Change subject: IMPALA-9107 (part 2): Add script to use the m2 archive tarball .. IMPALA-9107 (part 2): Add script to use the m2 archive

[Impala-ASF-CR] IMPALA-9760: Add NATIVE PACKAGES HOME to prepare for GCC7

2020-05-28 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15991 to look at the new patch set (#2). Change subject: IMPALA-9760: Add NATIVE_PACKAGES_HOME to prepare for GCC7 ..

[Impala-ASF-CR] IMPALA-9760: Add NATIVE PACKAGES HOME to prepare for GCC7

2020-05-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15991 ) Change subject: IMPALA-9760: Add NATIVE_PACKAGES_HOME to prepare for GCC7 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-9761: Fix GCC7 ambiguous else warning for gtest macros

2020-05-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15964 ) Change subject: IMPALA-9761: Fix GCC7 ambiguous else warning for gtest macros .. Patch Set 1: Thanks for the review, going ahead with

[Impala-ASF-CR] IMPALA-9777: Set hive.optimize.sort.dynamic.partition to true for dynamic inserts

2020-05-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15998 ) Change subject: IMPALA-9777: Set hive.optimize.sort.dynamic.partition to true for dynamic inserts .. Patch Set 2: (3 comments) http:

[Impala-ASF-CR] IMPALA-9760: Add NATIVE PACKAGES HOME to prepare for GCC7

2020-05-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15991 ) Change subject: IMPALA-9760: Add NATIVE_PACKAGES_HOME to prepare for GCC7 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-9760: Add IMPALA TOOLCHAIN PACKAGES HOME to prepare for GCC7

2020-05-28 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15991 to look at the new patch set (#3). Change subject: IMPALA-9760: Add IMPALA_TOOLCHAIN_PACKAGES_HOME to prepare for GCC7

[Impala-ASF-CR] IMPALA-9760: Add IMPALA TOOLCHAIN PACKAGES HOME to prepare for GCC7

2020-05-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15991 ) Change subject: IMPALA-9760: Add IMPALA_TOOLCHAIN_PACKAGES_HOME to prepare for GCC7 .. Patch Set 3: (2 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-9800: Fix undefined behavior in DecimalUtil::DecodeFromFixedLenByteArray()

2020-05-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16004 Change subject: IMPALA-9800: Fix undefined behavior in DecimalUtil::DecodeFromFixedLenByteArray() .. IMPALA-9800: Fix undefined behavio

[Impala-ASF-CR] IMPALA-9800: Fix undefined behavior in DecimalUtil::DecodeFromFixedLenByteArray()

2020-05-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16004 ) Change subject: IMPALA-9800: Fix undefined behavior in DecimalUtil::DecodeFromFixedLenByteArray() .. Patch Set 1: I'm running a UBSAN

[Impala-ASF-CR] Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores"

2020-05-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16006 Change subject: Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores" .. Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loa

[Impala-ASF-CR] IMPALA-9800: Fix undefined behavior in DecimalUtil::DecodeFromFixedLenByteArray()

2020-05-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16004 ) Change subject: IMPALA-9800: Fix undefined behavior in DecimalUtil::DecodeFromFixedLenByteArray() .. Patch Set 1: > Hm, I don't under

[Impala-ASF-CR] Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores"

2020-05-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16006 ) Change subject: Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores" .. Patch Set 1: Code-Review+2 Clean revert of my own

[Impala-ASF-CR] Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores"

2020-05-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16006 ) Change subject: Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores" .. Revert "IMPALA-9781: Fix GCC 7 unaligned 12

[Impala-ASF-CR] IMPALA-9760: Add IMPALA TOOLCHAIN PACKAGES HOME to prepare for GCC7

2020-05-29 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15991 to look at the new patch set (#4). Change subject: IMPALA-9760: Add IMPALA_TOOLCHAIN_PACKAGES_HOME to prepare for GCC7

[Impala-ASF-CR] IMPALA-9760: Add IMPALA TOOLCHAIN PACKAGES HOME to prepare for GCC7

2020-05-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15991 ) Change subject: IMPALA-9760: Add IMPALA_TOOLCHAIN_PACKAGES_HOME to prepare for GCC7 .. Patch Set 4: Code-Review+2 Added those comment

[Impala-ASF-CR] IMPALA-9760: Add IMPALA TOOLCHAIN PACKAGES HOME to prepare for GCC7

2020-05-29 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15991 to look at the new patch set (#5). Change subject: IMPALA-9760: Add IMPALA_TOOLCHAIN_PACKAGES_HOME to prepare for GCC7

[Impala-ASF-CR] IMPALA-9760: Add IMPALA TOOLCHAIN PACKAGES HOME to prepare for GCC7

2020-05-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15991 ) Change subject: IMPALA-9760: Add IMPALA_TOOLCHAIN_PACKAGES_HOME to prepare for GCC7 .. Patch Set 5: Code-Review+2 Did a build with IM

[Impala-ASF-CR] IMPALA-9760: Add IMPALA TOOLCHAIN PACKAGES HOME to prepare for GCC7

2020-05-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15991 ) Change subject: IMPALA-9760: Add IMPALA_TOOLCHAIN_PACKAGES_HOME to prepare for GCC7 .. IMPALA-9760: Add IMPALA_TOOLCHAIN_PACKA

[Impala-ASF-CR] IMPALA-9777: Set hive.optimize.sort.dynamic.partition to true for dynamic inserts

2020-05-31 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15998 ) Change subject: IMPALA-9777: Set hive.optimize.sort.dynamic.partition to true for dynamic inserts .. Patch Set 3: Code-Review+2 (1 co

[Impala-ASF-CR] IMPALA-9777: Use Impala to do text tpcds.store sales load

2020-05-31 Thread Joe McDonnell (Code Review)
Joe McDonnell has abandoned this change. ( http://gerrit.cloudera.org:8080/15980 ) Change subject: IMPALA-9777: Use Impala to do text tpcds.store_sales load .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/15980 T

[Impala-ASF-CR] Reapply IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores

2020-05-31 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16009 Change subject: Reapply IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores .. Reapply IMPALA-9781: Fix GCC 7 unaligned 128-bit load

[Impala-ASF-CR] IMPALA-9673: Add external warehouse dir variable in E2E test

2020-05-31 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15990 ) Change subject: IMPALA-9673: Add external warehouse dir variable in E2E test .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] Only build ext-py directories tracked by git for make shell tarball.sh

2020-06-01 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15886 ) Change subject: Only build ext-py directories tracked by git for make_shell_tarball.sh .. Patch Set 4: Code-Review+2 Carry +2 -- To

[Impala-ASF-CR] IMPALA-9800: Fix undefined behavior in DecimalUtil::DecodeFromFixedLenByteArray()

2020-06-01 Thread Joe McDonnell (Code Review)
Joe McDonnell has abandoned this change. ( http://gerrit.cloudera.org:8080/16004 ) Change subject: IMPALA-9800: Fix undefined behavior in DecimalUtil::DecodeFromFixedLenByteArray() .. Abandoned -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-9702: Cleanup unique database directories

2020-06-01 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16015 Change subject: IMPALA-9702: Cleanup unique_database directories .. IMPALA-9702: Cleanup unique_database directories If there are exter

[Impala-ASF-CR] IMPALA-9702: Cleanup unique database directories

2020-06-01 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16015 to look at the new patch set (#2). Change subject: IMPALA-9702: Cleanup unique_database directories .. IMP

[Impala-ASF-CR] [DOCS] data cache is not experimental

2020-06-01 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16016 ) Change subject: [DOCS] data cache is not experimental .. Patch Set 1: Code-Review+2 Thanks for fixing this -- To view, visit http://

[Impala-ASF-CR] Reapply IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores

2020-06-01 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16009 ) Change subject: Reapply IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores .. Reapply IMPALA-9781: Fix GCC 7 unaligned 128

[Impala-ASF-CR] IMPALA-9318: Add admission control setting to cap MT DOP

2020-06-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16020 Change subject: IMPALA-9318: Add admission control setting to cap MT_DOP .. IMPALA-9318: Add admission control setting to cap MT_DOP Th

[Impala-ASF-CR] IMPALA-9000: clean up misc TODO-MT comments

2020-06-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16023 ) Change subject: IMPALA-9000: clean up misc TODO-MT comments .. Patch Set 1: Code-Review+2 (2 comments) This makes sense to me. A coup

[Impala-ASF-CR] IMPALA-9673: Add external warehouse dir variable in E2E test

2020-06-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15990 ) Change subject: IMPALA-9673: Add external warehouse dir variable in E2E test .. Patch Set 7: Code-Review+1 (3 comments) This looks go

[Impala-ASF-CR] IMPALA-9673: Add external warehouse dir variable in E2E test

2020-06-03 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15990 ) Change subject: IMPALA-9673: Add external warehouse dir variable in E2E test .. Patch Set 8: Code-Review+2 Looks good! -- To view, v

[Impala-ASF-CR] IMPALA-9673: Add external warehouse dir variable in E2E test

2020-06-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15990 ) Change subject: IMPALA-9673: Add external warehouse dir variable in E2E test .. Patch Set 11: The test failure does not look related t

[Impala-ASF-CR] Filter out "Checksum validation failed" messages during the maven build

2020-06-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15775 ) Change subject: Filter out "Checksum validation failed" messages during the maven build .. Patch Set 5: Thanks for the review! -- T

[Impala-ASF-CR] IMPALA-9318: Add admission control setting to cap MT DOP

2020-06-05 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16020 to look at the new patch set (#4). Change subject: IMPALA-9318: Add admission control setting to cap MT_DOP

[Impala-ASF-CR] IMPALA-9318: Add admission control setting to cap MT DOP

2020-06-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16020 ) Change subject: IMPALA-9318: Add admission control setting to cap MT_DOP .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-9709: Remove Impala-lzo from the development environment

2020-06-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15814 Change subject: IMPALA-9709: Remove Impala-lzo from the development environment .. IMPALA-9709: Remove Impala-lzo from the development e

[Impala-ASF-CR] IMPALA-9838: Switch to GCC 7.5.0

2020-06-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16045 Change subject: IMPALA-9838: Switch to GCC 7.5.0 .. IMPALA-9838: Switch to GCC 7.5.0 This upgrades GCC and libstdc++ to version 7.5.0.

[Impala-ASF-CR] IMPALA-9709: Remove Impala-lzo from the development environment

2020-06-07 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15814 to look at the new patch set (#5). Change subject: IMPALA-9709: Remove Impala-lzo from the development environment

[Impala-ASF-CR] IMPALA-9838: Switch to GCC 7.5.0

2020-06-07 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16045 to look at the new patch set (#4). Change subject: IMPALA-9838: Switch to GCC 7.5.0 .. IMPALA-9838: Switch

[Impala-ASF-CR] IMPALA-9709: Remove Impala-lzo from the development environment

2020-06-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15814 ) Change subject: IMPALA-9709: Remove Impala-lzo from the development environment .. Patch Set 4: (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-9838: Switch to GCC 7.5.0

2020-06-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16045 ) Change subject: IMPALA-9838: Switch to GCC 7.5.0 .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/16045/3/bin/impala-

[native-toolchain-CR] IMPALA-9837: Switch to GCC 7.5

2020-06-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15205 Change subject: IMPALA-9837: Switch to GCC 7.5 .. IMPALA-9837: Switch to GCC 7.5 This changes GCC from version 4.9.2 to 7.5.0. The libs

[native-toolchain-CR] IMPALA-9837: Switch to GCC 7.5

2020-06-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15205 ) Change subject: IMPALA-9837: Switch to GCC 7.5 .. Patch Set 2: > Oh I guess this is still a draft. Looks fine to me but I'll wait > u

[Impala-ASF-CR] IMPALA-9435: Usability enhancements for data cache access trace

2020-06-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15914 ) Change subject: IMPALA-9435: Usability enhancements for data cache access trace .. Patch Set 5: (9 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-9435: Usability enhancements for data cache access trace

2020-06-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15914 ) Change subject: IMPALA-9435: Usability enhancements for data cache access trace .. Patch Set 5: This GVO run hit IMPALA-9830 -- To v

[Impala-ASF-CR] IMPALA-9435: Usability enhancements for data cache access trace

2020-06-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/15914 ) Change subject: IMPALA-9435: Usability enhancements for data cache access trace .. IMPALA-9435: Usability enhancements for data cache acc

[Impala-ASF-CR] IMPALA-9318: Add admission control setting to cap MT DOP

2020-06-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16020 ) Change subject: IMPALA-9318: Add admission control setting to cap MT_DOP .. IMPALA-9318: Add admission control setting to cap M

[Impala-ASF-CR] IMPALA-9435: Usability enhancements for data cache access trace

2020-06-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15914 ) Change subject: IMPALA-9435: Usability enhancements for data cache access trace .. Patch Set 6: Rebased past the fix for IMPALA-9830

[Impala-ASF-CR] IMPALA-9814: fix mt dop parallelism for analytic fns

2020-06-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16022 ) Change subject: IMPALA-9814: fix mt_dop parallelism for analytic fns .. Patch Set 2: Code-Review+1 This makes sense to me. I'm willing

[Impala-ASF-CR] IMPALA-9435: Usability enhancements for data cache access trace

2020-06-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15914 ) Change subject: IMPALA-9435: Usability enhancements for data cache access trace .. Patch Set 6: (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-9435: Usability enhancements for data cache access trace

2020-06-09 Thread Joe McDonnell (Code Review)
Hello Thomas Tauber-Marshall, Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15914 to look at the new patch set (#7). Change subject: IMPALA-9435: Usability enhancements for data cache access trace ..

[Impala-ASF-CR] IMPALA-9435: Usability enhancements for data cache access trace

2020-06-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15914 ) Change subject: IMPALA-9435: Usability enhancements for data cache access trace .. Patch Set 7: Code-Review+1 Carry +1 -- To view, v

[Impala-ASF-CR] IMPALA-9844: Ozone support for load data inpath

2020-06-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16055 ) Change subject: IMPALA-9844: Ozone support for load data inpath .. Patch Set 2: Code-Review+1 (2 comments) This makes sense to me, on

[Impala-ASF-CR] IMPALA-9814: fix mt dop parallelism for analytic fns

2020-06-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16022 ) Change subject: IMPALA-9814: fix mt_dop parallelism for analytic fns .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-9752: aggregate profile stats on executor

2020-06-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16050 ) Change subject: IMPALA-9752: aggregate profile stats on executor .. Patch Set 4: Code-Review+1 (2 comments) This is making sense to m

[Impala-ASF-CR] IMPALA-9107 (part 2): Add script to use the m2 archive tarball

2020-06-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15735 ) Change subject: IMPALA-9107 (part 2): Add script to use the m2 archive tarball .. Patch Set 6: (2 comments) http://gerrit.cloudera.or

<    4   5   6   7   8   9   10   11   12   13   >