[Impala-ASF-CR] IMPALA-11604 (part 1): Model ProcessingCost for PlanNodes & DataSink

2023-03-06 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 (part 1): Model ProcessingCost for PlanNodes & DataSink .. Patch Set 59: -Code-Review This is now split

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-03-06 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 58: Code-Review-2 Putting -2 for now until I managed to split

[Impala-ASF-CR] IMPALA-11989: ImpalaRuntimeException if Kudu and Impala use different HMS

2023-03-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19605 ) Change subject: IMPALA-11989: ImpalaRuntimeException if Kudu and Impala use different HMS .. Patch Set 2: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-11989: ImpalaRuntimeException if Kudu and Impala use different HMS

2023-03-10 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19605 ) Change subject: IMPALA-11989: ImpalaRuntimeException if Kudu and Impala use different HMS .. Patch Set 3: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-12005: Describe executor group set selection in query profile

2023-03-16 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Abhishek Rawat, David Rorke, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19628 to look at the new patch set (#2). Change subject: IMPALA-12005: Describe executor group set selection in query

[Impala-ASF-CR] IMPALA-12005: Describe executor group set selection in query profile

2023-03-16 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Abhishek Rawat, David Rorke, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19628 to look at the new patch set (#3). Change subject: IMPALA-12005: Describe executor group set selection in query

[Impala-ASF-CR] IMPALA-12005: Describe executor group set selection in query profile

2023-03-16 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Abhishek Rawat, David Rorke, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19628 to look at the new patch set (#4). Change subject: IMPALA-12005: Describe executor group set selection in query

[Impala-ASF-CR] IMPALA-12005: Describe executor group set selection in query profile

2023-03-16 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19628 ) Change subject: IMPALA-12005: Describe executor group set selection in query profile .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-12005: Describe executor group set selection in query profile

2023-03-16 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19628 ) Change subject: IMPALA-12005: Describe executor group set selection in query profile .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-12005: Describe executor group set selection in query profile

2023-03-16 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19628 ) Change subject: IMPALA-12005: Describe executor group set selection in query profile .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-11989: ImpalaRuntimeException if Kudu and Impala use different HMS

2023-03-14 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19605 ) Change subject: IMPALA-11989: ImpalaRuntimeException if Kudu and Impala use different HMS .. Patch Set 3: Code-Review+2 Carry

[Impala-ASF-CR] IMPALA-12017: Skip memory and cpu limit check if REQUEST POOL is set

2023-03-22 Thread Riza Suminto (Code Review)
Hello Andrew Sherman, Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19645 to look at the new patch set (#5). Change subject: IMPALA-12017: Skip memory and cpu limit check if REQUEST_POOL is set

[Impala-ASF-CR] IMPALA-12017: Skip memory and cpu limit check if REQUEST POOL is set

2023-03-22 Thread Riza Suminto (Code Review)
Hello Andrew Sherman, Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19645 to look at the new patch set (#3). Change subject: IMPALA-12017: Skip memory and cpu limit check if REQUEST_POOL is set

[Impala-ASF-CR] IMPALA-12017: Skip memory and cpu limit check if REQUEST POOL is set

2023-03-22 Thread Riza Suminto (Code Review)
Hello Andrew Sherman, Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19645 to look at the new patch set (#6). Change subject: IMPALA-12017: Skip memory and cpu limit check if REQUEST_POOL is set

[Impala-ASF-CR] IMPALA-12017: Skip memory and cpu limit check if REQUEST POOL is set

2023-03-22 Thread Riza Suminto (Code Review)
Hello Andrew Sherman, Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19645 to look at the new patch set (#4). Change subject: IMPALA-12017: Skip memory and cpu limit check if REQUEST_POOL is set

[Impala-ASF-CR] IMPALA-12017: Skip memory and cpu limit check if REQUEST POOL is set

2023-03-22 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19645 ) Change subject: IMPALA-12017: Skip memory and cpu limit check if REQUEST_POOL is set .. Patch Set 4: (2 comments) Test failure was

[Impala-ASF-CR] IMPALA-12017: Skip memory and cpu limit check if REQUEST POOL is set

2023-03-22 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19645 ) Change subject: IMPALA-12017: Skip memory and cpu limit check if REQUEST_POOL is set .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-12017: Skip memory and cpu limit check if REQUEST POOL is set

2023-03-22 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19645 ) Change subject: IMPALA-12017: Skip memory and cpu limit check if REQUEST_POOL is set .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-12005: Describe executor group set selection in query profile

2023-03-20 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Abhishek Rawat, David Rorke, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19628 to look at the new patch set (#5). Change subject: IMPALA-12005: Describe executor group set selection in query

[Impala-ASF-CR] IMPALA-12017: Skip memory and cpu limit check if REQUEST POOL is set

2023-03-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19645 ) Change subject: IMPALA-12017: Skip memory and cpu limit check if REQUEST_POOL is set .. Patch Set 6: Code-Review+2 Carry +2 -- To

[Impala-ASF-CR] IMPALA-8731: Balance queries across multiple executor groups

2023-03-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19630 ) Change subject: IMPALA-8731: Balance queries across multiple executor groups .. Patch Set 5: (1 comment) This looks OK to me. I just

[Impala-ASF-CR] IMPALA-12005: Describe executor group set selection in query profile

2023-03-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19628 ) Change subject: IMPALA-12005: Describe executor group set selection in query profile .. Patch Set 6: Verified+1 Code-Review+2 Carry

[Impala-ASF-CR] IMPALA-12005: Describe executor group set selection in query profile

2023-03-23 Thread Riza Suminto (Code Review)
Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19628 ) Change subject: IMPALA-12005: Describe executor group set selection in query profile .. IMPALA-12005: Describe executor group

[Impala-ASF-CR] IMPALA-12017: Skip memory and cpu limit check if REQUEST POOL is set

2023-03-23 Thread Riza Suminto (Code Review)
Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19645 ) Change subject: IMPALA-12017: Skip memory and cpu limit check if REQUEST_POOL is set .. IMPALA-12017: Skip memory and cpu

[Impala-ASF-CR] IMPALA-12023: Skip resource checking on last executor group set

2023-03-23 Thread Riza Suminto (Code Review)
Hello Andrew Sherman, Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19649 to look at the new patch set (#3). Change subject: IMPALA-12023: Skip resource checking on last executor group set

[Impala-ASF-CR] IMPALA-12023: Skip resource checking on last executor group set

2023-03-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19649 ) Change subject: IMPALA-12023: Skip resource checking on last executor group set .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-12023: Skip resource checking on last executor group set

2023-03-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19649 ) Change subject: IMPALA-12023: Skip resource checking on last executor group set .. Patch Set 3: Code-Review+2 Thank you Wenzhe and

[Impala-ASF-CR] IMPALA-12023: Skip resource checking on last executor group set

2023-03-23 Thread Riza Suminto (Code Review)
Hello Andrew Sherman, Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19649 to look at the new patch set (#2). Change subject: IMPALA-12023: Skip resource checking on last executor group set

[Impala-ASF-CR] IMPALA-12023: Skip resource checking on last executor group set

2023-03-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19649 ) Change subject: IMPALA-12023: Skip resource checking on last executor group set .. Patch Set 4: Code-Review-2 Apologies, it looks like

[Impala-ASF-CR] IMPALA-12023: Skip resource checking on last executor group set

2023-03-23 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19649 Change subject: IMPALA-12023: Skip resource checking on last executor group set .. IMPALA-12023: Skip resource checking on last executor

[Impala-ASF-CR] IMPALA-12023: Skip resource checking on last executor group set

2023-03-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19649 ) Change subject: IMPALA-12023: Skip resource checking on last executor group set .. Patch Set 4:

[Impala-ASF-CR] IMPALA-12025: Hide misleading TotalTime and InactiveTotalTime

2023-03-24 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19652 Change subject: IMPALA-12025: Hide misleading TotalTime and InactiveTotalTime .. IMPALA-12025: Hide misleading TotalTime and

[Impala-ASF-CR] IMPALA-8731: Balance queries across multiple executor groups

2023-03-25 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19630 ) Change subject: IMPALA-8731: Balance queries across multiple executor groups .. Patch Set 9: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12005: Describe executor group set selection in query profile

2023-03-20 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19628 ) Change subject: IMPALA-12005: Describe executor group set selection in query profile .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-12017: Skip memory and cpu limit check if REQUEST POOL is set

2023-03-22 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19645 Change subject: IMPALA-12017: Skip memory and cpu limit check if REQUEST_POOL is set .. IMPALA-12017: Skip memory and cpu limit check

[Impala-ASF-CR] IMPALA-12017: Skip memory and cpu limit check if REQUEST POOL is set

2023-03-22 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19645 ) Change subject: IMPALA-12017: Skip memory and cpu limit check if REQUEST_POOL is set .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-12017: Skip memory and cpu limit check if REQUEST POOL is set

2023-03-22 Thread Riza Suminto (Code Review)
Hello Andrew Sherman, Abhishek Rawat, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19645 to look at the new patch set (#2). Change subject: IMPALA-12017: Skip memory and cpu limit check if REQUEST_POOL is set

[Impala-ASF-CR] IMPALA-12017: Skip memory and cpu limit check if REQUEST POOL is set

2023-03-22 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19645 ) Change subject: IMPALA-12017: Skip memory and cpu limit check if REQUEST_POOL is set .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-11989: ImpalaRuntimeException if Kudu and Impala use different HMS

2023-03-14 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19605 ) Change subject: IMPALA-11989: ImpalaRuntimeException if Kudu and Impala use different HMS .. Patch Set 4: > Patch Set 4: Verified-1 >

[Impala-ASF-CR] IMPALA-12005: Describe executor group set selection in query profile

2023-03-16 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19628 Change subject: IMPALA-12005: Describe executor group set selection in query profile .. IMPALA-12005: Describe executor group set

[Impala-ASF-CR] IMPALA-11970: Add query timing display to Impala WebUI

2023-03-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19583 ) Change subject: IMPALA-11970: Add query timing display to Impala WebUI .. Patch Set 2: Code-Review+1 (1 comment) The CPP code looks

[Impala-ASF-CR] IMPALA-11970: Add query timeline display to Impala WebUI

2023-03-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19583 ) Change subject: IMPALA-11970: Add query timeline display to Impala WebUI .. Patch Set 3: Code-Review+2 Carry +1 from Wenzhe. -- To

[Impala-ASF-CR] IMPALA-11940: [DOCS] Document manifest caching settings for Iceberg

2023-02-23 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19530 Change subject: IMPALA-11940: [DOCS] Document manifest caching settings for Iceberg .. IMPALA-11940: [DOCS] Document manifest caching

[Impala-ASF-CR] IMPALA-11940: [DOCS] Document manifest caching settings for Iceberg

2023-02-23 Thread Riza Suminto (Code Review)
Hello Andrew Sherman, Gabor Kaszab, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19530 to look at the new patch set (#2). Change subject: IMPALA-11940: [DOCS] Document manifest caching settings for Iceberg

[Impala-ASF-CR] IMPALA-11795: Ignore high/low values stats for timestamp columns

2023-02-27 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19548 ) Change subject: IMPALA-11795: Ignore high/low values stats for timestamp columns .. Patch Set 2: Code-Review+2 LGTM! Carry Daniel's

[Impala-ASF-CR] IMPALA-11795: Ignore high/low values stats for timestamp columns

2023-02-27 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19548 ) Change subject: IMPALA-11795: Ignore high/low values stats for timestamp columns .. Patch Set 2: -Code-Review (2 comments) Sorry for

[Impala-ASF-CR] IMPALA-11924: Cap runtime filter NDV with build key NDV

2023-02-27 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19506 ) Change subject: IMPALA-11924: Cap runtime filter NDV with build key NDV .. Patch Set 3: Code-Review+1 This looks OK to me. -- To

[Impala-ASF-CR] IMPALA-11953: Declare num trues and num falses in TIntermediateColumnStats as optional

2023-02-27 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19555 ) Change subject: IMPALA-11953: Declare num_trues and num_falses in TIntermediateColumnStats as optional .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-11953: Declare num trues and num falses in TIntermediateColumnStats as optional

2023-02-27 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19555 ) Change subject: IMPALA-11953: Declare num_trues and num_falses in TIntermediateColumnStats as optional .. Patch Set 1: Code-Review+2

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-03-02 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 53: Patch set 53 update the planner test expected output after

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-03-02 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#53) to the change originally created by Qifan Chen. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. IMPALA-11604 Planner

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-03-02 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#54) to the change originally created by Qifan Chen. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. IMPALA-11604 Planner

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-03-02 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 54: (42 comments) Patch set 54 address comments from patch

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-03-03 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 55: (11 comments)

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-03-03 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#55) to the change originally created by Qifan Chen. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. IMPALA-11604 Planner

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-03-03 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 57: (5 comments) Done. Sorry for duplicating

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-03-03 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#56) to the change originally created by Qifan Chen. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. IMPALA-11604 Planner

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-03-03 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#57) to the change originally created by Qifan Chen. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. IMPALA-11604 Planner

[Impala-ASF-CR] IMPALA-11924: Cap runtime filter NDV with build key NDV

2023-02-16 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19506 ) Change subject: IMPALA-11924: Cap runtime filter NDV with build key NDV .. Patch Set 1: (1 comment) Hi Csaba, I have a question.

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-02-16 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 49: (9 comments)

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-02-16 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#49) to the change originally created by Qifan Chen. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. IMPALA-11604 Planner

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-02-22 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 51: (4 comments)

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-02-22 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#51) to the change originally created by Qifan Chen. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. IMPALA-11604 Planner

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-02-22 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#50) to the change originally created by Qifan Chen. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. IMPALA-11604 Planner

[Impala-ASF-CR] IMPALA-11940: [DOCS] Document manifest caching settings for Iceberg

2023-02-24 Thread Riza Suminto (Code Review)
Hello Andrew Sherman, Daniel Becker, Gabor Kaszab, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19530 to look at the new patch set (#4). Change subject: IMPALA-11940: [DOCS] Document manifest caching settings

[Impala-ASF-CR] IMPALA-11940: [DOCS] Document manifest caching settings for Iceberg

2023-02-24 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19530 ) Change subject: IMPALA-11940: [DOCS] Document manifest caching settings for Iceberg .. Patch Set 4: (10 comments)

[Impala-ASF-CR] IMPALA-11940: [DOCS] Document manifest caching settings for Iceberg

2023-02-24 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19530 ) Change subject: IMPALA-11940: [DOCS] Document manifest caching settings for Iceberg .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-11940: [DOCS] Document manifest caching settings for Iceberg

2023-02-24 Thread Riza Suminto (Code Review)
Hello Andrew Sherman, Daniel Becker, Gabor Kaszab, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19530 to look at the new patch set (#3). Change subject: IMPALA-11940: [DOCS] Document manifest caching settings

[Impala-ASF-CR] IMPALA-11940: [DOCS] Document manifest caching settings for Iceberg

2023-02-24 Thread Riza Suminto (Code Review)
Hello Andrew Sherman, Daniel Becker, Gabor Kaszab, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19530 to look at the new patch set (#5). Change subject: IMPALA-11940: [DOCS] Document manifest caching settings

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-02-24 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#52) to the change originally created by Qifan Chen. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. IMPALA-11604 Planner

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-02-24 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 52: (25 comments) ps52 is a rebase and address some comments

[Impala-ASF-CR] IMPALA-11795: Ignore high/low values stats for timestamp columns

2023-02-28 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19548 ) Change subject: IMPALA-11795: Ignore high/low values stats for timestamp columns .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-11795: Ignore high/low values stats for timestamp columns

2023-03-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19548 ) Change subject: IMPALA-11795: Ignore high/low values stats for timestamp columns .. Patch Set 4: Code-Review+2 (1 comment) Thank you

[Impala-ASF-CR] IMPALA-11945: Fix Flaky Test in JwtHttpTest

2023-02-24 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19536 ) Change subject: IMPALA-11945: Fix Flaky Test in JwtHttpTest .. Patch Set 5: (1 comment) Thanks Jason, just have 1 more nit.

[Impala-ASF-CR] IMPALA-11945: Fix Flaky Test in JwtHttpTest

2023-02-24 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19536 ) Change subject: IMPALA-11945: Fix Flaky Test in JwtHttpTest .. Patch Set 6: Code-Review+2 Looks good, thanks! Carry Andrew's +1. --

[Impala-ASF-CR] IMPALA-11924: Cap runtime filter NDV with build key NDV

2023-02-27 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19506 ) Change subject: IMPALA-11924: Cap runtime filter NDV with build key NDV .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-11795: Ignore high/low values stats for timestamp columns

2023-02-27 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19548 ) Change subject: IMPALA-11795: Ignore high/low values stats for timestamp columns .. Patch Set 1: (3 comments) Thanks Csaba! I have

[Impala-ASF-CR] IMPALA-11945: Fix Flaky Test in JwtHttpTest

2023-02-24 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19536 ) Change subject: IMPALA-11945: Fix Flaky Test in JwtHttpTest .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-12058: Impala throw exception for CTAS with non unique primary key

2023-04-12 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19725 ) Change subject: IMPALA-12058: Impala throw exception for CTAS with non unique primary key .. Patch Set 2: Code-Review+2 LGTM. Carry

[Impala-ASF-CR] IMPALA-12008: Fix incorrect end time in DML profiles

2023-04-12 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19644 ) Change subject: IMPALA-12008: Fix incorrect end time in DML profiles .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-11823: Add more items to Impala web UI queries page

2023-04-18 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19417 ) Change subject: IMPALA-11823: Add more items to Impala web UI queries page .. Patch Set 11: Any reason not to serve the tables in

[Impala-ASF-CR] IMPALA-12090: Split runtime profiles made by single node perf run.py

2023-04-24 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19796 Change subject: IMPALA-12090: Split runtime profiles made by single_node_perf_run.py .. IMPALA-12090: Split runtime profiles made by

[Impala-ASF-CR] IMPALA-12090: Split runtime profiles made by single node perf run.py

2023-04-24 Thread Riza Suminto (Code Review)
Hello Zoltan Borok-Nagy, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19796 to look at the new patch set (#2). Change subject: IMPALA-12090: Split runtime profiles made by single_node_perf_run.py

[Impala-ASF-CR] IMPALA-12090: Split runtime profiles made by single node perf run.py

2023-04-24 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19796 ) Change subject: IMPALA-12090: Split runtime profiles made by single_node_perf_run.py .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-12090: Split runtime profiles made by single node perf run.py

2023-04-24 Thread Riza Suminto (Code Review)
Hello Zoltan Borok-Nagy, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19796 to look at the new patch set (#3). Change subject: IMPALA-12090: Split runtime profiles made by single_node_perf_run.py

[Impala-ASF-CR] IMPALA-12090: Split runtime profiles made by single node perf run.py

2023-04-24 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19796 ) Change subject: IMPALA-12090: Split runtime profiles made by single_node_perf_run.py .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-12090: Split runtime profiles made by single node perf run.py

2023-04-25 Thread Riza Suminto (Code Review)
Hello Zoltan Borok-Nagy, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19796 to look at the new patch set (#4). Change subject: IMPALA-12090: Split runtime profiles made by single_node_perf_run.py

[Impala-ASF-CR] IMPALA-12090: Split runtime profiles made by single node perf run.py

2023-04-25 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19796 ) Change subject: IMPALA-12090: Split runtime profiles made by single_node_perf_run.py .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-12091: Control scan parallelism by its processing cost

2023-04-26 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19807 ) Change subject: IMPALA-12091: Control scan parallelism by its processing cost .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-12091: Control scan parallelism by its processing cost

2023-04-28 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19807 ) Change subject: IMPALA-12091: Control scan parallelism by its processing cost .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-12091: Control scan parallelism by its processing cost

2023-04-25 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19807 Change subject: IMPALA-12091: Control scan parallelism by its processing cost .. IMPALA-12091: Control scan parallelism by its

[Impala-ASF-CR] IMPALA-12106: Fix overparallelization of Union fragment by 1

2023-04-28 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19816 Change subject: IMPALA-12106: Fix overparallelization of Union fragment by 1 .. IMPALA-12106: Fix overparallelization of Union fragment

[Impala-ASF-CR] IMPALA-12106: Fix overparallelization of Union fragment by 1

2023-05-01 Thread Riza Suminto (Code Review)
Hello Csaba Ringhofer, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19816 to look at the new patch set (#2). Change subject: IMPALA-12106: Fix overparallelization of Union fragment by 1

[Impala-ASF-CR] IMPALA-12110: Create Kudu table in CTAS without specifying primary key

2023-05-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19825 ) Change subject: IMPALA-12110: Create Kudu table in CTAS without specifying primary key .. Patch Set 2: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-12091: Control scan parallelism by its processing cost

2023-05-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19807 ) Change subject: IMPALA-12091: Control scan parallelism by its processing cost .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-12091: Control scan parallelism by its processing cost

2023-05-01 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Kurt Deschler, Csaba Ringhofer, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19807 to look at the new patch set (#3). Change subject: IMPALA-12091: Control scan parallelism by its processing cost

[Impala-ASF-CR] IMPALA-12106: Fix overparallelization of Union fragment by 1

2023-05-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19816 ) Change subject: IMPALA-12106: Fix overparallelization of Union fragment by 1 .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-12091: Control scan parallelism by its processing cost

2023-04-30 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Kurt Deschler, Csaba Ringhofer, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19807 to look at the new patch set (#2). Change subject: IMPALA-12091: Control scan parallelism by its processing cost

[Impala-ASF-CR] IMPALA-12091: Control scan parallelism by its processing cost

2023-04-30 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19807 ) Change subject: IMPALA-12091: Control scan parallelism by its processing cost .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-12110: Create Kudu table in CTAS without specifying primary key

2023-05-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19825 ) Change subject: IMPALA-12110: Create Kudu table in CTAS without specifying primary key .. Patch Set 2: Code-Review+2 Test coverage

<    4   5   6   7   8   9   10   11   12   13   >