[Impala-ASF-CR] IMPALA-11871: Skip permissions loading and check on HDFS if Ranger is enabled

2024-04-12 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20221 ) Change subject: IMPALA-11871: Skip permissions loading and check on HDFS if Ranger is enabled .. Patch Set 11: I revised the commit

[Impala-ASF-CR] IMPALA-11871: Skip permissions loading and check on HDFS if Ranger is enabled

2024-04-12 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has uploaded a new patch set (#11) to the change originally created by Halim Kim. ( http://gerrit.cloudera.org:8080/20221 ) Change subject: IMPALA-11871: Skip permissions loading and check on HDFS if Ranger is enabled

[Impala-ASF-CR] IMPALA-11871: Skip permissions check on HDFS files if Ranger is enabled

2024-04-10 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20221 ) Change subject: IMPALA-11871: Skip permissions check on HDFS files if Ranger is enabled .. Patch Set 10: I slightly revised the patch

[Impala-ASF-CR] IMPALA-11871: Skip permissions check on HDFS files if Ranger is enabled

2024-04-10 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has uploaded a new patch set (#10) to the change originally created by Halim Kim. ( http://gerrit.cloudera.org:8080/20221 ) Change subject: IMPALA-11871: Skip permissions check on HDFS files if Ranger is enabled ..

[Impala-ASF-CR] IMPALA-12921: Support locally built Ranger

2024-04-10 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/21160 ) Change subject: IMPALA-12921: Support locally built Ranger .. Patch Set 7: Hi all, please let me know if you have any comment on this

[Impala-ASF-CR] IMPALA-12921: Support locally built Ranger

2024-04-10 Thread Fang-Yu Rao (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21160 to look at the new patch set (#7). Change subject: IMPALA-12921: Support locally built Ranger ..

[Impala-ASF-CR] IMPALA-12921: Support locally built Ranger

2024-04-10 Thread Fang-Yu Rao (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21160 to look at the new patch set (#6). Change subject: IMPALA-12921: Support locally built Ranger ..

[Impala-ASF-CR] IMPALA-12921: Support locally built Ranger

2024-04-09 Thread Fang-Yu Rao (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21160 to look at the new patch set (#5). Change subject: IMPALA-12921: Support locally built Ranger ..

[Impala-ASF-CR] IMPALA-12921: [WIP] Support locally built Ranger

2024-04-08 Thread Fang-Yu Rao (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21160 to look at the new patch set (#4). Change subject: IMPALA-12921: [WIP] Support locally built Ranger ..

[Impala-ASF-CR] IMPALA-12921: [WIP] Support locally built Ranger

2024-04-05 Thread Fang-Yu Rao (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21160 to look at the new patch set (#3). Change subject: IMPALA-12921: [WIP] Support locally built Ranger ..

[Impala-ASF-CR] IMPALA-12291 impala checks hdfs ranger policy

2024-04-05 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20221 ) Change subject: IMPALA-12291 impala checks hdfs ranger policy .. Patch Set 9: Hi all, based on our discussion so far, there are 2

[Impala-ASF-CR] IMPALA-12291 impala checks hdfs ranger policy

2024-04-03 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20221 ) Change subject: IMPALA-12291 impala checks hdfs ranger policy .. Patch Set 9: (2 comments) Thanks for the reply Halim! Other than

[Impala-ASF-CR] IMPALA-12291 impala checks hdfs ranger policy

2024-04-02 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20221 ) Change subject: IMPALA-12291 impala checks hdfs ranger policy .. Patch Set 9: (2 comments) Thanks for the help Halim! I left some

[Impala-ASF-CR] IMPALA-12921: [WIP] Support locally built Ranger

2024-03-25 Thread Fang-Yu Rao (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21160 to look at the new patch set (#2). Change subject: IMPALA-12921: [WIP] Support locally built Ranger ..

[Impala-ASF-CR] IMPALA-12921: [WIP] Support locally built Ranger

2024-03-18 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21160 Change subject: IMPALA-12921: [WIP] Support locally built Ranger .. IMPALA-12921: [WIP] Support locally built Ranger This patch adds the

[Impala-ASF-CR] IMPALA-12805: Avoid problems of HIVE-27114 without configuration changes

2024-02-10 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/21028 ) Change subject: IMPALA-12805: Avoid problems of HIVE-27114 without configuration changes .. Patch Set 1: (1 comment) Thanks for the

[Impala-ASF-CR] IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE

2024-02-07 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20916 ) Change subject: IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE .. IMPALA-12578: Pass owner user

[Impala-ASF-CR] IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE

2024-02-07 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20916 ) Change subject: IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE .. Patch Set 6: I have addressed Csaba's

[Impala-ASF-CR] IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE

2024-02-07 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20916 ) Change subject: IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE .. Patch Set 6: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE

2024-02-07 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20916 ) Change subject: IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE .. Patch Set 6: I fixed an indentation

[Impala-ASF-CR] IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE

2024-02-07 Thread Fang-Yu Rao (Code Review)
Hello Quanlong Huang, Aman Sinha, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20916 to look at the new patch set (#6). Change subject: IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE

[Impala-ASF-CR] IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE

2024-02-07 Thread Fang-Yu Rao (Code Review)
Hello Quanlong Huang, Aman Sinha, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20916 to look at the new patch set (#5). Change subject: IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE

[Impala-ASF-CR] IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE

2024-02-06 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20916 ) Change subject: IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE .. Patch Set 4: (1 comment) Hi all, I

[Impala-ASF-CR] IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE

2024-02-06 Thread Fang-Yu Rao (Code Review)
Hello Quanlong Huang, Aman Sinha, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20916 to look at the new patch set (#4). Change subject: IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE

[Impala-ASF-CR] IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE

2024-02-05 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20916 ) Change subject: IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE .. Patch Set 3: (2 comments) Hi all, I

[Impala-ASF-CR] IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE

2024-02-05 Thread Fang-Yu Rao (Code Review)
Hello Quanlong Huang, Aman Sinha, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20916 to look at the new patch set (#3). Change subject: IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE

[Impala-ASF-CR] IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE

2024-01-29 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20916 ) Change subject: IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE .. Patch Set 2: (6 comments) Hi all, I

[Impala-ASF-CR] IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE

2024-01-29 Thread Fang-Yu Rao (Code Review)
Hello Quanlong Huang, Aman Sinha, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20916 to look at the new patch set (#2). Change subject: IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE

[Impala-ASF-CR] IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE

2024-01-17 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20916 ) Change subject: IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE .. Patch Set 1: Hi all, please let me

[Impala-ASF-CR] IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE

2024-01-17 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20916 Change subject: IMPALA-12578: Pass owner user of database and table to Ranger in GRANT/REVOKE .. IMPALA-12578: Pass owner user of

[Impala-ASF-CR] IMPALA-11553: Add event specific metrics in the table metrics

2023-12-22 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20473 ) Change subject: IMPALA-11553: Add event specific metrics in the table metrics .. Patch Set 10: The patch failed the same test again:

[Impala-ASF-CR] IMPALA-11553: Add event specific metrics in the table metrics

2023-12-22 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20473 ) Change subject: IMPALA-11553: Add event specific metrics in the table metrics .. Patch Set 10: Saw the following in the failed Jenkins

[Impala-ASF-CR] IMPALA-11501: Add flag to allow catalog-cache operations on masked tables

2023-12-13 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20742 ) Change subject: IMPALA-11501: Add flag to allow catalog-cache operations on masked tables .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-11501: Add flag to allow catalog-cache operations on masked tables

2023-12-11 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20742 ) Change subject: IMPALA-11501: Add flag to allow catalog-cache operations on masked tables .. Patch Set 3: (1 comment) Thanks for

[Impala-ASF-CR] IMPALA-11501: Add flag to allow catalog-cache operations on masked tables

2023-12-10 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20742 ) Change subject: IMPALA-11501: Add flag to allow catalog-cache operations on masked tables .. Patch Set 2: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-12398: Fix Ranger role not exists when altering db/table/view owner to a role

2023-12-10 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20508 ) Change subject: IMPALA-12398: Fix Ranger role not exists when altering db/table/view owner to a role .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-11501: Add flag to allow catalog-cache operations on masked tables

2023-12-06 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20742 ) Change subject: IMPALA-11501: Add flag to allow catalog-cache operations on masked tables .. Patch Set 2: (3 comments) > Patch Set 2:

[Impala-ASF-CR] IMPALA-3268: Add support for SHOW VIEWS statement

2023-12-05 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20669 ) Change subject: IMPALA-3268: Add support for SHOW VIEWS statement .. Patch Set 11: (1 comment) Hi all, I have slightly revised the

[Impala-ASF-CR] IMPALA-3268: Add support for SHOW VIEWS statement

2023-12-05 Thread Fang-Yu Rao (Code Review)
Hello Quanlong Huang, Aman Sinha, Sai Hemanth Gantasala, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20669 to look at the new patch set (#11). Change subject: IMPALA-3268: Add support for SHOW VIEWS statement

[Impala-ASF-CR] IMPALA-11501: Add flag to allow catalog-cache operations on masked tables

2023-12-03 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20742 ) Change subject: IMPALA-11501: Add flag to allow catalog-cache operations on masked tables .. Patch Set 1: (5 comments) Thanks for the

[Impala-ASF-CR] IMPALA-3268: Add support for SHOW VIEWS statement

2023-11-30 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20669 ) Change subject: IMPALA-3268: Add support for SHOW VIEWS statement .. Patch Set 10: (2 comments) Thanks for the suggestions Quanlong! I

[Impala-ASF-CR] IMPALA-3268: Add support for SHOW VIEWS statement

2023-11-30 Thread Fang-Yu Rao (Code Review)
Hello Quanlong Huang, Aman Sinha, Sai Hemanth Gantasala, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20669 to look at the new patch set (#10). Change subject: IMPALA-3268: Add support for SHOW VIEWS statement

[Impala-ASF-CR] IMPALA-3268: Add support for SHOW VIEWS statement

2023-11-29 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20669 ) Change subject: IMPALA-3268: Add support for SHOW VIEWS statement .. Patch Set 9: (1 comment) I slightly revised the commit message of

[Impala-ASF-CR] IMPALA-3268: Add support for SHOW VIEWS statement

2023-11-29 Thread Fang-Yu Rao (Code Review)
Hello Quanlong Huang, Aman Sinha, Sai Hemanth Gantasala, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20669 to look at the new patch set (#9). Change subject: IMPALA-3268: Add support for SHOW VIEWS statement

[Impala-ASF-CR] IMPALA-3268: Add support for SHOW VIEWS statement

2023-11-28 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20669 ) Change subject: IMPALA-3268: Add support for SHOW VIEWS statement .. Patch Set 8: (4 comments) Hi all, in the patch set 8 I have

[Impala-ASF-CR] IMPALA-3268: Add support for SHOW VIEWS statement

2023-11-28 Thread Fang-Yu Rao (Code Review)
Hello Quanlong Huang, Aman Sinha, Sai Hemanth Gantasala, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20669 to look at the new patch set (#8). Change subject: IMPALA-3268: Add support for SHOW VIEWS statement

[Impala-ASF-CR] IMPALA-3268: Add support for SHOW VIEWS statement

2023-11-27 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20669 ) Change subject: IMPALA-3268: Add support for SHOW VIEWS statement .. Patch Set 7: (10 comments) Hi all, I have revised the patch set 6

[Impala-ASF-CR] IMPALA-3268: Add support for SHOW VIEWS statement

2023-11-27 Thread Fang-Yu Rao (Code Review)
Hello Quanlong Huang, Aman Sinha, Sai Hemanth Gantasala, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20669 to look at the new patch set (#7). Change subject: IMPALA-3268: Add support for SHOW VIEWS statement

[Impala-ASF-CR] IMPALA-3268: Add support for SHOW VIEWS statement

2023-11-23 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20669 ) Change subject: IMPALA-3268: Add support for SHOW VIEWS statement .. Patch Set 6: (3 comments) Hi all, I slightly revised the patch

[Impala-ASF-CR] IMPALA-3268: Add support for SHOW VIEWS statement

2023-11-23 Thread Fang-Yu Rao (Code Review)
Hello Quanlong Huang, Aman Sinha, Sai Hemanth Gantasala, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20669 to look at the new patch set (#6). Change subject: IMPALA-3268: Add support for SHOW VIEWS statement

[Impala-ASF-CR] IMPALA-3268: Add support for SHOW VIEWS statement

2023-11-17 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20669 ) Change subject: IMPALA-3268: Add support for SHOW VIEWS statement .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-3268: Add support for SHOW VIEWS statement

2023-11-17 Thread Fang-Yu Rao (Code Review)
Hello Quanlong Huang, Aman Sinha, Sai Hemanth Gantasala, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20669 to look at the new patch set (#5). Change subject: IMPALA-3268: Add support for SHOW VIEWS statement

[Impala-ASF-CR] IMPALA-3268: Add support for SHOW VIEWS statement

2023-11-17 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20669 ) Change subject: IMPALA-3268: Add support for SHOW VIEWS statement .. Patch Set 4: Hi all, I just revised the patch set 3 based on the

[Impala-ASF-CR] IMPALA-3268: Add support for SHOW VIEWS statement

2023-11-17 Thread Fang-Yu Rao (Code Review)
Hello Quanlong Huang, Aman Sinha, Sai Hemanth Gantasala, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20669 to look at the new patch set (#4). Change subject: IMPALA-3268: Add support for SHOW VIEWS statement

[Impala-ASF-CR] IMPALA-12398: Fix Ranger role not exists when altering db/table/view owner to a role

2023-11-16 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20508 ) Change subject: IMPALA-12398: Fix Ranger role not exists when altering db/table/view owner to a role .. Patch Set 7: Code-Review+1 (3

[Impala-ASF-CR] IMPALA-3268: Add support for SHOW VIEWS statement

2023-11-15 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20669 ) Change subject: IMPALA-3268: Add support for SHOW VIEWS statement .. Patch Set 3: (4 comments) Hi all, I have addressed Quanlong's

[Impala-ASF-CR] IMPALA-3268: Add support for SHOW VIEWS statement

2023-11-15 Thread Fang-Yu Rao (Code Review)
Hello Quanlong Huang, Aman Sinha, Sai Hemanth Gantasala, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20669 to look at the new patch set (#3). Change subject: IMPALA-3268: Add support for SHOW VIEWS statement

[Impala-ASF-CR] IMPALA-3268: Add support for SHOW VIEWS statement

2023-11-08 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20669 ) Change subject: IMPALA-3268: Add support for SHOW VIEWS statement .. Patch Set 2: Hi all, please let me know if you have any comment on

[Impala-ASF-CR] IMPALA-3268: Add support for SHOW VIEWS statement

2023-11-08 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20669 ) Change subject: IMPALA-3268: Add support for SHOW VIEWS statement .. Patch Set 2: > Patch Set 1: > > (1 comment) Thanks Michael! I

[Impala-ASF-CR] IMPALA-3268: Add support for SHOW VIEWS statement

2023-11-08 Thread Fang-Yu Rao (Code Review)
Hello Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20669 to look at the new patch set (#2). Change subject: IMPALA-3268: Add support for SHOW VIEWS statement

[Impala-ASF-CR] [WIP] IMPALA-3268: Add support for SHOW VIEWS statement

2023-11-06 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20669 Change subject: [WIP] IMPALA-3268: Add support for SHOW VIEWS statement .. [WIP] IMPALA-3268: Add support for SHOW VIEWS statement

[Impala-ASF-CR] IMPALA-12398: Ranger role not exists when altering db/table/view owner to a role

2023-10-11 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20508 ) Change subject: IMPALA-12398: Ranger role not exists when altering db/table/view owner to a role .. Patch Set 3: (4 comments) Thanks

[Impala-ASF-CR] IMPALA-12398: Ranger role not exists when altering db/table/view owner to a role

2023-09-27 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20508 ) Change subject: IMPALA-12398: Ranger role not exists when altering db/table/view owner to a role .. Patch Set 3: (6 comments) Thanks

[Impala-ASF-CR] IMPALA-12383: (Addendum) Use named params

2023-09-14 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20483 ) Change subject: IMPALA-12383: (Addendum) Use named params .. Patch Set 1: Code-Review+2 Thanks Michael! I do not have any comment. --

[Impala-ASF-CR] IMPALA-12397: NullPointerException in SHOW ROLES when there are no roles

2023-09-08 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20439 ) Change subject: IMPALA-12397: NullPointerException in SHOW ROLES when there are no roles .. Patch Set 4: Code-Review+1 Thanks for

[Impala-ASF-CR] IMPALA-12397: NullPointerException in SHOW ROLES when there are no roles

2023-09-06 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20439 ) Change subject: IMPALA-12397: NullPointerException in SHOW ROLES when there are no roles .. Patch Set 3: (4 comments) Thanks for the

[Impala-ASF-CR] IMPALA-12311: Remove extra newlines in the updated golden file

2023-08-02 Thread Fang-Yu Rao (Code Review)
Hello Riza Suminto, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20272 to look at the new patch set (#2). Change subject: IMPALA-12311: Remove extra newlines in the updated golden file

[Impala-ASF-CR] IMPALA-12311: Do not add a trailing newline when updating a golden file

2023-07-27 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20272 ) Change subject: IMPALA-12311: Do not add a trailing newline when updating a golden file .. Patch Set 1: (1 comment) > Patch Set 1: >

[Impala-ASF-CR] IMPALA-12311: Do not add a trailing newline when updating a golden file

2023-07-26 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20272 Change subject: IMPALA-12311: Do not add a trailing newline when updating a golden file .. IMPALA-12311: Do not add a trailing newline

[Impala-ASF-CR] IMPALA-12256: Fix DDLs losing create event ids in reloading partitions

2023-07-09 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20145 ) Change subject: IMPALA-12256: Fix DDLs losing create event ids in reloading partitions .. Patch Set 6: (1 comment) Thanks for the

[Impala-ASF-CR] IMPALA-12256: Fix DDLs losing create event ids in reloading partitions

2023-07-07 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20145 ) Change subject: IMPALA-12256: Fix DDLs losing create event ids in reloading partitions .. Patch Set 6: (1 comment) Sorry I have

[Impala-ASF-CR] IMPALA-12256: Fix DDLs losing create event ids in reloading partitions

2023-07-03 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20145 ) Change subject: IMPALA-12256: Fix DDLs losing create event ids in reloading partitions .. Patch Set 6: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-12256: Fix DDLs losing partition-level create event ids in reloads

2023-07-01 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20145 ) Change subject: IMPALA-12256: Fix DDLs losing partition-level create event ids in reloads .. Patch Set 4: Code-Review+1 (3 comments)

[Impala-ASF-CR] IMPALA-12248: Add three configuration properties after RANGER-2895

2023-06-27 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20129 ) Change subject: IMPALA-12248: Add three configuration properties after RANGER-2895 .. Patch Set 2: (1 comment) > Patch Set 1: > > (1

[Impala-ASF-CR] IMPALA-12248: Add three configuration properties after RANGER-2895

2023-06-27 Thread Fang-Yu Rao (Code Review)
Hello Riza Suminto, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20129 to look at the new patch set (#2). Change subject: IMPALA-12248: Add three configuration properties after RANGER-2895

[Impala-ASF-CR] IMPALA-12248: Add missing configuration properties after RANGER-2895

2023-06-27 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20129 Change subject: IMPALA-12248: Add missing configuration properties after RANGER-2895 .. IMPALA-12248: Add missing configuration

[Impala-ASF-CR] IMPALA-11912: Inline base::IsAarch64

2023-02-12 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19492 ) Change subject: IMPALA-11912: Inline base::IsAarch64 .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-11845: Fix incorrect check of struct STAR path in resolvePathWithMasking

2023-01-29 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19429 ) Change subject: IMPALA-11845: Fix incorrect check of struct STAR path in resolvePathWithMasking .. Patch Set 6: Code-Review+1 Thanks

[Impala-ASF-CR] IMPALA-11845: Fix incorrect check of struct STAR path in resolvePathWithMasking

2023-01-22 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19429 ) Change subject: IMPALA-11845: Fix incorrect check of struct STAR path in resolvePathWithMasking .. Patch Set 5: (2 comments) Thanks

[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests

2023-01-15 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. Patch Set 9: Thanks for the +2 Qifan! Does anyone else

[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests

2023-01-06 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests

2023-01-06 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. Patch Set 9: (1 comment) > Patch Set 7: > > (1 comment)

[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests

2023-01-06 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. Patch Set 9: (44 comments) I have fixed all the

[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests

2023-01-06 Thread Fang-Yu Rao (Code Review)
Hello Quanlong Huang, Qifan Chen, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19394 to look at the new patch set (#9). Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests

[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests

2023-01-06 Thread Fang-Yu Rao (Code Review)
Hello Quanlong Huang, Qifan Chen, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19394 to look at the new patch set (#8). Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests

[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests

2023-01-03 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. Patch Set 7: (1 comment) Thanks for the review Qifan! Let

[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests

2023-01-03 Thread Fang-Yu Rao (Code Review)
Hello Quanlong Huang, Qifan Chen, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19394 to look at the new patch set (#7). Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests

[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests

2023-01-03 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. Patch Set 6: Hi all, please let me know if there is any

[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests

2023-01-02 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19394 ) Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests

2023-01-02 Thread Fang-Yu Rao (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19394 to look at the new patch set (#6). Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests

[Impala-ASF-CR] IMPALA-10986 (Addendum): Add and refactor some E2E tests

2023-01-02 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19394 Change subject: IMPALA-10986 (Addendum): Add and refactor some E2E tests .. IMPALA-10986 (Addendum): Add and refactor some E2E tests

[Impala-ASF-CR] IMPALA-7942 (part 1): Add query hints for table cardinalities

2022-12-26 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18829 ) Change subject: IMPALA-7942 (part 1): Add query hints for table cardinalities .. Patch Set 10: > Patch Set 10: > > > Hi Quanlong, I

[Impala-ASF-CR] IMPALA-10399, IMPALA-11060, IMPALA-11788: Reset Ranger policy repository in an E2E test

2022-12-26 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19373 ) Change subject: IMPALA-10399, IMPALA-11060, IMPALA-11788: Reset Ranger policy repository in an E2E test .. Patch Set 5: Thanks for the

[Impala-ASF-CR] IMPALA-10399, IMPALA-11060, IMPALA-11788: Reset Ranger policy repository in an E2E test

2022-12-26 Thread Fang-Yu Rao (Code Review)
Hello Quanlong Huang, Andrew Sherman, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19373 to look at the new patch set (#5). Change subject: IMPALA-10399, IMPALA-11060, IMPALA-11788: Reset Ranger

[Impala-ASF-CR] IMPALA-10399, IMPALA-11060, IMPALA-11788: Reset Ranger policy repository in an E2E test

2022-12-21 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19373 ) Change subject: IMPALA-10399, IMPALA-11060, IMPALA-11788: Reset Ranger policy repository in an E2E test .. Patch Set 4: Only the

[Impala-ASF-CR] IMPALA-10399, IMPALA-11060, IMPALA-11788: Reset Ranger policy repository in an E2E test

2022-12-21 Thread Fang-Yu Rao (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19373 to look at the new patch set (#4). Change subject: IMPALA-10399, IMPALA-11060, IMPALA-11788: Reset Ranger policy repository

[Impala-ASF-CR] IMPALA-10399, IMPALA-11060, IMPALA-11788: Reset Ranger policy repository in an E2E test

2022-12-20 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19373 ) Change subject: IMPALA-10399, IMPALA-11060, IMPALA-11788: Reset Ranger policy repository in an E2E test .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-10399, IMPALA-11060, IMPALA-11788: Reset Ranger policy repository in an E2E test

2022-12-20 Thread Fang-Yu Rao (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19373 to look at the new patch set (#3). Change subject: IMPALA-10399, IMPALA-11060, IMPALA-11788: Reset Ranger policy repository

[Impala-ASF-CR] IMPALA-10399, IMPALA-11788: Reset Ranger policy repository in an E2E test

2022-12-18 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19373 ) Change subject: IMPALA-10399, IMPALA-11788: Reset Ranger policy repository in an E2E test .. Patch Set 2: Hi all, please let me know

[Impala-ASF-CR] IMPALA-10399, IMPALA-11788: Reset Ranger policy repository in an E2E test

2022-12-18 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19373 Change subject: IMPALA-10399, IMPALA-11788: Reset Ranger policy repository in an E2E test .. IMPALA-10399, IMPALA-11788: Reset Ranger

  1   2   3   4   5   6   >