[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5500: Reduce catalog update topic size .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/7268/5/be/src/catalog/catalog-server.cc F

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5500: Reduce catalog update topic size .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/7268/5/be/src/catalog/catalog-server.cc F

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5500: Reduce catalog update topic size .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7268/5/be/src/catalog/catalog-server.cc Fi

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#5). Change subject: IMPALA-5500: Reduce catalog update topic size .. IMPALA-5500: Reduce catalog update topic size Problem: IMPALA-4029 introduced the use of the flatbuffers s

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5500: Reduce catalog update topic size .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7268/4/be/src/catalog/catalog-server.cc Fi

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#4). Change subject: IMPALA-5500: Reduce catalog update topic size .. IMPALA-5500: Reduce catalog update topic size Problem: IMPALA-4029 introduced the use of the flatbuffers s

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5500: Reduce catalog update topic size .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/7268/3/be/src/catalog/catalog-server.cc F

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5500: Reduce catalog update topic size .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/7268/2/be/src/catalog/catalog-server.cc F

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-5500: Reduce catalog update topic size .. IMPALA-5500: Reduce catalog update topic size Problem: IMPALA-4029 introduced the use of the flatbuffers s

[Impala-ASF-CR] IMPALA-5571: Fix authorization tests

2017-06-26 Thread Dimitris Tsirogiannis (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7299 to look at the new patch set (#2). Change subject: IMPALA-5571: Fix authorization tests .. IMPALA-5571: Fix authorizat

[Impala-ASF-CR] IMPALA-5571: Fix authorization tests

2017-06-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5571: Fix authorization tests .. Patch Set 2: Code-Review+2 Rebase. Keep Alex's +2 -- To view, visit http://gerrit.cloudera.org:8080/7299 To uns

[Impala-ASF-CR] IMPALA-5571: Fix authorization tests

2017-06-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5571: Fix authorization tests .. Patch Set 1: It's not clear to me yet. I am just posting this to unblock the builds. I need to investigate this

[Impala-ASF-CR] IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change

2017-06-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change .. Patch Set 3: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/7236/3

[Impala-ASF-CR] IMPALA-5431: Remove redundant path exists checks during table load

2017-06-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5431: Remove redundant path exists checks during table load .. Patch Set 6: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/7095/

[Impala-ASF-CR] IMPALA-5579: Fix IndexOutOfBoundsException in GetTables metadata request

2017-06-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5579: Fix IndexOutOfBoundsException in GetTables metadata request .. Patch Set 2: Code-Review+2 Rebase and keep Alex's +2 -- To view, visit htt

[Impala-ASF-CR] IMPALA-5571: Fix authorization tests

2017-06-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/7299 Change subject: IMPALA-5571: Fix authorization tests .. IMPALA-5571: Fix authorization tests Issue: With the fix for IMPALA-5549

[Impala-ASF-CR] IMPALA-5579: Fix IndexOutOfBoundsException in GetTables metadata request

2017-06-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/7296 Change subject: IMPALA-5579: Fix IndexOutOfBoundsException in GetTables metadata request .. IMPALA-5579: Fix IndexOutOfBoundsExc

[Impala-ASF-CR] IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change

2017-06-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7236/2/docs/topics/im

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 6: Maybe the associated JIRA is a better place to have this discussion, but I am trying to

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-5500: Reduce catalog update topic size .. IMPALA-5500: Reduce catalog update topic size Problem: IMPALA-4029 introduced the use of the flatbuffers s

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/7268 Change subject: IMPALA-5500: Reduce catalog update topic size .. IMPALA-5500: Reduce catalog update topic size Problem: IMPALA-4

[Impala-ASF-CR] IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes

2017-06-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes .. Patch Set 2: Code-Review+2 (3 comments) Much better, thanks. http://gerrit.c

[Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API

2017-06-21 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API .. Patch Set 3: Code-Review+2 Rebased. Keep Alex's +2 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API

2017-06-21 Thread Dimitris Tsirogiannis (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7248 to look at the new patch set (#2). Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API ...

[Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API

2017-06-21 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7248/1/fe/src/main/java/or

[Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API

2017-06-21 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API .. Patch Set 1: > IIRC, this was introduced because the permanent UDF changes broke > some

[Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API

2017-06-21 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/7248 Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API .. IMPALA-5549: Remove deprecated fields from Catal

[Impala-ASF-CR] IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes

2017-06-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5503: [DOCS] Document how to specify coordinator/executor nodes .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7237/1/docs/top

[Impala-ASF-CR] IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change

2017-06-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7236/1/docs/topics/i

[Impala-ASF-CR] IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change

2017-06-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change .. Patch Set 1: > I included a link to IMPALA-4029 in the description of the known >

[Impala-ASF-CR] IMPALA-5495: Improve error message if no impalad role is configured

2017-06-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5495: Improve error message if no impalad role is configured .. Patch Set 2: Code-Review+2 Thanks for fixing this :) -- To view, visit http://g

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 13: Code-Review+2 Fix another clang-tidy madness... -- To view, visit h

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-09 Thread Dimitris Tsirogiannis (Code Review)
Hello Impala Public Jenkins, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7064 to look at the new patch set (#13). Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary ..

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 12: Code-Review+2 Fix more clang-tidy issue. Keep Dan's +2 -- To view,

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-09 Thread Dimitris Tsirogiannis (Code Review)
Hello Impala Public Jenkins, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7064 to look at the new patch set (#12). Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary ..

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 11: Code-Review+2 Fix minor issue that caused clang-tidy to complain. Kee

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-08 Thread Dimitris Tsirogiannis (Code Review)
Hello Impala Public Jenkins, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7064 to look at the new patch set (#11). Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary ..

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 10: (2 comments) Thanks for pointing these out. http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-5469: Fix exception when processing catalog update

2017-06-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5469: Fix exception when processing catalog update .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7121 To unsubs

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 10: Code-Review+2 Fixed minor test issue, keep Dan's +2 -- To view, vis

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-08 Thread Dimitris Tsirogiannis (Code Review)
Hello Impala Public Jenkins, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7064 to look at the new patch set (#10). Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary ..

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7064

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 8: Code-Review+2 Rebase and keep Dan's +2 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-08 Thread Dimitris Tsirogiannis (Code Review)
Hello Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7064 to look at the new patch set (#9). Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary ..

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/7064/8/be/src/servic

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/7064/7/be/src/servic

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-07 Thread Dimitris Tsirogiannis (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7064 to look at the new patch set (#8). Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 7: (2 comments) I am just answering two questions that Dan had. Let me k

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-07 Thread Dimitris Tsirogiannis (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7064 to look at the new patch set (#7). Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/7064/6/fe/src/main/ja

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 6: (1 comment) Found a bug. Plz wait until I post a new patch before sta

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#6). Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. IMPALA-4965: Authorize access to runtime profile and exec summary Bug: When Sentry-ba

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/7064/4/be/src/servic

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#5). Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. IMPALA-4965: Authorize access to runtime profile and exec summary Bug: When Sentry-ba

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/7064/1/tests/authori

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 4: Missed the comments in the test file. Sending a new patch in a while.

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/7064/3/be/src/servic

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#4). Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. IMPALA-4965: Authorize access to runtime profile and exec summary Bug: When Sentry-ba

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 5: Many of these changes are essentially needed just for generating consistent tests result

[Impala-ASF-CR] IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading

2017-06-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading .. Patch Set 4: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-5431: Remove redundant path exists check during table load

2017-06-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5431: Remove redundant path exists check during table load .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7095/1/

[Impala-ASF-CR] IMPALA-5355: Fix the order of Sentry roles and privileges

2017-06-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5355: Fix the order of Sentry roles and privileges .. Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/7004/4//COMMIT_

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. IMPALA-4965: Authorize access to runtime profile and exec summary Bug: When Sentry-ba

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. IMPALA-4965: Authorize access to runtime profile and exec summary Bug: When Sentry-ba

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 1: (12 comments) http://gerrit.cloudera.org:8080/#/c/7064/1/be/src/servi

[Impala-ASF-CR] IMPALA-5420: Skip ACL fetch if the acl bit is not set.

2017-06-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5420: Skip ACL fetch if the acl bit is not set. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7071 To unsubscri

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 1: The description in the JIRA asks for a redacted profile. I pinged the

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/7064 Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. IMPALA-4965: Authorize access to runtime pr

[Impala-ASF-CR] IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading

2017-06-01 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading

2017-06-01 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading .. Patch Set 1: Code-Review+2 (1 comment) Thanks. Not sure if I am technically

[Impala-ASF-CR] IMPALA-5355: Fix the order of Sentry roles and privileges

2017-05-30 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5355: Fix the order of Sentry roles and privileges .. Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/7004/1/fe/src/main/java/org/a

[Impala-ASF-CR] IMPALA-2373: Extrapolate row counts for HDFS tables.

2017-05-24 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2373: Extrapolate row counts for HDFS tables. .. Patch Set 8: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/6840/6//COMMIT_MSG C

[Impala-ASF-CR] IMPALA-5325: Do not update totalHdfsBytes /numHdfsFiles on Catalogd

2017-05-24 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5325: Do not update totalHdfsBytes_/numHdfsFiles_ on Catalogd .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/69

[Impala-ASF-CR] IMPALA-5333: Add support for Impala to work with ADLS

2017-05-24 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5333: Add support for Impala to work with ADLS .. Patch Set 6: Code-Review+2 Thanks Sailesh for the explanation. -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-5259: Add REFRESH FUNCTIONS statement

2017-05-24 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5259: Add REFRESH FUNCTIONS statement .. Patch Set 10: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6878/9/fe/src/main/java/org

[Impala-ASF-CR] IMPALA-5333: Add support for Impala to work with ADLS

2017-05-24 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5333: Add support for Impala to work with ADLS .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/6910/5/fe/src/main/java/org/apach

[Impala-ASF-CR] IMPALA-5325: Do not update totalHdfsBytes /numHdfsFiles on Catalogd

2017-05-24 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5325: Do not update totalHdfsBytes_/numHdfsFiles_ on Catalogd .. Patch Set 3: (1 comment) I wouldn't worry about the supportability aspect. I am

[Impala-ASF-CR] IMPALA-5259: Add REFRESH FUNCTIONS statement

2017-05-24 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5259: Add REFRESH FUNCTIONS statement .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/6878/9/fe/src/main/java/org/apache/impala/

[Impala-ASF-CR] IMPALA-5259: Add REFRESH FUNCTIONS statement

2017-05-23 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5259: Add REFRESH FUNCTIONS statement .. Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/6878/9/fe/src/main/java/org/apache/impala

[Impala-ASF-CR] IMPALA-5342: Add comments of loaded tables in the response of GetTables

2017-05-23 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5342: Add comments of loaded tables in the response of GetTables .. Patch Set 3: Code-Review+2 Rebase, keep Alex's +2 -- To view, visit http://

[Impala-ASF-CR] IMPALA-2373: Extrapolate row counts for HDFS tables.

2017-05-23 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2373: Extrapolate row counts for HDFS tables. .. Patch Set 4: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/6840/4/fe/src/main/j

[Impala-ASF-CR] IMPALA-5259: Add REFRESH FUNCTIONS statement

2017-05-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5259: Add REFRESH FUNCTIONS statement .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/6878/8/fe/src/main/java/org/apache/impala/

[Impala-ASF-CR] IMPALA-2373: Extrapolate row counts for HDFS tables.

2017-05-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2373: Extrapolate row counts for HDFS tables. .. Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/6840/2/fe/src/main/java/org/apache

[Impala-ASF-CR] IMPALA-5342: Add comments of loaded tables in the response of GetTables

2017-05-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5342: Add comments of loaded tables in the response of GetTables .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6933/1/fe/src/

[Impala-ASF-CR] IMPALA-5342: Add comments of loaded tables in the response of GetTables

2017-05-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-5342: Add comments of loaded tables in the response of GetTables .. IMPALA-5342: Add comments of loaded tables in the response of GetTables This co

[Impala-ASF-CR] IMPALA-5144: Remove sortby() hint

2017-05-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5144: Remove sortby() hint .. Patch Set 3: Lars, technically I can't +2 your patch. Ping Alex, it should be trivial to review. -- To view, visi

[Impala-ASF-CR] IMPALA-5259: Add REFRESH FUNCTIONS statement

2017-05-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5259: Add REFRESH FUNCTIONS statement .. Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/6878/4/fe/src/main/java/org/apache/impala

[Impala-ASF-CR] IMPALA-5342: Add comments of loaded tables in the response of GetTables

2017-05-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/6933 Change subject: IMPALA-5342: Add comments of loaded tables in the response of GetTables .. IMPALA-5342: Add comments of loaded t

[Impala-ASF-CR] IMPALA-5333: Add support for Impala to work with ADLS

2017-05-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5333: Add support for Impala to work with ADLS .. Patch Set 3: I have a few high level questions about this patch. This patch treats S3 and ADL t

[Impala-ASF-CR] IMPALA-5339: Fix analysis with sort.columns and expr rewrites

2017-05-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5339: Fix analysis with sort.columns and expr rewrites .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6921 To un

[Impala-ASF-CR] IMPALA-5333: Add support for Impala to work with ADLS

2017-05-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5333: Add support for Impala to work with ADLS .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6910/3/tests/metadata/test_ddl.py

[Impala-ASF-CR] IMPALA-5339: Fix analysis with sort.columns and expr rewrites

2017-05-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5339: Fix analysis with sort.columns and expr rewrites .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6921/2/testdata/workloads/

[Impala-ASF-CR] IMPALA-5333: Add support for Impala to work with ADLS

2017-05-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5333: Add support for Impala to work with ADLS .. Patch Set 2: (15 comments) Nice! Mostly formatting nits. http://gerrit.cloudera.org:8080/#/c/6

[Impala-ASF-CR] IMPALA-2373: Extrapolate row counts for HDFS tables.

2017-05-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2373: Extrapolate row counts for HDFS tables. .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/6840/2/fe/src/main/java/org/apache

[Impala-ASF-CR] IMPALA-4482, IMPALA-4838: RECOVER PARTITIONS with tpcds.store sales

2017-05-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4482, IMPALA-4838: RECOVER PARTITIONS with tpcds.store_sales .. Patch Set 8: David, plz abandon or finish this. -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-5144: Remove sortby() hint

2017-05-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5144: Remove sortby() hint .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/6885/3/fe/src/test/java/org/apache/impal

[Impala-ASF-CR] IMPALA-5144: Remove sortby() hint

2017-05-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5144: Remove sortby() hint .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6885/2/fe/src/test/java/org/apache/impala/analysis/An

[Impala-ASF-CR] IMPALA-2373: Extrapolate row counts for HDFS tables.

2017-05-12 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2373: Extrapolate row counts for HDFS tables. .. Patch Set 1: (11 comments) First pass on main classes. I haven't looked at the tests yet. http:

[Impala-ASF-CR] IMPALA-5318: Generate access events with fully qualified table names

2017-05-12 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5318: Generate access events with fully qualified table names .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6879/1/fe/src/mai

[Impala-ASF-CR] IMPALA-5318: Generate access events with fully qualified table names

2017-05-12 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-5318: Generate access events with fully qualified table names .. IMPALA-5318: Generate access events with fully qualified table names This commit f

<    1   2   3   4   5   6   >