[Impala-ASF-CR] IMPALA-992: Rerun past queries from history in shell

2017-08-22 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-992: Rerun past queries from history in shell .. Patch Set 10: (2 comments) Comments addressed. Thanks for the review. http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-992: Rerun past queries from history in shell

2017-08-22 Thread Tianyi Wang (Code Review)
Hello Lars Volker, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7674 to look at the new patch set (#10). Change subject: IMPALA-992: Rerun past queries from history in shell .

[Impala-ASF-CR] IMPALA-5573: Add decimal codegen in text scanner

2017-08-22 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5573: Add decimal codegen in text scanner .. Patch Set 8: > Were you able to figure out the problem with static linking? That is fixed. I'm looking into so

[Impala-ASF-CR] IMPALA-5573: Add decimal codegen in text scanner

2017-08-17 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5573: Add decimal codegen in text scanner .. Patch Set 8: LLVM still cannot find symbols with static linking, which I haven't tested before. -- To view,

[Impala-ASF-CR] IMPALA-5573: Add decimal codegen in text scanner

2017-08-16 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5573: Add decimal codegen in text scanner .. Patch Set 8: After these code re-spawning and inconsistency I decide to run a full test first. -- To view, v

[Impala-ASF-CR] IMPALA-4039: Increase width of Operator column in runtime profile

2017-08-16 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#3). Change subject: IMPALA-4039: Increase width of Operator column in runtime profile .. IMPALA-4039: Increase width of Operator column in runtime profile This patch changes the maximu

[Impala-ASF-CR] IMPALA-4039: Increase width of Operator column in runtime profile

2017-08-16 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-4039: Increase width of Operator column in runtime profile .. Patch Set 2: > > > Did you have a look at this comment in the JIRA? > > > > > > > Whoever i

[Impala-ASF-CR] IMPALA-4039: Increase width of Operator column in runtime profile

2017-08-16 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). Change subject: IMPALA-4039: Increase width of Operator column in runtime profile .. IMPALA-4039: Increase width of Operator column in runtime profile This patch changes the maximu

[Impala-ASF-CR] IMPALA-5573: Add decimal codegen in text scanner

2017-08-16 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5573: Add decimal codegen in text scanner .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7683/7/be/src/runtime/decimal-value.h File be/src

[Impala-ASF-CR] IMPALA-5573: Add decimal codegen in text scanner

2017-08-16 Thread Tianyi Wang (Code Review)
Hello Impala Public Jenkins, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7683 to look at the new patch set (#8). Change subject: IMPALA-5573: Add decimal codegen in text scanner

[Impala-ASF-CR] IMPALA-4039: Increase width of Operator column in runtime profile

2017-08-16 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-4039: Increase width of Operator column in runtime profile .. Patch Set 1: > Did you have a look at this comment in the JIRA? > > > Whoever implements t

[Impala-ASF-CR] IMPALA-5573: Add decimal codegen in text scanner

2017-08-16 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5573: Add decimal codegen in text scanner .. Patch Set 7: GCC implicitly converted nullptr to string then to Status. -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-5573: Add decimal codegen in text scanner

2017-08-16 Thread Tianyi Wang (Code Review)
Hello Impala Public Jenkins, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7683 to look at the new patch set (#7). Change subject: IMPALA-5573: Add decimal codegen in text scanner

[Impala-ASF-CR] IMPALA-4039: Increase width of Operator column in runtime profile

2017-08-16 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new change for review. http://gerrit.cloudera.org:8080/7691 Change subject: IMPALA-4039: Increase width of Operator column in runtime profile .. IMPALA-4039: Increase width of Operator column in run

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-16 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. Patch Set 11: > (1 comment) web browser -- To view, visit http://gerrit.cloudera.org:8080/7642 To unsubscr

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-16 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/7642/11/be/src/util/logging-support.cc File be

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-16 Thread Tianyi Wang (Code Review)
Hello Impala Public Jenkins, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7642 to look at the new patch set (#12). Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-16 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. Patch Set 11: > This failed in > authorization/test_authorization.py::TestAuthorization::()::test_impersonat

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-16 Thread Tianyi Wang (Code Review)
Hello Impala Public Jenkins, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7642 to look at the new patch set (#11). Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .

[Impala-ASF-CR] IMPALA-5573: Add decimal codegen in text scanner

2017-08-16 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5573: Add decimal codegen in text scanner .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7683/5/be/src/runtime/decimal-value.h File be/src

[Impala-ASF-CR] IMPALA-5573: Add decimal codegen in text scanner

2017-08-16 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#6). Change subject: IMPALA-5573: Add decimal codegen in text scanner .. IMPALA-5573: Add decimal codegen in text scanner This patch adds decimal type codegen support in text scanner. Cu

[Impala-ASF-CR] IMPALA-5573: Add decimal codegen in text scanner

2017-08-16 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5573: Add decimal codegen in text scanner .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7683/2//COMMIT_MSG Commit Message: Line 14: Str

[Impala-ASF-CR] IMPALA-5573: Add decimal codegen in text scanner

2017-08-16 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#5). Change subject: IMPALA-5573: Add decimal codegen in text scanner .. IMPALA-5573: Add decimal codegen in text scanner This patch adds decimal type codegen support in text scanner. Cu

[Impala-ASF-CR] IMPALA-5573: Add decimal codegen in text scanner

2017-08-16 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#4). Change subject: IMPALA-5573: Add decimal codegen in text scanner .. IMPALA-5573: Add decimal codegen in text scanner This patch adds decimal type codegen support in text scanner. Cu

[Impala-ASF-CR] IMPALA-4794: Grouping distinct agg plan robust to data skew

2017-08-16 Thread Tianyi Wang (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7643 to look at the new patch set (#6). Change subject: IMPALA-4794: Grouping distinct agg plan robust to data skew .. IMPA

[Impala-ASF-CR] IMPALA-5573: Add decimal codegen in text scanner

2017-08-16 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5573: Add decimal codegen in text scanner .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7683/2/be/src/codegen/llvm-codegen.cc File be/sr

[Impala-ASF-CR] IMPALA-5573: Add decimal codegen in text scanner

2017-08-16 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#3). Change subject: IMPALA-5573: Add decimal codegen in text scanner .. IMPALA-5573: Add decimal codegen in text scanner This patch adds decimal type codegen support in text scanner. Cu

[Impala-ASF-CR] IMPALA-4794: Grouping distinct agg plan robust to data skew

2017-08-16 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-4794: Grouping distinct agg plan robust to data skew .. Patch Set 5: Rebased -- To view, visit http://gerrit.cloudera.org:8080/7643 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5573: Add decimal codegen in text scanner

2017-08-15 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5573: Add decimal codegen in text scanner .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7683/2/be/src/codegen/llvm-codegen.cc File be/sr

[Impala-ASF-CR] IMPALA-992: Rerun past queries from history in shell

2017-08-15 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-992: Rerun past queries from history in shell .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/7674/8/tests/shell/test_shell_interactive.py

[Impala-ASF-CR] IMPALA-992: Rerun past queries from history in shell

2017-08-15 Thread Tianyi Wang (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7674 to look at the new patch set (#9). Change subject: IMPALA-992: Rerun past queries from history in shell .. IMPALA-

[Impala-ASF-CR] IMPALA-992: Rerun past queries from history in shell

2017-08-15 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#9). Change subject: IMPALA-992: Rerun past queries from history in shell .. IMPALA-992: Rerun past queries from history in shell This patch adds a new command "rerun" and a shortcut "@"

[Impala-ASF-CR] IMPALA-5573: Add decimal codegen in text scanner

2017-08-15 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). Change subject: IMPALA-5573: Add decimal codegen in text scanner .. IMPALA-5573: Add decimal codegen in text scanner This patch adds decimal type codegen support in text scanner. Cu

[Impala-ASF-CR] IMPALA-5573: Add decimal codegen in text scanner

2017-08-15 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new change for review. http://gerrit.cloudera.org:8080/7683 Change subject: IMPALA-5573: Add decimal codegen in text scanner .. IMPALA-5573: Add decimal codegen in text scanner This patch adds decim

[Impala-ASF-CR] IMPALA-992: Rerun past queries from history in shell

2017-08-15 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-992: Rerun past queries from history in shell .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7674/7/tests/shell/test_shell_interactive.py

[Impala-ASF-CR] IMPALA-992: Rerun past queries from history in shell

2017-08-15 Thread Tianyi Wang (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7674 to look at the new patch set (#8). Change subject: IMPALA-992: Rerun past queries from history in shell .. IMPALA-

[Impala-ASF-CR] IMPALA-992: Rerun past queries from history in shell

2017-08-15 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-992: Rerun past queries from history in shell .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/7674/5//COMMIT_MSG Commit Message: Line 9:

[Impala-ASF-CR] IMPALA-992: Rerun past queries from history in shell

2017-08-15 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#7). Change subject: IMPALA-992: Rerun past queries from history in shell .. IMPALA-992: Rerun past queries from history in shell This patch adds a new command "rerun" and a shortcut "@"

[Impala-ASF-CR] IMPALA-992: Rerun past queries from history in shell

2017-08-15 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#6). Change subject: IMPALA-992: Rerun past queries from history in shell .. IMPALA-992: Rerun past queries from history in shell This patch adds a new command "rerun" and a shortcut "@"

[Impala-ASF-CR] IMPALA-992: Rerun past queries from history in shell

2017-08-15 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-992: Rerun past queries from history in shell .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/7674/4/shell/impala_shell.py File shell/impa

[Impala-ASF-CR] IMPALA-992: Rerun past queries from history in shell

2017-08-15 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#5). Change subject: IMPALA-992: Rerun past queries from history in shell .. IMPALA-992: Rerun past queries from history in shell This patch adds a new command "rerun" and shortcut "@" t

[Impala-ASF-CR] IMPALA-992: Rerun past queries from history in shell

2017-08-15 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#5). Change subject: IMPALA-992: Rerun past queries from history in shell .. IMPALA-992: Rerun past queries from history in shell This patch adds a new command "rerun" and shortcut "@" t

[Impala-ASF-CR] IMPALA-992: Rerun past queries from history in shell

2017-08-15 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-992: Rerun past queries from history in shell .. Patch Set 4: (12 comments) http://gerrit.cloudera.org:8080/#/c/7674/2//COMMIT_MSG Commit Message: PS2, Li

[Impala-ASF-CR] IMPALA-992: Rerun past queries from history in shell

2017-08-15 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#4). Change subject: IMPALA-992: Rerun past queries from history in shell .. IMPALA-992: Rerun past queries from history in shell This patch adds a new command "rerun" and shortcut "@" t

[Impala-ASF-CR] IMPALA-992: Rerun past queries from history in shell

2017-08-15 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#4). Change subject: IMPALA-992: Rerun past queries from history in shell .. IMPALA-992: Rerun past queries from history in shell This patch adds a new command "rerun" and shortcut "@" t

[Impala-ASF-CR] IMPALA-992: Rerun past queries from history in shell

2017-08-15 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#3). Change subject: IMPALA-992: Rerun past queries from history in shell .. IMPALA-992: Rerun past queries from history in shell This patch adds a new command "rerun" and shortcut "@" t

[Impala-ASF-CR] Impala-992: Rerun past queries from history in shell

2017-08-15 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new change for review. http://gerrit.cloudera.org:8080/7674 Change subject: Impala-992: Rerun past queries from history in shell .. Impala-992: Rerun past queries from history in shell This patch ad

[Impala-ASF-CR] IMPALA-4794: Grouping distinct agg plan robust to data skew

2017-08-14 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-4794: Grouping distinct agg plan robust to data skew .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/7643/3//COMMIT_MSG Commit Message: L

[Impala-ASF-CR] IMPALA-4794: Grouping distinct agg plan robust to data skew

2017-08-14 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#4). Change subject: IMPALA-4794: Grouping distinct agg plan robust to data skew .. IMPALA-4794: Grouping distinct agg plan robust to data skew This patch changes the query plan for grou

[Impala-ASF-CR] IMPALA-4794: Grouping distinct agg plan robust to data skew

2017-08-14 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-4794: Grouping distinct agg plan robust to data skew .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/7643/2/fe/src/main/java/org/apache/im

[Impala-ASF-CR] IMPALA-4794: Grouping distinct agg plan robust to data skew

2017-08-14 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#3). Change subject: IMPALA-4794: Grouping distinct agg plan robust to data skew .. IMPALA-4794: Grouping distinct agg plan robust to data skew This patch changes the query plan for grou

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-14 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. Patch Set 10: > (2 comments) > > Looks good. If you fix the last couple of nits and rebase I can > start

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-14 Thread Tianyi Wang (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7642 to look at the new patch set (#9). Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. IMPALA-53

[Impala-ASF-CR] IMPALA-4794: Grouping distinct agg plan robust to data skew

2017-08-11 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-4794: Grouping distinct agg plan robust to data skew .. Patch Set 2: > (19 comments) Done -- To view, visit http://gerrit.cloudera.org:8080/7643 To unsub

[Impala-ASF-CR] IMPALA-4794: Grouping distinct agg plan robust to data skew

2017-08-11 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). Change subject: IMPALA-4794: Grouping distinct agg plan robust to data skew .. IMPALA-4794: Grouping distinct agg plan robust to data skew This patch changes the query plan for grou

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-11 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. Patch Set 8: > (4 comments) > > Yeah, we use Status almost universally for error handling. We don't > cur

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-11 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#8). Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. IMPALA-5327: Handle return of JNI GetStringUTFChar GetStringUTFChars may return NULL or throw exception and it

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-11 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#7). Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. IMPALA-5327: Handle return of JNI GetStringUTFChar GetStringUTFChars may return NULL or throw exception and it

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-11 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. Patch Set 6: D > (7 comments) Done(Test is still ongoing). I have a question: when doing error handling th

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-11 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#6). Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. IMPALA-5327: Handle return of JNI GetStringUTFChar GetStringUTFChars may return NULL or throw exception and it

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-11 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#5). Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. IMPALA-5327: Handle return of JNI GetStringUTFChar GetStringUTFChars may return NULL or throw exception and it

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-11 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#4). Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. IMPALA-5327: Handle return of JNI GetStringUTFChar GetStringUTFChars may return NULL or throw exception and it

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-10 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. Patch Set 3: > (5 comments) Comments addressed. The code is still a little redundant for resource releasing

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-10 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#3). Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. IMPALA-5327: Handle return of JNI GetStringUTFChar GetStringUTFChars may return NULL or throw exception and it

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-10 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. IMPALA-5327: Handle return of JNI GetStringUTFChar GetStringUTFChars may return NULL or throw exception and it

[Impala-ASF-CR] IMPALA-4794: Partition distinct expr for skew data

2017-08-10 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new change for review. http://gerrit.cloudera.org:8080/7643 Change subject: IMPALA-4794: Partition distinct expr for skew data .. IMPALA-4794: Partition distinct expr for skew data Currently in an a

[Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar

2017-08-10 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new change for review. http://gerrit.cloudera.org:8080/7642 Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar .. IMPALA-5327: Handle return of JNI GetStringUTFChar GetStringUTFChars

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-07 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 5: I will test the rebased version again. -- To view, visit http://gerrit.cloudera.org:8080/7556 To

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-04 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 4: > (1 comment) Done -- To view, visit http://gerrit.cloudera.org:8080/7556 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-04 Thread Tianyi Wang (Code Review)
Hello Impala Public Jenkins, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7556 to look at the new patch set (#4). Change subject: IMPALA-5572: Timestamp codegen for text scanner .

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-03 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 3: Rebase done -- To view, visit http://gerrit.cloudera.org:8080/7556 To unsubscribe, visit http://g

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-03 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/7556/1//COMMIT_MSG Commit Message: Line 14: > C

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-03 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). Change subject: IMPALA-5572: Timestamp codegen for text scanner .. IMPALA-5572: Timestamp codegen for text scanner Currently codegen is disabled when scanning text tables with times

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). Change subject: IMPALA-5572: Timestamp codegen for text scanner .. IMPALA-5572: Timestamp codegen for text scanner Currently codegen is disabled when scanning text tables with times

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#16). Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. IMPALA-3894: Change the behavior parsing date "YY" This patch change the behavor when running unix_timestamp(s

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Tianyi Wang (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7530 to look at the new patch set (#16). Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. IMPALA-3

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Tianyi Wang (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7530 to look at the new patch set (#15). Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. IMPALA-3

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/7530/14/be/src/runtime/timestamp-parse-util.h

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#14). Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. IMPALA-3894: Change the behavior parsing date "YY" This patch change the behavor when running unix_timestamp(s

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Tianyi Wang (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7530 to look at the new patch set (#14). Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. IMPALA-3

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/7530/13/be/src/runtime/timestamp-parse-util.h

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#13). Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. IMPALA-3894: Change the behavior parsing date "YY" This patch change the behavor when running unix_timestamp(s

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Tianyi Wang (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7530 to look at the new patch set (#13). Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. IMPALA-3

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Tianyi Wang (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7530 to look at the new patch set (#12). Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. IMPALA-3

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Tianyi Wang (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7530 to look at the new patch set (#11). Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. IMPALA-3

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-02 Thread Tianyi Wang (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7530 to look at the new patch set (#10). Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. IMPALA-3

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-08-01 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/7530/9//COMMIT_MSG Commit Message: PS9, Line 1

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-01 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7556/1/be/src/exec/hdfs-scanner-ir.cc File be/src/

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-01 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new change for review. http://gerrit.cloudera.org:8080/7556 Change subject: IMPALA-5572: Timestamp codegen for text scanner .. IMPALA-5572: Timestamp codegen for text scanner Currently codegen is di

[Impala-ASF-CR] IMPALA-1470: Fix error message with catalog down

2017-07-31 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-1470: Fix error message with catalog down .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7539/3/be/src/service/fe-support.cc File be/src/s

[Impala-ASF-CR] IMPALA-1470: Fix error message with catalog down

2017-07-31 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-1470: Fix error message with catalog down .. Patch Set 3: It does seem to work with the field made required. -- To view, visit http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-1470: Fix error message with catalog down

2017-07-31 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#3). Change subject: IMPALA-1470: Fix error message with catalog down .. IMPALA-1470: Fix error message with catalog down When the catalog server cannot be reached, currently impala clie

[Impala-ASF-CR] IMPALA-1470: Fix error message with catalog down

2017-07-31 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-1470: Fix error message with catalog down .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7539/2/be/src/service/fe-support.cc File be/src/s

[Impala-ASF-CR] IMPALA-1470: Fix error message with catalog down

2017-07-31 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). Change subject: IMPALA-1470: Fix error message with catalog down .. IMPALA-1470: Fix error message with catalog down When the catalog server cannot be reached, currently impala clie

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-07-31 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#9). Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. IMPALA-3894: Change the behavior parsing date "YY" This patch change the behavor when running unix_timestamp(st

[Impala-ASF-CR] IMPALA-1470: Fix error message with catalog down

2017-07-31 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new change for review. http://gerrit.cloudera.org:8080/7539 Change subject: IMPALA-1470: Fix error message with catalog down .. IMPALA-1470: Fix error message with catalog down When the catalog serv

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-07-28 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. Patch Set 8: (7 comments) http://gerrit.cloudera.org:8080/#/c/7530/4/be/src/exprs/timestamp-functions-ir.cc

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-07-28 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#8). Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. IMPALA-3894: Change the behavior parsing date "YY" This patch change the behavor when running unix_timestamp(st

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-07-28 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#5). Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. IMPALA-3894: Change the behavior parsing date "YY" This patch change the behavor when running unix_timestamp(st

[Impala-ASF-CR] IMPALA-5636: Change the metadata in parquet

2017-07-28 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#5). Change subject: IMPALA-5636: Change the metadata in parquet .. IMPALA-5636: Change the metadata in parquet When writing in parquet format, Impala does not use repetition level. But

<    1   2   3   4   >