[Impala-ASF-CR] IMPALA-3742: Partitions and sort INSERTs for Kudu tables

2017-04-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3742: Partitions and sort INSERTs for Kudu tables .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6559/2/be/src/exprs/kudu-partition-exp

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-04-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 5: > (5 comments) > > > 1) Brining in all the gflags is maybe concerning. will any > c

[Impala-ASF-CR](asf-site) Impala and Hive have slightly different SQL they accept.

2017-04-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Impala and Hive have slightly different SQL they accept. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6567/1/index.html File index.html: PS

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-04-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 6: > Re: gflags - agree we need to look hard at a solution. Do you think > we could do th

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-04-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5715 To unsubscribe, v

[Impala-ASF-CR](asf-site) Impala and Hive have slightly different SQL they accept.

2017-04-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Impala and Hive have slightly different SQL they accept. .. Patch Set 1: Code-Review+2 Yes, that works for me. Thanks! -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-04-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 2: ping @dan -- To view, visit http://gerrit.cloudera.org:8080/6526 To unsubscribe,

[Impala-ASF-CR] IMPALA-5183: increase write wait timeout in BufferedBlockMgrTest

2017-04-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5183: increase write wait timeout in BufferedBlockMgrTest .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6595 To unsubs

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-04-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 2: > > ping @dan > > Are you waiting for something from me? I thought you were wai

[Impala-ASF-CR] IMPALA-5189: Pin version of setuptools scm

2017-04-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5189: Pin version of setuptools_scm .. Patch Set 1: Thanks, Lars. How did you test this? -- To view, visit http://gerrit.cloudera.org:8080/6599 To uns

[Impala-ASF-CR] IMPALA-5189: Pin version of setuptools scm

2017-04-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5189: Pin version of setuptools_scm .. Patch Set 1: > > unless we feel we should pin the package to 1.15.0 anyways > > We could pin to 1.15.4 as our k

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-04-09 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6526/2/be/src/exec/kudu-table-si

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-04-09 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#3). Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP Adds Impala support for TIMESTAMP t

[Impala-ASF-CR] IMPALA-3742: Partitions and sort INSERTs for Kudu tables

2017-04-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3742: Partitions and sort INSERTs for Kudu tables .. Patch Set 3: (11 comments) http://gerrit.cloudera.org:8080/#/c/6559/3/be/src/exec/kudu-util.cc File

[Impala-ASF-CR] IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts

2017-04-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6616 Change subject: IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts .. IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts

[Impala-ASF-CR] IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts

2017-04-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts .. Patch Set 1: Yeah, it's a good question. I don't know and unfortunately I think it's more general

[Impala-ASF-CR] IMPALA-2800: make memory maintenance less aggressive

2017-04-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-2800: make memory maintenance less aggressive .. Patch Set 3: (2 comments) how did you test this? http://gerrit.cloudera.org:8080/#/c/6626/3//COMMIT_MS

[native-toolchain-CR] IMPALA-5187: Bump breakpad version for Breakpad bug #681

2017-04-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5187: Bump breakpad version for Breakpad bug #681 .. Patch Set 1: why don't we need 0002-Increase-maximum-number-of-threads-for-minidump_stac.patch anym

[Impala-ASF-CR] IMPALA-5080: OutOfMemory PermGen space

2017-04-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5080: OutOfMemory PermGen space .. Patch Set 1: Code-Review+1 (1 comment) Thanks for your work on this Thomas, I think this looks like a reasonable app

[Impala-ASF-CR] [DOCS] Mention Kerberos and TLS for Kudu security

2017-04-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [DOCS] Mention Kerberos and TLS for Kudu security .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6634/1/docs/shared/impala_common.xml File doc

[Impala-ASF-CR] [DOCS] Mention Kerberos and TLS for Kudu security

2017-04-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [DOCS] Mention Kerberos and TLS for Kudu security .. Patch Set 1: (1 comment) lets wait to hear from JD/Dan about the right link http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-2800: make memory maintenance less aggressive

2017-04-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-2800: make memory maintenance less aggressive .. Patch Set 4: Code-Review+1 Thanks for doing this -- To view, visit http://gerrit.cloudera.org:8080/662

[Impala-ASF-CR] IMPALA-5198: Error messages are sometimes dropped before reaching client

2017-04-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5198: Error messages are sometimes dropped before reaching client .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/6627/3/be/src/common

[Impala-ASF-CR] IMPALA-5198: Error messages are sometimes dropped before reaching client

2017-04-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5198: Error messages are sometimes dropped before reaching client .. Patch Set 4: Code-Review+1 lgtm pending test run passes thanks! -- To view, visi

[Impala-ASF-CR] IMPALA-3742: Partitions and sort INSERTs for Kudu tables

2017-04-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3742: Partitions and sort INSERTs for Kudu tables .. Patch Set 4: > > > Perf results from running on the 10 node cluster: > > > > > > For smaller queri

[Impala-ASF-CR] IMPALA-5080: OutOfMemory PermGen space

2017-04-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has submitted this change and it was merged. Change subject: IMPALA-5080: OutOfMemory PermGen space .. IMPALA-5080: OutOfMemory PermGen space The problem is that over time our usage of PermGen space has gradually

[Impala-ASF-CR] IMPALA-5080: OutOfMemory PermGen space

2017-04-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5080: OutOfMemory PermGen space .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6642 To unsubscribe, visit http://gerrit

[Impala-ASF-CR] IMPALA-5217: KuduTableSink checks null constraints incorrectly

2017-04-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5217: KuduTableSink checks null constraints incorrectly .. Patch Set 1: Code-Review+2 (1 comment) nice catch http://gerrit.cloudera.org:8080/#/c/6670/1

[native-toolchain-CR] IMPALA-5174: Add hidden flags to gflags (2.2.0-p1)

2017-04-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5174: Add hidden flags to gflags (2.2.0-p1) .. Patch Set 1: (3 comments) longer term, is it reasonable to think we'd try to get this functionality upst

[Impala-ASF-CR] IMPALA-5189: Pin version of setuptools-scm

2017-04-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5189: Pin version of setuptools-scm .. Patch Set 3: agreed -- To view, visit http://gerrit.cloudera.org:8080/6599 To unsubscribe, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-3742: Partitions and sort INSERTs for Kudu tables

2017-04-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3742: Partitions and sort INSERTs for Kudu tables .. Patch Set 4: > As requested, I ran some tests with tpcds_1000_text.store_sales: > > with patch: 3

[Impala-ASF-CR] IMPALA-5189: Pin version of setuptools-scm

2017-04-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5189: Pin version of setuptools-scm .. Patch Set 3: submitted for gvo -- To view, visit http://gerrit.cloudera.org:8080/6599 To unsubscribe, visit http

[Impala-ASF-CR] IMPALA-5231: skip test explain level on non-HDFS systems

2017-04-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5231: skip test_explain_level on non-HDFS systems .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6703/1/tests/common/skip.py File test

[Impala-ASF-CR] IMPALA-5231: skip test explain level on non-HDFS systems

2017-04-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5231: skip test_explain_level on non-HDFS systems .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6703 To unsubscribe, v

[native-toolchain-CR] IMPALA-5174: Add hidden flags to gflags (2.2.0-p1)

2017-04-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5174: Add hidden flags to gflags (2.2.0-p1) .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/6672/1/source/gflags/gflags-2.

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-04-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 2: (3 comments) Thanks for the input Lars, sorry for the delay. I've been waiting to

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-04-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#4). Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP Adds Impala support for TIMESTAMP t

[native-toolchain-CR] Bumped Kudu version to 238249c.

2017-04-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bumped Kudu version to 238249c. .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6711 To unsubscribe, visit http://ge

[native-toolchain-CR] Bumped Kudu version to 238249c.

2017-04-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has submitted this change and it was merged. Change subject: Bumped Kudu version to 238249c. .. Bumped Kudu version to 238249c. This will pull in the Kudu client partitioner API, which is needed for IMPALA-3742.

[Impala-ASF-CR] [DOCS] Mention Kerberos and TLS for Kudu security

2017-04-28 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [DOCS] Mention Kerberos and TLS for Kudu security .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6634 To unsubscribe, visit ht

[Impala-ASF-CR] Bump Kudu version to 238249c

2017-04-28 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to 238249c .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6718 To unsubscribe, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-5252: Fix crash in HiveUdfCall::GetStringVal() when mem limit exceeded

2017-04-28 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5252: Fix crash in HiveUdfCall::GetStringVal() when mem_limit exceeded .. Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/6

[Impala-ASF-CR] IMPALA-5252: Fix crash in HiveUdfCall::GetStringVal() when mem limit exceeded

2017-04-28 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5252: Fix crash in HiveUdfCall::GetStringVal() when mem_limit exceeded .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-5252: Fix crash in HiveUdfCall::GetStringVal() when mem limit exceeded

2017-04-28 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5252: Fix crash in HiveUdfCall::GetStringVal() when mem_limit exceeded .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6761/1/be/src/ud

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-05-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#5). Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP Adds Impala support for TIMESTAMP t

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-05-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. Patch Set 7: Code-Review+2 sorry for all the rebasing noise, I'm holding off on committing this until

[Impala-ASF-CR] IMPALA-4866: Hash join node does not apply limits correctly

2017-05-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4866: Hash join node does not apply limits correctly .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6778/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu

2017-05-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6789 Change subject: IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu .. IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-05-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. Patch Set 8: Code-Review+2 rebase, fixed a merge conflict -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-5080: OutOfMemory PermGen space

2017-05-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5080: OutOfMemory PermGen space .. Patch Set 1: Code-Review+2 wow, hopefully this was the issue thanks for double checking -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-05-03 Thread Matthew Jacobs (Code Review)
Hello Impala Public Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6510 to look at the new patch set (#9). Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors ..

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-05-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. Patch Set 9: Code-Review+2 Had to change a new instance of TimestampValue::DebugString -> ToString tha

[native-toolchain-CR] Bump Kudu version to 7533364.

2017-05-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6796 Change subject: Bump Kudu version to 7533364. .. Bump Kudu version to 7533364. Change-Id: Ia769446fbcd265977859d3e20a6acfff1d89344b ---

[Impala-ASF-CR] Bump Kudu version to 7533364

2017-05-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6797 Change subject: Bump Kudu version to 7533364 .. Bump Kudu version to 7533364 Change-Id: I88dc2d425bd3aff70c95d51818d0450709123d27 --- M

[Impala-ASF-CR] IMPALA-5167: Use a single Kudu client across the BE

2017-05-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5167: Use a single Kudu client across the BE .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6792/1/be/src/exec/kudu-table-sink.cc File

[Impala-ASF-CR] IMPALA-5167: Use a single Kudu client across the BE

2017-05-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5167: Use a single Kudu client across the BE .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6792/1//COMMIT_MSG Commit Message: Line 1

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-05-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 5: (14 comments) http://gerrit.cloudera.org:8080/#/c/6526/5//COMMIT_MSG Commit Messa

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-05-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#6). Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP Adds Impala support for TIMESTAMP t

[Impala-ASF-CR] IMPALA-5207,IMPALA-5214: distcc fixes

2017-05-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5207,IMPALA-5214: distcc fixes .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6655/3/bin/distcc/distcc_env.sh File bin/di

[Impala-ASF-CR] Bump Kudu version to 7533364

2017-05-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to 7533364 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6797 To unsubscribe, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-05-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/6526/6/be/src/exec/kudu-scanner.

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-05-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#7). Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP Adds Impala support for TIMESTAMP t

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-05-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 7: (2 comments) Thanks for the reviews. I'm going to squash in the "TimestampValue c

[Impala-ASF-CR] IMPALA-5167: Reduce the number of Kudu clients created

2017-05-09 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5167: Reduce the number of Kudu clients created .. Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/6792/1//COMMIT_MSG Commit Message: Lin

[Impala-ASF-CR] IMPALA-4499: Table name missing from exec summary

2017-05-09 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4499: Table name missing from exec summary .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/6832/1/tests/query_test/test_ob

[Impala-ASF-CR] IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6842 Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM .. IMPALA-5297: Reduce free-pool-test mem requirement to

[Impala-ASF-CR] IMPALA-5167: Reduce the number of Kudu clients created

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5167: Reduce the number of Kudu clients created .. Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/6792/3/be/src/runtime/exe

[Impala-ASF-CR] IMPALA-5297: Set Kudu minicluster memory limit

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6844 Change subject: IMPALA-5297: Set Kudu minicluster memory limit .. IMPALA-5297: Set Kudu minicluster memory limit By default, Kudu assum

[Impala-ASF-CR] IMPALA-5297: Set Kudu minicluster memory limit

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5297: Set Kudu minicluster memory limit .. Patch Set 1: posted to test gerrit-verify-dryrun -- To view, visit http://gerrit.cloudera.org:8080/6844 To u

[Impala-ASF-CR] IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6842/1/be/src/runtime/free-poo

[Impala-ASF-CR] IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM .. IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM On jenkins.impala.io gerrit-ver

[Impala-ASF-CR] IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM .. Patch Set 2: I measured the max rss w/ this change to be 88mb, down from 14gb is what I obse

[Impala-ASF-CR] IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM

2017-05-10 Thread Matthew Jacobs (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6842 to look at the new patch set (#3). Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM ..

[Impala-ASF-CR] IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM .. Patch Set 3: fwiw the jenkins nodes (both public and private) appear to have vm_overcommit 0

[Impala-ASF-CR] IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/6789/1/be/src/exprs/timestamp-functi

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has abandoned this change. Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. Abandoned merging with https://gerrit.cloudera.org/#/c/6526/ -- To view, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu .. IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu This change builds on the support for readi

[Impala-ASF-CR] IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6849 Change subject: IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL .. IMPALA-5137: Support TIMESTAMPs in Kudu range predicate D

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-05-10 Thread Matthew Jacobs (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6526 to look at the new patch set (#8). Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP ...

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 8: Code-Review+2 (1 comment) Merged in related refactoring patch which also had a +2

[Impala-ASF-CR] Bump Kudu version to 7533364

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to 7533364 .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6797 To unsubscribe, visit http://gerrit.cloudera.

[Impala-ASF-CR] Bump Kudu version to 7533364

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has submitted this change and it was merged. Change subject: Bump Kudu version to 7533364 .. Bump Kudu version to 7533364 Change-Id: I88dc2d425bd3aff70c95d51818d0450709123d27 Reviewed-on: http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 9: Code-Review+2 carry +2, rebased -- To view, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-05-11 Thread Matthew Jacobs (Code Review)
Hello Marcel Kornacker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6526 to look at the new patch set (#10). Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP ...

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-05-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 10: Code-Review+2 Missed a FE test -- To view, visit http://gerrit.cloudera.org:808

[native-toolchain-CR] Bump Kudu version to 7533364.

2017-05-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has submitted this change and it was merged. Change subject: Bump Kudu version to 7533364. .. Bump Kudu version to 7533364. Change-Id: Ia769446fbcd265977859d3e20a6acfff1d89344b --- M buildall.sh 1 file changed, 1

[native-toolchain-CR] Bump Kudu version to 7533364.

2017-05-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to 7533364. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6796 To unsubscribe, visit http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-5305: test observability.py failing on s3, localFS and Isilon

2017-05-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5305: test_observability.py failing on s3, localFS and Isilon .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6859 To u

[Impala-ASF-CR] IMPALA-4075: Fix import kudu module exception on conftest.py

2017-05-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has abandoned this change. Change subject: IMPALA-4075: Fix import kudu module exception on conftest.py .. Abandoned have been waiting on hewenting for 8 months without a response -- To view, visit http://gerri

[native-toolchain-CR] IMPALA-5208, IMPALA-5187: Fixes for Breakpad #681, #728

2017-05-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5208, IMPALA-5187: Fixes for Breakpad #681, #728 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6866 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL

2017-05-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6849/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL

2017-05-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL .. IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL Adds support in DDL for timestamps in K

[Impala-ASF-CR] IMPALA-5291: avoid calling global destructors in statestore-test

2017-05-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5291: avoid calling global destructors in statestore-test .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6872 To unsubs

[Impala-ASF-CR] IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu

2017-05-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6789/3/fe/src/main/java/org/apache/im

[Impala-ASF-CR] IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL

2017-05-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/6849/2//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL

2017-05-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#3). Change subject: IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL .. IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL Adds support in DDL for timestamps in K

[Impala-ASF-CR] IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL

2017-05-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#4). Change subject: IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL .. IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL Adds support in DDL for timestamps in K

[Impala-ASF-CR] IMPALA-4764: Add Hedged read metrics

2017-05-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4764: Add Hedged read metrics .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6886/3/be/src/runtime/disk-io-mgr-scan-range.cc File be/s

[Impala-ASF-CR] IMPALA-5187, IMPALA-5208: Bump Breakpad Version, undo IMPALA-3794

2017-05-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5187, IMPALA-5208: Bump Breakpad Version, undo IMPALA-3794 .. Patch Set 1: I assume you tested the repro mentioned in IMPALA-3794? while [ $? -eq 0 ];

[Impala-ASF-CR] IMPALA-4764: Add Hedged read metrics

2017-05-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4764: Add Hedged read metrics .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/6886/4//COMMIT_MSG Commit Message: PS4, Line 13: hedgeRe

<    1   2   3   4   5   6   7   8   9   10   >