[Impala-ASF-CR] IMPALA-4379: Fix and test Kudu table type checking, follow up

2016-11-03 Thread Matthew Jacobs (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4894 to look at the new patch set (#2). Change subject: IMPALA-4379: Fix and test Kudu table type checking, follow up .. IM

[Impala-ASF-CR] IMPALA-4379: Fix and test Kudu table type checking, follow up

2016-11-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4379: Fix and test Kudu table type checking, follow up .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4894 To unsubscri

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3771: Expose kudu client timeout and set default .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/4849/4/be/src/catalog/catalog.cc File

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-03 Thread Matthew Jacobs (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4849 to look at the new patch set (#5). Change subject: IMPALA-3771: Expose kudu client timeout and set default .. IMPALA

[Impala-ASF-CR] IMPALA-3710: Kudu DML should ignore conflicts by default

2016-11-04 Thread Matthew Jacobs (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4911 to look at the new patch set (#3). Change subject: IMPALA-3710: Kudu DML should ignore conflicts by default .

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-11-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 17: Why did the gvo fail? Were there any code changes in the latest patch set or just a rebase? -- To

[Impala-ASF-CR] IMPALA-3710: Kudu DML should ignore conflicts by default

2016-11-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3710: Kudu DML should ignore conflicts by default .. Patch Set 3: Code-Review+2 updated test and rebased -- To view, visit http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-11-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4756 To unsubs

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-11-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 8: Why did the gvo fail? Were there any code changes in the latest patch set or j

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-11-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 17: Code-Review+2 Ok thanks, it looked like this was just a rebase just wanted to check there wasn't any

[Impala-ASF-CR] IMPALA-4260: Alter table add column drops all the column stats

2016-11-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4260: Alter table add column drops all the column stats .. Patch Set 2: Code-Review+2 carrying dimitris' +2 -- To view, visit http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-11-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 19: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4047 To unsubscribe, visit http://ge

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3771: Expose kudu client timeout and set default .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/4849/5/be/src/exec/kudu-table-sink.h F

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3771: Expose kudu client timeout and set default .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4849/5/testdata/workloads/functional-qu

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-04 Thread Matthew Jacobs (Code Review)
Hello Lars Volker, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4849 to look at the new patch set (#6). Change subject: IMPALA-3771: Expose kudu client timeout and set default

[Impala-ASF-CR] IMPALA-3771: Expose kudu client timeout and set default

2016-11-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3771: Expose kudu client timeout and set default .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4849 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-11-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4756 To unsubs

[Impala-ASF-CR] IMPALA-4442: Fix FE ParserTests UnsatisfiedLinkError

2016-11-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/4976 Change subject: IMPALA-4442: Fix FE ParserTests UnsatisfiedLinkError .. IMPALA-4442: Fix FE ParserTests UnsatisfiedLinkError In some de

[Impala-ASF-CR] IMPALA-3710: Kudu DML should ignore conflicts by default

2016-11-07 Thread Matthew Jacobs (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4911 to look at the new patch set (#4). Change subject: IMPALA-3710: Kudu DML should ignore conflicts by default .

[Impala-ASF-CR] IMPALA-3710: Kudu DML should ignore conflicts by default

2016-11-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3710: Kudu DML should ignore conflicts by default .. Patch Set 4: Updated patch to resolve merge conflicts with: 1) UPSERT patch 2) Support for non-cover

[Impala-ASF-CR] IMPALA-3710: Kudu DML should ignore conflicts, pt2

2016-11-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/4985 Change subject: IMPALA-3710: Kudu DML should ignore conflicts, pt2 .. IMPALA-3710: Kudu DML should ignore conflicts, pt2 Second part of

[Impala-ASF-CR] Improve Kudu UPSERT test coverage

2016-11-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Improve Kudu UPSERT test coverage .. Patch Set 2: (7 comments) Thanks! This is great. I didn't look as closely as I did in revision 1, but I'll check again to

[Impala-ASF-CR] IMPALA-3710: Kudu DML should ignore conflicts, pt2

2016-11-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3710: Kudu DML should ignore conflicts, pt2 .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/4985/1/be/src/exec/data-sink.cc File be/src

[Impala-ASF-CR] Improve Kudu UPSERT test coverage

2016-11-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Improve Kudu UPSERT test coverage .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4953/2/tests/common/impala_test_suite.py File tests/common/i

[Impala-ASF-CR] Improve Kudu UPSERT test coverage

2016-11-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Improve Kudu UPSERT test coverage .. Patch Set 4: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/4953/4//COMMIT_MSG Commit Message: PS4, Line

[Impala-ASF-CR] IMPALA-3710: Kudu DML should ignore conflicts, pt2

2016-11-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3710: Kudu DML should ignore conflicts, pt2 .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4985/1/be/src/exec/data-sink.cc File be/src

[Impala-ASF-CR] IMPALA-3710: Kudu DML should ignore conflicts, pt2

2016-11-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3710: Kudu DML should ignore conflicts, pt2 .. Patch Set 1: BTW, based on a conversation with the Kudu folks I learned my handling of the 'NotFound' err

[Impala-ASF-CR] IMPALA-3710: Kudu DML should ignore conflicts, pt2

2016-11-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-3710: Kudu DML should ignore conflicts, pt2 .. IMPALA-3710: Kudu DML should ignore conflicts, pt2 Second part of IMPALA-3710, which removed the IGNORE DML

[Impala-ASF-CR] IMPALA-3710: Kudu DML should ignore conflicts, pt2

2016-11-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3710: Kudu DML should ignore conflicts, pt2 .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4985/2/be/src/exec/kudu-table-sink.cc File

[Impala-ASF-CR] IMPALA-3710: Kudu DML should ignore conflicts, pt2

2016-11-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#3). Change subject: IMPALA-3710: Kudu DML should ignore conflicts, pt2 .. IMPALA-3710: Kudu DML should ignore conflicts, pt2 Second part of IMPALA-3710, which removed the IGNORE DML

[Impala-ASF-CR] IMPALA-4466: Improve Kudu UPSERT test coverage

2016-11-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4466: Improve Kudu UPSERT test coverage .. Patch Set 6: (5 comments) Thanks, a few small things and I'm gonna follow up with you about validation. http

[Impala-ASF-CR] IMPALA-4466: Improve Kudu UPSERT test coverage

2016-11-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4466: Improve Kudu UPSERT test coverage .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4953 To unsubscribe, visit http:

[Impala-ASF-CR] IMPALA-4477: Upgrade Kudu version to latest master

2016-11-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5054 Change subject: IMPALA-4477: Upgrade Kudu version to latest master .. IMPALA-4477: Upgrade Kudu version to latest master Change the too

[Impala-ASF-CR] IMPALA-4477: Upgrade Kudu version to latest master

2016-11-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4477: Upgrade Kudu version to latest master .. Patch Set 1: Kicked off a test build. -- To view, visit http://gerrit.cloudera.org:8080/5054 To unsubscr

[Impala-ASF-CR] IMPALA-4477: Upgrade Kudu version to latest master

2016-11-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4477: Upgrade Kudu version to latest master .. Patch Set 1: Private build passed: http://sandbox.jenkins.cloudera.com/job/impala-umbrella-build-and-test/

[Impala-ASF-CR] Run MT DOP tests on all file formats.

2016-11-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Run MT_DOP tests on all file formats. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5025 To unsubscribe, visit http://gerrit.

[Impala-ASF-CR] IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting

2016-11-15 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5103 Change subject: IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting .. IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting Adds sup

[Impala-ASF-CR] IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting

2016-11-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5103/1/be/src/service/impala-beeswax-ser

[Impala-ASF-CR] IMPALA-4477: Upgrade Kudu version to latest master

2016-11-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5106 Change subject: IMPALA-4477: Upgrade Kudu version to latest master .. IMPALA-4477: Upgrade Kudu version to latest master Change the too

[Impala-ASF-CR] IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting

2016-11-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting .. IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting Adds support in the shell to report the number of m

[Impala-ASF-CR] IMPALA-4477: Upgrade Kudu version to latest master

2016-11-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4477: Upgrade Kudu version to latest master .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5106/1/bin/impala-config.sh File bin/impala-

[Impala-ASF-CR] IMPALA-4477: Upgrade Kudu version to latest master

2016-11-16 Thread Matthew Jacobs (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5106 to look at the new patch set (#2). Change subject: IMPALA-4477: Upgrade Kudu version to latest master .. I

[Impala-ASF-CR] IMPALA-4477: Upgrade Kudu version to latest master

2016-11-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4477: Upgrade Kudu version to latest master .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5106 To unsubscribe, visit h

[Impala-ASF-CR] IMPALA-4466: Improve Kudu CRUD test coverage

2016-11-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4466: Improve Kudu CRUD test coverage .. Patch Set 11: Code-Review+2 (1 comment) Reviewed the new test cases that were added. I assume there weren't oth

[Impala-ASF-CR] IMPALA-4466: Improve Kudu CRUD test coverage

2016-11-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4466: Improve Kudu CRUD test coverage .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4953 To unsubscribe, visit http:/

[Impala-ASF-CR] IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting

2016-11-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5103/2/common/thrift/ImpalaService.thrif

[Impala-ASF-CR] IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting

2016-11-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#3). Change subject: IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting .. IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting Adds support in the shell to report the number of m

[Impala-ASF-CR] IMPALA-4477: Upgrade Kudu version to latest master

2016-11-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5138 Change subject: IMPALA-4477: Upgrade Kudu version to latest master .. IMPALA-4477: Upgrade Kudu version to latest master Change the too

[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization

2016-11-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5139 Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization .. IMPALA-4497: Fix Kudu client crash w/ SASL initialization

[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization

2016-11-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization .. IMPALA-4497: Fix Kudu client crash w/ SASL initialization Kudu commit cd40d1c5126d0fd541d95370cdb2998

[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization

2016-11-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5139/2/be/src/rpc/authentication.cc F

[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization

2016-11-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#3). Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization .. IMPALA-4497: Fix Kudu client crash w/ SASL initialization Kudu commit cd40d1c5126d0fd541d95370cdb2998

[Impala-ASF-CR] IMPALA-4509: Initialise Sasl-specific mutex

2016-11-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4509: Initialise Sasl-specific mutex .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5142 To unsubscribe, visit http://g

[Impala-ASF-CR] IMPALA-4509: Initialise Sasl-specific mutex

2016-11-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4509: Initialise Sasl-specific mutex .. Patch Set 1: I'm kicking off a private build w/ my changes and I'm including this. I'll do a smoke test on a sec

[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization

2016-11-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization .. Patch Set 3: gvm failed because it needs to go in after the change the bumps the kudu version, whi

[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization

2016-11-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization .. Patch Set 4: Code-Review+2 carrying +2, rebased -- To view, visit http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-4509: Initialise Sasl-specific mutex

2016-11-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4509: Initialise Sasl-specific mutex .. Patch Set 1: Code-Review+2 I did a smoke test and it looks OK, we should still keep an eye out in perf runs, of

[Impala-ASF-CR] IMPALA-4357: Fix DROP TABLE for externally deleted Kudu tables

2016-11-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4357: Fix DROP TABLE for externally deleted Kudu tables .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5144/1/fe/src/main/java/org/apa

[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization

2016-11-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization .. Patch Set 4: Verified+1 Build failed with 'table already exists' bug - IMPALA-3641 Everything else

[Impala-ASF-CR] IMPALA-4497: Fix Kudu client crash w/ SASL initialization

2016-11-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4497: Fix Kudu client crash w/ SASL initialization .. Patch Set 4: -Verified Looks like I can't, so I'll run it through gvo again anyway. -- To view, v

[Impala-ASF-CR] IMPALA-4478: Initial Kudu client mem tracking for sink

2016-11-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5152 Change subject: IMPALA-4478: Initial Kudu client mem tracking for sink .. IMPALA-4478: Initial Kudu client mem tracking for sink The Ku

[Impala-ASF-CR] IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model

2016-11-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model .. Patch Set 1: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/51

[Impala-ASF-CR] IMPALA-4478: Initial Kudu client mem tracking for sink

2016-11-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4478: Initial Kudu client mem tracking for sink .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5152/1/be/src/exec/kudu-table-sink.cc F

[Impala-ASF-CR] IMPALA-4478: Initial Kudu client mem tracking for sink

2016-11-21 Thread Matthew Jacobs (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5152 to look at the new patch set (#2). Change subject: IMPALA-4478: Initial Kudu client mem tracking for sink ..

[Impala-ASF-CR] IMPALA-4478: Initial Kudu client mem tracking for sink

2016-11-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4478: Initial Kudu client mem tracking for sink .. Patch Set 2: Code-Review+2 carrying +2 -- To view, visit http://gerrit.cloudera.org:8080/5152 To uns

[Impala-ASF-CR] IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model

2016-11-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5162/1/tests/comp

[Impala-ASF-CR] IMPALA-4522: Bound Kudu client threads to avoid stress crash

2016-11-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5205 Change subject: IMPALA-4522: Bound Kudu client threads to avoid stress crash .. IMPALA-4522: Bound Kudu client threads to avoid stress c

[Impala-ASF-CR] IMPALA-4522: Bound Kudu client threads to avoid stress crash

2016-11-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4522: Bound Kudu client threads to avoid stress crash .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5205/1/fe/src/main/java/org/apache

[Impala-ASF-CR] IMPALA-4522: Bound Kudu client threads to avoid stress crash

2016-11-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-4522: Bound Kudu client threads to avoid stress crash .. IMPALA-4522: Bound Kudu client threads to avoid stress crash In stress testing on physical boxes (

[Impala-ASF-CR] IMPALA-3788: Add flag for Kudu read-your-writes

2016-11-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5288 Change subject: IMPALA-3788: Add flag for Kudu read-your-writes .. IMPALA-3788: Add flag for Kudu read-your-writes The previous attempt

[Impala-ASF-CR] IMPALA-3788: Add flag for Kudu read-your-writes

2016-11-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3788: Add flag for Kudu read-your-writes .. Patch Set 1: This is still being tested. David is going to test this with some Kudu changes going in to mast

[Impala-ASF-CR] IMPALA-4562: Fix for crash on kerberized clusters w/o Kudu support

2016-11-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5295 Change subject: IMPALA-4562: Fix for crash on kerberized clusters w/o Kudu support .. IMPALA-4562: Fix for crash on kerberized clusters

[Impala-ASF-CR] Bump Kudu python version to 1.1

2016-12-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5307 Change subject: Bump Kudu python version to 1.1 .. Bump Kudu python version to 1.1 Change-Id: I5834b3aa4eeae363eae938f61e473c52a0fe5596

[Impala-ASF-CR] IMPALA-4567: Fix test kudu alter table exhaustive failures

2016-12-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5312 Change subject: IMPALA-4567: Fix test_kudu_alter_table exhaustive failures .. IMPALA-4567: Fix test_kudu_alter_table exhaustive failures

[Impala-ASF-CR] IMPALA-4567: Fix test kudu alter table exhaustive failures

2016-12-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4567: Fix test_kudu_alter_table exhaustive failures .. Patch Set 1: > I used this command to see the test simply runs the .test file with > codegen enab

[Impala-ASF-CR] IMPALA-4571: InList predicates not being pushed to Kudu scans

2016-12-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5316 Change subject: IMPALA-4571: InList predicates not being pushed to Kudu scans .. IMPALA-4571: InList predicates not being pushed to Kudu

[Impala-ASF-CR] IMPALA-4571: InList predicates not being pushed to Kudu scans

2016-12-01 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-4571: InList predicates not being pushed to Kudu scans .. IMPALA-4571: InList predicates not being pushed to Kudu scans Fixes the KuduScanNode to convert I

[Impala-ASF-CR] IMPALA-4571: InList predicates not being pushed to Kudu scans

2016-12-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4571: InList predicates not being pushed to Kudu scans .. Patch Set 2: (12 comments) http://gerrit.cloudera.org:8080/#/c/5316/2//COMMIT_MSG Commit Messa

[Impala-ASF-CR] IMPALA-4571: Push IN predicates to Kudu

2016-12-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#3). Change subject: IMPALA-4571: Push IN predicates to Kudu .. IMPALA-4571: Push IN predicates to Kudu Fixes the KuduScanNode to convert InPredicates to KuduPredicates and push them

[Impala-ASF-CR] IMPALA-4566: Kudu client glog contention can cause timeouts

2016-12-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4566: Kudu client glog contention can cause timeouts .. Patch Set 1: Thanks, I'll test this on the stress cluster over the weekend -- To view, visit ht

[Impala-ASF-CR] IMPALA-4566: Kudu client glog contention can cause timeouts

2016-12-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4566: Kudu client glog contention can cause timeouts .. Patch Set 1: (3 comments) > I saw Todd has a change to address this on the client side.. is > t

[Impala-ASF-CR] Additional functional testing for default values on Kudu tables

2016-12-02 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Additional functional testing for default values on Kudu tables .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5337/1/testdata/workloads/funct

[Impala-ASF-CR] Additional functional testing for default values on Kudu tables

2016-12-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Additional functional testing for default values on Kudu tables .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5337/1/testdata/workloads/funct

[Impala-ASF-CR] Additional functional testing for default values on Kudu tables

2016-12-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Additional functional testing for default values on Kudu tables .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5337 To unsubsc

[Impala-ASF-CR] IMPALA-4571: Push IN predicates to Kudu

2016-12-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4571: Push IN predicates to Kudu .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/5316/3/fe/src/main/java/org/apache/impala/planner/Kudu

[Impala-ASF-CR] IMPALA-4571: Push IN predicates to Kudu

2016-12-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#4). Change subject: IMPALA-4571: Push IN predicates to Kudu .. IMPALA-4571: Push IN predicates to Kudu Fixes the KuduScanNode to convert InPredicates to KuduPredicates and push them

[Impala-ASF-CR] IMPALA-4571: Push IN predicates to Kudu

2016-12-05 Thread Matthew Jacobs (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5316 to look at the new patch set (#5). Change subject: IMPALA-4571: Push IN predicates to Kudu .. IMPALA-4571: Push IN pre

[Impala-ASF-CR] IMPALA-4571: Push IN predicates to Kudu

2016-12-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4571: Push IN predicates to Kudu .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5316/4/fe/src/main/java/org/apache/impala/planner/KuduS

[Impala-ASF-CR] IMPALA-4571: Push IN predicates to Kudu

2016-12-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4571: Push IN predicates to Kudu .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5316 To unsubscribe, visit http://gerri

[Impala-ASF-CR] IMPALA-4477: Bump Kudu version to latest master (60aa54e)

2016-12-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5369 Change subject: IMPALA-4477: Bump Kudu version to latest master (60aa54e) .. IMPALA-4477: Bump Kudu version to latest master (60aa54e)

[Impala-ASF-CR] IMPALA-4566: Kudu client glog contention can cause timeouts

2016-12-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4566: Kudu client glog contention can cause timeouts .. Patch Set 2: Code-Review+2 I think this addressed the issue, thanks! -- To view, visit http://g

[Impala-ASF-CR] IMPALA-4566: Kudu client glog contention can cause timeouts

2016-12-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4566: Kudu client glog contention can cause timeouts .. Patch Set 2: -Code-Review Hm maybe the issue is still there, I thought it was fixed but Todd said

[Impala-ASF-CR] IMPALA-3788: Add flag for Kudu read-your-writes

2016-12-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3788: Add flag for Kudu read-your-writes .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5288/1/be/src/exec/kudu-scanner.cc File be/src/

[Impala-ASF-CR] IMPALA-3788: Add flag for Kudu read-your-writes

2016-12-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-3788: Add flag for Kudu read-your-writes .. IMPALA-3788: Add flag for Kudu read-your-writes The previous attempt to support for Kudu 'read-your-writes' con

[Impala-ASF-CR] IMPALA-3788: Add flag for Kudu read-your-writes

2016-12-06 Thread Matthew Jacobs (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5288 to look at the new patch set (#3). Change subject: IMPALA-3788: Add flag for Kudu read-your-writes .. IMPALA-3788: Add

[Impala-ASF-CR] IMPALA-4477: Bump Kudu version to latest master (60aa54e)

2016-12-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4477: Bump Kudu version to latest master (60aa54e) .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5369/1/testdata/workloads/functional-

[Impala-ASF-CR] Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE

2016-12-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Replace INTO N BUCKETS with PARTITIONS N in CREATE TABLE .. Patch Set 2: FYI I submitted a private jenkins test run for this change: http://sandbox.jenkins.clo

[Impala-ASF-CR] IMPALA-4477: Bump Kudu version to latest master (60aa54e)

2016-12-06 Thread Matthew Jacobs (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5369 to look at the new patch set (#2). Change subject: IMPALA-4477: Bump Kudu version to latest master (60aa54e) .. IMPALA

[Impala-ASF-CR] IMPALA-4477: Bump Kudu version to latest master (60aa54e)

2016-12-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4477: Bump Kudu version to latest master (60aa54e) .. Patch Set 2: Code-Review+2 rebase, minor conflict in test -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-3788: Add flag for Kudu read-your-writes

2016-12-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3788: Add flag for Kudu read-your-writes .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5288/3/be/src/exec/kudu-scanner.cc File be/src/

<    2   3   4   5   6   7   8   9   10   11   >