Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5317: add DATE_TRUNC() function
..
Patch Set 3: Code-Review+1
(1 comment)
LGTM but would like someone else to check I didn't miss any edge cases
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5857: avoid invalid free of hedged read metrics
..
Patch Set 1:
(1 comment)
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7885
Change subject: IMPALA-5857: avoid invalid free of hedged read metrics
..
IMPALA-5857: avoid invalid free of hedged read metrics
The
Tim Armstrong has uploaded a new patch set (#3).
Change subject: IMPALA-5855: reserve enough memory for preaggs
..
IMPALA-5855: reserve enough memory for preaggs
The calculation in the planner failed to account for the
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5855: reserve enough memory for preaggs
..
Patch Set 2:
Fixed a couple of tests
--
To view, visit http://gerrit.cloudera.org:8080/7871
To unsubscribe,
Tim Armstrong has submitted this change and it was merged.
Change subject: IMPALA-2234: remove workaround from stress test
..
IMPALA-2234: remove workaround from stress test
We believe that IMPALA-2234 has probably been fixed
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2234: remove workaround from stress test
..
Patch Set 1: Verified+1
Code is not exercised by precommit tests. Ran a local stress test to make sure
I
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4856: Rename thrift-deps to gen-deps
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7851
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5830: SET_DENY_RESERVATION_PROBABILITY test
..
Patch Set 4: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/7809
To unsubscribe,
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7809
to look at the new patch set (#3).
Change subject: IMPALA-5830: SET_DENY_RESERVATION_PROBABILITY test
..
IMPALA-5830:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5830: SET_DENY_RESERVATION_PROBABILITY test
..
Patch Set 3: Code-Review+1
carry
--
To view, visit http://gerrit.cloudera.org:8080/7809
To unsubscribe,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5830: SET_DENY_RESERVATION_PROBABILITY test
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7809/2/tests/query_test/test_spilling.py
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4826 Fix wrong scan result on repeated root schema in
Parquet.
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7870/1//COMMIT_MSG
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5855: reserve enough memory for preaggs
..
Patch Set 2:
> I think you may need to update test admission-reject-min-reservation.test now
> too, since
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7874
Change subject: IMPALA-2234: remove workaround from stress test
..
IMPALA-2234: remove workaround from stress test
We believe that
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error
..
Patch Set 1:
(1 comment)
Hello Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7861
to look at the new patch set (#3).
Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error
..
Hello Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7861
to look at the new patch set (#2).
Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error
..
Tim Armstrong has posted comments on this change.
Change subject: Update stress test with admission control rejected messages
..
Patch Set 2:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5317: add DATE_TRUNC() function
..
Patch Set 2:
(15 comments)
Just minor comments, mainly cleanup. I'd also like someone else to look over
the code,
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7861
Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error
..
IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error
Tim Armstrong has posted comments on this change.
Change subject: Update stress test with admission control rejected messages
..
Patch Set 2:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: Update stress test with admission control rejected messages
..
Patch Set 2:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5750: Catch exceptions from boost thread creation
..
Patch Set 3:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/7730/3//COMMIT_MSG
Commit Message:
Tim Armstrong has submitted this change and it was merged.
Change subject: Update stress test with admission control rejected messages
..
Update stress test with admission control rejected messages
IMPALA-5644 added a couple
Tim Armstrong has posted comments on this change.
Change subject: Update stress test with admission control rejected messages
..
Patch Set 1: Verified+1
Precommit test doesn't exercise this. Manually verified by running stress
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3897 Codegen null-aware constant in
PHJ::ProcessBuildBatch()
..
Patch Set 1:
(2 comments)
Looks good to me, only a couple of minor comments.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5840: Don't write page-level statistics in Parquet files.
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7817
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and
compression codec
..
Patch Set 7:
Did you have a change to look at the test failures? They looked
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7834
To unsubscribe,
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7854
Change subject: Update stress test with admission control rejected messages
..
Update stress test with admission control rejected
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection
..
Patch Set 3:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5846: Fix output path for kudu libraries
..
Patch Set 1: Code-Review+2
I took a quick look at the cmake docs and I also don't fully understand what
was
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection
..
Patch Set 2:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection
..
Patch Set 2:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5840: Don't write page-level statistics in Parquet files.
..
Patch Set 1: Code-Review+1
That makes sense, thanks for clarifying.
--
To view, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5840: Don't write page-level statistics in Parquet files.
..
Patch Set 1:
Do any tests need to be modified to reflect this?
--
To view, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3642: Adding backend addresses to error statuses for
scratch failures.
..
Patch Set 1:
We have test coverage for scratch errors in a few places:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5830: SET_DENY_RESERVATION_PROBABILITY test
..
Patch Set 2:
(1 comment)
Tim Armstrong has uploaded a new patch set (#2).
Change subject: IMPALA-5830: SET_DENY_RESERVATION_PROBABILITY test
..
IMPALA-5830: SET_DENY_RESERVATION_PROBABILITY test
Add a targeted test that confirms that setting the query
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7811
Change subject: IMPALA-5827: add test for failure to repartition in hash join
..
IMPALA-5827: add test for failure to repartition in
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7809
Change subject: IMPALA-5830: SET_DENY_RESERVATION_PROBABILITY test
..
IMPALA-5830: SET_DENY_RESERVATION_PROBABILITY test
Add a targeted
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5713: always reserve memory for preaggs
..
Patch Set 6: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/7739
To unsubscribe,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5713: always reserve memory for preaggs
..
Patch Set 5:
I spoke to Mostafa about the change and he agreed it was a good idea.
--
To view, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5648: fix count(*) mem estimate regression
..
Patch Set 5: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/7783
To unsubscribe,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5648: fix count(*) mem estimate regression
..
Patch Set 4:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5648: fix count(*) mem estimate regression
..
Patch Set 3:
(3 comments)
Tim Armstrong has uploaded a new patch set (#4).
Change subject: IMPALA-5648: fix count(*) mem estimate regression
..
IMPALA-5648: fix count(*) mem estimate regression
The metadata-only scan doesn't allocate I/O buffers,
Tim Armstrong has uploaded a new patch set (#3).
Change subject: IMPALA-5648: fix count(*) mem estimate regression
..
IMPALA-5648: fix count(*) mem estimate regression
The metadata-only scan doesn't allocate I/O buffers,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5713: always reserve memory for preaggs
..
Patch Set 5: Code-Review+1
carry +1
--
To view, visit http://gerrit.cloudera.org:8080/7739
To unsubscribe,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5713: always reserve memory for preaggs
..
Patch Set 3:
(2 comments)
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7739
to look at the new patch set (#5).
Change subject: IMPALA-5713: always reserve memory for preaggs
..
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5713: always reserve memory for preaggs
..
Patch Set 3:
I'd be interested to get Mostafa's input on the change.
--
To view, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5713: always reserve memory for preaggs
..
Patch Set 3:
I augmented the commit message a bit to explain the context and details of the
change.
--
To
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7739
to look at the new patch set (#4).
Change subject: IMPALA-5713: always reserve memory for preaggs
..
IMPALA-5713:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests
..
Patch Set 2: Code-Review+2
rebased onto the naaj patch to confirm no merge conflicts
--
To view, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5570: fix spilling null-aware anti join
..
Patch Set 13: Code-Review+2
carry
--
To view, visit http://gerrit.cloudera.org:8080/7367
To unsubscribe,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5570: fix spilling null-aware anti join
..
Patch Set 12: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/7367
To unsubscribe,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5570: fix spilling null-aware anti join
..
Patch Set 12:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7367/12/tests/query_test/test_spilling.py
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests
..
Patch Set 1:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5713: always reserve memory for preaggs
..
Patch Set 3:
(2 comments)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7711
To unsubscribe,
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7787
Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests
..
IMPALA-5780,IMPALA-5779: extra spilling tests
* Test for
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5570: fix spilling null-aware anti join
..
Patch Set 10:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/7367/10//COMMIT_MSG
Commit Message:
Line 7:
Tim Armstrong has uploaded a new patch set (#11).
Change subject: IMPALA-4674: Part 3: fix null-aware anti join
..
IMPALA-4674: Part 3: fix null-aware anti join
Part 2 regressed NAAJ by tightening up the spilling invariants
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
..
Patch Set 4: Code-Review+1
(1 comment)
LGTM aside from one minor thing. Will give others a chance to
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5713: always reserve memory for preaggs
..
Patch Set 2:
(2 comments)
Tim Armstrong has uploaded a new patch set (#3).
Change subject: IMPALA-5713: always reserve memory for preaggs
..
IMPALA-5713: always reserve memory for preaggs
This has two parts:
* Changing the frontend reservation
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5713: always reserve memory for preaggs
..
Patch Set 2:
With the old code, it could essentially always allocate the small buffers and
hash tables
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5713: always reserve memory for preaggs
..
Patch Set 2:
I'm not 100% confident this is the optimal thing to do, but it avoids the
possibility of some
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4674: Part 3: fix null-aware anti join
..
Patch Set 10:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7367/10//COMMIT_MSG
Commit Message:
Line 7:
Tim Armstrong has uploaded a new patch set (#2).
Change subject: IMPALA-5713: always reserve memory for preaggs
..
IMPALA-5713: always reserve memory for preaggs
This has two parts:
* Changing the frontend reservation
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5823: fix SET_DENY_RESERVATION_PROBABILITY
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7771/4//COMMIT_MSG
Commit Message:
PS4, Line
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4674: Part 3: fix null-aware anti join
..
Patch Set 10:
The rebase required splitting out the tests into two categories: those that can
handle the debug
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5823: fix SET_DENY_RESERVATION_PROBABILITY
..
Patch Set 6:
Missed responding to the DCHECK comment. I don't think there's a clear
invariant here. I
Tim Armstrong has uploaded a new patch set (#10).
Change subject: IMPALA-4674: Part 3: fix null-aware anti join
..
IMPALA-4674: Part 3: fix null-aware anti join
Part 2 regressed NAAJ by tightening up the spilling invariants
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5823: fix SET_DENY_RESERVATION_PROBABILITY
..
Patch Set 5: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/7771
To unsubscribe,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5573: Add decimal codegen in text scanner
..
Patch Set 10: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7683
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5352: Age out unused file handles from the cache
..
Patch Set 9: Code-Review+2
Nice!
--
To view, visit http://gerrit.cloudera.org:8080/7640
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5573: Add decimal codegen in text scanner
..
Patch Set 9: Code-Review+2
(2 comments)
One minor request then I'll merge.
Tim Armstrong has uploaded a new patch set (#4).
Change subject: IMPALA-5823: fix SET_DENY_RESERVATION_PROBABILITY
..
IMPALA-5823: fix SET_DENY_RESERVATION_PROBABILITY
Sometimes the client is not open when the debug action
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5823: fix SET_DENY_RESERVATION_PROBABILITY
..
Patch Set 3:
(5 comments)
The check below prevented us trying to set the flag on an unregistered client,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3208: max_row_size option
..
Patch Set 14:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7629/14//COMMIT_MSG
Commit Message:
Line 26: per read and
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5823: fix SET_DENY_RESERVATION_PROBABILITY
..
Patch Set 3:
I rebased onto the large rows change. It turns out of the tests added there
starts failing,
Tim Armstrong has uploaded a new patch set (#3).
Change subject: IMPALA-5823: fix SET_DENY_RESERVATION_PROBABILITY
..
IMPALA-5823: fix SET_DENY_RESERVATION_PROBABILITY
Always set the probability even if the client is not yet
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5573: Add decimal codegen in text scanner
..
Patch Set 8:
Were you able to figure out the problem with static linking?
--
To view, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4990: fix run_tests.py --update_results
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6151
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3208: max_row_size option
..
Patch Set 14: Code-Review+2
carry +2
--
To view, visit http://gerrit.cloudera.org:8080/7629
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3208: max_row_size option
..
Patch Set 14:
Tweaked the tests to use less memory. I can now run them locally in parallel
without OOMing.
--
To view,
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7629
to look at the new patch set (#14).
Change subject: IMPALA-3208: max_row_size option
..
IMPALA-3208: max_row_size
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3208: max_row_size option
..
Patch Set 13:
Oh I see. Seems like a valid optimisation. I'm not sure how broadly applicable
it is and I think there are
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
..
Patch Set 3:
(1 comment)
Could we add a basic test to run a couple of queries (including a DDL
Tim Armstrong has posted comments on this change.
Change subject: Minor comment improvements in buffer-pool.h
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7774
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5352: Age out unused file handles from the cache
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7640
To unsubscribe,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5788: Fix agg node crash when grouping by
nondeterministic exprs
..
Patch Set 3:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3208: max_row_size option
..
Patch Set 13:
It doesn't seem too necessary to increase max_row_size automatically. The
default will fit 32k 16-byte
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3208: max_row_size option
..
Patch Set 13: Code-Review+2
Rebase
--
To view, visit http://gerrit.cloudera.org:8080/7629
To unsubscribe, visit
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7629
to look at the new patch set (#13).
Change subject: IMPALA-3208: max_row_size option
..
IMPALA-3208: max_row_size
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5612: join inversion should factor in parallelism
..
Patch Set 8: Code-Review+2
Missed updating a couple of planner tests
--
To view, visit
Hello Impala Public Jenkins, Bharath Vissapragada, Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7351
to look at the new patch set (#8).
Change subject: IMPALA-5612: join inversion should factor in parallelism
601 - 700 of 2851 matches
Mail list logo
