[kudu-CR] fs: move LBM tests to new test file

Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6485 to review the following change. Change subject: fs: move LBM tests to new test file .. fs: move LBM tests

[kudu-CR] [docs] Add security guide

Dan Burkert has posted comments on this change. Change subject: [docs] Add security guide .. Patch Set 1: Should probably add flume as a known limitation -- To view, visit http://gerrit.cloudera.org:8080/6479 To unsubscribe,

[kudu-CR] [docs] Add security guide

Dan Burkert has posted comments on this change. Change subject: [docs] Add security guide .. Patch Set 1: I forgot to document coarse grained authz, and in particular the ACLs. -- To view, visit http://gerrit.cloudera.org:808

[kudu-CR] kudu-mapreduce: tweak poms

Dan Burkert has posted comments on this change. Change subject: kudu-mapreduce: tweak poms .. Patch Set 2: oops disregard that. -- To view, visit http://gerrit.cloudera.org:8080/6418 To unsubscribe, visit http://gerrit.cloude

[kudu-CR] kudu-mapreduce: tweak poms

Dan Burkert has posted comments on this change. Change subject: kudu-mapreduce: tweak poms .. Patch Set 2: I forgot to document the ACLs. -- To view, visit http://gerrit.cloudera.org:8080/6418 To unsubscribe, visit http://ger

[kudu-CR] [docs] Add security guide

Dan Burkert has posted comments on this change. Change subject: [docs] Add security guide .. Patch Set 1: I won't be able to make changes to this for the next week, so if anyone wants to push changes and/or merge, please feel

[kudu-CR] WIP: tablet: skip over gaps in rowsets using key index instead of bloom

Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6484 to review the following change. Change subject: WIP: tablet: skip over gaps in rowsets using key index instead of bloom ..

[kudu-CR] WIP: interval tree: allow bulk queries

Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6481 to review the following change. Change subject: WIP: interval_tree: allow bulk queries .. WIP: interval_tree:

[kudu-CR] WIP: check for row presence in rowset-wise order

Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6483 to review the following change. Change subject: WIP: check for row presence in rowset-wise order .. WIP: check

[kudu-CR] WIP: rowset tree: add bulk queries

Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6482 to review the following change. Change subject: WIP: rowset_tree: add bulk queries .. WIP: rowset_tree: add bu

[kudu-CR] write transaction: allocate RowOp objects from the arena

Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6480 to review the following change. Change subject: write_transaction: allocate RowOp objects from the arena .. wr

[kudu-CR] [docs] Add security guide

Hello Jean-Daniel Cryans, Adar Dembo, Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6479 to review the following change. Change subject: [docs] Add security guide ..

[kudu-CR] log block manager: use sparse hash map for block map

Adar Dembo has posted comments on this change. Change subject: log_block_manager: use sparse_hash_map for block map .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6471 To unsubscribe, visit htt

[kudu-CR] log block manager: use sparse hash map for block map

Todd Lipcon has posted comments on this change. Change subject: log_block_manager: use sparse_hash_map for block map .. Patch Set 4: (1 comment) looks like using the GNUC macro wasn't useful because clang can still be using l

[kudu-CR] log block manager: use sparse hash map for block map

Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6471 to look at the new patch set (#4). Change subject: log_block_manager: use sparse_hash_map for block map

[kudu-CR] log: simplify log append code path, reduce contention

Todd Lipcon has submitted this change and it was merged. Change subject: log: simplify log append code path, reduce contention .. log: simplify log append code path, reduce contention Previously the log was trying to do some tr

[kudu-CR] log: simplify log append code path, reduce contention

Todd Lipcon has posted comments on this change. Change subject: log: simplify log append code path, reduce contention .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6284 To unsubscribe, visit h

[kudu-CR] kudu-mapreduce: tweak poms

Dan Burkert has posted comments on this change. Change subject: kudu-mapreduce: tweak poms .. Patch Set 2: async is part of the kudu-client public API. If we don't publicly expose kudu-client in the kudu-mapreduce API then we

[kudu-CR] kudu-mapreduce: tweak poms

Todd Lipcon has posted comments on this change. Change subject: kudu-mapreduce: tweak poms .. Patch Set 2: async's part of the public API which means we _cant_ shade it, right? if we shaded it it would be hard/impossible to co

[kudu-CR] log block manager: use sparse hash map for block map

Adar Dembo has posted comments on this change. Change subject: log_block_manager: use sparse_hash_map for block map .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6471/3/thirdparty/patches/sparse

[kudu-CR] log: simplify log append code path, reduce contention

Todd Lipcon has posted comments on this change. Change subject: log: simplify log append code path, reduce contention .. Patch Set 3: thanks for the review. rebasing just to make sure it still passes tests after whatever chang

[kudu-CR] log: simplify log append code path, reduce contention

David Ribeiro Alves has posted comments on this change. Change subject: log: simplify log append code path, reduce contention .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6284 To unsubscribe,

[kudu-CR] log block manager: use sparse hash map for block map

Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6471 to look at the new patch set (#3). Change subject: log_block_manager: use sparse_hash_map for block map

[kudu-CR] rowset metadata: use flat map for column->block mapping

Todd Lipcon has submitted this change and it was merged. Change subject: rowset_metadata: use flat_map for column->block mapping .. rowset_metadata: use flat_map for column->block mapping In a server with around 1T of data, the

[kudu-CR] diskrowset: stop using percpu rwlock

Todd Lipcon has submitted this change and it was merged. Change subject: diskrowset: stop using percpu_rwlock .. diskrowset: stop using percpu_rwlock In a heap analysis of a server with 34K rowsets, I see percpu_rwlocks inside

[kudu-CR] rowset metadata: use flat map for column->block mapping

Todd Lipcon has posted comments on this change. Change subject: rowset_metadata: use flat_map for column->block mapping .. Patch Set 3: Verified+1 issue was a known openssl leak that we havn't figured out yet -- To view, visi

[kudu-CR] rowset metadata: use flat map for column->block mapping

Mike Percy has posted comments on this change. Change subject: rowset_metadata: use flat_map for column->block mapping .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6470 To unsubscribe, visit

[kudu-CR] diskrowset: stop using percpu rwlock

Mike Percy has posted comments on this change. Change subject: diskrowset: stop using percpu_rwlock .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6472 To unsubscribe, visit http://gerrit.cloud

[kudu-CR] kudu-mapreduce: tweak poms

Mike Percy has posted comments on this change. Change subject: kudu-mapreduce: tweak poms .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6418/1//COMMIT_MSG Commit Message: Line 22: fat jar containing kudu-cli

[kudu-CR] [consensus] Add consensus op-level lag metrics

Mike Percy has submitted this change and it was merged. Change subject: [consensus] Add consensus op-level lag metrics .. [consensus] Add consensus op-level lag metrics It may be useful to see how far behind the leaders each fo

[kudu-CR] Update rpc.md with authentication protocol details

Todd Lipcon has posted comments on this change. Change subject: Update rpc.md with authentication protocol details .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6475 To unsubscribe, visit http

[kudu-CR] rowset metadata: use flat map for column->block mapping

Adar Dembo has posted comments on this change. Change subject: rowset_metadata: use flat_map for column->block mapping .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6470 To unsubscribe, visit

[kudu-CR] Update rpc.md with authentication protocol details

Hello Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6475 to review the following change. Change subject: Update rpc.md with authentication protocol details .. U

[kudu-CR] rowset metadata: use flat map for column->block mapping

Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6470 to look at the new patch set (#3). Change subject: rowset_metadata: use flat_map for column->block mapping .

[kudu-CR] log block manager: use sparse hash map for block map

Todd Lipcon has posted comments on this change. Change subject: log_block_manager: use sparse_hash_map for block map .. Patch Set 1: Looks like sparsehash has some issues on gcc 4.8. I put up a pull request against their githu

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

Mike Percy has submitted this change and it was merged. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. KUDU-1330: Add a tool to unsafely recover from loss of majority replicas This

[kudu-CR] [consensus] Add consensus op-level lag metrics

Mike Percy has posted comments on this change. Change subject: [consensus] Add consensus op-level lag metrics .. Patch Set 13: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/6451/12/src/kudu/consensus/consensus

[kudu-CR] [consensus] Add consensus op-level lag metrics

Andrew Wong has posted comments on this change. Change subject: [consensus] Add consensus op-level lag metrics .. Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/6451/12/src/kudu/consensus/consensus_queue.cc Fil

[kudu-CR] [consensus] Add consensus op-level lag metrics

Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6451 to look at the new patch set (#13). Change subject: [consensus] Add consensus op-level lag metrics

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

Mike Percy has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 19: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6066 To

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

Hello David Ribeiro Alves, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6066 to look at the new patch set (#18). Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

Dinesh Bhat has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 16: (9 comments) TFTR Mike again, updated now. http://gerrit.cloudera.org:

[kudu-CR] [consensus] Add consensus op-level lag metrics

David Ribeiro Alves has posted comments on this change. Change subject: [consensus] Add consensus op-level lag metrics .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/6451/12/src/kudu/consensus/consensus_queue

[kudu-CR] log block manager: use sparse hash map for block map

Adar Dembo has posted comments on this change. Change subject: log_block_manager: use sparse_hash_map for block map .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6471 To unsubscribe, visit htt

[kudu-CR] rowset metadata: use flat map for column->block mapping

Adar Dembo has posted comments on this change. Change subject: rowset_metadata: use flat_map for column->block mapping .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6470 To unsubscribe, visit

[kudu-CR] diskrowset: stop using percpu rwlock

Adar Dembo has posted comments on this change. Change subject: diskrowset: stop using percpu_rwlock .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6472 To unsubscribe, visit http://gerrit.cloud

[kudu-CR] rowset metadata: use flat map for column->block mapping

Hello Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6470 to look at the new patch set (#2). Change subject: rowset_metadata: use flat_map for column->block mapping .. rowset_

[kudu-CR] log block manager: use sparse hash map for block map

Todd Lipcon has posted comments on this change. Change subject: log_block_manager: use sparse_hash_map for block map .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6471/1/src/kudu/fs/log_block_manager.h File s

[kudu-CR] log block manager: use sparse hash map for block map

Hello Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6471 to look at the new patch set (#2). Change subject: log_block_manager: use sparse_hash_map for block map .. log_block_

[kudu-CR] diskrowset: stop using percpu rwlock

Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6472 to review the following change. Change subject: diskrowset: stop using percpu_rwlock .. diskrowset: stop using percpu_r

[kudu-CR] rowset metadata: use flat map for column->block mapping

Todd Lipcon has posted comments on this change. Change subject: rowset_metadata: use flat_map for column->block mapping .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6470/1/src/kudu/tablet/rowset_metadata.h

[kudu-CR] [consensus] Add consensus op-level lag metrics

Mike Percy has posted comments on this change. Change subject: [consensus] Add consensus op-level lag metrics .. Patch Set 12: (4 comments) http://gerrit.cloudera.org:8080/#/c/6451/10/src/kudu/consensus/consensus_queue-test.cc

[kudu-CR] rowset metadata: use flat map for column->block mapping

Adar Dembo has posted comments on this change. Change subject: rowset_metadata: use flat_map for column->block mapping .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6470/1/src/kudu/tablet/rowset_metadata.h Fi

[kudu-CR] log block manager: use sparse hash map for block map

Adar Dembo has posted comments on this change. Change subject: log_block_manager: use sparse_hash_map for block map .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6471/1/src/kudu/fs/log_block_manager.h File sr

[kudu-CR] rowset metadata: use flat map for column->block mapping

Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6470 to review the following change. Change subject: rowset_metadata: use flat_map for column->block mapping .. rowset_metad

[kudu-CR] log block manager: use sparse hash map for block map

Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6471 to review the following change. Change subject: log_block_manager: use sparse_hash_map for block map .. log_block_manag

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

Mike Percy has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 17: (8 comments) http://gerrit.cloudera.org:8080/#/c/6066/17//COMMIT_MSG Com

[kudu-CR] generic iterators: avoid holding completed iters in merge/union

David Ribeiro Alves has posted comments on this change. Change subject: generic_iterators: avoid holding completed iters in merge/union .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/6460/1//COMMIT_MSG Commit

[kudu-CR] [consensus] Add consensus op-level lag metrics

Andrew Wong has posted comments on this change. Change subject: [consensus] Add consensus op-level lag metrics .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/6451/11/src/kudu/consensus/consensus_queue.cc File

[kudu-CR] [consensus] Add consensus op-level lag metrics

Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6451 to look at the new patch set (#12). Change subject: [consensus] Add consensus op-level lag metrics

[kudu-CR] [consensus] Add consensus op-level lag metrics

David Ribeiro Alves has posted comments on this change. Change subject: [consensus] Add consensus op-level lag metrics .. Patch Set 11: Code-Review+2 (1 comment) +2 from my side. just a little nit: you can repost and re- +2 fr

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

Mike Percy has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/6066/16/src/kudu/consens

[kudu-CR] Use unique ptr instead of gscoped ptr for blocks, CFileReader

Todd Lipcon has posted comments on this change. Change subject: Use unique_ptr instead of gscoped_ptr for blocks, CFileReader .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6467/1/src/kudu/cfile/cfile_writer.h

[kudu-CR] Use unique ptr instead of gscoped ptr for blocks, CFileReader

Todd Lipcon has submitted this change and it was merged. Change subject: Use unique_ptr instead of gscoped_ptr for blocks, CFileReader .. Use unique_ptr instead of gscoped_ptr for blocks, CFileReader Adar asked me to change thi

[kudu-CR] Use unique ptr instead of gscoped ptr for blocks, CFileReader

Todd Lipcon has posted comments on this change. Change subject: Use unique_ptr instead of gscoped_ptr for blocks, CFileReader .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6467/1/src/kudu/tablet/cfile_set.h F

[kudu-CR] cfile set: reduce memory usage of reader map

Todd Lipcon has submitted this change and it was merged. Change subject: cfile_set: reduce memory usage of reader map .. cfile_set: reduce memory usage of reader map We previously used an unordered_map>. This patch changes to u

[kudu-CR] [consensus] Add consensus op-level lag metrics

Andrew Wong has posted comments on this change. Change subject: [consensus] Add consensus op-level lag metrics .. Patch Set 10: (10 comments) http://gerrit.cloudera.org:8080/#/c/6451/10/src/kudu/consensus/consensus.proto File

[kudu-CR] [consensus] Add consensus op-level lag metrics

Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6451 to look at the new patch set (#11). Change subject: [consensus] Add consensus op-level lag metrics

[kudu-CR] Use unique ptr instead of gscoped ptr for blocks, CFileReader

Adar Dembo has posted comments on this change. Change subject: Use unique_ptr instead of gscoped_ptr for blocks, CFileReader .. Patch Set 1: Code-Review+2 (2 comments) Just spot checked the headers. Looks fine. http://gerrit.

[kudu-CR] cfile set: reduce memory usage of reader map

Adar Dembo has posted comments on this change. Change subject: cfile_set: reduce memory usage of reader map .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6466 To unsubscribe, visit http://gerr

[kudu-CR] cfile set: reduce memory usage of reader map

Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6466 to look at the new patch set (#3). Change subject: cfile_set: reduce memory usage of reader map .. cfil

[kudu-CR] cfile set: reduce memory usage of reader map

Adar Dembo has posted comments on this change. Change subject: cfile_set: reduce memory usage of reader map .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6466/2/src/kudu/tablet/cfile_set.h File