[kudu-CR] [webui] Add templates for tserver webui

2017-10-18 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8307 ) Change subject: [webui] Add templates for tserver webui .. Patch Set 4: Not sure what's been going on with these test

[kudu-CR] WIP: [tls socket] retry IO on SSL ERROR WANT {READ,WRITE}

2017-10-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8328 ) Change subject: WIP: [tls_socket] retry IO on SSL_ERROR_WANT_{READ,WRITE} .. Patch Set 1: Code-Review-1 Missed the non-blocking IO

[kudu-CR] WIP: [tls socket] retry IO on SSL ERROR WANT {READ,WRITE}

2017-10-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8328 ) Change subject: WIP: [tls_socket] retry IO on SSL_ERROR_WANT_{READ,WRITE} .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-18 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Alexey Serbin, Jean-Daniel Cryans, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7053 to look at the new patch set (#29). Change subject: KUDU-2191 (2/n): Hive Metastore client

[kudu-CR] WIP: [tls socket] retry IO on SSL ERROR WANT {READ,WRITE}

2017-10-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8328 ) Change subject: WIP: [tls_socket] retry IO on SSL_ERROR_WANT_{READ,WRITE} .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/7053 ) Change subject: KUDU-2191 (2/n): Hive Metastore client .. Patch Set 27: Dissapointingly, the 10s limit on starting up the mini hms was

[kudu-CR] WIP: [tls socket] retry IO on SSL ERROR WANT {READ,WRITE}

2017-10-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8328 Change subject: WIP: [tls_socket] retry IO on SSL_ERROR_WANT_{READ,WRITE} .. WIP: [tls_socket] retry IO on SSL_ERROR_WANT_{READ,WRITE}

[kudu-CR] WIP: KUDU-2048. consensus: only evict unresponsive nodes if remaining voters are viable

2017-10-18 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8245 to look at the new patch set (#3). Change subject: WIP: KUDU-2048. consensus: only evict unresponsive nodes if remaining voters are viable

[kudu-CR] KUDU-1957: Clarify web UI redaction in --redact flag help

2017-10-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/6755 ) Change subject: KUDU-1957: Clarify web UI redaction in --redact flag help .. Patch Set 6: > Yeah, I think you're right. I'd suggest we not

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/7053 ) Change subject: KUDU-2191 (2/n): Hive Metastore client .. Patch Set 27: (4 comments)

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-18 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Alexey Serbin, Jean-Daniel Cryans, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7053 to look at the new patch set (#28). Change subject: KUDU-2191 (2/n): Hive Metastore client

[kudu-CR] KUDU-1957: Clarify web UI redaction in --redact flag help

2017-10-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/6755 ) Change subject: KUDU-1957: Clarify web UI redaction in --redact flag help .. Patch Set 6: > state it clear in help that 'log' also

[kudu-CR] KUDU-1957: Clarify web UI redaction in --redact flag help

2017-10-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/6755 ) Change subject: KUDU-1957: Clarify web UI redaction in --redact flag help .. Patch Set 6: > state it clear in help that 'log' also

[kudu-CR] KUDU-1957: Clarify web UI redaction in --redact flag help

2017-10-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/6755 ) Change subject: KUDU-1957: Clarify web UI redaction in --redact flag help .. Patch Set 6: > > > Yah, this is basically what I'm thinking.

[kudu-CR] KUDU-1957: Clarify web UI redaction in --redact flag help

2017-10-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/6755 ) Change subject: KUDU-1957: Clarify web UI redaction in --redact flag help .. Patch Set 6: Yeah, I think you're right. I'd suggest we

[kudu-CR] KUDU-1957: Clarify web UI redaction in --redact flag help

2017-10-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/6755 ) Change subject: KUDU-1957: Clarify web UI redaction in --redact flag help .. Patch Set 6: > > Yah, this is basically what I'm thinking. It

[kudu-CR] KUDU-1957: Clarify web UI redaction in --redact flag help

2017-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/6755 ) Change subject: KUDU-1957: Clarify web UI redaction in --redact flag help .. Patch Set 6: > Yah, this is basically what I'm thinking. It

[kudu-CR] KUDU-1957: Clarify web UI redaction in --redact flag help

2017-10-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/6755 ) Change subject: KUDU-1957: Clarify web UI redaction in --redact flag help .. Patch Set 6: > If you're referring specifically to error

[kudu-CR] log block manager: fix Status::Aborted() message

2017-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8282 ) Change subject: log_block_manager: fix Status::Aborted() message .. log_block_manager: fix Status::Aborted() message Updates the

[kudu-CR] KUDU-1957: Clarify web UI redaction in --redact flag help

2017-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/6755 ) Change subject: KUDU-1957: Clarify web UI redaction in --redact flag help .. Patch Set 6: > Do we have any concrete examples of error

[kudu-CR] WIP: KUDU-2048. consensus: only evict unresponsive nodes if remaining voters are viable

2017-10-18 Thread Todd Lipcon (Code Review)
Hello Mike Percy, David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8245 to look at the new patch set (#2). Change subject: WIP: KUDU-2048. consensus: only evict unresponsive nodes if remaining voters are viable

[kudu-CR] KUDU-2191 (5/n): WIP: Hive Metastore notification log event listener

2017-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8313 ) Change subject: KUDU-2191 (5/n): WIP: Hive Metastore notification log event listener .. Patch Set 3: (24 comments)

[kudu-CR] KUDU-1957: Clarify web UI redaction in --redact flag help

2017-10-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/6755 ) Change subject: KUDU-1957: Clarify web UI redaction in --redact flag help .. Patch Set 6: I think it's confusing to invert the flag.

[kudu-CR] Integrate BlockCreationTransaction into MajorDeltaCompaction

2017-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8325 ) Change subject: Integrate BlockCreationTransaction into MajorDeltaCompaction .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-2191 (4/n): WIP: Hive Metastore catalog manager integration

2017-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8312 ) Change subject: KUDU-2191 (4/n): WIP: Hive Metastore catalog manager integration .. Patch Set 3: (36 comments)

[kudu-CR] KUDU-1957: Clarify web UI redaction in --redact flag help

2017-10-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/6755 ) Change subject: KUDU-1957: Clarify web UI redaction in --redact flag help .. Patch Set 6: > > Proposed this on slack, but would like to do

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/7053 ) Change subject: KUDU-2191 (2/n): Hive Metastore client .. Patch Set 27: (6 comments)

[kudu-CR] Integrate BlockCreationTransaction into MajorDeltaCompaction

2017-10-18 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8325 Change subject: Integrate BlockCreationTransaction into MajorDeltaCompaction .. Integrate BlockCreationTransaction into MajorDeltaCompaction

[kudu-CR] KUDU-2191 (5/n): WIP: Hive Metastore notification log event listener

2017-10-18 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8313 to look at the new patch set (#3). Change subject: KUDU-2191 (5/n): WIP: Hive Metastore notification log event listener

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-18 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, Jean-Daniel Cryans, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7053 to look at the new patch set (#27). Change subject: KUDU-2191 (2/n): Hive Metastore client

[kudu-CR] KUDU-2191 (4/n): WIP: Hive Metastore catalog manager integration

2017-10-18 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8312 to look at the new patch set (#3). Change subject: KUDU-2191 (4/n): WIP: Hive Metastore catalog manager integration

[kudu-CR] Add missing comma in Impala CREATE TABLE statement

2017-10-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8321 ) Change subject: Add missing comma in Impala CREATE TABLE statement .. Add missing comma in Impala CREATE TABLE statement When

[kudu-CR] rpc: don't set SO REUSEADDR when binding to ephemeral ports

2017-10-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has abandoned this change. ( http://gerrit.cloudera.org:8080/944 ) Change subject: rpc: don't set SO_REUSEADDR when binding to ephemeral ports .. Abandoned haven't seen these issues in a while -- To view, visit

[kudu-CR] KUDU-2184. arena: fix max buffer size to just less than 1MB

2017-10-18 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8324 to review the following change. Change subject: KUDU-2184. arena: fix max buffer size to just less than 1MB ..

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/7053 ) Change subject: KUDU-2191 (2/n): Hive Metastore client .. Patch Set 24: (6 comments)

[kudu-CR] java: improve javadoc for setRangePartitionColumns

2017-10-18 Thread Hector Camarena (Code Review)
Hello Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8314 to look at the new patch set (#2). Change subject: java: improve javadoc for setRangePartitionColumns

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/7053 ) Change subject: KUDU-2191 (2/n): Hive Metastore client .. Patch Set 26: (5 comments)

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-18 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, Jean-Daniel Cryans, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7053 to look at the new patch set (#26). Change subject: KUDU-2191 (2/n): Hive Metastore client

[kudu-CR] KUDU-2191 (3/n): Add mini HMS option to external mini cluster

2017-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8304 ) Change subject: KUDU-2191 (3/n): Add mini HMS option to external mini cluster .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2191 (4/n): WIP: Hive Metastore catalog manager integration

2017-10-18 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8312 to look at the new patch set (#2). Change subject: KUDU-2191 (4/n): WIP: Hive Metastore catalog manager integration

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/7053 ) Change subject: KUDU-2191 (2/n): Hive Metastore client .. Patch Set 22: (5 comments)

[kudu-CR] KUDU-2191 (3/n): Add mini HMS option to external mini cluster

2017-10-18 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8304 to look at the new patch set (#4). Change subject: KUDU-2191 (3/n): Add mini HMS option to external mini cluster

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-18 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, Jean-Daniel Cryans, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7053 to look at the new patch set (#25). Change subject: KUDU-2191 (2/n): Hive Metastore client

[kudu-CR] [itests] fix flake in TombstonedVoteAfterFailedTabletCopy

2017-10-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8298 ) Change subject: [itests] fix flake in TombstonedVoteAfterFailedTabletCopy .. [itests] fix flake in

[kudu-CR] Add missing comma in Impala CREATE TABLE statement

2017-10-18 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8321 ) Change subject: Add missing comma in Impala CREATE TABLE statement .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Add missing comma in Impala CREATE TABLE statement

2017-10-18 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8321 to review the following change. Change subject: Add missing comma in Impala CREATE TABLE statement .. Add missing

[kudu-CR] KUDU-2055 [part 5]: Coalesce hole punch for LBM

2017-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8162 ) Change subject: KUDU-2055 [part 5]: Coalesce hole punch for LBM .. Patch Set 9: (5 comments) Looks much better!

[kudu-CR] KUDU-2191 (3/n): Add mini HMS option to external mini cluster

2017-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8304 ) Change subject: KUDU-2191 (3/n): Add mini HMS option to external mini cluster .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [tests] clean-up on cluster itest util

2017-10-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8318 ) Change subject: [tests] clean-up on cluster_itest_util .. Patch Set 1: (2 comments)

[kudu-CR] [tests] clean-up on cluster itest util

2017-10-18 Thread Alexey Serbin (Code Review)
Hello Dan Burkert, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8318 to look at the new patch set (#2). Change subject: [tests] clean-up on cluster_itest_util

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/7053 ) Change subject: KUDU-2191 (2/n): Hive Metastore client .. Patch Set 24: (6 comments)

[kudu-CR] [itests] fix flake in TombstonedVoteAfterFailedTabletCopy

2017-10-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8298 ) Change subject: [itests] fix flake in TombstonedVoteAfterFailedTabletCopy .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [itests] fix flake in TombstonedVoteAfterFailedTabletCopy

2017-10-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8298 ) Change subject: [itests] fix flake in TombstonedVoteAfterFailedTabletCopy .. Patch Set 1: (1 comment)

[kudu-CR] [itests] fix flake in TombstonedVoteAfterFailedTabletCopy

2017-10-18 Thread Alexey Serbin (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8298 to look at the new patch set (#2). Change subject: [itests] fix flake in TombstonedVoteAfterFailedTabletCopy

[kudu-CR] KUDU-1957: Clarify web UI redaction in --redact flag help

2017-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/6755 ) Change subject: KUDU-1957: Clarify web UI redaction in --redact flag help .. Patch Set 6: > Proposed this on slack, but would like to do

[kudu-CR] kudu-hive: add provided scope dependency on hadoop-mapreduce-client-common

2017-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8316 ) Change subject: kudu-hive: add provided scope dependency on hadoop-mapreduce-client-common .. Patch Set 2: (1 comment) Fix looks good

[kudu-CR] [client-stress-test] do not crash if client failed

2017-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8310 ) Change subject: [client-stress-test] do not crash if client failed .. [client-stress-test] do not crash if client failed Do not

[kudu-CR] [client-stress-test] do not crash if client failed

2017-10-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8310 ) Change subject: [client-stress-test] do not crash if client failed .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [tests] clean-up on cluster test util

2017-10-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8318 ) Change subject: [tests] clean-up on cluster_test_util .. Patch Set 1: (2 comments) LGTM

[kudu-CR] kudu-hive: add provided scope dependency on hadoop-mapreduce-client-common

2017-10-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. ( http://gerrit.cloudera.org:8080/8316 ) Change subject: kudu-hive: add provided scope dependency on hadoop-mapreduce-client-common .. Patch Set 1: Code-Review+2 -- To

[kudu-CR] kudu-hive: add provided scope dependency on hadoop-mapreduce-client-common

2017-10-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8316 ) Change subject: kudu-hive: add provided scope dependency on hadoop-mapreduce-client-common .. kudu-hive: add provided

[kudu-CR] [tests] clean-up on cluster test util

2017-10-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8318 Change subject: [tests] clean-up on cluster_test_util .. [tests] clean-up on cluster_test_util Updated signature of the AddServer(),

[kudu-CR] If not set, range partition does not default to no range partition Adding clarification to setRangePartitionColumns documentation, stating that if not set, by default the range will be parti

2017-10-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8314 ) Change subject: If not set, range partition does not default to no range partition Adding clarification to setRangePartitionColumns documentation, stating that if not set, by default the range will be

[kudu-CR] fs: move IsDirectoryEmpty to env util

2017-10-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8289 ) Change subject: fs: move IsDirectoryEmpty to env_util .. fs: move IsDirectoryEmpty to env_util I thought I'd need this in a

[kudu-CR] fs: move IsDirectoryEmpty to env util

2017-10-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8289 ) Change subject: fs: move IsDirectoryEmpty to env_util .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] env util: remove ScopedFileDeleter

2017-10-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8288 ) Change subject: env_util: remove ScopedFileDeleter .. env_util: remove ScopedFileDeleter It's a holdover from before

[kudu-CR] [itests] fix flake in TombstonedVoteAfterFailedTabletCopy

2017-10-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8298 ) Change subject: [itests] fix flake in TombstonedVoteAfterFailedTabletCopy .. Patch Set 1: (1 comment)

[kudu-CR] fs: change uuid index from uint16 t to int

2017-10-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8287 ) Change subject: fs: change uuid index from uint16_t to int .. fs: change uuid index from uint16_t to int While the file block

[kudu-CR] fs: change uuid index from uint16 t to int

2017-10-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8287 ) Change subject: fs: change uuid index from uint16_t to int .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] arena: remove second parameter for max buffer size

2017-10-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8269 ) Change subject: arena: remove second parameter for max buffer size .. Patch Set 3: Code-Review+2 Just rebased -- To view, visit

[kudu-CR] arena: remove second parameter for max buffer size

2017-10-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8269 ) Change subject: arena: remove second parameter for max buffer size .. arena: remove second parameter for max buffer size It was

[kudu-CR] twitter-demo: remove module

2017-10-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8302 ) Change subject: twitter-demo: remove module .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8302 To

[kudu-CR] twitter-demo: remove module

2017-10-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8302 ) Change subject: twitter-demo: remove module .. twitter-demo: remove module We haven't used this in any meaningful way in a long

[kudu-CR] fs: move IsDirectoryEmpty to env util

2017-10-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8289 ) Change subject: fs: move IsDirectoryEmpty to env_util .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] kudu-hive: add provided scope dependency on hadoop-mapreduce-client-common

2017-10-18 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8316 to review the following change. Change subject: kudu-hive: add provided scope dependency on hadoop-mapreduce-client-common

[kudu-CR] [webui] Add templates for tserver webui

2017-10-18 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8307 to look at the new patch set (#4). Change subject: [webui] Add templates for tserver webui .. [webui] Add

[kudu-CR] [webui] Add templates for tserver webui

2017-10-18 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8307 to look at the new patch set (#3). Change subject: [webui] Add templates for tserver webui .. [webui] Add

[kudu-CR] [webui] Add templates for tserver webui

2017-10-18 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8307 ) Change subject: [webui] Add templates for tserver webui .. Patch Set 2: (3 comments)

[kudu-CR] [webui] Add templates for tserver webui

2017-10-18 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8307 to look at the new patch set (#2). Change subject: [webui] Add templates for tserver webui .. [webui] Add

[kudu-CR] KUDU-2055 [part 5]: Coalesce hole punch for LBM

2017-10-18 Thread Hao Hao (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8162 to look at the new patch set (#9). Change subject: KUDU-2055 [part 5]: Coalesce hole punch for LBM