[kudu-CR] tablet: encapsulate common iterator options

2018-07-17 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10802 ) Change subject: tablet: encapsulate common iterator options .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] tablet: encapsulate common iterator options

2018-07-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10802 ) Change subject: tablet: encapsulate common iterator options .. Patch Set 6: Verified+1 Overriding Jenkins, unrelated test failure. --

[kudu-CR] memrowset: support iteration with is deleted virtual column

2018-07-17 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10968 to look at the new patch set (#2). Change subject: memrowset: support iteration with is_deleted virtual column

[kudu-CR] memrowset: support iteration with omit deleted rows�

2018-07-17 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10929 ) Change subject: memrowset: support iteration with omit_deleted_rows=false .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] memrowset: support iteration with snap to exclude

2018-07-17 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10926 ) Change subject: memrowset: support iteration with snap_to_exclude .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] memrowset: support iteration with omit deleted rows�

2018-07-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10929 ) Change subject: memrowset: support iteration with omit_deleted_rows=false .. Patch Set 2: Verified+1 Overriding Jenkins, unrelated test

[kudu-CR] memrowset: support iteration with snap to exclude

2018-07-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10926 ) Change subject: memrowset: support iteration with snap_to_exclude .. Patch Set 5: Verified+1 Overriding Jenkins, unrelated test failure.

[kudu-CR] mvn: Remove from

2018-07-17 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10957 ) Change subject: mvn: Remove from .. Patch Set 2: > I suppose, though it adds potential for a new foot-gun if the directory above >

[kudu-CR] [DOCS] Updated the max and recommended numbers of tablets per server

2018-07-17 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10969 Change subject: [DOCS] Updated the max and recommended numbers of tablets per server .. [DOCS] Updated the max and recommended numbers

[kudu-CR] memrowset: support iteration with is deleted virtual column

2018-07-17 Thread Adar Dembo (Code Review)
Hello Mike Percy, Grant Henke, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10968 to review the following change. Change subject: memrowset: support iteration with is_deleted virtual column

[kudu-CR] [logging] fix logging init if linking kudu client library

2018-07-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10956 ) Change subject: [logging] fix logging init if linking kudu client library .. [logging] fix logging init if linking kudu client

[kudu-CR](branch-1.6.x) KUDU-2312: Scan predicate application ordering is non-deterministic

2018-07-17 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10945 ) Change subject: KUDU-2312: Scan predicate application ordering is non-deterministic .. KUDU-2312: Scan predicate application

[kudu-CR](branch-1.6.x) KUDU-2312: Scan predicate application ordering is non-deterministic

2018-07-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10945 ) Change subject: KUDU-2312: Scan predicate application ordering is non-deterministic .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [logging] fix logging init if linking kudu client library

2018-07-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10956 ) Change subject: [logging] fix logging init if linking kudu client library .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR](branch-1.7.x) KUDU-2447 Fix TS crashed with "NONE predicate can not be pushed into key"

2018-07-17 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10963 ) Change subject: KUDU-2447 Fix TS crashed with "NONE predicate can not be pushed into key" .. KUDU-2447 Fix TS crashed with

[kudu-CR] [logging] fix logging init if linking kudu client library

2018-07-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10956 ) Change subject: [logging] fix logging init if linking kudu client library .. Patch Set 1: (1 comment)

[kudu-CR] Add support for Java dist-tests on Jenkins

2018-07-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10954 ) Change subject: Add support for Java dist-tests on Jenkins .. Patch Set 5: Are distributed Java tests retried on failure? If not, we

[kudu-CR] Add support for Java dist-tests on Jenkins

2018-07-17 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10954 ) Change subject: Add support for Java dist-tests on Jenkins .. Patch Set 5: I am not sure we should merge this yet given we don't have

[kudu-CR] Add support for Java dist-tests on Jenkins

2018-07-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10954 ) Change subject: Add support for Java dist-tests on Jenkins .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.7.x) KUDU-2447 Fix TS crashed with "NONE predicate can not be pushed into key"

2018-07-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10963 ) Change subject: KUDU-2447 Fix TS crashed with "NONE predicate can not be pushed into key" .. Patch Set 1: Code-Review+2 -- To view,

[kudu-CR](branch-1.7.x) KUDU-2447 Fix TS crashed with "NONE predicate can not be pushed into key"

2018-07-17 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10963 Change subject: KUDU-2447 Fix TS crashed with "NONE predicate can not be pushed into key" .. KUDU-2447 Fix TS crashed with "NONE

[kudu-CR] [java] Add extra info about using multiple clients

2018-07-17 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10962 Change subject: [java] Add extra info about using multiple clients .. [java] Add extra info about using multiple clients The

[kudu-CR] mvn: Remove from

2018-07-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10957 ) Change subject: mvn: Remove from .. Patch Set 2: > That said, I don't think removing this was a mistake, as the build is fine >

[kudu-CR] KUDU-2507: use FBM for KuduMiniCluster

2018-07-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10961 ) Change subject: KUDU-2507: use FBM for KuduMiniCluster .. Patch Set 1: > Patch Set 1: > > > I agree with the sentiment, but at the same

[kudu-CR] WIP Add error handling to KuduBackup DONT BUILD KuduBackup will attempt to backup every table. If any one table fails the entire job will fail.

2018-07-17 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10941 ) Change subject: WIP Add error handling to KuduBackup DONT_BUILD KuduBackup will attempt to backup every table. If any one table fails the entire job will fail.

[kudu-CR] KUDU-2507: use FBM for KuduMiniCluster

2018-07-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10961 ) Change subject: KUDU-2507: use FBM for KuduMiniCluster .. Patch Set 1: > I agree with the sentiment, but at the same time, the point of

[kudu-CR] mvn: Remove from

2018-07-17 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10957 ) Change subject: mvn: Remove from .. Patch Set 2: I'm not really sure I agree with your interpretation though because if you look at

[kudu-CR] KUDU-2437 Split a tablet into primary key ranges by size

2018-07-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10406 ) Change subject: KUDU-2437 Split a tablet into primary key ranges by size .. Patch Set 21: (8 comments) I've got a high-level question

[kudu-CR] mvn: Remove from

2018-07-17 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10957 ) Change subject: mvn: Remove from .. Patch Set 2: > Seems like an empty relativePath (what we already had) provides the behavior > you

[kudu-CR] KUDU-2507: use FBM for KuduMiniCluster

2018-07-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10961 ) Change subject: KUDU-2507: use FBM for KuduMiniCluster .. Patch Set 1: > Patch Set 1: > > hrm, I'm not sure I agree with this change.

[kudu-CR] KUDU-2507: use FBM for KuduMiniCluster

2018-07-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10961 ) Change subject: KUDU-2507: use FBM for KuduMiniCluster .. Patch Set 1: hrm, I'm not sure I agree with this change. Shouldn't we use our

[kudu-CR] KUDU-2507: use FBM for KuduMiniCluster

2018-07-17 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10961 Change subject: KUDU-2507: use FBM for KuduMiniCluster .. KUDU-2507: use FBM for KuduMiniCluster The log block manager isn't supported

[kudu-CR] KUDU-2437 Split a tablet into primary key ranges by size

2018-07-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10406 ) Change subject: KUDU-2437 Split a tablet into primary key ranges by size .. Patch Set 21: (2 comments) This is looking really good!

[kudu-CR] Add support for Java dist-tests on Jenkins

2018-07-17 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10954 to look at the new patch set (#5). Change subject: Add support for Java dist-tests on Jenkins

[kudu-CR] Add support for running Java tests in dist-test

2018-07-17 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10907 to look at the new patch set (#7). Change subject: Add support for running Java tests in dist-test

[kudu-CR] Add support for running Java tests in dist-test

2018-07-17 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10907 ) Change subject: Add support for running Java tests in dist-test .. Patch Set 6: (3 comments)

[kudu-CR] Add support for Java dist-tests on Jenkins

2018-07-17 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10954 ) Change subject: Add support for Java dist-tests on Jenkins .. Patch Set 4: (2 comments)

[kudu-CR] WIP Add error handling to KuduBackup DONT BUILD KuduBackup will attempt to backup every table. If any one table fails the entire job will fail.

2018-07-17 Thread Tony Foerster (Code Review)
Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10941 to look at the new patch set (#2). Change subject: WIP Add error handling to KuduBackup DONT_BUILD KuduBackup will attempt to backup every table. If any one table fails

[kudu-CR] WIP/repro reproduce 1-off errors in TestKuduBackup

2018-07-17 Thread Tony Foerster (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10959 to look at the new patch set (#2). Change subject: WIP/repro reproduce 1-off errors in TestKuduBackup .. WIP/repro

[kudu-CR] WIP/repro reproduce 1-off errors in TestKuduBackup

2018-07-17 Thread Tony Foerster (Code Review)
Tony Foerster has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10959 Change subject: WIP/repro reproduce 1-off errors in TestKuduBackup .. WIP/repro reproduce 1-off errors in TestKuduBackup Three of 4