[kudu-CR] tool: fixes for kudu local replica dump rowset

2019-04-09 Thread Adar Dembo (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12976 to look at the new patch set (#4). Change subject: tool: fixes for kudu local_replica dump rowset

[kudu-CR] tool: fixes for kudu local replica dump rowset

2019-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12976 ) Change subject: tool: fixes for kudu local_replica dump rowset .. Patch Set 2: (2 comments)

[kudu-CR] tool: fixes for kudu local replica dump rowset

2019-04-09 Thread Adar Dembo (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12976 to look at the new patch set (#3). Change subject: tool: fixes for kudu local_replica dump rowset

[kudu-CR] generic iterators: switch MergeIterator to intrusive list of states

2019-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12944 ) Change subject: generic_iterators: switch MergeIterator to intrusive list of states .. generic_iterators: switch MergeIterator

[kudu-CR] generic iterators: implement three-heap merge algorithm

2019-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12947 ) Change subject: generic_iterators: implement three-heap merge algorithm .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] generic iterators: implement three-heap merge algorithm

2019-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12947 ) Change subject: generic_iterators: implement three-heap merge algorithm .. Patch Set 7: Verified+1 Overriding Jenkins, Java flake. --

[kudu-CR] [docs] Remove flume kerberos limitation

2019-04-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12978 ) Change subject: [docs] Remove flume kerberos limitation .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] tools: escape brackets when generating XML

2019-04-09 Thread Andrew Wong (Code Review)
Hello Will Berkeley, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12981 to look at the new patch set (#2). Change subject: tools: escape brackets when generating XML

[kudu-CR] [docs] Remove flume kerberos limitation

2019-04-09 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12978 Change subject: [docs] Remove flume kerberos limitation .. [docs] Remove flume kerberos limitation Removes the flume kerberos limitation

[kudu-CR] tools: escape brackets when generating XML

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12981 Change subject: tools: escape brackets when generating XML .. tools: escape brackets when generating XML When building the site, we

[kudu-CR] tool: fixes for kudu local replica dump rowset

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12976 ) Change subject: tool: fixes for kudu local_replica dump rowset .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-2689: Made PartialRow setters use a fluent-style.

2019-04-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12949 ) Change subject: KUDU-2689: Made PartialRow setters use a fluent-style. .. Patch Set 1: > Agreed. Is there something off the shelf we

[kudu-CR] [docs] Add maximum tablet size recommendations

2019-04-09 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12979 Change subject: [docs] Add maximum tablet size recommendations .. [docs] Add maximum tablet size recommendations Based primarily on the

[kudu-CR] generic iterators: switch MergeIterator to intrusive list of states

2019-04-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12944 ) Change subject: generic_iterators: switch MergeIterator to intrusive list of states .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] tool: fixes for kudu local replica dump rowset

2019-04-09 Thread Adar Dembo (Code Review)
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12976 to look at the new patch set (#2). Change subject: tool: fixes for kudu local_replica dump rowset

[kudu-CR] remove schema copies from RowBlock and RowBuilder

2019-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12907 ) Change subject: remove schema copies from RowBlock and RowBuilder .. remove schema copies from RowBlock and RowBuilder AFAICT

[kudu-CR] generic iterators: implement three-heap merge algorithm

2019-04-09 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12947 to look at the new patch set (#7). Change subject: generic_iterators: implement three-heap merge algorithm

[kudu-CR] tool: fixes for kudu local replica dump rowset

2019-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12976 Change subject: tool: fixes for kudu local_replica dump rowset .. tool: fixes for kudu local_replica dump rowset This patch makes several

[kudu-CR] experiments: merge iterator optimization tests

2019-04-09 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12587 to look at the new patch set (#3). Change subject: experiments: merge iterator optimization tests ..

[kudu-CR] tool: perf tablet scan action

2019-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12945 ) Change subject: tool: perf tablet_scan action .. tool: perf tablet_scan action I found this action useful for benchmarking raw

[kudu-CR] sentry: populate TablePrivilegePBs

2019-04-09 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12941 ) Change subject: sentry: populate TablePrivilegePBs .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12941

[kudu-CR] remove schema copies from RowBlock and RowBuilder

2019-04-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12907 ) Change subject: remove schema copies from RowBlock and RowBuilder .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2449: "Tablet server addition" best practices

2019-04-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12969 ) Change subject: KUDU-2449: "Tablet server addition" best practices .. Patch Set 7: Code-Review+2 Thanks Mitch! -- To view, visit

[kudu-CR] sentry: populate TablePrivilegePBs

2019-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12941 ) Change subject: sentry: populate TablePrivilegePBs .. Patch Set 7: Code-Review+1 -- To view, visit

[kudu-CR] sentry: populate TablePrivilegePBs

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12941 ) Change subject: sentry: populate TablePrivilegePBs .. Patch Set 7: (1 comment)

[kudu-CR] sentry: populate TablePrivilegePBs

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12941 ) Change subject: sentry: populate TablePrivilegePBs .. Patch Set 5: -Verified Rebased -- To view, visit

[kudu-CR] sentry: populate TablePrivilegePBs

2019-04-09 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12941 to look at the new patch set (#6). Change subject: sentry: populate TablePrivilegePBs

[kudu-CR] KUDU-2449: "Tablet server addition" best practices

2019-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12969 ) Change subject: KUDU-2449: "Tablet server addition" best practices .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2449: "Tablet server addition" best practices

2019-04-09 Thread Mitch Barnett (Code Review)
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12969 to look at the new patch set (#7). Change subject: KUDU-2449: "Tablet server addition" best practices

[kudu-CR] KUDU-2450: "Tablet server addition" best practices

2019-04-09 Thread Mitch Barnett (Code Review)
Mitch Barnett has posted comments on this change. ( http://gerrit.cloudera.org:8080/12969 ) Change subject: KUDU-2450: "Tablet server addition" best practices .. Patch Set 4: (5 comments)

[kudu-CR] tool: perf tablet scan action

2019-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12945 ) Change subject: tool: perf tablet_scan action .. Patch Set 4: Verified+1 Overriding Jenkins, known flake. -- To view, visit

[kudu-CR] tool: perf tablet scan action

2019-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12945 ) Change subject: tool: perf tablet_scan action .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu

[kudu-CR] KUDU-2449: "Tablet server addition" best practices

2019-04-09 Thread Mitch Barnett (Code Review)
Mitch Barnett has posted comments on this change. ( http://gerrit.cloudera.org:8080/12969 ) Change subject: KUDU-2449: "Tablet server addition" best practices .. Patch Set 5: (1 comment) > Patch Set 5: > > (1 comment) > >

[kudu-CR] KUDU-2449: "Tablet server addition" best practices

2019-04-09 Thread Mitch Barnett (Code Review)
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12969 to look at the new patch set (#6). Change subject: KUDU-2449: "Tablet server addition" best practices

[kudu-CR] KUDU-2450: "Tablet server addition" best practices

2019-04-09 Thread Mitch Barnett (Code Review)
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12969 to look at the new patch set (#5). Change subject: KUDU-2450: "Tablet server addition" best practices

[kudu-CR] KUDU-2450: "Tablet server addition" best practices

2019-04-09 Thread Mitch Barnett (Code Review)
Mitch Barnett has posted comments on this change. ( http://gerrit.cloudera.org:8080/12969 ) Change subject: KUDU-2450: "Tablet server addition" best practices .. Patch Set 4: (7 comments)

[kudu-CR] KUDU-2450: "Tablet server addition" best practices

2019-04-09 Thread Mitch Barnett (Code Review)
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12969 to look at the new patch set (#4). Change subject: KUDU-2450: "Tablet server addition" best practices

[kudu-CR] generic iterators: switch MergeIterator to intrusive list of states

2019-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12944 ) Change subject: generic_iterators: switch MergeIterator to intrusive list of states .. Patch Set 3: > Patch Set 3: > > I experimented

[kudu-CR] generic iterators: implement three-heap merge algorithm

2019-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12947 ) Change subject: generic_iterators: implement three-heap merge algorithm .. Patch Set 6: I experimented with the different boost heaps

[kudu-CR] generic iterators: switch MergeIterator to intrusive list of states

2019-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12944 ) Change subject: generic_iterators: switch MergeIterator to intrusive list of states .. Patch Set 3: I experimented with the different

[kudu-CR] generic iterators: implement three-heap merge algorithm

2019-04-09 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12947 to look at the new patch set (#6). Change subject: generic_iterators: implement three-heap merge algorithm

[kudu-CR] sentry authz provider-test: fix logical conflict

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: sentry_authz_provider-test: fix logical conflict .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12971 To unsubscribe,

[kudu-CR] sentry authz provider-test: fix logical conflict

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12971 ) Change subject: sentry_authz_provider-test: fix logical conflict .. Patch Set 1: Verified+1 Known flake. -- To view, visit

[kudu-CR] KUDU-2449: "Tablet server addition" best practices

2019-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12969 ) Change subject: KUDU-2449: "Tablet server addition" best practices .. Patch Set 3: (7 comments)

[kudu-CR] KUDU-2449: "Tablet server addition" best practices

2019-04-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12969 ) Change subject: KUDU-2449: "Tablet server addition" best practices .. Patch Set 3: (5 comments)

[kudu-CR] KUDU-2449: "Tablet server addition" best practices

2019-04-09 Thread Mitch Barnett (Code Review)
Mitch Barnett has posted comments on this change. ( http://gerrit.cloudera.org:8080/12969 ) Change subject: KUDU-2449: "Tablet server addition" best practices .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2449: "Tablet server addition" best practices

2019-04-09 Thread Mitch Barnett (Code Review)
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12969 to look at the new patch set (#3). Change subject: KUDU-2449: "Tablet server addition" best practices

[kudu-CR] sentry authz provider-test: fix logical conflict

2019-04-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12971 ) Change subject: sentry_authz_provider-test: fix logical conflict .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] sentry authz provider-test: fix logical conflict

2019-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12971 ) Change subject: sentry_authz_provider-test: fix logical conflict .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] sentry authz provider-test: fix logical conflict

2019-04-09 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12971 to review the following change. Change subject: sentry_authz_provider-test: fix logical conflict ..

[kudu-CR] sentry: populate TablePrivilegePBs

2019-04-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12941 ) Change subject: sentry: populate TablePrivilegePBs .. Patch Set 5: Code-Review+2 (1 comment)

[kudu-CR] remove schema copies from RowBlock and RowBuilder

2019-04-09 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Mike Percy, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12907 to look at the new patch set (#6). Change subject: remove schema copies from RowBlock and RowBuilder

[kudu-CR] generic iterators: switch MergeIterator to intrusive list of states

2019-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12944 ) Change subject: generic_iterators: switch MergeIterator to intrusive list of states .. Patch Set 1: (1 comment)

[kudu-CR] tool: perf tablet scan action

2019-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12945 ) Change subject: tool: perf tablet_scan action .. Patch Set 2: (3 comments)

[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12966 ) Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test .. KUDU-2764: reduce runtime of

[kudu-CR] tool: perf tablet scan action

2019-04-09 Thread Adar Dembo (Code Review)
Hello Mike Percy, Andrew Wong, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12945 to look at the new patch set (#3). Change subject: tool: perf tablet_scan action

[kudu-CR] generic iterators: switch MergeIterator to intrusive list of states

2019-04-09 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12944 to look at the new patch set (#2). Change subject: generic_iterators: switch MergeIterator to intrusive list of states

[kudu-CR] [docs] Adjust latency and bandwidth limitations

2019-04-09 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12970 Change subject: [docs] Adjust latency and bandwidth limitations .. [docs] Adjust latency and bandwidth limitations Adjusts the

[kudu-CR] [HaClient] introduce client metrics

2019-04-09 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12951 ) Change subject: [HaClient] introduce client metrics .. Patch Set 7: (1 comment)

[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test

2019-04-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12966 ) Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test .. Patch Set 4: Code-Review+2 (1 comment)

[kudu-CR] [HaClient] introduce client metrics

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12951 ) Change subject: [HaClient] introduce client metrics .. Patch Set 6: Code-Review+2 (1 comment)

[kudu-CR] [SentryAuthzProvider] deduplicate RPCs to Sentry

2019-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12967 ) Change subject: [SentryAuthzProvider] deduplicate RPCs to Sentry .. Patch Set 2: (8 comments)

[kudu-CR] Created 'Adding tablet server best practices' per KUDU-2449.

2019-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12969 ) Change subject: Created 'Adding tablet server best practices' per KUDU-2449. .. Patch Set 2: (3 comments)

[kudu-CR] WIP [master] introduced SentryPrivilegesFetcher

2019-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12833 ) Change subject: WIP [master] introduced SentryPrivilegesFetcher .. Patch Set 11: (1 comment)

[kudu-CR] [HaClient] introduce client metrics

2019-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12951 ) Change subject: [HaClient] introduce client metrics .. Patch Set 6: Code-Review+1 -- To view, visit

[kudu-CR] tool: perf tablet scan action

2019-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12945 ) Change subject: tool: perf tablet_scan action .. Patch Set 2: (3 comments)

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 11: (3 comments)

[kudu-CR] WIP [master] introduced SentryPrivilegesFetcher

2019-04-09 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12833 to look at the new patch set (#11). Change subject: WIP [master] introduced SentryPrivilegesFetcher

[kudu-CR] [HaClient] introduce client metrics

2019-04-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12951 ) Change subject: [HaClient] introduce client metrics .. Patch Set 5: (2 comments)

[kudu-CR] tool: perf tablet scan action

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12945 ) Change subject: tool: perf tablet_scan action .. Patch Set 2: (3 comments)

[kudu-CR] sentry: sanitize and parse privileges from Sentry

2019-04-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12919 ) Change subject: sentry: sanitize and parse privileges from Sentry .. Patch Set 11: (11 comments)

[kudu-CR] [SentryAuthzProvider] deduplicate RPCs to Sentry

2019-04-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12967 to look at the new patch set (#2). Change subject: [SentryAuthzProvider] deduplicate RPCs to Sentry

[kudu-CR] [HaClient] introduce client metrics

2019-04-09 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12951 to look at the new patch set (#6). Change subject: [HaClient] introduce client metrics

[kudu-CR] [SentryAuthzProvider] deduplicate RPCs to Sentry

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12967 ) Change subject: [SentryAuthzProvider] deduplicate RPCs to Sentry .. Patch Set 1: (6 comments)

[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test

2019-04-09 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12966 ) Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test .. Patch Set 4: Code-Review+2 (1 comment)

[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12966 ) Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test

2019-04-09 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12966 ) Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test .. Patch Set 4: (1 comment)

[kudu-CR] sentry: populate TablePrivilegePBs

2019-04-09 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12941 ) Change subject: sentry: populate TablePrivilegePBs .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12941

[kudu-CR] Created 'Adding tablet server best practices' per KUDU-2449.

2019-04-09 Thread Mitch Barnett (Code Review)
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12969 to look at the new patch set (#2). Change subject: Created 'Adding tablet server best practices' per KUDU-2449.

[kudu-CR] Created 'Adding tablet server best practices' per KUDU-2449.

2019-04-09 Thread Mitch Barnett (Code Review)
Hello Will Berkeley, Adar Dembo, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12969 to review the following change. Change subject: Created 'Adding tablet server best practices' per KUDU-2449.

[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test

2019-04-09 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12966 to look at the new patch set (#4). Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test

[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test

2019-04-09 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12966 to look at the new patch set (#2). Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test

[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12966 ) Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test .. Patch Set 3: > Patch Set 3: > > (2 comments) Actually after

[kudu-CR] WIP [master] introduced SentryPrivilegesFetcher

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12833 ) Change subject: WIP [master] introduced SentryPrivilegesFetcher .. Patch Set 10: (1 comment)

[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12966 ) Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test .. Patch Set 3: (2 comments)

[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test

2019-04-09 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12966 to look at the new patch set (#3). Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test

[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test

2019-04-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12966 ) Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test .. Patch Set 1: (1 comment)

[kudu-CR] generic iterators: switch MergeIterator to intrusive list of states

2019-04-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12944 ) Change subject: generic_iterators: switch MergeIterator to intrusive list of states .. Patch Set 1: (1 comment)

[kudu-CR] remove schema copies from RowBlock and RowBuilder

2019-04-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12907 ) Change subject: remove schema copies from RowBlock and RowBuilder .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test

2019-04-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12966 ) Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test

2019-04-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12966 ) Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test .. Patch Set 1: Code-Review+1 > > Patch Set 1: > > > > How

[kudu-CR] sentry: populate TablePrivilegePBs

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12941 ) Change subject: sentry: populate TablePrivilegePBs .. Patch Set 5: Verified+1 A couple of Java flakies. -- To view, visit

[kudu-CR] sentry: populate TablePrivilegePBs

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: sentry: populate TablePrivilegePBs .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12941 To unsubscribe, visit

[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test

2019-04-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12966 ) Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test .. Patch Set 1: How important is this change? Do you want to

[kudu-CR] WIP [master] introduced SentryPrivilegesFetcher

2019-04-09 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12833 to look at the new patch set (#10). Change subject: WIP [master] introduced SentryPrivilegesFetcher

[kudu-CR] [SentryAuthzProvider] deduplicate RPCs to Sentry

2019-04-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12967 Change subject: [SentryAuthzProvider] deduplicate RPCs to Sentry .. [SentryAuthzProvider] deduplicate RPCs to Sentry With this patch,

[kudu-CR] sentry: populate TablePrivilegePBs

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12941 ) Change subject: sentry: populate TablePrivilegePBs .. Patch Set 5: (6 comments)

[kudu-CR] KUDU-2764: reduce runtime of sentry authz provider-test

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12966 Change subject: KUDU-2764: reduce runtime of sentry_authz_provider-test .. KUDU-2764: reduce runtime of sentry_authz_provider-test This

[kudu-CR] sentry: populate TablePrivilegePBs

2019-04-09 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12941 to look at the new patch set (#5). Change subject: sentry: populate TablePrivilegePBs

[kudu-CR] authz: authorize ListTablets

2019-04-09 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11752 ) Change subject: authz: authorize ListTablets .. authz: authorize ListTablets See the comment in tablet_service.h for details.

  1   2   >