[kudu-CR] webserver: add support for Knox URL rewriting

2019-11-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14573 ) Change subject: webserver: add support for Knox URL rewriting .. Patch Set 7: Code-Review+2 LGTM, my testing suggestions are targeting

[kudu-CR] webserver: add support for Knox URL rewriting

2019-11-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14573 ) Change subject: webserver: add support for Knox URL rewriting .. Patch Set 7: (2 comments)

[kudu-CR] webserver: add support for Knox URL rewriting

2019-11-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14573 ) Change subject: webserver: add support for Knox URL rewriting .. Patch Set 6: (2 comments)

[kudu-CR] thirdparty: add gumbo and gumbo-query

2019-11-01 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14572 to look at the new patch set (#5). Change subject: thirdparty: add gumbo and gumbo-query ..

[kudu-CR] thirdparty: add gumbo and gumbo-query

2019-11-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14572 ) Change subject: thirdparty: add gumbo and gumbo-query .. Patch Set 4: (1 comment)

[kudu-CR] thirdparty: clean up LICENSE.txt

2019-11-01 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/14619 to review the following change. Change subject: thirdparty: clean up LICENSE.txt .. thirdparty: clean

[kudu-CR] [fs] gscoped ptr -> unique ptr

2019-11-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14618 ) Change subject: [fs] gscoped_ptr -> unique_ptr .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14618 To

[kudu-CR] [fs] gscoped ptr -> unique ptr

2019-11-01 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14618 ) Change subject: [fs] gscoped_ptr -> unique_ptr .. [fs] gscoped_ptr -> unique_ptr Replace all existing `gscoped_ptr` in the fs

[kudu-CR] [docs] add info on KUDU-2990 into known issues

2019-11-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14616 ) Change subject: [docs] add info on KUDU-2990 into known issues .. Patch Set 2: (1 comment)

[kudu-CR] [RELEASING.adoc] clarify on sending announcement email

2019-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14617 ) Change subject: [RELEASING.adoc] clarify on sending announcement email .. [RELEASING.adoc] clarify on sending announcement

[kudu-CR] [RELEASING.adoc] clarify on sending announcement email

2019-11-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14617 ) Change subject: [RELEASING.adoc] clarify on sending announcement email .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [fs] gscoped ptr -> unique ptr

2019-11-01 Thread Anonymous Coward (Code Review)
lingbi...@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14618 Change subject: [fs] gscoped_ptr -> unique_ptr .. [fs] gscoped_ptr -> unique_ptr Replace all existing `gscoped_ptr` in the fs

[kudu-CR] [RELEASING.adoc] clarify on sending announcement email

2019-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14617 Change subject: [RELEASING.adoc] clarify on sending announcement email .. [RELEASING.adoc] clarify on sending announcement email

[kudu-CR] [RELEASING.adoc] clarify on sending announcement email

2019-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14617 ) Change subject: [RELEASING.adoc] clarify on sending announcement email .. Patch Set 1: (1 comment)

[kudu-CR] [docs] add info on KUDU-2990 into known issues

2019-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14616 ) Change subject: [docs] add info on KUDU-2990 into known issues .. Patch Set 2: Verified+1 Unrelated test failures: this is a doc-only

[kudu-CR] [docs] add info on KUDU-2990 into known issues

2019-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [docs] add info on KUDU-2990 into known issues .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/14616 To unsubscribe,

[kudu-CR] log: separate out allocation logic

2019-11-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14479 ) Change subject: log: separate out allocation logic .. Patch Set 5: (3 comments)

[kudu-CR] log: separate out allocation logic

2019-11-01 Thread Andrew Wong (Code Review)
Hello Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14479 to look at the new patch set (#5). Change subject: log: separate out allocation logic .. log: separate out

[kudu-CR] [docs] add info on KUDU-2990 into known issues

2019-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14616 ) Change subject: [docs] add info on KUDU-2990 into known issues .. Patch Set 1: (2 comments)

[kudu-CR] [docs] add info on KUDU-2990 into known issues

2019-11-01 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Greg Solovyev, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14616 to look at the new patch set (#2). Change subject: [docs] add info on KUDU-2990 into known issues

[kudu-CR] [docs] add info on KUDU-2990 into known issues

2019-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14616 ) Change subject: [docs] add info on KUDU-2990 into known issues .. Patch Set 1: (1 comment)

***UNCHECKED*** [kudu-CR] [docs] add info on KUDU-2990 into known issues

2019-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14616 ) Change subject: [docs] add info on KUDU-2990 into known issues .. Patch Set 1: (1 comment)

[kudu-CR] thirdparty: add gumbo and gumbo-query

2019-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14572 ) Change subject: thirdparty: add gumbo and gumbo-query .. Patch Set 4: (1 comment)

***UNCHECKED*** [kudu-CR] thirdparty: add gumbo and gumbo-query

2019-11-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14572 ) Change subject: thirdparty: add gumbo and gumbo-query .. Patch Set 4: Code-Review+2 (1 comment)

[kudu-CR] [docs] add info on KUDU-2990 into known issues

2019-11-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14616 ) Change subject: [docs] add info on KUDU-2990 into known issues .. Patch Set 1: (3 comments)

***UNCHECKED*** [kudu-CR] [docs] add info on KUDU-2990 into known issues

2019-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14616 Change subject: [docs] add info on KUDU-2990 into known issues .. [docs] add info on KUDU-2990 into known issues Change-Id:

[kudu-CR] KUDU-2977 Sharding block map to speed up tserver startup

2019-11-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14555 ) Change subject: KUDU-2977 Sharding block map to speed up tserver startup .. Patch Set 3: (2 comments)

***UNCHECKED*** [kudu-CR] thirdparty: add gumbo and gumbo-query

2019-11-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14572 ) Change subject: thirdparty: add gumbo and gumbo-query .. Patch Set 4: (1 comment)

[kudu-CR] [util] Fix comment of faststring

2019-11-01 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/14604 ) Change subject: [util] Fix comment of faststring .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu

[kudu-CR] [util] Fix comment of faststring

2019-11-01 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14604 ) Change subject: [util] Fix comment of faststring .. [util] Fix comment of faststring 1. Under any case, capacity() is greater

[kudu-CR] [util] Fix comment of faststring

2019-11-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14604 ) Change subject: [util] Fix comment of faststring .. Patch Set 5: Verified+1 Code-Review+2 The TSAN failure is unrelated to your change,

[kudu-CR] thirdparty: add gumbo and gumbo-query

2019-11-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14572 ) Change subject: thirdparty: add gumbo and gumbo-query .. Patch Set 4: Code-Review+1 (1 comment)

[kudu-CR] [RELEASING.adoc] add memo on 3rd-party license policy

2019-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14615 ) Change subject: [RELEASING.adoc] add memo on 3rd-party license policy .. Patch Set 1: Verified+1 Unrelated test failures (this is a

[kudu-CR] KUDU-2989. Work around SASL bug when FQDN is >d characters

2019-11-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14609 ) Change subject: KUDU-2989. Work around SASL bug when FQDN is >=64 characters .. KUDU-2989. Work around SASL bug when FQDN is

[kudu-CR] [RELEASING.adoc] add memo on 3rd-party license policy

2019-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14615 ) Change subject: [RELEASING.adoc] add memo on 3rd-party license policy .. [RELEASING.adoc] add memo on 3rd-party license policy

[kudu-CR] [RELEASING.adoc] add memo on 3rd-party license policy

2019-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [RELEASING.adoc] add memo on 3rd-party license policy .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/14615 To

[kudu-CR] RELEASING: add instructions to create binary test JARs

2019-11-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12868 ) Change subject: RELEASING: add instructions to create binary test JARs .. Patch Set 2: Code-Review+2 (3 comments) Couple of grammar

[kudu-CR] [RELEASING.adoc] add memo on 3rd-party license policy

2019-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14615 ) Change subject: [RELEASING.adoc] add memo on 3rd-party license policy .. Patch Set 1: > Uploaded patch set 1. Probably, the better

[kudu-CR] [RELEASING.adoc] add memo on 3rd-party license policy

2019-11-01 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/14615 ) Change subject: [RELEASING.adoc] add memo on 3rd-party license policy .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] [RELEASING.adoc] add memo on 3rd-party license policy

2019-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14615 ) Change subject: [RELEASING.adoc] add memo on 3rd-party license policy .. Patch Set 1: > Thanks for adding this... It's a bit too

[kudu-CR] [RELEASING.adoc] add memo on 3rd-party license policy

2019-11-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14615 ) Change subject: [RELEASING.adoc] add memo on 3rd-party license policy .. Patch Set 1: Code-Review+2 Thanks for adding this... -- To

[kudu-CR] webserver: add support for Knox URL rewriting

2019-11-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14573 ) Change subject: webserver: add support for Knox URL rewriting .. Patch Set 6: Code-Review+1 (2 comments)

[kudu-CR] [RELEASING.adoc] add memo on 3rd-party license policy

2019-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14615 Change subject: [RELEASING.adoc] add memo on 3rd-party license policy .. [RELEASING.adoc] add memo on 3rd-party license policy Added

[kudu-CR] [docs] Upgrade doc generating scripts

2019-11-01 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14613 ) Change subject: [docs] Upgrade doc generating scripts .. [docs] Upgrade doc generating scripts Docs scripts have dependencies

[kudu-CR] [util] Fix comment of faststring

2019-11-01 Thread Anonymous Coward (Code Review)
lingbi...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/14604 ) Change subject: [util] Fix comment of faststring .. Patch Set 5: > Patch Set 5: Verified-1 > > Build Failed > >

[kudu-CR] [docs] Upgrade doc generating scripts

2019-11-01 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14613 ) Change subject: [docs] Upgrade doc generating scripts .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [docs] Upgrade doc generating scripts

2019-11-01 Thread Attila Bukor (Code Review)
Hello Alexey Serbin, Adar Dembo, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/14613 to review the following change. Change subject: [docs] Upgrade doc generating scripts ..

[kudu-CR] [util] Fix comment of faststring

2019-11-01 Thread Anonymous Coward (Code Review)
lingbi...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/14604 ) Change subject: [util] Fix comment of faststring .. Patch Set 3: (3 comments) > Patch Set 3: > > (3 comments) > > Could you

[kudu-CR] [spark] Add prefetching option to kudu-spark

2019-11-01 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14598 ) Change subject: [spark] Add prefetching option to kudu-spark .. Patch Set 1: > (1 comment) > > Thanks for finding and fixing this bug.

[kudu-CR] [util] Fix comment of faststring

2019-11-01 Thread Anonymous Coward (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14604 to look at the new patch set (#5). Change subject: [util] Fix comment of faststring .. [util] Fix

[kudu-CR] [util] Fix comment of faststring

2019-11-01 Thread Anonymous Coward (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14604 to look at the new patch set (#4). Change subject: [util] Fix comment of faststring .. [util] Fix

[kudu-CR] [util] Fix comment of faststring

2019-11-01 Thread Anonymous Coward (Code Review)
lingbi...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/14604 ) Change subject: [util] Fix comment of faststring .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2977 Sharding block map to speed up tserver startup

2019-11-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14555 ) Change subject: KUDU-2977 Sharding block map to speed up tserver startup .. Patch Set 3: (7 comments)

[kudu-CR] KUDU-2986 p2: adjust the 'live row count' metric in master's Web UI

2019-11-01 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14601 ) Change subject: KUDU-2986 p2: adjust the 'live_row_count' metric in master's Web UI .. Patch Set 2: (1 comment)

[kudu-CR] [util] Fix comment of faststring

2019-11-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14604 ) Change subject: [util] Fix comment of faststring .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2977 Sharding block map to speed up tserver startup

2019-11-01 Thread Yingchun Lai (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14555 to look at the new patch set (#3). Change subject: KUDU-2977 Sharding block map to speed up tserver startup

[kudu-CR] KUDU-2986 p2: adjust the 'live row count' metric in master's Web UI

2019-11-01 Thread helifu (Code Review)
Hello Alexey Serbin, Yifan Zhang, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14601 to look at the new patch set (#2). Change subject: KUDU-2986 p2: adjust the 'live_row_count' metric in master's Web UI

[kudu-CR] KUDU-2986 p2: hide the live row count of table metrics

2019-11-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14601 ) Change subject: KUDU-2986 p2: hide the live row count of table metrics .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2986 p2: hide the live row count of table metrics

2019-11-01 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14601 ) Change subject: KUDU-2986 p2: hide the live row count of table metrics .. Patch Set 1: (2 comments)

[kudu-CR] [spark] Add prefetching option to kudu-spark

2019-11-01 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14598 ) Change subject: [spark] Add prefetching option to kudu-spark .. Patch Set 1: > (1 comment) Maybe we can use the existing testcase to test

[kudu-CR] [util] Fix comment of faststring

2019-11-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14604 ) Change subject: [util] Fix comment of faststring .. Patch Set 3: (3 comments) Could you add a few tests to faststring-test that verify

[kudu-CR] [util] Fix comment of faststring

2019-11-01 Thread Anonymous Coward (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14604 to look at the new patch set (#3). Change subject: [util] Fix comment of faststring .. [util] Fix

[kudu-CR] [util] Fix comment of faststring

2019-11-01 Thread Anonymous Coward (Code Review)
lingbi...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/14604 ) Change subject: [util] Fix comment of faststring .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2724: binary jar build on OSX should specify target macOS version

2019-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#2) to the change originally created by Mike Percy. ( http://gerrit.cloudera.org:8080/12655 ) Change subject: KUDU-2724: binary jar build on OSX should specify target macOS version ..

[kudu-CR] RELEASING: add instructions to create binary test JARs

2019-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#2) to the change originally created by Mike Percy. ( http://gerrit.cloudera.org:8080/12868 ) Change subject: RELEASING: add instructions to create binary test JARs .. RELEASING: add

[kudu-CR] RELEASING: add instructions to create binary test JARs

2019-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12868 ) Change subject: RELEASING: add instructions to create binary test JARs .. Patch Set 1: (2 comments)