[kudu-CR] [java] KUDU-2971: process communicates via protobuf-based protocol

2020-02-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14329 ) Change subject: [java] KUDU-2971: process communicates via protobuf-based protocol .. Patch Set 17: Code-Review+1 -- To view, visit

[kudu-CR] [clock] ntp gettime(): STA NANO bites again

2020-02-05 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15171 ) Change subject: [clock] ntp_gettime(): STA_NANO bites again .. [clock] ntp_gettime(): STA_NANO bites again Even with the most

[kudu-CR] [clock] ntp gettime(): STA NANO bites again

2020-02-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15171 ) Change subject: [clock] ntp_gettime(): STA_NANO bites again .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [clock] ntp gettime(): STA NANO bites again

2020-02-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15171 ) Change subject: [clock] ntp_gettime(): STA_NANO bites again .. Patch Set 3: Verified+1 unrelated failure in flaky test

[kudu-CR] [clock] ntp gettime(): STA NANO bites again

2020-02-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [clock] ntp_gettime(): STA_NANO bites again .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15171 To unsubscribe,

[kudu-CR] [clock] ntp gettime(): STA NANO bites again

2020-02-05 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15171 to look at the new patch set (#3). Change subject: [clock] ntp_gettime(): STA_NANO bites again

[kudu-CR] [java] KUDU-2971: process communicates via protobuf-based protocol

2020-02-05 Thread Hao Hao (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14329 to look at the new patch set (#17). Change subject: [java] KUDU-2971: process communicates via protobuf-based

[kudu-CR] [java] KUDU-2971: process communicates via protobuf-based protocol

2020-02-05 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14329 ) Change subject: [java] KUDU-2971: process communicates via protobuf-based protocol .. Patch Set 16: (5 comments)

[kudu-CR] [clock] ntp gettime(): STA NANO bites again

2020-02-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15171 ) Change subject: [clock] ntp_gettime(): STA_NANO bites again .. Patch Set 1: (1 comment) > (1 comment) > > Would be nice to think

[kudu-CR] [clock] ntp gettime(): STA NANO bites again

2020-02-05 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15171 to look at the new patch set (#2). Change subject: [clock] ntp_gettime(): STA_NANO bites again

[kudu-CR] [util] add CURLOPT FAILONERROR for instance metadata requests

2020-02-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [util] add CURLOPT_FAILONERROR for instance metadata requests .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15172

[kudu-CR] [util] add CURLOPT FAILONERROR for instance metadata requests

2020-02-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15172 ) Change subject: [util] add CURLOPT_FAILONERROR for instance metadata requests .. Patch Set 1: Verified+1 unrelated test failure:

[kudu-CR] [util] add CURLOPT FAILONERROR for instance metadata requests

2020-02-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15172 ) Change subject: [util] add CURLOPT_FAILONERROR for instance metadata requests .. [util] add CURLOPT_FAILONERROR for instance

[kudu-CR] [util] remove timeout parameter for cloud::InstanceDetector

2020-02-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15168 ) Change subject: [util] remove timeout parameter for cloud::InstanceDetector .. [util] remove timeout parameter for

[kudu-CR] [clock] ntp gettime(): STA NANO bites again

2020-02-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15171 ) Change subject: [clock] ntp_gettime(): STA_NANO bites again .. Patch Set 1: (1 comment) Would be nice to think about how we could test

[kudu-CR] [util] add CURLOPT FAILONERROR for instance metadata requests

2020-02-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15172 ) Change subject: [util] add CURLOPT_FAILONERROR for instance metadata requests .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [util] remove timeout parameter for cloud::InstanceDetector

2020-02-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15168 ) Change subject: [util] remove timeout parameter for cloud::InstanceDetector .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [util] add CURLOPT FAILONERROR for instance metadata requests

2020-02-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15172 Change subject: [util] add CURLOPT_FAILONERROR for instance metadata requests .. [util] add CURLOPT_FAILONERROR for instance metadata

[kudu-CR] [util] remove timeout parameter for cloud::InstanceDetector

2020-02-05 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, Volodymyr Verovkin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15168 to look at the new patch set (#2). Change subject: [util] remove timeout parameter for cloud::InstanceDetector

[kudu-CR] [util] remove timeout parameter for cloud::InstanceDetector

2020-02-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15168 ) Change subject: [util] remove timeout parameter for cloud::InstanceDetector .. Patch Set 1: (1 comment)

[kudu-CR] [clock] ntp gettime(): STA NANO bites again

2020-02-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15171 Change subject: [clock] ntp_gettime(): STA_NANO bites again .. [clock] ntp_gettime(): STA_NANO bites again The issue fixed once in

[kudu-CR] [util] remove timeout parameter for cloud::InstanceDetector

2020-02-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15168 ) Change subject: [util] remove timeout parameter for cloud::InstanceDetector .. Patch Set 1: (1 comment)

[kudu-CR] [util] remove timeout parameter for cloud::InstanceDetector

2020-02-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15168 ) Change subject: [util] remove timeout parameter for cloud::InstanceDetector .. Patch Set 1: (1 comment)

[kudu-CR] [util] remove timeout parameter for cloud::InstanceDetector

2020-02-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15168 ) Change subject: [util] remove timeout parameter for cloud::InstanceDetector .. Patch Set 1: (1 comment)

[kudu-CR] [util] remove timeout parameter for cloud::InstanceDetector

2020-02-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15168 ) Change subject: [util] remove timeout parameter for cloud::InstanceDetector .. Patch Set 1: (2 comments)

[kudu-CR] [util] remove timeout parameter for cloud::InstanceDetector

2020-02-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15168 Change subject: [util] remove timeout parameter for cloud::InstanceDetector .. [util] remove timeout parameter for

[kudu-CR] [client] KUDU-2483 Add IN Bloom filter predicate to C++ client

2020-02-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15122 ) Change subject: [client] KUDU-2483 Add IN Bloom filter predicate to C++ client .. Patch Set 4: (5 comments)

[kudu-CR] [util] Add a function to generate random unique 32-bit/64-bit integers

2020-02-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15166 ) Change subject: [util] Add a function to generate random unique 32-bit/64-bit integers .. Patch Set 1: (4 comments)

[kudu-CR] [util] Add cloning support to BlockBloomFilter and associated allocator

2020-02-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15121 ) Change subject: [util] Add cloning support to BlockBloomFilter and associated allocator .. Patch Set 4: (3 comments)

[kudu-CR] KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

2020-02-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15034 ) Change subject: KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side .. Patch Set 12: Code-Review+2 -- To view,

[kudu-CR] [java] Document increasing Intellij intellisense configuration

2020-02-05 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15155 ) Change subject: [java] Document increasing Intellij intellisense configuration .. [java] Document increasing Intellij

[kudu-CR] [util] Add a function to generate random unique 32-bit/64-bit integers

2020-02-05 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15166 Change subject: [util] Add a function to generate random unique 32-bit/64-bit integers .. [util] Add a function to generate random

[kudu-CR] KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

2020-02-05 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, helifu, Yao Xu, Adar Dembo, ZhangYao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15034 to look at the new patch set (#12). Change subject: KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

[kudu-CR] [client] KUDU-2483 Add IN Bloom filter predicate to C++ client

2020-02-05 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15122 to look at the new patch set (#4). Change subject: [client] KUDU-2483 Add IN Bloom filter predicate to C++ client

[kudu-CR] [util] Add cloning support to BlockBloomFilter and associated allocator

2020-02-05 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15121 to look at the new patch set (#4). Change subject: [util] Add cloning support to BlockBloomFilter and associated allocator

[kudu-CR] [client] KUDU-2483 Add IN Bloom filter predicate to C++ client

2020-02-05 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15122 ) Change subject: [client] KUDU-2483 Add IN Bloom filter predicate to C++ client .. Patch Set 3: (7 comments)

[kudu-CR] Add cloning support to BlockBloomFilter and associated allocator

2020-02-05 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15121 ) Change subject: Add cloning support to BlockBloomFilter and associated allocator .. Patch Set 3: (3 comments)

[kudu-CR] KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side

2020-02-05 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15034 ) Change subject: KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side .. Patch Set 11: (1 comment)

[kudu-CR] [java] KUDU-2971: process communicates via protobuf-based protocol

2020-02-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14329 ) Change subject: [java] KUDU-2971: process communicates via protobuf-based protocol .. Patch Set 16: (5 comments)

[kudu-CR] [java] KUDU-2971: process communicates via protobuf-based protocol

2020-02-05 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14329 ) Change subject: [java] KUDU-2971: process communicates via protobuf-based protocol .. Patch Set 16: (9 comments)

[kudu-CR] [java] KUDU-2971: process communicates via protobuf-based protocol

2020-02-05 Thread Hao Hao (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14329 to look at the new patch set (#16). Change subject: [java] KUDU-2971: process communicates via protobuf-based

[kudu-CR] [clock] fix on SystemNtp::Init()

2020-02-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15163 ) Change subject: [clock] fix on SystemNtp::Init() .. [clock] fix on SystemNtp::Init() Do not require the clock to be

[kudu-CR] [tests] enable TestNtpDiagnostics for 'system' time source

2020-02-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15160 ) Change subject: [tests] enable TestNtpDiagnostics for 'system' time source .. [tests] enable TestNtpDiagnostics for 'system'

[kudu-CR] [clock] auto-selection of time source

2020-02-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15161 ) Change subject: [clock] auto-selection of time source .. Patch Set 1: (2 comments)

[kudu-CR] [tests] enable TestNtpDiagnostics for 'system' time source

2020-02-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15160 ) Change subject: [tests] enable TestNtpDiagnostics for 'system' time source .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [java] KUDU-2971: process communicates via protobuf-based protocol

2020-02-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14329 ) Change subject: [java] KUDU-2971: process communicates via protobuf-based protocol .. Patch Set 15: (9 comments) OK I reviewed the

[kudu-CR] [clock] fix on SystemNtp::Init()

2020-02-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15163 ) Change subject: [clock] fix on SystemNtp::Init() .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15163

[kudu-CR] [TYPO] Trivial comment typo fix.

2020-02-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15164 ) Change subject: [TYPO] Trivial comment typo fix. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15164/1//COMMIT_MSG

[kudu-CR] [TYPO] Trivial comment typo fix.

2020-02-05 Thread ZhangYao (Code Review)
ZhangYao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15164 Change subject: [TYPO] Trivial comment typo fix. .. [TYPO] Trivial comment typo fix. Change-Id: I6ff4f14dc4793be8d3ab40c3c643b37e16af63f2