[kudu-CR](branch-1.17.x) [master] Exclude tservers in MAINTENANCE MODE when leader rebalancing

2023-05-24 Thread Yingchun Lai (Code Review)
Hello Yuqi Du, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/19923 to review the following change. Change subject: [master] Exclude tservers in MAINTENANCE_MODE when leader rebalancing .

[kudu-CR](branch-1.17.x) [tools] KUDU-1945 Print auto-incrementing counter in kudu wal dump

2023-05-24 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/19921 to review the following change. Change subject: [tools] KUDU-1945 Print auto-incrementing counter in kudu wal dump

[kudu-CR](branch-1.17.x) KUDU-1945 Add C++ example for non-unique PK

2023-05-24 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/19920 to review the following change. Change subject: KUDU-1945 Add C++ example for non-unique PK .. KUDU-1945 Add C++ ex

[kudu-CR](branch-1.17.x) [server] KUDU-1945 Fix bug in RowOperationsPBDecoder

2023-05-24 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/19919 to review the following change. Change subject: [server] KUDU-1945 Fix bug in RowOperationsPBDecoder .

[kudu-CR](branch-1.17.x) [Python] Add support for comment in ColumnSchema

2023-05-24 Thread Yingchun Lai (Code Review)
Hello Marton Greber, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19694 to look at the new patch set (#4). Change subject: [Python] Add support for comment in ColumnSchema ..

[kudu-CR] KUDU-3413 [multi-tenancy] add some renames for multi-tenancy

2023-05-23 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19899 ) Change subject: KUDU-3413 [multi-tenancy] add some renames for multi-tenancy .. KUDU-3413 [multi-tenancy] add some renames for m

[kudu-CR] KUDU-3413 [multi-tenancy] add some renames for multi-tenancy

2023-05-23 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19899 ) Change subject: KUDU-3413 [multi-tenancy] add some renames for multi-tenancy .. Patch Set 10: Code-Review+2 -- To view, visit http://g

[kudu-CR] KUDU-3413 [multi-tenancy] add some renames for multi-tenancy

2023-05-22 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19899 ) Change subject: KUDU-3413 [multi-tenancy] add some renames for multi-tenancy .. Patch Set 9: Code-Review+2 -- To view, visit http://ge

[kudu-CR] KUDU-3413 [multi-tenancy] add some renames for multi-tenancy

2023-05-22 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19899 ) Change subject: KUDU-3413 [multi-tenancy] add some renames for multi-tenancy .. Patch Set 7: Code-Review+1 (1 comment) http://gerrit.c

[kudu-CR] KUDU-3413 [multi-tenancy] add some renames for multi-tenancy

2023-05-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19899 ) Change subject: KUDU-3413 [multi-tenancy] add some renames for multi-tenancy .. Patch Set 5: Verified+1 Code-Review+2 -- To view, visi

[kudu-CR] KUDU-3413 [multi-tenancy] add some renames for multi-tenancy

2023-05-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: KUDU-3413 [multi-tenancy] add some renames for multi-tenancy .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/19899 To

[kudu-CR] KUDU-3413 [multi-tenancy] add some renames for multi-tenancy

2023-05-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19899 ) Change subject: KUDU-3413 [multi-tenancy] add some renames for multi-tenancy .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8

[kudu-CR] [tests] fix flakiness in TestLogCleanupOnStartup

2023-05-16 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19871 ) Change subject: [tests] fix flakiness in TestLogCleanupOnStartup .. Patch Set 1: This patch https://gerrit.cloudera.org/c/19842/ is aim

[kudu-CR] [tests] fix flakiness in TestLogCleanupOnStartup

2023-05-16 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19871 ) Change subject: [tests] fix flakiness in TestLogCleanupOnStartup .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/19871

[kudu-CR] KUDU-3413 [multi-tenancy] update server key for multi-tenancy

2023-05-16 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19622 ) Change subject: KUDU-3413 [multi-tenancy] update server key for multi-tenancy .. Patch Set 11: Verified+1 -- To view, visit http://ger

[kudu-CR] KUDU-3413 [multi-tenancy] update server key for multi-tenancy

2023-05-16 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: KUDU-3413 [multi-tenancy] update server key for multi-tenancy .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/19622 To

[kudu-CR] [server] remove unused JWT-related flags

2023-05-16 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19891 ) Change subject: [server] remove unused JWT-related flags .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] KUDU-3475: Update to the most recent sse2neon.h

2023-05-16 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19847 ) Change subject: KUDU-3475: Update to the most recent sse2neon.h .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera

[kudu-CR] KUDU-3475: Update to the most recent sse2neon.h

2023-05-16 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19847 ) Change subject: KUDU-3475: Update to the most recent sse2neon.h .. Patch Set 4: > Patch Set 4: > > > > > Patch Set 4: > > > > > > > >

[kudu-CR] [cpp-client] KUDU-3455 Reduce space complexity and speed up hash partition pruning for in-list predicate

2023-05-16 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19794 ) Change subject: [cpp-client] KUDU-3455 Reduce space complexity and speed up hash partition pruning for in-list predicate .. Patch Set 7

[kudu-CR] KUDU-3413 [multi-tenancy] update server key for multi-tenancy

2023-05-16 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19622 ) Change subject: KUDU-3413 [multi-tenancy] update server key for multi-tenancy .. Patch Set 11: Code-Review+2 -- To view, visit http://

[kudu-CR] KUDU-3413 [multi-tenancy] update server key for multi-tenancy

2023-05-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19622 ) Change subject: KUDU-3413 [multi-tenancy] update server key for multi-tenancy .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:

[kudu-CR] KUDU-3413 [multi-tenancy] update server key for multi-tenancy

2023-05-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19622 ) Change subject: KUDU-3413 [multi-tenancy] update server key for multi-tenancy .. Patch Set 10: Code-Review+1 (2 comments) http://gerri

[kudu-CR] KUDU-3475: Update to the most recent sse2neon.h

2023-05-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19847 ) Change subject: KUDU-3475: Update to the most recent sse2neon.h .. Patch Set 4: > Patch Set 4: > > Thanks to the contribution! > > But

[kudu-CR] KUDU-3475: Update to the most recent sse2neon.h

2023-05-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19847 ) Change subject: KUDU-3475: Update to the most recent sse2neon.h .. Patch Set 4: Thanks to the contribution! But I'm curious why not in

[kudu-CR] [tools]KUDU-1945: Kudu copy table tool

2023-05-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19890 ) Change subject: [tools]KUDU-1945: Kudu copy table tool .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19890/2//COMMI

[kudu-CR] [KUDU-3452] Make validate tablet creating task not affected

2023-05-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19594 ) Change subject: [KUDU-3452] Make validate tablet creating task not affected .. Patch Set 21: (2 comments) http://gerrit.cloudera.org:8

[kudu-CR] KUDU-3452 Allow creating tablets under replicated tables

2023-05-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19571 ) Change subject: KUDU-3452 Allow creating tablets under replicated tables .. KUDU-3452 Allow creating tablets under replicated ta

[kudu-CR] KUDU-3452 Allow creating tablets under replicated tables

2023-05-15 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19571 ) Change subject: KUDU-3452 Allow creating tablets under replicated tables .. Patch Set 23: Code-Review+2 -- To view, visit http://gerri

[kudu-CR] KUDU-3413 [multi-tenancy] update server key for multi-tenancy

2023-05-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19622 ) Change subject: KUDU-3413 [multi-tenancy] update server key for multi-tenancy .. Patch Set 9: (13 comments) http://gerrit.cloudera.org

[kudu-CR](gh-pages) KUDU-1945 Update faq with non-unique PK

2023-05-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19860 ) Change subject: KUDU-1945 Update faq with non-unique PK .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19860/2/faq.md

[kudu-CR] KUDU-1945 Update docs with non-unique PK

2023-05-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19809 ) Change subject: KUDU-1945 Update docs with non-unique PK .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] KUDU-1945 Update docs with non-unique PK

2023-05-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: KUDU-1945 Update docs with non-unique PK .. Removed Code-Review+2 by Yingchun Lai -- To view, visit http://gerrit.cloudera.org:8080/19809 To unsubscribe, visit htt

[kudu-CR] KUDU-1945 Update docs with non-unique PK

2023-05-10 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19809 ) Change subject: KUDU-1945 Update docs with non-unique PK .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] KUDU-1945 Update docs with non-unique PK

2023-05-09 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19809 ) Change subject: KUDU-1945 Update docs with non-unique PK .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19809/2/docs

[kudu-CR](branch-1.17.x) [Python] Add support for comment in ColumnSchema

2023-05-09 Thread Yingchun Lai (Code Review)
Hello Marton Greber, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19694 to look at the new patch set (#3). Change subject: [Python] Add support for comment in ColumnSchema ..

[kudu-CR] KUDU-1945 Update docs with non-unique PK

2023-05-09 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19809 ) Change subject: KUDU-1945 Update docs with non-unique PK .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/19809/2/docs

[kudu-CR] KUDU-3413 [multi-tenancy] update server key for multi-tenancy

2023-05-09 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19622 ) Change subject: KUDU-3413 [multi-tenancy] update server key for multi-tenancy .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8

[kudu-CR] KUDU-3371 [fs] make LogBlockContainer a base class

2023-05-07 Thread Yingchun Lai (Code Review)
Hello Tidy Bot, Alexey Serbin, Yuqi Du, Ashwani Raina, Attila Bukor, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, KeDeng, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19610 to look at the new patch set (#4). Change subject: KUDU-3371 [fs] mak

[kudu-CR] KUDU-3371 [fs] make LogBlockContainer a base class

2023-05-07 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19610 ) Change subject: KUDU-3371 [fs] make LogBlockContainer a base class .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/19

[kudu-CR] [thirdparty] upgrade libunwind to 1.6.2

2023-05-07 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19853 ) Change subject: [thirdparty] upgrade libunwind to 1.6.2 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:808

[kudu-CR] [KUDU-3452] Make validate table creating task not affected

2023-05-07 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19594 ) Change subject: [KUDU-3452] Make validate table creating task not affected .. Patch Set 13: (7 comments) http://gerrit.cloudera.org:80

[kudu-CR] KUDU-3452 Allow creating tablets under replicated tables

2023-05-06 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19571 ) Change subject: KUDU-3452 Allow creating tablets under replicated tables .. Patch Set 17: Code-Review+2 -- To view, visit http://gerri

[kudu-CR] KUDU-3452 Allow creating tablets under replicated tables

2023-05-06 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19571 ) Change subject: KUDU-3452 Allow creating tablets under replicated tables .. Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/

[kudu-CR] KUDU-3452 Create tablet without enough healthy tservers

2023-05-06 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19571 ) Change subject: KUDU-3452 Create tablet without enough healthy tservers .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#

[kudu-CR] KUDU-3452 Create tablet without enough healthy tservers

2023-05-06 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19571 ) Change subject: KUDU-3452 Create tablet without enough healthy tservers .. Patch Set 15: (10 comments) http://gerrit.cloudera.org:8080

[kudu-CR] [tablet] GC ancient, fully deleted rowsets without live row count stats

2023-04-30 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19670 ) Change subject: [tablet] GC ancient, fully deleted rowsets without live row count stats .. [tablet] GC ancient, fully deleted r

[kudu-CR] [Tool] Show the information of a tablet

2023-04-27 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 ) Change subject: [Tool] Show the information of a tablet .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/19501/12//COM

[kudu-CR] [tablet] GC ancient, fully deleted rowsets without live row count stats

2023-04-27 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19670 ) Change subject: [tablet] GC ancient, fully deleted rowsets without live row count stats .. Patch Set 19: Code-Review+2 -- To view, vi

[kudu-CR] [java] KUDU-3455 Reduce space complexity of hash partition pruning for in-list predicate

2023-04-27 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19568 ) Change subject: [java] KUDU-3455 Reduce space complexity of hash partition pruning for in-list predicate .. [java] KUDU-3455 Re

[kudu-CR] [java] KUDU-3455 Reduce space complexity of hash partition pruning for in-list predicate

2023-04-25 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19568 ) Change subject: [java] KUDU-3455 Reduce space complexity of hash partition pruning for in-list predicate .. Patch Set 14: Code-Review+2

[kudu-CR] KUDU-3452 Create tablet without enough healthy tservers

2023-04-24 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19571 ) Change subject: KUDU-3452 Create tablet without enough healthy tservers .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#

[kudu-CR] [tablet] GC ancient, fully deleted rowsets witout live row count stats

2023-04-24 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19670 ) Change subject: [tablet] GC ancient, fully deleted rowsets witout live row count stats .. Patch Set 16: Code-Review+2 -- To view, vis

[kudu-CR] [multi-tenancy] KUDU-3413 update server key for multi-tenancy

2023-04-24 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19622 ) Change subject: [multi-tenancy] KUDU-3413 update server key for multi-tenancy .. Patch Set 5: (8 comments) http://gerrit.cloudera.org:

[kudu-CR] KUDU-3452 Create tablet without enough healthy tservers

2023-04-23 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19571 ) Change subject: KUDU-3452 Create tablet without enough healthy tservers .. Patch Set 10: (8 comments) http://gerrit.cloudera.org:8080/

[kudu-CR] [master] Exclude tservers in MAINTENANCE MODE when leader rebalancing

2023-04-23 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19608 ) Change subject: [master] Exclude tservers in MAINTENANCE_MODE when leader rebalancing .. [master] Exclude tservers in MAINTENAN

[kudu-CR] [client] add -Werror flag for checking client C++ API

2023-04-23 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19784 ) Change subject: [client] add -Werror flag for checking client C++ API .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cl

[kudu-CR] [tablet] GC ancient, fully deleted rowsets witout live row count stats

2023-04-21 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19670 ) Change subject: [tablet] GC ancient, fully deleted rowsets witout live row count stats .. Patch Set 14: Code-Review+1 (1 comment) htt

[kudu-CR] [master] Exclude tservers in MAINTENANCE MODE when leader rebalancing

2023-04-21 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19608 ) Change subject: [master] Exclude tservers in MAINTENANCE_MODE when leader rebalancing .. Patch Set 13: Code-Review+2 (1 comment) http

[kudu-CR] [docs] fix instructions for building Kudu on SLES

2023-04-20 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19779 ) Change subject: [docs] fix instructions for building Kudu on SLES .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloude

[kudu-CR] [build-support] allow building with gcc/g++-7 on SLES

2023-04-20 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19778 ) Change subject: [build-support] allow building with gcc/g++-7 on SLES .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cl

[kudu-CR] [client] fix API non-compliance in KuduUpsertIgnore

2023-04-19 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19765 ) Change subject: [client] fix API non-compliance in KuduUpsertIgnore .. Patch Set 3: Thanks for the fix. -- To view, visit http://gerr

[kudu-CR] [GC] gc ancient, fully deleted rowsets without live row count

2023-04-09 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19670 ) Change subject: [GC] gc ancient, fully deleted rowsets without live row count .. Patch Set 7: Verified+1 Code-Review+2 -- To view, vis

[kudu-CR] [GC] gc ancient, fully deleted rowsets without live row count

2023-04-09 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: [GC] gc ancient, fully deleted rowsets without live row count .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/19670 To

[kudu-CR] [Tool] Show the information of a tablet

2023-04-09 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 ) Change subject: [Tool] Show the information of a tablet .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/19501/11/src/

[kudu-CR] [KUDU-3452] Make validate table creating task not affected

2023-04-09 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19594 ) Change subject: [KUDU-3452] Make validate table creating task not affected .. Patch Set 7: Code-Review+1 (4 comments) http://gerrit.cl

[kudu-CR] jwt: introduce MiniOidc

2023-04-05 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18473 ) Change subject: jwt: introduce MiniOidc .. Patch Set 20: Hi! Shall we also cherry-pick the new jwt related commits into branch-1.17.x?

[kudu-CR](branch-1.17.x) [Python] Add support for immutable column

2023-04-05 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/19695 to review the following change. Change subject: [Python] Add support for immutable column .. [Python]

[kudu-CR](branch-1.17.x) [Python] Add support for comment in ColumnSchema

2023-04-05 Thread Yingchun Lai (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/19694 to review the following change. Change subject: [Python] Add support for comment in ColumnSchema .. [

[kudu-CR](branch-1.17.x) [tools] update 'kudu table copy' CLI tool

2023-04-05 Thread Yingchun Lai (Code Review)
Hello Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/19693 to review the following change. Change subject: [tools] update 'kudu table copy' CLI tool .. [tools] update 'kudu ta

[kudu-CR](branch-1.17.x) [docs] Add release notes for 1.17.0

2023-04-05 Thread Yingchun Lai (Code Review)
Hello Marton Greber, Alexey Serbin, Kurt Deschler, Yuqi Du, Andrew Wong, Yifan Zhang, Khazar Mammadli, Joe McDonnell, Zoltan Chovan, Ashwani Raina, Attila Bukor, KeDeng, Ádám Bakai, Mahesh Reddy, zhanghongbin, Wenzhe Zhou, bsglz, harinreddy, Riza Suminto, Hongjiang Zhang, Kudu Jenkins, Abhishek

[kudu-CR] [GC] gc ancient, fully deleted rowsets without live row count

2023-04-04 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19670 ) Change subject: [GC] gc ancient, fully deleted rowsets without live row count .. Patch Set 7: Code-Review+1 (6 comments) http://gerrit

[kudu-CR] [master] Exclude tservers in MAINTENANCE MODE when leader rebalancing

2023-04-04 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: [master] Exclude tservers in MAINTENANCE_MODE when leader rebalancing .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080

[kudu-CR] [master] Exclude tservers in MAINTENANCE MODE when leader rebalancing

2023-04-04 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19608 ) Change subject: [master] Exclude tservers in MAINTENANCE_MODE when leader rebalancing .. Patch Set 12: Verified+1 Code-Review+2 (2 com

[kudu-CR] [Tool] Show the information of a tablet

2023-04-04 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 ) Change subject: [Tool] Show the information of a tablet .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/19501/11/src/

[kudu-CR] KUDU-3371 [fs] make LogBlockContainer a base class

2023-04-04 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19610 ) Change subject: KUDU-3371 [fs] make LogBlockContainer a base class .. Patch Set 3: (2 comments) Thanks a lot to your guys to review th

[kudu-CR](branch-1.17.x) [clock] add sanity check to detect wall clock jumps

2023-04-03 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19681 ) Change subject: [clock] add sanity check to detect wall clock jumps .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clou

[kudu-CR] [KUDU-3452] Make validate table creating task not affected

2023-04-03 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19594 ) Change subject: [KUDU-3452] Make validate table creating task not affected .. Patch Set 6: (8 comments) http://gerrit.cloudera.org:808

[kudu-CR] [GC] gc ancient, fully deleted rowsets without live row count

2023-04-03 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19670 ) Change subject: [GC] gc ancient, fully deleted rowsets without live row count .. Patch Set 5: (6 comments) http://gerrit.cloudera.org:

[kudu-CR](branch-1.17.x) KUDU-3437 Set default block cache metrics policy to reset

2023-04-02 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19673 ) Change subject: KUDU-3437 Set default block_cache_metrics_policy to reset .. Patch Set 1: Code-Review+2 -- To view, visit http://gerri

[kudu-CR](branch-1.17.x) KUDU-1945 Update auto incrementing counter during bootstrap

2023-04-02 Thread Yingchun Lai (Code Review)
Yingchun Lai has removed a vote on this change. Change subject: KUDU-1945 Update auto incrementing counter during bootstrap .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/19678 To u

[kudu-CR](branch-1.17.x) KUDU-1945 Update auto incrementing counter during bootstrap

2023-04-02 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19678 ) Change subject: KUDU-1945 Update auto incrementing counter during bootstrap .. Patch Set 2: Code-Review+2 -- To view, visit http://ger

[kudu-CR](branch-1.17.x) KUDU-1945 Update auto incrementing counter during bootstrap

2023-04-02 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19678 ) Change subject: KUDU-1945 Update auto incrementing counter during bootstrap .. Patch Set 2: Verified+1 -- To view, visit http://gerrit

[kudu-CR](branch-1.17.x) [www] add slow scans show control

2023-04-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19675 ) Change subject: [www] add slow scans show control .. [www] add slow scans show control The slow scans show functionality may le

[kudu-CR](branch-1.17.x) [www] add slow scans show control

2023-04-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19675 ) Change subject: [www] add slow scans show control .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/1967

[kudu-CR] [clock] add sanity check to detect wall clock jumps

2023-04-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19473 ) Change subject: [clock] add sanity check to detect wall clock jumps .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.clou

[kudu-CR](branch-1.17.x) [server] add 'slow scans' metric for tablet server

2023-04-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19674 ) Change subject: [server] add 'slow_scans' metric for tablet server .. [server] add 'slow_scans' metric for tablet server As a s

[kudu-CR](branch-1.17.x) [server] add 'slow scans' metric for tablet server

2023-04-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19674 ) Change subject: [server] add 'slow_scans' metric for tablet server .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloud

[kudu-CR](branch-1.17.x) KUDU-1945 Auto-incrementing column feature flag

2023-04-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19676 ) Change subject: KUDU-1945 Auto-incrementing column feature flag .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera

[kudu-CR](branch-1.17.x) KUDU-1945 Auto-incrementing column, Python client

2023-04-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19677 ) Change subject: KUDU-1945 Auto-incrementing column, Python client .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloude

[kudu-CR](branch-1.17.x) KUDU-1945 Update auto incrementing counter during bootstrap

2023-04-01 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19678 ) Change subject: KUDU-1945 Update auto incrementing counter during bootstrap .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cl

[kudu-CR] KUDU-1945 Update auto incrementing counter during bootstrap

2023-03-31 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19445 ) Change subject: KUDU-1945 Update auto incrementing counter during bootstrap .. Patch Set 12: (3 comments) http://gerrit.cloudera.org:8

[kudu-CR] [client] Improve logging in client metacache

2023-03-31 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19653 ) Change subject: [client] Improve logging in client metacache .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.or

[kudu-CR] [GC] gc ancient, fully deleted rowsets without live row count

2023-03-31 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19670 ) Change subject: [GC] gc ancient, fully deleted rowsets without live row count .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:

[kudu-CR] [Tool] Show the information of a tablet

2023-03-31 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 ) Change subject: [Tool] Show the information of a tablet .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/19501/11/src/

[kudu-CR] [KUDU-3452] Make validate table creating task not affected

2023-03-31 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19594 ) Change subject: [KUDU-3452] Make validate table creating task not affected .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:808

[kudu-CR] [Tool] Show the information of a tablet

2023-03-31 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19501 ) Change subject: [Tool] Show the information of a tablet .. Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/19501/11/src

[kudu-CR] [KUDU-3452] A tool to show on creating tables

2023-03-31 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19584 ) Change subject: [KUDU-3452] A tool to show on creating tables .. Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/19584/4

[kudu-CR] [clock] add sanity check to detect wall clock jumps

2023-03-31 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19473 ) Change subject: [clock] add sanity check to detect wall clock jumps .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.clou

[kudu-CR] [rowset metadata] update min/max encoded keys during bootstrapping

2023-03-31 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19650 ) Change subject: [rowset_metadata] update min/max encoded keys during bootstrapping .. Patch Set 10: Code-Review+1 -- To view, visit h

<    5   6   7   8   9   10   11   12   13   14   >