[kudu-CR] [client] performance optimizations

2016-09-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [client] performance optimizations .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4385/2/src/kudu/client/batcher.cc File src/kudu/client/

[kudu-CR] KUDU-1614 - [python] Enable Set/Get of unixtime micros

2016-09-16 Thread Jordan Birdsell (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4417 to look at the new patch set (#7). Change subject: KUDU-1614 - [python] Enable Set/Get of unixtime_micros ...

[kudu-CR] KUDU-1614 - [python] Enable Set/Get of unixtime micros

2016-09-16 Thread Jordan Birdsell (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4417 to look at the new patch set (#8). Change subject: KUDU-1614 - [python] Enable Set/Get of unixtime_micros ...

[kudu-CR] [java client] KuduScanToken#build cleanup

2016-09-16 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java client] KuduScanToken#build cleanup .. [java client] KuduScanToken#build cleanup Using Todd's patch for error-prone, I found that KuduScanTok

[kudu-CR] [c++client] added TestAutoFlushBackgroundDropSession

2016-09-16 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: [c++client] added TestAutoFlushBackgroundDropSession .. [c++client] added TestAutoFlushBackgroundDropSession As a follow-up for 1a062253e3fdc900a4b0b418520

[kudu-CR] [c++client] added TestAutoFlushBackgroundDropSession

2016-09-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [c++client] added TestAutoFlushBackgroundDropSession .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4432 To unsubscribe, visit htt

[kudu-CR] [client-test] faster TestFlushModesCompareOpRates*

2016-09-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [client-test] faster TestFlushModesCompareOpRates* .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4437/1/src/kudu/client/client-test.cc File src/k

[kudu-CR] Change timestamp printing to ISO-8601 (with microseconds)

2016-09-16 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/1995 to look at the new patch set (#3). Change subject: Change timestamp printing to ISO-8601 (with microseconds) .. Cha

[kudu-CR] Change timestamp printing to ISO-8601 (with microseconds)

2016-09-16 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Change timestamp printing to ISO-8601 (with microseconds) .. Patch Set 3: I fixed this on the Java side a little bit ago, since I thought this patch had landed a

[kudu-CR] make election timeout jitter more aggressive

2016-09-16 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3828 to look at the new patch set (#2). Change subject: make election timeout jitter more aggressive .. make election ti

[kudu-CR] [client] performance optimizations

2016-09-16 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4385 to look at the new patch set (#3). Change subject: [client] performance optimizations .. [client] performance optim

[kudu-CR] make election timeout jitter more aggressive

2016-09-16 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: make election timeout jitter more aggressive .. Patch Set 1: I've changed this so it's just making the jitter more aggressive. The clamp is still a theoretical i

[kudu-CR] c++ client: use entire deadline when retrying single-master DDL operations

2016-09-16 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4435 to look at the new patch set (#2). Change subject: c++ client: use entire deadline when retrying single-master DDL operations .

[kudu-CR] cli tool: add -v to 'kudu table list'

2016-09-16 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4440 to review the following change. Change subject: cli tool: add -v to 'kudu table list' .. cli tool: add -v

[kudu-CR] Change timestamp printing to ISO-8601 (with microseconds)

2016-09-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Change timestamp printing to ISO-8601 (with microseconds) .. Patch Set 3: Verified+1 unrelated flake org.apache.kudu.client.ITClient.test -- To view, vis

[kudu-CR] cli tool: add -v to 'kudu table list'

2016-09-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: cli tool: add -v to 'kudu table list' .. Patch Set 1: (9 comments) http://gerrit.cloudera.org:8080/#/c/4440/1//COMMIT_MSG Commit Message: PS1, Line 10: corelate c

[kudu-CR] WIP: KUDU-1623. Properly handle UPSERTS that only include PK column

2016-09-16 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4441 to review the following change. Change subject: WIP: KUDU-1623. Properly handle UPSERTS that only include PK column ..

[kudu-CR] [client] performance optimizations

2016-09-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [client] performance optimizations .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4385/3/src/kudu/client/session-internal.h File src/kudu/clien

[kudu-CR] [client] performance optimizations

2016-09-16 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4385 to look at the new patch set (#4). Change subject: [client] performance optimizations .. [client] performance optim

[kudu-CR] c++ client: use entire deadline when retrying single-master DDL operations

2016-09-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: c++ client: use entire deadline when retrying single-master DDL operations .. Patch Set 2: Verified+1 Spurious failure in ITClient test. -- To view, visit http:/

[kudu-CR] [client] performance optimizations

2016-09-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [client] performance optimizations .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4385/4/src/kudu/client/batcher.cc File src/kudu/client

[kudu-CR] [java-client] address follow-up comments to c7dab4

2016-09-16 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4442 to review the following change. Change subject: [java-client] address follow-up comments to c7dab4 .. [java-client] ad

[kudu-CR] [java-client] address follow-up comments to c7dab4

2016-09-16 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] address follow-up comments to c7dab4 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4442 To unsubscribe, vis

[kudu-CR] [client] performance optimizations

2016-09-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [client] performance optimizations .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4385/4/src/kudu/client/batcher.cc File src/kudu/client/batch

[kudu-CR] KUDU-1623. Properly handle UPSERTS that only include PK column

2016-09-16 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4441 to look at the new patch set (#2). Change subject: KUDU-1623. Properly handle UPSERTS that only include PK column ..

[kudu-CR] KUDU-1135 (part 1): avoid flushing cmeta to disk twice when voting

2016-09-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1135 (part 1): avoid flushing cmeta to disk twice when voting .. Patch Set 1: Verified+1 unrelated flake -- To view, visit http://gerrit.cloudera.o

[kudu-CR] [java-client] address follow-up comments to c7dab4

2016-09-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [java-client] address follow-up comments to c7dab4 .. Patch Set 1: How about this comment? https://gerrit.cloudera.org/#/c/4299/3/java/kudu-client/src/test/java/o

[kudu-CR] make election timeout jitter more aggressive

2016-09-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: make election timeout jitter more aggressive .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3828 To unsubscribe, visit http://ger

[kudu-CR] KUDU-1065: [java client] Flexible Partition Pruning

2016-09-16 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1065: [java client] Flexible Partition Pruning .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/4299/3/java/kudu-client/src/main/java/org/apa

[kudu-CR] Change timestamp printing to ISO-8601 (with microseconds)

2016-09-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Change timestamp printing to ISO-8601 (with microseconds) .. Patch Set 3: Should we be consistent with the Java side? -- To view, visit http://gerrit.cloudera.or

[kudu-CR] KUDU-1623. Properly handle UPSERTS that only include PK column

2016-09-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1623. Properly handle UPSERTS that only include PK column .. Patch Set 2: btw looped fuzz-itest 500 times: http://dist-test.cloudera.org//job?job_id=todd.147

[kudu-CR] [java-client] address follow-up comments to c7dab4

2016-09-16 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: [java-client] address follow-up comments to c7dab4 .. [java-client] address follow-up comments to c7dab4 Change-Id: Id9c071b8c267ed86f74c6d13b49d4c4693fdd

[kudu-CR] csd: also use master address for --rpc bind address

2016-09-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: csd: also use master_address for --rpc_bind_address .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4431/1/java/kudu-csd/src/scripts/kudu.sh File

[kudu-CR] Change timestamp printing to ISO-8601 (with microseconds)

2016-09-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Change timestamp printing to ISO-8601 (with microseconds) .. Patch Set 3: Dan mentioned that it had already done it for java -- To view, visit http://ger

[kudu-CR] Document Impala and Spark integration known issues & limitations

2016-09-16 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Dinesh Bhat, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4443 to review the following change. Change subject: Document Impala and Spark integration known issues & limitations ..

[kudu-CR] make election timeout jitter more aggressive

2016-09-16 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3828 to look at the new patch set (#3). Change subject: make election timeout jitter more aggressive .. mak

[kudu-CR] KUDU-1623. Properly handle UPSERTS that only include PK column

2016-09-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1623. Properly handle UPSERTS that only include PK column .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/4441/2/src/kudu/tablet/key

[kudu-CR] [tools] updated insert-generated-rows tool

2016-09-16 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4412 to look at the new patch set (#4). Change subject: [tools] updated insert-generated-rows tool .. [tools] updated in

[kudu-CR] [client] performance optimizations

2016-09-16 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4385 to look at the new patch set (#5). Change subject: [client] performance optimizations .. [client] performance optim

[kudu-CR] Change timestamp printing to ISO-8601 (with microseconds)

2016-09-16 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Change timestamp printing to ISO-8601 (with microseconds) .. Patch Set 3: Yep, it was changed on the Java side recently. https://github.com/apache/kudu/blob/mast

[kudu-CR] make election timeout jitter more aggressive

2016-09-16 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: make election timeout jitter more aggressive .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3828 To unsubscribe, visit http://ger

[kudu-CR] make election timeout jitter more aggressive

2016-09-16 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: make election timeout jitter more aggressive .. make election timeout jitter more aggressive Random election timeout jitter is necessary in Raft in order

[kudu-CR] [c++client] performance optimizations

2016-09-16 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4385 to look at the new patch set (#6). Change subject: [c++client] performance optimizations .. [c++client] performance

[kudu-CR] [tools] updated insert-generated-rows tool

2016-09-16 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4412 to look at the new patch set (#5). Change subject: [tools] updated insert-generated-rows tool .. [tools] updated in

[kudu-CR] [client-test] faster TestFlushModesCompareOpRates*

2016-09-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [client-test] faster TestFlushModesCompareOpRates* .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4437/1/src/kudu/client/client-test.cc File sr

[kudu-CR] [c++client] performance optimizations

2016-09-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [c++client] performance optimizations .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4385/4/src/kudu/client/batcher.cc File src/kudu/clie

[kudu-CR] [tools] updated insert-generated-rows tool

2016-09-16 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4412 to look at the new patch set (#6). Change subject: [tools] updated insert-generated-rows tool .. [tools] updated in

[kudu-CR] [java-client] repackage to org.apache.kudu (Part 3)

2016-09-16 Thread Dan Burkert (Code Review)
Dan Burkert has abandoned this change. Change subject: [java-client] repackage to org.apache.kudu (Part 3) .. Abandoned This never made it in, and I'm sure it's in rebase hell at this point. -- To view, visit http://gerrit.cl

[kudu-CR] replace boost::detail::yield with std::this thread::yield

2016-09-16 Thread Dan Burkert (Code Review)
Dan Burkert has abandoned this change. Change subject: replace boost::detail::yield with std::this_thread::yield .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/3492 To unsubscribe, visit http://gerrit.cloudera.

[kudu-CR] KUDU-1614 - [python] Enable Set/Get of unixtime micros

2016-09-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1614 - [python] Enable Set/Get of unixtime_micros .. Patch Set 8: Code-Review+1 Leaving a +1 so that Todd can take one last look -- To view, visit h

[kudu-CR] [client-test] faster TestFlushModesCompareOpRates*

2016-09-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [client-test] faster TestFlushModesCompareOpRates* .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4437/1/src/kudu/client/client-test

[kudu-CR] [client-test] faster TestFlushModesCompareOpRates*

2016-09-16 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: [client-test] faster TestFlushModesCompareOpRates* .. [client-test] faster TestFlushModesCompareOpRates* Use smaller mutation buffer size and apply fewer w

[kudu-CR] [tools] updated insert-generated-rows tool

2016-09-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [tools] updated insert-generated-rows tool .. Patch Set 6: (1 comment) Would be nice to see a small integration test that runs the tool against a cluster then ver

[kudu-CR] Change timestamp printing to ISO-8601 (with microseconds)

2016-09-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Change timestamp printing to ISO-8601 (with microseconds) .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/1995 To unsubscribe, vis

[kudu-CR] Change timestamp printing to ISO-8601 (with microseconds)

2016-09-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Change timestamp printing to ISO-8601 (with microseconds) .. Change timestamp printing to ISO-8601 (with microseconds) Dan raised the concern in a

[kudu-CR] [tools] updated insert-generated-rows tool

2016-09-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [tools] updated insert-generated-rows tool .. Patch Set 6: (1 comment) > (1 comment) > > Would be nice to see a small integration test that runs the tool >

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

2016-09-16 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4440 to look at the new patch set (#2). Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list'

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

2016-09-16 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list' .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/4440/1//COMMIT_MSG Commit Message

[kudu-CR] csd: also use master address for --rpc bind address

2016-09-16 Thread Adar Dembo (Code Review)
Adar Dembo has abandoned this change. Change subject: csd: also use master_address for --rpc_bind_address .. Abandoned Todd and I discussed this patch in person. We agreed that it doesn't really make sense for the reason he po

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

2016-09-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list' .. Patch Set 2: (2 comments) Would be nice to get a little coverage of the new path, especially sin

[kudu-CR] [tools] updated insert-generated-rows tool

2016-09-16 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4412 to look at the new patch set (#7). Change subject: [tools] updated insert-generated-rows tool .. [tools] updated in

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

2016-09-16 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list' .. Patch Set 2: (2 comments) > (2 comments) > > Would be nice to get a little coverage of the n

[kudu-CR] cli tool: List all tablets/replica uuids with 'kudu table list'

2016-09-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: cli tool: List all tablets/replica_uuids with 'kudu table list' .. Patch Set 2: > Also on an ortho topic of making the output to machine-readable by > keeping logl

[kudu-CR] [tools] updated insert-generated-rows tool

2016-09-16 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4412 to look at the new patch set (#8). Change subject: [tools] updated insert-generated-rows tool .. [tools] updated in

[kudu-CR] [c++client] performance optimizations

2016-09-16 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4385 to look at the new patch set (#7). Change subject: [c++client] performance optimizations .. [c++client] performance

[kudu-CR] [c++client] performance optimizations

2016-09-16 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4385 to look at the new patch set (#8). Change subject: [c++client] performance optimizations .. [c++client] performance

[kudu-CR] Python - Bump version package to 0.4.0

2016-09-16 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has uploaded a new change for review. http://gerrit.cloudera.org:8080/ Change subject: Python - Bump version package to 0.4.0 .. Python - Bump version package to 0.4.0 There have been additional changes to

[kudu-CR] Python - Bump package version to 0.4.0

2016-09-16 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/ to look at the new patch set (#2). Change subject: Python - Bump package version to 0.4.0 .. Python - Bump package

[kudu-CR] [c++client] performance optimizations

2016-09-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [c++client] performance optimizations .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4385 To unsubscribe, visit http://ge

[kudu-CR] Python - Bump package version to 0.4.0

2016-09-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Python - Bump package version to 0.4.0 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/ To unsubscribe, visit http://g