[kudu-CR] [java client] AsyncKuduClient#delayedSendRpcToTablet should return a Deferred

2016-10-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] AsyncKuduClient#delayedSendRpcToTablet should return a Deferred .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] WIP: KUDU-1365. Add leader pre-elections

2016-10-12 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: KUDU-1365. Add leader pre-elections .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4694/2/src/kudu/consensus/raft_consensus.cc File

[kudu-CR] WIP: KUDU-1365. Add leader pre-elections

2016-10-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: KUDU-1365. Add leader pre-elections .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4694/2/src/kudu/consensus/raft_consensus.cc File

[kudu-CR] add 1.0.1 release notes to prior release notes.adoc

2016-10-12 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4699 to review the following change. Change subject: add 1.0.1 release notes to prior_release_notes.adoc

[kudu-CR] WIP: KUDU-1365. Add leader pre-elections

2016-10-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: KUDU-1365. Add leader pre-elections .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4694/2/src/kudu/consensus/raft_consensus.cc File

[kudu-CR] WIP: KUDU-1365. Add leader pre-elections

2016-10-12 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: KUDU-1365. Add leader pre-elections .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4694/2/src/kudu/consensus/raft_consensus.cc File

[kudu-CR] add 1.0.1 release notes to prior release notes.adoc

2016-10-12 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: add 1.0.1 release notes to prior_release_notes.adoc .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4699 To unsubscribe,

[kudu-CR] KUDU-1365. Add leader pre-elections

2016-10-12 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4694 to look at the new patch set (#3). Change subject: KUDU-1365. Add leader pre-elections .. KUDU-1365. Add leader

[kudu-CR] WIP: KUDU-1365. Add leader pre-elections

2016-10-12 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4694 to review the following change. Change subject: WIP: KUDU-1365. Add leader pre-elections .. WIP:

[kudu-CR] WIP: KUDU-1365. Add leader pre-elections

2016-10-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: KUDU-1365. Add leader pre-elections .. Patch Set 1: submitted an itest x1000 loop here: http://dist-test.cloudera.org//job?job_id=todd.147621.11040 --

[kudu-CR] WIP: KUDU-1365. Add leader pre-elections

2016-10-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: KUDU-1365. Add leader pre-elections .. Patch Set 1: One more TODO item here is that LeaderElectionExpBackoff needs to use a different count for figuring out

[kudu-CR] KUDU-1135 (part 2): avoid flushing metadata twice when starting an election

2016-10-12 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4702 to review the following change. Change subject: KUDU-1135 (part 2): avoid flushing metadata twice when starting an election

[kudu-CR] [c++ client] use default RPC timeout for batchers

2016-10-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [c++ client] use default RPC timeout for batchers .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4703 To unsubscribe, visit

[kudu-CR] [java client] Cleanup AsyncKuduClient's unused caches

2016-10-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java client] Cleanup AsyncKuduClient's unused caches .. Patch Set 2: (2 comments)

[kudu-CR] [c++ client] use default RPC timeout for batchers

2016-10-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [c++ client] use default RPC timeout for batchers .. Patch Set 1: Can we add a new unit test of sorts that pauses a leader and makes sure that a write to that

[kudu-CR] consensus peers: a little cleanup of cruft

2016-10-12 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4704 to review the following change. Change subject: consensus_peers: a little cleanup of cruft ..

[kudu-CR] [java client] Cleanup AsyncKuduClient's unused caches

2016-10-12 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/4705 Change subject: [java client] Cleanup AsyncKuduClient's unused caches .. [java client] Cleanup AsyncKuduClient's unused caches

[kudu-CR] [c++ client] use default RPC timeout for batchers

2016-10-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [c++ client] use default RPC timeout for batchers .. Patch Set 1: > Can we add a new unit test of sorts that pauses a leader and makes > sure that a write to

[kudu-CR] [java client] Cleanup AsyncKuduClient's unused caches

2016-10-12 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new patch set (#2). Change subject: [java client] Cleanup AsyncKuduClient's unused caches .. [java client] Cleanup AsyncKuduClient's unused caches Originally, asynchbase came with a few caches

[kudu-CR] [util] added Subprocess::GetExitStatus()

2016-10-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util] added Subprocess::GetExitStatus() .. Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/4648/7/src/kudu/util/subprocess.cc File

[kudu-CR] [java client] Cleanup AsyncKuduClient's unused caches

2016-10-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Cleanup AsyncKuduClient's unused caches .. Patch Set 2: (2 comments)

[kudu-CR] [util] added Subprocess::GetExitStatus()

2016-10-12 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4648 to look at the new patch set (#10). Change subject: [util] added Subprocess::GetExitStatus() .. [util] added

[kudu-CR] [java client] Cleanup AsyncKuduClient's unused caches

2016-10-12 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4705 to look at the new patch set (#3). Change subject: [java client] Cleanup AsyncKuduClient's unused caches .. [java

[kudu-CR] KUDU-1682. Lock contention on table locations cache in Java client

2016-10-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1682. Lock contention on table locations cache in Java client .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] [c++ client] use default RPC timeout for batchers

2016-10-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [c++ client] use default RPC timeout for batchers .. [c++ client] use default RPC timeout for batchers If not overridden by

[kudu-CR] [c++ client] use default RPC timeout for batchers

2016-10-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/4703 Change subject: [c++ client] use default RPC timeout for batchers .. [c++ client] use default RPC timeout for batchers If not

[kudu-CR] KUDU-1682. Lock contention on table locations cache in Java client

2016-10-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1682. Lock contention on table locations cache in Java client .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] KUDU-1365. Add leader pre-elections

2016-10-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1365. Add leader pre-elections .. Patch Set 3: Code-Review+1 (1 comment) LGTM

[kudu-CR] KUDU-1692: tie various reader memtrackers to the tablet tracker

2016-10-12 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4708 to review the following change. Change subject: KUDU-1692: tie various reader memtrackers to the tablet tracker ..

[kudu-CR] consensus queue: make methods non-virtual

2016-10-12 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4710 to review the following change. Change subject: consensus_queue: make methods non-virtual ..

[kudu-CR] consensus: move more logic from ReplicaState to RaftConsensus

2016-10-12 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4709 to review the following change. Change subject: consensus: move more logic from ReplicaState to RaftConsensus

[kudu-CR] KUDU-1365. Add leader pre-elections

2016-10-12 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4694 to look at the new patch set (#4). Change subject: KUDU-1365. Add leader pre-elections

[kudu-CR] consensus: move ReplicaTransactionFactory into RaftConsensus

2016-10-12 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4711 to review the following change. Change subject: consensus: move ReplicaTransactionFactory into RaftConsensus

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

2016-10-12 Thread Brock Noland (Code Review)
Brock Noland has posted comments on this change. Change subject: KUDU-1563. Add support for INSERT IGNORE .. Patch Set 8: (17 comments) Updated patch should have these items addressed.

[kudu-CR] KUDU-1135 (part 2): avoid flushing metadata twice when starting an election

2016-10-12 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1135 (part 2): avoid flushing metadata twice when starting an election .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4702

[kudu-CR] [util] added Subprocess::GetExitStatus()

2016-10-12 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [util] added Subprocess::GetExitStatus() .. Patch Set 10: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4648 To unsubscribe, visit

[kudu-CR] KUDU-1692: tie various reader memtrackers to the tablet tracker

2016-10-12 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4708 to look at the new patch set (#2). Change subject: KUDU-1692: tie various reader memtrackers to the tablet tracker

[kudu-CR] consensus: remove bits of dead code

2016-10-12 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4712 to review the following change. Change subject: consensus: remove bits of dead code .. consensus:

[kudu-CR] KUDU-1692: tie various reader memtrackers to the tablet tracker

2016-10-12 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4708 to look at the new patch set (#3). Change subject: KUDU-1692: tie various reader memtrackers to the tablet tracker

[kudu-CR] KUDU-1365. Add leader pre-elections

2016-10-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1365. Add leader pre-elections .. Patch Set 4: Seeing one issue here.. with a 3-node config and one down, we can get stuck in this state: peer A: current

[kudu-CR] consensus: split ReplicaState in twain[1]

2016-10-12 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4713 to review the following change. Change subject: consensus: split ReplicaState in twain[1] ..

[kudu-CR] KUDU-1365. Add leader pre-elections

2016-10-12 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1365. Add leader pre-elections .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4694/4/src/kudu/consensus/raft_consensus.cc File